From nobody Sat Jun 20 00:55:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76349C433EF for ; Fri, 25 Mar 2022 03:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353234AbiCYD7f (ORCPT ); Thu, 24 Mar 2022 23:59:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347333AbiCYD7c (ORCPT ); Thu, 24 Mar 2022 23:59:32 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E1FDC55B0 for ; Thu, 24 Mar 2022 20:57:57 -0700 (PDT) Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 5E6B03F19D for ; Fri, 25 Mar 2022 03:57:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1648180674; bh=sBm+dzND20zvV48a+5lKby5znKuzcId45M5VCBIr4Hk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VLLmtYt6o+k0PKfzkW9SWONeLDZryqh0/ZHvob5p4q3G/7Zlg2VhtbUTgj5ZrBCvx QMTRCpAn7gvSR9xAjfjcD6CX37jy1VvYB7FdekeE+un2fMt7a1OGMBzphlkR1vTdO0 +t12SrhkFYvG56U7SZBTTALaLA+Bm6MgbJhVdMRXHXqiEfRpzFkwNgJXo93AANByWa b+YQbrcLJRh2B1bu7eijSV96xvkgeJ2Sd9I1hY1pPM7FBB92gXzbMU94lOwmvqZd32 700iN5j1whoankADdwqbujsmAQ6oCRkgAvbk5hI8JjxySDLeMReGoVci5oeS7brSmg as4cTMEqpQF4w== Received: by mail-pl1-f199.google.com with SMTP id b4-20020a170902e94400b0015309b5c481so3550737pll.6 for ; Thu, 24 Mar 2022 20:57:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sBm+dzND20zvV48a+5lKby5znKuzcId45M5VCBIr4Hk=; b=64wXDkDbIv55bZnIBvnahAgrnZP1BgEBbJAq0V6Q866jY06I0Lj+6wVxXJc2R/YBk2 nzJwK6CzYf/BppUA/EtenLn1YIKPLvK3NN4xaWMciaf0iTP0Qg32i/PrifYe21ZPQfgz iBHy2JXYL/MPSjr7mXWKcAVRVxN+4WZeaR+gvTsSC48RgAUxb9hUzM0cTRPlgd6XSW4z FGWjyUGanm1PlDEIgqxXmOQ+UQA1x9vZ5AKVYfNC8FgP/1YI5uca+xzkEKqHr/KKb0aW F/atEKOvlnBwUHh2RrM6U8/QAtYReYqpvM66dvW5EYevg0VUvu3udhLsPCahwNkqnRqe xnBA== X-Gm-Message-State: AOAM533YxYIOiLy2H4wLmptkL+kY8xemKoUJqE+H7yRXCW1Y/5ejrryT 7jrFMmb5XS8uh1noIpUp30WqgwNgGSoLchGD6VBapS1KGq8waqaWZq20r7N5P1jfmzM3ubdVXAW A316021OLFCGxHiR2yht5QErnRO/cXq1OpgzZYwgVZQ== X-Received: by 2002:a05:6a00:234f:b0:4fa:f52b:46a1 with SMTP id j15-20020a056a00234f00b004faf52b46a1mr5114519pfj.32.1648180672961; Thu, 24 Mar 2022 20:57:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/IuahQpQ0LUgvUGC1C+LbOiyBqHg4NscrDf4ccSD492uSz6kUcrRNBVv3Md3kTWuzNsvIGw== X-Received: by 2002:a05:6a00:234f:b0:4fa:f52b:46a1 with SMTP id j15-20020a056a00234f00b004faf52b46a1mr5114500pfj.32.1648180672642; Thu, 24 Mar 2022 20:57:52 -0700 (PDT) Received: from localhost.localdomain (2001-b400-e286-bae1-8fdb-11c6-cf63-1f23.emome-ip6.hinet.net. [2001:b400:e286:bae1:8fdb:11c6:cf63:1f23]) by smtp.gmail.com with ESMTPSA id 21-20020a630115000000b00382a0895661sm3825801pgb.11.2022.03.24.20.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 20:57:52 -0700 (PDT) From: Chris Chiu To: kvalo@kernel.org, Jes.Sorensen@gmail.com, davem@davemloft.net, kuba@kernel.org Cc: code@reto-schneider.ch, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Chiu Subject: [PATCH v3 1/2] rtl8xxxu: feed antenna information for cfg80211 Date: Fri, 25 Mar 2022 11:57:34 +0800 Message-Id: <20220325035735.4745-2-chris.chiu@canonical.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220325035735.4745-1-chris.chiu@canonical.com> References: <20220325035735.4745-1-chris.chiu@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fill up the available TX/RX antenna so the iw commands can show correct antenna information for different chips. Signed-off-by: Chris Chiu --- .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/driver= s/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 06d59ffb7444..d225a1257530 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -1607,6 +1607,7 @@ static void rtl8xxxu_print_chipinfo(struct rtl8xxxu_p= riv *priv) static int rtl8xxxu_identify_chip(struct rtl8xxxu_priv *priv) { struct device *dev =3D &priv->udev->dev; + struct ieee80211_hw *hw =3D priv->hw; u32 val32, bonding; u16 val16; =20 @@ -1684,6 +1685,9 @@ static int rtl8xxxu_identify_chip(struct rtl8xxxu_pri= v *priv) priv->has_wifi =3D 1; } =20 + hw->wiphy->available_antennas_tx =3D BIT(priv->tx_paths) - 1; + hw->wiphy->available_antennas_rx =3D BIT(priv->rx_paths) - 1; + switch (priv->rtl_chip) { case RTL8188E: case RTL8192E: @@ -4282,6 +4286,17 @@ static void rtl8xxxu_cam_write(struct rtl8xxxu_priv = *priv, rtl8xxxu_debug =3D tmp_debug; } =20 +static +int rtl8xxxu_get_antenna(struct ieee80211_hw *hw, u32 *tx_ant, u32 *rx_ant) +{ + struct rtl8xxxu_priv *priv =3D hw->priv; + + *tx_ant =3D BIT(priv->tx_paths) - 1; + *rx_ant =3D BIT(priv->rx_paths) - 1; + + return 0; +} + static void rtl8xxxu_sw_scan_start(struct ieee80211_hw *hw, struct ieee80211_vif *vif, const u8 *mac) { @@ -6472,6 +6487,7 @@ static const struct ieee80211_ops rtl8xxxu_ops =3D { .set_key =3D rtl8xxxu_set_key, .ampdu_action =3D rtl8xxxu_ampdu_action, .sta_statistics =3D rtl8xxxu_sta_statistics, + .get_antenna =3D rtl8xxxu_get_antenna, }; =20 static int rtl8xxxu_parse_usb(struct rtl8xxxu_priv *priv, --=20 2.25.1 From nobody Sat Jun 20 00:55:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6445C433EF for ; Fri, 25 Mar 2022 03:58:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356782AbiCYD7p (ORCPT ); Thu, 24 Mar 2022 23:59:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355628AbiCYD7e (ORCPT ); Thu, 24 Mar 2022 23:59:34 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB23CC55B2 for ; Thu, 24 Mar 2022 20:57:59 -0700 (PDT) Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id A66AD3F6C6 for ; Fri, 25 Mar 2022 03:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1648180678; bh=HfhFiSazR5AEpCcSLsKBFtyKGjNGuMH/2Hmmg2fcF54=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=K6eNxOXWTVIg1lw+cpr92g//f2Q779mTD5JEEsvwY9SUVR8JHb05bpnCmE+ILJrnI sPMuMKorrqqliTp0zwNtHOFFYJ67ZZzKYCAXXcwk0Na3o6XhPykht34HCzDG5YWtC8 2GjE29fTSveDao3/kNt3UfzLLwt9WduNCnXy6DQw26jpb5fmJVbbVvF/OI1OPodRlD udCEyqJf72/ZcL0JewGk7Ppy0gqHg/oGbmE6lbrYRQEpJjP42/2PW59l2E0c8KuLFN lA1sf9GFLSbzEYLPUX/YdtDgH8AuT9E9aTQhG3oGMujt2lqhZV5kizecxqElCJejwO C752XSwPyN45w== Received: by mail-pl1-f198.google.com with SMTP id j6-20020a170902c08600b0015442fe6256so3534689pld.23 for ; Thu, 24 Mar 2022 20:57:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HfhFiSazR5AEpCcSLsKBFtyKGjNGuMH/2Hmmg2fcF54=; b=CMFwnqMdS3FNuAmPVacGZ2PTt1i8J9xZ0ts6JCq/dmFnVA1RbTexWQwCYFzZMIOFRs boUamQX/4OIJZTUPcIZuc68qMZNyPnLHHYN+iYpcXbOjnsBw8C0081Yn01CRM0jrY90I HilbkU7gKwVoDCdaMpN2hpZEvtlMxAm2nc8GO9yMzc1jETncjwS4Gqloa7aqGmkpfoVw 5Y58I/jvizQsuC4xm6lEG7LEH8ojAcjfuFKD2rrSnIKZWAwxcD4DEe0WIPcZfjU7Xujc 5+wfk2HWjSaNM5jOWfUDxfTYmOhwYA/wh6s8lYtvgfvClyKMD5r7wgi/1oSjvd08hnpX 80SA== X-Gm-Message-State: AOAM532q+nQcdQQU8zqUgzPezYs+X4p8N8eOdahoV/3n6fTyIFmhT5ST GXK/YXy8qrNWisjqXtVJmYCisLwNFCf9q+bXd4ZVJPgTh67CnQ7P1G0k7xaH4ZgwYWq6R1658Kw nEXS9WwRFWQv4NAxEb/7atFM2QRtXz9IuAHS8c7Snfw== X-Received: by 2002:a63:1e4b:0:b0:381:c48:928b with SMTP id p11-20020a631e4b000000b003810c48928bmr6225535pgm.139.1648180677214; Thu, 24 Mar 2022 20:57:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFFS803gF+q2mgNAsgGNpiwAvXpqSXWcGhWvjVXchMZL//AWHsQKx3HdQP/D0kn2Ktzy9xXg== X-Received: by 2002:a63:1e4b:0:b0:381:c48:928b with SMTP id p11-20020a631e4b000000b003810c48928bmr6225515pgm.139.1648180676853; Thu, 24 Mar 2022 20:57:56 -0700 (PDT) Received: from localhost.localdomain (2001-b400-e286-bae1-8fdb-11c6-cf63-1f23.emome-ip6.hinet.net. [2001:b400:e286:bae1:8fdb:11c6:cf63:1f23]) by smtp.gmail.com with ESMTPSA id 21-20020a630115000000b00382a0895661sm3825801pgb.11.2022.03.24.20.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 20:57:56 -0700 (PDT) From: Chris Chiu To: kvalo@kernel.org, Jes.Sorensen@gmail.com, davem@davemloft.net, kuba@kernel.org Cc: code@reto-schneider.ch, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Chiu Subject: [PATCH v3 2/2] rtl8xxxu: fill up txrate info for gen1 chips Date: Fri, 25 Mar 2022 11:57:35 +0800 Message-Id: <20220325035735.4745-3-chris.chiu@canonical.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220325035735.4745-1-chris.chiu@canonical.com> References: <20220325035735.4745-1-chris.chiu@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" RTL8188CUS/RTL8192CU(gen1) don't support rate adatptive report hence no real txrate info can be retrieved. The vendor driver reports the highest rate in HT capabilities from the IEs to avoid empty txrate. This commit initiates the txrate information with the highest supported rate negotiated with AP. The gen2 chip keeps update the txrate from the rate adaptive reports, and gen1 chips at least have non-NULL txrate after associated. Signed-off-by: Chris Chiu --- Changelog: v3: - Move the rtl8xxxu_legacy_ratetable[] and rtl8xxxu_desc_to_mcsrate() to the proper place instead of adding them =20 v2: - Use the 'static const' for rtl8xxxu_legacy_ratetable[] .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 88 +++++++++++++------ 1 file changed, 59 insertions(+), 29 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/driver= s/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index d225a1257530..6d9b5cf01b11 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -4473,6 +4473,35 @@ void rtl8xxxu_gen1_init_aggregation(struct rtl8xxxu_= priv *priv) priv->rx_buf_aggregation =3D 1; } =20 +static const struct ieee80211_rate rtl8xxxu_legacy_ratetable[] =3D { + {.bitrate =3D 10, .hw_value =3D 0x00,}, + {.bitrate =3D 20, .hw_value =3D 0x01,}, + {.bitrate =3D 55, .hw_value =3D 0x02,}, + {.bitrate =3D 110, .hw_value =3D 0x03,}, + {.bitrate =3D 60, .hw_value =3D 0x04,}, + {.bitrate =3D 90, .hw_value =3D 0x05,}, + {.bitrate =3D 120, .hw_value =3D 0x06,}, + {.bitrate =3D 180, .hw_value =3D 0x07,}, + {.bitrate =3D 240, .hw_value =3D 0x08,}, + {.bitrate =3D 360, .hw_value =3D 0x09,}, + {.bitrate =3D 480, .hw_value =3D 0x0a,}, + {.bitrate =3D 540, .hw_value =3D 0x0b,}, +}; + +static void rtl8xxxu_desc_to_mcsrate(u16 rate, u8 *mcs, u8 *nss) +{ + if (rate <=3D DESC_RATE_54M) + return; + + if (rate >=3D DESC_RATE_MCS0 && rate <=3D DESC_RATE_MCS15) { + if (rate < DESC_RATE_MCS8) + *nss =3D 1; + else + *nss =3D 2; + *mcs =3D rate - DESC_RATE_MCS0; + } +} + static void rtl8xxxu_set_basic_rates(struct rtl8xxxu_priv *priv, u32 rate_= cfg) { struct ieee80211_hw *hw =3D priv->hw; @@ -4534,9 +4563,12 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, s= truct ieee80211_vif *vif, struct rtl8xxxu_priv *priv =3D hw->priv; struct device *dev =3D &priv->udev->dev; struct ieee80211_sta *sta; + struct rtl8xxxu_ra_report *rarpt; u32 val32; u8 val8; =20 + rarpt =3D &priv->ra_report; + if (changed & BSS_CHANGED_ASSOC) { dev_dbg(dev, "Changed ASSOC: %i!\n", bss_conf->assoc); =20 @@ -4545,6 +4577,10 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, s= truct ieee80211_vif *vif, if (bss_conf->assoc) { u32 ramask; int sgi =3D 0; + u8 highest_rate; + u8 mcs =3D 0, nss =3D 0; + u32 bit_rate; + =20 rcu_read_lock(); sta =3D ieee80211_find_sta(vif, bss_conf->bssid); @@ -4569,6 +4605,29 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, s= truct ieee80211_vif *vif, sgi =3D 1; rcu_read_unlock(); =20 + highest_rate =3D fls(ramask) - 1; + if (highest_rate < DESC_RATE_MCS0) { + rarpt->txrate.legacy =3D + rtl8xxxu_legacy_ratetable[highest_rate].bitrate; + } else { + rtl8xxxu_desc_to_mcsrate(highest_rate, + &mcs, &nss); + rarpt->txrate.flags |=3D RATE_INFO_FLAGS_MCS; + + rarpt->txrate.mcs =3D mcs; + rarpt->txrate.nss =3D nss; + + if (sgi) { + rarpt->txrate.flags |=3D + RATE_INFO_FLAGS_SHORT_GI; + } + + rarpt->txrate.bw |=3D RATE_INFO_BW_20; + } + bit_rate =3D cfg80211_calculate_bitrate(&rarpt->txrate); + rarpt->bit_rate =3D bit_rate; + rarpt->desc_rate =3D highest_rate; + priv->vif =3D vif; priv->rssi_level =3D RTL8XXXU_RATR_STA_INIT; =20 @@ -5419,35 +5478,6 @@ void rtl8723bu_handle_bt_info(struct rtl8xxxu_priv *= priv) } } =20 -static struct ieee80211_rate rtl8xxxu_legacy_ratetable[] =3D { - {.bitrate =3D 10, .hw_value =3D 0x00,}, - {.bitrate =3D 20, .hw_value =3D 0x01,}, - {.bitrate =3D 55, .hw_value =3D 0x02,}, - {.bitrate =3D 110, .hw_value =3D 0x03,}, - {.bitrate =3D 60, .hw_value =3D 0x04,}, - {.bitrate =3D 90, .hw_value =3D 0x05,}, - {.bitrate =3D 120, .hw_value =3D 0x06,}, - {.bitrate =3D 180, .hw_value =3D 0x07,}, - {.bitrate =3D 240, .hw_value =3D 0x08,}, - {.bitrate =3D 360, .hw_value =3D 0x09,}, - {.bitrate =3D 480, .hw_value =3D 0x0a,}, - {.bitrate =3D 540, .hw_value =3D 0x0b,}, -}; - -static void rtl8xxxu_desc_to_mcsrate(u16 rate, u8 *mcs, u8 *nss) -{ - if (rate <=3D DESC_RATE_54M) - return; - - if (rate >=3D DESC_RATE_MCS0 && rate <=3D DESC_RATE_MCS15) { - if (rate < DESC_RATE_MCS8) - *nss =3D 1; - else - *nss =3D 2; - *mcs =3D rate - DESC_RATE_MCS0; - } -} - static void rtl8xxxu_c2hcmd_callback(struct work_struct *work) { struct rtl8xxxu_priv *priv; --=20 2.25.1