From nobody Sat Jun 20 01:52:44 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E78C433F5 for ; Thu, 24 Mar 2022 07:20:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348469AbiCXHWW (ORCPT ); Thu, 24 Mar 2022 03:22:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbiCXHWQ (ORCPT ); Thu, 24 Mar 2022 03:22:16 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D6B85A09F; Thu, 24 Mar 2022 00:20:44 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id qa43so7265361ejc.12; Thu, 24 Mar 2022 00:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OZ30SALDCdF6ve1jmx8o4UeGTC9W1dlBNNl9mV+QfPY=; b=d9eKEqeBGQjuStvECA/Izr927dwj0JKnWImmODXq196m7snXz/5gmKmzjlyLT7PP++ gZ0E5eA2KjHlqmgyA2u+VfOx38B6rl8G8Fxj8TEfMXGTQDL2ohIHGdX3bKESfod/sBdz Q6uA7IWNYGi765VMr4JopZUUf4RaxrnfZBi9zIrChfYIxBT3CSe742dMXej+BvUSB2xh sloc/H71kMmQqn24YX7kZgpO0wKoM501xH2Xk8nsKYp30iNoP3oFahrC2po9lUEX7AuL z4kddmMVY3upaYkbnLmcM1C5Uxdql5HYc5yVsjsgNBKAlNBhvmJ5jefo0f1NmpsRHNHY 371Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OZ30SALDCdF6ve1jmx8o4UeGTC9W1dlBNNl9mV+QfPY=; b=MB+cfmBgxqVUk1ZK06NbSv0cPk0ikwQaTk4GsRoj2AR4RIFWVA2XUU972ndNVyw5pe PM7zsKDoOEwyKtDw0jROk0Rie6gvcLnzrth20R4LvA5zEOJg9MWGg0iHJNyX8WyNNZp6 ZmeLWkKHtXmW0ZarDG7CMvpqtxtfpR9qBZzubB1vQ1A5VomgkQCGS/UQgxmHjW3NjfdG DbYnFODzq11db+ozOWThBJBoI4uxTyNPNZy7Mk6QdRdZbZOfhBGO3aP1JPt5KuwBMULL AS+OLEBYe0xJOpsHW8d7zV+9uvJ5mBpuOcrzvC+NOh/nfW9ucrnFPrHrmxptau7ZVUB9 FrJQ== X-Gm-Message-State: AOAM532uuAtmYYRDSOkrenR4HcLkYqjL7WofmBKrX2OuGOKklXbwrgqn jyGqJHkLozeD41enKZmlJek= X-Google-Smtp-Source: ABdhPJx3JQ8gNE82asV1UbXAVUZNjIRCfJZ5V6bEHEK69fbvEF3AxeZ/p3Xr/hj8zaWnmwA/hKvHqg== X-Received: by 2002:a17:906:174f:b0:6d0:5629:e4be with SMTP id d15-20020a170906174f00b006d05629e4bemr4152151eje.525.1648106439694; Thu, 24 Mar 2022 00:20:39 -0700 (PDT) Received: from localhost.localdomain (i130160.upc-i.chello.nl. [62.195.130.160]) by smtp.googlemail.com with ESMTPSA id l4-20020aa7c304000000b004192b7825a2sm956913edq.12.2022.03.24.00.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 00:20:39 -0700 (PDT) From: Jakob Koschel To: Hans de Goede Cc: Mark Gross , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport , "Brian Johannesmeyer" , Cristiano Giuffrida , "Bos, H.J." , Jakob Koschel Subject: [PATCH] platform/x86: wmi: replace usage of found with dedicated list iterator variable Date: Thu, 24 Mar 2022 08:20:15 +0100 Message-Id: <20220324072015.62063-1-jakobkoschel@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" To move the list iterator variable into the list_for_each_entry_*() macro in the future it should be avoided to use the list iterator variable after the loop body. To *never* use the list iterator variable after the loop it was concluded to use a separate iterator variable instead of a found boolean [1]. This removes the need to use a found variable and simply checking if the variable was set, can determine if the break/goto was hit. Link: https://lore.kernel.org/all/CAHk-=3DwgRr_D8CB-D9Kg-c=3DEHreAsk5SqXPwr= 9Y7k9sA6cWXJ6w@mail.gmail.com/ Signed-off-by: Jakob Koschel --- drivers/platform/x86/wmi.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 58a23a9adbef..aed293b5af81 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -1308,21 +1308,20 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physic= al_address address, static void acpi_wmi_notify_handler(acpi_handle handle, u32 event, void *context) { - struct wmi_block *wblock; - bool found_it =3D false; + struct wmi_block *wblock =3D NULL, *iter; =20 - list_for_each_entry(wblock, &wmi_block_list, list) { - struct guid_block *block =3D &wblock->gblock; + list_for_each_entry(iter, &wmi_block_list, list) { + struct guid_block *block =3D &iter->gblock; =20 - if (wblock->acpi_device->handle =3D=3D handle && + if (iter->acpi_device->handle =3D=3D handle && (block->flags & ACPI_WMI_EVENT) && (block->notify_id =3D=3D event)) { - found_it =3D true; + wblock =3D iter; break; } } =20 - if (!found_it) + if (!wblock) return; =20 /* If a driver is bound, then notify the driver. */ base-commit: f443e374ae131c168a065ea1748feac6b2e76613 --=20 2.25.1