From nobody Mon Jun 22 15:23:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B537C433EF for ; Tue, 22 Mar 2022 06:22:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236967AbiCVGXe (ORCPT ); Tue, 22 Mar 2022 02:23:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236917AbiCVGX3 (ORCPT ); Tue, 22 Mar 2022 02:23:29 -0400 Received: from out30-56.freemail.mail.aliyun.com (out30-56.freemail.mail.aliyun.com [115.124.30.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF51D1138; Mon, 21 Mar 2022 23:22:00 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R901e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0V7uWHBg_1647930110; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0V7uWHBg_1647930110) by smtp.aliyun-inc.com(127.0.0.1); Tue, 22 Mar 2022 14:21:57 +0800 From: Jiapeng Chong To: rostedt@goodmis.org Cc: mingo@redhat.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, davem@davemloft.net, kuba@kernel.org, hawk@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] bpf: Use swap() instead of open coding it Date: Tue, 22 Mar 2022 14:21:49 +0800 Message-Id: <20220322062149.109180-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Clean the following coccicheck warning: ./kernel/trace/bpf_trace.c:2263:34-35: WARNING opportunity for swap(). ./kernel/trace/bpf_trace.c:2264:40-41: WARNING opportunity for swap(). Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- kernel/trace/bpf_trace.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 0009104dca82..36e0f459d152 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -2253,15 +2253,13 @@ static void bpf_kprobe_multi_cookie_swap(void *a, v= oid *b, int size, const void const struct bpf_kprobe_multi_link *link =3D priv; unsigned long *addr_a =3D a, *addr_b =3D b; u64 *cookie_a, *cookie_b; - unsigned long tmp1; - u64 tmp2; =20 cookie_a =3D link->cookies + (addr_a - link->addrs); cookie_b =3D link->cookies + (addr_b - link->addrs); =20 /* swap addr_a/addr_b and cookie_a/cookie_b values */ - tmp1 =3D *addr_a; *addr_a =3D *addr_b; *addr_b =3D tmp1; - tmp2 =3D *cookie_a; *cookie_a =3D *cookie_b; *cookie_b =3D tmp2; + swap(*addr_a, *addr_b); + swap(*cookie_a, *cookie_b); } =20 static int __bpf_kprobe_multi_cookie_cmp(const void *a, const void *b) --=20 2.20.1.7.g153144c