From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FEEFC4332F for ; Mon, 21 Mar 2022 20:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352931AbiCUUJa (ORCPT ); Mon, 21 Mar 2022 16:09:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352910AbiCUUJU (ORCPT ); Mon, 21 Mar 2022 16:09:20 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C5EC103BB8 for ; Mon, 21 Mar 2022 13:07:51 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id a1so20845274wrh.10 for ; Mon, 21 Mar 2022 13:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B4Tf8ps8Giknxs7LQki4ZGeia2acPTQFjucag6hcCiQ=; b=a5sdYH/JpduGpHD1tJRBR8er5IEbsClNfH4hgpWRK5s0+TXOINVNN1DNWc4QM5y0cz JH6/NV5PqdZ1ky07vprQy7CVZz+/Wq35BT81QdG6z3kTRWl/mFF1tbvyb5U5lkph+rGa DCznuSr+wpfwfCTRtEYMSF2uJFLVckT2GtBapFEGR7cMQ4FAVNxhnxjfandRUP94E43J TV6jkc64qtNCwBd2Abay8L3GUGgych7CpLkh7HYaLRkGBNxZvnIV6VTRYD7vqxSMB/RB vPUIqL/+XVdFYhuz4BxNljahR/VYlwTEWvz5zvoWvB+uNrG1o4EIiKWX8nCrUBtNRBj1 FqcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B4Tf8ps8Giknxs7LQki4ZGeia2acPTQFjucag6hcCiQ=; b=jvGAvujfDFMpWVUupjB8k6YyB/65Da+QCuCo1NfakTRK+kcst1bWYIp8OLq98hJ9/y yjMPfU/ZhnqlzJnJodiBNBwGGn95KJshi6L5GIS4qmC97PTPetKQvpxmYnowO1ADIQJL okQgffEbCcDFR6b2/PLi+nLMWwthFNhgyE8LMnMhUdYsmER0Jk8UdHub1iVibxzWg00P hLAdvYBDK390cHpZsCn5/b4t5kFWlAqEOlPe3C4HUX7SEzYuI3x/iZ+Cq3on4YZorkej xMyUnxQDAcvWzIOCihhjMWl/zn+csAkJ5lhzoGPf/eSUY5UZZFJ21OVMLNFhNz6UMtoZ UsfQ== X-Gm-Message-State: AOAM531nRHG7S63C69mIZrfhS+pmNAGyrWToPFKa1SLhySO3Td+8G2Pw th1r8+7wddTkreWSCrDozHNaog== X-Google-Smtp-Source: ABdhPJwYTWhzkN17VaZNGiC+QJK17xaCo3Z3qvpMMvQ6vPT24W5CB9Yg+9XGiJtSQblUoHYogJ4VkQ== X-Received: by 2002:adf:df8c:0:b0:203:e4f3:920 with SMTP id z12-20020adfdf8c000000b00203e4f30920mr19304734wrl.461.1647893269753; Mon, 21 Mar 2022 13:07:49 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:07:49 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 01/26] crypto: rockchip: use dev_err for error message about interrupt Date: Mon, 21 Mar 2022 20:07:14 +0000 Message-Id: <20220321200739.3572792-2-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Interrupt is mandatory so the message should be printed as error. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index 35d73061d156..45cc5f766788 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -371,8 +371,7 @@ static int rk_crypto_probe(struct platform_device *pdev) =20 crypto_info->irq =3D platform_get_irq(pdev, 0); if (crypto_info->irq < 0) { - dev_warn(crypto_info->dev, - "control Interrupt is not available.\n"); + dev_err(&pdev->dev, "control Interrupt is not available.\n"); err =3D crypto_info->irq; goto err_crypto; } --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BDB1C433EF for ; Mon, 21 Mar 2022 20:08:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352937AbiCUUJd (ORCPT ); Mon, 21 Mar 2022 16:09:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352911AbiCUUJU (ORCPT ); Mon, 21 Mar 2022 16:09:20 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE83A103BBC for ; Mon, 21 Mar 2022 13:07:51 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id h23so21607858wrb.8 for ; Mon, 21 Mar 2022 13:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5/nH1g76OJr2xP0kEzxoO9d69o0mEYaKTMfwjCEna4k=; b=wpn2+3RRnKkURh7Cw42HtJCAMkGca4Slv7C6iuakbwLvTEXnNMZzVN751genrV/kWo iNcZG0du3r5XDwFHWSd8w7O00LHqepu20bQcqsweCcvcYBhGDae5z/Xdr241Qj2lGmhq kxDrXL1VHXyXj1f+MMtaEdWsHpDq43C4aIMqGefVUKLoxEtmTQn37vtUIQXvdjTKowFA m5DDXmT8VT0KQYHblOsC+briTj5e840IrbzIHWDHk5xnvZjOYfHZPRBha9ZcI1vFDl5V h0FOj9A6OR0AhE6Wh2Jt/fMphE1zTO6OUlvAZ+7AcUM3Y6oM7Z5xJ9zA++vv4HSW8bPW 4yVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5/nH1g76OJr2xP0kEzxoO9d69o0mEYaKTMfwjCEna4k=; b=AYmlDIf5YFv+tNF7l8yxLinsf1u4My+LAlwDrdKhmGzMsednJEsg9YLsR3GNyKKAu5 l4J5txP7LPYowJEEVv+TJxQL5qMoTIfxyx1/h2atT8a1QQNIUEhIQRJvRtwcoXAo34XR KNLbFL00VybjCYg5C7Pq0ALPtVSQp84ajU4ySHivgOeFoo2B2krPCfDVG3dzLqtEOS1D QpzbjHIX/lYAgKiITtGDl23uRisYqL1/ga0pDa6FiHsa+D6BpxtrjJPMe1Wh4IyZPZyf JdHySpr7dgRpD7tykRTKOiM9O+KkW0n+CW/c9hsbqwocmMJxI1tLqHG48YGjLB4VPgDe p0CQ== X-Gm-Message-State: AOAM533l7WXFhYmGlEb+yOhgAt9A+5m6Hzc1Uiu2H6VNS5HNW2616vqd bp0FXkbwhkaQanYriRs0fUbNNQ== X-Google-Smtp-Source: ABdhPJyclLZRRx/ILXop0mbVpOT4zhXti8FhJnghzlEFGMiCmx9/J4a7ey9jKBPCbiZ3XOVMesKP5w== X-Received: by 2002:a5d:6746:0:b0:203:d6c1:9c5b with SMTP id l6-20020a5d6746000000b00203d6c19c5bmr19647521wrw.446.1647893270523; Mon, 21 Mar 2022 13:07:50 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:07:50 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 02/26] crypto: rockchip: do not use uninit variable Date: Mon, 21 Mar 2022 20:07:15 +0000 Message-Id: <20220321200739.3572792-3-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" crypto_info->dev is not yet set, so use pdev-dev instead. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index 45cc5f766788..21d3f1458584 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -381,7 +381,7 @@ static int rk_crypto_probe(struct platform_device *pdev) "rk-crypto", pdev); =20 if (err) { - dev_err(crypto_info->dev, "irq request failed.\n"); + dev_err(&pdev->dev, "irq request failed.\n"); goto err_crypto; } =20 --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0496BC4332F for ; Mon, 21 Mar 2022 20:08:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352989AbiCUUJl (ORCPT ); Mon, 21 Mar 2022 16:09:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352917AbiCUUJV (ORCPT ); Mon, 21 Mar 2022 16:09:21 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECADC103DB6 for ; Mon, 21 Mar 2022 13:07:52 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id l7-20020a05600c1d0700b0038c99618859so232837wms.2 for ; Mon, 21 Mar 2022 13:07:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mCxawyPN6KRYTDCClsWI1h6jdnBe5QeH3y4o4F1jrpo=; b=1rrs45jT231Z20PbD3V9/18Hr0tDnLuxWTICMBQhSkdq4EEdAEJKS0xF1IzppKNdlt edos0zZHekmuZS39WBkaUc0Am6LmuSSNTzOVT0JPNn40MZU3EE+1lRZHap0kN/KFFDyw 2zPl1cx+a8sewKkfHX5UJ/ikI5M9pdhSWtvTvVTVwaPBuMtFUs7vqi2OMSpRuZ5mvd9X hSkQ74qKjq2mxtPHNs20mHchkByaspZs3CVfdTpO1ja8G5LLTu24jdSGJwEd4eRR4fcS k7qGOJKGGShZ+4lP0OvqkmTI3eJzlhCv3Ymt62cSjr6iq0ikEmuVEnlJetehlLEUqBuR Cxsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mCxawyPN6KRYTDCClsWI1h6jdnBe5QeH3y4o4F1jrpo=; b=Ea4hT3PxYgMBJq1Yyw99GKUeXzLiC1Oxh1zuDPkP08qcXs18q//SIxrKIyKplsEkYd 2A4UPfsNLdW8JWqRb7b8qCHTPxF2FOnJs3W2fLE+kyZ2Yn/CHn02UTOu/CDIqcpQJNrF PucekO1FnIoUAcAIz0XeN7785Bhxu80G23g2R4SxGFjxchWoN/vMbjENihkafMuGBtx8 BTI1w4rVM+bLkS8oHLbhxE3f2KMAkyNNZFK7WTQ/0biyVCyZ344AD9cpZqGJFjWEEysV bd+HUjrcktf40rZZ6hPrFP1CJhc40DNl+8Haa49Uhf/BwWNUKlLuev5NzJS5ubkDFDWI U33Q== X-Gm-Message-State: AOAM530j51C+cY4wDvmQPFS/9aeal14FnNx8B7WjRQQzDMAgsMxfLn61 7Z91spUtW8L3rGECn4U9wdcfZQ== X-Google-Smtp-Source: ABdhPJzLc/odetDBVs6vFd2ZQkPkGqJ1aW2JmcN60MgGQkKZg3XXFbSoqr149pfQH+j55WI2l9q2rw== X-Received: by 2002:a7b:c017:0:b0:38c:8a13:466d with SMTP id c23-20020a7bc017000000b0038c8a13466dmr697433wmb.128.1647893271431; Mon, 21 Mar 2022 13:07:51 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:07:51 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 03/26] crypto: rockchip: do not do custom power management Date: Mon, 21 Mar 2022 20:07:16 +0000 Message-Id: <20220321200739.3572792-4-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The clock enable/disable at tfm init/exit is fragile, if 2 tfm are init in the same time and one is removed just after, it will leave the hardware uncloked even if a user remains. Instead simply enable clocks at probe time. We will do PM later. Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 4 ++-- drivers/crypto/rockchip/rk3288_crypto.h | 2 -- drivers/crypto/rockchip/rk3288_crypto_ahash.c | 3 +-- drivers/crypto/rockchip/rk3288_crypto_skcipher.c | 5 +++-- 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index 21d3f1458584..4cff49b82983 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -394,8 +394,7 @@ static int rk_crypto_probe(struct platform_device *pdev) rk_crypto_done_task_cb, (unsigned long)crypto_info); crypto_init_queue(&crypto_info->queue, 50); =20 - crypto_info->enable_clk =3D rk_crypto_enable_clk; - crypto_info->disable_clk =3D rk_crypto_disable_clk; + rk_crypto_enable_clk(crypto_info); crypto_info->load_data =3D rk_load_data; crypto_info->unload_data =3D rk_unload_data; crypto_info->enqueue =3D rk_crypto_enqueue; @@ -422,6 +421,7 @@ static int rk_crypto_remove(struct platform_device *pde= v) struct rk_crypto_info *crypto_tmp =3D platform_get_drvdata(pdev); =20 rk_crypto_unregister(); + rk_crypto_disable_clk(crypto_tmp); tasklet_kill(&crypto_tmp->done_task); tasklet_kill(&crypto_tmp->queue_task); return 0; diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockc= hip/rk3288_crypto.h index 97278c2574ff..2fa7131e4060 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.h +++ b/drivers/crypto/rockchip/rk3288_crypto.h @@ -220,8 +220,6 @@ struct rk_crypto_info { int (*start)(struct rk_crypto_info *dev); int (*update)(struct rk_crypto_info *dev); void (*complete)(struct crypto_async_request *base, int err); - int (*enable_clk)(struct rk_crypto_info *dev); - void (*disable_clk)(struct rk_crypto_info *dev); int (*load_data)(struct rk_crypto_info *dev, struct scatterlist *sg_src, struct scatterlist *sg_dst); diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto= /rockchip/rk3288_crypto_ahash.c index ed03058497bc..49017d1fb510 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c @@ -301,7 +301,7 @@ static int rk_cra_hash_init(struct crypto_tfm *tfm) sizeof(struct rk_ahash_rctx) + crypto_ahash_reqsize(tctx->fallback_tfm)); =20 - return tctx->dev->enable_clk(tctx->dev); + return 0; } =20 static void rk_cra_hash_exit(struct crypto_tfm *tfm) @@ -309,7 +309,6 @@ static void rk_cra_hash_exit(struct crypto_tfm *tfm) struct rk_ahash_ctx *tctx =3D crypto_tfm_ctx(tfm); =20 free_page((unsigned long)tctx->dev->addr_vir); - return tctx->dev->disable_clk(tctx->dev); } =20 struct rk_crypto_tmp rk_ahash_sha1 =3D { diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/cry= pto/rockchip/rk3288_crypto_skcipher.c index 5bbf0d2722e1..8c44a19eab75 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c +++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c @@ -388,8 +388,10 @@ static int rk_ablk_init_tfm(struct crypto_skcipher *tf= m) ctx->dev->update =3D rk_ablk_rx; ctx->dev->complete =3D rk_crypto_complete; ctx->dev->addr_vir =3D (char *)__get_free_page(GFP_KERNEL); + if (!ctx->dev->addr_vir) + return -ENOMEM; =20 - return ctx->dev->addr_vir ? ctx->dev->enable_clk(ctx->dev) : -ENOMEM; + return 0; } =20 static void rk_ablk_exit_tfm(struct crypto_skcipher *tfm) @@ -397,7 +399,6 @@ static void rk_ablk_exit_tfm(struct crypto_skcipher *tf= m) struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 free_page((unsigned long)ctx->dev->addr_vir); - ctx->dev->disable_clk(ctx->dev); } =20 struct rk_crypto_tmp rk_ecb_aes_alg =3D { --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E0DC43217 for ; Mon, 21 Mar 2022 20:08:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352963AbiCUUJo (ORCPT ); Mon, 21 Mar 2022 16:09:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352926AbiCUUJZ (ORCPT ); Mon, 21 Mar 2022 16:09:25 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD6B3103DBC for ; Mon, 21 Mar 2022 13:07:53 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id u16so21214268wru.4 for ; Mon, 21 Mar 2022 13:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mEFtl1Tv/8nxJX+EKBZcS0Lbq1ln6/kUirDV/Y73Tsk=; b=F3u4P2haN80NrYC3ry5184pwPLJ/YQ3Giy8swGovoQmMsCQ6epOO6PnK/ZYYrgUlG4 XrFw44QYsT+1XIdOx8Apq84YhG+Bmip+iW14+CfVb5HO9Up36ocNDiqUqWFpxlCcVnYU MXentJLxLq1zjQ5EbW+iCgXlPPXr06Js/lSjzmXhCa9Tzp9iEqGMsgbr7PWoFB3HyB+j olxsoLTCA3bzP73p2v4DC4Vn7SqT+htvS3Bw/Ynaje3tRX7TcNRePnKo9XOyBJOsN05q Y+iplil8uOnefQb9/1ELEnNGEP73Nt+vqB1dpisFP2PQC7sTR15IYQBp+ejIJyfjcuAK EYKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mEFtl1Tv/8nxJX+EKBZcS0Lbq1ln6/kUirDV/Y73Tsk=; b=b2oQN2yTWP/TMVLgoB1t6p8FqTSqW9Iz1pgItlxYmtWFMsXx2iJbqmBYrU3b58GcdO nvm+SVV9g8mfchTut/tBwJo4WRmVOAUxR3YUkNmUlEp24QjI0QrenBPgfmKNW3gNmKFq ei+vE+K1IJUp3qzpnc74KFbxoQXvAe4K5ws2WEkYsSoD1N/YihLET6IUrj/0qjvq6l+N iMSnIlkdE/b5uuEyvtbCTFErugEvzaztaMkaG44/gJXQnp67dAJtdaJMf+SHqVCGz8MU DoOglgGiBRlz/gECidAhWLxU7VhTqJJvVqwef/6b/ogKu/x9eDRKwsIYCQSBoYllS4My jC5Q== X-Gm-Message-State: AOAM530uJpoJVBQ+Qccv/7D/9b3Kpajp2wrnh7DOsA0tixI9I6a7Ki2C ks11XeWcoh673sAPUIq+KRUBMg== X-Google-Smtp-Source: ABdhPJxkRI1qN0mzT6Z/8NVjt0akO5/CVOtecvW98ZeN8iahdZXAXfJOQaJBPSBncrIHwFoZBScOrQ== X-Received: by 2002:a5d:59a1:0:b0:204:1777:fc08 with SMTP id p1-20020a5d59a1000000b002041777fc08mr3923959wrr.545.1647893272263; Mon, 21 Mar 2022 13:07:52 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:07:51 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 04/26] crypto: rockchip: fix privete/private typo Date: Mon, 21 Mar 2022 20:07:17 +0000 Message-Id: <20220321200739.3572792-5-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This fix a simple typo on private word. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockc= hip/rk3288_crypto.h index 2fa7131e4060..656d6795d400 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.h +++ b/drivers/crypto/rockchip/rk3288_crypto.h @@ -235,7 +235,7 @@ struct rk_ahash_ctx { struct crypto_ahash *fallback_tfm; }; =20 -/* the privete variable of hash for fallback */ +/* the private variable of hash for fallback */ struct rk_ahash_rctx { struct ahash_request fallback_req; u32 mode; --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E9E1C4332F for ; Mon, 21 Mar 2022 20:08:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352952AbiCUUJt (ORCPT ); Mon, 21 Mar 2022 16:09:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352909AbiCUUJX (ORCPT ); Mon, 21 Mar 2022 16:09:23 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 949B6104284 for ; Mon, 21 Mar 2022 13:07:54 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id j18so12587874wrd.6 for ; Mon, 21 Mar 2022 13:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GHpdtAlTcspTEUjTHGrVm+ax9xkwkOuqMMVc7q/8Ibs=; b=Q0VZNaCBPNXkyLhbXvsIzD/m/SwspfNYTwEfGLCdFuf/+RGDewVx9kQhugulOTop3B RjRH8YFeZinkg7ZZiJ6phzT5X78+T28F2Rk5ylyyv/wv8tYs5M4U4l1/O1vpVQD4ktmo dlPs3TY47ouNPC6gVWC3zk7endCQofxlg22/ayYd1yjndjhcyRqF+qBPjMoe6p9zWIE8 WqyNMld7V4b7vx5Eix0be1uwJgj1b61DZXswmBKAd8hdBPPTTWTf22ULeeVtvSAEoXLR N+kVPX6t9W3lZF+vxQETgu2xnR+MtIwpG37ZrE986HepaySBbvH9Ys8xc1CxeAsPJ7Mp kDxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GHpdtAlTcspTEUjTHGrVm+ax9xkwkOuqMMVc7q/8Ibs=; b=4fHE617xk+BAQ161bFOcQ/7thwfWHHfROxRWfVGoFe3mSrumuI44yab+G3Np3M6aua vm2txaoUdUSeD4znF9RvNQAyxmbqNqcF9sxaMRFACwSyYYOR7ruw5wlAVkpofSbvR1cn 5wa0TjkwbYFUvWnL/EW5Wo4PdtxgXRN87zlgM8t5EqHpPBRZp4rdKdcSCSMsEjOKa+UA WN1i3riNVe1pFwY4wD0xfu9EcRyPyZg0xvV63PyTfUzUK62ZnG6gZrszOCSesZe5Lfrz Wxo3R50k9naUBzw70/e0GkDlky19vkrBIqtu3XVHbhl+eeZ1Gl6bP4KyH7c5F4DqtJoy 1mxw== X-Gm-Message-State: AOAM5322a+W9+6Q8xZDmNlgeJTYhqWU8NqNSpYJQXEbg6X09Ogh+uZ/Q 2Q7FWFZD3lsEAMxsgmebJuLk7g== X-Google-Smtp-Source: ABdhPJx6cozvo01X7CmrlVUXK8Cw3g2zz07Zy4UFKYJIdjXtuOLb6Xjh5kPJCX1nQqNXl+LRsG11Eg== X-Received: by 2002:a5d:5255:0:b0:203:ec9c:6d5e with SMTP id k21-20020a5d5255000000b00203ec9c6d5emr17806786wrc.70.1647893273111; Mon, 21 Mar 2022 13:07:53 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:07:52 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 05/26] crypto: rockchip: do not store mode globally Date: Mon, 21 Mar 2022 20:07:18 +0000 Message-Id: <20220321200739.3572792-6-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Storing the mode globally does not work if 2 requests are handled in the same time. We should store it in a request context. Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.h | 5 +- .../crypto/rockchip/rk3288_crypto_skcipher.c | 58 ++++++++++++------- 2 files changed, 41 insertions(+), 22 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockc= hip/rk3288_crypto.h index 656d6795d400..c919d9a43a08 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.h +++ b/drivers/crypto/rockchip/rk3288_crypto.h @@ -245,10 +245,13 @@ struct rk_ahash_rctx { struct rk_cipher_ctx { struct rk_crypto_info *dev; unsigned int keylen; - u32 mode; u8 iv[AES_BLOCK_SIZE]; }; =20 +struct rk_cipher_rctx { + u32 mode; +}; + enum alg_type { ALG_TYPE_HASH, ALG_TYPE_CIPHER, diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/cry= pto/rockchip/rk3288_crypto_skcipher.c index 8c44a19eab75..bbd0bf52bf07 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c +++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c @@ -76,9 +76,10 @@ static int rk_aes_ecb_encrypt(struct skcipher_request *r= eq) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_crypto_info *dev =3D ctx->dev; =20 - ctx->mode =3D RK_CRYPTO_AES_ECB_MODE; + rctx->mode =3D RK_CRYPTO_AES_ECB_MODE; return rk_handle_req(dev, req); } =20 @@ -86,9 +87,10 @@ static int rk_aes_ecb_decrypt(struct skcipher_request *r= eq) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_crypto_info *dev =3D ctx->dev; =20 - ctx->mode =3D RK_CRYPTO_AES_ECB_MODE | RK_CRYPTO_DEC; + rctx->mode =3D RK_CRYPTO_AES_ECB_MODE | RK_CRYPTO_DEC; return rk_handle_req(dev, req); } =20 @@ -96,9 +98,10 @@ static int rk_aes_cbc_encrypt(struct skcipher_request *r= eq) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_crypto_info *dev =3D ctx->dev; =20 - ctx->mode =3D RK_CRYPTO_AES_CBC_MODE; + rctx->mode =3D RK_CRYPTO_AES_CBC_MODE; return rk_handle_req(dev, req); } =20 @@ -106,9 +109,10 @@ static int rk_aes_cbc_decrypt(struct skcipher_request = *req) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_crypto_info *dev =3D ctx->dev; =20 - ctx->mode =3D RK_CRYPTO_AES_CBC_MODE | RK_CRYPTO_DEC; + rctx->mode =3D RK_CRYPTO_AES_CBC_MODE | RK_CRYPTO_DEC; return rk_handle_req(dev, req); } =20 @@ -116,9 +120,10 @@ static int rk_des_ecb_encrypt(struct skcipher_request = *req) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_crypto_info *dev =3D ctx->dev; =20 - ctx->mode =3D 0; + rctx->mode =3D 0; return rk_handle_req(dev, req); } =20 @@ -126,9 +131,10 @@ static int rk_des_ecb_decrypt(struct skcipher_request = *req) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_crypto_info *dev =3D ctx->dev; =20 - ctx->mode =3D RK_CRYPTO_DEC; + rctx->mode =3D RK_CRYPTO_DEC; return rk_handle_req(dev, req); } =20 @@ -136,9 +142,10 @@ static int rk_des_cbc_encrypt(struct skcipher_request = *req) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_crypto_info *dev =3D ctx->dev; =20 - ctx->mode =3D RK_CRYPTO_TDES_CHAINMODE_CBC; + rctx->mode =3D RK_CRYPTO_TDES_CHAINMODE_CBC; return rk_handle_req(dev, req); } =20 @@ -146,9 +153,10 @@ static int rk_des_cbc_decrypt(struct skcipher_request = *req) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_crypto_info *dev =3D ctx->dev; =20 - ctx->mode =3D RK_CRYPTO_TDES_CHAINMODE_CBC | RK_CRYPTO_DEC; + rctx->mode =3D RK_CRYPTO_TDES_CHAINMODE_CBC | RK_CRYPTO_DEC; return rk_handle_req(dev, req); } =20 @@ -156,9 +164,10 @@ static int rk_des3_ede_ecb_encrypt(struct skcipher_req= uest *req) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_crypto_info *dev =3D ctx->dev; =20 - ctx->mode =3D RK_CRYPTO_TDES_SELECT; + rctx->mode =3D RK_CRYPTO_TDES_SELECT; return rk_handle_req(dev, req); } =20 @@ -166,9 +175,10 @@ static int rk_des3_ede_ecb_decrypt(struct skcipher_req= uest *req) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_crypto_info *dev =3D ctx->dev; =20 - ctx->mode =3D RK_CRYPTO_TDES_SELECT | RK_CRYPTO_DEC; + rctx->mode =3D RK_CRYPTO_TDES_SELECT | RK_CRYPTO_DEC; return rk_handle_req(dev, req); } =20 @@ -176,9 +186,10 @@ static int rk_des3_ede_cbc_encrypt(struct skcipher_req= uest *req) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_crypto_info *dev =3D ctx->dev; =20 - ctx->mode =3D RK_CRYPTO_TDES_SELECT | RK_CRYPTO_TDES_CHAINMODE_CBC; + rctx->mode =3D RK_CRYPTO_TDES_SELECT | RK_CRYPTO_TDES_CHAINMODE_CBC; return rk_handle_req(dev, req); } =20 @@ -186,9 +197,10 @@ static int rk_des3_ede_cbc_decrypt(struct skcipher_req= uest *req) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_crypto_info *dev =3D ctx->dev; =20 - ctx->mode =3D RK_CRYPTO_TDES_SELECT | RK_CRYPTO_TDES_CHAINMODE_CBC | + rctx->mode =3D RK_CRYPTO_TDES_SELECT | RK_CRYPTO_TDES_CHAINMODE_CBC | RK_CRYPTO_DEC; return rk_handle_req(dev, req); } @@ -199,6 +211,7 @@ static void rk_ablk_hw_init(struct rk_crypto_info *dev) skcipher_request_cast(dev->async_req); struct crypto_skcipher *cipher =3D crypto_skcipher_reqtfm(req); struct crypto_tfm *tfm =3D crypto_skcipher_tfm(cipher); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(cipher); u32 ivsize, block, conf_reg =3D 0; =20 @@ -206,22 +219,22 @@ static void rk_ablk_hw_init(struct rk_crypto_info *de= v) ivsize =3D crypto_skcipher_ivsize(cipher); =20 if (block =3D=3D DES_BLOCK_SIZE) { - ctx->mode |=3D RK_CRYPTO_TDES_FIFO_MODE | + rctx->mode |=3D RK_CRYPTO_TDES_FIFO_MODE | RK_CRYPTO_TDES_BYTESWAP_KEY | RK_CRYPTO_TDES_BYTESWAP_IV; - CRYPTO_WRITE(dev, RK_CRYPTO_TDES_CTRL, ctx->mode); + CRYPTO_WRITE(dev, RK_CRYPTO_TDES_CTRL, rctx->mode); memcpy_toio(dev->reg + RK_CRYPTO_TDES_IV_0, req->iv, ivsize); conf_reg =3D RK_CRYPTO_DESSEL; } else { - ctx->mode |=3D RK_CRYPTO_AES_FIFO_MODE | + rctx->mode |=3D RK_CRYPTO_AES_FIFO_MODE | RK_CRYPTO_AES_KEY_CHANGE | RK_CRYPTO_AES_BYTESWAP_KEY | RK_CRYPTO_AES_BYTESWAP_IV; if (ctx->keylen =3D=3D AES_KEYSIZE_192) - ctx->mode |=3D RK_CRYPTO_AES_192BIT_key; + rctx->mode |=3D RK_CRYPTO_AES_192BIT_key; else if (ctx->keylen =3D=3D AES_KEYSIZE_256) - ctx->mode |=3D RK_CRYPTO_AES_256BIT_key; - CRYPTO_WRITE(dev, RK_CRYPTO_AES_CTRL, ctx->mode); + rctx->mode |=3D RK_CRYPTO_AES_256BIT_key; + CRYPTO_WRITE(dev, RK_CRYPTO_AES_CTRL, rctx->mode); memcpy_toio(dev->reg + RK_CRYPTO_AES_IV_0, req->iv, ivsize); } conf_reg |=3D RK_CRYPTO_BYTESWAP_BTFIFO | @@ -246,6 +259,7 @@ static int rk_set_data_start(struct rk_crypto_info *dev) struct skcipher_request *req =3D skcipher_request_cast(dev->async_req); struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); u32 ivsize =3D crypto_skcipher_ivsize(tfm); u8 *src_last_blk =3D page_address(sg_page(dev->sg_src)) + @@ -254,7 +268,7 @@ static int rk_set_data_start(struct rk_crypto_info *dev) /* Store the iv that need to be updated in chain mode. * And update the IV buffer to contain the next IV for decryption mode. */ - if (ctx->mode & RK_CRYPTO_DEC) { + if (rctx->mode & RK_CRYPTO_DEC) { memcpy(ctx->iv, src_last_blk, ivsize); sg_pcopy_to_buffer(dev->first, dev->src_nents, req->iv, ivsize, dev->total - ivsize); @@ -294,11 +308,12 @@ static void rk_iv_copyback(struct rk_crypto_info *dev) struct skcipher_request *req =3D skcipher_request_cast(dev->async_req); struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); u32 ivsize =3D crypto_skcipher_ivsize(tfm); =20 /* Update the IV buffer to contain the next IV for encryption mode. */ - if (!(ctx->mode & RK_CRYPTO_DEC)) { + if (!(rctx->mode & RK_CRYPTO_DEC)) { if (dev->aligned) { memcpy(req->iv, sg_virt(dev->sg_dst) + dev->sg_dst->length - ivsize, ivsize); @@ -314,11 +329,12 @@ static void rk_update_iv(struct rk_crypto_info *dev) struct skcipher_request *req =3D skcipher_request_cast(dev->async_req); struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); u32 ivsize =3D crypto_skcipher_ivsize(tfm); u8 *new_iv =3D NULL; =20 - if (ctx->mode & RK_CRYPTO_DEC) { + if (rctx->mode & RK_CRYPTO_DEC) { new_iv =3D ctx->iv; } else { new_iv =3D page_address(sg_page(dev->sg_dst)) + --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BFD4C433FE for ; Mon, 21 Mar 2022 20:08:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353086AbiCUUKR (ORCPT ); Mon, 21 Mar 2022 16:10:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352948AbiCUUJi (ORCPT ); Mon, 21 Mar 2022 16:09:38 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ED54265 for ; Mon, 21 Mar 2022 13:07:55 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id q8so10859012wrc.0 for ; Mon, 21 Mar 2022 13:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sCvYVn7Hne+2KPUxmGua1GiohRnLm8tqh0zAsSOWbzg=; b=U0I+apoFQqBcFpdqv1CICk4UopHjh1TR5t+5XmFtvuXHKGrCnrFRBJuAP2RmUcFLRo 5X6EGra3/ysXQSQblIoJjOzcja/nNUpn1Fq7yjIH846LfpOUzPuIPrF6lxFRiFt/dCwH xKLxMrKx8InSw1c6PCD07YNXPQZRPepODCtm4+cKWdBg/v9+8kuCzhrUQysrTUShNqb2 sgvKn/aknyAyW/ye+B+zPj8p4haOezOCBUOP452chzDpYMt65FhAdGrK/ygEJw02CcKj +QtDQQXluu9a5XBB2bI60Jyqb4JGb4E+mNFt6m/fUiSc/lWQptfXtHuyxPAIdmcouz9o n3dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sCvYVn7Hne+2KPUxmGua1GiohRnLm8tqh0zAsSOWbzg=; b=Edoc63fI+E+u1JTFdkm/a5odTC10FfhYpdkU7GwhB/S5bsPPuGEUpq2X2IfHvn73oK /ZMOiPR1C7DzYWxxm8pseGaR96XRuwJtKaXpkMvP4EF0CYg8aFvotZahaVJ76det9RW2 lKrohSOjqYHUAVdddqj6X2z5KddWAN6hsHqJrv/93lB18PqQgL7BvExofx8hLyBa3PVb MHcWZCC/9YiHYdi1C5+rLimWVFFihGRtSsaKTIzC+x8tB+DQpqMFhT12H7IebkuiYblN DmcJrGkYibCU47wzUg66RzM1ra6mzl6JRgJk5mjprPOrw5+6b7VQ5SD4gSuGCRUey7FD +fwA== X-Gm-Message-State: AOAM531LgOe8J6GUkQ9qnEkpNHa/Dv7Q1S/cPBjprQB/XhexK8IePrDn yhL0qfT0+vz0giyh1hUwMdydNg== X-Google-Smtp-Source: ABdhPJy72meZPVVcutO8WQVX/sUngezMw0i4beXbVC7TcDENGfVFsuQr0n8vcDoccqN5hrMsiwTPEA== X-Received: by 2002:a5d:6542:0:b0:203:da90:969f with SMTP id z2-20020a5d6542000000b00203da90969fmr18904212wrv.479.1647893273865; Mon, 21 Mar 2022 13:07:53 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:07:53 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 06/26] crypto: rockchip: add fallback for cipher Date: Mon, 21 Mar 2022 20:07:19 +0000 Message-Id: <20220321200739.3572792-7-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The hardware does not handle 0 size length request, let's add a fallback. Furthermore fallback will be used for all unaligned case the hardware cannot handle. Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") Signed-off-by: Corentin Labbe --- drivers/crypto/Kconfig | 4 + drivers/crypto/rockchip/rk3288_crypto.h | 2 + .../crypto/rockchip/rk3288_crypto_skcipher.c | 105 +++++++++++++++--- 3 files changed, 98 insertions(+), 13 deletions(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 7b2d138bc83e..84ab14afcbd9 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -784,6 +784,10 @@ config CRYPTO_DEV_IMGTEC_HASH config CRYPTO_DEV_ROCKCHIP tristate "Rockchip's Cryptographic Engine driver" depends on OF && ARCH_ROCKCHIP + depends on PM + select CRYPTO_ECB + select CRYPTO_CBC + select CRYPTO_DES select CRYPTO_AES select CRYPTO_LIB_DES select CRYPTO_MD5 diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockc= hip/rk3288_crypto.h index c919d9a43a08..8b1e15d8ddc6 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.h +++ b/drivers/crypto/rockchip/rk3288_crypto.h @@ -246,10 +246,12 @@ struct rk_cipher_ctx { struct rk_crypto_info *dev; unsigned int keylen; u8 iv[AES_BLOCK_SIZE]; + struct crypto_skcipher *fallback_tfm; }; =20 struct rk_cipher_rctx { u32 mode; + struct skcipher_request fallback_req; // keep at the end }; =20 enum alg_type { diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/cry= pto/rockchip/rk3288_crypto_skcipher.c index bbd0bf52bf07..c6b601086c04 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c +++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c @@ -13,6 +13,71 @@ =20 #define RK_CRYPTO_DEC BIT(0) =20 +static int rk_cipher_need_fallback(struct skcipher_request *req) +{ + struct scatterlist *sgs, *sgd; + unsigned int todo, len; + unsigned int bs =3D crypto_skcipher_blocksize(tfm); + + if (!req->cryptlen) + return true; + + len =3D req->cryptlen; + sgs =3D req->src; + while (sgs) { + if (!IS_ALIGNED(sgs->offset, sizeof(u32))) { + return true; + } + todo =3D min(len, sgs->length); + if (todo % bs) { + return true; + } + len -=3D todo; + sgs =3D sg_next(sgs); + } + len =3D req->cryptlen; + sgd =3D req->dst; + while (sgd) { + if (!IS_ALIGNED(sgd->offset, sizeof(u32))) { + return true; + } + todo =3D min(len, sgd->length); + if (todo % bs) { + return true; + } + len -=3D todo; + sgd =3D sg_next(sgd); + } + sgs =3D req->src; + sgd =3D req->dst; + while (sgs && sgd) { + if (sgs->length !=3D sgd->length) + return true; + sgs =3D sg_next(sgs); + sgd =3D sg_next(sgd); + } + return false; +} + +static int rk_cipher_fallback(struct skcipher_request *areq) +{ + struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(areq); + struct rk_cipher_ctx *op =3D crypto_skcipher_ctx(tfm); + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(areq); + int err; + + skcipher_request_set_tfm(&rctx->fallback_req, op->fallback_tfm); + skcipher_request_set_callback(&rctx->fallback_req, areq->base.flags, + areq->base.complete, areq->base.data); + skcipher_request_set_crypt(&rctx->fallback_req, areq->src, areq->dst, + areq->cryptlen, areq->iv); + if (rctx->mode & RK_CRYPTO_DEC) + err =3D crypto_skcipher_decrypt(&rctx->fallback_req); + else + err =3D crypto_skcipher_encrypt(&rctx->fallback_req); + return err; +} + static void rk_crypto_complete(struct crypto_async_request *base, int err) { if (base->complete) @@ -22,10 +87,10 @@ static void rk_crypto_complete(struct crypto_async_requ= est *base, int err) static int rk_handle_req(struct rk_crypto_info *dev, struct skcipher_request *req) { - if (!IS_ALIGNED(req->cryptlen, dev->align_size)) - return -EINVAL; - else - return dev->enqueue(dev, &req->base); + if (rk_cipher_need_fallback(req)) + return rk_cipher_fallback(req); + + return dev->enqueue(dev, &req->base); } =20 static int rk_aes_setkey(struct crypto_skcipher *cipher, @@ -39,7 +104,8 @@ static int rk_aes_setkey(struct crypto_skcipher *cipher, return -EINVAL; ctx->keylen =3D keylen; memcpy_toio(ctx->dev->reg + RK_CRYPTO_AES_KEY_0, key, keylen); - return 0; + + return crypto_skcipher_setkey(ctx->fallback_tfm, key, keylen); } =20 static int rk_des_setkey(struct crypto_skcipher *cipher, @@ -54,7 +120,8 @@ static int rk_des_setkey(struct crypto_skcipher *cipher, =20 ctx->keylen =3D keylen; memcpy_toio(ctx->dev->reg + RK_CRYPTO_TDES_KEY1_0, key, keylen); - return 0; + + return crypto_skcipher_setkey(ctx->fallback_tfm, key, keylen); } =20 static int rk_tdes_setkey(struct crypto_skcipher *cipher, @@ -69,7 +136,7 @@ static int rk_tdes_setkey(struct crypto_skcipher *cipher, =20 ctx->keylen =3D keylen; memcpy_toio(ctx->dev->reg + RK_CRYPTO_TDES_KEY1_0, key, keylen); - return 0; + return crypto_skcipher_setkey(ctx->fallback_tfm, key, keylen); } =20 static int rk_aes_ecb_encrypt(struct skcipher_request *req) @@ -394,6 +461,7 @@ static int rk_ablk_init_tfm(struct crypto_skcipher *tfm) { struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); struct skcipher_alg *alg =3D crypto_skcipher_alg(tfm); + const char *name =3D crypto_tfm_alg_name(&tfm->base); struct rk_crypto_tmp *algt; =20 algt =3D container_of(alg, struct rk_crypto_tmp, alg.skcipher); @@ -407,6 +475,16 @@ static int rk_ablk_init_tfm(struct crypto_skcipher *tf= m) if (!ctx->dev->addr_vir) return -ENOMEM; =20 + ctx->fallback_tfm =3D crypto_alloc_skcipher(name, 0, CRYPTO_ALG_NEED_FALL= BACK); + if (IS_ERR(ctx->fallback_tfm)) { + dev_err(ctx->dev->dev, "ERROR: Cannot allocate fallback for %s %ld\n", + name, PTR_ERR(ctx->fallback_tfm)); + return PTR_ERR(ctx->fallback_tfm); + } + + tfm->reqsize =3D sizeof(struct rk_cipher_rctx) + + crypto_skcipher_reqsize(ctx->fallback_tfm); + return 0; } =20 @@ -415,6 +493,7 @@ static void rk_ablk_exit_tfm(struct crypto_skcipher *tf= m) struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 free_page((unsigned long)ctx->dev->addr_vir); + crypto_free_skcipher(ctx->fallback_tfm); } =20 struct rk_crypto_tmp rk_ecb_aes_alg =3D { @@ -423,7 +502,7 @@ struct rk_crypto_tmp rk_ecb_aes_alg =3D { .base.cra_name =3D "ecb(aes)", .base.cra_driver_name =3D "ecb-aes-rk", .base.cra_priority =3D 300, - .base.cra_flags =3D CRYPTO_ALG_ASYNC, + .base.cra_flags =3D CRYPTO_ALG_ASYNC | CRYPTO_ALG_NEED_FALLBACK, .base.cra_blocksize =3D AES_BLOCK_SIZE, .base.cra_ctxsize =3D sizeof(struct rk_cipher_ctx), .base.cra_alignmask =3D 0x0f, @@ -445,7 +524,7 @@ struct rk_crypto_tmp rk_cbc_aes_alg =3D { .base.cra_name =3D "cbc(aes)", .base.cra_driver_name =3D "cbc-aes-rk", .base.cra_priority =3D 300, - .base.cra_flags =3D CRYPTO_ALG_ASYNC, + .base.cra_flags =3D CRYPTO_ALG_ASYNC | CRYPTO_ALG_NEED_FALLBACK, .base.cra_blocksize =3D AES_BLOCK_SIZE, .base.cra_ctxsize =3D sizeof(struct rk_cipher_ctx), .base.cra_alignmask =3D 0x0f, @@ -468,7 +547,7 @@ struct rk_crypto_tmp rk_ecb_des_alg =3D { .base.cra_name =3D "ecb(des)", .base.cra_driver_name =3D "ecb-des-rk", .base.cra_priority =3D 300, - .base.cra_flags =3D CRYPTO_ALG_ASYNC, + .base.cra_flags =3D CRYPTO_ALG_ASYNC | CRYPTO_ALG_NEED_FALLBACK, .base.cra_blocksize =3D DES_BLOCK_SIZE, .base.cra_ctxsize =3D sizeof(struct rk_cipher_ctx), .base.cra_alignmask =3D 0x07, @@ -490,7 +569,7 @@ struct rk_crypto_tmp rk_cbc_des_alg =3D { .base.cra_name =3D "cbc(des)", .base.cra_driver_name =3D "cbc-des-rk", .base.cra_priority =3D 300, - .base.cra_flags =3D CRYPTO_ALG_ASYNC, + .base.cra_flags =3D CRYPTO_ALG_ASYNC | CRYPTO_ALG_NEED_FALLBACK, .base.cra_blocksize =3D DES_BLOCK_SIZE, .base.cra_ctxsize =3D sizeof(struct rk_cipher_ctx), .base.cra_alignmask =3D 0x07, @@ -513,7 +592,7 @@ struct rk_crypto_tmp rk_ecb_des3_ede_alg =3D { .base.cra_name =3D "ecb(des3_ede)", .base.cra_driver_name =3D "ecb-des3-ede-rk", .base.cra_priority =3D 300, - .base.cra_flags =3D CRYPTO_ALG_ASYNC, + .base.cra_flags =3D CRYPTO_ALG_ASYNC | CRYPTO_ALG_NEED_FALLBACK, .base.cra_blocksize =3D DES_BLOCK_SIZE, .base.cra_ctxsize =3D sizeof(struct rk_cipher_ctx), .base.cra_alignmask =3D 0x07, @@ -535,7 +614,7 @@ struct rk_crypto_tmp rk_cbc_des3_ede_alg =3D { .base.cra_name =3D "cbc(des3_ede)", .base.cra_driver_name =3D "cbc-des3-ede-rk", .base.cra_priority =3D 300, - .base.cra_flags =3D CRYPTO_ALG_ASYNC, + .base.cra_flags =3D CRYPTO_ALG_ASYNC | CRYPTO_ALG_NEED_FALLBACK, .base.cra_blocksize =3D DES_BLOCK_SIZE, .base.cra_ctxsize =3D sizeof(struct rk_cipher_ctx), .base.cra_alignmask =3D 0x07, --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35952C4332F for ; Mon, 21 Mar 2022 20:09:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353118AbiCUUK3 (ORCPT ); Mon, 21 Mar 2022 16:10:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352944AbiCUUJh (ORCPT ); Mon, 21 Mar 2022 16:09:37 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3070ADEF for ; Mon, 21 Mar 2022 13:07:56 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id b19so22194534wrh.11 for ; Mon, 21 Mar 2022 13:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UQNU+zESf8LDh+yao8Oc3gO6dXSE2ne6kHnyQ9VdhdQ=; b=bCWuedgEdxQ7ZPcn7Zt8Lml8+iEWLNQVUY0rUru/QtoYn0MOrpEUsyLpekVCNDYCJ+ YeEdphO1oqFtPGEyEIBfxShBostEBw7ElvU8b5Hb6BRr+ZDTU7P2/s8WLpAcW4WNNjqL dy0io7iO7xqlE/pYqgFzVtYTt+zUOE5WjMEhFrPmLiCXtOIe/fMI6Hi/PRu9fzg36a70 YUfaeSodXPYFR5VsIiKvhxSORikLu9Gh6Ou8lcaBABQ6O6Z3AUI4FWn3jC+iEUihnC+y Jc4yvH4jmgX/8RFmeqAyG1h4DG/9+QCquKHhPAqEq2RVYHhlSVURqhgGR141duC/bvV1 B89Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UQNU+zESf8LDh+yao8Oc3gO6dXSE2ne6kHnyQ9VdhdQ=; b=M1Wvl3B168IhvodtXRm+jXdnAG56XI7KP27znVYZKWQNQwQiQTKD8yMLDlAD6ONUx+ WkCiKSL/gtqGFTpRn7ryqWEaUR0jKoFjpx5OLFnF3LQzZdR8uoA0XIkL7okV2x3n97NW YPrAbw/SnKEbgJvMWqPIyCgemEo1DjvOy5uV6sJFpQ9NQVUqZmSQKxh5e5dgEvgKlgcQ 839U65LFrW9eYAhlyRyFWCicam2+8aWoYvxIasdJ7RBKxuZrfS+VbIacOEQRRFoOLh+u RLfjjW5muDoNiRNivF+juApLug45kJpr/aJunMMr0R3bqRyQ7ft2C1Jroh2DFo5VcRJ2 X5oQ== X-Gm-Message-State: AOAM532QQcolTx+hMtbQuAZgif4u6wijZ2gies7Jd2yos0FAnF1BWO2i 9Zg7Ek/EpI+Ga0xMX+fRPQBRY0j187JKeg== X-Google-Smtp-Source: ABdhPJw+YjFMcmO2mxPCtPyEBZnTzJXXr/ng5v/aNNYmHjLenv/wVVgoiGG3XNBwDlHVKQmZZJYNJw== X-Received: by 2002:a5d:6442:0:b0:203:dff2:866c with SMTP id d2-20020a5d6442000000b00203dff2866cmr19241487wrw.465.1647893274691; Mon, 21 Mar 2022 13:07:54 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:07:54 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 07/26] crypto: rockchip: add fallback for ahash Date: Mon, 21 Mar 2022 20:07:20 +0000 Message-Id: <20220321200739.3572792-8-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Adds a fallback for all case hardware cannot handle. Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto_ahash.c | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto= /rockchip/rk3288_crypto_ahash.c index 49017d1fb510..16009bb0bf16 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c @@ -16,6 +16,40 @@ * so we put the fixed hash out when met zero message. */ =20 +static bool rk_ahash_need_fallback(struct ahash_request *req) +{ + struct scatterlist *sg; + + sg =3D req->src; + while (sg) { + if (!IS_ALIGNED(sg->offset, sizeof(u32))) { + return true; + } + if (sg->length % 4) { + return true; + } + sg =3D sg_next(sg); + } + return false; +} + +static int rk_ahash_digest_fb(struct ahash_request *areq) +{ + struct rk_ahash_rctx *rctx =3D ahash_request_ctx(areq); + struct crypto_ahash *tfm =3D crypto_ahash_reqtfm(areq); + struct rk_ahash_ctx *tfmctx =3D crypto_ahash_ctx(tfm); + + ahash_request_set_tfm(&rctx->fallback_req, tfmctx->fallback_tfm); + rctx->fallback_req.base.flags =3D areq->base.flags & + CRYPTO_TFM_REQ_MAY_SLEEP; + + rctx->fallback_req.nbytes =3D areq->nbytes; + rctx->fallback_req.src =3D areq->src; + rctx->fallback_req.result =3D areq->result; + + return crypto_ahash_digest(&rctx->fallback_req); +} + static int zero_message_process(struct ahash_request *req) { struct crypto_ahash *tfm =3D crypto_ahash_reqtfm(req); @@ -167,6 +201,9 @@ static int rk_ahash_digest(struct ahash_request *req) struct rk_ahash_ctx *tctx =3D crypto_tfm_ctx(req->base.tfm); struct rk_crypto_info *dev =3D tctx->dev; =20 + if (rk_ahash_need_fallback(req)) + return rk_ahash_digest_fb(req); + if (!req->nbytes) return zero_message_process(req); else @@ -309,6 +346,7 @@ static void rk_cra_hash_exit(struct crypto_tfm *tfm) struct rk_ahash_ctx *tctx =3D crypto_tfm_ctx(tfm); =20 free_page((unsigned long)tctx->dev->addr_vir); + crypto_free_ahash(tctx->fallback_tfm); } =20 struct rk_crypto_tmp rk_ahash_sha1 =3D { --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A71C433EF for ; Mon, 21 Mar 2022 20:09:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353030AbiCUUKX (ORCPT ); Mon, 21 Mar 2022 16:10:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352954AbiCUUJi (ORCPT ); Mon, 21 Mar 2022 16:09:38 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01E9C104297 for ; Mon, 21 Mar 2022 13:07:57 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id r10so22253024wrp.3 for ; Mon, 21 Mar 2022 13:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ci0efpCMY9zTNuOVgDKNG91fdIJJ0F69qN8X/Q/Dc4g=; b=fUlJScinxALBEKGsxDRADRumA9/X76r4caxuw7MfkLlPHpxvicP7Z1x2y7CJtV7tAk 08HcMfjN3qx8ha5ErVUA1JEOtg/wO8FK8wwK7RdaKWzmaeCVBqZHmJCoQcpldbXU5v+Y HPD7qSmBVrpx95StbfZPDTznrB7TN11f5XqoJF/C8HaOmV2OJvOoOlVCuDLVaewm2NSq BXj62hwdSLYjxudkNPULA9U1JzjvuIrXv0tDOv/I6hz33ncEfU0anwuJC9Sl8qW7k6+B Cx5w97iId9pK6D3w1E+GFB/A+75c/k2IA7NHnwUkj3O1lRgO8wCG8JdSXQ0KwvMHMn3d UVhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ci0efpCMY9zTNuOVgDKNG91fdIJJ0F69qN8X/Q/Dc4g=; b=wm3dTVMwzYJk2SwPkErdPYfo18a8VP9yzWyIcRWMNiVZ9tWs8Bp+xyTU1uooWQsdbF AM0jZQLldW7M9qdS5ZVsWY+zmgJkX1Bdy1raflV6boWCbGebBOM26jSXFzBTq1Ii/P7z uOf0bObTspN3jFMlUl5/ZuLbsAXSl/ek+ofR+hUP4Vg8YchNIfpF43D780VBt6MEHmF9 tQHc2rqoH3NmgR0eLk4lhS2s4WhJfxXN+bPbVc5pgk+uHrvFQLeITW/GOUaVA9A5MH+d yFQedwIF6N2LrprRfuzG13I+CNvPxkU7/HUfHQpfhESQD5fBlFzBsjxHiAaI7XCMqz+Q l3Lw== X-Gm-Message-State: AOAM532e6IbSea2XGl/n0O7dLzn2RhhJD0N/bBxruJ3lp9pJG124aIbG bQFC+dqXfKVt2vAKx826TKRCbA== X-Google-Smtp-Source: ABdhPJxyLt+c6FqsDmNtE9T6VneF9gd/vdSmff2ATUPTkqRPvltvlqbagxJ930el3cMP7k+jGTV9wg== X-Received: by 2002:a5d:6d8b:0:b0:203:f9b4:be1d with SMTP id l11-20020a5d6d8b000000b00203f9b4be1dmr13153556wrs.298.1647893275492; Mon, 21 Mar 2022 13:07:55 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:07:55 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 08/26] crypto: rockchip: better handle cipher key Date: Mon, 21 Mar 2022 20:07:21 +0000 Message-Id: <20220321200739.3572792-9-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The key should not be set in hardware too much in advance, this will fail it 2 TFM with different keys generate alternative requests. The key should be stored and used just before doing cipher operations. Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.h | 1 + drivers/crypto/rockchip/rk3288_crypto_skcipher.c | 10 +++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockc= hip/rk3288_crypto.h index 8b1e15d8ddc6..826508e4a0c3 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.h +++ b/drivers/crypto/rockchip/rk3288_crypto.h @@ -245,6 +245,7 @@ struct rk_ahash_rctx { struct rk_cipher_ctx { struct rk_crypto_info *dev; unsigned int keylen; + u32 key[AES_MAX_KEY_SIZE / 4]; u8 iv[AES_BLOCK_SIZE]; struct crypto_skcipher *fallback_tfm; }; diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/cry= pto/rockchip/rk3288_crypto_skcipher.c index c6b601086c04..5a9ba7c0206d 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c +++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c @@ -103,7 +103,7 @@ static int rk_aes_setkey(struct crypto_skcipher *cipher, keylen !=3D AES_KEYSIZE_256) return -EINVAL; ctx->keylen =3D keylen; - memcpy_toio(ctx->dev->reg + RK_CRYPTO_AES_KEY_0, key, keylen); + memcpy(ctx->key, key, keylen); =20 return crypto_skcipher_setkey(ctx->fallback_tfm, key, keylen); } @@ -119,7 +119,7 @@ static int rk_des_setkey(struct crypto_skcipher *cipher, return err; =20 ctx->keylen =3D keylen; - memcpy_toio(ctx->dev->reg + RK_CRYPTO_TDES_KEY1_0, key, keylen); + memcpy(ctx->key, key, keylen); =20 return crypto_skcipher_setkey(ctx->fallback_tfm, key, keylen); } @@ -135,7 +135,8 @@ static int rk_tdes_setkey(struct crypto_skcipher *ciphe= r, return err; =20 ctx->keylen =3D keylen; - memcpy_toio(ctx->dev->reg + RK_CRYPTO_TDES_KEY1_0, key, keylen); + memcpy(ctx->key, key, keylen); + return crypto_skcipher_setkey(ctx->fallback_tfm, key, keylen); } =20 @@ -291,6 +292,7 @@ static void rk_ablk_hw_init(struct rk_crypto_info *dev) RK_CRYPTO_TDES_BYTESWAP_IV; CRYPTO_WRITE(dev, RK_CRYPTO_TDES_CTRL, rctx->mode); memcpy_toio(dev->reg + RK_CRYPTO_TDES_IV_0, req->iv, ivsize); + memcpy_toio(ctx->dev->reg + RK_CRYPTO_TDES_KEY1_0, ctx->key, ctx->keylen= ); conf_reg =3D RK_CRYPTO_DESSEL; } else { rctx->mode |=3D RK_CRYPTO_AES_FIFO_MODE | @@ -303,6 +305,7 @@ static void rk_ablk_hw_init(struct rk_crypto_info *dev) rctx->mode |=3D RK_CRYPTO_AES_256BIT_key; CRYPTO_WRITE(dev, RK_CRYPTO_AES_CTRL, rctx->mode); memcpy_toio(dev->reg + RK_CRYPTO_AES_IV_0, req->iv, ivsize); + memcpy_toio(ctx->dev->reg + RK_CRYPTO_AES_KEY_0, ctx->key, ctx->keylen); } conf_reg |=3D RK_CRYPTO_BYTESWAP_BTFIFO | RK_CRYPTO_BYTESWAP_BRFIFO; @@ -492,6 +495,7 @@ static void rk_ablk_exit_tfm(struct crypto_skcipher *tf= m) { struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 + memzero_explicit(ctx->key, ctx->keylen); free_page((unsigned long)ctx->dev->addr_vir); crypto_free_skcipher(ctx->fallback_tfm); } --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E3EFC433FE for ; Mon, 21 Mar 2022 20:08:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352979AbiCUUJz (ORCPT ); Mon, 21 Mar 2022 16:09:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352960AbiCUUJi (ORCPT ); Mon, 21 Mar 2022 16:09:38 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5EBC1042B2 for ; Mon, 21 Mar 2022 13:07:57 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id h16so8677495wmd.0 for ; Mon, 21 Mar 2022 13:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X5lhb7cXcJv4jCcoxcl/PiLSqbadaq/iBHsPS27oZOA=; b=LnvZ4zn9/PYHof4GepyVPmgh695fDqiVYvzlxQ/XxSIAD6ZnPjf6salmFirh1VX6NJ 9LYys5wg9rTMFQmcpBPW7naQ0jmhSnRplX+MIvLNz2xmcGfBkXXowj0NJvL7OTBcSm3E r9UNxsvNUysmz1DVzjFnsES2t+P3O4eQnNwr7mYT60ALV0+1mq1oeDf7Fw4lrKvZ+0ck vNo2v7S1ZDpAtGxk77J4AJiTIrZdFT3yAZdRO6NeEQ/t/sbcsNDuJGWNQ0hNhxnIvpfe J5pOw7De9vpaA8eLup4QLvy1iIlPFcHr3h9taD+n6amFJG4num0uzujdo8ZegwrBgVYK xpyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X5lhb7cXcJv4jCcoxcl/PiLSqbadaq/iBHsPS27oZOA=; b=x8lDrDOMLzIHpH0v5/O1F0W1/BT6Qv8l6d01PHg8BCjDgjuWzauYNG3S9YxI+Yk6OT mK7lLvPCj+GClJXVIfnbqtdh3X38sgUlyJg8qODi0jp91nJcMp2zDv1pH08qiD+i6LKE 7jXWt/5Bvm6+fGy2BP9uHiJuBrgHU5gELuGc/wvbLHfGl+PlanLfeWpcIC/HsVV0vkcO ryWRqX7fL4JO7n7Yz36s3YaN8eJRvqjQWCjyfMioq+LYt3oFAeqU8rI2WoC5Qr2etSWA mnYg2042Wz6DfwiVQSManZ8sb/krbLwXw0azkls3JgE7OmhFsU29Jbbmz3sPVP6fYVEm Cm/A== X-Gm-Message-State: AOAM530qeN9AfEd7ABO4as8eyab4iqdVgSK6mcMy8ArvLVqPd9dr2s7E iY5eT+gB9ZtLraccQPVX9tGrqQ== X-Google-Smtp-Source: ABdhPJyFJ7caJRr0Rt6jo/F3t4IL2P7r72gZo4MgqUYyBw3FJMLz4O8/qdahelDJ5jgGm1uNPUMBKA== X-Received: by 2002:a05:600c:4e53:b0:38c:987e:cdc with SMTP id e19-20020a05600c4e5300b0038c987e0cdcmr679825wmq.154.1647893276252; Mon, 21 Mar 2022 13:07:56 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:07:55 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 09/26] crypto: rockchip: remove non-aligned handling Date: Mon, 21 Mar 2022 20:07:22 +0000 Message-Id: <20220321200739.3572792-10-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Now driver have fallback for un-aligned cases, remove all code handling those cases. Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 69 +++++-------------- drivers/crypto/rockchip/rk3288_crypto.h | 4 -- drivers/crypto/rockchip/rk3288_crypto_ahash.c | 22 ++---- .../crypto/rockchip/rk3288_crypto_skcipher.c | 39 +++-------- 4 files changed, 31 insertions(+), 103 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index 4cff49b82983..b3db096e2ec2 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -88,63 +88,26 @@ static int rk_load_data(struct rk_crypto_info *dev, { unsigned int count; =20 - dev->aligned =3D dev->aligned ? - check_alignment(sg_src, sg_dst, dev->align_size) : - dev->aligned; - if (dev->aligned) { - count =3D min(dev->left_bytes, sg_src->length); - dev->left_bytes -=3D count; - - if (!dma_map_sg(dev->dev, sg_src, 1, DMA_TO_DEVICE)) { - dev_err(dev->dev, "[%s:%d] dma_map_sg(src) error\n", + count =3D min(dev->left_bytes, sg_src->length); + dev->left_bytes -=3D count; + + if (!dma_map_sg(dev->dev, sg_src, 1, DMA_TO_DEVICE)) { + dev_err(dev->dev, "[%s:%d] dma_map_sg(src) error\n", __func__, __LINE__); - return -EINVAL; - } - dev->addr_in =3D sg_dma_address(sg_src); + return -EINVAL; + } + dev->addr_in =3D sg_dma_address(sg_src); =20 - if (sg_dst) { - if (!dma_map_sg(dev->dev, sg_dst, 1, DMA_FROM_DEVICE)) { - dev_err(dev->dev, + if (sg_dst) { + if (!dma_map_sg(dev->dev, sg_dst, 1, DMA_FROM_DEVICE)) { + dev_err(dev->dev, "[%s:%d] dma_map_sg(dst) error\n", __func__, __LINE__); - dma_unmap_sg(dev->dev, sg_src, 1, - DMA_TO_DEVICE); - return -EINVAL; - } - dev->addr_out =3D sg_dma_address(sg_dst); - } - } else { - count =3D (dev->left_bytes > PAGE_SIZE) ? - PAGE_SIZE : dev->left_bytes; - - if (!sg_pcopy_to_buffer(dev->first, dev->src_nents, - dev->addr_vir, count, - dev->total - dev->left_bytes)) { - dev_err(dev->dev, "[%s:%d] pcopy err\n", - __func__, __LINE__); + dma_unmap_sg(dev->dev, sg_src, 1, + DMA_TO_DEVICE); return -EINVAL; } - dev->left_bytes -=3D count; - sg_init_one(&dev->sg_tmp, dev->addr_vir, count); - if (!dma_map_sg(dev->dev, &dev->sg_tmp, 1, DMA_TO_DEVICE)) { - dev_err(dev->dev, "[%s:%d] dma_map_sg(sg_tmp) error\n", - __func__, __LINE__); - return -ENOMEM; - } - dev->addr_in =3D sg_dma_address(&dev->sg_tmp); - - if (sg_dst) { - if (!dma_map_sg(dev->dev, &dev->sg_tmp, 1, - DMA_FROM_DEVICE)) { - dev_err(dev->dev, - "[%s:%d] dma_map_sg(sg_tmp) error\n", - __func__, __LINE__); - dma_unmap_sg(dev->dev, &dev->sg_tmp, 1, - DMA_TO_DEVICE); - return -ENOMEM; - } - dev->addr_out =3D sg_dma_address(&dev->sg_tmp); - } + dev->addr_out =3D sg_dma_address(sg_dst); } dev->count =3D count; return 0; @@ -154,11 +117,11 @@ static void rk_unload_data(struct rk_crypto_info *dev) { struct scatterlist *sg_in, *sg_out; =20 - sg_in =3D dev->aligned ? dev->sg_src : &dev->sg_tmp; + sg_in =3D dev->sg_src; dma_unmap_sg(dev->dev, sg_in, 1, DMA_TO_DEVICE); =20 if (dev->sg_dst) { - sg_out =3D dev->aligned ? dev->sg_dst : &dev->sg_tmp; + sg_out =3D dev->sg_dst; dma_unmap_sg(dev->dev, sg_out, 1, DMA_FROM_DEVICE); } } diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockc= hip/rk3288_crypto.h index 826508e4a0c3..d35b84071935 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.h +++ b/drivers/crypto/rockchip/rk3288_crypto.h @@ -204,12 +204,8 @@ struct rk_crypto_info { /* the public variable */ struct scatterlist *sg_src; struct scatterlist *sg_dst; - struct scatterlist sg_tmp; struct scatterlist *first; unsigned int left_bytes; - void *addr_vir; - int aligned; - int align_size; size_t src_nents; size_t dst_nents; unsigned int total; diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto= /rockchip/rk3288_crypto_ahash.c index 16009bb0bf16..c762e462eb57 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c @@ -236,8 +236,6 @@ static int rk_ahash_start(struct rk_crypto_info *dev) =20 dev->total =3D req->nbytes; dev->left_bytes =3D req->nbytes; - dev->aligned =3D 0; - dev->align_size =3D 4; dev->sg_dst =3D NULL; dev->sg_src =3D req->src; dev->first =3D req->src; @@ -272,15 +270,13 @@ static int rk_ahash_crypto_rx(struct rk_crypto_info *= dev) =20 dev->unload_data(dev); if (dev->left_bytes) { - if (dev->aligned) { - if (sg_is_last(dev->sg_src)) { - dev_warn(dev->dev, "[%s:%d], Lack of data\n", - __func__, __LINE__); - err =3D -ENOMEM; - goto out_rx; - } - dev->sg_src =3D sg_next(dev->sg_src); + if (sg_is_last(dev->sg_src)) { + dev_warn(dev->dev, "[%s:%d], Lack of data\n", + __func__, __LINE__); + err =3D -ENOMEM; + goto out_rx; } + dev->sg_src =3D sg_next(dev->sg_src); err =3D rk_ahash_set_data_start(dev); } else { /* @@ -318,11 +314,6 @@ static int rk_cra_hash_init(struct crypto_tfm *tfm) algt =3D container_of(alg, struct rk_crypto_tmp, alg.hash); =20 tctx->dev =3D algt->dev; - tctx->dev->addr_vir =3D (void *)__get_free_page(GFP_KERNEL); - if (!tctx->dev->addr_vir) { - dev_err(tctx->dev->dev, "failed to kmalloc for addr_vir\n"); - return -ENOMEM; - } tctx->dev->start =3D rk_ahash_start; tctx->dev->update =3D rk_ahash_crypto_rx; tctx->dev->complete =3D rk_ahash_crypto_complete; @@ -345,7 +336,6 @@ static void rk_cra_hash_exit(struct crypto_tfm *tfm) { struct rk_ahash_ctx *tctx =3D crypto_tfm_ctx(tfm); =20 - free_page((unsigned long)tctx->dev->addr_vir); crypto_free_ahash(tctx->fallback_tfm); } =20 diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/cry= pto/rockchip/rk3288_crypto_skcipher.c index 5a9ba7c0206d..1b449d8623c9 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c +++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c @@ -364,7 +364,6 @@ static int rk_ablk_start(struct rk_crypto_info *dev) dev->src_nents =3D sg_nents(req->src); dev->sg_dst =3D req->dst; dev->dst_nents =3D sg_nents(req->dst); - dev->aligned =3D 1; =20 spin_lock_irqsave(&dev->lock, flags); rk_ablk_hw_init(dev); @@ -384,13 +383,9 @@ static void rk_iv_copyback(struct rk_crypto_info *dev) =20 /* Update the IV buffer to contain the next IV for encryption mode. */ if (!(rctx->mode & RK_CRYPTO_DEC)) { - if (dev->aligned) { - memcpy(req->iv, sg_virt(dev->sg_dst) + - dev->sg_dst->length - ivsize, ivsize); - } else { - memcpy(req->iv, dev->addr_vir + - dev->count - ivsize, ivsize); - } + memcpy(req->iv, + sg_virt(dev->sg_dst) + dev->sg_dst->length - ivsize, + ivsize); } } =20 @@ -428,27 +423,16 @@ static int rk_ablk_rx(struct rk_crypto_info *dev) skcipher_request_cast(dev->async_req); =20 dev->unload_data(dev); - if (!dev->aligned) { - if (!sg_pcopy_from_buffer(req->dst, dev->dst_nents, - dev->addr_vir, dev->count, - dev->total - dev->left_bytes - - dev->count)) { - err =3D -EINVAL; - goto out_rx; - } - } if (dev->left_bytes) { rk_update_iv(dev); - if (dev->aligned) { - if (sg_is_last(dev->sg_src)) { - dev_err(dev->dev, "[%s:%d] Lack of data\n", + if (sg_is_last(dev->sg_src)) { + dev_err(dev->dev, "[%s:%d] Lack of data\n", __func__, __LINE__); - err =3D -ENOMEM; - goto out_rx; - } - dev->sg_src =3D sg_next(dev->sg_src); - dev->sg_dst =3D sg_next(dev->sg_dst); + err =3D -ENOMEM; + goto out_rx; } + dev->sg_src =3D sg_next(dev->sg_src); + dev->sg_dst =3D sg_next(dev->sg_dst); err =3D rk_set_data_start(dev); } else { rk_iv_copyback(dev); @@ -470,13 +454,9 @@ static int rk_ablk_init_tfm(struct crypto_skcipher *tf= m) algt =3D container_of(alg, struct rk_crypto_tmp, alg.skcipher); =20 ctx->dev =3D algt->dev; - ctx->dev->align_size =3D crypto_tfm_alg_alignmask(crypto_skcipher_tfm(tfm= )) + 1; ctx->dev->start =3D rk_ablk_start; ctx->dev->update =3D rk_ablk_rx; ctx->dev->complete =3D rk_crypto_complete; - ctx->dev->addr_vir =3D (char *)__get_free_page(GFP_KERNEL); - if (!ctx->dev->addr_vir) - return -ENOMEM; =20 ctx->fallback_tfm =3D crypto_alloc_skcipher(name, 0, CRYPTO_ALG_NEED_FALL= BACK); if (IS_ERR(ctx->fallback_tfm)) { @@ -496,7 +476,6 @@ static void rk_ablk_exit_tfm(struct crypto_skcipher *tf= m) struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 memzero_explicit(ctx->key, ctx->keylen); - free_page((unsigned long)ctx->dev->addr_vir); crypto_free_skcipher(ctx->fallback_tfm); } =20 --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B79DEC433EF for ; Mon, 21 Mar 2022 20:08:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353084AbiCUUKP (ORCPT ); Mon, 21 Mar 2022 16:10:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352901AbiCUUJi (ORCPT ); Mon, 21 Mar 2022 16:09:38 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30609104A4D for ; Mon, 21 Mar 2022 13:07:58 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id a1so20845640wrh.10 for ; Mon, 21 Mar 2022 13:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KQSaTYiOSI0TRAZD5ooTY/e9tL7fD5JOoDunX2Za/eU=; b=ILC/BhJpWqwWaMqsXonCVgbkIZbMuaIhwmjzFicPiqOmWFq8dnSjN3TPyTEors4RHB M4ehKlAl/NwyORNnah1b8VOmKg1UBIKvqsXJ2F0s3O2QhHZ8XnaaNyBhbJguSHte1X2v ipjtDmu8IorMThwGSDtDty7Zuz6yMHE69eLd9bteVuoTdkFSWeqIKU/nzKNwt+fmfvvp jtPQi7uvRKe5c+Gef419ThkrQf7NYNj7Cxb0Ht+BDylNhsk/K/wUOYBaGTEJjtYLrAmf mmycGiz4YLAhKmxz3f7d4trNCYH32uWC4rIUglHH3yXNFFOxoLgRNAQg1GafdlRmEV/m 4DMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KQSaTYiOSI0TRAZD5ooTY/e9tL7fD5JOoDunX2Za/eU=; b=4Yr/qFZH5aesTJKRIu58uHp1mmpxGe6hHuIzn4SPr3PTt4TsOonqB2289mp235ld1G dHmiXm/NW1WzR6Da2946TqypPKO9UBNddSkFTNG4GsIDTyJzMBgKuDLb5fn7O9onKpnk EHMcbAEkEu5wvd1wPFA2K7aTI4/3fIOE+eMm6td9oDyVN5EizlMy8mGItaM4/nOslv0C CXEIW2pR1c23b25lPEQcjToWx1x9W1YHNz/KyeQQZoXmxVL7KFNDHvYrHz+gglIhYpzK nlHUJCJ93wmTzNgcGkgUpmSpZOHMrnuA0B4dFoGDDJHEljOHnEK0myMBpHBFg6U1uSgJ ggIw== X-Gm-Message-State: AOAM530phW8hPwNlvoSQL1kO8kr1XsgEhXCwRav+F92P/nc2hCv5Og8u NMggq86J8tp+Tw7TeP6y00BuvQ== X-Google-Smtp-Source: ABdhPJzxwuzrbR8pSzX0qFY0ZVNYvjDnomOm1Uznk3pyN/rjumNx7s2OSrwPbsGXDAdyaSIVCF2ZpQ== X-Received: by 2002:adf:9123:0:b0:1ef:9b6d:60c1 with SMTP id j32-20020adf9123000000b001ef9b6d60c1mr19352162wrj.169.1647893277053; Mon, 21 Mar 2022 13:07:57 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:07:56 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 10/26] crypto: rockchip: rework by using crypto_engine Date: Mon, 21 Mar 2022 20:07:23 +0000 Message-Id: <20220321200739.3572792-11-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Instead of doing manual queue management, let's use the crypto/engine for that. In the same time, rework the requests handling to be easier to understand (and fix all bugs related to them). Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") Signed-off-by: Corentin Labbe --- drivers/crypto/Kconfig | 1 + drivers/crypto/rockchip/rk3288_crypto.c | 152 +---------- drivers/crypto/rockchip/rk3288_crypto.h | 39 +-- drivers/crypto/rockchip/rk3288_crypto_ahash.c | 144 +++++----- .../crypto/rockchip/rk3288_crypto_skcipher.c | 250 +++++++++--------- 5 files changed, 222 insertions(+), 364 deletions(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 84ab14afcbd9..d68cc2dc2bd5 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -789,6 +789,7 @@ config CRYPTO_DEV_ROCKCHIP select CRYPTO_CBC select CRYPTO_DES select CRYPTO_AES + select CRYPTO_ENGINE select CRYPTO_LIB_DES select CRYPTO_MD5 select CRYPTO_SHA1 diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index b3db096e2ec2..1afb65eee6c9 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -65,149 +65,24 @@ static void rk_crypto_disable_clk(struct rk_crypto_inf= o *dev) clk_disable_unprepare(dev->sclk); } =20 -static int check_alignment(struct scatterlist *sg_src, - struct scatterlist *sg_dst, - int align_mask) -{ - int in, out, align; - - in =3D IS_ALIGNED((uint32_t)sg_src->offset, 4) && - IS_ALIGNED((uint32_t)sg_src->length, align_mask); - if (!sg_dst) - return in; - out =3D IS_ALIGNED((uint32_t)sg_dst->offset, 4) && - IS_ALIGNED((uint32_t)sg_dst->length, align_mask); - align =3D in && out; - - return (align && (sg_src->length =3D=3D sg_dst->length)); -} - -static int rk_load_data(struct rk_crypto_info *dev, - struct scatterlist *sg_src, - struct scatterlist *sg_dst) -{ - unsigned int count; - - count =3D min(dev->left_bytes, sg_src->length); - dev->left_bytes -=3D count; - - if (!dma_map_sg(dev->dev, sg_src, 1, DMA_TO_DEVICE)) { - dev_err(dev->dev, "[%s:%d] dma_map_sg(src) error\n", - __func__, __LINE__); - return -EINVAL; - } - dev->addr_in =3D sg_dma_address(sg_src); - - if (sg_dst) { - if (!dma_map_sg(dev->dev, sg_dst, 1, DMA_FROM_DEVICE)) { - dev_err(dev->dev, - "[%s:%d] dma_map_sg(dst) error\n", - __func__, __LINE__); - dma_unmap_sg(dev->dev, sg_src, 1, - DMA_TO_DEVICE); - return -EINVAL; - } - dev->addr_out =3D sg_dma_address(sg_dst); - } - dev->count =3D count; - return 0; -} - -static void rk_unload_data(struct rk_crypto_info *dev) -{ - struct scatterlist *sg_in, *sg_out; - - sg_in =3D dev->sg_src; - dma_unmap_sg(dev->dev, sg_in, 1, DMA_TO_DEVICE); - - if (dev->sg_dst) { - sg_out =3D dev->sg_dst; - dma_unmap_sg(dev->dev, sg_out, 1, DMA_FROM_DEVICE); - } -} - static irqreturn_t rk_crypto_irq_handle(int irq, void *dev_id) { struct rk_crypto_info *dev =3D platform_get_drvdata(dev_id); u32 interrupt_status; =20 - spin_lock(&dev->lock); interrupt_status =3D CRYPTO_READ(dev, RK_CRYPTO_INTSTS); CRYPTO_WRITE(dev, RK_CRYPTO_INTSTS, interrupt_status); =20 + dev->status =3D 1; if (interrupt_status & 0x0a) { dev_warn(dev->dev, "DMA Error\n"); - dev->err =3D -EFAULT; + dev->status =3D 0; } - tasklet_schedule(&dev->done_task); + complete(&dev->complete); =20 - spin_unlock(&dev->lock); return IRQ_HANDLED; } =20 -static int rk_crypto_enqueue(struct rk_crypto_info *dev, - struct crypto_async_request *async_req) -{ - unsigned long flags; - int ret; - - spin_lock_irqsave(&dev->lock, flags); - ret =3D crypto_enqueue_request(&dev->queue, async_req); - if (dev->busy) { - spin_unlock_irqrestore(&dev->lock, flags); - return ret; - } - dev->busy =3D true; - spin_unlock_irqrestore(&dev->lock, flags); - tasklet_schedule(&dev->queue_task); - - return ret; -} - -static void rk_crypto_queue_task_cb(unsigned long data) -{ - struct rk_crypto_info *dev =3D (struct rk_crypto_info *)data; - struct crypto_async_request *async_req, *backlog; - unsigned long flags; - int err =3D 0; - - dev->err =3D 0; - spin_lock_irqsave(&dev->lock, flags); - backlog =3D crypto_get_backlog(&dev->queue); - async_req =3D crypto_dequeue_request(&dev->queue); - - if (!async_req) { - dev->busy =3D false; - spin_unlock_irqrestore(&dev->lock, flags); - return; - } - spin_unlock_irqrestore(&dev->lock, flags); - - if (backlog) { - backlog->complete(backlog, -EINPROGRESS); - backlog =3D NULL; - } - - dev->async_req =3D async_req; - err =3D dev->start(dev); - if (err) - dev->complete(dev->async_req, err); -} - -static void rk_crypto_done_task_cb(unsigned long data) -{ - struct rk_crypto_info *dev =3D (struct rk_crypto_info *)data; - - if (dev->err) { - dev->complete(dev->async_req, dev->err); - return; - } - - dev->err =3D dev->update(dev); - if (dev->err) - dev->complete(dev->async_req, dev->err); -} - static struct rk_crypto_tmp *rk_cipher_algs[] =3D { &rk_ecb_aes_alg, &rk_cbc_aes_alg, @@ -300,8 +175,6 @@ static int rk_crypto_probe(struct platform_device *pdev) if (err) goto err_crypto; =20 - spin_lock_init(&crypto_info->lock); - crypto_info->reg =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(crypto_info->reg)) { err =3D PTR_ERR(crypto_info->reg); @@ -351,17 +224,11 @@ static int rk_crypto_probe(struct platform_device *pd= ev) crypto_info->dev =3D &pdev->dev; platform_set_drvdata(pdev, crypto_info); =20 - tasklet_init(&crypto_info->queue_task, - rk_crypto_queue_task_cb, (unsigned long)crypto_info); - tasklet_init(&crypto_info->done_task, - rk_crypto_done_task_cb, (unsigned long)crypto_info); - crypto_init_queue(&crypto_info->queue, 50); + crypto_info->engine =3D crypto_engine_alloc_init(&pdev->dev, true); + crypto_engine_start(crypto_info->engine); + init_completion(&crypto_info->complete); =20 rk_crypto_enable_clk(crypto_info); - crypto_info->load_data =3D rk_load_data; - crypto_info->unload_data =3D rk_unload_data; - crypto_info->enqueue =3D rk_crypto_enqueue; - crypto_info->busy =3D false; =20 err =3D rk_crypto_register(crypto_info); if (err) { @@ -373,9 +240,9 @@ static int rk_crypto_probe(struct platform_device *pdev) return 0; =20 err_register_alg: - tasklet_kill(&crypto_info->queue_task); - tasklet_kill(&crypto_info->done_task); + crypto_engine_exit(crypto_info->engine); err_crypto: + dev_err(dev, "Crypto Accelerator not successfully registered\n"); return err; } =20 @@ -385,8 +252,7 @@ static int rk_crypto_remove(struct platform_device *pde= v) =20 rk_crypto_unregister(); rk_crypto_disable_clk(crypto_tmp); - tasklet_kill(&crypto_tmp->done_task); - tasklet_kill(&crypto_tmp->queue_task); + crypto_engine_exit(crypto_tmp->engine); return 0; } =20 diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockc= hip/rk3288_crypto.h index d35b84071935..c741e97057dc 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.h +++ b/drivers/crypto/rockchip/rk3288_crypto.h @@ -5,9 +5,11 @@ #include #include #include +#include #include #include #include +#include #include #include =20 @@ -193,39 +195,15 @@ struct rk_crypto_info { struct reset_control *rst; void __iomem *reg; int irq; - struct crypto_queue queue; - struct tasklet_struct queue_task; - struct tasklet_struct done_task; - struct crypto_async_request *async_req; - int err; - /* device lock */ - spinlock_t lock; - - /* the public variable */ - struct scatterlist *sg_src; - struct scatterlist *sg_dst; - struct scatterlist *first; - unsigned int left_bytes; - size_t src_nents; - size_t dst_nents; - unsigned int total; - unsigned int count; - dma_addr_t addr_in; - dma_addr_t addr_out; - bool busy; - int (*start)(struct rk_crypto_info *dev); - int (*update)(struct rk_crypto_info *dev); - void (*complete)(struct crypto_async_request *base, int err); - int (*load_data)(struct rk_crypto_info *dev, - struct scatterlist *sg_src, - struct scatterlist *sg_dst); - void (*unload_data)(struct rk_crypto_info *dev); - int (*enqueue)(struct rk_crypto_info *dev, - struct crypto_async_request *async_req); + + struct crypto_engine *engine; + struct completion complete; + int status; }; =20 /* the private variable of hash */ struct rk_ahash_ctx { + struct crypto_engine_ctx enginectx; struct rk_crypto_info *dev; /* for fallback */ struct crypto_ahash *fallback_tfm; @@ -235,10 +213,12 @@ struct rk_ahash_ctx { struct rk_ahash_rctx { struct ahash_request fallback_req; u32 mode; + int nrsg; }; =20 /* the private variable of cipher */ struct rk_cipher_ctx { + struct crypto_engine_ctx enginectx; struct rk_crypto_info *dev; unsigned int keylen; u32 key[AES_MAX_KEY_SIZE / 4]; @@ -247,6 +227,7 @@ struct rk_cipher_ctx { }; =20 struct rk_cipher_rctx { + u8 backup_iv[AES_BLOCK_SIZE]; u32 mode; struct skcipher_request fallback_req; // keep at the end }; diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto= /rockchip/rk3288_crypto_ahash.c index c762e462eb57..edd40e16a3f0 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c @@ -9,6 +9,7 @@ * Some ideas are from marvell/cesa.c and s5p-sss.c driver. */ #include +#include #include "rk3288_crypto.h" =20 /* @@ -72,16 +73,12 @@ static int zero_message_process(struct ahash_request *r= eq) return 0; } =20 -static void rk_ahash_crypto_complete(struct crypto_async_request *base, in= t err) +static void rk_ahash_reg_init(struct ahash_request *req) { - if (base->complete) - base->complete(base, err); -} - -static void rk_ahash_reg_init(struct rk_crypto_info *dev) -{ - struct ahash_request *req =3D ahash_request_cast(dev->async_req); struct rk_ahash_rctx *rctx =3D ahash_request_ctx(req); + struct crypto_ahash *tfm =3D crypto_ahash_reqtfm(req); + struct rk_ahash_ctx *tctx =3D crypto_ahash_ctx(tfm); + struct rk_crypto_info *dev =3D tctx->dev; int reg_status; =20 reg_status =3D CRYPTO_READ(dev, RK_CRYPTO_CTRL) | @@ -108,7 +105,7 @@ static void rk_ahash_reg_init(struct rk_crypto_info *de= v) RK_CRYPTO_BYTESWAP_BRFIFO | RK_CRYPTO_BYTESWAP_BTFIFO); =20 - CRYPTO_WRITE(dev, RK_CRYPTO_HASH_MSG_LEN, dev->total); + CRYPTO_WRITE(dev, RK_CRYPTO_HASH_MSG_LEN, req->nbytes); } =20 static int rk_ahash_init(struct ahash_request *req) @@ -206,44 +203,59 @@ static int rk_ahash_digest(struct ahash_request *req) =20 if (!req->nbytes) return zero_message_process(req); - else - return dev->enqueue(dev, &req->base); + + return crypto_transfer_hash_request_to_engine(dev->engine, req); } =20 -static void crypto_ahash_dma_start(struct rk_crypto_info *dev) +static void crypto_ahash_dma_start(struct rk_crypto_info *dev, struct scat= terlist *sg) { - CRYPTO_WRITE(dev, RK_CRYPTO_HRDMAS, dev->addr_in); - CRYPTO_WRITE(dev, RK_CRYPTO_HRDMAL, (dev->count + 3) / 4); + CRYPTO_WRITE(dev, RK_CRYPTO_HRDMAS, sg_dma_address(sg)); + CRYPTO_WRITE(dev, RK_CRYPTO_HRDMAL, sg_dma_len(sg) / 4); CRYPTO_WRITE(dev, RK_CRYPTO_CTRL, RK_CRYPTO_HASH_START | (RK_CRYPTO_HASH_START << 16)); } =20 -static int rk_ahash_set_data_start(struct rk_crypto_info *dev) +static int rk_hash_prepare(struct crypto_engine *engine, void *breq) +{ + struct ahash_request *areq =3D container_of(breq, struct ahash_request, b= ase); + struct crypto_ahash *tfm =3D crypto_ahash_reqtfm(areq); + struct rk_ahash_rctx *rctx =3D ahash_request_ctx(areq); + struct rk_ahash_ctx *tctx =3D crypto_ahash_ctx(tfm); + int ret; + + ret =3D dma_map_sg(tctx->dev->dev, areq->src, sg_nents(areq->src), DMA_TO= _DEVICE); + if (ret <=3D 0) + return -EINVAL; + + rctx->nrsg =3D ret; + + return 0; +} + +static int rk_hash_unprepare(struct crypto_engine *engine, void *breq) { - int err; + struct ahash_request *areq =3D container_of(breq, struct ahash_request, b= ase); + struct crypto_ahash *tfm =3D crypto_ahash_reqtfm(areq); + struct rk_ahash_rctx *rctx =3D ahash_request_ctx(areq); + struct rk_ahash_ctx *tctx =3D crypto_ahash_ctx(tfm); =20 - err =3D dev->load_data(dev, dev->sg_src, NULL); - if (!err) - crypto_ahash_dma_start(dev); - return err; + dma_unmap_sg(tctx->dev->dev, areq->src, rctx->nrsg, DMA_TO_DEVICE); + return 0; } =20 -static int rk_ahash_start(struct rk_crypto_info *dev) +static int rk_hash_run(struct crypto_engine *engine, void *breq) { - struct ahash_request *req =3D ahash_request_cast(dev->async_req); - struct crypto_ahash *tfm; - struct rk_ahash_rctx *rctx; - - dev->total =3D req->nbytes; - dev->left_bytes =3D req->nbytes; - dev->sg_dst =3D NULL; - dev->sg_src =3D req->src; - dev->first =3D req->src; - dev->src_nents =3D sg_nents(req->src); - rctx =3D ahash_request_ctx(req); + struct ahash_request *areq =3D container_of(breq, struct ahash_request, b= ase); + struct crypto_ahash *tfm =3D crypto_ahash_reqtfm(areq); + struct rk_ahash_rctx *rctx =3D ahash_request_ctx(areq); + struct rk_ahash_ctx *tctx =3D crypto_ahash_ctx(tfm); + struct scatterlist *sg =3D areq->src; + int err =3D 0; + int i; + u32 v; + rctx->mode =3D 0; =20 - tfm =3D crypto_ahash_reqtfm(req); switch (crypto_ahash_digestsize(tfm)) { case SHA1_DIGEST_SIZE: rctx->mode =3D RK_CRYPTO_HASH_SHA1; @@ -255,30 +267,26 @@ static int rk_ahash_start(struct rk_crypto_info *dev) rctx->mode =3D RK_CRYPTO_HASH_MD5; break; default: - return -EINVAL; + err =3D -EINVAL; + goto theend; } =20 - rk_ahash_reg_init(dev); - return rk_ahash_set_data_start(dev); -} + rk_ahash_reg_init(areq); =20 -static int rk_ahash_crypto_rx(struct rk_crypto_info *dev) -{ - int err =3D 0; - struct ahash_request *req =3D ahash_request_cast(dev->async_req); - struct crypto_ahash *tfm; - - dev->unload_data(dev); - if (dev->left_bytes) { - if (sg_is_last(dev->sg_src)) { - dev_warn(dev->dev, "[%s:%d], Lack of data\n", - __func__, __LINE__); - err =3D -ENOMEM; - goto out_rx; + while (sg) { + reinit_completion(&tctx->dev->complete); + tctx->dev->status =3D 0; + crypto_ahash_dma_start(tctx->dev, sg); + wait_for_completion_interruptible_timeout(&tctx->dev->complete, + msecs_to_jiffies(2000)); + if (!tctx->dev->status) { + dev_err(tctx->dev->dev, "DMA timeout\n"); + err =3D -EFAULT; + goto theend; } - dev->sg_src =3D sg_next(dev->sg_src); - err =3D rk_ahash_set_data_start(dev); - } else { + sg =3D sg_next(sg); + } + /* * it will take some time to process date after last dma * transmission. @@ -289,18 +297,20 @@ static int rk_ahash_crypto_rx(struct rk_crypto_info *= dev) * efficiency, and make it response quickly when dma * complete. */ - while (!CRYPTO_READ(dev, RK_CRYPTO_HASH_STS)) - udelay(10); - - tfm =3D crypto_ahash_reqtfm(req); - memcpy_fromio(req->result, dev->reg + RK_CRYPTO_HASH_DOUT_0, - crypto_ahash_digestsize(tfm)); - dev->complete(dev->async_req, 0); - tasklet_schedule(&dev->queue_task); + while (!CRYPTO_READ(tctx->dev, RK_CRYPTO_HASH_STS)) + udelay(10); + + for (i =3D 0; i < crypto_ahash_digestsize(tfm) / 4; i++) { + v =3D readl(tctx->dev->reg + RK_CRYPTO_HASH_DOUT_0 + i * 4); + put_unaligned_le32(v, areq->result + i * 4); } =20 -out_rx: - return err; +theend: + local_bh_disable(); + crypto_finalize_hash_request(engine, breq, err); + local_bh_enable(); + + return 0; } =20 static int rk_cra_hash_init(struct crypto_tfm *tfm) @@ -314,9 +324,6 @@ static int rk_cra_hash_init(struct crypto_tfm *tfm) algt =3D container_of(alg, struct rk_crypto_tmp, alg.hash); =20 tctx->dev =3D algt->dev; - tctx->dev->start =3D rk_ahash_start; - tctx->dev->update =3D rk_ahash_crypto_rx; - tctx->dev->complete =3D rk_ahash_crypto_complete; =20 /* for fallback */ tctx->fallback_tfm =3D crypto_alloc_ahash(alg_name, 0, @@ -325,10 +332,15 @@ static int rk_cra_hash_init(struct crypto_tfm *tfm) dev_err(tctx->dev->dev, "Could not load fallback driver.\n"); return PTR_ERR(tctx->fallback_tfm); } + crypto_ahash_set_reqsize(__crypto_ahash_cast(tfm), sizeof(struct rk_ahash_rctx) + crypto_ahash_reqsize(tctx->fallback_tfm)); =20 + tctx->enginectx.op.do_one_request =3D rk_hash_run; + tctx->enginectx.op.prepare_request =3D rk_hash_prepare; + tctx->enginectx.op.unprepare_request =3D rk_hash_unprepare; + return 0; } =20 diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/cry= pto/rockchip/rk3288_crypto_skcipher.c index 1b449d8623c9..bd83aedc064f 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c +++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c @@ -9,6 +9,7 @@ * Some ideas are from marvell-cesa.c and s5p-sss.c driver. */ #include +#include #include "rk3288_crypto.h" =20 #define RK_CRYPTO_DEC BIT(0) @@ -78,19 +79,15 @@ static int rk_cipher_fallback(struct skcipher_request *= areq) return err; } =20 -static void rk_crypto_complete(struct crypto_async_request *base, int err) -{ - if (base->complete) - base->complete(base, err); -} - static int rk_handle_req(struct rk_crypto_info *dev, struct skcipher_request *req) { + struct crypto_engine *engine =3D dev->engine; + if (rk_cipher_need_fallback(req)) return rk_cipher_fallback(req); =20 - return dev->enqueue(dev, &req->base); + return crypto_transfer_skcipher_request_to_engine(engine, req); } =20 static int rk_aes_setkey(struct crypto_skcipher *cipher, @@ -273,25 +270,21 @@ static int rk_des3_ede_cbc_decrypt(struct skcipher_re= quest *req) return rk_handle_req(dev, req); } =20 -static void rk_ablk_hw_init(struct rk_crypto_info *dev) +static void rk_ablk_hw_init(struct rk_crypto_info *dev, struct skcipher_re= quest *req) { - struct skcipher_request *req =3D - skcipher_request_cast(dev->async_req); struct crypto_skcipher *cipher =3D crypto_skcipher_reqtfm(req); struct crypto_tfm *tfm =3D crypto_skcipher_tfm(cipher); struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(cipher); - u32 ivsize, block, conf_reg =3D 0; + u32 block, conf_reg =3D 0; =20 block =3D crypto_tfm_alg_blocksize(tfm); - ivsize =3D crypto_skcipher_ivsize(cipher); =20 if (block =3D=3D DES_BLOCK_SIZE) { rctx->mode |=3D RK_CRYPTO_TDES_FIFO_MODE | RK_CRYPTO_TDES_BYTESWAP_KEY | RK_CRYPTO_TDES_BYTESWAP_IV; CRYPTO_WRITE(dev, RK_CRYPTO_TDES_CTRL, rctx->mode); - memcpy_toio(dev->reg + RK_CRYPTO_TDES_IV_0, req->iv, ivsize); memcpy_toio(ctx->dev->reg + RK_CRYPTO_TDES_KEY1_0, ctx->key, ctx->keylen= ); conf_reg =3D RK_CRYPTO_DESSEL; } else { @@ -304,7 +297,6 @@ static void rk_ablk_hw_init(struct rk_crypto_info *dev) else if (ctx->keylen =3D=3D AES_KEYSIZE_256) rctx->mode |=3D RK_CRYPTO_AES_256BIT_key; CRYPTO_WRITE(dev, RK_CRYPTO_AES_CTRL, rctx->mode); - memcpy_toio(dev->reg + RK_CRYPTO_AES_IV_0, req->iv, ivsize); memcpy_toio(ctx->dev->reg + RK_CRYPTO_AES_KEY_0, ctx->key, ctx->keylen); } conf_reg |=3D RK_CRYPTO_BYTESWAP_BTFIFO | @@ -314,133 +306,140 @@ static void rk_ablk_hw_init(struct rk_crypto_info *= dev) RK_CRYPTO_BCDMA_ERR_ENA | RK_CRYPTO_BCDMA_DONE_ENA); } =20 -static void crypto_dma_start(struct rk_crypto_info *dev) +static void crypto_dma_start(struct rk_crypto_info *dev, + struct scatterlist *sgs, + struct scatterlist *sgd, unsigned int todo) { - CRYPTO_WRITE(dev, RK_CRYPTO_BRDMAS, dev->addr_in); - CRYPTO_WRITE(dev, RK_CRYPTO_BRDMAL, dev->count / 4); - CRYPTO_WRITE(dev, RK_CRYPTO_BTDMAS, dev->addr_out); + CRYPTO_WRITE(dev, RK_CRYPTO_BRDMAS, sg_dma_address(sgs)); + CRYPTO_WRITE(dev, RK_CRYPTO_BRDMAL, todo); + CRYPTO_WRITE(dev, RK_CRYPTO_BTDMAS, sg_dma_address(sgd)); CRYPTO_WRITE(dev, RK_CRYPTO_CTRL, RK_CRYPTO_BLOCK_START | _SBF(RK_CRYPTO_BLOCK_START, 16)); } =20 -static int rk_set_data_start(struct rk_crypto_info *dev) +static int rk_cipher_run(struct crypto_engine *engine, void *async_req) { - int err; - struct skcipher_request *req =3D - skcipher_request_cast(dev->async_req); - struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); - struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); + struct skcipher_request *areq =3D container_of(async_req, struct skcipher= _request, base); + struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(areq); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); - u32 ivsize =3D crypto_skcipher_ivsize(tfm); - u8 *src_last_blk =3D page_address(sg_page(dev->sg_src)) + - dev->sg_src->offset + dev->sg_src->length - ivsize; - - /* Store the iv that need to be updated in chain mode. - * And update the IV buffer to contain the next IV for decryption mode. - */ - if (rctx->mode & RK_CRYPTO_DEC) { - memcpy(ctx->iv, src_last_blk, ivsize); - sg_pcopy_to_buffer(dev->first, dev->src_nents, req->iv, - ivsize, dev->total - ivsize); - } - - err =3D dev->load_data(dev, dev->sg_src, dev->sg_dst); - if (!err) - crypto_dma_start(dev); - return err; -} - -static int rk_ablk_start(struct rk_crypto_info *dev) -{ - struct skcipher_request *req =3D - skcipher_request_cast(dev->async_req); - unsigned long flags; + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(areq); + struct scatterlist *sgs, *sgd; int err =3D 0; + int n =3D 0; + int ivsize =3D crypto_skcipher_ivsize(tfm); + int offset; + u8 iv[AES_BLOCK_SIZE]; + u8 biv[AES_BLOCK_SIZE]; + u8 *ivtouse =3D areq->iv; + unsigned int len =3D areq->cryptlen; + unsigned int todo; + + ivsize =3D crypto_skcipher_ivsize(tfm); + if (areq->iv && crypto_skcipher_ivsize(tfm) > 0) { + if (rctx->mode & RK_CRYPTO_DEC) { + offset =3D areq->cryptlen - ivsize; + scatterwalk_map_and_copy(rctx->backup_iv, areq->src, + offset, ivsize, 0); + } + } =20 - dev->left_bytes =3D req->cryptlen; - dev->total =3D req->cryptlen; - dev->sg_src =3D req->src; - dev->first =3D req->src; - dev->src_nents =3D sg_nents(req->src); - dev->sg_dst =3D req->dst; - dev->dst_nents =3D sg_nents(req->dst); - - spin_lock_irqsave(&dev->lock, flags); - rk_ablk_hw_init(dev); - err =3D rk_set_data_start(dev); - spin_unlock_irqrestore(&dev->lock, flags); - return err; -} + sgs =3D areq->src; + sgd =3D areq->dst; =20 -static void rk_iv_copyback(struct rk_crypto_info *dev) -{ - struct skcipher_request *req =3D - skcipher_request_cast(dev->async_req); - struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); - struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); - struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); - u32 ivsize =3D crypto_skcipher_ivsize(tfm); + while (sgs && sgd && len) { + if (!sgs->length) { + sgs =3D sg_next(sgs); + sgd =3D sg_next(sgd); + continue; + } + if (rctx->mode & RK_CRYPTO_DEC) { + /* we backup last block of source to be used as IV at next step */ + offset =3D sgs->length - ivsize; + scatterwalk_map_and_copy(biv, sgs, offset, ivsize, 0); + } + if (sgs =3D=3D sgd) { + err =3D dma_map_sg(ctx->dev->dev, sgs, 1, DMA_BIDIRECTIONAL); + if (err <=3D 0) { + err =3D -EINVAL; + goto theend_iv; + } + } else { + err =3D dma_map_sg(ctx->dev->dev, sgs, 1, DMA_TO_DEVICE); + if (err <=3D 0) { + err =3D -EINVAL; + goto theend_iv; + } + err =3D dma_map_sg(ctx->dev->dev, sgd, 1, DMA_FROM_DEVICE); + if (err <=3D 0) { + err =3D -EINVAL; + goto theend_sgs; + } + } + err =3D 0; + rk_ablk_hw_init(ctx->dev, areq); + if (ivsize) { + if (ivsize =3D=3D DES_BLOCK_SIZE) + memcpy_toio(ctx->dev->reg + RK_CRYPTO_TDES_IV_0, ivtouse, ivsize); + else + memcpy_toio(ctx->dev->reg + RK_CRYPTO_AES_IV_0, ivtouse, ivsize); + } + reinit_completion(&ctx->dev->complete); + ctx->dev->status =3D 0; =20 - /* Update the IV buffer to contain the next IV for encryption mode. */ - if (!(rctx->mode & RK_CRYPTO_DEC)) { - memcpy(req->iv, - sg_virt(dev->sg_dst) + dev->sg_dst->length - ivsize, - ivsize); + todo =3D min(sg_dma_len(sgs), len); + len -=3D todo; + crypto_dma_start(ctx->dev, sgs, sgd, todo / 4); + wait_for_completion_interruptible_timeout(&ctx->dev->complete, + msecs_to_jiffies(2000)); + if (!ctx->dev->status) { + dev_err(ctx->dev->dev, "DMA timeout\n"); + err =3D -EFAULT; + goto theend; + } + if (sgs =3D=3D sgd) { + dma_unmap_sg(ctx->dev->dev, sgs, 1, DMA_BIDIRECTIONAL); + } else { + dma_unmap_sg(ctx->dev->dev, sgs, 1, DMA_TO_DEVICE); + dma_unmap_sg(ctx->dev->dev, sgd, 1, DMA_FROM_DEVICE); + } + if (rctx->mode & RK_CRYPTO_DEC) { + memcpy(iv, biv, ivsize); + ivtouse =3D iv; + } else { + offset =3D sgd->length - ivsize; + scatterwalk_map_and_copy(iv, sgd, offset, ivsize, 0); + ivtouse =3D iv; + } + sgs =3D sg_next(sgs); + sgd =3D sg_next(sgd); + n++; } -} - -static void rk_update_iv(struct rk_crypto_info *dev) -{ - struct skcipher_request *req =3D - skcipher_request_cast(dev->async_req); - struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); - struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); - struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(tfm); - u32 ivsize =3D crypto_skcipher_ivsize(tfm); - u8 *new_iv =3D NULL; =20 - if (rctx->mode & RK_CRYPTO_DEC) { - new_iv =3D ctx->iv; - } else { - new_iv =3D page_address(sg_page(dev->sg_dst)) + - dev->sg_dst->offset + dev->sg_dst->length - ivsize; + if (areq->iv && ivsize > 0) { + offset =3D areq->cryptlen - ivsize; + if (rctx->mode & RK_CRYPTO_DEC) { + memcpy(areq->iv, rctx->backup_iv, ivsize); + memzero_explicit(rctx->backup_iv, ivsize); + } else { + scatterwalk_map_and_copy(areq->iv, areq->dst, offset, + ivsize, 0); + } } =20 - if (ivsize =3D=3D DES_BLOCK_SIZE) - memcpy_toio(dev->reg + RK_CRYPTO_TDES_IV_0, new_iv, ivsize); - else if (ivsize =3D=3D AES_BLOCK_SIZE) - memcpy_toio(dev->reg + RK_CRYPTO_AES_IV_0, new_iv, ivsize); -} +theend: + local_bh_disable(); + crypto_finalize_skcipher_request(engine, areq, err); + local_bh_enable(); + return 0; =20 -/* return: - * true some err was occurred - * fault no err, continue - */ -static int rk_ablk_rx(struct rk_crypto_info *dev) -{ - int err =3D 0; - struct skcipher_request *req =3D - skcipher_request_cast(dev->async_req); - - dev->unload_data(dev); - if (dev->left_bytes) { - rk_update_iv(dev); - if (sg_is_last(dev->sg_src)) { - dev_err(dev->dev, "[%s:%d] Lack of data\n", - __func__, __LINE__); - err =3D -ENOMEM; - goto out_rx; - } - dev->sg_src =3D sg_next(dev->sg_src); - dev->sg_dst =3D sg_next(dev->sg_dst); - err =3D rk_set_data_start(dev); +theend_sgs: + if (sgs =3D=3D sgd) { + dma_unmap_sg(ctx->dev->dev, sgs, 1, DMA_BIDIRECTIONAL); } else { - rk_iv_copyback(dev); - /* here show the calculation is over without any err */ - dev->complete(dev->async_req, 0); - tasklet_schedule(&dev->queue_task); + dma_unmap_sg(ctx->dev->dev, sgs, 1, DMA_TO_DEVICE); + dma_unmap_sg(ctx->dev->dev, sgd, 1, DMA_FROM_DEVICE); } -out_rx: +theend_iv: return err; } =20 @@ -454,9 +453,6 @@ static int rk_ablk_init_tfm(struct crypto_skcipher *tfm) algt =3D container_of(alg, struct rk_crypto_tmp, alg.skcipher); =20 ctx->dev =3D algt->dev; - ctx->dev->start =3D rk_ablk_start; - ctx->dev->update =3D rk_ablk_rx; - ctx->dev->complete =3D rk_crypto_complete; =20 ctx->fallback_tfm =3D crypto_alloc_skcipher(name, 0, CRYPTO_ALG_NEED_FALL= BACK); if (IS_ERR(ctx->fallback_tfm)) { @@ -468,6 +464,8 @@ static int rk_ablk_init_tfm(struct crypto_skcipher *tfm) tfm->reqsize =3D sizeof(struct rk_cipher_rctx) + crypto_skcipher_reqsize(ctx->fallback_tfm); =20 + ctx->enginectx.op.do_one_request =3D rk_cipher_run; + return 0; } =20 --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9BAC433EF for ; Mon, 21 Mar 2022 20:08:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353010AbiCUUKJ (ORCPT ); Mon, 21 Mar 2022 16:10:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352964AbiCUUJi (ORCPT ); Mon, 21 Mar 2022 16:09:38 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD33C10505F for ; Mon, 21 Mar 2022 13:07:59 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id h4so4253884wrc.13 for ; Mon, 21 Mar 2022 13:07:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rBu6j0w04IfSqWI+ftLtxGPBWDOHCHmSIcBEO9bL8NQ=; b=A+Y+WHeebMeeJ9PSJzeFR+is7hiZhmAPTd7FH71piFGyX60V6+23FXXYdlbamFR2E0 pEtnYEs8ZyF5HGWwfxnNw/BMgQDO9QVYsTZy/S3IBwTVOxbPrrSGPNNLv0K25+i7TY63 8usYdzdO410NuhI6H34Nl+ifw4O4REH2kT/8Df2xVCCkUF3oYDBufYVtDtr2nvIqtHXu TbPN7/IsFaeu9SWNZCsLiMSnvBfVJ+NdhRgOBirDuzzuR4WL0yO4Ofdl3r/IDF3FXAWr oOms/TKo/jYvRGgr823FjqLMT8irXwun0s/aHi1qR1XKj0Vmgqv8LAZwCb5oKLUvhPUC LVjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rBu6j0w04IfSqWI+ftLtxGPBWDOHCHmSIcBEO9bL8NQ=; b=2W/CuaoiA7aMTPyNuFAxO23g3Eu7TnYiIjBRycsqI/7Z59e6ocaH1LBnNebMAI5FY/ dYIam2TK74t23MgnYdKuBw5D5RDVFicjTI3vP7Nvwj0kxBzjpv0Y6vzNGhFHFZY4WB+q hvm/azxdfhjNQ55+BbGZ7/1qhsXuiPnvZo+Q6xRiA9Es+O9QnK/AslgYPrzYfR4j8MEF WGNu8t2Jy9llz2kphGiSTUx/6NMpzEUuLVtScb3Hw797iGQHYGfIs3aFElV8jNv0xQ64 GCREhUrqP+iQ1JOH8OFYbSWsuHsmFyL4YANGck7WuvxCLVAsrgQ90n5nLtdcVHuNZrI6 JAGw== X-Gm-Message-State: AOAM532BDvwDeb0ISyHM+U0SIOruJZ8DkYlvy/y2NWHozZph0ZAjULw5 wbSqcEZ+qBWeQBpHF4Z3MCtXlA== X-Google-Smtp-Source: ABdhPJwI0yEgoLCvpKyIxf6bNypCv0hJnD6wzE8Gok4Iy9rRePqWrvltYy8zh2m/TpSrKTbdNixIRA== X-Received: by 2002:adf:f4ce:0:b0:203:fb72:8709 with SMTP id h14-20020adff4ce000000b00203fb728709mr12641388wrp.28.1647893277874; Mon, 21 Mar 2022 13:07:57 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:07:57 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 11/26] crypto: rockchip: rewrite type Date: Mon, 21 Mar 2022 20:07:24 +0000 Message-Id: <20220321200739.3572792-12-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Instead of using a custom type for classify algorithms, let's just use already defined ones. And let's made a bit more verbose about what is registered. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 26 +++++++++++++------ drivers/crypto/rockchip/rk3288_crypto.h | 7 +---- drivers/crypto/rockchip/rk3288_crypto_ahash.c | 6 ++--- .../crypto/rockchip/rk3288_crypto_skcipher.c | 12 ++++----- 4 files changed, 28 insertions(+), 23 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index 1afb65eee6c9..8f9664acc78d 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -102,12 +102,22 @@ static int rk_crypto_register(struct rk_crypto_info *= crypto_info) =20 for (i =3D 0; i < ARRAY_SIZE(rk_cipher_algs); i++) { rk_cipher_algs[i]->dev =3D crypto_info; - if (rk_cipher_algs[i]->type =3D=3D ALG_TYPE_CIPHER) - err =3D crypto_register_skcipher( - &rk_cipher_algs[i]->alg.skcipher); - else - err =3D crypto_register_ahash( - &rk_cipher_algs[i]->alg.hash); + switch (rk_cipher_algs[i]->type) { + case CRYPTO_ALG_TYPE_SKCIPHER: + dev_info(crypto_info->dev, "Register %s as %s\n", + rk_cipher_algs[i]->alg.skcipher.base.cra_name, + rk_cipher_algs[i]->alg.skcipher.base.cra_driver_name); + err =3D crypto_register_skcipher(&rk_cipher_algs[i]->alg.skcipher); + break; + case CRYPTO_ALG_TYPE_AHASH: + dev_info(crypto_info->dev, "Register %s as %s\n", + rk_cipher_algs[i]->alg.hash.halg.base.cra_name, + rk_cipher_algs[i]->alg.hash.halg.base.cra_driver_name); + err =3D crypto_register_ahash(&rk_cipher_algs[i]->alg.hash); + break; + default: + dev_err(crypto_info->dev, "unknown algorithm\n"); + } if (err) goto err_cipher_algs; } @@ -115,7 +125,7 @@ static int rk_crypto_register(struct rk_crypto_info *cr= ypto_info) =20 err_cipher_algs: for (k =3D 0; k < i; k++) { - if (rk_cipher_algs[i]->type =3D=3D ALG_TYPE_CIPHER) + if (rk_cipher_algs[i]->type =3D=3D CRYPTO_ALG_TYPE_SKCIPHER) crypto_unregister_skcipher(&rk_cipher_algs[k]->alg.skcipher); else crypto_unregister_ahash(&rk_cipher_algs[i]->alg.hash); @@ -128,7 +138,7 @@ static void rk_crypto_unregister(void) unsigned int i; =20 for (i =3D 0; i < ARRAY_SIZE(rk_cipher_algs); i++) { - if (rk_cipher_algs[i]->type =3D=3D ALG_TYPE_CIPHER) + if (rk_cipher_algs[i]->type =3D=3D CRYPTO_ALG_TYPE_SKCIPHER) crypto_unregister_skcipher(&rk_cipher_algs[i]->alg.skcipher); else crypto_unregister_ahash(&rk_cipher_algs[i]->alg.hash); diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockc= hip/rk3288_crypto.h index c741e97057dc..99b93841fbff 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.h +++ b/drivers/crypto/rockchip/rk3288_crypto.h @@ -232,18 +232,13 @@ struct rk_cipher_rctx { struct skcipher_request fallback_req; // keep at the end }; =20 -enum alg_type { - ALG_TYPE_HASH, - ALG_TYPE_CIPHER, -}; - struct rk_crypto_tmp { + u32 type; struct rk_crypto_info *dev; union { struct skcipher_alg skcipher; struct ahash_alg hash; } alg; - enum alg_type type; }; =20 extern struct rk_crypto_tmp rk_ecb_aes_alg; diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto= /rockchip/rk3288_crypto_ahash.c index edd40e16a3f0..d08e2438d356 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c @@ -352,7 +352,7 @@ static void rk_cra_hash_exit(struct crypto_tfm *tfm) } =20 struct rk_crypto_tmp rk_ahash_sha1 =3D { - .type =3D ALG_TYPE_HASH, + .type =3D CRYPTO_ALG_TYPE_AHASH, .alg.hash =3D { .init =3D rk_ahash_init, .update =3D rk_ahash_update, @@ -382,7 +382,7 @@ struct rk_crypto_tmp rk_ahash_sha1 =3D { }; =20 struct rk_crypto_tmp rk_ahash_sha256 =3D { - .type =3D ALG_TYPE_HASH, + .type =3D CRYPTO_ALG_TYPE_AHASH, .alg.hash =3D { .init =3D rk_ahash_init, .update =3D rk_ahash_update, @@ -412,7 +412,7 @@ struct rk_crypto_tmp rk_ahash_sha256 =3D { }; =20 struct rk_crypto_tmp rk_ahash_md5 =3D { - .type =3D ALG_TYPE_HASH, + .type =3D CRYPTO_ALG_TYPE_AHASH, .alg.hash =3D { .init =3D rk_ahash_init, .update =3D rk_ahash_update, diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/cry= pto/rockchip/rk3288_crypto_skcipher.c index bd83aedc064f..19bb9a9576d8 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c +++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c @@ -478,7 +478,7 @@ static void rk_ablk_exit_tfm(struct crypto_skcipher *tf= m) } =20 struct rk_crypto_tmp rk_ecb_aes_alg =3D { - .type =3D ALG_TYPE_CIPHER, + .type =3D CRYPTO_ALG_TYPE_SKCIPHER, .alg.skcipher =3D { .base.cra_name =3D "ecb(aes)", .base.cra_driver_name =3D "ecb-aes-rk", @@ -500,7 +500,7 @@ struct rk_crypto_tmp rk_ecb_aes_alg =3D { }; =20 struct rk_crypto_tmp rk_cbc_aes_alg =3D { - .type =3D ALG_TYPE_CIPHER, + .type =3D CRYPTO_ALG_TYPE_SKCIPHER, .alg.skcipher =3D { .base.cra_name =3D "cbc(aes)", .base.cra_driver_name =3D "cbc-aes-rk", @@ -523,7 +523,7 @@ struct rk_crypto_tmp rk_cbc_aes_alg =3D { }; =20 struct rk_crypto_tmp rk_ecb_des_alg =3D { - .type =3D ALG_TYPE_CIPHER, + .type =3D CRYPTO_ALG_TYPE_SKCIPHER, .alg.skcipher =3D { .base.cra_name =3D "ecb(des)", .base.cra_driver_name =3D "ecb-des-rk", @@ -545,7 +545,7 @@ struct rk_crypto_tmp rk_ecb_des_alg =3D { }; =20 struct rk_crypto_tmp rk_cbc_des_alg =3D { - .type =3D ALG_TYPE_CIPHER, + .type =3D CRYPTO_ALG_TYPE_SKCIPHER, .alg.skcipher =3D { .base.cra_name =3D "cbc(des)", .base.cra_driver_name =3D "cbc-des-rk", @@ -568,7 +568,7 @@ struct rk_crypto_tmp rk_cbc_des_alg =3D { }; =20 struct rk_crypto_tmp rk_ecb_des3_ede_alg =3D { - .type =3D ALG_TYPE_CIPHER, + .type =3D CRYPTO_ALG_TYPE_SKCIPHER, .alg.skcipher =3D { .base.cra_name =3D "ecb(des3_ede)", .base.cra_driver_name =3D "ecb-des3-ede-rk", @@ -590,7 +590,7 @@ struct rk_crypto_tmp rk_ecb_des3_ede_alg =3D { }; =20 struct rk_crypto_tmp rk_cbc_des3_ede_alg =3D { - .type =3D ALG_TYPE_CIPHER, + .type =3D CRYPTO_ALG_TYPE_SKCIPHER, .alg.skcipher =3D { .base.cra_name =3D "cbc(des3_ede)", .base.cra_driver_name =3D "cbc-des3-ede-rk", --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 771AFC433FE for ; Mon, 21 Mar 2022 20:09:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348011AbiCUUKd (ORCPT ); Mon, 21 Mar 2022 16:10:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352982AbiCUUJl (ORCPT ); Mon, 21 Mar 2022 16:09:41 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F245C106628 for ; Mon, 21 Mar 2022 13:08:00 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id p184-20020a1c29c1000000b0037f76d8b484so168796wmp.5 for ; Mon, 21 Mar 2022 13:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AKRbYqcsDyjIoHLD4o9ziO8ejE2hsGzM+UDz7GoR584=; b=UbzwzD/wt+a4pYrJzouMBVRpAHs4fC8vm/+m2rG4BDtB0xc4rwektdtayVt2WHxato FGXDgSubpdXS4vPs6qsmTHLiQOYhLJvmZPDIzo2NmDzbZxWoivu4cMSK3afIvJQfBeS7 Q1vL8JV+0JBV+ENHH6UrahiVMrtUl2rRdx5/rqz3PyKh/DguMJiAQLjSSTUbcOQaYt2J F5ZCqFAPDQjChK/hjFRAKztvBTIfRzDHWm59cRIcKRQHpsKOZyN/1GdiEhZHKJ2gUx0p 100QsCDsk+XkmU7oPHhtXTwyKvkwz5ebbS6qQluqZwROcXLp4Zoi8JzNI7ChGkyxj0/F +P1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AKRbYqcsDyjIoHLD4o9ziO8ejE2hsGzM+UDz7GoR584=; b=M8VTl3US4aFMztjWjP/YaQPj9AMNUI5GUCK53ALSC4C+V4s1lu+Mx4yU/k7BgcEpmu Qh7qGOY+3Q1kANZmvCYLEhslXUgmmqQVug4IdZK+iaGc4GaOZjVHoYrft4Y8GxytMXp6 a5hGR/k8qyU+nb8v2Zfv6FDUvy8j8BHKKfEnQLhayJwEVXA3k9fx+vgis9dkenvVU8ac VO75H9E+z4tWIaVk9sbSxEy+lRU51B9R4p+VHlT3Dd1moIa4gHtshs1Jf0bpz5XMU8qL n2VYmqN8nYjdjXQtgnJpi7KUKE+HX1lGcrLH7B1LAtAO7XIeu1WERbV2duVTF94KCslE be9Q== X-Gm-Message-State: AOAM533HUeo8abDZETlWwKLIGHxplJ0oIOd150l3K310yEt1i83NXUQG cz4V+q1ABTMUIOl9Y0jlgNQdeA== X-Google-Smtp-Source: ABdhPJzLfFACesomu1x18FBI9rkvW5RTTXGQhL7I+v04tKFK6M8vBlHBJ66KDsEkghj597f7mvX3eQ== X-Received: by 2002:a05:600c:4ece:b0:38c:7938:d73c with SMTP id g14-20020a05600c4ece00b0038c7938d73cmr662017wmq.165.1647893278669; Mon, 21 Mar 2022 13:07:58 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:07:58 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 12/26] crypto: rockchip: add debugfs Date: Mon, 21 Mar 2022 20:07:25 +0000 Message-Id: <20220321200739.3572792-13-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch enable to access usage stats for each algorithm. Signed-off-by: Corentin Labbe --- drivers/crypto/Kconfig | 10 ++++ drivers/crypto/rockchip/rk3288_crypto.c | 47 +++++++++++++++++++ drivers/crypto/rockchip/rk3288_crypto.h | 11 +++++ drivers/crypto/rockchip/rk3288_crypto_ahash.c | 8 ++++ .../crypto/rockchip/rk3288_crypto_skcipher.c | 19 +++++++- 5 files changed, 94 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index d68cc2dc2bd5..b609215ecd62 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -801,6 +801,16 @@ config CRYPTO_DEV_ROCKCHIP This driver interfaces with the hardware crypto accelerator. Supporting cbc/ecb chainmode, and aes/des/des3_ede cipher mode. =20 +config CRYPTO_DEV_ROCKCHIP_DEBUG + bool "Enable Rockchip crypto stats" + depends on CRYPTO_DEV_ROCKCHIP + depends on DEBUG_FS + help + Say y to enable Rockchip crypto debug stats. + This will create /sys/kernel/debug/rk3288_crypto/stats for displaying + the number of requests per algorithm and other internal stats. + + config CRYPTO_DEV_ZYNQMP_AES tristate "Support for Xilinx ZynqMP AES hw accelerator" depends on ZYNQMP_FIRMWARE || COMPILE_TEST diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index 8f9664acc78d..3e1b4f3b2422 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -95,6 +95,41 @@ static struct rk_crypto_tmp *rk_cipher_algs[] =3D { &rk_ahash_md5, }; =20 +#ifdef CONFIG_CRYPTO_DEV_ROCKCHIP_DEBUG +static int rk_crypto_debugfs_show(struct seq_file *seq, void *v) +{ + unsigned int i; + + for (i =3D 0; i < ARRAY_SIZE(rk_cipher_algs); i++) { + if (!rk_cipher_algs[i]->dev) + continue; + switch (rk_cipher_algs[i]->type) { + case CRYPTO_ALG_TYPE_SKCIPHER: + seq_printf(seq, "%s %s reqs=3D%lu fallback=3D%lu\n", + rk_cipher_algs[i]->alg.skcipher.base.cra_driver_name, + rk_cipher_algs[i]->alg.skcipher.base.cra_name, + rk_cipher_algs[i]->stat_req, rk_cipher_algs[i]->stat_fb); + seq_printf(seq, "\tfallback due to length: %lu\n", + rk_cipher_algs[i]->stat_fb_len); + seq_printf(seq, "\tfallback due to alignment: %lu\n", + rk_cipher_algs[i]->stat_fb_align); + seq_printf(seq, "\tfallback due to SGs: %lu\n", + rk_cipher_algs[i]->stat_fb_sgdiff); + break; + case CRYPTO_ALG_TYPE_AHASH: + seq_printf(seq, "%s %s reqs=3D%lu fallback=3D%lu\n", + rk_cipher_algs[i]->alg.hash.halg.base.cra_driver_name, + rk_cipher_algs[i]->alg.hash.halg.base.cra_name, + rk_cipher_algs[i]->stat_req, rk_cipher_algs[i]->stat_fb); + break; + } + } + return 0; +} + +DEFINE_SHOW_ATTRIBUTE(rk_crypto_debugfs); +#endif + static int rk_crypto_register(struct rk_crypto_info *crypto_info) { unsigned int i, k; @@ -246,6 +281,15 @@ static int rk_crypto_probe(struct platform_device *pde= v) goto err_register_alg; } =20 +#ifdef CONFIG_CRYPTO_DEV_ROCKCHIP_DEBUG + /* Ignore error of debugfs */ + crypto_info->dbgfs_dir =3D debugfs_create_dir("rk3288_crypto", NULL); + crypto_info->dbgfs_stats =3D debugfs_create_file("stats", 0444, + crypto_info->dbgfs_dir, + crypto_info, + &rk_crypto_debugfs_fops); +#endif + dev_info(dev, "Crypto Accelerator successfully registered\n"); return 0; =20 @@ -260,6 +304,9 @@ static int rk_crypto_remove(struct platform_device *pde= v) { struct rk_crypto_info *crypto_tmp =3D platform_get_drvdata(pdev); =20 +#ifdef CONFIG_CRYPTO_DEV_ROCKCHIP_DEBUG + debugfs_remove_recursive(crypto_tmp->dbgfs_dir); +#endif rk_crypto_unregister(); rk_crypto_disable_clk(crypto_tmp); crypto_engine_exit(crypto_tmp->engine); diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockc= hip/rk3288_crypto.h index 99b93841fbff..f85144e3d124 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.h +++ b/drivers/crypto/rockchip/rk3288_crypto.h @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -199,6 +200,10 @@ struct rk_crypto_info { struct crypto_engine *engine; struct completion complete; int status; +#ifdef CONFIG_CRYPTO_DEV_ROCKCHIP_DEBUG + struct dentry *dbgfs_dir; + struct dentry *dbgfs_stats; +#endif }; =20 /* the private variable of hash */ @@ -239,6 +244,12 @@ struct rk_crypto_tmp { struct skcipher_alg skcipher; struct ahash_alg hash; } alg; + unsigned long stat_req; + unsigned long stat_fb; + unsigned long stat_fb_len; + unsigned long stat_fb_sglen; + unsigned long stat_fb_align; + unsigned long stat_fb_sgdiff; }; =20 extern struct rk_crypto_tmp rk_ecb_aes_alg; diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto= /rockchip/rk3288_crypto_ahash.c index d08e2438d356..8856c6226be6 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c @@ -39,6 +39,10 @@ static int rk_ahash_digest_fb(struct ahash_request *areq) struct rk_ahash_rctx *rctx =3D ahash_request_ctx(areq); struct crypto_ahash *tfm =3D crypto_ahash_reqtfm(areq); struct rk_ahash_ctx *tfmctx =3D crypto_ahash_ctx(tfm); + struct ahash_alg *alg =3D __crypto_ahash_alg(tfm->base.__crt_alg); + struct rk_crypto_tmp *algt =3D container_of(alg, struct rk_crypto_tmp, al= g.hash); + + algt->stat_fb++; =20 ahash_request_set_tfm(&rctx->fallback_req, tfmctx->fallback_tfm); rctx->fallback_req.base.flags =3D areq->base.flags & @@ -249,6 +253,8 @@ static int rk_hash_run(struct crypto_engine *engine, vo= id *breq) struct crypto_ahash *tfm =3D crypto_ahash_reqtfm(areq); struct rk_ahash_rctx *rctx =3D ahash_request_ctx(areq); struct rk_ahash_ctx *tctx =3D crypto_ahash_ctx(tfm); + struct ahash_alg *alg =3D __crypto_ahash_alg(tfm->base.__crt_alg); + struct rk_crypto_tmp *algt =3D container_of(alg, struct rk_crypto_tmp, al= g.hash); struct scatterlist *sg =3D areq->src; int err =3D 0; int i; @@ -256,6 +262,8 @@ static int rk_hash_run(struct crypto_engine *engine, vo= id *breq) =20 rctx->mode =3D 0; =20 + algt->stat_req++; + switch (crypto_ahash_digestsize(tfm)) { case SHA1_DIGEST_SIZE: rctx->mode =3D RK_CRYPTO_HASH_SHA1; diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/cry= pto/rockchip/rk3288_crypto_skcipher.c index 19bb9a9576d8..4ff08238156b 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c +++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c @@ -16,6 +16,9 @@ =20 static int rk_cipher_need_fallback(struct skcipher_request *req) { + struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(req); + struct skcipher_alg *alg =3D crypto_skcipher_alg(tfm); + struct rk_crypto_tmp *algt =3D container_of(alg, struct rk_crypto_tmp, al= g.skcipher); struct scatterlist *sgs, *sgd; unsigned int todo, len; unsigned int bs =3D crypto_skcipher_blocksize(tfm); @@ -27,10 +30,12 @@ static int rk_cipher_need_fallback(struct skcipher_requ= est *req) sgs =3D req->src; while (sgs) { if (!IS_ALIGNED(sgs->offset, sizeof(u32))) { + algt->stat_fb_align++; return true; } todo =3D min(len, sgs->length); if (todo % bs) { + algt->stat_fb_len++; return true; } len -=3D todo; @@ -40,10 +45,12 @@ static int rk_cipher_need_fallback(struct skcipher_requ= est *req) sgd =3D req->dst; while (sgd) { if (!IS_ALIGNED(sgd->offset, sizeof(u32))) { + algt->stat_fb_align++; return true; } todo =3D min(len, sgd->length); if (todo % bs) { + algt->stat_fb_len++; return true; } len -=3D todo; @@ -52,8 +59,10 @@ static int rk_cipher_need_fallback(struct skcipher_reque= st *req) sgs =3D req->src; sgd =3D req->dst; while (sgs && sgd) { - if (sgs->length !=3D sgd->length) + if (sgs->length !=3D sgd->length) { + algt->stat_fb_sgdiff++; return true; + } sgs =3D sg_next(sgs); sgd =3D sg_next(sgd); } @@ -65,8 +74,12 @@ static int rk_cipher_fallback(struct skcipher_request *a= req) struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(areq); struct rk_cipher_ctx *op =3D crypto_skcipher_ctx(tfm); struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(areq); + struct skcipher_alg *alg =3D crypto_skcipher_alg(tfm); + struct rk_crypto_tmp *algt =3D container_of(alg, struct rk_crypto_tmp, al= g.skcipher); int err; =20 + algt->stat_fb++; + skcipher_request_set_tfm(&rctx->fallback_req, op->fallback_tfm); skcipher_request_set_callback(&rctx->fallback_req, areq->base.flags, areq->base.complete, areq->base.data); @@ -333,6 +346,10 @@ static int rk_cipher_run(struct crypto_engine *engine,= void *async_req) u8 *ivtouse =3D areq->iv; unsigned int len =3D areq->cryptlen; unsigned int todo; + struct skcipher_alg *alg =3D crypto_skcipher_alg(tfm); + struct rk_crypto_tmp *algt =3D container_of(alg, struct rk_crypto_tmp, al= g.skcipher); + + algt->stat_req++; =20 ivsize =3D crypto_skcipher_ivsize(tfm); if (areq->iv && crypto_skcipher_ivsize(tfm) > 0) { --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF470C433FE for ; Mon, 21 Mar 2022 20:08:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352990AbiCUUKD (ORCPT ); Mon, 21 Mar 2022 16:10:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352971AbiCUUJj (ORCPT ); Mon, 21 Mar 2022 16:09:39 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 257BD106638 for ; Mon, 21 Mar 2022 13:08:01 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id h23so21608287wrb.8 for ; Mon, 21 Mar 2022 13:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2koU9eUC0sosP5fb70SNKNvUvxzlAfqY4XAuaRf+3BM=; b=nm4JEFKv1ExN1Yho426sggi0XyhrT+8dhyjrwKK1msCHIWs1SIk4Kb8qMUCV55Itii g9lqsAXZi29gfQF7o5okjJcW/2A1yzHT0qXUWXCtEGgMYeLId08PQuzx151jmjjTGDrZ ybIVXhyIeOURG9ya5EtiEgCvUa0AF8JyZPs1FAjjEKIaVr+/GtO+smSoJeWXrAw9c+3m sck7SM8Ro5gIsTpECT4taI3XZ7KkcmZyOMwX3nAt3su5qacTWqTYfXLiizBxvUSMoYJf h6mPfnHdKd47AZrHpn2B3sZUDQDIHJy+OrqQEFkYsajNGSFCoe618lt4tXlEklSqJ9sg WDpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2koU9eUC0sosP5fb70SNKNvUvxzlAfqY4XAuaRf+3BM=; b=ATpJ+oa57UbYrZljC+yeyoXWRpf7oj6+jjnRCHXHtmjYrEgXkl8swgrnnwN8j+Bj3l ynbCNXw7nH8Vp4wi6E2iSSQZYX6wu6YgWxhbw5658gHj8Yu5m5up70q1cAKQADRYZwvL uUWPQqPQbejI7IEhYaRZ8irJTglXFb75JRW6hNS7cdLcHBpHEt+wFeQmuH0uxDrfo6fB 5sGqLw+mdDoND7Y/Zo4f82D1fhMf/J9Al7kQQ1RK1KbaspvZIkT3jU8bEcftLeg6PL8F /wgxf90c/1JDoHA3/9hez8+ximn032BNqYK7TJKcWls9uaHLHGQc94B1yDTAmIT+euB1 +LTA== X-Gm-Message-State: AOAM533XqksrJUZXV3MoYkOM4EXyPNssO0kwfpoO8wNNBCRBktJC1B3c z2Ib76wvbW3eGEO/4lTsjk5N5g== X-Google-Smtp-Source: ABdhPJyhUOiAdTCjzsUCBzWNJdJJWllqjue/UNJ355mEpXvW7VMVR6TQAKhsHbUq/Tf1P1iWLVp2bA== X-Received: by 2002:a05:6000:1363:b0:203:d731:a19 with SMTP id q3-20020a056000136300b00203d7310a19mr20231181wrz.322.1647893279501; Mon, 21 Mar 2022 13:07:59 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:07:59 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 13/26] crypto: rockchip: introduce PM Date: Mon, 21 Mar 2022 20:07:26 +0000 Message-Id: <20220321200739.3572792-14-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add runtime PM support for rockchip crypto. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 51 ++++++++++++++++++- drivers/crypto/rockchip/rk3288_crypto.h | 1 + drivers/crypto/rockchip/rk3288_crypto_ahash.c | 10 ++++ .../crypto/rockchip/rk3288_crypto_skcipher.c | 9 ++++ 4 files changed, 69 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index 3e1b4f3b2422..d9258b9e71b3 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -65,6 +65,48 @@ static void rk_crypto_disable_clk(struct rk_crypto_info = *dev) clk_disable_unprepare(dev->sclk); } =20 +/* + * Power management strategy: The device is suspended unless a TFM exists = for + * one of the algorithms proposed by this driver. + */ +static int rk_crypto_pm_suspend(struct device *dev) +{ + struct rk_crypto_info *rkdev =3D dev_get_drvdata(dev); + + rk_crypto_disable_clk(rkdev); + return 0; +} + +static int rk_crypto_pm_resume(struct device *dev) +{ + struct rk_crypto_info *rkdev =3D dev_get_drvdata(dev); + + return rk_crypto_enable_clk(rkdev); +} + +static const struct dev_pm_ops rk_crypto_pm_ops =3D { + SET_RUNTIME_PM_OPS(rk_crypto_pm_suspend, rk_crypto_pm_resume, NULL) +}; + +static int rk_crypto_pm_init(struct rk_crypto_info *rkdev) +{ + int err; + + pm_runtime_use_autosuspend(rkdev->dev); + pm_runtime_set_autosuspend_delay(rkdev->dev, 2000); + + err =3D pm_runtime_set_suspended(rkdev->dev); + if (err) + return err; + pm_runtime_enable(rkdev->dev); + return err; +} + +static void rk_crypto_pm_exit(struct rk_crypto_info *rkdev) +{ + pm_runtime_disable(rkdev->dev); +} + static irqreturn_t rk_crypto_irq_handle(int irq, void *dev_id) { struct rk_crypto_info *dev =3D platform_get_drvdata(dev_id); @@ -273,7 +315,9 @@ static int rk_crypto_probe(struct platform_device *pdev) crypto_engine_start(crypto_info->engine); init_completion(&crypto_info->complete); =20 - rk_crypto_enable_clk(crypto_info); + err =3D rk_crypto_pm_init(crypto_info); + if (err) + goto err_pm; =20 err =3D rk_crypto_register(crypto_info); if (err) { @@ -294,6 +338,8 @@ static int rk_crypto_probe(struct platform_device *pdev) return 0; =20 err_register_alg: + rk_crypto_pm_exit(crypto_info); +err_pm: crypto_engine_exit(crypto_info->engine); err_crypto: dev_err(dev, "Crypto Accelerator not successfully registered\n"); @@ -308,7 +354,7 @@ static int rk_crypto_remove(struct platform_device *pde= v) debugfs_remove_recursive(crypto_tmp->dbgfs_dir); #endif rk_crypto_unregister(); - rk_crypto_disable_clk(crypto_tmp); + rk_crypto_pm_exit(crypto_tmp); crypto_engine_exit(crypto_tmp->engine); return 0; } @@ -318,6 +364,7 @@ static struct platform_driver crypto_driver =3D { .remove =3D rk_crypto_remove, .driver =3D { .name =3D "rk3288-crypto", + .pm =3D &rk_crypto_pm_ops, .of_match_table =3D crypto_of_id_table, }, }; diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockc= hip/rk3288_crypto.h index f85144e3d124..6a1f09d409bf 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.h +++ b/drivers/crypto/rockchip/rk3288_crypto.h @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto= /rockchip/rk3288_crypto_ahash.c index 8856c6226be6..137013bd4410 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c @@ -328,6 +328,7 @@ static int rk_cra_hash_init(struct crypto_tfm *tfm) struct ahash_alg *alg =3D __crypto_ahash_alg(tfm->__crt_alg); =20 const char *alg_name =3D crypto_tfm_alg_name(tfm); + int err; =20 algt =3D container_of(alg, struct rk_crypto_tmp, alg.hash); =20 @@ -349,7 +350,15 @@ static int rk_cra_hash_init(struct crypto_tfm *tfm) tctx->enginectx.op.prepare_request =3D rk_hash_prepare; tctx->enginectx.op.unprepare_request =3D rk_hash_unprepare; =20 + err =3D pm_runtime_resume_and_get(tctx->dev->dev); + if (err < 0) + goto error_pm; + return 0; +error_pm: + crypto_free_ahash(tctx->fallback_tfm); + + return err; } =20 static void rk_cra_hash_exit(struct crypto_tfm *tfm) @@ -357,6 +366,7 @@ static void rk_cra_hash_exit(struct crypto_tfm *tfm) struct rk_ahash_ctx *tctx =3D crypto_tfm_ctx(tfm); =20 crypto_free_ahash(tctx->fallback_tfm); + pm_runtime_put_autosuspend(tctx->dev->dev); } =20 struct rk_crypto_tmp rk_ahash_sha1 =3D { diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/cry= pto/rockchip/rk3288_crypto_skcipher.c index 4ff08238156b..8d3a60db0cf6 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c +++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c @@ -466,6 +466,7 @@ static int rk_ablk_init_tfm(struct crypto_skcipher *tfm) struct skcipher_alg *alg =3D crypto_skcipher_alg(tfm); const char *name =3D crypto_tfm_alg_name(&tfm->base); struct rk_crypto_tmp *algt; + int err; =20 algt =3D container_of(alg, struct rk_crypto_tmp, alg.skcipher); =20 @@ -483,7 +484,14 @@ static int rk_ablk_init_tfm(struct crypto_skcipher *tf= m) =20 ctx->enginectx.op.do_one_request =3D rk_cipher_run; =20 + err =3D pm_runtime_resume_and_get(ctx->dev->dev); + if (err < 0) + goto error_pm; + return 0; +error_pm: + crypto_free_skcipher(ctx->fallback_tfm); + return err; } =20 static void rk_ablk_exit_tfm(struct crypto_skcipher *tfm) @@ -492,6 +500,7 @@ static void rk_ablk_exit_tfm(struct crypto_skcipher *tf= m) =20 memzero_explicit(ctx->key, ctx->keylen); crypto_free_skcipher(ctx->fallback_tfm); + pm_runtime_put_autosuspend(ctx->dev->dev); } =20 struct rk_crypto_tmp rk_ecb_aes_alg =3D { --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9CB1C433EF for ; Mon, 21 Mar 2022 20:09:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353126AbiCUUKs (ORCPT ); Mon, 21 Mar 2022 16:10:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352985AbiCUUJl (ORCPT ); Mon, 21 Mar 2022 16:09:41 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2ACE108542 for ; Mon, 21 Mar 2022 13:08:01 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id b19so22194804wrh.11 for ; Mon, 21 Mar 2022 13:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+HaTfNod3aEyDePLcyY2jAUHNy+p+ObhCTXVNT/SKZc=; b=emOhvDacn9fqoR2jXRzNDjn/fMmRrieuSeznEfikBdGRSkW2QwjxouH81+Fwjh0AFd evXQ4E/OjsZlquw1PFRoq0qZ8V1uU2dFw1KW4yypwDaSb1WSt5zeJgWlg5AYy9384SQ3 EpD6THUKpqH7hPQTQY08PbmuT8BAv4OnTUVoUfDp5LtFeplmVBFPr3+8hTR4tBIHhOeF 3vG09MypOc4eMpOZxMnmImtm/CgbL7xv9hLR14dx73f+uOss+jTDm/5foL1JamFERmKp x1ttW1tsMfncnHvuIpVhHHrNp5HQlCPINjlHk+DHdfCdKbg5tZiKZ5O664jCsB5wZ5Z7 ikWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+HaTfNod3aEyDePLcyY2jAUHNy+p+ObhCTXVNT/SKZc=; b=DW/c0SioIMsS5lV9HMNtHHemy/uPgSCdmQxB5ApSMsdCkoq7AsNV2bTtJAM4jaIJoe YpAaJ+Ei4gOZVpHshLecY/qjHCc7e95ctU2GOq3AOpW+zWDooOmm9fsKMTIdXEGdRXih QrPXi45lpJgmBn0THJp3xxiadgovhYRf3KTtXus8DO4bqXZ1fxqHSe74OLFIcFLx3MDL tdR0eVC2r0AJWICc4C6HD3DENp8w14ar2ZbHcNwQmWakzONc4omHQIfGvzFmC1PMB/v2 bJ+L6pBygbQoHYO36y2Me8pD8AeWXuhB2IyI3rdSV5NFPNNvsq3psRf3mo87fjKrJ8ba /0yw== X-Gm-Message-State: AOAM531Cqga7vvHLhFtRAs8c/+kaCJdgZq8a/vHHIegDYAlBbCTdNGKS cBiltoxjN4jtbwJUWjl8at0O4w== X-Google-Smtp-Source: ABdhPJwHFqbCE5MwjHAeF2xKY2Y2VcS4CCDMlY5kasTggHm29bdfQnRql04xP+EjlytxwV7aRGHYZg== X-Received: by 2002:adf:df8c:0:b0:203:e4f3:920 with SMTP id z12-20020adfdf8c000000b00203e4f30920mr19305159wrl.461.1647893280338; Mon, 21 Mar 2022 13:08:00 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.07.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:08:00 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 14/26] crypto: rockchip: handle reset also in PM Date: Mon, 21 Mar 2022 20:07:27 +0000 Message-Id: <20220321200739.3572792-15-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" reset could be handled by PM functions. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index d9258b9e71b3..a11a92e1f3fd 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -73,6 +73,8 @@ static int rk_crypto_pm_suspend(struct device *dev) { struct rk_crypto_info *rkdev =3D dev_get_drvdata(dev); =20 + reset_control_assert(rkdev->rst); + rk_crypto_disable_clk(rkdev); return 0; } @@ -81,6 +83,8 @@ static int rk_crypto_pm_resume(struct device *dev) { struct rk_crypto_info *rkdev =3D dev_get_drvdata(dev); =20 + reset_control_deassert(rkdev->rst); + return rk_crypto_enable_clk(rkdev); } =20 @@ -222,13 +226,6 @@ static void rk_crypto_unregister(void) } } =20 -static void rk_crypto_action(void *data) -{ - struct rk_crypto_info *crypto_info =3D data; - - reset_control_assert(crypto_info->rst); -} - static const struct of_device_id crypto_of_id_table[] =3D { { .compatible =3D "rockchip,rk3288-crypto" }, {} @@ -254,14 +251,6 @@ static int rk_crypto_probe(struct platform_device *pde= v) goto err_crypto; } =20 - reset_control_assert(crypto_info->rst); - usleep_range(10, 20); - reset_control_deassert(crypto_info->rst); - - err =3D devm_add_action_or_reset(dev, rk_crypto_action, crypto_info); - if (err) - goto err_crypto; - crypto_info->reg =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(crypto_info->reg)) { err =3D PTR_ERR(crypto_info->reg); --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFDBFC433F5 for ; Mon, 21 Mar 2022 20:09:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353046AbiCUUKi (ORCPT ); Mon, 21 Mar 2022 16:10:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353002AbiCUUJm (ORCPT ); Mon, 21 Mar 2022 16:09:42 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A26F9151D2A for ; Mon, 21 Mar 2022 13:08:02 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id p9so22186045wra.12 for ; Mon, 21 Mar 2022 13:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TC2ukNpjnca3/C/2NpZDQj5qjEIJ5Lf4AutHU4Vrcn0=; b=VL1++qWq+V/AY+U1OwOt2RXityXZahi+1XI8ynS0pv6KFqc45EOtiW+MTLa1cu01bp SfRJ0DDCpB6kgyFj5aViXSnqxqcYwjw88kTO/EJ2DYGYL3LditWQBolYH21wuFtAomwa 9fh8fKH61kDT3LsZPRSDplVpnFzEIjEWQsb00G6Mrg/Davzbwc87OSsLCq1zp2Btp4u2 HEOMzmAAi5w2A0Xthpx3BZtJacIq8RtuuIk4V235lsjY5mRnrmguybNdh3rBqlrN+L6w LbdpVp8XTkDEjhKB1SgK5f3vBUCGuNcW43f+JDfzuaummMyZN/yf+XE9OVTsChKsqwoN VWbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TC2ukNpjnca3/C/2NpZDQj5qjEIJ5Lf4AutHU4Vrcn0=; b=GWiezmnshAUTovVP0JX9+XHNgQkPTlK90fOYY5pnbkWYUGFTl97g9M9HMcruOSyQZZ qEhSgMGofkv9XFcvzSGuY+jY3ByoyOa6tEdu5l1w5jQrERmgWgsTQdulLp7EmF9zAPRX KLQtJA25ESkkIl2r7HjMg2LVlb13KiSC4eD6cqBLu8r5SM13Qx2ghs3/jf4Dt+/D9mge cSGet2HHo3f90VOsU+pItiGhIGMSWfKlW3ayIcfWsCfvyUk/2zwWhtkkstyjzxxN1CeG OGfuahFUALdePgoEtnsiIrGsEQoVyZp5p+vFJvH12xDBvc1RM2bKS27lh6MeOpMCpBU2 kOeA== X-Gm-Message-State: AOAM530c/K38bNHvWMVpSilxLIW4JH9SoYKn0zviRjrouJHRVcR7N4y3 JWZUu+gDf+MUHL6AtuLHboUBZQ== X-Google-Smtp-Source: ABdhPJxnHLouyElDQFO1AvalQF392AVWAvEZN6CoSfdeQNnoN6hQ5PZK3LK6wUdDa4lf2qX3bPSwgw== X-Received: by 2002:a05:6000:388:b0:204:445:6a56 with SMTP id u8-20020a056000038800b0020404456a56mr8931941wrf.372.1647893281110; Mon, 21 Mar 2022 13:08:01 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.08.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:08:00 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 15/26] crypto: rockchip: use clk_bulk to simplify clock management Date: Mon, 21 Mar 2022 20:07:28 +0000 Message-Id: <20220321200739.3572792-16-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rk3328 does not have the same clock names than rk3288, instead of using a c= omplex clock management, let's use clk_bulk to simplify their handling. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 66 ++++--------------------- drivers/crypto/rockchip/rk3288_crypto.h | 6 +-- 2 files changed, 11 insertions(+), 61 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index a11a92e1f3fd..97ef59a36be6 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -22,47 +22,16 @@ static int rk_crypto_enable_clk(struct rk_crypto_info *= dev) { int err; =20 - err =3D clk_prepare_enable(dev->sclk); - if (err) { - dev_err(dev->dev, "[%s:%d], Couldn't enable clock sclk\n", - __func__, __LINE__); - goto err_return; - } - err =3D clk_prepare_enable(dev->aclk); - if (err) { - dev_err(dev->dev, "[%s:%d], Couldn't enable clock aclk\n", - __func__, __LINE__); - goto err_aclk; - } - err =3D clk_prepare_enable(dev->hclk); - if (err) { - dev_err(dev->dev, "[%s:%d], Couldn't enable clock hclk\n", - __func__, __LINE__); - goto err_hclk; - } - err =3D clk_prepare_enable(dev->dmaclk); - if (err) { - dev_err(dev->dev, "[%s:%d], Couldn't enable clock dmaclk\n", - __func__, __LINE__); - goto err_dmaclk; - } - return err; -err_dmaclk: - clk_disable_unprepare(dev->hclk); -err_hclk: - clk_disable_unprepare(dev->aclk); -err_aclk: - clk_disable_unprepare(dev->sclk); -err_return: + err =3D clk_bulk_prepare_enable(dev->num_clks, dev->clks); + if (err) + dev_err(dev->dev, "Could not enable clock clks\n"); + return err; } =20 static void rk_crypto_disable_clk(struct rk_crypto_info *dev) { - clk_disable_unprepare(dev->dmaclk); - clk_disable_unprepare(dev->hclk); - clk_disable_unprepare(dev->aclk); - clk_disable_unprepare(dev->sclk); + clk_bulk_disable_unprepare(dev->num_clks, dev->clks); } =20 /* @@ -257,27 +226,10 @@ static int rk_crypto_probe(struct platform_device *pd= ev) goto err_crypto; } =20 - crypto_info->aclk =3D devm_clk_get(&pdev->dev, "aclk"); - if (IS_ERR(crypto_info->aclk)) { - err =3D PTR_ERR(crypto_info->aclk); - goto err_crypto; - } - - crypto_info->hclk =3D devm_clk_get(&pdev->dev, "hclk"); - if (IS_ERR(crypto_info->hclk)) { - err =3D PTR_ERR(crypto_info->hclk); - goto err_crypto; - } - - crypto_info->sclk =3D devm_clk_get(&pdev->dev, "sclk"); - if (IS_ERR(crypto_info->sclk)) { - err =3D PTR_ERR(crypto_info->sclk); - goto err_crypto; - } - - crypto_info->dmaclk =3D devm_clk_get(&pdev->dev, "apb_pclk"); - if (IS_ERR(crypto_info->dmaclk)) { - err =3D PTR_ERR(crypto_info->dmaclk); + crypto_info->num_clks =3D devm_clk_bulk_get_all(&pdev->dev, + &crypto_info->clks); + if (crypto_info->num_clks < 3) { + err =3D -EINVAL; goto err_crypto; } =20 diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockc= hip/rk3288_crypto.h index 6a1f09d409bf..b6cd67d1d0cb 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.h +++ b/drivers/crypto/rockchip/rk3288_crypto.h @@ -190,10 +190,8 @@ =20 struct rk_crypto_info { struct device *dev; - struct clk *aclk; - struct clk *hclk; - struct clk *sclk; - struct clk *dmaclk; + struct clk_bulk_data *clks; + int num_clks; struct reset_control *rst; void __iomem *reg; int irq; --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B8D0C433F5 for ; Mon, 21 Mar 2022 20:09:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239678AbiCUUKm (ORCPT ); Mon, 21 Mar 2022 16:10:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353008AbiCUUJm (ORCPT ); Mon, 21 Mar 2022 16:09:42 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D19E154059 for ; Mon, 21 Mar 2022 13:08:03 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id h4so4254082wrc.13 for ; Mon, 21 Mar 2022 13:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lHOz18mOxmFMMtKt0o540U9gTFJ/b9JmGBo5H/9UdMU=; b=LuQPUBXWZOpDbwZ1YCfAxxpQxme/kyvgeHyDE6wAI/F/xnR+RYEq8VxTfwjtEisP2U rVg/dYRMQvZrnb5zBZ2zrV0Y732DEIY0ElGsLCJkKglNA9j7LeUp2b2IZ9PeMKnaHfUt wy/mtADbyocrOUmyADeh7AEHQpKZwAWl0gKh7zwIJKzoBn80jphLCrsDTV8hYLwoigpS N2f0E5qfLUeXb/F5iQqH3TIbbjlKEYfMrQhZQZwqkf7wg41WaNLNJ0Xk4uSZPGSMru68 wnHbXtx7j0gqtpnDU+X3KU0t4XneYjAr3eFiSLnsrz/o6GByEHpbTQ/A1lTtGfieuuxH zUVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lHOz18mOxmFMMtKt0o540U9gTFJ/b9JmGBo5H/9UdMU=; b=VFCKD3TVLZ4Nvjaa2zAu9TgSIyypZZ4Uj0thEk0XkS+yUhQrAAZS7c3+Rc4DE3DTbw poHD52uztXsfWPEN5PpUF5s+0ckoHwPZAYok2/wzmxywckcH+MCLJzKXGootgJvCwF1g 9Ox7e9qvWF14Y2nuaOwDKoF2ZSBJZ9gePCmF01tAEGEFGbRSPlmoEHhghRT3ucBWqDwM 9FGEdUY3/93B4lahd99dx+dXLLsp2h/LQxWxu/X+MSYpnJJoTM5NDC/5DxVzfIQfbCkE I74vzzz7QVc7eYlSNRvadPTs7L3g6zXASTbxfLEPHnhVURvGWzfK+n1WSfKHGC2FFEXT I2Zw== X-Gm-Message-State: AOAM531gGgv7JJVdkr2TVtBDRYvTmzpbpr3lYXxnLvf6MSiGjK5PEdLE W4z99hnC6psdUJAfUmSk9tmp5A== X-Google-Smtp-Source: ABdhPJx25lCFurNfXtsAe8CjsnIdG4+jKGImGSESGACBQRcR501itJtp9xA6jYnooZhZBlTUIDkaOw== X-Received: by 2002:a5d:4441:0:b0:1f0:882d:77e9 with SMTP id x1-20020a5d4441000000b001f0882d77e9mr18936245wrr.718.1647893281879; Mon, 21 Mar 2022 13:08:01 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.08.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:08:01 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 16/26] crypto: rockchip: add support for r3399 Date: Mon, 21 Mar 2022 20:07:29 +0000 Message-Id: <20220321200739.3572792-17-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The RK3399 has 2 crypto identical IP, so let's add support for both. We need also to handle all rk3399-cryto's resets. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 111 +++++++++++------- drivers/crypto/rockchip/rk3288_crypto.h | 32 +++-- drivers/crypto/rockchip/rk3288_crypto_ahash.c | 65 +++++----- .../crypto/rockchip/rk3288_crypto_skcipher.c | 51 ++++---- 4 files changed, 160 insertions(+), 99 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index 97ef59a36be6..5f1422094a7f 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -14,10 +14,19 @@ #include #include #include +#include #include #include #include =20 +static const struct rk_variant rk3288_variant =3D { + .num_instance =3D 1 +}; + +static const struct rk_variant rk3399_variant =3D { + .num_instance =3D 2 +}; + static int rk_crypto_enable_clk(struct rk_crypto_info *dev) { int err; @@ -82,19 +91,25 @@ static void rk_crypto_pm_exit(struct rk_crypto_info *rk= dev) =20 static irqreturn_t rk_crypto_irq_handle(int irq, void *dev_id) { - struct rk_crypto_info *dev =3D platform_get_drvdata(dev_id); + struct rk_crypto_info *dev =3D platform_get_drvdata(dev_id); + void __iomem *reg; u32 interrupt_status; + int i; =20 - interrupt_status =3D CRYPTO_READ(dev, RK_CRYPTO_INTSTS); - CRYPTO_WRITE(dev, RK_CRYPTO_INTSTS, interrupt_status); + for (i =3D 0; i < dev->variant->num_instance; i++) { + if (dev->rki[i].irq !=3D irq) + continue; + reg =3D dev->rki[i].reg; + interrupt_status =3D readl(reg + RK_CRYPTO_INTSTS); + writel(interrupt_status, reg + RK_CRYPTO_INTSTS); =20 - dev->status =3D 1; - if (interrupt_status & 0x0a) { - dev_warn(dev->dev, "DMA Error\n"); - dev->status =3D 0; + dev->rki[i].status =3D 1; + if (interrupt_status & 0x0a) { + dev->rki[i].status =3D 0; + } + complete(&dev->rki[i].complete); + return IRQ_HANDLED; } - complete(&dev->complete); - return IRQ_HANDLED; } =20 @@ -152,6 +167,7 @@ static int rk_crypto_register(struct rk_crypto_info *cr= ypto_info) =20 for (i =3D 0; i < ARRAY_SIZE(rk_cipher_algs); i++) { rk_cipher_algs[i]->dev =3D crypto_info; + switch (rk_cipher_algs[i]->type) { case CRYPTO_ALG_TYPE_SKCIPHER: dev_info(crypto_info->dev, "Register %s as %s\n", @@ -196,7 +212,12 @@ static void rk_crypto_unregister(void) } =20 static const struct of_device_id crypto_of_id_table[] =3D { - { .compatible =3D "rockchip,rk3288-crypto" }, + { .compatible =3D "rockchip,rk3288-crypto", + .data =3D &rk3288_variant, + }, + { .compatible =3D "rockchip,rk3399-crypto", + .data =3D &rk3399_variant, + }, {} }; MODULE_DEVICE_TABLE(of, crypto_of_id_table); @@ -206,6 +227,7 @@ static int rk_crypto_probe(struct platform_device *pdev) struct device *dev =3D &pdev->dev; struct rk_crypto_info *crypto_info; int err =3D 0; + int i; =20 crypto_info =3D devm_kzalloc(&pdev->dev, sizeof(*crypto_info), GFP_KERNEL); @@ -214,48 +236,54 @@ static int rk_crypto_probe(struct platform_device *pd= ev) goto err_crypto; } =20 - crypto_info->rst =3D devm_reset_control_get(dev, "crypto-rst"); - if (IS_ERR(crypto_info->rst)) { - err =3D PTR_ERR(crypto_info->rst); - goto err_crypto; + crypto_info->variant =3D of_device_get_match_data(&pdev->dev); + if (!crypto_info->variant) { + dev_err(&pdev->dev, "Missing variant\n"); + return -EINVAL; } =20 - crypto_info->reg =3D devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(crypto_info->reg)) { - err =3D PTR_ERR(crypto_info->reg); - goto err_crypto; - } + for (i =3D 0; i < crypto_info->variant->num_instance; i++) { + crypto_info->rki[i].reg =3D devm_platform_ioremap_resource(pdev, i); + if (IS_ERR(crypto_info->rki[i].reg)) { + err =3D PTR_ERR(crypto_info->rki[i].reg); + goto err_crypto; + } + crypto_info->rki[i].irq =3D platform_get_irq(pdev, i); + if (crypto_info->rki[i].irq < 0) { + dev_err(&pdev->dev, "control Interrupt is not available.\n"); + err =3D crypto_info->rki[i].irq; + goto err_crypto; + } =20 - crypto_info->num_clks =3D devm_clk_bulk_get_all(&pdev->dev, - &crypto_info->clks); - if (crypto_info->num_clks < 3) { - err =3D -EINVAL; - goto err_crypto; + err =3D devm_request_irq(&pdev->dev, crypto_info->rki[i].irq, + rk_crypto_irq_handle, IRQF_SHARED, + "rk-crypto", pdev); + + if (err) { + dev_err(&pdev->dev, "irq request failed.\n"); + goto err_crypto; + } + init_completion(&crypto_info->rki[i].complete); + crypto_info->rki[i].engine =3D crypto_engine_alloc_init(&pdev->dev, true= ); + crypto_engine_start(crypto_info->rki[i].engine); } =20 - crypto_info->irq =3D platform_get_irq(pdev, 0); - if (crypto_info->irq < 0) { - dev_err(&pdev->dev, "control Interrupt is not available.\n"); - err =3D crypto_info->irq; + crypto_info->rst =3D devm_reset_control_array_get_exclusive(dev); + if (IS_ERR(crypto_info->rst)) { + err =3D PTR_ERR(crypto_info->rst); goto err_crypto; } =20 - err =3D devm_request_irq(&pdev->dev, crypto_info->irq, - rk_crypto_irq_handle, IRQF_SHARED, - "rk-crypto", pdev); - - if (err) { - dev_err(&pdev->dev, "irq request failed.\n"); + crypto_info->num_clks =3D devm_clk_bulk_get_all(&pdev->dev, + &crypto_info->clks); + if (crypto_info->num_clks < 3) { + err =3D -EINVAL; goto err_crypto; } =20 crypto_info->dev =3D &pdev->dev; platform_set_drvdata(pdev, crypto_info); =20 - crypto_info->engine =3D crypto_engine_alloc_init(&pdev->dev, true); - crypto_engine_start(crypto_info->engine); - init_completion(&crypto_info->complete); - err =3D rk_crypto_pm_init(crypto_info); if (err) goto err_pm; @@ -281,7 +309,8 @@ static int rk_crypto_probe(struct platform_device *pdev) err_register_alg: rk_crypto_pm_exit(crypto_info); err_pm: - crypto_engine_exit(crypto_info->engine); + for (i =3D 0; i < crypto_info->variant->num_instance; i++) + crypto_engine_exit(crypto_info->rki[i].engine); err_crypto: dev_err(dev, "Crypto Accelerator not successfully registered\n"); return err; @@ -290,13 +319,15 @@ static int rk_crypto_probe(struct platform_device *pd= ev) static int rk_crypto_remove(struct platform_device *pdev) { struct rk_crypto_info *crypto_tmp =3D platform_get_drvdata(pdev); + int i; =20 #ifdef CONFIG_CRYPTO_DEV_ROCKCHIP_DEBUG debugfs_remove_recursive(crypto_tmp->dbgfs_dir); #endif rk_crypto_unregister(); rk_crypto_pm_exit(crypto_tmp); - crypto_engine_exit(crypto_tmp->engine); + for (i =3D 0; i < crypto_tmp->variant->num_instance; i++) + crypto_engine_exit(crypto_tmp->rki[i].engine); return 0; } =20 diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockc= hip/rk3288_crypto.h index b6cd67d1d0cb..e1dac351bc64 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.h +++ b/drivers/crypto/rockchip/rk3288_crypto.h @@ -183,28 +183,38 @@ #define RK_CRYPTO_HASH_DOUT_6 0x01a4 #define RK_CRYPTO_HASH_DOUT_7 0x01a8 =20 -#define CRYPTO_READ(dev, offset) \ - readl_relaxed(((dev)->reg + (offset))) -#define CRYPTO_WRITE(dev, offset, val) \ - writel_relaxed((val), ((dev)->reg + (offset))) +struct rk_variant { + int num_instance; +}; + +struct rk_instance { + void __iomem *reg; + int irq; + struct completion complete; + struct crypto_engine *engine; + int status; +}; =20 struct rk_crypto_info { struct device *dev; struct clk_bulk_data *clks; int num_clks; struct reset_control *rst; - void __iomem *reg; - int irq; - - struct crypto_engine *engine; - struct completion complete; - int status; + struct rk_instance rki[2]; + int numinst; + const struct rk_variant *variant; + atomic_t flow; #ifdef CONFIG_CRYPTO_DEV_ROCKCHIP_DEBUG struct dentry *dbgfs_dir; struct dentry *dbgfs_stats; #endif }; =20 +static inline int rk_get_engine_number(struct rk_crypto_info *rk) +{ + return atomic_inc_return(&rk->flow) % rk->variant->num_instance; +} + /* the private variable of hash */ struct rk_ahash_ctx { struct crypto_engine_ctx enginectx; @@ -218,6 +228,7 @@ struct rk_ahash_rctx { struct ahash_request fallback_req; u32 mode; int nrsg; + int ninst; }; =20 /* the private variable of cipher */ @@ -233,6 +244,7 @@ struct rk_cipher_ctx { struct rk_cipher_rctx { u8 backup_iv[AES_BLOCK_SIZE]; u32 mode; + int ninst; struct skcipher_request fallback_req; // keep at the end }; =20 diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto= /rockchip/rk3288_crypto_ahash.c index 137013bd4410..28f4a7124683 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c @@ -83,33 +83,33 @@ static void rk_ahash_reg_init(struct ahash_request *req) struct crypto_ahash *tfm =3D crypto_ahash_reqtfm(req); struct rk_ahash_ctx *tctx =3D crypto_ahash_ctx(tfm); struct rk_crypto_info *dev =3D tctx->dev; + void __iomem *reg =3D dev->rki[rctx->ninst].reg; int reg_status; =20 - reg_status =3D CRYPTO_READ(dev, RK_CRYPTO_CTRL) | + reg_status =3D readl(reg + RK_CRYPTO_CTRL) | RK_CRYPTO_HASH_FLUSH | _SBF(0xffff, 16); - CRYPTO_WRITE(dev, RK_CRYPTO_CTRL, reg_status); + writel(reg_status, reg + RK_CRYPTO_CTRL); =20 - reg_status =3D CRYPTO_READ(dev, RK_CRYPTO_CTRL); + reg_status =3D readl(reg + RK_CRYPTO_CTRL); reg_status &=3D (~RK_CRYPTO_HASH_FLUSH); reg_status |=3D _SBF(0xffff, 16); - CRYPTO_WRITE(dev, RK_CRYPTO_CTRL, reg_status); + writel(reg_status, reg + RK_CRYPTO_CTRL); =20 - memset_io(dev->reg + RK_CRYPTO_HASH_DOUT_0, 0, 32); + memset_io(reg + RK_CRYPTO_HASH_DOUT_0, 0, 32); =20 - CRYPTO_WRITE(dev, RK_CRYPTO_INTENA, RK_CRYPTO_HRDMA_ERR_ENA | - RK_CRYPTO_HRDMA_DONE_ENA); + writel(RK_CRYPTO_HRDMA_ERR_ENA | RK_CRYPTO_HRDMA_DONE_ENA, + reg + RK_CRYPTO_INTENA); =20 - CRYPTO_WRITE(dev, RK_CRYPTO_INTSTS, RK_CRYPTO_HRDMA_ERR_INT | - RK_CRYPTO_HRDMA_DONE_INT); + writel(RK_CRYPTO_HRDMA_ERR_INT | RK_CRYPTO_HRDMA_DONE_INT, + reg + RK_CRYPTO_INTSTS); =20 - CRYPTO_WRITE(dev, RK_CRYPTO_HASH_CTRL, rctx->mode | - RK_CRYPTO_HASH_SWAP_DO); + writel(rctx->mode | RK_CRYPTO_HASH_SWAP_DO, + reg + RK_CRYPTO_HASH_CTRL); =20 - CRYPTO_WRITE(dev, RK_CRYPTO_CONF, RK_CRYPTO_BYTESWAP_HRFIFO | - RK_CRYPTO_BYTESWAP_BRFIFO | - RK_CRYPTO_BYTESWAP_BTFIFO); + writel(RK_CRYPTO_BYTESWAP_HRFIFO | RK_CRYPTO_BYTESWAP_BRFIFO | + RK_CRYPTO_BYTESWAP_BTFIFO, reg + RK_CRYPTO_CONF); =20 - CRYPTO_WRITE(dev, RK_CRYPTO_HASH_MSG_LEN, req->nbytes); + writel(req->nbytes, reg + RK_CRYPTO_HASH_MSG_LEN); } =20 static int rk_ahash_init(struct ahash_request *req) @@ -200,7 +200,9 @@ static int rk_ahash_export(struct ahash_request *req, v= oid *out) static int rk_ahash_digest(struct ahash_request *req) { struct rk_ahash_ctx *tctx =3D crypto_tfm_ctx(req->base.tfm); + struct rk_ahash_rctx *rctx =3D ahash_request_ctx(req); struct rk_crypto_info *dev =3D tctx->dev; + struct crypto_engine *engine; =20 if (rk_ahash_need_fallback(req)) return rk_ahash_digest_fb(req); @@ -208,15 +210,20 @@ static int rk_ahash_digest(struct ahash_request *req) if (!req->nbytes) return zero_message_process(req); =20 - return crypto_transfer_hash_request_to_engine(dev->engine, req); + rctx->ninst =3D rk_get_engine_number(dev); + engine =3D dev->rki[rctx->ninst].engine; + return crypto_transfer_hash_request_to_engine(engine, req); } =20 -static void crypto_ahash_dma_start(struct rk_crypto_info *dev, struct scat= terlist *sg) +static void crypto_ahash_dma_start(struct rk_crypto_info *dev, int ninst, + struct scatterlist *sg) { - CRYPTO_WRITE(dev, RK_CRYPTO_HRDMAS, sg_dma_address(sg)); - CRYPTO_WRITE(dev, RK_CRYPTO_HRDMAL, sg_dma_len(sg) / 4); - CRYPTO_WRITE(dev, RK_CRYPTO_CTRL, RK_CRYPTO_HASH_START | - (RK_CRYPTO_HASH_START << 16)); + void __iomem *reg =3D dev->rki[ninst].reg; + + writel(sg_dma_address(sg), reg + RK_CRYPTO_HRDMAS); + writel(sg_dma_len(sg) / 4, reg + RK_CRYPTO_HRDMAL); + writel(RK_CRYPTO_HASH_START | (RK_CRYPTO_HASH_START << 16), + reg + RK_CRYPTO_CTRL); } =20 static int rk_hash_prepare(struct crypto_engine *engine, void *breq) @@ -255,6 +262,8 @@ static int rk_hash_run(struct crypto_engine *engine, vo= id *breq) struct rk_ahash_ctx *tctx =3D crypto_ahash_ctx(tfm); struct ahash_alg *alg =3D __crypto_ahash_alg(tfm->base.__crt_alg); struct rk_crypto_tmp *algt =3D container_of(alg, struct rk_crypto_tmp, al= g.hash); + struct rk_instance *rki =3D &tctx->dev->rki[rctx->ninst]; + void __iomem *reg =3D tctx->dev->rki[rctx->ninst].reg; struct scatterlist *sg =3D areq->src; int err =3D 0; int i; @@ -282,12 +291,12 @@ static int rk_hash_run(struct crypto_engine *engine, = void *breq) rk_ahash_reg_init(areq); =20 while (sg) { - reinit_completion(&tctx->dev->complete); - tctx->dev->status =3D 0; - crypto_ahash_dma_start(tctx->dev, sg); - wait_for_completion_interruptible_timeout(&tctx->dev->complete, + reinit_completion(&rki->complete); + rki->status =3D 0; + crypto_ahash_dma_start(tctx->dev, rctx->ninst, sg); + wait_for_completion_interruptible_timeout(&rki->complete, msecs_to_jiffies(2000)); - if (!tctx->dev->status) { + if (!rki->status) { dev_err(tctx->dev->dev, "DMA timeout\n"); err =3D -EFAULT; goto theend; @@ -305,11 +314,11 @@ static int rk_hash_run(struct crypto_engine *engine, = void *breq) * efficiency, and make it response quickly when dma * complete. */ - while (!CRYPTO_READ(tctx->dev, RK_CRYPTO_HASH_STS)) + while (!readl(reg + RK_CRYPTO_HASH_STS)) udelay(10); =20 for (i =3D 0; i < crypto_ahash_digestsize(tfm) / 4; i++) { - v =3D readl(tctx->dev->reg + RK_CRYPTO_HASH_DOUT_0 + i * 4); + v =3D readl(reg + RK_CRYPTO_HASH_DOUT_0 + i * 4); put_unaligned_le32(v, areq->result + i * 4); } =20 diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/cry= pto/rockchip/rk3288_crypto_skcipher.c index 8d3a60db0cf6..f386ebb32e7c 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c +++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c @@ -95,11 +95,15 @@ static int rk_cipher_fallback(struct skcipher_request *= areq) static int rk_handle_req(struct rk_crypto_info *dev, struct skcipher_request *req) { - struct crypto_engine *engine =3D dev->engine; + struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); + struct crypto_engine *engine; =20 if (rk_cipher_need_fallback(req)) return rk_cipher_fallback(req); =20 + rctx->ninst =3D rk_get_engine_number(dev); + engine =3D dev->rki[rctx->ninst].engine; + return crypto_transfer_skcipher_request_to_engine(engine, req); } =20 @@ -290,6 +294,7 @@ static void rk_ablk_hw_init(struct rk_crypto_info *dev,= struct skcipher_request struct rk_cipher_rctx *rctx =3D skcipher_request_ctx(req); struct rk_cipher_ctx *ctx =3D crypto_skcipher_ctx(cipher); u32 block, conf_reg =3D 0; + void __iomem *reg =3D dev->rki[rctx->ninst].reg; =20 block =3D crypto_tfm_alg_blocksize(tfm); =20 @@ -297,8 +302,8 @@ static void rk_ablk_hw_init(struct rk_crypto_info *dev,= struct skcipher_request rctx->mode |=3D RK_CRYPTO_TDES_FIFO_MODE | RK_CRYPTO_TDES_BYTESWAP_KEY | RK_CRYPTO_TDES_BYTESWAP_IV; - CRYPTO_WRITE(dev, RK_CRYPTO_TDES_CTRL, rctx->mode); - memcpy_toio(ctx->dev->reg + RK_CRYPTO_TDES_KEY1_0, ctx->key, ctx->keylen= ); + writel(rctx->mode, reg + RK_CRYPTO_TDES_CTRL); + memcpy_toio(reg + RK_CRYPTO_TDES_KEY1_0, ctx->key, ctx->keylen); conf_reg =3D RK_CRYPTO_DESSEL; } else { rctx->mode |=3D RK_CRYPTO_AES_FIFO_MODE | @@ -309,25 +314,27 @@ static void rk_ablk_hw_init(struct rk_crypto_info *de= v, struct skcipher_request rctx->mode |=3D RK_CRYPTO_AES_192BIT_key; else if (ctx->keylen =3D=3D AES_KEYSIZE_256) rctx->mode |=3D RK_CRYPTO_AES_256BIT_key; - CRYPTO_WRITE(dev, RK_CRYPTO_AES_CTRL, rctx->mode); - memcpy_toio(ctx->dev->reg + RK_CRYPTO_AES_KEY_0, ctx->key, ctx->keylen); + writel(rctx->mode, reg + RK_CRYPTO_AES_CTRL); + memcpy_toio(reg + RK_CRYPTO_AES_KEY_0, ctx->key, ctx->keylen); } conf_reg |=3D RK_CRYPTO_BYTESWAP_BTFIFO | RK_CRYPTO_BYTESWAP_BRFIFO; - CRYPTO_WRITE(dev, RK_CRYPTO_CONF, conf_reg); - CRYPTO_WRITE(dev, RK_CRYPTO_INTENA, - RK_CRYPTO_BCDMA_ERR_ENA | RK_CRYPTO_BCDMA_DONE_ENA); + writel(conf_reg, reg + RK_CRYPTO_CONF); + writel(RK_CRYPTO_BCDMA_ERR_ENA | RK_CRYPTO_BCDMA_DONE_ENA, + reg + RK_CRYPTO_INTENA); } =20 -static void crypto_dma_start(struct rk_crypto_info *dev, +static void crypto_dma_start(struct rk_crypto_info *dev, int ninst, struct scatterlist *sgs, struct scatterlist *sgd, unsigned int todo) { - CRYPTO_WRITE(dev, RK_CRYPTO_BRDMAS, sg_dma_address(sgs)); - CRYPTO_WRITE(dev, RK_CRYPTO_BRDMAL, todo); - CRYPTO_WRITE(dev, RK_CRYPTO_BTDMAS, sg_dma_address(sgd)); - CRYPTO_WRITE(dev, RK_CRYPTO_CTRL, RK_CRYPTO_BLOCK_START | - _SBF(RK_CRYPTO_BLOCK_START, 16)); + void __iomem *reg =3D dev->rki[ninst].reg; + + writel(sg_dma_address(sgs), reg + RK_CRYPTO_BRDMAS); + writel(todo, reg + RK_CRYPTO_BRDMAL); + writel(sg_dma_address(sgd), reg + RK_CRYPTO_BTDMAS); + writel(RK_CRYPTO_BLOCK_START | _SBF(RK_CRYPTO_BLOCK_START, 16), + reg + RK_CRYPTO_CTRL); } =20 static int rk_cipher_run(struct crypto_engine *engine, void *async_req) @@ -348,6 +355,8 @@ static int rk_cipher_run(struct crypto_engine *engine, = void *async_req) unsigned int todo; struct skcipher_alg *alg =3D crypto_skcipher_alg(tfm); struct rk_crypto_tmp *algt =3D container_of(alg, struct rk_crypto_tmp, al= g.skcipher); + struct rk_instance *rki =3D &ctx->dev->rki[rctx->ninst]; + void __iomem *reg =3D ctx->dev->rki[rctx->ninst].reg; =20 algt->stat_req++; =20 @@ -396,19 +405,19 @@ static int rk_cipher_run(struct crypto_engine *engine= , void *async_req) rk_ablk_hw_init(ctx->dev, areq); if (ivsize) { if (ivsize =3D=3D DES_BLOCK_SIZE) - memcpy_toio(ctx->dev->reg + RK_CRYPTO_TDES_IV_0, ivtouse, ivsize); + memcpy_toio(reg + RK_CRYPTO_TDES_IV_0, ivtouse, ivsize); else - memcpy_toio(ctx->dev->reg + RK_CRYPTO_AES_IV_0, ivtouse, ivsize); + memcpy_toio(reg + RK_CRYPTO_AES_IV_0, ivtouse, ivsize); } - reinit_completion(&ctx->dev->complete); - ctx->dev->status =3D 0; + reinit_completion(&rki->complete); + rki->status =3D 0; =20 todo =3D min(sg_dma_len(sgs), len); len -=3D todo; - crypto_dma_start(ctx->dev, sgs, sgd, todo / 4); - wait_for_completion_interruptible_timeout(&ctx->dev->complete, + crypto_dma_start(ctx->dev, rctx->ninst, sgs, sgd, todo / 4); + wait_for_completion_interruptible_timeout(&rki->complete, msecs_to_jiffies(2000)); - if (!ctx->dev->status) { + if (!rki->status) { dev_err(ctx->dev->dev, "DMA timeout\n"); err =3D -EFAULT; goto theend; --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8148DC433FE for ; Mon, 21 Mar 2022 20:09:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353156AbiCUUKw (ORCPT ); Mon, 21 Mar 2022 16:10:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353019AbiCUUJv (ORCPT ); Mon, 21 Mar 2022 16:09:51 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40620CE0 for ; Mon, 21 Mar 2022 13:08:04 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id v22so8308534wra.2 for ; Mon, 21 Mar 2022 13:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9ucjurjOvrnrrbawIJXLKDlqa8V8uccBbyHnKi4+U0E=; b=3wuPfy2RH+Ymxx/9SwcWmTDsnnJEKwy/r9XF6UO5MnE+O8LuVg6+0EzZnQfixXVAvP VkH9TpOf6SHabA+zBwjbo9v6wt2HrypvzA8FG1hHvBBUd/y0l6gmEINU6AFVQGXxI5En U5Ds7xy1uYkiUXBTx6dWcGWll13LPaVrTUjryrVyc76cpC20WVohsCJCxrKyYfnEFk7Q QrSW4FIDI1Zed5rtVxgw3TIdefmHnrJ3mgrjvzhNajq1rSgODe5zPj6NXxjVTZJ0mbFu nRTGEYf06+zIg+kq5vvn84dExn3QrgSxwZ866mnMpBAx5VPMjy9l57uWiwiGlGYRvui2 W2lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9ucjurjOvrnrrbawIJXLKDlqa8V8uccBbyHnKi4+U0E=; b=UjaR9bmPpfZhCfZ/pGC+pGjuQyBUWLVmPh6BBeo2CkJjaXuk1edbGlqP2VBeWxgaF7 C19zPCN6Z/5IMKCcJVMSHvwCnEWhyU+hh3u/xqcrWG8nDI8xthxpcOYWts09NP/+3868 TvFeJ0EA/2Uk1aMyRje6jxAcHDpQUU8ktKdWMY1svbdfG34F7PTlWelSJkJmGrGBo8D6 5EMmS6spx71keobVPmZyymZjvmaCrMRBrYIEZQIs+uERh0e+HD7ORuJ0Ov9GU63P/0es FmNW/LH4+MrivStmqL97aOGEiYGzfj+Vckos/sj9kwqDvEvK6JIOepzszrqWNzSYAUYQ jAhA== X-Gm-Message-State: AOAM530WpZ5xmWpTefsieDtuiYB26bvwEluC6HXTmhQQ5AXdYGKyyhur XeZZtUZyd2IA+hkqraQw0W/XwQ== X-Google-Smtp-Source: ABdhPJyE/LR3AyjH3tqnMFFD+/rjJUMIzhATha74RVKWFJS8fgaKQKdvfFPfuNT01HSFlOARgkVZOw== X-Received: by 2002:a5d:5255:0:b0:203:ec9c:6d5e with SMTP id k21-20020a5d5255000000b00203ec9c6d5emr17807215wrc.70.1647893282761; Mon, 21 Mar 2022 13:08:02 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:08:02 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 17/26] clk: rk3399: use proper crypto0 name Date: Mon, 21 Mar 2022 20:07:30 +0000 Message-Id: <20220321200739.3572792-18-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rk3399 has 2 crypto instance, reset for crypto1 is correctly named, but crypto0 not. Add a 0 to be consistent. Signed-off-by: Corentin Labbe --- include/dt-bindings/clock/rk3399-cru.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/dt-bindings/clock/rk3399-cru.h b/include/dt-bindings/c= lock/rk3399-cru.h index 44e0a319f077..39169d94a44e 100644 --- a/include/dt-bindings/clock/rk3399-cru.h +++ b/include/dt-bindings/clock/rk3399-cru.h @@ -547,8 +547,8 @@ #define SRST_H_PERILP0 171 #define SRST_H_PERILP0_NOC 172 #define SRST_ROM 173 -#define SRST_CRYPTO_S 174 -#define SRST_CRYPTO_M 175 +#define SRST_CRYPTO0_S 174 +#define SRST_CRYPTO0_M 175 =20 /* cru_softrst_con11 */ #define SRST_P_DCF 176 @@ -556,7 +556,7 @@ #define SRST_CM0S 178 #define SRST_CM0S_DBG 179 #define SRST_CM0S_PO 180 -#define SRST_CRYPTO 181 +#define SRST_CRYPTO0 181 #define SRST_P_PERILP1_SGRF 182 #define SRST_P_PERILP1_GRF 183 #define SRST_CRYPTO1_S 184 --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3FAC433F5 for ; Mon, 21 Mar 2022 20:09:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353023AbiCUULH (ORCPT ); Mon, 21 Mar 2022 16:11:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353039AbiCUUJw (ORCPT ); Mon, 21 Mar 2022 16:09:52 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C058181B38 for ; Mon, 21 Mar 2022 13:08:05 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id l1-20020a05600c4f0100b00389645443d2so174852wmq.2 for ; Mon, 21 Mar 2022 13:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Bc8iW2Y0p9EgNyzaPB9ofcw8MbDcjRfG8JdfcAHFb9c=; b=vPZ/T6QEQRI5o5bMpxza/WJQImKeu2kaxYIN8+9IjmsqwJLvIW9K+APd3EqKjRyzIJ DcbKbvtRdMho6bSss1EIZHOZjvyzb5TbVl2tCRBYuFOyiCyzUjeXdKU52DXmJR9biEOM i1t5XgGdmtBAIjZVbWf5ZvXwZ1e3CktFylVHsnV/ub6JFIsKvYNSZbSJIWUrNC6JGFNt 9e12+Mwv2ZpheIHi5kYdGDVWhpwcaCOEYEdL3S75wmRVPe0NYmBS0Z/4lNRmNrSJIbUv tLCm4v4HISJv2KcvORMQeEMi1/hqjnqeA8963xbvMmmyyQIhQHslfOHFgo8t1o54ecUd 7x6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bc8iW2Y0p9EgNyzaPB9ofcw8MbDcjRfG8JdfcAHFb9c=; b=cJxsC+KjyfmV5jSrO4SJXTCgMLZGQMRsfUilEFaHtOmy9bvcmcnTRIrsdJArmtxLOV WZ1v2JHSIiVWtNcVApdyyyqvAcp7vWh6iRIBt/FbwhphJOqWsBbpZioVVonpztuFoqHE IAqw4BT4654Pb9Z3Dul6oZkR6jk8jnjRJJ/LKysg1SMnCAA3k6ihaAZcQZ0acje1WGjn MFj1dD+QL36Gg/Js5PopWbD2YszgC29OJw1U8AYU53gA/uaBQsPMfnm/4qC1Uze1sI0X MkXEWaSTpEvy4ZDwhAwu8XRD4KYdoSws1xUE+Y341VqRbrPtc4awo81pgdJf86WFXzMF 0iFA== X-Gm-Message-State: AOAM532aLKXqDIlk+iru6Tra9CQGnnnb+anxneTQDhIQTES5ev0Gs+aD BzcizMjIEA0DLsgMM6U7wK6Zkw== X-Google-Smtp-Source: ABdhPJy3YhrNZyJegsZ4K1MpM/YfOrXBlYIaHDQMjBJoBFW5PFV/x3FE3e88dikg4ydj/4FOrTqSUA== X-Received: by 2002:a05:600c:19cd:b0:38c:b84f:41fb with SMTP id u13-20020a05600c19cd00b0038cb84f41fbmr27683wmq.137.1647893283516; Mon, 21 Mar 2022 13:08:03 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:08:03 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 18/26] arm64: dts: rockchip: rk3399: add crypto node Date: Mon, 21 Mar 2022 20:07:31 +0000 Message-Id: <20220321200739.3572792-19-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The rk3399 has a crypto IP handled by the rk3288 crypto driver so adds a node for it. Signed-off-by: Corentin Labbe --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts= /rockchip/rk3399.dtsi index 88f26d89eea1..ca2c658371a5 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi @@ -573,6 +573,18 @@ saradc: saradc@ff100000 { status =3D "disabled"; }; =20 + crypto0: crypto@ff8b0000 { + compatible =3D "rockchip,rk3399-crypto"; + reg =3D <0x0 0xff8b0000 0x0 0x4000>, + <0x0 0xff8b8000 0x0 0x4000>; + interrupts =3D , + ; + clocks =3D <&cru SCLK_CRYPTO0>, <&cru HCLK_M_CRYPTO0>, <&cru HCLK_S_CRYP= TO0>, + <&cru SCLK_CRYPTO1>, <&cru HCLK_M_CRYPTO1>, <&cru HCLK_S_CRYPTO1>; + resets =3D <&cru SRST_CRYPTO0>, <&cru SRST_CRYPTO0_S>, <&cru SRST_CRYPTO= 0_M>, + <&cru SRST_CRYPTO1>, <&cru SRST_CRYPTO1_S>, <&cru SRST_CRYPTO1_M>; + }; + i2c1: i2c@ff110000 { compatible =3D "rockchip,rk3399-i2c"; reg =3D <0x0 0xff110000 0x0 0x1000>; --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E28C433FE for ; Mon, 21 Mar 2022 20:09:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353078AbiCUULD (ORCPT ); Mon, 21 Mar 2022 16:11:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353031AbiCUUJw (ORCPT ); Mon, 21 Mar 2022 16:09:52 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE57D182ACD for ; Mon, 21 Mar 2022 13:08:05 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id r10so22253401wrp.3 for ; Mon, 21 Mar 2022 13:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ALP0rhmdyOFskfZyrCUywCyi9ACOSmK3EYQ8ApiRER4=; b=PgoKWs6BqTd0YVwXlKBTcyBVNt7mdUfOIGxdK2fjBUMqsY8QYZujGa40w7xZBZA/yp esIJw6J9JSeWIhA+U6x2mYwng+KEadRC1WZHfCqjm0WL/XS3cQcbxVphfXFhjW7U03L4 SNF/O75AKTknPDP2nfoWBmQEH5lTIMm9DWh1VCa4ZX7nP/eynUi5fmB0QP30fkDj7k5Z sAtqVOVA9VEEw36jbB62quDplN0EFDiUtJ9Una41golcgA5MfXd7pzSuAvzbkakLaeaf SE/tp7FpbXGtBq8Vd2tcXJI8tzVejLR3DGCuOlBj9FPXxChNf47ychi8mDpXDCqNpLEZ /Olg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ALP0rhmdyOFskfZyrCUywCyi9ACOSmK3EYQ8ApiRER4=; b=d3at7gaNjWrqNdAIFm/HBTfLGcM7kvGxKNMSIitaHeuFKsvPCnIN5VG6QqIzOkknq8 mX/t8iwGuCElHfZH7cGCUKW/3MDKG6/CN/y6Iuv1R4mJ0lN23H/g4A1e1tsXd19aeceK Q+tKZCXcmPFnOchkzsOpCtTp9+urWjSzcFlwRPg48zv45tEA+LeHQ14Mg9eU+cZOrHVw vmsewl5SNxQefglEi4E8/GjMf92beSE//epgeUmKJSmsAfXLnG3uqZXYu2bOOb3wzbsT 7eaRj7mk94ItxvGeH45aXMVL30I7tyijvDZP482uTCfKsVfAsp0MXI60FXdck+SfC2Gy mJbg== X-Gm-Message-State: AOAM531N2bcobX8ar4Ho9IdwLSwDYcIEpczmEutle/3/tHPtNYBiZ5q2 IFZHrcSoni48SXf3e9T3LIGs2A== X-Google-Smtp-Source: ABdhPJzDjnGj7IJraPSCtEXEfN9Mb8TcdmAUQ8cWd4O9rEnCAZpJ5de3D55tdtOi3oK+SbIlHh7IFg== X-Received: by 2002:adf:8128:0:b0:203:e32d:4d03 with SMTP id 37-20020adf8128000000b00203e32d4d03mr19172030wrm.540.1647893284321; Mon, 21 Mar 2022 13:08:04 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:08:04 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 19/26] arm64: dts: rockchip: add rk3328 crypto node Date: Mon, 21 Mar 2022 20:07:32 +0000 Message-Id: <20220321200739.3572792-20-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rk3328 has a crypto IP handled by the rk3288 crypto driver so adds a node for it. Signed-off-by: Corentin Labbe --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts= /rockchip/rk3328.dtsi index b822533dc7f1..e83e0bf7e517 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi @@ -1007,6 +1007,16 @@ gic: interrupt-controller@ff811000 { (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; }; =20 + crypto: crypto@ff060000 { + compatible =3D "rockchip,rk3328-crypto"; + reg =3D <0x0 0xff060000 0x0 0x4000>; + interrupts =3D ; + clocks =3D <&cru HCLK_CRYPTO_MST>, <&cru HCLK_CRYPTO_SLV>, + <&cru SCLK_CRYPTO>; + clock-names =3D "hclk_master", "hclk_slave", "sclk"; + resets =3D <&cru SRST_CRYPTO>; + }; + pinctrl: pinctrl { compatible =3D "rockchip,rk3328-pinctrl"; rockchip,grf =3D <&grf>; --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE99CC433EF for ; Mon, 21 Mar 2022 20:09:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353091AbiCUULO (ORCPT ); Mon, 21 Mar 2022 16:11:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353055AbiCUUJy (ORCPT ); Mon, 21 Mar 2022 16:09:54 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8B5B182D92 for ; Mon, 21 Mar 2022 13:08:06 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id h23so21608556wrb.8 for ; Mon, 21 Mar 2022 13:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=glbkwheqgo+YAwXKKccRcXjFIyD1/ids9/fwj2aHXuM=; b=IIFdmZFGMTy1XTsiFJ2yuqXCl4xUkZYDLDbpk+6xncAzjuKnt6aj29k14JEwZtQxcT q9iZem4IhopHHo2Pi25oKJ5SGuvfeQBLl/gneyZ22nthVW0TOqxNEFibVrf2TWeBOigu 6NicvGvRoHntUToJ0n0snGfypZyo2f/OdxCLh6rBUHcwpIJRkXC1GGyq//bX6MUlHq9J Mbrv+brDGYH7J0c+BwIzgFLX26OOLAgUoTbAOKXNLUEuEosOi0lFGvrVmNvNb6EhZRNE IwuXCSte1ffXtUE4wxgTyKSlbwxn2ow0fCODAo0hi5WGjmDCLMR18NcyYERWnR6MfKlQ /Jiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=glbkwheqgo+YAwXKKccRcXjFIyD1/ids9/fwj2aHXuM=; b=hnCZmgfCR2oxAQiUXBvwO5WVPekSV/vr0jYYu7sWaSmHb+RuqmHX4RRDrvfBQUH5mk 9OIwzhPsDNuohgfh4KMC8KjjqTHElD5ccZxs/n+h/YRrYi/J3vwu/Yvi0OOdKV4eGR0z g0Kua02WCBS+wW7++nZlNWnHWD9qUZFVksXEncBLOR3vcwFJXvwCmaQpsJm74IlVvgau RloiAgvkH2NNuRtZU1AF922+qDYUgP4mq+ijYkCaWeUlPsVS380FKgF+lriqvd1VYcWb QAZkhMy3M3dU3f3Yw+kawcRQDlf3DDLUUibhVjc6tk/JUl07aJjDLzqH354WSr3WAQj0 E/gw== X-Gm-Message-State: AOAM532YUl11qPdvTpAPDcirOAdZABNdAsE8pc/fBZUsSJS/5o+E/DC8 lcbll2prEWETNFtN00rtFC5QMw== X-Google-Smtp-Source: ABdhPJz7fCs1t2aqp8p1p2t3TcSgtujQDHRA0ZZy7GQGPnJaxekip2TbpedVAZt8pxnpLiZRg9JGPg== X-Received: by 2002:a5d:6483:0:b0:203:801e:ad1b with SMTP id o3-20020a5d6483000000b00203801ead1bmr19292641wri.30.1647893285166; Mon, 21 Mar 2022 13:08:05 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.08.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:08:04 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 20/26] ARM: dts: rk3288: crypto does not need reset-names anymore Date: Mon, 21 Mar 2022 20:07:33 +0000 Message-Id: <20220321200739.3572792-21-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" reset-names are not necessary anymore for the crypto node. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/rk3288.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 26b9bbe310af..50f0890b3f6e 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -979,7 +979,6 @@ crypto: crypto@ff8a0000 { <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>; clock-names =3D "aclk", "hclk", "sclk", "apb_pclk"; resets =3D <&cru SRST_CRYPTO>; - reset-names =3D "crypto-rst"; }; =20 iep_mmu: iommu@ff900800 { --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0546CC433F5 for ; Mon, 21 Mar 2022 20:09:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345335AbiCUULM (ORCPT ); Mon, 21 Mar 2022 16:11:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353045AbiCUUJw (ORCPT ); Mon, 21 Mar 2022 16:09:52 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 706C51834C4 for ; Mon, 21 Mar 2022 13:08:07 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id q8so10859636wrc.0 for ; Mon, 21 Mar 2022 13:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DGQHyhE/73CNabvymhoJTcg8Bi3arW1cv1zfXXK1DZo=; b=aEualytqvjRyUY7VI/hrJxlyktgpE0UuuhEy4bx3ZxwrMAcBa6DMwt3TEwRyup+2mt KhzT7uPiMMiOAYaV005/FX1UjV9DZ0fBHg7zMQ8p43h8ICi7NY7H0/fqFPltz5e6uIRZ +QvN6PEevUN/jeJC1ptck07oV2uvFzQhDr9+stuGUb22KrtetfQ16eQWk5FtghavQTTf hLAY+VoUXR9zHVEGbbLKAFZPOHdd+Jp0NQcKJu3b9AtEwhTRhlCYN53eABSSOYjj6YV4 jrVa5IaATxWEyIHkMMBIWnbzTgeFQAZs3IP/eXLkiglNZMxUowqcUB6t2L84+3WOHlMf aeXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DGQHyhE/73CNabvymhoJTcg8Bi3arW1cv1zfXXK1DZo=; b=DP0c3/QjitHD9XpbRAc+z9U6XP8o7qlrnweyRR6DUfV3l5NjADXqStDPCeG9V/di0z q8EIdnXpajWpYPuKqCHw+XGkL8KMr+3zBxuSnWdosHw5eWvmVNfqPP6gnfxy1zyrLW1s +2ulpb7LwLl+8yRnv4sgot5SHfIouZ7x81Mw/CYLHHAUuZqy4n6+KK/itgahPkzrNtCK hKxZCri/NJuASk58s8R6WyT0K8wcZcfawQe70Pj5OAvO1ld0dF9VzbrbRWpj5HUkcKCy lVkm7krK9ehTsj9LrYguUmx0K8duc8yT8ZCcUM2XxwZbPegaz0ojM30XsVFSo1BUb0UQ kgDg== X-Gm-Message-State: AOAM53223FuN7Yqn5Jau3x5peYAIRH/TxdHXGYneN9qGj1/CCqeixYp+ Z/0nOepafkEmEOhDb3TaRbREKg== X-Google-Smtp-Source: ABdhPJyClWStPMofGThgNOqaGK50UdbzCCGvlkQJgVVh8veL4GE8YXyqpASVm2SkWcM+LzazrquFTA== X-Received: by 2002:a05:6000:144e:b0:203:e36c:74b3 with SMTP id v14-20020a056000144e00b00203e36c74b3mr20171231wrx.565.1647893285974; Mon, 21 Mar 2022 13:08:05 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.08.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:08:05 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 21/26] dt-bindings: crypto: convert rockchip-crypto to yaml Date: Mon, 21 Mar 2022 20:07:34 +0000 Message-Id: <20220321200739.3572792-22-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Convert rockchip-crypto to yaml Signed-off-by: Corentin Labbe --- .../crypto/rockchip,rk3288-crypto.yaml | 84 +++++++++++++++++++ .../bindings/crypto/rockchip-crypto.txt | 28 ------- 2 files changed, 84 insertions(+), 28 deletions(-) create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk328= 8-crypto.yaml delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypt= o.txt diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypt= o.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.ya= ml new file mode 100644 index 000000000000..a6be89a1c890 --- /dev/null +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml @@ -0,0 +1,84 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/crypto/rockchip,rk3288-crypto.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip Electronics And Security Accelerator + +maintainers: + - Heiko Stuebner + +properties: + compatible: + enum: + - rockchip,rk3288-crypto + - rockchip,rk3328-crypto + - rockchip,rk3399-crypto + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + minItems: 4 + + clock-names: + minItems: 4 + + resets: + maxItems: 1 + +if: + properties: + compatible: + const: rockchip,rk3399-crypto +then: + properties: + reg: + minItems: 2 + interrupts: + minItems: 2 + clocks: + minItems: 6 + clock-names: + minItems: 6 + resets: + minItems: 6 +else: + if: + properties: + compatible: + const: rockchip,rk3328-crypto + then: + properties: + clocks: + minItems: 3 + clock-names: + minItems: 3 + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + - resets + +additionalProperties: false + +examples: + - | + #include + #include + crypto@ff8a0000 { + compatible =3D "rockchip,rk3288-crypto"; + reg =3D <0xff8a0000 0x4000>; + interrupts =3D ; + clocks =3D <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>, + <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>; + clock-names =3D "aclk", "hclk", "sclk", "apb_pclk"; + resets =3D <&cru SRST_CRYPTO>; + }; diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt b= /Documentation/devicetree/bindings/crypto/rockchip-crypto.txt deleted file mode 100644 index 5e2ba385b8c9..000000000000 --- a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt +++ /dev/null @@ -1,28 +0,0 @@ -Rockchip Electronics And Security Accelerator - -Required properties: -- compatible: Should be "rockchip,rk3288-crypto" -- reg: Base physical address of the engine and length of memory mapped - region -- interrupts: Interrupt number -- clocks: Reference to the clocks about crypto -- clock-names: "aclk" used to clock data - "hclk" used to clock data - "sclk" used to clock crypto accelerator - "apb_pclk" used to clock dma -- resets: Must contain an entry for each entry in reset-names. - See ../reset/reset.txt for details. -- reset-names: Must include the name "crypto-rst". - -Examples: - - crypto: cypto-controller@ff8a0000 { - compatible =3D "rockchip,rk3288-crypto"; - reg =3D <0xff8a0000 0x4000>; - interrupts =3D ; - clocks =3D <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>, - <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>; - clock-names =3D "aclk", "hclk", "sclk", "apb_pclk"; - resets =3D <&cru SRST_CRYPTO>; - reset-names =3D "crypto-rst"; - }; --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E384DC433F5 for ; Mon, 21 Mar 2022 20:09:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237687AbiCUULS (ORCPT ); Mon, 21 Mar 2022 16:11:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353001AbiCUUJ6 (ORCPT ); Mon, 21 Mar 2022 16:09:58 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D7471834E1 for ; Mon, 21 Mar 2022 13:08:08 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id h23so21608638wrb.8 for ; Mon, 21 Mar 2022 13:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KKQIZ8jXpBKaieCflF0TRZBAI0CizxmrIeEedyXM13o=; b=xwGWaPIxsJtw1F30UvWCKmUgnDyZOwOcJWbagXXvLSDhkHTI0ZRhzVADNnTlEyOoB0 lwAXUoXQuz9yAaR/zpIVOVLLjkk+Zh/JkM85bx86GufMvQxoRpLXWMzCisU5ssO/i0El n0t2KyNfF91/u3jTzbfGpjjsAdtoN8eqvIL/YQNlQhfQ+SBU+g+GQBkMs6JdKcWXzsAX zXh+wqDoB+BV8aySN6zfDLPdnI/O/UA9Mu+AtefcqeIrbBRATcaQdZ1GvhCgYBV4vZ57 pF2RezgivY0en7SmC6nV6Cy5xvXn63ExrUPdada1ZbiyeFgAvkQhuCuU8G9AhIziGYB7 yZ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KKQIZ8jXpBKaieCflF0TRZBAI0CizxmrIeEedyXM13o=; b=w24eihn2fr4C6HjMK9629nhIt/34nQrPbae2nJrsS4YNGpxdi/MvYcO+XfBTjLdW5g 6tGXaSojj2sutMe3Ki+oZphX+npgbRAJFIyijvbTnMq4DO2WNBEeHYdd8+sd3JP9+nRr F4xgLYIP7NG2b62s1j6iJTqM/LGGjmGnnl8F6S5uz8Vt9x5lSjF6Fc81lIDd5t7yshcn I6iL7jVdlWjfaoMWXa/ylen65fLYvs+U6CEcdYvLWJIU6d9eBEv7rDNxiFPXImrimv28 CMnpx/uOfhPjGJOtc5rvvggR5hcJT7Ex4kqHQiohRSOeuHzpJs3+lZtZAOGBHhXedw2u x7Ig== X-Gm-Message-State: AOAM530s4EL5LYtRCI0zob2FFrCS0+LkP71j+2xZuvbFDWeE+QWVGYGj r4Tbf0JxY+fwQLguAPlJ7KuvEg== X-Google-Smtp-Source: ABdhPJwZkUNjMvKbTUN2HxHXxoH9tJ6RsaGOP6up/Huupq5DDHCueRCHLJ4pVYum6Blg/i5/uq9qXA== X-Received: by 2002:a5d:47cc:0:b0:204:1c9d:2157 with SMTP id o12-20020a5d47cc000000b002041c9d2157mr2642754wrc.294.1647893286777; Mon, 21 Mar 2022 13:08:06 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.08.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:08:06 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 22/26] crypto: rockchip: add support for rk3328 Date: Mon, 21 Mar 2022 20:07:35 +0000 Message-Id: <20220321200739.3572792-23-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add compatible and variant for rk3328. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index 5f1422094a7f..bb1adbe947f9 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -19,6 +19,10 @@ #include #include =20 +static const struct rk_variant rk3328_variant =3D { + .num_instance =3D 1, +}; + static const struct rk_variant rk3288_variant =3D { .num_instance =3D 1 }; @@ -215,6 +219,9 @@ static const struct of_device_id crypto_of_id_table[] = =3D { { .compatible =3D "rockchip,rk3288-crypto", .data =3D &rk3288_variant, }, + { .compatible =3D "rockchip,rk3328-crypto", + .data =3D &rk3328_variant, + }, { .compatible =3D "rockchip,rk3399-crypto", .data =3D &rk3399_variant, }, --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94CACC433F5 for ; Mon, 21 Mar 2022 20:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353193AbiCUULa (ORCPT ); Mon, 21 Mar 2022 16:11:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353077AbiCUUKI (ORCPT ); Mon, 21 Mar 2022 16:10:08 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FFD3183800 for ; Mon, 21 Mar 2022 13:08:09 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id h23so21608691wrb.8 for ; Mon, 21 Mar 2022 13:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y7w+zqe3BXjvjhchXa/pBa1pkRP5bMMQhUOTBznLw9o=; b=Ar1L+2wA/o0Q1EkoN38a9f7c73jKiqze4tO2slfF6d+t30zZ8dQqDCYQRkjeBh8Dsk hMqHjcCm501iWNMalE6VUn1bq4XXKr2jB6GfraCpwiy7Pqngk/r5jlkrzyKaYS3CJTPa /6KwzzhqH6cBSkf957di2qKLlZQ8uk0wLnwHw4WLAb2Df5e2DoRI0DH6F6msPQXwRlzH 7Q5fLQXJV+jWxt05rCTdWUN912h2wBHsZ1wQZ6fN6sFNMOdVpwQCOTdaU4/gaGaHVwcb VARjhoj3Ln1MuUSNWL4eh1CE7CG5zxjF9+DVJ1X41IRPGjC87rthU+Dg4dTOeZnPh3IE HhcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y7w+zqe3BXjvjhchXa/pBa1pkRP5bMMQhUOTBznLw9o=; b=SnkE8V8lfrJZI2oJaplLvOl2fztx1fkzbyA93kr6c8apItEo5HZnvjvGnxxC5R5Oxj oGqOo4Utz6RXGdRZSGyC/9viQATbMPlYFFxXMCBbFHNGcz7Un+PGClHCRaH+dDI2P2vf fGcXdAJtPW4afOCafBucpmN+b9FkuAFKRWnRkHmtJ8K9tXnvHGOvWI45h05F3nnZyBDP 6rbikEtF6b/SysPJHQX3dzLC/4+gPnAqU6TIn3X0o0CGmvop8IfKqReF4/vgQAD50jt1 mqB2J/HRKibaGSdQwHEUQnHXtQBV7Ir8IoFOdPUBGrj6CpdAB/lwrPflbCUBlb3V7s57 /RlQ== X-Gm-Message-State: AOAM530uF4gNAUg3GgSHwmVUTf7xIKJEo6uEm+j8s4DVC+3oRwff1/81 d78lF3bUBSPeg1K1yRu+sbw02Q== X-Google-Smtp-Source: ABdhPJwsy1g21VlpFB3wtwTflfz/CG4Cqj1CkSmAuDpWHDVVKi6WMOpu+elSjE5RWqjHtlshh+yWHw== X-Received: by 2002:adf:f20f:0:b0:203:fc73:a9a0 with SMTP id p15-20020adff20f000000b00203fc73a9a0mr12135240wro.418.1647893287604; Mon, 21 Mar 2022 13:08:07 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.08.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:08:07 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 23/26] crypto: rockchip: Check for maximum frequency of clocks Date: Mon, 21 Mar 2022 20:07:36 +0000 Message-Id: <20220321200739.3572792-24-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rockchip's datasheet give maximum frequencies for some clocks, so add checks for verifying they are within limits. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 57 +++++++++++++++++++++---- drivers/crypto/rockchip/rk3288_crypto.h | 9 ++++ 2 files changed, 57 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockc= hip/rk3288_crypto.c index bb1adbe947f9..ededae9f2671 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -21,16 +21,58 @@ =20 static const struct rk_variant rk3328_variant =3D { .num_instance =3D 1, + .num_clks =3D 3, }; =20 static const struct rk_variant rk3288_variant =3D { - .num_instance =3D 1 + .num_instance =3D 1, + .num_clks =3D 3, + .rkclks =3D { + { "sclk", 150000000}, + } }; =20 static const struct rk_variant rk3399_variant =3D { - .num_instance =3D 2 + .num_instance =3D 2, + .num_clks =3D 6, }; =20 +static int rk_crypto_get_clks(struct rk_crypto_info *dev) +{ + int i, j, err; + unsigned long cr; + + dev->num_clks =3D devm_clk_bulk_get_all(dev->dev, &dev->clks); + if (dev->num_clks < dev->variant->num_clks) { + dev_err(dev->dev, "Missing clocks, got %d instead of %d\n", + dev->num_clks, dev->variant->num_clks); + return -EINVAL; + } + + for (i =3D 0; i < dev->num_clks; i++) { + cr =3D clk_get_rate(dev->clks[i].clk); + for (j =3D 0; j < ARRAY_SIZE(dev->variant->rkclks); j++) { + if (dev->variant->rkclks[j].max =3D=3D 0) + continue; + if (strcmp(dev->variant->rkclks[j].name, dev->clks[i].id)) + continue; + if (cr > dev->variant->rkclks[j].max) { + err =3D clk_set_rate(dev->clks[i].clk, + dev->variant->rkclks[j].max); + if (err) + dev_err(dev->dev, "Fail downclocking %s from %lu to %lu\n", + dev->variant->rkclks[j].name, cr, + dev->variant->rkclks[j].max); + else + dev_info(dev->dev, "Downclocking %s from %lu to %lu\n", + dev->variant->rkclks[j].name, cr, + dev->variant->rkclks[j].max); + } + } + } + return 0; +} + static int rk_crypto_enable_clk(struct rk_crypto_info *dev) { int err; @@ -281,16 +323,13 @@ static int rk_crypto_probe(struct platform_device *pd= ev) goto err_crypto; } =20 - crypto_info->num_clks =3D devm_clk_bulk_get_all(&pdev->dev, - &crypto_info->clks); - if (crypto_info->num_clks < 3) { - err =3D -EINVAL; - goto err_crypto; - } - crypto_info->dev =3D &pdev->dev; platform_set_drvdata(pdev, crypto_info); =20 + err =3D rk_crypto_get_clks(crypto_info); + if (err) + goto err_crypto; + err =3D rk_crypto_pm_init(crypto_info); if (err) goto err_pm; diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockc= hip/rk3288_crypto.h index e1dac351bc64..8fd46cda5189 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.h +++ b/drivers/crypto/rockchip/rk3288_crypto.h @@ -183,8 +183,17 @@ #define RK_CRYPTO_HASH_DOUT_6 0x01a4 #define RK_CRYPTO_HASH_DOUT_7 0x01a8 =20 +#define RK_MAX_CLKS 6 + +struct rk_clks { + const char *name; + unsigned long max; +}; + struct rk_variant { int num_instance; + int num_clks; + struct rk_clks rkclks[RK_MAX_CLKS]; }; =20 struct rk_instance { --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6448DC433F5 for ; Mon, 21 Mar 2022 20:09:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353182AbiCUULU (ORCPT ); Mon, 21 Mar 2022 16:11:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353092AbiCUUKT (ORCPT ); Mon, 21 Mar 2022 16:10:19 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E12AB184609 for ; Mon, 21 Mar 2022 13:08:09 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id r133so58906wma.3 for ; Mon, 21 Mar 2022 13:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4gMoepUVOvRDAwTmdAmkWkLiyH53f2JJghRF0kAYUp8=; b=RDx+GXVUtpQmfbr16DO6Yq2LL7DbfVvfRBqBwtb6SSusIn9ZBx50PKSTikg0mRz6tc 6oxmv4dy2wKCWPdKx9D7rxLiZbRgyRs/vQu1V2merbLQjyFP/G0iT7zz/q3t9N7A6jt3 YLFAynrGGAnpEVVGUhBzCoA6t5wBknbzxTFFi0Gdy8lpKDyGwBOK3bdgMY8oY4/hMxB9 fOXBdOAkwGQhaLdRNWRHd66hiC+vndiHtkb158AufTRG3S2JhvwCYPagu93Xie5VkfJr k7eDzzS4x/f6cQ8uj4b/dNiRFrPoEyy+9+s1/r+A8XFZh+aXGywRjmweWthRxEpScRA+ QbTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4gMoepUVOvRDAwTmdAmkWkLiyH53f2JJghRF0kAYUp8=; b=1cOdLf0QDtB4/rRA0sg5r7tR017yPpJffbiwsulSUQuc4Hte4Zji9LtPMWjX3ZukOX WJgUETtfUkOp7pze2Kw2bEe/qWIFl2008xNnaOgwZH9SS4G1rPz3dRf6z7tBHElmZV0v dSwFJBu/9td9yYAFIbCwOSgZuDeYdKJ/uXleJDz/AcwAz8up6KPfA6TRbQEQnQ3q4nYg +ZuSQ8DgWIpoRrRtc3GIkpzvWLQjUirmt0BCtCbRkCRsye+jATQ/oQF/y/q+eJpc/2oi SCo/PfcsSCHFDpsBA0Li8d6eJ32yOLDxHSxL7eXjQxIG66nYetLlhLD2/n71EWnLIUtm l0hg== X-Gm-Message-State: AOAM533R6rfs1K8AiQM4KJtK01oqLAZbq4RQOCIRMgKy1zp7d9e05CLm KvLB1VwTXq5q0IsZAvgXZ2pkbQ== X-Google-Smtp-Source: ABdhPJwulLc2e95bjKUvggoQfu0QNbRnAFa6ydl55NbQ/vrr36S8Y+UYDhSh6EwwXvT6NSWfbKDUdg== X-Received: by 2002:a05:600c:5110:b0:38c:9521:8ef1 with SMTP id o16-20020a05600c511000b0038c95218ef1mr650466wms.107.1647893288443; Mon, 21 Mar 2022 13:08:08 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:08:08 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 24/26] crypto: rockchip: add myself as maintainer Date: Mon, 21 Mar 2022 20:07:37 +0000 Message-Id: <20220321200739.3572792-25-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Nobody is set as maintainer of rockchip crypto, I propose to do it as I have already reworked lot of this code. Signed-off-by: Corentin Labbe --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c520915a3222..df4c72d37116 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16937,6 +16937,13 @@ F: Documentation/ABI/*/sysfs-driver-hid-roccat* F: drivers/hid/hid-roccat* F: include/linux/hid-roccat* =20 +ROCKCHIP CRYPTO DRIVERS +M: Corentin Labbe +L: linux-crypto@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml +F: drivers/crypto/rockchip/ + ROCKCHIP I2S TDM DRIVER M: Nicolas Frattaroli L: linux-rockchip@lists.infradead.org --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 201DAC433F5 for ; Mon, 21 Mar 2022 20:10:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353187AbiCUUL0 (ORCPT ); Mon, 21 Mar 2022 16:11:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353096AbiCUUKT (ORCPT ); Mon, 21 Mar 2022 16:10:19 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA62318594B for ; Mon, 21 Mar 2022 13:08:10 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id t11so22243851wrm.5 for ; Mon, 21 Mar 2022 13:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7FqnmDcsvrgYbGP6OPh4RiTzDpGi2N0/p6IXPk696Vg=; b=cSv2fVbDJkMxVE7wCqRDiDoIM+o2oygSfZJi5Lo8JF+0nPoMSMuYGxZeV1grnEbf3Q 8+FMdFK/NBM/b72tKOQxCvMWYAXOzbs3ZjEUJ/0PF7fFTAjLE1uwEmqOfceAbSzxy3rE NZyqn5dK91pZm47mnumvMLE9ou9PkiBM0gVyOiNfSqapxOHQW7nu1CzewxtMQ6LPTVTo 4zO4nH7vJe04kqSNep/pTIgMSjc499naZ3dX0mHbD1noHXGaB6lA2tQVBBNLCZM5QN2D xOXR0qdJYolDSe4KrNDX94sylsi+Hkf5U2A6KiQC/ErJ2NDlF3kOa3Wpi5HraV7pn5O5 t60g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7FqnmDcsvrgYbGP6OPh4RiTzDpGi2N0/p6IXPk696Vg=; b=v/5Hpds/GeYRUyRq/FxBL0QH6Nu0tBNsYKSjGkYYTbF3CE5gKC4/0muRGqku2QynqJ yXmeJOJ/L2tJtfpxJb3wKwyFqwNh1Ssy3hzNXxVCEEKAjmZ3TfrFcw/sHTdBKZewYnGn vnrBFneD69EiWbbMrwXXwoVHDM6EJaNYV/OCS5sdRksm5D5cw0zuWz0a5EVC+dUYch7T 96XbM2aEWjXgKss9h3rJB6askQ34GRrSTnwKCOVV562cLZPBItYuzpyBR8YryJVZVjDe rWzcPzuW1+yg/jucldweo/udjBtVsUaHRCJI6xCBl17sQND13nPReQkf9eyEqkDXmLpN Dxaw== X-Gm-Message-State: AOAM532odR3+G60k6SYCsDJkggSU9bv7E4cM8tZEm8IFUhp9QNPBZ34S es/BzTxHj9hRhgH8i/0xg02P5A== X-Google-Smtp-Source: ABdhPJzWq4byShCgqQrYWFCe7oBReuZfefWI5AqTr4VVN54zmHM+SXxb+aSGKY0sN+bcl4fgvkgZsA== X-Received: by 2002:a5d:6746:0:b0:203:d6c1:9c5b with SMTP id l6-20020a5d6746000000b00203d6c19c5bmr19648307wrw.446.1647893289203; Mon, 21 Mar 2022 13:08:09 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:08:08 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 25/26] crypto: rockchip: fix style issue Date: Mon, 21 Mar 2022 20:07:38 +0000 Message-Id: <20220321200739.3572792-26-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch fixes some warning reported by checkpatch Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto_ahash.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto= /rockchip/rk3288_crypto_ahash.c index 28f4a7124683..1d20f58275f0 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c @@ -345,7 +345,7 @@ static int rk_cra_hash_init(struct crypto_tfm *tfm) =20 /* for fallback */ tctx->fallback_tfm =3D crypto_alloc_ahash(alg_name, 0, - CRYPTO_ALG_NEED_FALLBACK); + CRYPTO_ALG_NEED_FALLBACK); if (IS_ERR(tctx->fallback_tfm)) { dev_err(tctx->dev->dev, "Could not load fallback driver.\n"); return PTR_ERR(tctx->fallback_tfm); @@ -403,8 +403,8 @@ struct rk_crypto_tmp rk_ahash_sha1 =3D { .cra_init =3D rk_cra_hash_init, .cra_exit =3D rk_cra_hash_exit, .cra_module =3D THIS_MODULE, - } - } + } + } } }; =20 @@ -433,8 +433,8 @@ struct rk_crypto_tmp rk_ahash_sha256 =3D { .cra_init =3D rk_cra_hash_init, .cra_exit =3D rk_cra_hash_exit, .cra_module =3D THIS_MODULE, - } - } + } + } } }; =20 @@ -463,7 +463,7 @@ struct rk_crypto_tmp rk_ahash_md5 =3D { .cra_init =3D rk_cra_hash_init, .cra_exit =3D rk_cra_hash_exit, .cra_module =3D THIS_MODULE, - } } + } } }; --=20 2.34.1 From nobody Mon Jun 22 15:45:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A002C433EF for ; Mon, 21 Mar 2022 20:10:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348716AbiCUULq (ORCPT ); Mon, 21 Mar 2022 16:11:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353028AbiCUUKU (ORCPT ); Mon, 21 Mar 2022 16:10:20 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70B7C186881 for ; Mon, 21 Mar 2022 13:08:11 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id d7so22217173wrb.7 for ; Mon, 21 Mar 2022 13:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BLjOQyn7vWMkEPL3YYfpuMi7xJgnIr5nJYm6Y0L1/14=; b=jKZtZBoF+9D29LJdTrP/WOpH/cL6jYaJC9M0oJuNgOyTdPr1TJAPI1W2pBoz9Layd9 7uSO+zDYiRBUX0UM8LbbsPxXW91fIBcgIqvMT8eaf1xa2hWGc3CNRNq4CXuQ1Y6eu9eJ 6hqRRER8yr1rBhBksWX42igHEepCKJnCHaDZbl1Kp7FdNrkS4eBZohJS+YpYLOFo5z/p yrr3hOdZpAuRTTFF0I7rHrh+pqKRW7GmLAGgTcNBz/DiHtFUsoM0WMfltE7owv7QMGxZ jG9wL+y2FdunXMckttPckesTN2HvpfXNg9vM2yI26FsFxEqFPrWGb4NI9t1tVdn4jlPD oHXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BLjOQyn7vWMkEPL3YYfpuMi7xJgnIr5nJYm6Y0L1/14=; b=JdULBV5R+1r1GtyPo4deYhhJm37evpRz02qPZds4sm/MWKEAq5t1zQfd9FaS2o5Dce xmSPCHHQIo37mm38k7sKnsRUSR6vU6gDUuVlQzk8oVSqb+sIsQ4yzpiafp0D2SGzB0GA Ndp3/CGnqynjLjL+Ha2HhroD87c0cUiFO29yp7xbSo+V81ZkONyWBB45l8AToCyTbQ6X i10GF8HhZF28WEhQ5fAyw5Kg7z1gUHxyAGTtpe8GBjYDiGSLK5LCGuYT3S+cQGE2Xxzn fzYvrdBn4PdKlgccwGlmvgTM2EzQj6TWUGE6p2HrRxlY3zTxl+mjP2rWjJPxgnRce8/K yzDw== X-Gm-Message-State: AOAM530PH0+Qh/Ced/EJpsB1GfCkw12jTtGBUYGobAZfIZA+kfMOqgDU fFoMxyUBUVYHlB2W+ll6hNDCXw== X-Google-Smtp-Source: ABdhPJw+15wozTaGAkfF7E2x/BPx9ctqPg1cM7rmgS855iWGEC3nUElEC3OQjcdUVIZxkSJwNtjFmw== X-Received: by 2002:a5d:59a1:0:b0:204:1777:fc08 with SMTP id p1-20020a5d59a1000000b002041777fc08mr3924749wrr.545.1647893289973; Mon, 21 Mar 2022 13:08:09 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i14-20020a0560001ace00b00203da1fa749sm24426988wry.72.2022.03.21.13.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 13:08:09 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v3 26/26] crypto: rockchip: use read_poll_timeout Date: Mon, 21 Mar 2022 20:07:39 +0000 Message-Id: <20220321200739.3572792-27-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220321200739.3572792-1-clabbe@baylibre.com> References: <20220321200739.3572792-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use read_poll_timeout instead of open coding it. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto_ahash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto= /rockchip/rk3288_crypto_ahash.c index 1d20f58275f0..0ea47f50607e 100644 --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c @@ -9,6 +9,7 @@ * Some ideas are from marvell/cesa.c and s5p-sss.c driver. */ #include +#include #include #include "rk3288_crypto.h" =20 @@ -314,8 +315,7 @@ static int rk_hash_run(struct crypto_engine *engine, vo= id *breq) * efficiency, and make it response quickly when dma * complete. */ - while (!readl(reg + RK_CRYPTO_HASH_STS)) - udelay(10); + read_poll_timeout(readl, v, v =3D=3D 0, 10, 1000, false, reg + RK_CRYPTO_= HASH_STS); =20 for (i =3D 0; i < crypto_ahash_digestsize(tfm) / 4; i++) { v =3D readl(reg + RK_CRYPTO_HASH_DOUT_0 + i * 4); --=20 2.34.1