From nobody Mon Jun 22 16:49:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5DEEC433EF for ; Sat, 19 Mar 2022 15:31:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243486AbiCSPdA (ORCPT ); Sat, 19 Mar 2022 11:33:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243461AbiCSPc6 (ORCPT ); Sat, 19 Mar 2022 11:32:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 93DD72571A4 for ; Sat, 19 Mar 2022 08:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647703896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=RDYbzlAeYYOLKs0jJASD2ePoaygRETdsPOHhL2YcgAw=; b=Wv/7y0Atoy9y5Nh2ECQJzKYas2/V27pmOd8H/s0FPY6iE8faoQjCmoqgOCe0Zn9lRIGhda JimTwYoi9OFb5vexub+eb5GTFFwP9neo//oSatItlzmI4s6py3zht7n8KJPuCbIkQqfnkp Boxf/Lv8L+SUJUecCK98jWDw41r+e3c= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-669-dnK5vpV5OxyRhn32zkszRQ-1; Sat, 19 Mar 2022 11:31:34 -0400 X-MC-Unique: dnK5vpV5OxyRhn32zkszRQ-1 Received: by mail-qt1-f200.google.com with SMTP id f22-20020ac840d6000000b002dd4d87de21so7365257qtm.23 for ; Sat, 19 Mar 2022 08:31:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RDYbzlAeYYOLKs0jJASD2ePoaygRETdsPOHhL2YcgAw=; b=6bTYRizFyGLHoL/4d17xKAOIWpxWHjV1msaR/9dkxJBJrjQQdDZVFdh+Qpxsm2p/AB vwFD8J3njE04db5A85fYB4VWit7b5/49WkM4/sOOMDjB9oxGeOywBpYkty3hXr44+Jss 2S3AsFozTpH1XIqz4ucK2vCxqO5asU7UrzlI4f/VpFmgS7cpCTS1aoD4BdHSMQT594cw c+thMvxdvjxOhZCkY0lgSXZhv67rZV0Pn9WfY51P2lxUG1gjzcx6OfaCVFbZkq8XA8TO ViCH2tWtQ5pGjeHvD0ay/p6wv1vH7wOVtMZpmx3B1X0Dw499uUzB6LTxZxfC5Hzjhslk 43Zg== X-Gm-Message-State: AOAM531uURxYfrpSNrnXsvCjM3K9KT/6wtfXwuFezF3LLWtZa19WHpjA AsHxmIcb8VzTN5Iet1YvwKZmWKoONVdyvSrJaLxoGkmkSpkchNYK5Z/No74qmaIpm3E3WoMuKOw 5rgREXnPqPhH0KvGpeoZ76zXc X-Received: by 2002:a05:620a:430b:b0:67e:85d1:f53f with SMTP id u11-20020a05620a430b00b0067e85d1f53fmr376984qko.43.1647703894468; Sat, 19 Mar 2022 08:31:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJylEZz+szJS3qXk/iEXTdbF/WnpVfwDLcvLyw6fK6qEuP1X7aGSWen2MjQL9ePfNbUbvv7PgQ== X-Received: by 2002:a05:620a:430b:b0:67e:85d1:f53f with SMTP id u11-20020a05620a430b00b0067e85d1f53fmr376962qko.43.1647703894215; Sat, 19 Mar 2022 08:31:34 -0700 (PDT) Received: from localhost.localdomain.com (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id b2-20020ac87fc2000000b002e1b9ddb629sm7850596qtk.47.2022.03.19.08.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Mar 2022 08:31:33 -0700 (PDT) From: trix@redhat.com To: mkl@pengutronix.de, mani@kernel.org, thomas.kopp@microchip.com, wg@grandegger.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, nathan@kernel.org, ndesaulniers@google.com Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] can: mcp251xfd: return errors from mcp251xfd_register_get_dev_id Date: Sat, 19 Mar 2022 08:31:28 -0700 Message-Id: <20220319153128.2164120-1-trix@redhat.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Tom Rix Clang static analysis reports this issue mcp251xfd-core.c:1813:7: warning: The left operand of '&' is a garbage value FIELD_GET(MCP251XFD_REG_DEVID_ID_MASK, dev_id), ^ ~~~~~~ dev_id is set in a successful call to mcp251xfd_register_get_dev_id(). Though the status of calls made by mcp251xfd_register_get_dev_id() are checked and handled, their status' are not returned. So return err. Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SP= I CAN") Signed-off-by: Tom Rix --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/c= an/spi/mcp251xfd/mcp251xfd-core.c index 325024be7b045..f9dd8fdba12bc 100644 --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c @@ -1786,7 +1786,7 @@ mcp251xfd_register_get_dev_id(const struct mcp251xfd_= priv *priv, u32 *dev_id, out_kfree_buf_rx: kfree(buf_rx); =20 - return 0; + return err; } =20 #define MCP251XFD_QUIRK_ACTIVE(quirk) \ --=20 2.26.3