From nobody Mon Jun 22 19:20:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BF7FC433F5 for ; Fri, 18 Mar 2022 05:59:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232618AbiCRGA3 (ORCPT ); Fri, 18 Mar 2022 02:00:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229912AbiCRGA1 (ORCPT ); Fri, 18 Mar 2022 02:00:27 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2082.outbound.protection.outlook.com [40.107.223.82]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89E432EB57B for ; Thu, 17 Mar 2022 22:59:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DcwaBsNPy023DmaAXHjBCGAiQdOOVqztT+rViBrOYCoYSeWWGPzbUvTLxVGSd8zBvICd2C/Zt9AoWhU5/cj5iLStyreCoDfhBy0aAYnDEE50nWwl5MGScABGx5GrYxk+Nd2Bjs4bD3NvGxE+PEebVmxMV/7whA9YTCYU2rTS9GDt/dXGNd60IIbmSzdoDdDnkBZO/+Rr3DONcHsqpdBCjvbtpzA5nE686V7E+8PYuAXUlTe1L8p7G3sz5NcuaskGApZrK5KQpT2PKyjCqh8/BxG9FNYL3/hW4fTP+Q+KZ2y61wULuPn8664weA03WwBEP9aFkfdKoIQ8ZhjUbXWFlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lCh6GmUXzrnJCdAMiDfY26axiq0ujeeb1vq13L2g7Yw=; b=emXV4+UAjswDxYXFhEjwo9McYgs0HlHzZTR8FXEovuokV5cszNnbuS+Roxy6zRtAQxfoBZIlHzWjyUxGbZA/emj7PTamJ+2FhoaJphCkaIGv7u8qRdXFDurbgptwCuY2htPF46Km8EJvWgnpFuGJ+vZaq+IUNYmgV96coS5LA/9HuNizWSPeYGKjTP1z1fSv3wC44cvRXzcs/BJKrCBizoCEX+aeBr9ioyg+r7p2tBqjW3cT5K0xjBEpo3FbFNsiqIDadNyRErbHKpMlDzwe6nHgnNtYeMDYW0J4WwJN/3cfBAnifUAf9KmwrjQj7ydEsV43IR1ehfpOuoyKtSQLTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lCh6GmUXzrnJCdAMiDfY26axiq0ujeeb1vq13L2g7Yw=; b=1cGfbJG/JgxR/TGvoiHy9GFn96cyOUQw5fT8q6IwynrmoOyPLVAVij3kG0YSHHc9PWrIgJLXK5VCPBlJ7lQeWv6MsXvM7ggvObplk9Ud/F44lL8N5ITfEwqRQ4rjR9LAslyNvtwzlp//w2avDwwbngk9FlMot/ZWlhS2IWsRBug= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vmware.com; Received: from BYAPR05MB3960.namprd05.prod.outlook.com (2603:10b6:a02:88::12) by BL0PR05MB4884.namprd05.prod.outlook.com (2603:10b6:208:57::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.7; Fri, 18 Mar 2022 05:59:07 +0000 Received: from BYAPR05MB3960.namprd05.prod.outlook.com ([fe80::5d86:5648:18fe:a5ab]) by BYAPR05MB3960.namprd05.prod.outlook.com ([fe80::5d86:5648:18fe:a5ab%3]) with mapi id 15.20.5081.018; Fri, 18 Mar 2022 05:59:07 +0000 From: vdasa@vmware.com To: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: gregkh@linuxfoundation.org, pv-drivers@vmware.com, bryantan@vmware.com, rjalisatgi@vmware.com, Vishnu Dasa , Dan Carpenter Subject: [PATCH RESEND] VMCI: Check exclusive_vectors when freeing interrupt 1 Date: Thu, 17 Mar 2022 22:58:43 -0700 Message-Id: <20220318055843.30606-1-vdasa@vmware.com> X-Mailer: git-send-email 2.35.1 Reply-To: vdasa@vmware.com Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR04CA0016.namprd04.prod.outlook.com (2603:10b6:a03:217::21) To BYAPR05MB3960.namprd05.prod.outlook.com (2603:10b6:a02:88::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f7c9e37f-e8c8-45db-b3d7-08da08a469a0 X-MS-TrafficTypeDiagnostic: BL0PR05MB4884:EE_ X-LD-Processed: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0,ExtAddr X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xC4SLJgYnj6YWkL5GOy9ClBlobL5ZAWnHFW0I/Hrr5TifyE5wbzxOf/ocMGg33JJ77dD86AXUz0lYoknBSAT1e3EUxCp5ar9Artmh93ZVGY29SOcUiXUC0HvlYEGfxUAJnIFRFBvKAlxeODVf8nWlnKXjpVYr0xwBIa1xi0+5QHhfB0C++HSN+G9vic2NDZuqn5q6Gx7Kba9DRpxkB11JE6fex4trjQZ5NTcVR8SBuYM3Uyp7KbAAyLPZ9WFMqiQiQj2uYPyeD1qFVjfA4ieXp8r5xzIjh7dthfQlcGgq4ekZi67+iwnYe8JHbGBReAq9IhL43tyVZ5RFRXE4bBKE4q5Gc/r17voqdH5Bv3Ig4VwmlbhcdEcPt4Rntn8EUm3eFcETH1GVcpVMk/ojcZrgLHHcvIRn+aTKQKLFqDsV9MZe9IvcozxfnomyAl4nvNLr5OnYeBGr3y3r/fcwj4yPCDvTlKRmYdcUG/m6b2cH6sdWPHU6payOoIpArM2LUM0DqicsGM6m8BJHo/DD3nToqkk7Py+wYauwI5ebW9nvmqbSPP1V5/pkhEK/Xv0cloxBsh3cg6SO6XnG1OkuVITaFlx/TcLJTkyusbvnGejnCojnYYnUDRam2fesUc1b0hKi8UoUrDG5Mfd1JcyRac3zQZXucx7GW+jkyPIIHVCbtpwAjhW5V4d8X4GZnqG3qjxE4hBRsfFwvXFCD4Q9c68QQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR05MB3960.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(8676002)(4326008)(66476007)(66946007)(38350700002)(38100700002)(508600001)(86362001)(36756003)(6512007)(9686003)(6486002)(52116002)(26005)(186003)(6506007)(2616005)(54906003)(6666004)(8936002)(5660300002)(83380400001)(1076003)(2906002)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6MV6gw46DNlf7sPR2iXuU65v0wfiMldYolOsVxV7li/HlDa0nmZ7qCxZn1Y9?= =?us-ascii?Q?/I0y20SRizxVEVlbFG5i7igIRkeLWPuEZAqyvnFQGVEdgQuYUA7C170U9iis?= =?us-ascii?Q?lIs2p+oQ7/LhQ+EfL3JTJJ3XGpzxgLubCm7bQf+rYI0HlvQ0Wz+5oY9R8UDk?= =?us-ascii?Q?4dQ2bAnAQSAK5cjtQivmXx0LIVSEJ/2qWJ/7L+NvY7sDr9nrNcpbeSNgO1E3?= =?us-ascii?Q?9kflDMjAWgPyhcxM4bUFKrsG7lMjHM/E/OTorVaOMU7tMAZuiYKccwzfaGUp?= =?us-ascii?Q?2v89k+56Ucz6//FyNrvimwcZ+EzBA7sCdrASAtzOlRW2VeCtLI5Bjuyuo287?= =?us-ascii?Q?eLbdA17BTauVnSYD36vfd+/ep32vXq2XKvNhq8Nog4ZkXpeOIdV/7KV3zEOb?= =?us-ascii?Q?aQx+SVkFLZYefj8FpKFaBtSdZlID82lRagIioYGK+o9oJdBuyF/5tpmWa8vX?= =?us-ascii?Q?VmpqtTdV3tUDFGtPIHv9QClFkzvVNUrue8uPVQxd1AtH7+HvzeYkCTSd7rUu?= =?us-ascii?Q?jvrnATgSv9+Or39WxnZYAU4Tx0pjCnD34Oy52Chj2LSVgMu2oGiTDdFxvKYC?= =?us-ascii?Q?nw0Bz/f2joBSTqTOwkelbmkMjkNSPgLz0GjPHth5daNCYQERnqYCW/o6fWFu?= =?us-ascii?Q?19mvXBngvaPftEoS6i6Ir9Q7ExZisdhnyYVHe7OkiLhJEsCpWwl34HiJlfYZ?= =?us-ascii?Q?/mHNMYDmMLcUooZb7ef14uFUiq/gKcZ5OIzoaPHt8lplzQyzw7LhZZsn/io/?= =?us-ascii?Q?Zj/5PairQfz89SrG2GrRnqBieQgrWUrpg48iEDxPftC8B/DZ9Fu3Kx2XyMzc?= =?us-ascii?Q?x+0lM6+8om02jFLkfa2mK4xJ3zBA05Do2QG7sOMFqT1OwZGrbSW9OA5rnSmF?= =?us-ascii?Q?yEePXr0P3FEM5g+d/KArHVoAWDLvyhwiZ8S3EiAvixFdW8tZKZJhzFqYdm4E?= =?us-ascii?Q?yOtMnpQG6Tz2Bszrj+4tLiotqnbqvd1iMBL0ZWVwu2p6fFPAnE2dQa7N/gMP?= =?us-ascii?Q?+ydj6YLytThL0feZPdlGu7bmUtOX0Yv1a5/2A/Q3XCw4W6D1B0NeWO6r3eV8?= =?us-ascii?Q?fOcmQ2QEDEcDxLAtpXTv3AFiVZsqdgyuF/pAF8oDsdF8gHwSEDK/nJvdopL4?= =?us-ascii?Q?IgqwO53AD1Cw8kNKXOOAjFheTZVf80ouGFyRAgfC+R386atY5AywOA+LJUPq?= =?us-ascii?Q?bnJVIdCwc5Cb+I5MTMbCdZqI3/4HvBZ///5s2t8Aav17UEBzvzuh+RCU0x4D?= =?us-ascii?Q?P6aM5ds6PxBiOe6dRhJnnsswHGCSCdzr4dtGWzPGG4pqj+v+w/E4iqCUUln5?= =?us-ascii?Q?Kzq85mzY0J9j4GB5ZAPd1XmYK+WlCN99414qYmciJfx3+naJD3uzl/p0hVx9?= =?us-ascii?Q?gT8bm6e+ID8ZsX9VBOBbEKl/3LvC5vz5s21M/6u52oM1H+Vas+oKn0JYHj0B?= =?us-ascii?Q?4YKbnNyWOiWUWo0X8yrgn4iYXaIi+qpZ?= X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7c9e37f-e8c8-45db-b3d7-08da08a469a0 X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB3960.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 05:59:06.9425 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KoEqnC2ynirtPCGuZCovj7v4XXX0JVgUkxF2bOytBHvkv3izgeBAl4dahFP0PHqjHrc0O1mPEdFD6Ih2MAJqMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR05MB4884 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Vishnu Dasa free_irq() may be called to free an interrupt that was not allocated. Add missing 'if' statement to check for exclusive_vectors when freeing interrupt 1. Fixes: cc68f2177fcb ("VMCI: dma dg: register dummy IRQ handlers for DMA dat= agrams") Reported-by: Dan Carpenter Reviewed-by: Bryan Tan Reviewed-by: Rajesh Jalisatgi Signed-off-by: Vishnu Dasa --- drivers/misc/vmw_vmci/vmci_guest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/vmc= i_guest.c index 6596a54daa88..57a6157209a1 100644 --- a/drivers/misc/vmw_vmci/vmci_guest.c +++ b/drivers/misc/vmw_vmci/vmci_guest.c @@ -862,7 +862,9 @@ static int vmci_guest_probe_device(struct pci_dev *pdev, return 0; =20 err_free_bm_irq: - free_irq(pci_irq_vector(pdev, 1), vmci_dev); + if (vmci_dev->exclusive_vectors) + free_irq(pci_irq_vector(pdev, 1), vmci_dev); + err_free_irq: free_irq(pci_irq_vector(pdev, 0), vmci_dev); tasklet_kill(&vmci_dev->datagram_tasklet); --=20 2.25.1