From nobody Mon Jun 22 19:22:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16553C433EF for ; Fri, 18 Mar 2022 02:43:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231912AbiCRCoa (ORCPT ); Thu, 17 Mar 2022 22:44:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231853AbiCRCoV (ORCPT ); Thu, 17 Mar 2022 22:44:21 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB4C2C74B1 for ; Thu, 17 Mar 2022 19:43:00 -0700 (PDT) Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1C56E3F1D2 for ; Fri, 18 Mar 2022 02:42:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647571377; bh=IsQNvnrYzFlByVho6HFj26Mu5PXAjpXD97Wru1aaDTM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Q/bTcGQrI2ntRSQUP5/O5IB6Pe8MaHpDYBytW0dEBlkf/hp7LbqZQgij08fbYjfDh IxJIN5iWSK4ux+eB2LNsIfITmqqQtuvjEdITpRv3R93Mtd7YXoiCoZqOGrEQRUZj26 UF/JPAXIwdCsreXPTg9/KFbc9injf5kfzQyyEVAVU151q7s0Ks8Wy+lq7TZqCqPzfU 4vQZoXtynO4Lz/VWdV+kRnjfapQq4c5zqLSWkT6DD/RvnXiwLrK0Fxki7ehcZgmT86 YMM9Ndhfo/QZtazT4VOR4PvFRlKFvFI53ou4/+hKgP9tVdHfDqaceW8R1/pSMnrCKB szbgh9Z3Z3yKA== Received: by mail-pj1-f72.google.com with SMTP id o6-20020a17090a9f8600b001c640fa1499so4295240pjp.3 for ; Thu, 17 Mar 2022 19:42:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IsQNvnrYzFlByVho6HFj26Mu5PXAjpXD97Wru1aaDTM=; b=RKbx2HtUbl3T/zZHh7O5FvJu6XOjdZ0JWRa4+L7Bm3zBpDZPzDja5Fm18qdhf0SGJW SZ4vlWBMaw/VVPGSMlrIE2X0yb+hSWmyBNQRs/Uwi57hbqap4KQpelvskzoGNS0r6kiZ Sax8hmnAUQbIJkBq7FdVwVjlipWCdpaolI36CkuAFvRRMOlkIx+zJEwnI63nNqivGFDH tjXT0bf67D8pxpo0AI9Bv7qMtx2z+mdXZoUJ3awWZ2QAGnUImHLsYTMPD3WMq3pG2dQG my6QRgxvYjyQFkBMoGnpkhit+cs8HFnjpFSwS2nsVjf2uU1pYkS+KrEEsI1NHJyP11zA lhVA== X-Gm-Message-State: AOAM533uJkV7dHPW6s1aCrtgL2vkdWONfYMOBd8/b8JOaJ5I3AVLx+AH fmQMgmtIMOix6UVc6MAb9pQv05gK1vmbyxbGub9KLd6f1ZM+n5xa+Lklx14tvRW2I6nH/ZsoEXW QnEkqCzu4tA0ZiYv74Fj8uiKkJidNbrxlZR3MYlUJRg== X-Received: by 2002:a17:902:be14:b0:14f:ce67:d0a1 with SMTP id r20-20020a170902be1400b0014fce67d0a1mr7647159pls.29.1647571375717; Thu, 17 Mar 2022 19:42:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWDlX7R0u3bbFhyd2lD9L026rsWS+K74zpJKVsaJKOqtXpz80a93XUCWWuMOjElFNq5i7sfw== X-Received: by 2002:a17:902:be14:b0:14f:ce67:d0a1 with SMTP id r20-20020a170902be1400b0014fce67d0a1mr7647141pls.29.1647571375385; Thu, 17 Mar 2022 19:42:55 -0700 (PDT) Received: from localhost.localdomain (2001-b400-e287-a413-5915-32ac-82c3-a966.emome-ip6.hinet.net. [2001:b400:e287:a413:5915:32ac:82c3:a966]) by smtp.gmail.com with ESMTPSA id v16-20020a056a00149000b004f7ae2cbd3asm8191232pfu.166.2022.03.17.19.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 19:42:55 -0700 (PDT) From: Chris Chiu To: kvalo@kernel.org, Jes.Sorensen@gmail.com, davem@davemloft.net, kuba@kernel.org Cc: code@reto-schneider.ch, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Chiu Subject: [PATCH v2 1/2] rtl8xxxu: feed antenna information for cfg80211 Date: Fri, 18 Mar 2022 10:42:15 +0800 Message-Id: <20220318024216.42204-2-chris.chiu@canonical.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220318024216.42204-1-chris.chiu@canonical.com> References: <20220318024216.42204-1-chris.chiu@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fill up the available TX/RX antenna so the iw commands can show correct antenna information for different chips. Signed-off-by: Chris Chiu --- .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/driver= s/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 06d59ffb7444..d225a1257530 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -1607,6 +1607,7 @@ static void rtl8xxxu_print_chipinfo(struct rtl8xxxu_p= riv *priv) static int rtl8xxxu_identify_chip(struct rtl8xxxu_priv *priv) { struct device *dev =3D &priv->udev->dev; + struct ieee80211_hw *hw =3D priv->hw; u32 val32, bonding; u16 val16; =20 @@ -1684,6 +1685,9 @@ static int rtl8xxxu_identify_chip(struct rtl8xxxu_pri= v *priv) priv->has_wifi =3D 1; } =20 + hw->wiphy->available_antennas_tx =3D BIT(priv->tx_paths) - 1; + hw->wiphy->available_antennas_rx =3D BIT(priv->rx_paths) - 1; + switch (priv->rtl_chip) { case RTL8188E: case RTL8192E: @@ -4282,6 +4286,17 @@ static void rtl8xxxu_cam_write(struct rtl8xxxu_priv = *priv, rtl8xxxu_debug =3D tmp_debug; } =20 +static +int rtl8xxxu_get_antenna(struct ieee80211_hw *hw, u32 *tx_ant, u32 *rx_ant) +{ + struct rtl8xxxu_priv *priv =3D hw->priv; + + *tx_ant =3D BIT(priv->tx_paths) - 1; + *rx_ant =3D BIT(priv->rx_paths) - 1; + + return 0; +} + static void rtl8xxxu_sw_scan_start(struct ieee80211_hw *hw, struct ieee80211_vif *vif, const u8 *mac) { @@ -6472,6 +6487,7 @@ static const struct ieee80211_ops rtl8xxxu_ops =3D { .set_key =3D rtl8xxxu_set_key, .ampdu_action =3D rtl8xxxu_ampdu_action, .sta_statistics =3D rtl8xxxu_sta_statistics, + .get_antenna =3D rtl8xxxu_get_antenna, }; =20 static int rtl8xxxu_parse_usb(struct rtl8xxxu_priv *priv, --=20 2.20.1 From nobody Mon Jun 22 19:22:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E04AC433EF for ; Fri, 18 Mar 2022 02:43:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231923AbiCRCod (ORCPT ); Thu, 17 Mar 2022 22:44:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231888AbiCRCoX (ORCPT ); Thu, 17 Mar 2022 22:44:23 -0400 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4012BF55C1 for ; Thu, 17 Mar 2022 19:43:03 -0700 (PDT) Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 5B4863F614 for ; Fri, 18 Mar 2022 02:43:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647571381; bh=f9EJWx0pz9xYZ/T46QT2nYRC6HKLvwA6csw+2PrRGps=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YLRzvp92GBU4FRz4LgaQrk/bEqU17GjVC9tvxbA1F8IEVJKfY/3HDO7SlvD0giA38 9te1CQv6x/D4u7io/DbKFWyBmpzEQ8rH8BvyQk39aC+6NlG/aPVgVTnA1RF5vlOOtg yYGKt6KvrsON0DH7a+bYWGDlodZnmbAnAE39N2PEVUko3hQlGEfELT9SCeHb/1oYKT HF86+kQJElm3J+pztcsxHjli19O65zzgPRYjz4Mqa5j48x2rGvZjKayNSvJgeryPqn IUvKGdERb0jHEM1L/tpYew30LYbjWKQ7qCg7jVHt6nXlLniRbH+Ad6qihNF6WZoFAw gVp/qwpfM+Hbg== Received: by mail-pf1-f200.google.com with SMTP id w19-20020aa79553000000b004fa64758b82so1204940pfq.22 for ; Thu, 17 Mar 2022 19:43:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f9EJWx0pz9xYZ/T46QT2nYRC6HKLvwA6csw+2PrRGps=; b=B17ubHQR9USyBXt3mAJm2fJFLr3ir+I42sH8TXXJXo51w5jV1QLF/s9wVN6b5qGNeo QXZd3y2um7iL5WLkgldoditqaFrWBe7pZUdi96SA/S+6F3Ri5qROPHHiU7HHAbbWXuj1 HbYuo8Aq4zTRTbORujYCbJL5cJjDrvhUpHQ/PxLz4Qa9gMM/EiU3w7VqkWzckMNbbM+F Qy/gh6bYFtNNoMFCOO7EL6qpsaxveDH/D52Q4Fx2jxy+tH9lkTM/XgZPZJM1Kd+AkJrp goKbtlECcnJAUmNEhNkOoe9oY+5TBcNK6eNJ6auNGcpIhPBIhBD4oPFk960LAvF+MJb3 aSeQ== X-Gm-Message-State: AOAM530VQukKaaL6AZB0md9kGQ1T/YGaHZ5eUBLAvDUoHyo391ggulJo t+FKIC4NRtS/xTvW+Xdu5ERZVKGDbVk0KngckJyEC4mc14GaSth6jN707s+/PaBJrlAApxkZL4Y vuK2H7y/OsxfQGnKpMbj0Cyz7zqr86bT0bhZtgB9Ufw== X-Received: by 2002:a17:902:bd87:b0:153:ceb:3a6d with SMTP id q7-20020a170902bd8700b001530ceb3a6dmr7811838pls.146.1647571379133; Thu, 17 Mar 2022 19:42:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykrTwLqVp8lScEdbYiq8EeLrP9LGRMLzx7tFiMg0QnklPTnrHP6GdA0fMNW/PbHzHpC5KKgQ== X-Received: by 2002:a17:902:bd87:b0:153:ceb:3a6d with SMTP id q7-20020a170902bd8700b001530ceb3a6dmr7811824pls.146.1647571378831; Thu, 17 Mar 2022 19:42:58 -0700 (PDT) Received: from localhost.localdomain (2001-b400-e287-a413-5915-32ac-82c3-a966.emome-ip6.hinet.net. [2001:b400:e287:a413:5915:32ac:82c3:a966]) by smtp.gmail.com with ESMTPSA id v16-20020a056a00149000b004f7ae2cbd3asm8191232pfu.166.2022.03.17.19.42.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 19:42:58 -0700 (PDT) From: Chris Chiu To: kvalo@kernel.org, Jes.Sorensen@gmail.com, davem@davemloft.net, kuba@kernel.org Cc: code@reto-schneider.ch, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Chiu Subject: [PATCH v2 2/2] rtl8xxxu: fill up txrate info for gen1 chips Date: Fri, 18 Mar 2022 10:42:16 +0800 Message-Id: <20220318024216.42204-3-chris.chiu@canonical.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220318024216.42204-1-chris.chiu@canonical.com> References: <20220318024216.42204-1-chris.chiu@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" RTL8188CUS/RTL8192CU(gen1) don't support rate adatptive report hence no real txrate info can be retrieved. The vendor driver reports the highest rate in HT capabilities from the IEs to avoid empty txrate. This commit initiates the txrate information with the highest supported rate negotiated with AP. The gen2 chip keeps update the txrate from the rate adaptive reports, and gen1 chips at least have non-NULL txrate after associated. Signed-off-by: Chris Chiu --- Changelog: v2: - Use the 'static const' for rtl8xxxu_legacy_ratetable[] .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 59 +++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/driver= s/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index d225a1257530..cc9d14e9c4c4 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -4473,6 +4473,35 @@ void rtl8xxxu_gen1_init_aggregation(struct rtl8xxxu_= priv *priv) priv->rx_buf_aggregation =3D 1; } =20 +static const struct ieee80211_rate rtl8xxxu_legacy_ratetable[] =3D { + {.bitrate =3D 10, .hw_value =3D 0x00,}, + {.bitrate =3D 20, .hw_value =3D 0x01,}, + {.bitrate =3D 55, .hw_value =3D 0x02,}, + {.bitrate =3D 110, .hw_value =3D 0x03,}, + {.bitrate =3D 60, .hw_value =3D 0x04,}, + {.bitrate =3D 90, .hw_value =3D 0x05,}, + {.bitrate =3D 120, .hw_value =3D 0x06,}, + {.bitrate =3D 180, .hw_value =3D 0x07,}, + {.bitrate =3D 240, .hw_value =3D 0x08,}, + {.bitrate =3D 360, .hw_value =3D 0x09,}, + {.bitrate =3D 480, .hw_value =3D 0x0a,}, + {.bitrate =3D 540, .hw_value =3D 0x0b,}, +}; + +static void rtl8xxxu_desc_to_mcsrate(u16 rate, u8 *mcs, u8 *nss) +{ + if (rate <=3D DESC_RATE_54M) + return; + + if (rate >=3D DESC_RATE_MCS0 && rate <=3D DESC_RATE_MCS15) { + if (rate < DESC_RATE_MCS8) + *nss =3D 1; + else + *nss =3D 2; + *mcs =3D rate - DESC_RATE_MCS0; + } +} + static void rtl8xxxu_set_basic_rates(struct rtl8xxxu_priv *priv, u32 rate_= cfg) { struct ieee80211_hw *hw =3D priv->hw; @@ -4534,9 +4563,12 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, s= truct ieee80211_vif *vif, struct rtl8xxxu_priv *priv =3D hw->priv; struct device *dev =3D &priv->udev->dev; struct ieee80211_sta *sta; + struct rtl8xxxu_ra_report *rarpt; u32 val32; u8 val8; =20 + rarpt =3D &priv->ra_report; + if (changed & BSS_CHANGED_ASSOC) { dev_dbg(dev, "Changed ASSOC: %i!\n", bss_conf->assoc); =20 @@ -4545,6 +4577,10 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, s= truct ieee80211_vif *vif, if (bss_conf->assoc) { u32 ramask; int sgi =3D 0; + u8 highest_rate; + u8 mcs =3D 0, nss =3D 0; + u32 bit_rate; + =20 rcu_read_lock(); sta =3D ieee80211_find_sta(vif, bss_conf->bssid); @@ -4569,6 +4605,29 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, s= truct ieee80211_vif *vif, sgi =3D 1; rcu_read_unlock(); =20 + highest_rate =3D fls(ramask) - 1; + if (highest_rate < DESC_RATE_MCS0) { + rarpt->txrate.legacy =3D + rtl8xxxu_legacy_ratetable[highest_rate].bitrate; + } else { + rtl8xxxu_desc_to_mcsrate(highest_rate, + &mcs, &nss); + rarpt->txrate.flags |=3D RATE_INFO_FLAGS_MCS; + + rarpt->txrate.mcs =3D mcs; + rarpt->txrate.nss =3D nss; + + if (sgi) { + rarpt->txrate.flags |=3D + RATE_INFO_FLAGS_SHORT_GI; + } + + rarpt->txrate.bw |=3D RATE_INFO_BW_20; + } + bit_rate =3D cfg80211_calculate_bitrate(&rarpt->txrate); + rarpt->bit_rate =3D bit_rate; + rarpt->desc_rate =3D highest_rate; + priv->vif =3D vif; priv->rssi_level =3D RTL8XXXU_RATR_STA_INIT; =20 --=20 2.20.1