From nobody Mon Jun 22 21:18:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D6F3C433F5 for ; Thu, 17 Mar 2022 01:47:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358334AbiCQBtL (ORCPT ); Wed, 16 Mar 2022 21:49:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239498AbiCQBtF (ORCPT ); Wed, 16 Mar 2022 21:49:05 -0400 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94F1AC0A for ; Wed, 16 Mar 2022 18:47:49 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R761e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0V7OxMrR_1647481662; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0V7OxMrR_1647481662) by smtp.aliyun-inc.com(127.0.0.1); Thu, 17 Mar 2022 09:47:47 +0800 From: Jiapeng Chong To: mingo@redhat.com Cc: peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] sched/fair: fix boolreturn.cocci warning Date: Thu, 17 Mar 2022 09:47:40 +0800 Message-Id: <20220317014740.3138-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Return statements in functions returning bool should use true/false instead of 1/0. ./kernel/sched/fair.c:9846:9-10: WARNING: return of 0/1 in function 'imbalanced_active_balance' with return type bool. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 8bcc1dbc544c..bba2f9d94e53 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9843,9 +9843,9 @@ imbalanced_active_balance(struct lb_env *env) */ if ((env->migration_type =3D=3D migrate_task) && (sd->nr_balance_failed > sd->cache_nice_tries+2)) - return 1; + return true; =20 - return 0; + return false; } =20 static int need_active_balance(struct lb_env *env) --=20 2.20.1.7.g153144c