From nobody Mon Jun 22 21:20:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F10B3C433EF for ; Thu, 17 Mar 2022 01:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355131AbiCQBIF (ORCPT ); Wed, 16 Mar 2022 21:08:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233097AbiCQBH6 (ORCPT ); Wed, 16 Mar 2022 21:07:58 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 970A01D0D3 for ; Wed, 16 Mar 2022 18:06:43 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id gb19so3619742pjb.1 for ; Wed, 16 Mar 2022 18:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WZQaPcDKKFXzU5tYoLycGxECEAPv9mMkSoufmv1EZTg=; b=dqcNR3YSEOig3GV63ooaumDDhzuZrloUf0ajwHJAxn0/Jkh6KRG5Llr8qAdUfl6OSd O8K4IW3aAb1juEABRFFBJi4+xNR5eOB2q+rD9hg+cLHq41OJQxXQG29XjFzlqLTLMJXX 40XXyzEg5CHIjdFZagBhPqu5lIlH2zoiXlbmU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WZQaPcDKKFXzU5tYoLycGxECEAPv9mMkSoufmv1EZTg=; b=D8fC23CF6C5qspFCYbG5kj6Z45shWyq3cb2aZ57DdWdWoi8o/E/GusZwVhKd8D59gp FtLzLEaFVsYetXrrlkLZFzSyBNWY0OemC3WP2PBzGacc2jTJ1ra8bqgok+KetgLBnS9X eHNYX459eESaMQshr+QQQC3AJQXgjqxMgAdBNAHlj5FWNLU4wZsH3yYP6aTuI6PIuZWI mk6la/hfClH1MF9HWvU8Gb9UF4B8UXRVXFVn4TbuK1NTtwBZ3MfVRA3NRb5EXrx4VkL8 /v99MPUEFVz/fq3+x1UiWezeR5ytol2+/jx8u1HvTlP+Oj5rm8c5alQMatodn5Ap3S9i 7l1Q== X-Gm-Message-State: AOAM530NdrSvzO3StpsbxOuV0lQWImtCISxGUc5lhaeLNXDbiyYpDEnn KT/OJjrnBZ4qAghhNsYJmu90tA== X-Google-Smtp-Source: ABdhPJwSlqdw7Z1UWr/ZNPyRNptixyjPpYfit6VckDanvexqXtsN9gly7JRmSu0PZn4VitzeAoEJpg== X-Received: by 2002:a17:90b:4d89:b0:1c6:1047:ce4f with SMTP id oj9-20020a17090b4d8900b001c61047ce4fmr2565473pjb.78.1647479203081; Wed, 16 Mar 2022 18:06:43 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:dec5:e3f8:cbd7:f5a7]) by smtp.gmail.com with ESMTPSA id s14-20020a056a0008ce00b004f66dcd4f1csm5093923pfu.32.2022.03.16.18.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 18:06:42 -0700 (PDT) From: Stephen Boyd To: Andy Gross , Bjorn Andersson Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Douglas Anderson , Matthias Kaehlcke , Alexandru M Stan Subject: [PATCH 1/2] arm64: dts: qcom: sc7280-herobrine: Drop outputs on fpmcu pins Date: Wed, 16 Mar 2022 18:06:39 -0700 Message-Id: <20220317010640.2498502-2-swboyd@chromium.org> X-Mailer: git-send-email 2.35.1.723.g4982287a31-goog In-Reply-To: <20220317010640.2498502-1-swboyd@chromium.org> References: <20220317010640.2498502-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Having these pins with outputs is good on a fresh boot because it puts the boot and reset pins in a known "good" state. Unfortunately, that conflicts with the fingerprint firmware flashing code. The firmware flashing process binds and unbinds the cros-ec and spidev drivers and that reapplies the pin output values after the flashing code has overridden the gpio values. This causes a problem because we try to put the device into bootloader mode, bind the spidev driver and that inadvertently puts it right back into normal boot mode, breaking the flashing process. Fix this by removing the outputs. We'll introduce a binding for fingerprint cros-ec specifically to set the gpios properly via gpio APIs during cros-ec driver probe instead. Cc: Douglas Anderson Cc: Matthias Kaehlcke Cc: Alexandru M Stan Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1") Signed-off-by: Stephen Boyd Reviewed-by: Douglas Anderson --- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/bo= ot/dts/qcom/sc7280-herobrine.dtsi index dc17f2079695..984a7faf0888 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -677,7 +677,6 @@ fp_rst_l: fp-rst-l { function =3D "gpio"; bias-disable; drive-strength =3D <2>; - output-high; }; =20 fp_to_ap_irq_l: fp-to-ap-irq-l { @@ -691,7 +690,6 @@ fpmcu_boot0: fpmcu-boot0 { pins =3D "gpio68"; function =3D "gpio"; bias-disable; - output-low; }; =20 gsc_ap_int_odl: gsc-ap-int-odl { --=20 https://chromeos.dev From nobody Mon Jun 22 21:20:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EE7EC433EF for ; Thu, 17 Mar 2022 01:06:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355664AbiCQBII (ORCPT ); Wed, 16 Mar 2022 21:08:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343725AbiCQBH7 (ORCPT ); Wed, 16 Mar 2022 21:07:59 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81EBE1BEBD for ; Wed, 16 Mar 2022 18:06:44 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id q13so3181453plk.12 for ; Wed, 16 Mar 2022 18:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JvLDVbDDgbp0yNCGRRURLsKBk/XllLTzcyEp1TF0KUo=; b=PRkbCtsXHTB57k+4a4eBSqG/fVFlU0qGBWCrJ0/MhTEHIqVuE5K8MPEmI/PjxK/zFV sGNJW44o6VQz8zhaQ7yOrVVb7LbvHWOdaZEKg3hFFUpnyayUm8f2O5CZBLSvN0Q5rafR VR90mvph3Atwbf+BShZ9hblUpBnw98VJA3tb4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JvLDVbDDgbp0yNCGRRURLsKBk/XllLTzcyEp1TF0KUo=; b=kSmNWT2QXRN8ZAw3cvuwmHEdgV4zCaAYvok+BZuCol1Enfwg/umhyn4B3r7L/U6tnx JNG9jHqOa5ue3ISr9jarU4QQ/R5ee8curSLcUL25nPIuPOM3hqq6E2WFRZuBu11IO11a ZPvQmmeVjp5xoodPGum7FJTi98OmrcEFtGmxOjtIEQpkmqUssZtng2+SPSAt2m42X9Y6 QuQVSelCVvAWsvEGLC4GXIb6isJPH8TFJ0kUGbaJ/Sy9xhkrLm5XU4cncQT6SIPSeS9O 3wIU925zw5jQY4ovitQ0QMlFb9bN7X5H0IztuAlfqengVyDeGIlwYOi1RD5ZN3R1ZiX1 NfRw== X-Gm-Message-State: AOAM530j7sucLtWk3xC3NFzqQP3gRVy0Y2dYPZQzW4Jcu6A4gy99Uvfz xg15Bp51sNGMxaLfP5CMwLQOrA== X-Google-Smtp-Source: ABdhPJy+en968FQATdRXl3SZ6Q+LOtWTG56qirSD/XRFWyWoeul7smFZUJMjLCzcV7qvAaSU6jwyMQ== X-Received: by 2002:a17:902:b597:b0:151:e24e:a61e with SMTP id a23-20020a170902b59700b00151e24ea61emr2615241pls.66.1647479204063; Wed, 16 Mar 2022 18:06:44 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:dec5:e3f8:cbd7:f5a7]) by smtp.gmail.com with ESMTPSA id s14-20020a056a0008ce00b004f66dcd4f1csm5093923pfu.32.2022.03.16.18.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 18:06:43 -0700 (PDT) From: Stephen Boyd To: Andy Gross , Bjorn Andersson Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Douglas Anderson , Matthias Kaehlcke , Alexandru M Stan Subject: [PATCH 2/2] arm64: dts: qcom: Fully describe fingerprint node on Herobrine Date: Wed, 16 Mar 2022 18:06:40 -0700 Message-Id: <20220317010640.2498502-3-swboyd@chromium.org> X-Mailer: git-send-email 2.35.1.723.g4982287a31-goog In-Reply-To: <20220317010640.2498502-1-swboyd@chromium.org> References: <20220317010640.2498502-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Update the fingerprint node on Herobrine to match the fingerprint DT binding. This will allow us to drive the reset and boot gpios from the driver when it is re-attached after flashing. We'll also be able to boot the fingerprint processor if the BIOS isn't doing it for us. Cc: Douglas Anderson Cc: Matthias Kaehlcke Cc: Alexandru M Stan Signed-off-by: Stephen Boyd Reviewed-by: Matthias Kaehlcke --- Depends on https://lore.kernel.org/r/20220317005814.2496302-1-swboyd@chromi= um.org arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/bo= ot/dts/qcom/sc7280-herobrine.dtsi index 984a7faf0888..282dda78ba3f 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -396,13 +396,16 @@ ap_spi_fp: &spi9 { cs-gpios =3D <&tlmm 39 GPIO_ACTIVE_LOW>; =20 cros_ec_fp: ec@0 { - compatible =3D "google,cros-ec-spi"; + compatible =3D "google,cros-ec-fp"; reg =3D <0>; interrupt-parent =3D <&tlmm>; interrupts =3D <61 IRQ_TYPE_LEVEL_LOW>; pinctrl-names =3D "default"; pinctrl-0 =3D <&fp_to_ap_irq_l>, <&fp_rst_l>, <&fpmcu_boot0>; + boot0-gpios =3D <&tlmm 68 GPIO_ACTIVE_HIGH>; + reset-gpios =3D <&tlmm 78 GPIO_ACTIVE_LOW>; spi-max-frequency =3D <3000000>; + vdd-supply =3D <&pp3300_fp_mcu>; }; }; =20 --=20 https://chromeos.dev