From nobody Mon Jun 22 22:49:23 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA32C433EF for ; Wed, 16 Mar 2022 01:08:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352902AbiCPBKC (ORCPT ); Tue, 15 Mar 2022 21:10:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351012AbiCPBJy (ORCPT ); Tue, 15 Mar 2022 21:09:54 -0400 Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8C96443EE2 for ; Tue, 15 Mar 2022 18:08:41 -0700 (PDT) Received: from localhost.localdomain (unknown [10.2.5.185]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9DxTxOVODFi5PQJAA--.6644S2; Wed, 16 Mar 2022 09:08:37 +0800 (CST) From: Bibo Mao To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: add access/dirty bit on numa page fault Date: Tue, 15 Mar 2022 21:08:36 -0400 Message-Id: <20220316010836.1137084-1-maobibo@loongson.cn> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: AQAAf9DxTxOVODFi5PQJAA--.6644S2 X-Coremail-Antispam: 1UD129KBjvJXoW7ur47tr13AF4DJFW3Ww45KFg_yoW8ArWUpF 93C3yjganrXrn7Aa13GFn0yr15Xa48Ka48Ar9xtw1qqws8Wrn7uayUW3yS9aykGry8tw4D Jr4UWFW8CF48Xw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnUUvcSsGvfC2KfnxnUUI43ZEXa7xR_UUUUUUUUU== X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" During numa page fault, dirty bit can be added for old pte if fail to migrate on write fault. And if it succeeds to migrate, access bit can be added for migrated new pte, also dirty bit can be added for write fault. Signed-off-by: Bibo Mao --- mm/memory.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index c125c4969913..65813bec9c06 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -4404,6 +4404,22 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) if (migrate_misplaced_page(page, vma, target_nid)) { page_nid =3D target_nid; flags |=3D TNF_MIGRATED; + + /* + * update pte entry with access bit, and dirty bit for + * write fault + */ + spin_lock(vmf->ptl); + pte =3D *vmf->pte; + pte =3D pte_mkyoung(pte); + if (was_writable) { + pte =3D pte_mkwrite(pte); + if (vmf->flags & FAULT_FLAG_WRITE) + pte =3D pte_mkdirty(pte); + } + set_pte_at(vma->vm_mm, vmf->address, vmf->pte, pte); + update_mmu_cache(vma, vmf->address, vmf->pte); + pte_unmap_unlock(vmf->pte, vmf->ptl); } else { flags |=3D TNF_MIGRATE_FAIL; vmf->pte =3D pte_offset_map(vmf->pmd, vmf->address); @@ -4427,8 +4443,11 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) old_pte =3D ptep_modify_prot_start(vma, vmf->address, vmf->pte); pte =3D pte_modify(old_pte, vma->vm_page_prot); pte =3D pte_mkyoung(pte); - if (was_writable) + if (was_writable) { pte =3D pte_mkwrite(pte); + if (vmf->flags & FAULT_FLAG_WRITE) + pte =3D pte_mkdirty(pte); + } ptep_modify_prot_commit(vma, vmf->address, vmf->pte, old_pte, pte); update_mmu_cache(vma, vmf->address, vmf->pte); pte_unmap_unlock(vmf->pte, vmf->ptl); --=20 2.31.1