From nobody Tue Jun 23 04:00:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE1E3C433EF for ; Fri, 11 Mar 2022 00:18:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344982AbiCKATF (ORCPT ); Thu, 10 Mar 2022 19:19:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236938AbiCKATD (ORCPT ); Thu, 10 Mar 2022 19:19:03 -0500 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F7DB9F6E2; Thu, 10 Mar 2022 16:18:00 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0V6qSMeb_1646957877; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0V6qSMeb_1646957877) by smtp.aliyun-inc.com(127.0.0.1); Fri, 11 Mar 2022 08:17:58 +0800 From: Yang Li To: davem@davemloft.net Cc: kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] ethernet: 8390: Remove unnecessary print function dev_err() Date: Fri, 11 Mar 2022 08:17:56 +0800 Message-Id: <20220311001756.12234-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/net/ethernet/8390/mcf8390.c:414:2-9: line 414 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/ethernet/8390/mcf8390.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/8390/mcf8390.c b/drivers/net/ethernet/839= 0/mcf8390.c index 90cd7bdf06f5..21047ae1bc3d 100644 --- a/drivers/net/ethernet/8390/mcf8390.c +++ b/drivers/net/ethernet/8390/mcf8390.c @@ -410,10 +410,8 @@ static int mcf8390_probe(struct platform_device *pdev) int ret, irq; =20 irq =3D platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "no IRQ specified?\n"); + if (irq < 0) return -ENXIO; - } =20 mem =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); if (mem =3D=3D NULL) { --=20 2.20.1.7.g153144c