From nobody Tue Jun 23 07:28:06 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E44EC433F5 for ; Wed, 9 Mar 2022 12:45:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231984AbiCIMqD (ORCPT ); Wed, 9 Mar 2022 07:46:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230231AbiCIMqB (ORCPT ); Wed, 9 Mar 2022 07:46:01 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15D4017129D for ; Wed, 9 Mar 2022 04:45:03 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id i8so2829598wrr.8 for ; Wed, 09 Mar 2022 04:45:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vgKY2Q6+QhjEsaicdqEnaC8ePiL0nSdZLDa1oY8ac70=; b=vVSZXrOPJfdfQlk3yTj0sWxYXjSZJJJkmhzOxE8T2zdhsyWzXcJymep2acmJW5EkAj tDRgXyY/uR+mP9F92Mto8Ua/ILvYDmGp64/LXYomkY+MK1rCMnk8u12j2VVPJahNUhS6 +CsX2K1acavUCwQt7YsxEB0kw5Dd+RkwxFtZ0Fl15TTmgrVdO0kIXf8UNPjbmEHb54Wy rBdBlhr4PTMAYyRcjAH3JGSph2JPa0K8mfiYKGg49yc8LQoUMJJWCgYNgOTtO58extn8 mchCuXE3HVN6NGKZVKmMxBCKSy+gODUHJwECYAwDSrwtUey2k5ZfdtG1VP2B15qGSVeJ Qfww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vgKY2Q6+QhjEsaicdqEnaC8ePiL0nSdZLDa1oY8ac70=; b=v4awtDWSB3YFOUlRggVXNxX1b5h1KCsjRyTpUt4bA6KUATJAjznbhOuwoY5iFKk2MM srihr56DSuZze5apLofWOsf162AFeGalfsWQaKeRdbVpG7PCNVi6S06oDhmKHKLQEVSU 2WZqCgtkvZgXeenrkYYy84Emx537oxlEEG6SpGierWiNm8Vchqo3vFjSxqIy8GdrHQi9 ZT0G3R8Dlxh7a5qlj/b2NV7s0nHuznJZYInTCweyaMS6b9h/j2wqqTTbncEeP/SbDLEa BI9SBoYYD2hRdvHMab4TZvCJVdb5YmfuZUkiGvPFhTWjnLf+6r9gnsCO73uOIB33O4wa zvgQ== X-Gm-Message-State: AOAM531adaEtLMd4eeMrx7w77mpX0Bsu4nkHhMoGxl29ZQJ+kIJl3Rfi ScP2FSWM3aF98UtTlJbw59SFTQ== X-Google-Smtp-Source: ABdhPJwj7n2SG+ZJ5L+LFVYmeqokwoThVczi/zeuMIVWGe6Ti9GLdtc8xDYQ1inhbtePKDrv/qyzog== X-Received: by 2002:a5d:6344:0:b0:1f0:21ee:9705 with SMTP id b4-20020a5d6344000000b001f021ee9705mr15663343wrw.93.1646829901625; Wed, 09 Mar 2022 04:45:01 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id bg20-20020a05600c3c9400b0037fa5c422c8sm5414414wmb.48.2022.03.09.04.45.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 04:45:01 -0800 (PST) From: Srinivas Kandagatla To: broonie@kernel.org Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, quic_srivasam@quicinc.com, Srinivas Kandagatla , Randy Dunlap , kernel test robot Subject: [PATCH] ASoC: qcom: fix Kconfig for SC7280 Date: Wed, 9 Mar 2022 12:44:53 +0000 Message-Id: <20220309124453.25841-1-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" select would force the symbol to value without checking the dependencies. In this case selecting TX and RX MACROs directly without checking its dependency on COMMON_CLK would break builds on platform which do no set COMMON_CLK. ex: WARNING: unmet direct dependencies detected for SND_SOC_LPASS_RX_MACRO Depends on [n]: SOUND [=3Dm] && !UML && SND [=3Dm] && SND_SOC [=3Dm] && C= OMMON_CLK [=3Dn] Selected by [m]: - SND_SOC_SC7280 [=3Dm] && SOUND [=3Dm] && !UML && SND [=3Dm] && SND_SOC = [=3Dm] && SND_SOC_QCOM [=3Dm] && I2C [=3Dy] && SOUNDWIRE [=3Dm] move select to imply which should enforce symbol to be set to 'n' if any dependencies are not resolved. Fixes: 57350bd41c3a ("ASoC: qcom: SC7280: Add machine driver") Reported-by: Randy Dunlap Reported-by: kernel test robot Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index ae99833b3fdb..593fd85e03ad 100644 --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -194,8 +194,8 @@ config SND_SOC_SC7280 select SND_SOC_LPASS_SC7280 select SND_SOC_MAX98357A select SND_SOC_WCD938X - select SND_SOC_LPASS_RX_MACRO - select SND_SOC_LPASS_TX_MACRO + imply SND_SOC_LPASS_RX_MACRO + imply SND_SOC_LPASS_TX_MACRO help Add support for audio on Qualcomm Technologies Inc. SC7280 SoC-based systems. --=20 2.21.0