From nobody Tue Jun 23 08:14:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4983CC433FE for ; Wed, 9 Mar 2022 03:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231733AbiCIDbU (ORCPT ); Tue, 8 Mar 2022 22:31:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231625AbiCIDbT (ORCPT ); Tue, 8 Mar 2022 22:31:19 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 222A715B3F5; Tue, 8 Mar 2022 19:30:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=Aasby+93F3H3sQOG047CDVl/4vvrh2eNkazM7N8aBm0=; b=ovJTpCHMUN9Ts6OvX59nTZgbXv wCbU6VlQTzM4coC5DrXJr5CHAVt0kl0Wjl1p4Iq+oAFnUGQ0yuoIFVjB1pziG2594VlA25Hx3dvNW qwNPnk45l6IhAZCoRy7RkzDLZElI3tChTSF6ZvNYUyP0A+kebn/3D6GHZEOGhbopMu/L/LHhAx6gR xyRg8ljtMMCjn1AxT/KSGpmfX7JXdJ/aVY3L/3qJZJUuQvK+YEeuemccx8jP9NvSo1tg2hgzM4vjf pkDUvgc337rzPGgzDTqHsIPSXw9hKOIqUdlva5/MUzUy0rJuDLj31wvqTXvpKEP9TknRK6GY7lVLR JZU8NPaw==; Received: from [2601:1c0:6280:3f0::aa0b] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRn1n-0076Gm-Hk; Wed, 09 Mar 2022 03:30:19 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Igor Zhbanov , He Zhe , Greg Kroah-Hartman , Jiri Slaby , kgdb-bugreport@lists.sourceforge.net, Jason Wessel , Daniel Thompson , Douglas Anderson , linux-serial@vger.kernel.org Subject: [PATCH v2] kgdboc: fix return value of __setup handler Date: Tue, 8 Mar 2022 19:30:18 -0800 Message-Id: <20220309033018.17936-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" __setup() handlers should return 1 to obsolete_checksetup() in init/main.c to indicate that the boot option has been handled. A return of 0 causes the boot option/value to be listed as an Unknown kernel parameter and added to init's (limited) environment strings. So return 1 from kgdboc_option_setup(). Unknown kernel command line parameters "BOOT_IMAGE=3D/boot/bzImage-517rc7 kgdboc=3Dkbd kgdbts=3D", will be passed to user space. Run /sbin/init as init process with arguments: /sbin/init with environment: HOME=3D/ TERM=3Dlinux BOOT_IMAGE=3D/boot/bzImage-517rc7 kgdboc=3Dkbd kgdbts=3D Fixes: 1bd54d851f50 ("kgdboc: Passing ekgdboc to command line causes panic") Fixes: f2d937f3bf00 ("consoles: polling support, kgdboc") Signed-off-by: Randy Dunlap Reported-by: Igor Zhbanov Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru Cc: He Zhe Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: kgdb-bugreport@lists.sourceforge.net Cc: Jason Wessel Cc: Daniel Thompson Cc: Douglas Anderson Cc: linux-serial@vger.kernel.org Reviewed-by: Douglas Anderson --- v2- correct Fixes: tag(s) (thanks Doug) - drop Cc: Laura Abbott (bouncing) - add a reference to init/main.c::obsolete_checksetup() drivers/tty/serial/kgdboc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- lnx-517-rc7.orig/drivers/tty/serial/kgdboc.c +++ lnx-517-rc7/drivers/tty/serial/kgdboc.c @@ -403,16 +403,16 @@ static int kgdboc_option_setup(char *opt { if (!opt) { pr_err("config string not provided\n"); - return -EINVAL; + return 1; } =20 if (strlen(opt) >=3D MAX_CONFIG_LEN) { pr_err("config string too long\n"); - return -ENOSPC; + return 1; } strcpy(config, opt); =20 - return 0; + return 1; } =20 __setup("kgdboc=3D", kgdboc_option_setup);