From nobody Tue Jun 23 09:24:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFCB9C433EF for ; Tue, 8 Mar 2022 08:09:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344763AbiCHIKd (ORCPT ); Tue, 8 Mar 2022 03:10:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344784AbiCHIKW (ORCPT ); Tue, 8 Mar 2022 03:10:22 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42C323EA95 for ; Tue, 8 Mar 2022 00:09:26 -0800 (PST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 0F0C33F618 for ; Tue, 8 Mar 2022 08:09:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646726965; bh=Dwp/aQOBQEXJT+052j4TYlKoFTeM490hQz5ZQ8IolK4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GkgWIVEaTirXnRwDelGoi01Gli8aZ5HPIdhSzenB0f59kewQO0FMHflBvYoG//gAo yDENmjeEWX4eLP5MwCbt5quvQyrPwpCPkJsU2IGsXj5FKAFo54whQ73ydgVFuhlvCt 7OZJGz55aeswfySJmGAq0lp/TQlH6ldU2qZZeS3GE/lqQW6ON6KT0epjFt77QK1ruD qAqF37X/IdbBvD5jH6UjYjSWHyW+lBojRwKu2gjyasr2UFHQXrrQcI0cWPXzvFASEy nF7CgiG4k647O73imKRhoHhm46qs6nZrCIjnU644lMdfJOeqzfJmxAzGKbT/vaxnHJ YTGaQUqWnDpWA== Received: by mail-ed1-f70.google.com with SMTP id h17-20020a05640250d100b004133863d836so10157781edb.0 for ; Tue, 08 Mar 2022 00:09:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dwp/aQOBQEXJT+052j4TYlKoFTeM490hQz5ZQ8IolK4=; b=aKTq86C+vu/zuKzeiRloqzAVJwLMpzLyMHNgFPXnKMbSziCPZ8/wjR/SiozvhkyUyI c/9aLITYy8xGcfjvlBrfkp0nH+DS/LBnxHXvv+ze1Hz1hDgrr40I7s79Tm67ak4rRz4d k7nO39eQmCfmjPOCj26pkdx+xaRA5RnFv3c+jN7kv+wUABc5nRha4TmlepCJLIAUUEyC 4S4GS7/kFH1XCfFiPl/y143kjtONZV5ndZMMX5mvTPhD4GyOnfUeZcr6Q7CG2PBFzj06 ypSy480U4qSbxutcyyRmyxhk3YsxZK2jOK4Ao5r05B89AXP/xXhGuqfro6KDkEPMOI6C DIVw== X-Gm-Message-State: AOAM532wQnIKR/wT5Ghfw++njFRm+jGbnafU7klpYI2YM0qSdxhi4ljG b7AklbVVlrCIJfhNmFzeEp2pRgG/NZTDiSOw3Sxhb7fJYm+OVhU23pZhzblF9sRSDYQMojPYdHL GWbx85G/s1Mt595c0rIJBOljgK8C2S2k2fdp3oEb5bg== X-Received: by 2002:a17:907:8688:b0:6d2:c19:e1a0 with SMTP id qa8-20020a170907868800b006d20c19e1a0mr11801069ejc.249.1646726963524; Tue, 08 Mar 2022 00:09:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQGA9AtYeOF5o4ZCAtjuIHASbFdPaBaVMJaKdXkELr+T4yRLutynO8tWxKX7iXVrYNqK6kmw== X-Received: by 2002:a17:907:8688:b0:6d2:c19:e1a0 with SMTP id qa8-20020a170907868800b006d20c19e1a0mr11801059ejc.249.1646726963335; Tue, 08 Mar 2022 00:09:23 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.gmail.com with ESMTPSA id t4-20020a056402524400b00415b90801edsm7385697edd.57.2022.03.08.00.09.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 00:09:22 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v3 1/8] tty: serial: samsung: embed s3c24xx_uart_info in parent structure Date: Tue, 8 Mar 2022 09:09:12 +0100 Message-Id: <20220308080919.152715-2-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> References: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Embed "struct s3c24xx_uart_info" directly as a member of "struct s3c24xx_serial_drv_data" instead of keeping it as a pointer. This makes the code clearer (obvious ownership of "struct s3c24xx_serial_drv_data") and saves one pointer. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jiri Slaby Reviewed-by: Alim Akhtar Tested-by: Alim Akhtar --- drivers/tty/serial/samsung_tty.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_= tty.c index d002a4e48ed9..aa5678d03704 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -85,7 +85,7 @@ struct s3c24xx_uart_info { }; =20 struct s3c24xx_serial_drv_data { - struct s3c24xx_uart_info *info; + struct s3c24xx_uart_info info; struct s3c2410_uartcfg *def_cfg; unsigned int fifosize[CONFIG_SERIAL_SAMSUNG_UARTS]; }; @@ -2197,7 +2197,7 @@ static int s3c24xx_serial_probe(struct platform_devic= e *pdev) } =20 ourport->baudclk =3D ERR_PTR(-EINVAL); - ourport->info =3D ourport->drv_data->info; + ourport->info =3D &ourport->drv_data->info; ourport->cfg =3D (dev_get_platdata(&pdev->dev)) ? dev_get_platdata(&pdev->dev) : ourport->drv_data->def_cfg; @@ -2616,7 +2616,7 @@ static struct console s3c24xx_serial_console =3D { =20 #ifdef CONFIG_CPU_S3C2410 static struct s3c24xx_serial_drv_data s3c2410_serial_drv_data =3D { - .info =3D &(struct s3c24xx_uart_info) { + .info =3D { .name =3D "Samsung S3C2410 UART", .type =3D TYPE_S3C24XX, .port_type =3D PORT_S3C2410, @@ -2644,7 +2644,7 @@ static struct s3c24xx_serial_drv_data s3c2410_serial_= drv_data =3D { =20 #ifdef CONFIG_CPU_S3C2412 static struct s3c24xx_serial_drv_data s3c2412_serial_drv_data =3D { - .info =3D &(struct s3c24xx_uart_info) { + .info =3D { .name =3D "Samsung S3C2412 UART", .type =3D TYPE_S3C24XX, .port_type =3D PORT_S3C2412, @@ -2674,7 +2674,7 @@ static struct s3c24xx_serial_drv_data s3c2412_serial_= drv_data =3D { #if defined(CONFIG_CPU_S3C2440) || defined(CONFIG_CPU_S3C2416) || \ defined(CONFIG_CPU_S3C2443) || defined(CONFIG_CPU_S3C2442) static struct s3c24xx_serial_drv_data s3c2440_serial_drv_data =3D { - .info =3D &(struct s3c24xx_uart_info) { + .info =3D { .name =3D "Samsung S3C2440 UART", .type =3D TYPE_S3C24XX, .port_type =3D PORT_S3C2440, @@ -2704,7 +2704,7 @@ static struct s3c24xx_serial_drv_data s3c2440_serial_= drv_data =3D { =20 #if defined(CONFIG_CPU_S3C6400) || defined(CONFIG_CPU_S3C6410) static struct s3c24xx_serial_drv_data s3c6400_serial_drv_data =3D { - .info =3D &(struct s3c24xx_uart_info) { + .info =3D { .name =3D "Samsung S3C6400 UART", .type =3D TYPE_S3C6400, .port_type =3D PORT_S3C6400, @@ -2733,7 +2733,7 @@ static struct s3c24xx_serial_drv_data s3c6400_serial_= drv_data =3D { =20 #ifdef CONFIG_CPU_S5PV210 static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data =3D { - .info =3D &(struct s3c24xx_uart_info) { + .info =3D { .name =3D "Samsung S5PV210 UART", .type =3D TYPE_S3C6400, .port_type =3D PORT_S3C6400, @@ -2762,7 +2762,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_= drv_data =3D { =20 #if defined(CONFIG_ARCH_EXYNOS) #define EXYNOS_COMMON_SERIAL_DRV_DATA() \ - .info =3D &(struct s3c24xx_uart_info) { \ + .info =3D { \ .name =3D "Samsung Exynos UART", \ .type =3D TYPE_S3C6400, \ .port_type =3D PORT_S3C6400, \ @@ -2811,7 +2811,7 @@ static struct s3c24xx_serial_drv_data exynos850_seria= l_drv_data =3D { =20 #ifdef CONFIG_ARCH_APPLE static struct s3c24xx_serial_drv_data s5l_serial_drv_data =3D { - .info =3D &(struct s3c24xx_uart_info) { + .info =3D { .name =3D "Apple S5L UART", .type =3D TYPE_APPLE_S5L, .port_type =3D PORT_8250, --=20 2.32.0 From nobody Tue Jun 23 09:24:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD109C433FE for ; Tue, 8 Mar 2022 08:09:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344793AbiCHIK2 (ORCPT ); Tue, 8 Mar 2022 03:10:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344785AbiCHIKW (ORCPT ); Tue, 8 Mar 2022 03:10:22 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 531E43EAA8 for ; Tue, 8 Mar 2022 00:09:26 -0800 (PST) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 3278F3F79D for ; Tue, 8 Mar 2022 08:09:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646726965; bh=RaO5N5+xpc6qv0C5C+2+SP0aJMALLkB4br4l3fJLsRI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BdgUOyLggHdP9lzIgR65TSCLNFsbrhCJxfwBq9I+iSu1TljH75CFwmoH4zwRfHknE 91DaYOqkWzQca3UfMc0wgNFDbmUtNptGs9E1oy2Mo4XKcJCYrj+1whz7DoYnY/nybz XcUxP5cf9mwfKEGumdk9wbyV3/zCaFOCrjXGjWClNVgLMkvQXT4Is5W2bnYIEuWLmc jxCjPFnNElUfo/TH6fM8QltQ3UpXsdovC5Y7iIZvlB4Fx2LpmjQoKHNxq2aO7Nh2Jf r59g/PifU2Sy0KMemr7Docc8q2tTKfjvmecG79Npr14oZi4F+PeOHYwCzQQA4ENVzt 7zJFKdQVCQuUA== Received: by mail-ej1-f70.google.com with SMTP id 13-20020a170906328d00b006982d0888a4so8186728ejw.9 for ; Tue, 08 Mar 2022 00:09:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RaO5N5+xpc6qv0C5C+2+SP0aJMALLkB4br4l3fJLsRI=; b=46/FMph8ifjyD1fhAN36VDmgEse4rmFYPylBAHCXw1/XUlxUBlbBR2Sl+hl/qnQkO4 K3ajL2lmY5OauUUo1JsQlTBMwfOUITjjaO+aXWRkSEn8xarJNIIbASMizrF+InNhgDbD 46DvI18sB39GE8aSP/dsiR2yz0rBzGokuPPC/ZsAkbsx9OPg+MsTh1GKoYM4/O8LRyuw t0BWl85wkfSOrGHgwqJnsPI5mL8F7gkJMsG9v9Uy6LAPphVO6svEihcHYqUSyxrsMadf Io/S1K9t3nEaEAtcdmJBzfgX2rd3asBwzX9quQiVRo9OqjzRw0NKrdvR6KPU9dwLj7az xSAA== X-Gm-Message-State: AOAM532PoF607Bz7SmBpvgEQFPaR4M8pMVuu1gUwSXAnMNIlQzCj9IFU G3ftS03Puf7eki4jnDQDoOFkscgwAuNXFtfaoyBW2A7GWkaK8klnesFsH4D4kq+MSGh97pp4TFR Eqprx2chcMs4CqqrggEIi96afcIJxG3YkdcZd/vpUJw== X-Received: by 2002:a17:906:7d83:b0:6ce:fee:9256 with SMTP id v3-20020a1709067d8300b006ce0fee9256mr12751422ejo.647.1646726964793; Tue, 08 Mar 2022 00:09:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJw6SJAGGC/ezAoZpSp4TpDtyzbSfuJ1xdN0lOAmzmlE3wQWBFRDDMvLFPw6x2SrFrtTdkAZ4g== X-Received: by 2002:a17:906:7d83:b0:6ce:fee:9256 with SMTP id v3-20020a1709067d8300b006ce0fee9256mr12751408ejo.647.1646726964615; Tue, 08 Mar 2022 00:09:24 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.gmail.com with ESMTPSA id t4-20020a056402524400b00415b90801edsm7385697edd.57.2022.03.08.00.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 00:09:23 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v3 2/8] tty: serial: samsung: embed s3c2410_uartcfg in parent structure Date: Tue, 8 Mar 2022 09:09:13 +0100 Message-Id: <20220308080919.152715-3-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> References: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Embed "struct s3c2410_uartcfg" directly as a member of "struct s3c24xx_serial_drv_data" instead of keeping it as a pointer. This makes the code clearer (obvious ownership of "s3c2410_uartcfg s3c24xx_serial_drv_data") and saves one pointer. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jiri Slaby Reviewed-by: Alim Akhtar Tested-by: Alim Akhtar --- drivers/tty/serial/samsung_tty.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_= tty.c index aa5678d03704..a9a75b5b9705 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -86,7 +86,7 @@ struct s3c24xx_uart_info { =20 struct s3c24xx_serial_drv_data { struct s3c24xx_uart_info info; - struct s3c2410_uartcfg *def_cfg; + struct s3c2410_uartcfg def_cfg; unsigned int fifosize[CONFIG_SERIAL_SAMSUNG_UARTS]; }; =20 @@ -2200,7 +2200,7 @@ static int s3c24xx_serial_probe(struct platform_devic= e *pdev) ourport->info =3D &ourport->drv_data->info; ourport->cfg =3D (dev_get_platdata(&pdev->dev)) ? dev_get_platdata(&pdev->dev) : - ourport->drv_data->def_cfg; + &ourport->drv_data->def_cfg; =20 switch (ourport->info->type) { case TYPE_S3C24XX: @@ -2632,7 +2632,7 @@ static struct s3c24xx_serial_drv_data s3c2410_serial_= drv_data =3D { .clksel_mask =3D S3C2410_UCON_CLKMASK, .clksel_shift =3D S3C2410_UCON_CLKSHIFT, }, - .def_cfg =3D &(struct s3c2410_uartcfg) { + .def_cfg =3D { .ucon =3D S3C2410_UCON_DEFAULT, .ufcon =3D S3C2410_UFCON_DEFAULT, }, @@ -2661,7 +2661,7 @@ static struct s3c24xx_serial_drv_data s3c2412_serial_= drv_data =3D { .clksel_mask =3D S3C2412_UCON_CLKMASK, .clksel_shift =3D S3C2412_UCON_CLKSHIFT, }, - .def_cfg =3D &(struct s3c2410_uartcfg) { + .def_cfg =3D { .ucon =3D S3C2410_UCON_DEFAULT, .ufcon =3D S3C2410_UFCON_DEFAULT, }, @@ -2692,7 +2692,7 @@ static struct s3c24xx_serial_drv_data s3c2440_serial_= drv_data =3D { .clksel_shift =3D S3C2412_UCON_CLKSHIFT, .ucon_mask =3D S3C2440_UCON0_DIVMASK, }, - .def_cfg =3D &(struct s3c2410_uartcfg) { + .def_cfg =3D { .ucon =3D S3C2410_UCON_DEFAULT, .ufcon =3D S3C2410_UFCON_DEFAULT, }, @@ -2721,7 +2721,7 @@ static struct s3c24xx_serial_drv_data s3c6400_serial_= drv_data =3D { .clksel_mask =3D S3C6400_UCON_CLKMASK, .clksel_shift =3D S3C6400_UCON_CLKSHIFT, }, - .def_cfg =3D &(struct s3c2410_uartcfg) { + .def_cfg =3D { .ucon =3D S3C2410_UCON_DEFAULT, .ufcon =3D S3C2410_UFCON_DEFAULT, }, @@ -2749,7 +2749,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_= drv_data =3D { .clksel_mask =3D S5PV210_UCON_CLKMASK, .clksel_shift =3D S5PV210_UCON_CLKSHIFT, }, - .def_cfg =3D &(struct s3c2410_uartcfg) { + .def_cfg =3D { .ucon =3D S5PV210_UCON_DEFAULT, .ufcon =3D S5PV210_UFCON_DEFAULT, }, @@ -2778,7 +2778,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_= drv_data =3D { .clksel_mask =3D 0, \ .clksel_shift =3D 0, \ }, \ - .def_cfg =3D &(struct s3c2410_uartcfg) { \ + .def_cfg =3D { \ .ucon =3D S5PV210_UCON_DEFAULT, \ .ufcon =3D S5PV210_UFCON_DEFAULT, \ .has_fracval =3D 1, \ @@ -2827,7 +2827,7 @@ static struct s3c24xx_serial_drv_data s5l_serial_drv_= data =3D { .clksel_mask =3D 0, .clksel_shift =3D 0, }, - .def_cfg =3D &(struct s3c2410_uartcfg) { + .def_cfg =3D { .ucon =3D APPLE_S5L_UCON_DEFAULT, .ufcon =3D S3C2410_UFCON_DEFAULT, }, --=20 2.32.0 From nobody Tue Jun 23 09:24:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCAD4C433EF for ; Tue, 8 Mar 2022 08:09:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344826AbiCHIKi (ORCPT ); Tue, 8 Mar 2022 03:10:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344789AbiCHIKY (ORCPT ); Tue, 8 Mar 2022 03:10:24 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9516E3EB92 for ; Tue, 8 Mar 2022 00:09:28 -0800 (PST) Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 3FEF03F60D for ; Tue, 8 Mar 2022 08:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646726967; bh=JiKqSLqC9cz+DomuU4Hx2hld8wGUXAiXEgnja8m8/QA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qzy/0jMcFKkiyIMBaRsMnDlK80QqGFhkG5okvxsHwVU7zS+ry8KP5SVoW279J8+eI TlwUhhYq7rCEvWLnV11AmIWulN7GatZz8+NV7atHS64bF17f40y++mdLPKj2es875y PGJwNw/3060PHr3xnaT/+ek/j+ImdkKT9FmDqc0jx43ehXzVulvJXalBtJwYS7rOuh E5ZG2l803VglgfLNPsxzfOL1x+l3t99M7g0iJQc6egsfSKiSV5R4Lv8Dx/J0gDZ9PK bYXAfS78kwtOCC611FJGPYUT0fGEBgrpe4ksXfiAgik9D6B7mMdlWNuLq+BTs3xBDN kEiUMzR5ubemQ== Received: by mail-ej1-f69.google.com with SMTP id d7-20020a1709061f4700b006bbf73a7becso8242174ejk.17 for ; Tue, 08 Mar 2022 00:09:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JiKqSLqC9cz+DomuU4Hx2hld8wGUXAiXEgnja8m8/QA=; b=lRsQWGEEA4yp4Xq+Mi1b7Cx5E83yQpaFvvWclWuoRbZeSLx5rBus+9yDR/Lx5/P75p N44pH1t1gk5EuHbPir6Tq4Pzru/D8Is+vvApeKEpFIwRNLyzoy+2/l99k24UgiWlCh69 VfLlOaxk1ZRituhVCs8p+C2JC0ba96TPBKiWB2bwYW8UUIT5Wsyb1jAW9NhboMHg7bz9 uGMf3ChM21SPbs6dgs9CP54C+ErQKnLKJJPYyL+1GJd0e1RxWzC5tDIOODyQvaj/yH+O 5v5WItCHycdSS/k5n+JCgoJ3Nf8SzvCLxPwT0uGJtD9wLynNWvls1QsL/2SPzSeJbxar Qi3w== X-Gm-Message-State: AOAM531hpuDeXndthnIb5QF44EwBbqYrD63zyoPKI/OnXBzTF7k0Bkv5 KeY/sBW2wo2wFjsi1nGHl1Amum5pPMdzT1C9x1xCGBDxNnmq/s2TrylGgPAts2UfX4TFQBU0ppK /YZPC2XUGiT/7mX65RtDIOfe3lTu+7kyC7F1OCtoeoQ== X-Received: by 2002:a17:907:9691:b0:6d1:711d:9050 with SMTP id hd17-20020a170907969100b006d1711d9050mr12786631ejc.755.1646726966877; Tue, 08 Mar 2022 00:09:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJyP0hp7rDrHBkxpGSi42kG38akSsQnOk/uybyIcsE8rFLwZ5IzvABPItTpU0pBtDEzT1lGCMw== X-Received: by 2002:a17:907:9691:b0:6d1:711d:9050 with SMTP id hd17-20020a170907969100b006d1711d9050mr12786598ejc.755.1646726966458; Tue, 08 Mar 2022 00:09:26 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.gmail.com with ESMTPSA id t4-20020a056402524400b00415b90801edsm7385697edd.57.2022.03.08.00.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 00:09:26 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v3 3/8] tty: serial: samsung: reduce number of casts Date: Tue, 8 Mar 2022 09:09:14 +0100 Message-Id: <20220308080919.152715-4-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> References: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The pointers to instances of "struct s3c24xx_serial_drv_data" are first cast to kernel_ulong_t and then either used directly (in "platform_device_id.driver_data") or cast again to void * (in "of_device_id.data"). One cast can be dropped, so at least for "of_device_id.data" case there will be no casts at all. This makes the code a bit simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/tty/serial/samsung_tty.c | 72 ++++++++++++++++---------------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_= tty.c index a9a75b5b9705..66434eb58db8 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -2637,9 +2637,9 @@ static struct s3c24xx_serial_drv_data s3c2410_serial_= drv_data =3D { .ufcon =3D S3C2410_UFCON_DEFAULT, }, }; -#define S3C2410_SERIAL_DRV_DATA ((kernel_ulong_t)&s3c2410_serial_drv_data) +#define S3C2410_SERIAL_DRV_DATA (&s3c2410_serial_drv_data) #else -#define S3C2410_SERIAL_DRV_DATA (kernel_ulong_t)NULL +#define S3C2410_SERIAL_DRV_DATA NULL #endif =20 #ifdef CONFIG_CPU_S3C2412 @@ -2666,9 +2666,9 @@ static struct s3c24xx_serial_drv_data s3c2412_serial_= drv_data =3D { .ufcon =3D S3C2410_UFCON_DEFAULT, }, }; -#define S3C2412_SERIAL_DRV_DATA ((kernel_ulong_t)&s3c2412_serial_drv_data) +#define S3C2412_SERIAL_DRV_DATA (&s3c2412_serial_drv_data) #else -#define S3C2412_SERIAL_DRV_DATA (kernel_ulong_t)NULL +#define S3C2412_SERIAL_DRV_DATA NULL #endif =20 #if defined(CONFIG_CPU_S3C2440) || defined(CONFIG_CPU_S3C2416) || \ @@ -2697,9 +2697,9 @@ static struct s3c24xx_serial_drv_data s3c2440_serial_= drv_data =3D { .ufcon =3D S3C2410_UFCON_DEFAULT, }, }; -#define S3C2440_SERIAL_DRV_DATA ((kernel_ulong_t)&s3c2440_serial_drv_data) +#define S3C2440_SERIAL_DRV_DATA (&s3c2440_serial_drv_data) #else -#define S3C2440_SERIAL_DRV_DATA (kernel_ulong_t)NULL +#define S3C2440_SERIAL_DRV_DATA NULL #endif =20 #if defined(CONFIG_CPU_S3C6400) || defined(CONFIG_CPU_S3C6410) @@ -2726,9 +2726,9 @@ static struct s3c24xx_serial_drv_data s3c6400_serial_= drv_data =3D { .ufcon =3D S3C2410_UFCON_DEFAULT, }, }; -#define S3C6400_SERIAL_DRV_DATA ((kernel_ulong_t)&s3c6400_serial_drv_data) +#define S3C6400_SERIAL_DRV_DATA (&s3c6400_serial_drv_data) #else -#define S3C6400_SERIAL_DRV_DATA (kernel_ulong_t)NULL +#define S3C6400_SERIAL_DRV_DATA NULL #endif =20 #ifdef CONFIG_CPU_S5PV210 @@ -2755,9 +2755,9 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_= drv_data =3D { }, .fifosize =3D { 256, 64, 16, 16 }, }; -#define S5PV210_SERIAL_DRV_DATA ((kernel_ulong_t)&s5pv210_serial_drv_data) +#define S5PV210_SERIAL_DRV_DATA (&s5pv210_serial_drv_data) #else -#define S5PV210_SERIAL_DRV_DATA (kernel_ulong_t)NULL +#define S5PV210_SERIAL_DRV_DATA NULL #endif =20 #if defined(CONFIG_ARCH_EXYNOS) @@ -2799,14 +2799,14 @@ static struct s3c24xx_serial_drv_data exynos850_ser= ial_drv_data =3D { .fifosize =3D { 256, 64, 64, 64 }, }; =20 -#define EXYNOS4210_SERIAL_DRV_DATA ((kernel_ulong_t)&exynos4210_serial_drv= _data) -#define EXYNOS5433_SERIAL_DRV_DATA ((kernel_ulong_t)&exynos5433_serial_drv= _data) -#define EXYNOS850_SERIAL_DRV_DATA ((kernel_ulong_t)&exynos850_serial_drv_d= ata) +#define EXYNOS4210_SERIAL_DRV_DATA (&exynos4210_serial_drv_data) +#define EXYNOS5433_SERIAL_DRV_DATA (&exynos5433_serial_drv_data) +#define EXYNOS850_SERIAL_DRV_DATA (&exynos850_serial_drv_data) =20 #else -#define EXYNOS4210_SERIAL_DRV_DATA ((kernel_ulong_t)NULL) -#define EXYNOS5433_SERIAL_DRV_DATA ((kernel_ulong_t)NULL) -#define EXYNOS850_SERIAL_DRV_DATA ((kernel_ulong_t)NULL) +#define EXYNOS4210_SERIAL_DRV_DATA NULL +#define EXYNOS5433_SERIAL_DRV_DATA NULL +#define EXYNOS850_SERIAL_DRV_DATA NULL #endif =20 #ifdef CONFIG_ARCH_APPLE @@ -2832,39 +2832,39 @@ static struct s3c24xx_serial_drv_data s5l_serial_dr= v_data =3D { .ufcon =3D S3C2410_UFCON_DEFAULT, }, }; -#define S5L_SERIAL_DRV_DATA ((kernel_ulong_t)&s5l_serial_drv_data) +#define S5L_SERIAL_DRV_DATA (&s5l_serial_drv_data) #else -#define S5L_SERIAL_DRV_DATA ((kernel_ulong_t)NULL) +#define S5L_SERIAL_DRV_DATA NULL #endif =20 static const struct platform_device_id s3c24xx_serial_driver_ids[] =3D { { .name =3D "s3c2410-uart", - .driver_data =3D S3C2410_SERIAL_DRV_DATA, + .driver_data =3D (kernel_ulong_t)S3C2410_SERIAL_DRV_DATA, }, { .name =3D "s3c2412-uart", - .driver_data =3D S3C2412_SERIAL_DRV_DATA, + .driver_data =3D (kernel_ulong_t)S3C2412_SERIAL_DRV_DATA, }, { .name =3D "s3c2440-uart", - .driver_data =3D S3C2440_SERIAL_DRV_DATA, + .driver_data =3D (kernel_ulong_t)S3C2440_SERIAL_DRV_DATA, }, { .name =3D "s3c6400-uart", - .driver_data =3D S3C6400_SERIAL_DRV_DATA, + .driver_data =3D (kernel_ulong_t)S3C6400_SERIAL_DRV_DATA, }, { .name =3D "s5pv210-uart", - .driver_data =3D S5PV210_SERIAL_DRV_DATA, + .driver_data =3D (kernel_ulong_t)S5PV210_SERIAL_DRV_DATA, }, { .name =3D "exynos4210-uart", - .driver_data =3D EXYNOS4210_SERIAL_DRV_DATA, + .driver_data =3D (kernel_ulong_t)EXYNOS4210_SERIAL_DRV_DATA, }, { .name =3D "exynos5433-uart", - .driver_data =3D EXYNOS5433_SERIAL_DRV_DATA, + .driver_data =3D (kernel_ulong_t)EXYNOS5433_SERIAL_DRV_DATA, }, { .name =3D "s5l-uart", - .driver_data =3D S5L_SERIAL_DRV_DATA, + .driver_data =3D (kernel_ulong_t)S5L_SERIAL_DRV_DATA, }, { .name =3D "exynos850-uart", - .driver_data =3D EXYNOS850_SERIAL_DRV_DATA, + .driver_data =3D (kernel_ulong_t)EXYNOS850_SERIAL_DRV_DATA, }, { }, }; @@ -2873,23 +2873,23 @@ MODULE_DEVICE_TABLE(platform, s3c24xx_serial_driver= _ids); #ifdef CONFIG_OF static const struct of_device_id s3c24xx_uart_dt_match[] =3D { { .compatible =3D "samsung,s3c2410-uart", - .data =3D (void *)S3C2410_SERIAL_DRV_DATA }, + .data =3D S3C2410_SERIAL_DRV_DATA }, { .compatible =3D "samsung,s3c2412-uart", - .data =3D (void *)S3C2412_SERIAL_DRV_DATA }, + .data =3D S3C2412_SERIAL_DRV_DATA }, { .compatible =3D "samsung,s3c2440-uart", - .data =3D (void *)S3C2440_SERIAL_DRV_DATA }, + .data =3D S3C2440_SERIAL_DRV_DATA }, { .compatible =3D "samsung,s3c6400-uart", - .data =3D (void *)S3C6400_SERIAL_DRV_DATA }, + .data =3D S3C6400_SERIAL_DRV_DATA }, { .compatible =3D "samsung,s5pv210-uart", - .data =3D (void *)S5PV210_SERIAL_DRV_DATA }, + .data =3D S5PV210_SERIAL_DRV_DATA }, { .compatible =3D "samsung,exynos4210-uart", - .data =3D (void *)EXYNOS4210_SERIAL_DRV_DATA }, + .data =3D EXYNOS4210_SERIAL_DRV_DATA }, { .compatible =3D "samsung,exynos5433-uart", - .data =3D (void *)EXYNOS5433_SERIAL_DRV_DATA }, + .data =3D EXYNOS5433_SERIAL_DRV_DATA }, { .compatible =3D "apple,s5l-uart", - .data =3D (void *)S5L_SERIAL_DRV_DATA }, + .data =3D S5L_SERIAL_DRV_DATA }, { .compatible =3D "samsung,exynos850-uart", - .data =3D (void *)EXYNOS850_SERIAL_DRV_DATA }, + .data =3D EXYNOS850_SERIAL_DRV_DATA }, {}, }; MODULE_DEVICE_TABLE(of, s3c24xx_uart_dt_match); --=20 2.32.0 From nobody Tue Jun 23 09:24:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6915C433FE for ; Tue, 8 Mar 2022 08:09:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237521AbiCHIKn (ORCPT ); Tue, 8 Mar 2022 03:10:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344795AbiCHIKZ (ORCPT ); Tue, 8 Mar 2022 03:10:25 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7680B3D1F6 for ; Tue, 8 Mar 2022 00:09:29 -0800 (PST) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 52F7F3F61B for ; Tue, 8 Mar 2022 08:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646726968; bh=tfYTw7M8SGNblLSK+OTR7ft1x+niAVfIowhtu3q65AY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HXjJB6B9B6ejGdITG09qJCNIaaq/CcWIRiUKd5IwqDV5xmOgX6TbUBTKCt5PtWdUP /RoLR2JTax1E7McLkeWzlUzm5trNDQnZr79E7iCwXN9MDL+3aW+S0j9CyUjuEFVo7E Y+06/0+dEHC/IOaCftyrIdocS1jCmpSCxiiUM1zolPQyVGnKSD/z4sNya0mJCosypN 8fmlRzlUNcnB1EIc22zkB9TOgWuYNl21C//HKYkDEbbzSpmy9S66TGzubrRt4Zgrsc h+yuDNS7bk1bFv6o0NjwwJu9wbetchyRboMJW68xtW0e2RFngzUnzsi7NeeD98m9OW DeNZYSW92pwOQ== Received: by mail-ej1-f70.google.com with SMTP id 13-20020a170906328d00b006982d0888a4so8186818ejw.9 for ; Tue, 08 Mar 2022 00:09:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tfYTw7M8SGNblLSK+OTR7ft1x+niAVfIowhtu3q65AY=; b=Pjv77QsPpmFyt5g9ZIq+IiGDuQOGAVeS96IPcKQkMgX1/qADz8IdgZQfp1eTPJl9HJ Mi25jub1YA3jg93KPJF3TCkfuUiQLN6K0axWUgLOMce6pQFS0XUnxypwYoIFoVsewst5 U/56iv5lv6/CZqix06yTxiLKGZyOHN0g5Mhu/h57/y+6oR7X502QEb1jwFFF/gjegytQ ocJjNUipGELYj/BGpMhrhWIwjxjqI3M9cOZ2SIeKR3gujpggVsYLfAp1FulmIFOs1gu7 BSekI7nRHCeuZboIJBGqXtqHeIn5vGV4QepkWOSI15FILEbXEKwyiheV12PenP8JQ4HJ QqGw== X-Gm-Message-State: AOAM533hPUKLBigYJNxk49lJuFK+Rzdg+4Jl9UZT1c8d/wGOCIru4JYt +SgSBQUt4aJOl3Onq9LpR9aPziBmvoONm0jY3/mhNZuUMOAEc8xzQ86ozRmO9vArvYSnBuesafp 6RsRZiu5EM+HwFIE/HSCGLuZGCHWIRjeND00FFm4X1Q== X-Received: by 2002:a17:907:1b09:b0:6d8:faa8:4a06 with SMTP id mp9-20020a1709071b0900b006d8faa84a06mr12097008ejc.701.1646726967879; Tue, 08 Mar 2022 00:09:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJy4S5b8cDkgWsMD2VwX44UQxX1h1DDN2AljrAE6McGdTq0MBRrLMyFtooQYg29GydbisVK9qQ== X-Received: by 2002:a17:907:1b09:b0:6d8:faa8:4a06 with SMTP id mp9-20020a1709071b0900b006d8faa84a06mr12096985ejc.701.1646726967665; Tue, 08 Mar 2022 00:09:27 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.gmail.com with ESMTPSA id t4-20020a056402524400b00415b90801edsm7385697edd.57.2022.03.08.00.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 00:09:26 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v3 4/8] tty: serial: samsung: constify s3c24xx_serial_drv_data Date: Tue, 8 Mar 2022 09:09:15 +0100 Message-Id: <20220308080919.152715-5-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> References: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The driver data (struct s3c24xx_serial_drv_data) is only used to initialize the driver properly and is not modified. Make it const. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar Tested-by: Alim Akhtar --- drivers/tty/serial/samsung_tty.c | 58 ++++++++++++++++---------------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_= tty.c index 66434eb58db8..c4b13f2d6e26 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -136,14 +136,14 @@ struct s3c24xx_uart_port { unsigned int tx_mode; unsigned int rx_mode; =20 - struct s3c24xx_uart_info *info; + const struct s3c24xx_uart_info *info; struct clk *clk; struct clk *baudclk; struct uart_port port; - struct s3c24xx_serial_drv_data *drv_data; + const struct s3c24xx_serial_drv_data *drv_data; =20 /* reference to platform data */ - struct s3c2410_uartcfg *cfg; + const struct s3c2410_uartcfg *cfg; =20 struct s3c24xx_uart_dma *dma; =20 @@ -221,7 +221,7 @@ static inline void s3c24xx_clear_bit(struct uart_port *= port, int idx, local_irq_restore(flags); } =20 -static inline struct s3c24xx_uart_port *to_ourport(struct uart_port *port) +static inline struct s3c24xx_uart_port *to_ourport(const struct uart_port = *port) { return container_of(port, struct s3c24xx_uart_port, port); } @@ -573,13 +573,13 @@ static void s3c24xx_serial_stop_rx(struct uart_port *= port) } } =20 -static inline struct s3c24xx_uart_info +static inline const struct s3c24xx_uart_info *s3c24xx_port_to_info(struct uart_port *port) { return to_ourport(port)->info; } =20 -static inline struct s3c2410_uartcfg +static inline const struct s3c2410_uartcfg *s3c24xx_port_to_cfg(struct uart_port *port) { struct s3c24xx_uart_port *ourport; @@ -594,7 +594,7 @@ static inline struct s3c2410_uartcfg static int s3c24xx_serial_rx_fifocnt(struct s3c24xx_uart_port *ourport, unsigned long ufstat) { - struct s3c24xx_uart_info *info =3D ourport->info; + const struct s3c24xx_uart_info *info =3D ourport->info; =20 if (ufstat & info->rx_fifofull) return ourport->port.fifosize; @@ -986,7 +986,7 @@ static irqreturn_t apple_serial_handle_irq(int irq, voi= d *id) =20 static unsigned int s3c24xx_serial_tx_empty(struct uart_port *port) { - struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); + const struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); unsigned long ufstat =3D rd_regl(port, S3C2410_UFSTAT); unsigned long ufcon =3D rd_regl(port, S3C2410_UFCON); =20 @@ -1405,7 +1405,7 @@ static void s3c24xx_serial_pm(struct uart_port *port,= unsigned int level, =20 static inline int s3c24xx_serial_getsource(struct uart_port *port) { - struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); + const struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); unsigned int ucon; =20 if (info->num_clks =3D=3D 1) @@ -1419,7 +1419,7 @@ static inline int s3c24xx_serial_getsource(struct uar= t_port *port) static void s3c24xx_serial_setsource(struct uart_port *port, unsigned int clk_sel) { - struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); + const struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); unsigned int ucon; =20 if (info->num_clks =3D=3D 1) @@ -1438,7 +1438,7 @@ static unsigned int s3c24xx_serial_getclk(struct s3c2= 4xx_uart_port *ourport, unsigned int req_baud, struct clk **best_clk, unsigned int *clk_num) { - struct s3c24xx_uart_info *info =3D ourport->info; + const struct s3c24xx_uart_info *info =3D ourport->info; struct clk *clk; unsigned long rate; unsigned int cnt, baud, quot, best_quot =3D 0; @@ -1522,7 +1522,7 @@ static void s3c24xx_serial_set_termios(struct uart_po= rt *port, struct ktermios *termios, struct ktermios *old) { - struct s3c2410_uartcfg *cfg =3D s3c24xx_port_to_cfg(port); + const struct s3c2410_uartcfg *cfg =3D s3c24xx_port_to_cfg(port); struct s3c24xx_uart_port *ourport =3D to_ourport(port); struct clk *clk =3D ERR_PTR(-EINVAL); unsigned long flags; @@ -1691,7 +1691,7 @@ static const char *s3c24xx_serial_type(struct uart_po= rt *port) =20 static void s3c24xx_serial_config_port(struct uart_port *port, int flags) { - struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); + const struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); =20 if (flags & UART_CONFIG_TYPE) port->type =3D info->port_type; @@ -1703,7 +1703,7 @@ static void s3c24xx_serial_config_port(struct uart_po= rt *port, int flags) static int s3c24xx_serial_verify_port(struct uart_port *port, struct serial_struct *s= er) { - struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); + const struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); =20 if (ser->type !=3D PORT_UNKNOWN && ser->type !=3D info->port_type) return -EINVAL; @@ -1873,9 +1873,9 @@ s3c24xx_serial_ports[CONFIG_SERIAL_SAMSUNG_UARTS] =3D= { */ =20 static void s3c24xx_serial_resetport(struct uart_port *port, - struct s3c2410_uartcfg *cfg) + const struct s3c2410_uartcfg *cfg) { - struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); + const struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); unsigned long ucon =3D rd_regl(port, S3C2410_UCON); =20 ucon &=3D (info->clksel_mask | info->ucon_mask); @@ -1979,7 +1979,7 @@ s3c24xx_serial_cpufreq_deregister(struct s3c24xx_uart= _port *port) static int s3c24xx_serial_enable_baudclk(struct s3c24xx_uart_port *ourport) { struct device *dev =3D ourport->port.dev; - struct s3c24xx_uart_info *info =3D ourport->info; + const struct s3c24xx_uart_info *info =3D ourport->info; char clk_name[MAX_CLK_NAME_LENGTH]; unsigned int clk_sel; struct clk *clk; @@ -2021,7 +2021,7 @@ static int s3c24xx_serial_init_port(struct s3c24xx_ua= rt_port *ourport, struct platform_device *platdev) { struct uart_port *port =3D &ourport->port; - struct s3c2410_uartcfg *cfg =3D ourport->cfg; + const struct s3c2410_uartcfg *cfg =3D ourport->cfg; struct resource *res; int ret; =20 @@ -2156,7 +2156,7 @@ static const struct of_device_id s3c24xx_uart_dt_matc= h[]; =20 static int probe_index; =20 -static inline struct s3c24xx_serial_drv_data * +static inline const struct s3c24xx_serial_drv_data * s3c24xx_get_driver_data(struct platform_device *pdev) { #ifdef CONFIG_OF @@ -2419,7 +2419,7 @@ static struct uart_port *cons_uart; static int s3c24xx_serial_console_txrdy(struct uart_port *port, unsigned int ufcon) { - struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); + const struct s3c24xx_uart_info *info =3D s3c24xx_port_to_info(port); unsigned long ufstat, utrstat; =20 if (ufcon & S3C2410_UFCON_FIFOMODE) { @@ -2615,7 +2615,7 @@ static struct console s3c24xx_serial_console =3D { #endif /* CONFIG_SERIAL_SAMSUNG_CONSOLE */ =20 #ifdef CONFIG_CPU_S3C2410 -static struct s3c24xx_serial_drv_data s3c2410_serial_drv_data =3D { +static const struct s3c24xx_serial_drv_data s3c2410_serial_drv_data =3D { .info =3D { .name =3D "Samsung S3C2410 UART", .type =3D TYPE_S3C24XX, @@ -2643,7 +2643,7 @@ static struct s3c24xx_serial_drv_data s3c2410_serial_= drv_data =3D { #endif =20 #ifdef CONFIG_CPU_S3C2412 -static struct s3c24xx_serial_drv_data s3c2412_serial_drv_data =3D { +static const struct s3c24xx_serial_drv_data s3c2412_serial_drv_data =3D { .info =3D { .name =3D "Samsung S3C2412 UART", .type =3D TYPE_S3C24XX, @@ -2673,7 +2673,7 @@ static struct s3c24xx_serial_drv_data s3c2412_serial_= drv_data =3D { =20 #if defined(CONFIG_CPU_S3C2440) || defined(CONFIG_CPU_S3C2416) || \ defined(CONFIG_CPU_S3C2443) || defined(CONFIG_CPU_S3C2442) -static struct s3c24xx_serial_drv_data s3c2440_serial_drv_data =3D { +static const struct s3c24xx_serial_drv_data s3c2440_serial_drv_data =3D { .info =3D { .name =3D "Samsung S3C2440 UART", .type =3D TYPE_S3C24XX, @@ -2703,7 +2703,7 @@ static struct s3c24xx_serial_drv_data s3c2440_serial_= drv_data =3D { #endif =20 #if defined(CONFIG_CPU_S3C6400) || defined(CONFIG_CPU_S3C6410) -static struct s3c24xx_serial_drv_data s3c6400_serial_drv_data =3D { +static const struct s3c24xx_serial_drv_data s3c6400_serial_drv_data =3D { .info =3D { .name =3D "Samsung S3C6400 UART", .type =3D TYPE_S3C6400, @@ -2732,7 +2732,7 @@ static struct s3c24xx_serial_drv_data s3c6400_serial_= drv_data =3D { #endif =20 #ifdef CONFIG_CPU_S5PV210 -static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data =3D { +static const struct s3c24xx_serial_drv_data s5pv210_serial_drv_data =3D { .info =3D { .name =3D "Samsung S5PV210 UART", .type =3D TYPE_S3C6400, @@ -2784,17 +2784,17 @@ static struct s3c24xx_serial_drv_data s5pv210_seria= l_drv_data =3D { .has_fracval =3D 1, \ } \ =20 -static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data =3D { +static const struct s3c24xx_serial_drv_data exynos4210_serial_drv_data =3D= { EXYNOS_COMMON_SERIAL_DRV_DATA(), .fifosize =3D { 256, 64, 16, 16 }, }; =20 -static struct s3c24xx_serial_drv_data exynos5433_serial_drv_data =3D { +static const struct s3c24xx_serial_drv_data exynos5433_serial_drv_data =3D= { EXYNOS_COMMON_SERIAL_DRV_DATA(), .fifosize =3D { 64, 256, 16, 256 }, }; =20 -static struct s3c24xx_serial_drv_data exynos850_serial_drv_data =3D { +static const struct s3c24xx_serial_drv_data exynos850_serial_drv_data =3D { EXYNOS_COMMON_SERIAL_DRV_DATA(), .fifosize =3D { 256, 64, 64, 64 }, }; @@ -2810,7 +2810,7 @@ static struct s3c24xx_serial_drv_data exynos850_seria= l_drv_data =3D { #endif =20 #ifdef CONFIG_ARCH_APPLE -static struct s3c24xx_serial_drv_data s5l_serial_drv_data =3D { +static const struct s3c24xx_serial_drv_data s5l_serial_drv_data =3D { .info =3D { .name =3D "Apple S5L UART", .type =3D TYPE_APPLE_S5L, --=20 2.32.0 From nobody Tue Jun 23 09:24:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A14C3C433FE for ; Tue, 8 Mar 2022 08:09:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243546AbiCHIKt (ORCPT ); Tue, 8 Mar 2022 03:10:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344798AbiCHIK3 (ORCPT ); Tue, 8 Mar 2022 03:10:29 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B291C3EAA9 for ; Tue, 8 Mar 2022 00:09:30 -0800 (PST) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 5F1F33F7E0 for ; Tue, 8 Mar 2022 08:09:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646726969; bh=29Pf3ZsU5JJVOHBIO1WRfRouMVWJymQOmYuJyfmZYy4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LkfbNmA9Vjt18uCAYkD/pVLrecoVDZlQhW5ah475s/GQnogj6tnEjYQ6nHpDib1X3 R3473N8FT7FF25HiCF7EMiaMW6GYb2rCOMD99DeNX7sxtMEEGck8lzy7sT5Q3vpxBI XpwVT0ILex4z0miDeiAXMaognDhTvvCh6Za3ur3q8nAHkbimbx6oDPLOrHBm/uPr/A FAlsUBQA2n30Pq5et4NQzOgBQh3/2PWjbNK7MkxTLiLz3HpdqfNd4kkvD7NbRB7dl9 IbuMAczN6X4DYZi8g9FL42hBwyVVENMDDSSZby3uCMcI2qOufJ7M7nnCTPFuV9pVTh irARfJ5mM/3+Q== Received: by mail-ed1-f69.google.com with SMTP id co2-20020a0564020c0200b00415f9fa6ca8so6664726edb.6 for ; Tue, 08 Mar 2022 00:09:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=29Pf3ZsU5JJVOHBIO1WRfRouMVWJymQOmYuJyfmZYy4=; b=BdqzbuAV0tId1XXSzZ0pSMFs3+FR9V6mODeSQNtfM7li5KO3KT1aN2tBcYogweRDkR PgXYijySKvWw/2RVJVrJGLyhS/0NtwfwQ9FhJ7l7GafX4GIjp82sO+QMmBdnU1PIl58H QopdYtzUOoNnaTEE71xbZ4QqBXI6Tq5ZfooRDQrJzhIxjU8nbQ9/LwNWr5bjZ2MY61nD 5rKBAQXJQyJ2l93UiQEp09Vm/QihXwj+Jpeu/R5mLlHR8S0mYu4kSG9q6ydtjr8lAcQn Kozxo65x8qsnD23dBM/09uRXc8CVkfKVJ69LylztW4RvBky53m0vfzVDaIV7d7tU4HDb Pf6A== X-Gm-Message-State: AOAM533cXpVHHNLNUT0ra90HLYAUsp+LQD2v+LJq0q6ZpKW9o1UUKiz6 NO/ElLvsX+IwAht4FPkAYhHv3oHhfi12IJ8olRrL1O8+Z5ilj5Uu2cGK2mYkIsUVoBbIUFR4aCo dQiQIcrbPXL0nfEJSgXOULNOwmRr0moS/FlLdn/S5rA== X-Received: by 2002:a17:906:9bd7:b0:6d6:e920:8d04 with SMTP id de23-20020a1709069bd700b006d6e9208d04mr12389916ejc.547.1646726969067; Tue, 08 Mar 2022 00:09:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCDpyzVeafJO+tBKmLNUmXCUwu/pvO8ES0IOzwYdYS55Y3KidkwCIqb81SC/LBMvb5FhouCg== X-Received: by 2002:a17:906:9bd7:b0:6d6:e920:8d04 with SMTP id de23-20020a1709069bd700b006d6e9208d04mr12389895ejc.547.1646726968858; Tue, 08 Mar 2022 00:09:28 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.gmail.com with ESMTPSA id t4-20020a056402524400b00415b90801edsm7385697edd.57.2022.03.08.00.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 00:09:28 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v3 5/8] tty: serial: samsung: constify UART name Date: Tue, 8 Mar 2022 09:09:16 +0100 Message-Id: <20220308080919.152715-6-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> References: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The UART name from driver data holds only string literals. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jiri Slaby Reviewed-by: Alim Akhtar Tested-by: Alim Akhtar --- drivers/tty/serial/samsung_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_= tty.c index c4b13f2d6e26..7025306f76b7 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -63,7 +63,7 @@ enum s3c24xx_port_type { }; =20 struct s3c24xx_uart_info { - char *name; + const char *name; enum s3c24xx_port_type type; unsigned int port_type; unsigned int fifosize; --=20 2.32.0 From nobody Tue Jun 23 09:24:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00A21C433F5 for ; Tue, 8 Mar 2022 08:09:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344840AbiCHIKv (ORCPT ); Tue, 8 Mar 2022 03:10:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344804AbiCHIK3 (ORCPT ); Tue, 8 Mar 2022 03:10:29 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 454653EB98 for ; Tue, 8 Mar 2022 00:09:32 -0800 (PST) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1339F3F7E4 for ; Tue, 8 Mar 2022 08:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646726971; bh=Dr4tgo26oKDD7/cFmU+MgZtFQEJoCk73ZvgNX0zaNnk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=MW4cS/a3rZ6mGwrKSnHQ9n+eNyJl1EoZSCGCxN/P3foXVGy6W5iqZ3gM7TiTKKrvt W6iXAeVZLcKVfrvMEsePZqimQGUDPrQzjoABVIGYLcrLCxxbhkmM1uohT8hZKEnwaj 9tY6NKr2GJaXu5yRF5uybkXDZztssgVl+rMCNZjK2Ck2C9xoGlOps2mgzjCOfTqjMG CmOlZatxvEnhmYqS9aV3L90kblYY5Oc2PozdxcCk2Agi/wiU82Ss3gYPRd7ERuNEh0 WzxJlLpmdmGL/KFqduwBKDvro+kbRiuY59jfNso5dDmG57E4KsU5zV8unPydIZ+mdM +9/wWiQBGFBrw== Received: by mail-ed1-f71.google.com with SMTP id l24-20020a056402231800b00410f19a3103so10133086eda.5 for ; Tue, 08 Mar 2022 00:09:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dr4tgo26oKDD7/cFmU+MgZtFQEJoCk73ZvgNX0zaNnk=; b=6Hq1QSmiMm6LfnTU5we4N4BmvKo8OVNpU88Fts2Eu3O9FTUQrg2ZwDy1vzvUmyx4XP ae6fWF0lkuKeycfU5JCqOJWRlTGsppPHe/GnesWPBMkeUxOODoBvFCJfNQOVdHnHZM6r 9WZ+iiayUrr+uFOuIcFdbgjYY+slwdD2zxv7kE5pIPt4nZJcCimKJZD+Iw/fCd7Na/p6 eTtCIv1Rip+/M0gzAQ1OGHb9yWpYQki0hQ4JLCf6wiT4Y99XWZS5kL1F4IF1ct6GhmVc dTpeNphzV/kBXjsVjRwBbpP243tguxEB3M1Az7JzeaEh0jhlwVgjoEXgRMYm3pdwhq4O 0mUw== X-Gm-Message-State: AOAM5319NhVf3bboEnTDQzLYyqXtqxeB9RhN/25cKwxCcimeDxqXM/gz KkT1s73gpIeOH2fxrmiiCO62kbh+x/mvo8+5E5Bo9og7rtQVKZyHW4qk1ClOjBivsaIiZo/SP2o qJLnTFgdpfw7oKcE3YHoIzVuc1BOVefGCpYcHHFUHnA== X-Received: by 2002:a17:906:3e90:b0:6b6:829b:577c with SMTP id a16-20020a1709063e9000b006b6829b577cmr12689316ejj.711.1646726970628; Tue, 08 Mar 2022 00:09:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJyvyuR3mb0kzIzmDG7xL2Oq1O5GTZ5RmEqTaJMl1TSRoKLAqTby19CSrJRxPUdjCfrfwqyzaw== X-Received: by 2002:a17:906:3e90:b0:6b6:829b:577c with SMTP id a16-20020a1709063e9000b006b6829b577cmr12689291ejj.711.1646726970318; Tue, 08 Mar 2022 00:09:30 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.gmail.com with ESMTPSA id t4-20020a056402524400b00415b90801edsm7385697edd.57.2022.03.08.00.09.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 00:09:29 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v3 6/8] tty: serial: samsung: constify s3c24xx_serial_drv_data members Date: Tue, 8 Mar 2022 09:09:17 +0100 Message-Id: <20220308080919.152715-7-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> References: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The driver data (struct s3c24xx_serial_drv_data) is never modified, so also its members can be made const. Except code style this has no impact because the structure itself is always a const. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jiri Slaby Reviewed-by: Alim Akhtar Tested-by: Alim Akhtar --- drivers/tty/serial/samsung_tty.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_= tty.c index 7025306f76b7..b9783d8fb440 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -85,9 +85,9 @@ struct s3c24xx_uart_info { }; =20 struct s3c24xx_serial_drv_data { - struct s3c24xx_uart_info info; - struct s3c2410_uartcfg def_cfg; - unsigned int fifosize[CONFIG_SERIAL_SAMSUNG_UARTS]; + const struct s3c24xx_uart_info info; + const struct s3c2410_uartcfg def_cfg; + const unsigned int fifosize[CONFIG_SERIAL_SAMSUNG_UARTS]; }; =20 struct s3c24xx_uart_dma { --=20 2.32.0 From nobody Tue Jun 23 09:24:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69A2CC433EF for ; Tue, 8 Mar 2022 08:10:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344858AbiCHILI (ORCPT ); Tue, 8 Mar 2022 03:11:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344819AbiCHIKh (ORCPT ); Tue, 8 Mar 2022 03:10:37 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81D013EBAA for ; Tue, 8 Mar 2022 00:09:33 -0800 (PST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 5266E3F5F1 for ; Tue, 8 Mar 2022 08:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646726972; bh=YZ43hLE0duJi88wrK3ybDZb8cX9SjP237BkyHbKYO34=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pDDkeXEo8kI2Eol4WTMcXtArxqTPkn90ZVA6sSq3Lhstfvmok0q7b8QaMqob6ippI GeWhc7q43OUEFC0buXfFBUWq833OfQKDJwtifZV1OBi5WClwqUoGIh8q/dvob2joTC PF/g1y/wVXa/a2xrDHuO1WmejP0t7K1Uvys0FLooAOwapbQp5bjB70vmkR+ZTQ70i8 xDs5l6mwT26ue1g/svXeZLgKooi0mXNOf8Ohsv7vI9wUFd7cKxvDfWaZXetM7Z38U6 StPeJFn2u3QQrdMTXeDVTbWsQiZD7DOZma7MZBSNCDBVcIZB1LX9i0q0TLVsUyUD/p +C/9ObqWceQ8Q== Received: by mail-ed1-f70.google.com with SMTP id n11-20020aa7c68b000000b0041641550e11so3771951edq.8 for ; Tue, 08 Mar 2022 00:09:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YZ43hLE0duJi88wrK3ybDZb8cX9SjP237BkyHbKYO34=; b=MpZUWSu06FwBMdTKOaL8kyfpNXDUpzMYMs1tVeu2RXDYhyxZyA71wib44/goiqWtUJ 6KegWjAVsofrbEKygfwDRS7HhaZ8D4Mrz+BjbirgDD885x++VigMTgXNELp4A+4xDvGv 2nkPBfsExjkWssk7BLBgMJLMxsIjVYRWj/FUOJ4vny2CeVZYetEpx8P0vKFa+PwX6C/m rJDlNTW2gHAN1rLm0OJShtt57E5kaMv0s5AJtwIea6IoGYTLgObjLxwXYSABLHRTR0vW RQx7sE0F2AKbXwW/GRs/A75iMbov7pHbvb+zuhAeBqEiXK7a4P0wyDKN7P/fmdE8qhms 3qYQ== X-Gm-Message-State: AOAM53363ywHSk65/u0Sxwb50IKd0xq/Sq8LamN3NIjZePd0c2x0Y0PV DyGX66XfHPg2WQGO2RCihmta1/nSxNYxonAm4Fho6qx+klq6vRet+QZ7m9wtUrI6U5wlBdiY+wc m2fwtZa7WenNtO83cYL5krdL0nmyhQ+KFo9iwKjVmJg== X-Received: by 2002:a17:906:e08c:b0:6bb:6f89:7d59 with SMTP id gh12-20020a170906e08c00b006bb6f897d59mr12109649ejb.85.1646726971877; Tue, 08 Mar 2022 00:09:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJyxGJcW6u1S98RfCw05htwWFvnVS+wlZNMJiHq0b+kovRBJRvSyL9xFWYDEk4pestC9EEEWVA== X-Received: by 2002:a17:906:e08c:b0:6bb:6f89:7d59 with SMTP id gh12-20020a170906e08c00b006bb6f897d59mr12109636ejb.85.1646726971666; Tue, 08 Mar 2022 00:09:31 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.gmail.com with ESMTPSA id t4-20020a056402524400b00415b90801edsm7385697edd.57.2022.03.08.00.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 00:09:31 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v3 7/8] tty: serial: samsung: constify variables and pointers Date: Tue, 8 Mar 2022 09:09:18 +0100 Message-Id: <20220308080919.152715-8-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> References: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Constify variables, data pointed by several pointers and "udivslot_table" static array. This makes code a bit safer. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jiri Slaby Reviewed-by: Alim Akhtar Tested-by: Alim Akhtar --- drivers/tty/serial/samsung_tty.c | 46 ++++++++++++++++---------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_= tty.c index b9783d8fb440..3ffae912217c 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -164,7 +164,7 @@ static void s3c24xx_serial_tx_chars(struct s3c24xx_uart= _port *ourport); #define portaddrl(port, reg) \ ((unsigned long *)(unsigned long)((port)->membase + (reg))) =20 -static u32 rd_reg(struct uart_port *port, u32 reg) +static u32 rd_reg(const struct uart_port *port, u32 reg) { switch (port->iotype) { case UPIO_MEM: @@ -179,7 +179,7 @@ static u32 rd_reg(struct uart_port *port, u32 reg) =20 #define rd_regl(port, reg) (readl_relaxed(portaddr(port, reg))) =20 -static void wr_reg(struct uart_port *port, u32 reg, u32 val) +static void wr_reg(const struct uart_port *port, u32 reg, u32 val) { switch (port->iotype) { case UPIO_MEM: @@ -195,7 +195,7 @@ static void wr_reg(struct uart_port *port, u32 reg, u32= val) =20 /* Byte-order aware bit setting/clearing functions. */ =20 -static inline void s3c24xx_set_bit(struct uart_port *port, int idx, +static inline void s3c24xx_set_bit(const struct uart_port *port, int idx, unsigned int reg) { unsigned long flags; @@ -208,7 +208,7 @@ static inline void s3c24xx_set_bit(struct uart_port *po= rt, int idx, local_irq_restore(flags); } =20 -static inline void s3c24xx_clear_bit(struct uart_port *port, int idx, +static inline void s3c24xx_clear_bit(const struct uart_port *port, int idx, unsigned int reg) { unsigned long flags; @@ -221,19 +221,19 @@ static inline void s3c24xx_clear_bit(struct uart_port= *port, int idx, local_irq_restore(flags); } =20 -static inline struct s3c24xx_uart_port *to_ourport(const struct uart_port = *port) +static inline struct s3c24xx_uart_port *to_ourport(struct uart_port *port) { return container_of(port, struct s3c24xx_uart_port, port); } =20 /* translate a port to the device name */ =20 -static inline const char *s3c24xx_serial_portname(struct uart_port *port) +static inline const char *s3c24xx_serial_portname(const struct uart_port *= port) { return to_platform_device(port->dev)->name; } =20 -static int s3c24xx_serial_txempty_nofifo(struct uart_port *port) +static int s3c24xx_serial_txempty_nofifo(const struct uart_port *port) { return rd_regl(port, S3C2410_UTRSTAT) & S3C2410_UTRSTAT_TXE; } @@ -358,7 +358,7 @@ static void s3c24xx_serial_tx_dma_complete(void *args) =20 static void enable_tx_dma(struct s3c24xx_uart_port *ourport) { - struct uart_port *port =3D &ourport->port; + const struct uart_port *port =3D &ourport->port; u32 ucon; =20 /* Mask Tx interrupt */ @@ -387,7 +387,7 @@ static void enable_tx_dma(struct s3c24xx_uart_port *our= port) =20 static void enable_tx_pio(struct s3c24xx_uart_port *ourport) { - struct uart_port *port =3D &ourport->port; + const struct uart_port *port =3D &ourport->port; u32 ucon, ufcon; =20 /* Set ufcon txtrig */ @@ -580,9 +580,9 @@ static inline const struct s3c24xx_uart_info } =20 static inline const struct s3c2410_uartcfg - *s3c24xx_port_to_cfg(struct uart_port *port) + *s3c24xx_port_to_cfg(const struct uart_port *port) { - struct s3c24xx_uart_port *ourport; + const struct s3c24xx_uart_port *ourport; =20 if (port->dev =3D=3D NULL) return NULL; @@ -591,7 +591,7 @@ static inline const struct s3c2410_uartcfg return ourport->cfg; } =20 -static int s3c24xx_serial_rx_fifocnt(struct s3c24xx_uart_port *ourport, +static int s3c24xx_serial_rx_fifocnt(const struct s3c24xx_uart_port *ourpo= rt, unsigned long ufstat) { const struct s3c24xx_uart_info *info =3D ourport->info; @@ -947,8 +947,8 @@ static irqreturn_t s3c24xx_serial_tx_irq(int irq, void = *id) /* interrupt handler for s3c64xx and later SoC's.*/ static irqreturn_t s3c64xx_serial_handle_irq(int irq, void *id) { - struct s3c24xx_uart_port *ourport =3D id; - struct uart_port *port =3D &ourport->port; + const struct s3c24xx_uart_port *ourport =3D id; + const struct uart_port *port =3D &ourport->port; unsigned int pend =3D rd_regl(port, S3C64XX_UINTP); irqreturn_t ret =3D IRQ_HANDLED; =20 @@ -966,8 +966,8 @@ static irqreturn_t s3c64xx_serial_handle_irq(int irq, v= oid *id) /* interrupt handler for Apple SoC's.*/ static irqreturn_t apple_serial_handle_irq(int irq, void *id) { - struct s3c24xx_uart_port *ourport =3D id; - struct uart_port *port =3D &ourport->port; + const struct s3c24xx_uart_port *ourport =3D id; + const struct uart_port *port =3D &ourport->port; unsigned int pend =3D rd_regl(port, S3C2410_UTRSTAT); irqreturn_t ret =3D IRQ_NONE; =20 @@ -1499,7 +1499,7 @@ static unsigned int s3c24xx_serial_getclk(struct s3c2= 4xx_uart_port *ourport, * This table takes the fractional value of the baud divisor and gives * the recommended setting for the UDIVSLOT register. */ -static u16 udivslot_table[16] =3D { +static const u16 udivslot_table[16] =3D { [0] =3D 0x0000, [1] =3D 0x0080, [2] =3D 0x0808, @@ -1675,7 +1675,7 @@ static void s3c24xx_serial_set_termios(struct uart_po= rt *port, =20 static const char *s3c24xx_serial_type(struct uart_port *port) { - struct s3c24xx_uart_port *ourport =3D to_ourport(port); + const struct s3c24xx_uart_port *ourport =3D to_ourport(port); =20 switch (ourport->info->type) { case TYPE_S3C24XX: @@ -2450,7 +2450,7 @@ s3c24xx_port_configured(unsigned int ucon) =20 static int s3c24xx_serial_get_poll_char(struct uart_port *port) { - struct s3c24xx_uart_port *ourport =3D to_ourport(port); + const struct s3c24xx_uart_port *ourport =3D to_ourport(port); unsigned int ufstat; =20 ufstat =3D rd_regl(port, S3C2410_UFSTAT); @@ -2935,7 +2935,7 @@ module_exit(samsung_serial_exit); * Early console. */ =20 -static void wr_reg_barrier(struct uart_port *port, u32 reg, u32 val) +static void wr_reg_barrier(const struct uart_port *port, u32 reg, u32 val) { switch (port->iotype) { case UPIO_MEM: @@ -2951,15 +2951,15 @@ struct samsung_early_console_data { u32 txfull_mask; }; =20 -static void samsung_early_busyuart(struct uart_port *port) +static void samsung_early_busyuart(const struct uart_port *port) { while (!(readl(port->membase + S3C2410_UTRSTAT) & S3C2410_UTRSTAT_TXFE)) ; } =20 -static void samsung_early_busyuart_fifo(struct uart_port *port) +static void samsung_early_busyuart_fifo(const struct uart_port *port) { - struct samsung_early_console_data *data =3D port->private_data; + const struct samsung_early_console_data *data =3D port->private_data; =20 while (readl(port->membase + S3C2410_UFSTAT) & data->txfull_mask) ; --=20 2.32.0 From nobody Tue Jun 23 09:24:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70770C433FE for ; Tue, 8 Mar 2022 08:10:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344815AbiCHILO (ORCPT ); Tue, 8 Mar 2022 03:11:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344824AbiCHIKi (ORCPT ); Tue, 8 Mar 2022 03:10:38 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DCBE3EBBD for ; Tue, 8 Mar 2022 00:09:35 -0800 (PST) Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id B42603F629 for ; Tue, 8 Mar 2022 08:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646726973; bh=HBWgDosMAxuyNUJy93OLxsRzmckdD8hfFxFfwNDa3dk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gTeTFmNS5aebL7Hy7XLUm1mOhREgd7O3FVcgt1QYGhKZYxSTk0tWAjT/Uu5uryPoA WfdfSRFLipFl72xbXy1CV/QECMhWfStoQmy7CNGuIwk+yQOErXny4Imvz3QGPnBHbx HyTpYRFchYhuptwz8ri0GRWC9tGz0wRtIjclmAX0IzcLfNcgEYuhzwfbcxIosOOdv4 1p8odZsdwLxL7rJ1VoVq7ebhArOygBHhCtyh0p1wsLYviFJA5doITv0KvV9In/G0G3 btbNnnZXOYSoB9ikn2gfUfEC6xamK8/kZhGqJTcsTGfcS/bb3GpbzhIeqWjqcWaPKY lRR3IRG8dbuBQ== Received: by mail-ej1-f69.google.com with SMTP id hr26-20020a1709073f9a00b006d6d1ee8cf8so8176310ejc.19 for ; Tue, 08 Mar 2022 00:09:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HBWgDosMAxuyNUJy93OLxsRzmckdD8hfFxFfwNDa3dk=; b=dCjjWpOBLV9Bq+4zrcQMqvt5QrkqN2M7oYS0qoLysndSKZjh1bTBpW+40A1EsRrdjb PM4CM86uYzr0LoQvehXU/0cK3j/C1eyxfhjRmIv8VLWSksF501hGCoOCWVOLO+rLdj2W NNEveovlCJiZUFrhGYfJPfwwEKrTHKgJl4Cid+G3jEHugnlcXELeC7PrbW2LVBoBobIy 8M6Vk4AIKin45NaWBg3Xs2zeuS1t6erBm7yIw8/J/qjJ1pcX9n1wX35Sw3yeBkZCIV/s OPhmOQsLyHsp59wzOWUjcdDynHLKt+pIv/Cy4M+zBZXcdRgzHR/rfsGq/fIKogqYM4cs CCxA== X-Gm-Message-State: AOAM532hFSU2Ui4/8uxz5VKcRCHTWL/cLbcdbvemGALkrqlqad45k/Ml hN81kOfqLHBgSqqyzoT3KLZjj62nPuDv0PXX4kkFD3yEdMiv9PC+IRghprA+ytiqnkyK543BNVO /S5+NWElmEtkddmVUSqzGcyNaYQtce3VaR5tT22UFIA== X-Received: by 2002:a05:6402:3582:b0:416:6d78:c693 with SMTP id y2-20020a056402358200b004166d78c693mr1885074edc.24.1646726973296; Tue, 08 Mar 2022 00:09:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJwX4vanJVIXL0r2uldoJOauafSu6vD8LH4bQI9ff/g3MAlWaGOGZ5yN4YqE3lb73p272nAkog== X-Received: by 2002:a05:6402:3582:b0:416:6d78:c693 with SMTP id y2-20020a056402358200b004166d78c693mr1885050edc.24.1646726973053; Tue, 08 Mar 2022 00:09:33 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.gmail.com with ESMTPSA id t4-20020a056402524400b00415b90801edsm7385697edd.57.2022.03.08.00.09.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 00:09:32 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v3 8/8] tty: serial: samsung: simplify getting OF match data Date: Tue, 8 Mar 2022 09:09:19 +0100 Message-Id: <20220308080919.152715-9-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> References: <20220308080919.152715-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Simplify the code with of_device_get_match_data() and use dev_of_node() to remove ifdef-erry. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar Tested-by: Alim Akhtar --- drivers/tty/serial/samsung_tty.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_= tty.c index 3ffae912217c..74d466cc4152 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -2150,23 +2150,14 @@ static int s3c24xx_serial_init_port(struct s3c24xx_= uart_port *ourport, =20 /* Device driver serial port probe */ =20 -#ifdef CONFIG_OF -static const struct of_device_id s3c24xx_uart_dt_match[]; -#endif - static int probe_index; =20 static inline const struct s3c24xx_serial_drv_data * s3c24xx_get_driver_data(struct platform_device *pdev) { -#ifdef CONFIG_OF - if (pdev->dev.of_node) { - const struct of_device_id *match; + if (dev_of_node(&pdev->dev)) + return of_device_get_match_data(&pdev->dev); =20 - match =3D of_match_node(s3c24xx_uart_dt_match, pdev->dev.of_node); - return (struct s3c24xx_serial_drv_data *)match->data; - } -#endif return (struct s3c24xx_serial_drv_data *) platform_get_device_id(pdev)->driver_data; } --=20 2.32.0