From nobody Tue Jun 23 09:12:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9BB7C433EF for ; Tue, 8 Mar 2022 03:32:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243968AbiCHDdp (ORCPT ); Mon, 7 Mar 2022 22:33:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237662AbiCHDdk (ORCPT ); Mon, 7 Mar 2022 22:33:40 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B1EA9FC0; Mon, 7 Mar 2022 19:32:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=HUmMz6qGSkRqQTVdTZn2JyPBpZ46vr+DcB9VLWAk23Q=; b=hKwOUlA4WO+Ijep6kudjei8/eA 6sPJyFp1FR/1ks4BHuJYWkEzL673JQyW6/APY4ddrynynis7mRWZrml/1yrJp+l2WsZFVN4qfR3i1 C+ctp5PzkMaZmoTwZp+1LQPWHwxHZ1iMC4fkzQ/CkzLL67xNd6bjou8Odgq0llLavXdhRrKYBkQLU OvZU8L9/fpHMEO6ZrUz7asxxK0zi12lqniPTfanOk7QUSzb2Ns3fhsef9b2THH745neSqU0LSxR8o 5XKQnwUaKCA2/Vt1tJRIUh5ei5dXmf9P6UCmun3s5E0PxlbAps+qwJO1lZpPfztbVPRt+db5KgghV C1GFVA+w==; Received: from [2601:1c0:6280:3f0::aa0b] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRQaY-002Xrl-JL; Tue, 08 Mar 2022 03:32:42 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Igor Zhbanov , Laura Abbott , Greg Kroah-Hartman , Jiri Slaby , kgdb-bugreport@lists.sourceforge.net, Jason Wessel , Daniel Thompson , Douglas Anderson , linux-serial@vger.kernel.org Subject: [PATCH] kgdboc: fix return value of __setup handler Date: Mon, 7 Mar 2022 19:32:41 -0800 Message-Id: <20220308033241.22099-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" __setup() handlers should return 1 to indicate that the boot option has been handled. A return of 0 causes the boot option/value to be listed as an Unknown kernel parameter and added to init's (limited) environment strings. So return 1 from kgdboc_option_setup(). Unknown kernel command line parameters "BOOT_IMAGE=3D/boot/bzImage-517rc7 kgdboc=3Dkbd kgdbts=3D", will be passed to user space. Run /sbin/init as init process with arguments: /sbin/init with environment: HOME=3D/ TERM=3Dlinux BOOT_IMAGE=3D/boot/bzImage-517rc7 kgdboc=3Dkbd kgdbts=3D Fixes: 1cd25cbb2fed ("kgdboc: Fix warning with module build") Signed-off-by: Randy Dunlap Reported-by: Igor Zhbanov Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru Cc: Laura Abbott Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: kgdb-bugreport@lists.sourceforge.net Cc: Jason Wessel Cc: Daniel Thompson Cc: Douglas Anderson Cc: linux-serial@vger.kernel.org --- drivers/tty/serial/kgdboc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- lnx-517-rc7.orig/drivers/tty/serial/kgdboc.c +++ lnx-517-rc7/drivers/tty/serial/kgdboc.c @@ -403,16 +403,16 @@ static int kgdboc_option_setup(char *opt { if (!opt) { pr_err("config string not provided\n"); - return -EINVAL; + return 1; } =20 if (strlen(opt) >=3D MAX_CONFIG_LEN) { pr_err("config string too long\n"); - return -ENOSPC; + return 1; } strcpy(config, opt); =20 - return 0; + return 1; } =20 __setup("kgdboc=3D", kgdboc_option_setup);