From nobody Tue Jun 23 11:16:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4737C433FE for ; Mon, 7 Mar 2022 01:34:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234617AbiCGBfP (ORCPT ); Sun, 6 Mar 2022 20:35:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234605AbiCGBfM (ORCPT ); Sun, 6 Mar 2022 20:35:12 -0500 Received: from smtpproxy21.qq.com (smtpbg701.qq.com [203.205.195.86]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F292B1E3C1 for ; Sun, 6 Mar 2022 17:34:16 -0800 (PST) X-QQ-mid: bizesmtp80t1646616832two2455y Received: from localhost.localdomain ( [58.240.82.166]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 07 Mar 2022 09:33:45 +0800 (CST) X-QQ-SSF: 01400000002000B0I000B00A0000000 X-QQ-FEAT: YOzQJqMlvs4f0p3oV5qekI6gjmv0OXoUKubEtLBd7DsMVpP17aR3kyW0ldIiv EaXKoETMz0yDDbOfcuL5ONVBej/MrqqUkMx+snT2lnNT1GNWTWwSWyhbf/bNWDRQUzAnSAz NKfbCl8f5BkJDysjcPDz3z3BaTwO1a7xs7YEreEH3Ai5z3UmH0RfQbe69GaksQGLAUWwPOV ik1a9pnAACPQqSTKaOEm83NtFT4oXcz5s257yfeVncijvF/Zmd32gSR+qGgkdPTVfAuNtSq kot46+3u7HDH5cltLJCII71188gG/zd4Ipl0iGV3+4bDR/dzClfxHdaKeOffRBaM1tKVjUA mxRSKuFsF0Cm4ly+VW0ITr0Anx17w328Ah6ZFNBW8d6Ki24j7g= X-QQ-GoodBg: 2 From: Lianjie Zhang To: Jakub Kicinski Cc: "David S. Miller" , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, zhanglianjie , Jay Vosburgh Subject: [PATCH v2] bonding: helper macro __ATTR_RO to make code more clear Date: Mon, 7 Mar 2022 09:33:33 +0800 Message-Id: <20220307013333.15826-1-zhanglianjie@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: zhanglianjie Delete SLAVE_ATTR macro, use __ATTR_RO replacement, make code logic clearer and unified. Signed-off-by: Lianjie Zhang Reviewed-by: Jay Vosburgh diff --git a/drivers/net/bonding/bond_sysfs_slave.c b/drivers/net/bonding/b= ond_sysfs_slave.c index 6a6cdd0bb258..69b0a3751dff 100644 Acked-by: Jay Vosburgh --- a/drivers/net/bonding/bond_sysfs_slave.c +++ b/drivers/net/bonding/bond_sysfs_slave.c @@ -15,14 +15,8 @@ struct slave_attribute { ssize_t (*show)(struct slave *, char *); }; -#define SLAVE_ATTR(_name, _mode, _show) \ -const struct slave_attribute slave_attr_##_name =3D { \ - .attr =3D {.name =3D __stringify(_name), \ - .mode =3D _mode }, \ - .show =3D _show, \ -}; #define SLAVE_ATTR_RO(_name) \ - SLAVE_ATTR(_name, 0444, _name##_show) +const struct slave_attribute slave_attr_##_name =3D __ATTR_RO(_name) static ssize_t state_show(struct slave *slave, char *buf) { -- 2.20.1