From nobody Tue Jun 23 12:19:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 482D6C433F5 for ; Sat, 5 Mar 2022 12:35:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230382AbiCEMgo (ORCPT ); Sat, 5 Mar 2022 07:36:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbiCEMgm (ORCPT ); Sat, 5 Mar 2022 07:36:42 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14BF73DDE1 for ; Sat, 5 Mar 2022 04:35:52 -0800 (PST) Received: from canpemm500007.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4K9kft1Gv6zBrl9; Sat, 5 Mar 2022 20:33:58 +0800 (CST) Received: from localhost (10.174.179.215) by canpemm500007.china.huawei.com (7.192.104.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sat, 5 Mar 2022 20:35:50 +0800 From: YueHaibing To: , , , , , CC: , , YueHaibing Subject: [PATCH -next] ASoC: amd: acp: signedness bug in acp-renoir Date: Sat, 5 Mar 2022 20:35:19 +0800 Message-ID: <20220305123519.26788-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500007.china.huawei.com (7.192.104.62) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In renoir_audio_probe() platform_get_irq_byname() may return error, but i2s_irq now is unsigned int so the error handling is never triggered. Fixes: 3304a242f45a ("ASoC: amd: Use platform_get_irq_byname() to get the i= nterrupt") Signed-off-by: YueHaibing --- sound/soc/amd/acp/amd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h index 8fd38bf4d3bd..acb50d9fca58 100644 --- a/sound/soc/amd/acp/amd.h +++ b/sound/soc/amd/acp/amd.h @@ -96,7 +96,7 @@ struct acp_dev_data { char *name; struct device *dev; void __iomem *acp_base; - unsigned int i2s_irq; + int i2s_irq; =20 /* SOC specific dais */ struct snd_soc_dai_driver *dai_driver; --=20 2.17.1