From nobody Tue Jun 23 15:08:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 139EAC433EF for ; Thu, 3 Mar 2022 08:02:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230467AbiCCID0 (ORCPT ); Thu, 3 Mar 2022 03:03:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230353AbiCCIDY (ORCPT ); Thu, 3 Mar 2022 03:03:24 -0500 Received: from smtpbgsg1.qq.com (smtpbgsg1.qq.com [54.254.200.92]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DBD6100B for ; Thu, 3 Mar 2022 00:02:32 -0800 (PST) X-QQ-mid: bizesmtp70t1646294533t7gdvkex Received: from localhost.localdomain (unknown [58.240.82.166]) by bizesmtp.qq.com (ESMTP) with id ; Thu, 03 Mar 2022 16:02:07 +0800 (CST) X-QQ-SSF: 01400000002000C0G000000A0000000 X-QQ-FEAT: rn/rQ7Qm5gXNw165vUDyUK9zHAQ88wOFHpozS3Lroq74ASFiOMJS8J86lw9gQ YN9M0Q3sS8X2HFcji9yAWp44+0/tutHqM/dCXxg5jub9IirSt2YbjW2ltxxBzNegyJ0Pyob blyxyDzCRl5ycdVRkTgqe/B4FM6brcPHQVwA/7nGG6LqeLGtJoW3y1X+8k45IKptySPJ2qh FcSMRAdzhAkvl+CPVr1AqSMpUj4bHMhg0hhA3LpPsKsI1gFSw+gL8CmWF7hXusymYGRFCWf oV2JXtvUjrELZuUXEj7L3FoPridtasMBbfgJmOClAoLGCoR4YSZRrXg0Fa4Z1bJt/Zi5nhf Ps/mhlyXWzuTD3O60gI2qZ/OxfArbb5+hHXgKDjVNx7ERElGus= X-QQ-GoodBg: 1 From: Meng Tang To: linus.walleij@linaro.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Meng Tang Subject: [PATCH] pinctrl: berlin: fix error return code of berlin_pinctrl_build_state() Date: Thu, 3 Mar 2022 16:02:06 +0800 Message-Id: <20220303080206.16463-1-tangmeng@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" When krealloc() fails and pctrl->functions is NULL, no error return code of berlin_pinctrl_build_state() is assigned. To fix this bug, ret is assigned with -ENOMEM when pctrl->functions is NULL. Signed-off-by: Meng Tang --- drivers/pinctrl/berlin/berlin.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berli= n.c index b17a03cf87be..a073eedd71aa 100644 --- a/drivers/pinctrl/berlin/berlin.c +++ b/drivers/pinctrl/berlin/berlin.c @@ -233,6 +233,8 @@ static int berlin_pinctrl_build_state(struct platform_d= evice *pdev) pctrl->functions =3D krealloc(pctrl->functions, pctrl->nfunctions * sizeof(*pctrl->functions), GFP_KERNEL); + if (!pctrl->functions) + return -ENOMEM; =20 /* map functions to theirs groups */ for (i =3D 0; i < pctrl->desc->ngroups; i++) { --=20 2.20.1