From nobody Tue Jun 23 15:09:47 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0552DC433EF for ; Thu, 3 Mar 2022 02:24:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231723AbiCCCZW (ORCPT ); Wed, 2 Mar 2022 21:25:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231634AbiCCCZU (ORCPT ); Wed, 2 Mar 2022 21:25:20 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F41D22503; Wed, 2 Mar 2022 18:24:35 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id p9so5526433wra.12; Wed, 02 Mar 2022 18:24:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=bs5ojZXXlLRZXUwC3XJKXaFe2NaCdMkJfCggibvm1pE=; b=jg6O0SzIZvQ0dZtavnIktpzmUozBQixShvJVM1Tj6K+wpAtQ5EK0DJTQyMjBbwV345 kefreXsEKX7onCIiawRPSREjXf/ZFEhxeW1itTQRt9flzXy6Ea08VxuGwfM5XPC7hBey M8WBmKlICVK2wr6G2D32vIb47E58EKZ+pGPnMx8n+QEUkOp3Tu+nk/gSpS7tNXFRNtQy po1UCpox9K93LsPPlD7eyun4WJ/3GCpGnAf9xmOwfuXUo8/pWyuohd+xmAmpECwXMpcH 6e3CkeyNHwyBl2Cc1ep4jobHnQXfRKbRj/vfUnCTo+D4HTlUUVG95K1EhoM2QImvUWWq HxZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bs5ojZXXlLRZXUwC3XJKXaFe2NaCdMkJfCggibvm1pE=; b=r5F4aq40arOjSG8sBAspmlBCjf9MoMRdbo6u4MDIdyCOROt44O5osXXm9Ijce/lpHL Yuz2Y6dvrdbcJjN86BO9x/vx0cO9FEBo1PkT95umtevB+XSqWxfOphWwTO5rxu+wzbQq 1tPFuEiwlHOUNRMHUG8QsZYf0IJeSvaCThSzwfD+U4lUzsK2hH6OxAtA+TXUhQzLVTC9 XvHMjra2iK79NqVyewibmWssMkp19+iufAjel5u608HOa4DjQmtt6hbxCOJQNnBBfVRV ZSy9JwAnVy7E3LEUN9o0fwANCAn4gQBp495XpNX3d1nLzgDOyos7zIu9k5t5M38hGuir 7Ptg== X-Gm-Message-State: AOAM533291S45gGKT67nme9M57HWQIkeyBn5KvjyHa0K90pJ14IdhalQ ZJVSAna0HxtZd03k1Q+8oo8xWQuAqTY86Q== X-Google-Smtp-Source: ABdhPJwbyH4tQeCUC2s0hLlopCdEpRq6dM05TWo/TQpenI+bJUoLyRDH0qdHpgrQ4DqTGI6KLBB0IQ== X-Received: by 2002:a5d:4f03:0:b0:1ed:9eb4:9e45 with SMTP id c3-20020a5d4f03000000b001ed9eb49e45mr24240589wru.464.1646274273857; Wed, 02 Mar 2022 18:24:33 -0800 (PST) Received: from localhost.localdomain ([64.64.123.48]) by smtp.gmail.com with ESMTPSA id f22-20020a1cc916000000b00380d3e49e89sm620979wmb.22.2022.03.02.18.24.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 18:24:33 -0800 (PST) From: Jia-Ju Bai To: hdegoede@redhat.com, markgross@kernel.org Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH v2] platform: x86: huawei-wmi: check the return value of device_create_file() Date: Wed, 2 Mar 2022 18:24:21 -0800 Message-Id: <20220303022421.313-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The function device_create_file() in huawei_wmi_battery_add() can fail, so its return value should be checked. Fixes: 355a070b09ab ("platform/x86: huawei-wmi: Add battery charging thresh= olds") Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- v2: * Fix the code format. Thank Hans for good advice. --- drivers/platform/x86/huawei-wmi.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawe= i-wmi.c index a2d846c4a7ee..eac3e6b4ea11 100644 --- a/drivers/platform/x86/huawei-wmi.c +++ b/drivers/platform/x86/huawei-wmi.c @@ -470,10 +470,17 @@ static DEVICE_ATTR_RW(charge_control_thresholds); =20 static int huawei_wmi_battery_add(struct power_supply *battery) { - device_create_file(&battery->dev, &dev_attr_charge_control_start_threshol= d); - device_create_file(&battery->dev, &dev_attr_charge_control_end_threshold); + int err =3D 0; =20 - return 0; + err =3D device_create_file(&battery->dev, &dev_attr_charge_control_start_= threshold); + if (err) + return err; + + err =3D device_create_file(&battery->dev, &dev_attr_charge_control_end_th= reshold); + if (err) + device_remove_file(&battery->dev, &dev_attr_charge_control_start_thresho= ld); + + return err; } =20 static int huawei_wmi_battery_remove(struct power_supply *battery) --=20 2.17.1