From nobody Tue Jun 23 16:15:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C741FC433EF for ; Wed, 2 Mar 2022 10:40:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241083AbiCBKkx (ORCPT ); Wed, 2 Mar 2022 05:40:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241066AbiCBKkr (ORCPT ); Wed, 2 Mar 2022 05:40:47 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B741BBF504 for ; Wed, 2 Mar 2022 02:40:02 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id p3-20020a17090a680300b001bbfb9d760eso4429900pjj.2 for ; Wed, 02 Mar 2022 02:40:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pq6jKLtGHQsUT6iafR8v8xBWK/Sf/g1/dX36fql3M4I=; b=EVYKZ1nXdOBRMVBEuZ0vUSAHriHHBiRo7e2sw7KOvF3JmJh/+iRWyb0PnKDK/paOUa +QbxooHCgR6BLMR+Qjf5y3owxxUpoKVqK7aev4IjD3vWYIaCBnE4/n1MPjUpqSrHBFca 2PoeBHGJ80zEnH15/eSbjdjsqc7kv2nle7Y4B6STd0/pY5/S+1aii+RjcxEURp6tHOrV XgSnpetupAWNzGAAUuQD4/5+iVPS4Ry470EV75Y60sFn07HUv6ssKcK08wG/zBzxpFzQ 9gAnB0Bk7Ip+S5G6MB2qyx9Bp4L91yqr/YDuHBdY9yNCb39DNB4IpTvqr2BT3epWbGDR Zztw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pq6jKLtGHQsUT6iafR8v8xBWK/Sf/g1/dX36fql3M4I=; b=f5xLrc06a32xSmaxE6JH9hQ3AlS/5uxDIj9fI9oJdAs20goUtuLkGnkW3QLCfLy9Ir XZOlWonQOGlVlaKXJrEhZTzBW7KhEX1fqJxw7caLk1zHF/jgokKMmvy5Q9ZhyE5TaMpy +111nWfcTkbsrS9SxLqJOMSkrB6RhIcAJPaTTiXFvBnOqnb9SMt8qK2e10rmxtAB4WXq qrkONyCETDBlUNGD2ytoo2weJg/JdTYoarwgIopLLtE/flhOMf84ibJxSawZhXMkVTbp eTil3POK0eLAigNOekKZvV9zwLVwnG5UeDYIbtUbCHV40vZCo+k9sGdl/8n6Erb0AQEa Ds1A== X-Gm-Message-State: AOAM531ycVmtZrNmGN8XN+5q4unUcNe8c5Ji33uMfvDtMi2yvnIJb0HL BHXtgTJq8RU9GpHpIkbS/lEBWw== X-Google-Smtp-Source: ABdhPJwQUPKAnnn9iLIXF/B8bDN6A7uOJd4C0X1jTMj3JNqZd4rykY8pvF/ArLHTfHAmPPXS+8ye0A== X-Received: by 2002:a17:902:e943:b0:14f:4a2b:203 with SMTP id b3-20020a170902e94300b0014f4a2b0203mr30121444pll.113.1646217602135; Wed, 02 Mar 2022 02:40:02 -0800 (PST) Received: from localhost.localdomain ([171.50.175.145]) by smtp.gmail.com with ESMTPSA id m20-20020a634c54000000b003739af127c9sm15612308pgl.70.2022.03.02.02.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 02:40:01 -0800 (PST) From: Bhupesh Sharma To: netdev@vger.kernel.org Cc: bhupesh.sharma@linaro.org, bhupesh.linux@gmail.com, vkoul@kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org Subject: [PATCH v2 1/2 net-next] net: stmmac: Add support for SM8150 Date: Wed, 2 Mar 2022 16:09:49 +0530 Message-Id: <20220302103950.30356-2-bhupesh.sharma@linaro.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220302103950.30356-1-bhupesh.sharma@linaro.org> References: <20220302103950.30356-1-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Vinod Koul This adds compatible, POR config & driver data for ethernet controller found in SM8150 SoC. Cc: David S. Miller Signed-off-by: Vinod Koul [bhsharma: Massage the commit log and other cosmetic changes] Signed-off-by: Bhupesh Sharma --- .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 2ffa0a11eea5..8cdba9d521ec 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -183,6 +183,20 @@ static const struct ethqos_emac_driver_data emac_v2_3_= 0_data =3D { .num_por =3D ARRAY_SIZE(emac_v2_3_0_por), }; =20 +static const struct ethqos_emac_por emac_v2_1_0_por[] =3D { + { .offset =3D RGMII_IO_MACRO_CONFIG, .value =3D 0x40C01343 }, + { .offset =3D SDCC_HC_REG_DLL_CONFIG, .value =3D 0x2004642C }, + { .offset =3D SDCC_HC_REG_DDR_CONFIG, .value =3D 0x00000000 }, + { .offset =3D SDCC_HC_REG_DLL_CONFIG2, .value =3D 0x00200000 }, + { .offset =3D SDCC_USR_CTL, .value =3D 0x00010800 }, + { .offset =3D RGMII_IO_MACRO_CONFIG2, .value =3D 0x00002060 }, +}; + +static const struct ethqos_emac_driver_data emac_v2_1_0_data =3D { + .por =3D emac_v2_1_0_por, + .num_por =3D ARRAY_SIZE(emac_v2_1_0_por), +}; + static int ethqos_dll_configure(struct qcom_ethqos *ethqos) { unsigned int val; @@ -558,6 +572,7 @@ static int qcom_ethqos_remove(struct platform_device *p= dev) =20 static const struct of_device_id qcom_ethqos_match[] =3D { { .compatible =3D "qcom,qcs404-ethqos", .data =3D &emac_v2_3_0_data}, + { .compatible =3D "qcom,sm8150-ethqos", .data =3D &emac_v2_1_0_data}, { } }; MODULE_DEVICE_TABLE(of, qcom_ethqos_match); --=20 2.35.1 From nobody Tue Jun 23 16:15:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B03E2C433EF for ; Wed, 2 Mar 2022 10:40:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241092AbiCBKk4 (ORCPT ); Wed, 2 Mar 2022 05:40:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241086AbiCBKkx (ORCPT ); Wed, 2 Mar 2022 05:40:53 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D028BECE9 for ; Wed, 2 Mar 2022 02:40:06 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id s1so1184820plg.12 for ; Wed, 02 Mar 2022 02:40:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3OW6Vzq0apzZ0AvI5XYyUy01zZckjEhZ83VWyjEGv1M=; b=lxb5ga3VT2jhzJzOvy/QTv1oGLd8ZdoJf29WIXqBa7cDDqZcmYiqSfbXwiC+bo484R rvULaR6bCyDxTl6cE1/UB6zyP+N2xmjciFjbkjCJULIfn65SIXDSrAKvaBQ9QEMkbifz yPHGw41EvzJopM+AGQaPMN8FlmR5ewdhu0Kvmu9osMpAaSFV6MgMlIpBspPlHT6gcsE3 2WvBiP5tAdfvKeTRciolbdItL/bblTAqpx6KM561EOy0Mk68z8FiXMRELdsYxRP2tnrZ DHJfYphDZJVFKiDZsoHu0oNP3lCPreoozlXG5QCyPLEmltUXX4xZWaRuL/aXj7gSWi7j B7SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3OW6Vzq0apzZ0AvI5XYyUy01zZckjEhZ83VWyjEGv1M=; b=dkiqgoXwCQY+8JkkOD8UwRbv8wxRJbsaGBle3FnvoaYNN2MD44dGJFsaIbBAF8ReGq HpveIL8W9jF5oouq621P5vvB4wZ7GMfFbkm8le21iuB4hihuTM2vgK0OIS77Im8aMNzK X3o5AK1N9D1njfJbEKMRRQLVZd/0J6H4QF6phQv/tgaZXX1AfCqY1gL8RmCJzQbATbro UtePHqO0pSbMBancOHFAzdceBJtwgCkl6Sm1w5mKD4wTN5J178lfRXXHt5EZN4JeBR5I Y1KBSrLW+qSXEgAGyt0qtfQmlteXgGK5cgGac8BDe4uXKvxMJ4f9lJGvSTRdBqpUu17Y D/2Q== X-Gm-Message-State: AOAM533cLYSbASQcqjHH3yHSous/0HRAOQaMHWMuwllWRqcU9VmyRC3T M2rpQqdzg3WGAceiPj2f3NbD5w== X-Google-Smtp-Source: ABdhPJxBX9zldaofDMQXAyS43Qk+pwolnE7L6eIRQD0Ydlk47m5P4RU24uvzpKq26vhLtsXNxAIS8g== X-Received: by 2002:a17:902:ef52:b0:151:84fe:bccb with SMTP id e18-20020a170902ef5200b0015184febccbmr7215972plx.9.1646217605772; Wed, 02 Mar 2022 02:40:05 -0800 (PST) Received: from localhost.localdomain ([171.50.175.145]) by smtp.gmail.com with ESMTPSA id m20-20020a634c54000000b003739af127c9sm15612308pgl.70.2022.03.02.02.40.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 02:40:05 -0800 (PST) From: Bhupesh Sharma To: netdev@vger.kernel.org Cc: bhupesh.sharma@linaro.org, bhupesh.linux@gmail.com, vkoul@kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org Subject: [PATCH v2 2/2 net-next] net: stmmac: dwmac-qcom-ethqos: Adjust rgmii loopback_en per platform Date: Wed, 2 Mar 2022 16:09:50 +0530 Message-Id: <20220302103950.30356-3-bhupesh.sharma@linaro.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220302103950.30356-1-bhupesh.sharma@linaro.org> References: <20220302103950.30356-1-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Bjorn Andersson Not all platforms should have RGMII_CONFIG_LOOPBACK_EN and the result it about 50% packet loss on incoming messages. So make it possile to configure this per compatible and enable it for QCS404. Cc: David S. Miller Signed-off-by: Bjorn Andersson --- .../stmicro/stmmac/dwmac-qcom-ethqos.c | 22 +++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/driv= ers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 8cdba9d521ec..0cc28c79cc61 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -78,6 +78,7 @@ struct ethqos_emac_por { struct ethqos_emac_driver_data { const struct ethqos_emac_por *por; unsigned int num_por; + bool rgmii_config_looback_en; }; =20 struct qcom_ethqos { @@ -90,6 +91,7 @@ struct qcom_ethqos { =20 const struct ethqos_emac_por *por; unsigned int num_por; + bool rgmii_config_looback_en; }; =20 static int rgmii_readl(struct qcom_ethqos *ethqos, unsigned int offset) @@ -181,6 +183,7 @@ static const struct ethqos_emac_por emac_v2_3_0_por[] = =3D { static const struct ethqos_emac_driver_data emac_v2_3_0_data =3D { .por =3D emac_v2_3_0_por, .num_por =3D ARRAY_SIZE(emac_v2_3_0_por), + .rgmii_config_looback_en =3D true, }; =20 static const struct ethqos_emac_por emac_v2_1_0_por[] =3D { @@ -195,6 +198,7 @@ static const struct ethqos_emac_por emac_v2_1_0_por[] = =3D { static const struct ethqos_emac_driver_data emac_v2_1_0_data =3D { .por =3D emac_v2_1_0_por, .num_por =3D ARRAY_SIZE(emac_v2_1_0_por), + .rgmii_config_looback_en =3D false, }; =20 static int ethqos_dll_configure(struct qcom_ethqos *ethqos) @@ -311,8 +315,12 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos = *ethqos) rgmii_updatel(ethqos, SDCC_DDR_CONFIG_PRG_DLY_EN, SDCC_DDR_CONFIG_PRG_DLY_EN, SDCC_HC_REG_DDR_CONFIG); - rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, - RGMII_CONFIG_LOOPBACK_EN, RGMII_IO_MACRO_CONFIG); + if (ethqos->rgmii_config_looback_en) + rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, + RGMII_CONFIG_LOOPBACK_EN, RGMII_IO_MACRO_CONFIG); + else + rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, + 0, RGMII_IO_MACRO_CONFIG); break; =20 case SPEED_100: @@ -345,8 +353,13 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos = *ethqos) rgmii_updatel(ethqos, SDCC_DDR_CONFIG_EXT_PRG_RCLK_DLY_EN, SDCC_DDR_CONFIG_EXT_PRG_RCLK_DLY_EN, SDCC_HC_REG_DDR_CONFIG); - rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, - RGMII_CONFIG_LOOPBACK_EN, RGMII_IO_MACRO_CONFIG); + if (ethqos->rgmii_config_looback_en) + rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, + RGMII_CONFIG_LOOPBACK_EN, RGMII_IO_MACRO_CONFIG); + else + rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, + 0, RGMII_IO_MACRO_CONFIG); + break; =20 case SPEED_10: @@ -518,6 +531,7 @@ static int qcom_ethqos_probe(struct platform_device *pd= ev) data =3D of_device_get_match_data(&pdev->dev); ethqos->por =3D data->por; ethqos->num_por =3D data->num_por; + ethqos->rgmii_config_looback_en =3D data->rgmii_config_looback_en; =20 ethqos->rgmii_clk =3D devm_clk_get(&pdev->dev, "rgmii"); if (IS_ERR(ethqos->rgmii_clk)) { --=20 2.35.1