From nobody Tue Jun 23 16:13:06 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11DC2C433EF for ; Wed, 2 Mar 2022 03:37:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239375AbiCBDif (ORCPT ); Tue, 1 Mar 2022 22:38:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229911AbiCBDi3 (ORCPT ); Tue, 1 Mar 2022 22:38:29 -0500 Received: from smtpbg152.qq.com (smtpbg152.qq.com [13.245.186.79]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CCC5201B6 for ; Tue, 1 Mar 2022 19:37:44 -0800 (PST) X-QQ-mid: bizesmtp65t1646192242t89gbo78 Received: from localhost.localdomain ( [58.240.82.166]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 02 Mar 2022 11:37:18 +0800 (CST) X-QQ-SSF: 0140000000200060D000B00A0000000 X-QQ-FEAT: dpyQmELDBxF9Prl52JgMRPjgodJe3WWVa84v1DaukhPHZqksTih2wpOdExClV +7SFqNDhjW+FqQE5TPGdcnfwpkQDCWwVA5g6iS1mS1yOOzzImVFQqRCF8bApQXJnOX1/jpN 3xgpc2ogtaCj1Pxnd7a2fNjF0jv1OYicRF+iNmaDMUqnbSTnmBQIabJsSMVPcQsvPawY7Ut XG8+DJkPyI73KXoIiWlozIdvvYkuB+D2H+PFoHCYYtfM1X8dWYZpdmCvXkIgnZpTUmU8OrX TRsNWUqzPg/+G8oCSLJuQjoBwNq4TfE7DtD+EkA74KTT6bNoOn+jETXbv4RNxYJXQzJciIn DW/3rBxedTmCBWIedM= X-QQ-GoodBg: 2 From: Zhen Ni To: ok@artecdesign.ee, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Zhen Ni Subject: [PATCH] USB: host: isp116x: check return value after calling platform_get_resource() Date: Wed, 2 Mar 2022 11:37:16 +0800 Message-Id: <20220302033716.31272-1-nizhen@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Zhen Ni --- drivers/usb/host/isp116x-hcd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c index 8835f6bd528e..8c7f0991c21b 100644 --- a/drivers/usb/host/isp116x-hcd.c +++ b/drivers/usb/host/isp116x-hcd.c @@ -1541,10 +1541,12 @@ static int isp116x_remove(struct platform_device *p= dev) =20 iounmap(isp116x->data_reg); res =3D platform_get_resource(pdev, IORESOURCE_MEM, 1); - release_mem_region(res->start, 2); + if (res) + release_mem_region(res->start, 2); iounmap(isp116x->addr_reg); res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - release_mem_region(res->start, 2); + if (res) + release_mem_region(res->start, 2); =20 usb_put_hcd(hcd); return 0; --=20 2.20.1