From nobody Tue Jun 23 17:15:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6162C433EF for ; Tue, 1 Mar 2022 18:56:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237127AbiCAS5L (ORCPT ); Tue, 1 Mar 2022 13:57:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237104AbiCAS5J (ORCPT ); Tue, 1 Mar 2022 13:57:09 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05FDE60CDB for ; Tue, 1 Mar 2022 10:56:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8D0C7B81CB0 for ; Tue, 1 Mar 2022 18:56:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFFE8C340EE; Tue, 1 Mar 2022 18:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646160985; bh=usfHRRJQxk5ZPBBjY5lM+QOMJJruSA25LZ2RYqAjsk8=; h=From:To:Cc:Subject:Date:From; b=boS0m3SGvvVYdSDPMbk2vmPxKby2L4qP2A0CRlh1JLasCXH718Gwc5zuNqHnFHDDo 1bS2HQCfW730Eb+VPYoyxy7qyvC0X4GRiFaOTQiRRcwzEnto9FfSjh8juc7OiGgVWa 7kCGiW0awUpro2719e0IwyMHrcZDNvpDf2PCYtkGX8RIYBeLD4rYxYmYOo5LCJcztA 6Dc+k0R8Jhd0M5cN49XzxpxULfU/yV76oE8PlIKTpI4uxs+MS+vyLv2pLZinng0u12 9ZoVseoreMsjOmJZXMzMLgWxjewxjnyfBXMDH0DTSdkA4bV/FKZPfrw37po1BURHgz Zaw4XH5rzM/1g== From: SeongJae Park To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, SeongJae Park Subject: [PATCH for-mm] mm/damon/sysfs: Fix out-of-bound array access for wmark_metric_strs[] Date: Tue, 1 Mar 2022 18:56:19 +0000 Message-Id: <20220301185619.2904-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Commit 7a8630be880e ("mm/damon/sysfs: support DAMOS watermarks") on -mm tree which introduced by a patch[1] titled mm-damon-sysfs-support-damos-watermarks.patch allows out-of-bound access to damon_sysfs_wmark_metric_strs[] array due to wrong bound check. This commit fixes the wrong bound check. The issue has found by Coverity report for linux-next. [1] https://www.ozlabs.org/~akpm/mmotm/broken-out/mm-damon-sysfs-support-da= mos-watermarks.patch Addresses-Coverity: ("Out-of-bounds read") Fixes: 7a8630be880e ("mm/damon/sysfs: support DAMOS watermarks") Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 32a9d21c0db5..fda2506c676f 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -266,7 +266,7 @@ static ssize_t metric_store(struct kobject *kobj, struc= t kobj_attribute *attr, struct damon_sysfs_watermarks, kobj); enum damos_wmark_metric metric; =20 - for (metric =3D 0; metric <=3D NR_DAMOS_WMARK_METRICS; metric++) { + for (metric =3D 0; metric < NR_DAMOS_WMARK_METRICS; metric++) { if (sysfs_streq(buf, damon_sysfs_wmark_metric_strs[metric])) { watermarks->metric =3D metric; return count; --=20 2.17.1