From nobody Tue Jun 23 19:26:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96AF6C433EF for ; Mon, 28 Feb 2022 14:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237249AbiB1Ond (ORCPT ); Mon, 28 Feb 2022 09:43:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232032AbiB1On3 (ORCPT ); Mon, 28 Feb 2022 09:43:29 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DB1E2716E for ; Mon, 28 Feb 2022 06:42:48 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id d28so15844362wra.4 for ; Mon, 28 Feb 2022 06:42:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JeiJd2ZgJiYLQDAoicuBe5LbDBJMIUmRRu8Fz2FFrrY=; b=AWcnUSmR1nyOrs2af4OP9NZKhiPk9OK4hwjMbjIt+eWRCmyQ8LFIHpf+qFIcrnUUgb BCqlu/ThO7XS664ZJQqdOdiWx6EaTa8eGO6YHM8Cqqjk/dskiZ+AlQVfQiudj9bXnlif czcfbv9E1xGuT3vFGipmbSGOCttiqC+u6Xdnl9wPHTz7uSbyqDpFcmmrGPrVRi6WX+qN 4d8CGrhAzQQjE94pzgtFObmlx3wE3OkuyKFacs8oFzMBCjrvB6jafvnes1oOpiDXAzRh 1+si/nRLnsttkoXCmb1j4fntKSYHq4pcHs4l2C2lPy7E5uxQgYUEkBOMx/gWrnOGYPok homw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JeiJd2ZgJiYLQDAoicuBe5LbDBJMIUmRRu8Fz2FFrrY=; b=QOhOSZWrgNpwaYiOHaeHBwy2kUvGZHm3gCeJm7q/EQeWKdypxNIrIuFosxwZBN0oDV eD4XOVR7AF750y0sK3MTvHYjzGiBxaqSKxXkOwT1DvC32Gqtdm8dCvO7Z5VIUAVOTwFv pl/uUsonvlmb7XKGj9D0387O5TalnaDDeGoSiKPCJyBcMfLG0/GWY368lTaX13AvHqip TZITd0ehTOJ2LAe8s5YK3zk49cDB/lPaIgHmX9rFLif4FTBx6KONGQ/AKxA0+10wC2Dc ADBvL67VK0oQ2kYwL+ljV1vGyAtTWRl+IRXCsPCm5c6F81BMEl2LjXIvrir2LqQJy76j zMZg== X-Gm-Message-State: AOAM531q15b8h7roPt5XeQ5vET8biU7q8K9VgpurQtWm2ZhBUvDf0hb3 Zwne5jFDtVu3n0XBdXwI45JOkA== X-Google-Smtp-Source: ABdhPJwiNyvayuILk4HidnUJ6aXnqMYeqhE/TX7K/qv04vfoCVYAD3RUQk2OEsWQ6V2SrGv27K2iOg== X-Received: by 2002:adf:eb81:0:b0:1e3:2bf5:132 with SMTP id t1-20020adfeb81000000b001e32bf50132mr16412204wrn.246.1646059367227; Mon, 28 Feb 2022 06:42:47 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id c12-20020a05600c0a4c00b00381141f4967sm14643724wmq.35.2022.02.28.06.42.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 06:42:46 -0800 (PST) From: Srinivas Kandagatla To: broonie@kernel.org Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, quic_srivasam@quicinc.com, Srinivas Kandagatla Subject: [PATCH v4] ASoC: codecs: wsa881x: add runtime pm support Date: Mon, 28 Feb 2022 14:42:35 +0000 Message-Id: <20220228144235.24208-1-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" WSA SoundWire Controller does not support Clock stop and performs a soft re= set on suspend resume path. Its recommended that WSA881x codecs connected to t= his are also reset using a hard reset during suspend resume. So this codec driver performs a hard reset during suspend resume cycle. Signed-off-by: Srinivas Kandagatla --- Changes since v3: - added missing sign off. - no code changes sound/soc/codecs/wsa881x.c | 53 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c index 0222370ff95d..616b26c70c3b 100644 --- a/sound/soc/codecs/wsa881x.c +++ b/sound/soc/codecs/wsa881x.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -198,6 +199,7 @@ #define WSA881X_OCP_CTL_TIMER_SEC 2 #define WSA881X_OCP_CTL_TEMP_CELSIUS 25 #define WSA881X_OCP_CTL_POLL_TIMER_SEC 60 +#define WSA881X_PROBE_TIMEOUT 1000 =20 #define WSA881X_PA_GAIN_TLV(xname, reg, shift, max, invert, tlv_array) \ { .iface =3D SNDRV_CTL_ELEM_IFACE_MIXER, .name =3D xname, \ @@ -747,6 +749,12 @@ static int wsa881x_put_pa_gain(struct snd_kcontrol *kc, unsigned int mask =3D (1 << fls(max)) - 1; int val, ret, min_gain, max_gain; =20 + ret =3D pm_runtime_get_sync(comp->dev); + if (ret < 0 && ret !=3D -EACCES) { + pm_runtime_put_noidle(comp->dev); + return ret; + } + max_gain =3D (max - ucontrol->value.integer.value[0]) & mask; /* * Gain has to set incrementally in 4 steps @@ -773,6 +781,9 @@ static int wsa881x_put_pa_gain(struct snd_kcontrol *kc, usleep_range(1000, 1010); } =20 + pm_runtime_mark_last_busy(comp->dev); + pm_runtime_put_autosuspend(comp->dev); + return 1; } =20 @@ -1101,6 +1112,7 @@ static int wsa881x_probe(struct sdw_slave *pdev, const struct sdw_device_id *id) { struct wsa881x_priv *wsa881x; + struct device *dev =3D &pdev->dev; =20 wsa881x =3D devm_kzalloc(&pdev->dev, sizeof(*wsa881x), GFP_KERNEL); if (!wsa881x) @@ -1132,12 +1144,52 @@ static int wsa881x_probe(struct sdw_slave *pdev, return PTR_ERR(wsa881x->regmap); } =20 + pm_runtime_set_autosuspend_delay(dev, 3000); + pm_runtime_use_autosuspend(dev); + pm_runtime_mark_last_busy(dev); + pm_runtime_set_active(dev); + pm_runtime_enable(dev); + return devm_snd_soc_register_component(&pdev->dev, &wsa881x_component_drv, wsa881x_dais, ARRAY_SIZE(wsa881x_dais)); } =20 +static int __maybe_unused wsa881x_runtime_suspend(struct device *dev) +{ + struct regmap *regmap =3D dev_get_regmap(dev, NULL); + struct wsa881x_priv *wsa881x =3D dev_get_drvdata(dev); + + gpiod_direction_output(wsa881x->sd_n, 0); + + regcache_cache_only(regmap, true); + regcache_mark_dirty(regmap); + + return 0; +} + +static int __maybe_unused wsa881x_runtime_resume(struct device *dev) +{ + struct sdw_slave *slave =3D dev_to_sdw_dev(dev); + struct regmap *regmap =3D dev_get_regmap(dev, NULL); + struct wsa881x_priv *wsa881x =3D dev_get_drvdata(dev); + + gpiod_direction_output(wsa881x->sd_n, 1); + + wait_for_completion_timeout(&slave->initialization_complete, + msecs_to_jiffies(WSA881X_PROBE_TIMEOUT)); + + regcache_cache_only(regmap, false); + regcache_sync(regmap); + + return 0; +} + +static const struct dev_pm_ops wsa881x_pm_ops =3D { + SET_RUNTIME_PM_OPS(wsa881x_runtime_suspend, wsa881x_runtime_resume, NULL) +}; + static const struct sdw_device_id wsa881x_slave_id[] =3D { SDW_SLAVE_ENTRY(0x0217, 0x2010, 0), SDW_SLAVE_ENTRY(0x0217, 0x2110, 0), @@ -1151,6 +1203,7 @@ static struct sdw_driver wsa881x_codec_driver =3D { .id_table =3D wsa881x_slave_id, .driver =3D { .name =3D "wsa881x-codec", + .pm =3D &wsa881x_pm_ops, } }; module_sdw_driver(wsa881x_codec_driver); --=20 2.21.0