From nobody Sun Sep 22 07:40:47 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1841DC433F5 for ; Sun, 27 Feb 2022 16:44:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231162AbiB0Qoq (ORCPT ); Sun, 27 Feb 2022 11:44:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbiB0Qom (ORCPT ); Sun, 27 Feb 2022 11:44:42 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2C18F47547 for ; Sun, 27 Feb 2022 08:44:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645980245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=V5Y+mhXtEe4aHWk4DE77nNDoAlUo3znM4yBU3KLbx5o=; b=eP1VBEZMM7wqkOeIyEnAI3tkXeahQcm4pMy0qnEdE+DOGduH/SUMQ/kZ2EAv1pDjBnEhno qVqyOxzPxUKDPTvNNe6scCzLMTexPF3ACSwsqHsf7hwZMX3vKlz/eiMMUZU/MkNt0lvBM6 2eVPWSYeHPQy3CEKzsdKV/Q9TCm+xiY= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-255-n-G5qifHOOCRzOnGdgXBig-1; Sun, 27 Feb 2022 11:44:04 -0500 X-MC-Unique: n-G5qifHOOCRzOnGdgXBig-1 Received: by mail-qk1-f200.google.com with SMTP id s71-20020a37a94a000000b00648c7f2b289so9505988qke.12 for ; Sun, 27 Feb 2022 08:44:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=V5Y+mhXtEe4aHWk4DE77nNDoAlUo3znM4yBU3KLbx5o=; b=tZvNWC/PJqwG/yvsWwFzkTs/a7zDMiMzk05O16bTlnDS+3x6H2vd1YjZs2++sp5+B+ qKPHaij90hZzjjhpovbbxiIcUucwUff0zRI9NfQudpwj1BdCx6mNltu7EgE4NoNDV4/9 kNbE2A71hkbzefScbQo8UxYQ7RgiJvwtZpC9LoMKopCgzZwtv7B4n1YdKWZWTrp4Hslf wWjwr6HZujVhDUycMVYgqlO3tGu2aRgEd2AimQGsxhA8v9CA6JRao50e1A0tqbPq+sKF jr3brnVbsLCH/kZMLjv0j0l2oFYmQTyVKUFhQfKMBlDyVJWjrkMHpZtNIzdH5qsv19Pk cC/w== X-Gm-Message-State: AOAM530uMkpse5Md4pJ3xLDkFQQn15nzTxFAyye2BIrOelOgMJvTzUAM RTK+zOSteIMTBJgJRBMKf/WmdzIU1Ql4aTzpQ18NdOHa0SFkvdDgaC+EUnl4XM9GkdbnlJvp9MT dqeq9CNtNTMHXNa5DlssUHFql X-Received: by 2002:a05:620a:1fc:b0:60d:d438:d628 with SMTP id x28-20020a05620a01fc00b0060dd438d628mr9489732qkn.388.1645980242782; Sun, 27 Feb 2022 08:44:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJxmEEmzM5eDcwZIwdUdPIYKMl5r3tEeMsKZSwUZGmeUMBHmHQtSkJ2w3iQrxB7UtVNBvR5apQ== X-Received: by 2002:a05:620a:1fc:b0:60d:d438:d628 with SMTP id x28-20020a05620a01fc00b0060dd438d628mr9489721qkn.388.1645980242555; Sun, 27 Feb 2022 08:44:02 -0800 (PST) Received: from localhost.localdomain.com (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id w140-20020a376292000000b00648e88c1f05sm4010675qkb.67.2022.02.27.08.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Feb 2022 08:44:02 -0800 (PST) From: trix@redhat.com To: jic23@kernel.org, lars@metafoo.de, matthias.bgg@gmail.com, nathan@kernel.org, ndesaulniers@google.com, linus.walleij@linaro.org, ardeleanalex@gmail.com Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] iio: adc: mt6360: strengthen return check of mt6360_adc_read_channel Date: Sun, 27 Feb 2022 08:43:57 -0800 Message-Id: <20220227164357.84742-1-trix@redhat.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Tom Rix Clang static analysis reports this issue mt6360-adc.c:277:20: warning: Assigned value is garbage or undefined data.values[i++] =3D val; ^ ~~~ val is set by a successful call to m6360_adc_read_channel(). A negative return is checked but within m6360_adc_read_channel, a non zero check is done. Strengthen the check to non zero. Signed-off-by: Tom Rix --- drivers/iio/adc/mt6360-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/mt6360-adc.c b/drivers/iio/adc/mt6360-adc.c index 07c0e67683910..9fb6dc305a392 100644 --- a/drivers/iio/adc/mt6360-adc.c +++ b/drivers/iio/adc/mt6360-adc.c @@ -269,7 +269,7 @@ static irqreturn_t mt6360_adc_trigger_handler(int irq, = void *p) memset(&data, 0, sizeof(data)); for_each_set_bit(bit, indio_dev->active_scan_mask, indio_dev->masklength)= { ret =3D mt6360_adc_read_channel(mad, bit, &val); - if (ret < 0) { + if (ret) { dev_warn(&indio_dev->dev, "Failed to get channel %d conversion val\n", = bit); goto out; } --=20 2.26.3