From nobody Tue Jun 23 21:33:27 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE1FC433F5 for ; Fri, 25 Feb 2022 17:58:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231284AbiBYR7W (ORCPT ); Fri, 25 Feb 2022 12:59:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231163AbiBYR7S (ORCPT ); Fri, 25 Feb 2022 12:59:18 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31D321BBF59 for ; Fri, 25 Feb 2022 09:58:45 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id p9so5635429wra.12 for ; Fri, 25 Feb 2022 09:58:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8KdJ2FuMgAyAwbLGKNB+M/QY0Fvh3jw6kKr9Fyh7jJI=; b=wGTTgtTOINGcGh8LMGUGXuLE7Cs/hN6BmzVHFaZV9hj0zLjF0GlvJN2OK2CXRrUqqh AQF4Nf5r3TY2W/UTjlVKLWWcZI/1wXMvHSo8flb8j3GdFDDB4YB8o594pmwKFptLkbN1 0h5FQDnsEwRfsEGzYvnKRlmkeerXly02XTXqe24BQHdmScu5aAWJ8CtnKw2JasgU9/lE 4R81WMNVOY0VtxbQ3jPxocwCu4vcriE17Fr9J7UYkj2COKtlJJy4MrZj3c6qWCOiVwmp ZGlezW5B2uyUoKZQaBvXHhU/15STqsQjQMuN3hx4jsvtEPw0neSfwYW3y0Xr1F939xC7 JBCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8KdJ2FuMgAyAwbLGKNB+M/QY0Fvh3jw6kKr9Fyh7jJI=; b=X29HXcL2MjSkgn8hEKljzvfHtah1bjNX8yiyOTZNuUpzkD6yEet7Nz7mqP2LL+e1a7 gh9/7ifdHwHyz7JQ4rQ5AF144HkJOf/jGY/8G60ZaaQHsvAQ3dmMAQJ5/nlituVMOSDg FAbkQzMbqEnonl2qdIDCkFckzDpK+BwBWfRnkm7XehG0WCh74RsJQ5kE4FWp3oOPUjlO FogO4vFUvdLL20rKoJCBG8zU9ceKD375zRGUYMukf9zZxvD64HOG8WzK5jspksSDZOVS e0UQwaBJeNJQL3dlw/ZvQbB3I4NZel88lxwkttyr8nPrvEuXJVnlGibfQEB2euKpzpw3 w4bg== X-Gm-Message-State: AOAM533VZlqAKNdsQs6NxgRPkTBFnlAQefmwQe7u/wg1lY/kZmoV8jVl nzyXLhVBK5QvxbjCfx5FKXpzWw== X-Google-Smtp-Source: ABdhPJxRAraWWrduA8zR6qPJ1E7eeRNDlYWCml7+zaSHqDg+lA5TJCnmOcQpcE31Zv39OZ8W6Fuvjw== X-Received: by 2002:a5d:64ec:0:b0:1e6:8d72:b8af with SMTP id g12-20020a5d64ec000000b001e68d72b8afmr7087179wri.165.1645811923796; Fri, 25 Feb 2022 09:58:43 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id t8-20020a05600c2f8800b00381428ad88dsm74172wmn.15.2022.02.25.09.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 09:58:43 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Vincent Shih , Rob Herring , Srinivas Kandagatla Subject: [PATCH 1/4] nvmem: dt-bindings: Fix the error of dt-bindings check Date: Fri, 25 Feb 2022 17:58:19 +0000 Message-Id: <20220225175822.8293-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220225175822.8293-1-srinivas.kandagatla@linaro.org> References: <20220225175822.8293-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Vincent Shih 1. Remove the unnecessary header file for dt-binding check 2. Replace OTPRX with 0x15 since it is not defined here. 3. Modify the name of the node of the clock driver. Fixes: 8fb29b450182 ("dt-bindings: nvmem: Add bindings doc for Sunplus OCOT= P driver") Reported-by: Rob Herring Signed-off-by: Vincent Shih Signed-off-by: Srinivas Kandagatla --- .../devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.y= aml b/Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml index 4b28f37dfb67..a7644ebbc2ca 100644 --- a/Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml +++ b/Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml @@ -60,13 +60,11 @@ unevaluatedProperties: false =20 examples: - | - #include - otp: otp@9c00af00 { compatible =3D "sunplus,sp7021-ocotp"; reg =3D <0x9c00af00 0x34>, <0x9c00af80 0x58>; reg-names =3D "hb_gpio", "otprx"; - clocks =3D <&clks OTPRX>; + clocks =3D <&clkc 0x15>; =20 #address-cells =3D <1>; #size-cells =3D <1>; --=20 2.21.0 From nobody Tue Jun 23 21:33:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C06CDC433EF for ; Fri, 25 Feb 2022 17:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231364AbiBYR7Y (ORCPT ); Fri, 25 Feb 2022 12:59:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231178AbiBYR7T (ORCPT ); Fri, 25 Feb 2022 12:59:19 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DB311BBF5C for ; Fri, 25 Feb 2022 09:58:46 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id d14-20020a05600c34ce00b0037bf4d14dc7so2153314wmq.3 for ; Fri, 25 Feb 2022 09:58:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4aleIewlwKJ1poVk10Jw8E3A1niTjHR1aIKsYOteRaE=; b=PfUwWn5+6UEKSBSJSnsKTXOfu7BCeNBeueveB86gaDf3xbEpm69XTzGBRnofGXBwre HfMbIx+KQkntMerVVbNP1xCc/nbhMA3wF8NJaWh/ijDRx+nfAThKRJSckHaPHHO9u1hf gRUVQ2i8dIZowl0zS/lW5/5A6Evr51RJAWJFywF5oqFV3xlmdkZgjjq8YL0PRmjlhq31 dapWDAtrhqjNiTDB1DHVqtwuXYNcZHfF9h4TsNImsLDwaLgorOk+hSsC5iTWdxMRBYFR plpaja9XzoR1ydBgfDhzUTO3qWxdnhkvANPh9vdS2YiTHUjfnxRKHgMdeNNB357R1VhZ wQ+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4aleIewlwKJ1poVk10Jw8E3A1niTjHR1aIKsYOteRaE=; b=u4ru1X8Kug8RtMCAeFJs2agzk9yJCjtfq6uY7bNZjG++s2dcrxKTx3uxwdUNif/8By rVVzbp7quQ4GIFBfDGUDYj0XSu9z73v+x/1fionjQwObEXNMTM/U1vea+Corj9I0oBhX Pwz9xXRSzYPNaI4fA9hOMzXH7X2t3tWWT5ZogqGq0gTJ4s5sQtCDBtsLADkXS9IedA2k 0C5EF8CQZRJMR6VzqCy7fHJcrvetRrrF+Ya5pgvWUE53LH2tQUKwxZCYW7U5DFcnw8Ad Zzh0vuaHxHRYuJrWcoWuUPcnraV2ZXT/5L8ACmcSVUF8wNF3KkM0DGdr5wp9r/cHtwbi 9OQA== X-Gm-Message-State: AOAM532nvFjWQsWG78gqnAQNmzd1MZR4cEg9rMkUEGisacA17bUd8/L0 t1ItsBcg3cglYk0rWux3S6M0Qw== X-Google-Smtp-Source: ABdhPJwED8ZFQcWOXXVX/CYMkODNcBl04QDeIURlCgk/IzGxCDkxnhvhyZQhp//vtJjoPUq6aGUOxg== X-Received: by 2002:a05:600c:4182:b0:381:42:ac91 with SMTP id p2-20020a05600c418200b003810042ac91mr3710003wmh.116.1645811924887; Fri, 25 Feb 2022 09:58:44 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id t8-20020a05600c2f8800b00381428ad88dsm74172wmn.15.2022.02.25.09.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 09:58:44 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Srinivas Kandagatla Subject: [PATCH 2/4] nvmem: brcm_nvram: parse NVRAM content into NVMEM cells Date: Fri, 25 Feb 2022 17:58:20 +0000 Message-Id: <20220225175822.8293-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220225175822.8293-1-srinivas.kandagatla@linaro.org> References: <20220225175822.8293-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rafa=C5=82 Mi=C5=82ecki NVRAM consist of header and NUL separated key-value pairs. Parse it and create NVMEM cell for every key-value entry. Signed-off-by: Rafa=C5=82 Mi=C5=82ecki Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/brcm_nvram.c | 90 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 90 insertions(+) diff --git a/drivers/nvmem/brcm_nvram.c b/drivers/nvmem/brcm_nvram.c index bd2ecaaf4585..439f00b9eef6 100644 --- a/drivers/nvmem/brcm_nvram.c +++ b/drivers/nvmem/brcm_nvram.c @@ -6,12 +6,26 @@ #include #include #include +#include #include #include +#include + +#define NVRAM_MAGIC "FLSH" =20 struct brcm_nvram { struct device *dev; void __iomem *base; + struct nvmem_cell_info *cells; + int ncells; +}; + +struct brcm_nvram_header { + char magic[4]; + __le32 len; + __le32 crc_ver_init; /* 0:7 crc, 8:15 ver, 16:31 sdram_init */ + __le32 config_refresh; /* 0:15 sdram_config, 16:31 sdram_refresh */ + __le32 config_ncdl; /* ncdl values for memc */ }; =20 static int brcm_nvram_read(void *context, unsigned int offset, void *val, @@ -26,6 +40,75 @@ static int brcm_nvram_read(void *context, unsigned int o= ffset, void *val, return 0; } =20 +static int brcm_nvram_add_cells(struct brcm_nvram *priv, uint8_t *data, + size_t len) +{ + struct device *dev =3D priv->dev; + char *var, *value, *eq; + int idx; + + priv->ncells =3D 0; + for (var =3D data + sizeof(struct brcm_nvram_header); + var < (char *)data + len && *var; + var +=3D strlen(var) + 1) { + priv->ncells++; + } + + priv->cells =3D devm_kcalloc(dev, priv->ncells, sizeof(*priv->cells), GFP= _KERNEL); + if (!priv->cells) + return -ENOMEM; + + for (var =3D data + sizeof(struct brcm_nvram_header), idx =3D 0; + var < (char *)data + len && *var; + var =3D value + strlen(value) + 1, idx++) { + eq =3D strchr(var, '=3D'); + if (!eq) + break; + *eq =3D '\0'; + value =3D eq + 1; + + priv->cells[idx].name =3D devm_kstrdup(dev, var, GFP_KERNEL); + if (!priv->cells[idx].name) + return -ENOMEM; + priv->cells[idx].offset =3D value - (char *)data; + priv->cells[idx].bytes =3D strlen(value); + } + + return 0; +} + +static int brcm_nvram_parse(struct brcm_nvram *priv) +{ + struct device *dev =3D priv->dev; + struct brcm_nvram_header header; + uint8_t *data; + size_t len; + int err; + + memcpy_fromio(&header, priv->base, sizeof(header)); + + if (memcmp(header.magic, NVRAM_MAGIC, 4)) { + dev_err(dev, "Invalid NVRAM magic\n"); + return -EINVAL; + } + + len =3D le32_to_cpu(header.len); + + data =3D kcalloc(1, len, GFP_KERNEL); + memcpy_fromio(data, priv->base, len); + data[len - 1] =3D '\0'; + + err =3D brcm_nvram_add_cells(priv, data, len); + if (err) { + dev_err(dev, "Failed to add cells: %d\n", err); + return err; + } + + kfree(data); + + return 0; +} + static int brcm_nvram_probe(struct platform_device *pdev) { struct nvmem_config config =3D { @@ -35,6 +118,7 @@ static int brcm_nvram_probe(struct platform_device *pdev) struct device *dev =3D &pdev->dev; struct resource *res; struct brcm_nvram *priv; + int err; =20 priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -46,7 +130,13 @@ static int brcm_nvram_probe(struct platform_device *pde= v) if (IS_ERR(priv->base)) return PTR_ERR(priv->base); =20 + err =3D brcm_nvram_parse(priv); + if (err) + return err; + config.dev =3D dev; + config.cells =3D priv->cells; + config.ncells =3D priv->ncells; config.priv =3D priv; config.size =3D resource_size(res); =20 --=20 2.21.0 From nobody Tue Jun 23 21:33:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D1BEC433F5 for ; Fri, 25 Feb 2022 17:59:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231401AbiBYR7c (ORCPT ); Fri, 25 Feb 2022 12:59:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231343AbiBYR7W (ORCPT ); Fri, 25 Feb 2022 12:59:22 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43C621BBF59 for ; Fri, 25 Feb 2022 09:58:47 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id i20so2102315wmc.3 for ; Fri, 25 Feb 2022 09:58:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6PhrHGYYFJ/UoeUEyqMP9QMPkUrRP2Euua3cF1w3ntw=; b=BDUQ8FIxHFgti+MjvYVkimqQFihWbMv8hkX5vShAr3ByrKFCPsispbHu56Km7TC7zg lqToITqG53PSSV9hqTlMEECIUN9IvlrX5CffWUbJZGNJOQhluKyN8TZ0hen40eMSwTrg nuJv3Owpa1PqP5NiDNlqyeKV+MsoLDj6z5K9NBOYiCXMxOEsnUH5/OiaJXLzOVy4XdaO M0ZioN8pSieFxDcKzay71rgyFLIWpkwR7Vzjdeqy0NfVUj+HEwa2KNCbz4uLg9w3XXFJ Sgckx8/Z+RjY122yJAHlNSNTQZpmEMQw/BnC59ilWKJj+fTPzS8+Rk/EDB7QJZWRccB9 POWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6PhrHGYYFJ/UoeUEyqMP9QMPkUrRP2Euua3cF1w3ntw=; b=hu5bhCk2jnbFESagPcAk74Rz46UcwJTSPRHuJQHNyHWp5TMT2qaGD+k5dwRMfZ28N/ Go7nptiqBE3/i+yj+9WI7yz0Nw/K/1ThK2ODn93/uGlRkD+i8d9p94FuPLKAY1tQr3Iy 7mh5X+S4gE6gmPzM7ovAvdrvQe1ZMMTGAcnUfLM+kLN6JTJgDm4ZhJhcRtpG6DclwRPG DeaP9E/krPk4Sor+Ha5lVOiVfnQydlJvB4YPw1zV/q9y8Xm3KzllrBd0KsldnOrHGgSa Iwyl5y/GGocEK11XUv1nzKy7Q2PDCFVodGQToHYJhhTKqhgYk5tfgIZjXV6FIDGn94DZ CYfA== X-Gm-Message-State: AOAM531ajboe8COtWI0UbQXYv8KoXptq8iyBGT0ucS33ry796TX6OEJ2 KOLxCjam/LglLBirbkvWA7eYkg== X-Google-Smtp-Source: ABdhPJz91dir81i2Q6xpDKe7kVh3AkArh/GAdjPZQaOye4o0PqbuI71IPDfVpIODqAxzRxKmp0N3Jw== X-Received: by 2002:a05:600c:2c46:b0:37b:c653:37a3 with SMTP id r6-20020a05600c2c4600b0037bc65337a3mr3738608wmg.65.1645811925881; Fri, 25 Feb 2022 09:58:45 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id t8-20020a05600c2f8800b00381428ad88dsm74172wmn.15.2022.02.25.09.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 09:58:45 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Rob Herring , Srinivas Kandagatla Subject: [PATCH 3/4] dt-bindings: nvmem: make "reg" property optional Date: Fri, 25 Feb 2022 17:58:21 +0000 Message-Id: <20220225175822.8293-4-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220225175822.8293-1-srinivas.kandagatla@linaro.org> References: <20220225175822.8293-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rafa=C5=82 Mi=C5=82ecki Most NVMEM providers have cells at hardcoded addresses however there are some exceptions. Some devices store cells layout in internal structs using custom formats. It's important to allow NVMEM consumers to still reference such NVMEM cells. Making "reg" optional allows defining NVMEM cells by their names only and using them with phandles. Signed-off-by: Rafa=C5=82 Mi=C5=82ecki Reviewed-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/nvmem/nvmem.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documenta= tion/devicetree/bindings/nvmem/nvmem.yaml index 43ed7e32e5ac..3bb349c634cb 100644 --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml @@ -60,9 +60,6 @@ patternProperties: description: Size in bit within the address range specified by reg. =20 - required: - - reg - additionalProperties: true =20 examples: --=20 2.21.0 From nobody Tue Jun 23 21:33:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB530C433F5 for ; Fri, 25 Feb 2022 17:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231470AbiBYR71 (ORCPT ); Fri, 25 Feb 2022 12:59:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231294AbiBYR7V (ORCPT ); Fri, 25 Feb 2022 12:59:21 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93DA21BF93A for ; Fri, 25 Feb 2022 09:58:48 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id bg16-20020a05600c3c9000b00380f6f473b0so2166268wmb.1 for ; Fri, 25 Feb 2022 09:58:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TToHHhQ9e3UF7DAGb1X/L762Cx9ZwKjwgUki3iHq62w=; b=b1l/w/YSXYX7+AXroPrKESOq2dTiEMdf9vimQ/VnLm62eIy2NGJVm3hk34x+wsIkOb f6+CDfRjN3t53enSilCo6dy/7VqHLKdtw9atzEJPMJ72cXMXR6S4r8DvXFxcnaaog2+z 32+earhfFmLvPwkFwhDS4LLhzuu/me2zdDO8pVkg2+Spmyb1ZVdi5sc2bYqQiZicQswU EnzA3Va4hOiejHsk+lXoW7nS84JFbfks0n25/hbFeWxpHrPEj2iSj2ZVf2lSppGDkx/S L06LSbk4K/TFmKftG7fupA7EutWWsMU3GcHtTV0kJSzDOa+egw1Lh+tf3ytyAscbRqqb zqvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TToHHhQ9e3UF7DAGb1X/L762Cx9ZwKjwgUki3iHq62w=; b=iVrAgP32sddt/E8eZavmWJPjHY9C3pLvNL3rbrCNpvGBHyxvr3l9+4DLuGh4QeDar3 TwskCJQPr7ZN51LpcTQQgQXFfbPD7v1mZwa3ZnW+f3bTk+CPb7jcJl51Jc3ezV33l2JL /hA/YXW/kyQPo1NJ98N2kgrNWY4QOliew00YrfH7NQCQlEFEwu8Et85fOXDeAMvkTpdD 8gIya1TnINku1fGETw9fSgWBFc2Z4HMcVwI7Yj9tM+eLXKPnu65A5D1J9MAADRxgZS8L sRrooFaTWNb1pHn2JEXZNFm6b7NKSvdM0GZeG6ATUhpV9vP/KvubgG3JPaE1ad+ZggPd vlkw== X-Gm-Message-State: AOAM532A2ED9joeR37kEGfpfgnQHlRGR8aBuzfhahABk9s+xRk4KRzs4 S8Y8PObS1aSgpLM+W69cOCCL2Q== X-Google-Smtp-Source: ABdhPJzIrSRHpSy3s2TEPlKdC96c8Ay/w1HBZW8pOPhVyk9/ZGKa99x9C3ugV7b3cxf64njV06CAJA== X-Received: by 2002:a7b:c932:0:b0:381:c66:fff2 with SMTP id h18-20020a7bc932000000b003810c66fff2mr3752039wml.42.1645811927147; Fri, 25 Feb 2022 09:58:47 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id t8-20020a05600c2f8800b00381428ad88dsm74172wmn.15.2022.02.25.09.58.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 09:58:46 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Rob Herring , Srinivas Kandagatla Subject: [PATCH 4/4] dt-bindings: nvmem: brcm,nvram: add basic NVMEM cells Date: Fri, 25 Feb 2022 17:58:22 +0000 Message-Id: <20220225175822.8293-5-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220225175822.8293-1-srinivas.kandagatla@linaro.org> References: <20220225175822.8293-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rafa=C5=82 Mi=C5=82ecki NVRAM doesn't have cells at hardcoded addresses. They are stored in internal struct (custom & dynamic format). It's still important to define relevant cells in DT so NVMEM consumers can reference them. Update binding to allow including basic cells as NVMEM device subnodes. Signed-off-by: Rafa=C5=82 Mi=C5=82ecki Reviewed-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- .../devicetree/bindings/nvmem/brcm,nvram.yaml | 25 +++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Docu= mentation/devicetree/bindings/nvmem/brcm,nvram.yaml index 8c3f0cd22821..25033de3ef6b 100644 --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml @@ -14,6 +14,8 @@ description: | NVRAM can be accessed on Broadcom BCM47xx MIPS and Northstar ARM Cortex-= A9 devices usiong I/O mapped memory. =20 + NVRAM variables can be defined as NVMEM device subnodes. + maintainers: - Rafa=C5=82 Mi=C5=82ecki =20 @@ -27,11 +29,30 @@ properties: reg: maxItems: 1 =20 + board_id: + type: object + description: Board identification name + + et0macaddr: + type: object + description: First Ethernet interface's MAC address + + et1macaddr: + type: object + description: Second Ethernet interface's MAC address + + et2macaddr: + type: object + description: Third Ethernet interface's MAC address + unevaluatedProperties: false =20 examples: - | nvram@1eff0000 { - compatible =3D "brcm,nvram"; - reg =3D <0x1eff0000 0x10000>; + compatible =3D "brcm,nvram"; + reg =3D <0x1eff0000 0x10000>; + + mac: et0macaddr { + }; }; --=20 2.21.0