From nobody Tue Jun 23 22:31:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08774C433FE for ; Fri, 25 Feb 2022 08:28:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238487AbiBYI25 (ORCPT ); Fri, 25 Feb 2022 03:28:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235974AbiBYI2y (ORCPT ); Fri, 25 Feb 2022 03:28:54 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A37E2399C0; Fri, 25 Feb 2022 00:28:23 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id p9so3227307wra.12; Fri, 25 Feb 2022 00:28:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=1pk0WLnHXlhoL5oO4cTN7zI653+mY17exVAjVvxpGiI=; b=fPLc8XONsYkqIevb0UtKzISDb0EfV55898canwMM/Td3rcQ/VB+/LMFdc9559EOmPm Dg2TdxmhOmFp8bcq2DXXkaA2U9Gtopb1zwTTfELifE9MKyy4NP2XF6+1AfAuWarjDam+ AQogKI1MejsGvGe7mOqhhyRDnTrtiH3Abo2i/HpetCT1lEdMcZkaJPjM19hb52pe0t0Q ZYqfFlAYn2GI1vVSkgKzJIR/6lZapU6gPh4rXcmcDy7MDocQfoTBgPaF5aXpMbiBnVuJ CdBKa1ClIlI8kd0yxb8E74wekx1fiytf0ao4J5oOu6M+RlKJ88Ckyey4UNTVZBliSGjr TmlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1pk0WLnHXlhoL5oO4cTN7zI653+mY17exVAjVvxpGiI=; b=8J3vhMRCFK9U37B8HyMCg2cSh0spfudCUV+Jmsh/CAl/hpzBs59F05idEQ1jcsGY9H 5rt2m0MVH55b8rE3blygxHqq8bUexvoc5o8eRL/whBsIZ7/FJO/lSMVxV5dfOucqR8yS ZZgQYfHe5tUBvlUOjcfQrmpzk+3IwQ4Cd+pYnQ6uAfwNjgFiJPP6UwzzHFnt3QYD2v/a CtF1kwmzVNhyXwHbhH+O30Ja5vI3AYkJCSvoPg5wWou9P2t1T+U8C3qJvP7nORM/2kw7 rmw6IGAOERvTLQ5NEHu0uPr9FsW8yCoWigApcaT0OCRd6Wi4Rcff2Sun37DAX8chIIx1 Ihcg== X-Gm-Message-State: AOAM533p5KESnAV8weRFyV8l3OVLxetvbVhEz/9lfi8QTEa29v5m72qh AeER3ZrO4JO+fCRW2haENC0= X-Google-Smtp-Source: ABdhPJw7lM5U90Kcb5DDdxYcaKJG8VnYjOnuuVpkMln8V2MLvmT4afd29iRlybMgAEjP81FUXY0ugg== X-Received: by 2002:a5d:6241:0:b0:1ed:b534:e04e with SMTP id m1-20020a5d6241000000b001edb534e04emr5393634wrv.68.1645777701838; Fri, 25 Feb 2022 00:28:21 -0800 (PST) Received: from localhost.localdomain ([64.64.123.40]) by smtp.gmail.com with ESMTPSA id o20-20020a05600c511400b0038133076da9sm1049613wms.25.2022.02.25.00.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 00:28:21 -0800 (PST) From: Jia-Ju Bai To: colyli@suse.de, kent.overstreet@gmail.com Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] md: bcache: check the return value of mempool_alloc() in bch_btree_node_read_done() Date: Fri, 25 Feb 2022 00:28:04 -0800 Message-Id: <20220225082804.19793-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The function mempool_alloc() in bch_btree_node_read_done() can fail, so its return value should be checked. Fixes: d19936a26658 ("bcache: convert to bioset_init()/mempool_init()") Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/md/bcache/btree.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c index 88c573eeb598..fb8b7dd6bcc2 100644 --- a/drivers/md/bcache/btree.c +++ b/drivers/md/bcache/btree.c @@ -157,6 +157,8 @@ void bch_btree_node_read_done(struct btree *b) * See the comment arount cache_set->fill_iter. */ iter =3D mempool_alloc(&b->c->fill_iter, GFP_NOIO); + if (!iter) + return; iter->size =3D b->c->cache->sb.bucket_size / b->c->cache->sb.block_size; iter->used =3D 0; =20 --=20 2.17.1