From nobody Fri Jun 26 16:02:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC7FC433EF for ; Tue, 22 Feb 2022 13:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232295AbiBVNSH (ORCPT ); Tue, 22 Feb 2022 08:18:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231265AbiBVNSF (ORCPT ); Tue, 22 Feb 2022 08:18:05 -0500 Received: from mail-oo1-xc2d.google.com (mail-oo1-xc2d.google.com [IPv6:2607:f8b0:4864:20::c2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5361BB097 for ; Tue, 22 Feb 2022 05:17:39 -0800 (PST) Received: by mail-oo1-xc2d.google.com with SMTP id j7-20020a4ad6c7000000b0031c690e4123so8311369oot.11 for ; Tue, 22 Feb 2022 05:17:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8PBq7kLR2y8s9lJx+dEOyUvKlmC0izFjBVBTrNAah9s=; b=zDyEXMRdcUX5t9jSuG3U62H5xWO+QvfUk2ZhsY58HqOIx9ZnUABFz3X6sbr6HP2ZhL ZkFEielo35ToVAG0T3KZnKFZq+ielr9LclAFAtCFbGqTnnYtoKb7yn+g2Wh/D1oyNezp 0RzfGweLjxjfmYxWe3eS/tpFENTrHDFIM1lRMKJfCTu5sLLvV+KgHW/UD4nV2hJu5/ru vHNnxC1OY2tbeUAWCE6VEdaA3Pmothkk3CLzUH7rW2rSEu81lUeI6kTuGObzanZXxggT n5njzrT5GV82couAkS7S9CYMi+8RD1d+knUl/5DwG8spMBQ1BE576XER/mfh9CqYZbnp VScw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8PBq7kLR2y8s9lJx+dEOyUvKlmC0izFjBVBTrNAah9s=; b=JrLyyTUV/ZWdcivSX4fUfJCAY1A9bRtk5R+fRq/IRVa4K1iGtTLgsEwQuKX8XT2uZC PzRypbOO7uSpBPj+kIOrrcebNUUrOn2yXEJzKclC1UabnkI8teycHKdvAX/RWQOoLyrE pBBnio2mnhpGVk6/Up6JYiNQ8qeR57C9+3TDGqDceU7eJfISBVCqw/PVkbT5xCMOpyyE 1DY8iEqnO1H62VbNTnGgpy19jastG7hMMVHQJoolFVlfMgBz5zbTQxK12WxW96dZl13B sNwaiWmhMXbHfN1mqGU8xaRkOGFqewhZRty2+zhF2QrW/Wrdm9M2RISXde9QwSGkwqVW JdnA== X-Gm-Message-State: AOAM533qt4h3E0c38UT9pNBPsXWcIDuJ2x2HmQKck46uxSBscKT6XRyc QMnUwJT1TPX3xO4Q5dVGJSpBHw== X-Google-Smtp-Source: ABdhPJw09Q2GTtVLbWQ/lSO046k89Fi/+pAQfC7O7eca3GixOjwGWDj/ecijDSXxl83tN2+o5PHkWg== X-Received: by 2002:a05:6870:580c:b0:d1:7d97:19a with SMTP id r12-20020a056870580c00b000d17d97019amr1592418oap.281.1645535859003; Tue, 22 Feb 2022 05:17:39 -0800 (PST) Received: from fedora.. ([187.36.236.204]) by smtp.gmail.com with ESMTPSA id c9sm6325050otd.26.2022.02.22.05.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 05:17:38 -0800 (PST) From: =?UTF-8?q?Ma=C3=ADra=20Canal?= To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, Hawking.Zhang@amd.com, john.clements@amd.com, tao.zhou1@amd.com, YiPeng.Chai@amd.com, luben.tuikov@amd.com, Stanley.Yang@amd.com, Dennis.Li@amd.com, mukul.joshi@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, Anthony.Koo@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, magalilemes00@gmail.com, mwen@igalia.com, isabbasso@riseup.net, =?UTF-8?q?Ma=C3=ADra=20Canal?= Subject: [PATCH 01/10] drm/amdgpu: Change amdgpu_ras_block_late_init_default function scope Date: Tue, 22 Feb 2022 10:16:52 -0300 Message-Id: <20220222131701.356117-2-maira.canal@usp.br> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222131701.356117-1-maira.canal@usp.br> References: <20220222131701.356117-1-maira.canal@usp.br> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Turn previously global function into a static function to avoid the following Clang warning: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2459:5: warning: no previous protot= ype for function 'amdgpu_ras_block_late_init_default' [-Wmissing-prototypes] int amdgpu_ras_block_late_init_default(struct amdgpu_device *adev, ^ drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2459:1: note: declare 'static' if t= he function is not intended to be used outside of this translation unit int amdgpu_ras_block_late_init_default(struct amdgpu_device *adev, ^ static Signed-off-by: Ma=C3=ADra Canal --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/= amdgpu/amdgpu_ras.c index e5874df3c9ca..dff5240efcc7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c @@ -2456,7 +2456,7 @@ int amdgpu_ras_block_late_init(struct amdgpu_device *= adev, return r; } =20 -int amdgpu_ras_block_late_init_default(struct amdgpu_device *adev, +static int amdgpu_ras_block_late_init_default(struct amdgpu_device *adev, struct ras_common_if *ras_block) { return amdgpu_ras_block_late_init(adev, ras_block); --=20 2.35.1 From nobody Fri Jun 26 16:02:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D23EDC433EF for ; Tue, 22 Feb 2022 13:17:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232335AbiBVNSQ (ORCPT ); Tue, 22 Feb 2022 08:18:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231265AbiBVNSM (ORCPT ); Tue, 22 Feb 2022 08:18:12 -0500 Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A02FBB0B0 for ; Tue, 22 Feb 2022 05:17:47 -0800 (PST) Received: by mail-oo1-xc30.google.com with SMTP id j7-20020a4ad6c7000000b0031c690e4123so8311987oot.11 for ; Tue, 22 Feb 2022 05:17:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yJggk1To+XLut1ObcBuO//1+OtwNQL2IY8utthiAw+M=; b=M5U+hrmDa39RJmpT6cpDMWuT1ftn8C6oDHPdv+0YjkKjP3plzi/1n7Yos1ZJvj5TWL oSJ6jfHTPW6wOoEzXfnmv0O6XULQpIlFFRouo6PlM2daWq3ng4LttobHWIUFfhweB76U cbnu0WB5CVQAQUu+9ZsF71wZFXSr5Tr2Q3GSMDmVZTSvqqUBxkN8maDIQdoR6mbTHnzl +sXNxOLwoN5wFXpDoydePtV49H1x/bexC6s0pumgdWV1YSFBFau+iHG9qfZvXDzLh5Dp R5V1tJuwXzwOTm8SeUcVi5RKzf90KB6fCi/7MmcsgKU7TGU4UFNug4thzgm77mP9WDgN jpBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yJggk1To+XLut1ObcBuO//1+OtwNQL2IY8utthiAw+M=; b=6GtHFBpJs44cJP3s3Q1h9vTo8Hf0x76VlmRC9FjwTmHsRXwKxJI+oAkDVhg5MnDGIc oGNGUSVdg+gwDRhL6taeiV7lfry+qmXzSX94lH/dp7NzSQZ7yvhfEXLfl4oyjSjIk3ja tsdvcwMB+eWRyVeukIfrh4as8vMWJPIpO0V6h0tpgzxZq0sWzgw75hjHuS8n2g7S8ClA Y/LMwaneZ7j1lSfqQtmL3E0/bxpmPCrCMkf0dZr3laVisEumoWYRzECMGPSlXJpcYc4r /uUFIU+aMOrf1uJUsF8iq7lhC33+70RMLLLu43KEuhpxRzQYVfZ1qpot9acGsR9PDHT4 OJVg== X-Gm-Message-State: AOAM532ZhkKl3o2mW1Es9ED+KVgMmHzPCTBVlsgfALyFjz1gRyJrVpJy s/JS85tyG8FR8OV1nh4sxYdKwP5Vl++FeVZ9 X-Google-Smtp-Source: ABdhPJyEmLFkADch2Vvvvc2TiPZFt4fsErzfmYtqCPhQrfpy8eB9rJIReQvGDozdKk6LKkOtj8RqLQ== X-Received: by 2002:a05:6870:c898:b0:ce:c0c9:660 with SMTP id er24-20020a056870c89800b000cec0c90660mr1543821oab.178.1645535866494; Tue, 22 Feb 2022 05:17:46 -0800 (PST) Received: from fedora.. ([187.36.236.204]) by smtp.gmail.com with ESMTPSA id c9sm6325050otd.26.2022.02.22.05.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 05:17:46 -0800 (PST) From: =?UTF-8?q?Ma=C3=ADra=20Canal?= To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, Hawking.Zhang@amd.com, john.clements@amd.com, tao.zhou1@amd.com, YiPeng.Chai@amd.com, luben.tuikov@amd.com, Stanley.Yang@amd.com, Dennis.Li@amd.com, mukul.joshi@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, Anthony.Koo@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, magalilemes00@gmail.com, mwen@igalia.com, isabbasso@riseup.net, =?UTF-8?q?Ma=C3=ADra=20Canal?= Subject: [PATCH 02/10] drm/amdgpu: Remove tmp unused variable Date: Tue, 22 Feb 2022 10:16:53 -0300 Message-Id: <20220222131701.356117-3-maira.canal@usp.br> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222131701.356117-1-maira.canal@usp.br> References: <20220222131701.356117-1-maira.canal@usp.br> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The variable tmp is not used in the dce_v6_0_hpd_fini and dce_v8_0_hpd_fini functions. Therefor, the variable is removed in order to avoid the following Clang warnings: drivers/gpu/drm/amd/amdgpu/dce_v6_0.c:331:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable] u32 tmp; ^ drivers/gpu/drm/amd/amdgpu/dce_v8_0.c:325:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable] u32 tmp; ^ Signed-off-by: Ma=C3=ADra Canal --- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 4 +--- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/am= dgpu/dce_v6_0.c index b90bc2adf778..2c61f0c2e709 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c @@ -328,7 +328,6 @@ static void dce_v6_0_hpd_fini(struct amdgpu_device *ade= v) struct drm_device *dev =3D adev_to_drm(adev); struct drm_connector *connector; struct drm_connector_list_iter iter; - u32 tmp; =20 drm_connector_list_iter_begin(dev, &iter); drm_for_each_connector_iter(connector, &iter) { @@ -337,8 +336,7 @@ static void dce_v6_0_hpd_fini(struct amdgpu_device *ade= v) if (amdgpu_connector->hpd.hpd >=3D adev->mode_info.num_hpd) continue; =20 - tmp =3D RREG32(mmDC_HPD1_CONTROL + hpd_offsets[amdgpu_connector->hpd.hpd= ]); - tmp &=3D ~DC_HPD1_CONTROL__DC_HPD1_EN_MASK; + RREG32(mmDC_HPD1_CONTROL + hpd_offsets[amdgpu_connector->hpd.hpd]); WREG32(mmDC_HPD1_CONTROL + hpd_offsets[amdgpu_connector->hpd.hpd], 0); =20 amdgpu_irq_put(adev, &adev->hpd_irq, amdgpu_connector->hpd.hpd); diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/am= dgpu/dce_v8_0.c index 7c1379b02f94..c5e9c5dbd165 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c @@ -322,7 +322,6 @@ static void dce_v8_0_hpd_fini(struct amdgpu_device *ade= v) struct drm_device *dev =3D adev_to_drm(adev); struct drm_connector *connector; struct drm_connector_list_iter iter; - u32 tmp; =20 drm_connector_list_iter_begin(dev, &iter); drm_for_each_connector_iter(connector, &iter) { @@ -331,8 +330,7 @@ static void dce_v8_0_hpd_fini(struct amdgpu_device *ade= v) if (amdgpu_connector->hpd.hpd >=3D adev->mode_info.num_hpd) continue; =20 - tmp =3D RREG32(mmDC_HPD1_CONTROL + hpd_offsets[amdgpu_connector->hpd.hpd= ]); - tmp &=3D ~DC_HPD1_CONTROL__DC_HPD1_EN_MASK; + RREG32(mmDC_HPD1_CONTROL + hpd_offsets[amdgpu_connector->hpd.hpd]); WREG32(mmDC_HPD1_CONTROL + hpd_offsets[amdgpu_connector->hpd.hpd], 0); =20 amdgpu_irq_put(adev, &adev->hpd_irq, amdgpu_connector->hpd.hpd); --=20 2.35.1 From nobody Fri Jun 26 16:02:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7842C433EF for ; Tue, 22 Feb 2022 13:17:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232336AbiBVNSX (ORCPT ); Tue, 22 Feb 2022 08:18:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230154AbiBVNSW (ORCPT ); Tue, 22 Feb 2022 08:18:22 -0500 Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4AADBD2C9 for ; Tue, 22 Feb 2022 05:17:53 -0800 (PST) Received: by mail-oo1-xc2b.google.com with SMTP id w10-20020a4ae08a000000b0031bdf7a6d76so17386428oos.10 for ; Tue, 22 Feb 2022 05:17:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gUjTQJmzrA7YmPv0U39+3zh4DUhMv7PoZUE1y8daTkU=; b=FPkH1X3s9Z4MaxrX4uqfjr3F7a7VH/XL8sjYBD6kv6nMhEpAtU0QfomFMaSf8GNpNb t8YlseyboP1Z50Mc5eIfXqwSJbkKQTQ9ZXMON7BiQCTV40wpQybAmTe494JaSNRDO+zC vbuySWtEozg1GqhKsGDm9fQ6jWZhJiM7f8lLHj9CylLBenQ2MER4QfyRBDuXXRIlTfvt 5ryycyOYPDO6dj2uPS+Xzphui8DCkRzUX48xpDmIKU+nAvi9WGP2l70vmWQ0sQFkV6ea LdMIKNtGBicAKMdkC8dcenYvWdwTribZIuLNqcKIWS1LNJGiEYXiZp0ClRVbRr+Q0sZT YZIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gUjTQJmzrA7YmPv0U39+3zh4DUhMv7PoZUE1y8daTkU=; b=vy/Ax87e7ukcCR7AsyvHpBUld1vjMWtC6dcDj7GM0EfyEw2TbCvbIOamH2xCZZH8PM uDzOTU88qUIDOtnaTQsMrHfz9odB3tBHhPu4LOtN6wyL31PWh67s/jMzaA2w6U1t/1pN sgY6QXaQ9JZqxTMsq+rFWgHEu/Wp/kGiM74AbnfuSULERRgPdQKulML2RN6vgyJM7SUc OW5vP95H8RZn5MSDLa8eG6aoFza95dnMUYlKkaudqhIdHwM4/7h5uwqHiLYG/rJ4QgIT 58FVWM2rmL0CpzbHyxr6OVEz5XCDQLMejURete++n1pJd5ENPz1/AKdi2Ff092G1QIce Fv+A== X-Gm-Message-State: AOAM5301Pke6CR2WYIODLhaETsTCqsPuB4m7BerJl3Diz6qt7UHWgRTL dw97xVWUZtVYsnRmIQ1WncRCQg== X-Google-Smtp-Source: ABdhPJzSWobKzGCiBglLAMfGQ3zQeN2B60sOxZj/bjK565W/h7V9hy4VhSqKHUZu46XzLWuT1K3MqQ== X-Received: by 2002:a05:6870:2142:b0:d2:c3fe:83c8 with SMTP id g2-20020a056870214200b000d2c3fe83c8mr1630946oae.165.1645535873120; Tue, 22 Feb 2022 05:17:53 -0800 (PST) Received: from fedora.. ([187.36.236.204]) by smtp.gmail.com with ESMTPSA id c9sm6325050otd.26.2022.02.22.05.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 05:17:52 -0800 (PST) From: =?UTF-8?q?Ma=C3=ADra=20Canal?= To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, Hawking.Zhang@amd.com, john.clements@amd.com, tao.zhou1@amd.com, YiPeng.Chai@amd.com, luben.tuikov@amd.com, Stanley.Yang@amd.com, Dennis.Li@amd.com, mukul.joshi@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, Anthony.Koo@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, magalilemes00@gmail.com, mwen@igalia.com, isabbasso@riseup.net, =?UTF-8?q?Ma=C3=ADra=20Canal?= Subject: [PATCH 03/10] drm/amdgpu: Remove unused get_umc_v8_7_channel_index function Date: Tue, 22 Feb 2022 10:16:54 -0300 Message-Id: <20220222131701.356117-4-maira.canal@usp.br> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222131701.356117-1-maira.canal@usp.br> References: <20220222131701.356117-1-maira.canal@usp.br> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove get_umc_v8_7_channel_index function, which is not used in the codebase. This was pointed by clang with the following warning: drivers/gpu/drm/amd/amdgpu/umc_v8_7.c:50:24: warning: unused function 'get_umc_v8_7_channel_index' [-Wunused-function] static inline uint32_t get_umc_v8_7_channel_index(struct amdgpu_device *ade= v, ^ Signed-off-by: Ma=C3=ADra Canal --- drivers/gpu/drm/amd/amdgpu/umc_v8_7.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c b/drivers/gpu/drm/amd/am= dgpu/umc_v8_7.c index de85a998ef99..f35253e0eaa6 100644 --- a/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c +++ b/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c @@ -47,13 +47,6 @@ static inline uint32_t get_umc_v8_7_reg_offset(struct am= dgpu_device *adev, return adev->umc.channel_offs*ch_inst + UMC_8_INST_DIST*umc_inst; } =20 -static inline uint32_t get_umc_v8_7_channel_index(struct amdgpu_device *ad= ev, - uint32_t umc_inst, - uint32_t ch_inst) -{ - return adev->umc.channel_idx_tbl[umc_inst * adev->umc.channel_inst_num + = ch_inst]; -} - static void umc_v8_7_ecc_info_query_correctable_error_count(struct amdgpu_= device *adev, uint32_t umc_inst, uint32_t ch_inst, unsigned long *error_count) --=20 2.35.1 From nobody Fri Jun 26 16:02:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E83C433FE for ; Tue, 22 Feb 2022 13:18:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232334AbiBVNS3 (ORCPT ); Tue, 22 Feb 2022 08:18:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232306AbiBVNS0 (ORCPT ); Tue, 22 Feb 2022 08:18:26 -0500 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66B65BD8B6 for ; Tue, 22 Feb 2022 05:18:01 -0800 (PST) Received: by mail-oi1-x229.google.com with SMTP id s5so14384864oic.10 for ; Tue, 22 Feb 2022 05:18:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ayEiTJoQMQ+jcjp3UMRNd5LwLeFycUhnaRc8GdLvEdk=; b=Wqh8WVyaB3/ePOUVG3qDmLXtRM2V02SqDxNeuWJZyWdRv9S3nWuGPgBol8HVCWBq8s DhdiEThHMeaf3oShHr2vzPZEF1glAHISZfrq3028oU3ta8gBcyG3ZW7qCSSEyHOTI3lB BnxvSUxinY/c3tq9cibM8S6EyjPjwHVN8UdKR268Zwpzc9EZjOU39PEj/kwRRPUwIzMC TJoaaWdEK9eQzLpnFNJIlDEy9QqLPUYMg7l3IH3RF7db55PMl9T1tKhWeuWn2GGMES0C X+a0prpgsJLlkvgbGmBRL1Skefle02K+m9wUWk7PYw5kkYDqo0dRaW0HX71nR2+EcEzY Q1og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ayEiTJoQMQ+jcjp3UMRNd5LwLeFycUhnaRc8GdLvEdk=; b=EBfx5lwYRMByZ/aVYLXWJhxWy0NrID+VMn6G4STeM9ML6PWSi81LqAS7ixYAWoAlJK i7le6EmUIoIHHOA3VnY88h4/mZFlOaW+wdqfOnIOg5T4YHO0W2Q+LDylcx6JBC381GIt TmLHi4qiSYFtOi5Ax5MoBWKNUVKAHU72+5DR4F03NxkCmLXComAD5A8CAAkrQRX1sWYT 9yTdej0NUFUYtltJ6UwxK7KbjuhiKautvbXigcviyh5khr7E1zVHg+hazioZVvMnkKL5 WVgk0OhEjm6KvOmSAb4Ka5pHs2gbbV1b8dISEtcbW7BPOsJINonq+CyMTVPalh8Wx0ct MDTQ== X-Gm-Message-State: AOAM530cUkUukIYoYbAMpEVF+9SN8n22/PyQTIQpPjwqmAhK5PzcmUKU 6g+l9qLiQzYFHPTlphdvZZOg2A== X-Google-Smtp-Source: ABdhPJwWSQJbsP6uAkrMylNazH+1ImSjAqTPKRnK19++tCqd6JrQXsgHYiKgvyoSEEmR6fmGiVSzTQ== X-Received: by 2002:a05:6808:f0f:b0:2cf:3d64:2333 with SMTP id m15-20020a0568080f0f00b002cf3d642333mr1897906oiw.23.1645535880803; Tue, 22 Feb 2022 05:18:00 -0800 (PST) Received: from fedora.. ([187.36.236.204]) by smtp.gmail.com with ESMTPSA id c9sm6325050otd.26.2022.02.22.05.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 05:18:00 -0800 (PST) From: =?UTF-8?q?Ma=C3=ADra=20Canal?= To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, Hawking.Zhang@amd.com, john.clements@amd.com, tao.zhou1@amd.com, YiPeng.Chai@amd.com, luben.tuikov@amd.com, Stanley.Yang@amd.com, Dennis.Li@amd.com, mukul.joshi@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, Anthony.Koo@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, magalilemes00@gmail.com, mwen@igalia.com, isabbasso@riseup.net, =?UTF-8?q?Ma=C3=ADra=20Canal?= Subject: [PATCH 04/10] drm/amd/display: Remove unused temp variable Date: Tue, 22 Feb 2022 10:16:55 -0300 Message-Id: <20220222131701.356117-5-maira.canal@usp.br> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222131701.356117-1-maira.canal@usp.br> References: <20220222131701.356117-1-maira.canal@usp.br> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove unused temp variable from the dmub_rb_flush_pending function by using arithmetic to remove the loop. The -Wunused-but-set-variable warning was pointed out by Clang with the following warning: drivers/gpu/drm/amd/amdgpu/../display/dmub/inc/dmub_cmd.h:2921:12: warning: variable 'temp' set but not used [-Wunused-but-set-variable] uint64_t temp; ^ Signed-off-by: Ma=C3=ADra Canal --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/= drm/amd/display/dmub/inc/dmub_cmd.h index fb01ff49e655..d3088836d4e4 100644 --- a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h +++ b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h @@ -2918,11 +2918,8 @@ static inline void dmub_rb_flush_pending(const struc= t dmub_rb *rb) while (rptr !=3D wptr) { uint64_t volatile *data =3D (uint64_t volatile *)((uint8_t *)(rb->base_a= ddress) + rptr); //uint64_t volatile *p =3D (uint64_t volatile *)data; - uint64_t temp; - uint8_t i; =20 - for (i =3D 0; i < DMUB_RB_CMD_SIZE / sizeof(uint64_t); i++) - temp =3D *data++; + *data +=3D DMUB_RB_CMD_SIZE / sizeof(uint64_t); =20 rptr +=3D DMUB_RB_CMD_SIZE; if (rptr >=3D rb->capacity) --=20 2.35.1 From nobody Fri Jun 26 16:02:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6570AC433F5 for ; Tue, 22 Feb 2022 13:18:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232339AbiBVNSk (ORCPT ); Tue, 22 Feb 2022 08:18:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232348AbiBVNSg (ORCPT ); Tue, 22 Feb 2022 08:18:36 -0500 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B704C0842 for ; Tue, 22 Feb 2022 05:18:08 -0800 (PST) Received: by mail-oi1-x22c.google.com with SMTP id 12so6386233oix.12 for ; Tue, 22 Feb 2022 05:18:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ACyjILcPZ7NYc4LHqBI/xMepMYxZRqk3PuvZsYhS/Ak=; b=v4JuF4eo37E18crpKjb/Gy2A7pJWq76VCa+SO0Yq2LZhwxQ80IckHLVEykfxl+nfW6 zOiTv4hSWHNOaMO3uESTI58NF+VpBtZ+ioz74gPPvRewBi5Wm/vNY4R76jnCGHoPc6H1 D4duIjjzalbpwjn4VmFoKeov9xAV/JkbSY0bME9CiQ5EoiVvI/bAL+3PvS4rK8pcTUer fAL6Y8cQdpq2p3zQaGuE84a+1HeTzBv7Vxh8mUZFHbhT28l7rk9/7J139WxWOZ2t9UX0 QfoIZcl0NVgcSrenDt/ZlCfp0kbAjFMyzQUcxgYWD2P6bDQVYoBq0GMddHGGMJx8FiVi Xkgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ACyjILcPZ7NYc4LHqBI/xMepMYxZRqk3PuvZsYhS/Ak=; b=5CnnKn2fWQskCatR4rDImlFuQawYVa1ZdK5Xq3E4jFLZmh1Vs5qkOhTQRDGtZwQuCA 9OxZ5A8SoAKR26mNtSddje9TUWrAKm5lCHaf4h3FE2VMxIm6ATQOUsctp9IZo/g8QYpb 62t3LsOVc4XXICQeIN11WH3qBa6pOZlR2B2LGfHaA3D7z/3JPy3RrJr/asHiJkbwzvYM gHxLtBKwMLC8BIZvlkfqQEMBLpVtPZVuR6Jtg+mHj7vyYwi7JWqTy1UFy+f0Dg9cRRIY fhRqj1FjFIubfiBaZWvoJdN9D2Q5z1jtAfqZskpnLEmW03beOfqpBwwauRtVHVrXdlkL /raw== X-Gm-Message-State: AOAM531gt8mGVr0OfFyyKh2qpA4XZv4JVa31g+LEu6g5XCtEEATENFdn 6vDyhxRD0M8cDVu4AE8emhF7WulLnt7dAu2u X-Google-Smtp-Source: ABdhPJwPv6b/Py7a73THpCfPZnfM/8IqLsz85BzUx8kIjX3WPdbvzYq+DLAUFR44XYrhcXxQsPSCiA== X-Received: by 2002:a05:6808:238e:b0:2d4:fe08:9351 with SMTP id bp14-20020a056808238e00b002d4fe089351mr1835703oib.291.1645535887885; Tue, 22 Feb 2022 05:18:07 -0800 (PST) Received: from fedora.. ([187.36.236.204]) by smtp.gmail.com with ESMTPSA id c9sm6325050otd.26.2022.02.22.05.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 05:18:07 -0800 (PST) From: =?UTF-8?q?Ma=C3=ADra=20Canal?= To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, Hawking.Zhang@amd.com, john.clements@amd.com, tao.zhou1@amd.com, YiPeng.Chai@amd.com, luben.tuikov@amd.com, Stanley.Yang@amd.com, Dennis.Li@amd.com, mukul.joshi@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, Anthony.Koo@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, magalilemes00@gmail.com, mwen@igalia.com, isabbasso@riseup.net, =?UTF-8?q?Ma=C3=ADra=20Canal?= Subject: [PATCH 05/10] drm/amd/display: Remove unused dcn316_smu_set_voltage_via_phyclk function Date: Tue, 22 Feb 2022 10:16:56 -0300 Message-Id: <20220222131701.356117-6-maira.canal@usp.br> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222131701.356117-1-maira.canal@usp.br> References: <20220222131701.356117-1-maira.canal@usp.br> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove dcn316_smu_set_voltage_via_phyclk function, which is not used in the codebase. This was pointed by clang with the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_smu.c:171:5: warning: no previous prototype for function 'dcn316_smu_set_voltage_via_phyclk' [-Wmissing-prototypes] int dcn316_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int requested_phyclk_khz) ^ Signed-off-by: Ma=C3=ADra Canal --- .../amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c b/d= rivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c index b7f9e1b34c11..fd6497fd2dc5 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c @@ -168,22 +168,6 @@ int dcn316_smu_set_dispclk(struct clk_mgr_internal *cl= k_mgr, int requested_dispc return actual_dispclk_set_mhz * 1000; } =20 -int dcn316_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, in= t requested_phyclk_khz) -{ - int actual_phypclk_set_mhz =3D -1; - - if (!clk_mgr->smu_present && requested_phyclk_khz) - return requested_phyclk_khz; - - /* Unit of SMU msg parameter is Mhz */ - actual_phypclk_set_mhz =3D dcn316_smu_send_msg_with_param( - clk_mgr, - VBIOSSMC_MSG_SetPhyclkVoltageByFreq, - khz_to_mhz_ceil(requested_phyclk_khz)); - - return actual_phypclk_set_mhz * 1000; -} - int dcn316_smu_set_hard_min_dcfclk(struct clk_mgr_internal *clk_mgr, int r= equested_dcfclk_khz) { int actual_dcfclk_set_mhz =3D -1; --=20 2.35.1 From nobody Fri Jun 26 16:02:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F8DAC433FE for ; Tue, 22 Feb 2022 13:18:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232366AbiBVNSt (ORCPT ); Tue, 22 Feb 2022 08:18:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232306AbiBVNSl (ORCPT ); Tue, 22 Feb 2022 08:18:41 -0500 Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8841BF973 for ; Tue, 22 Feb 2022 05:18:15 -0800 (PST) Received: by mail-oo1-xc2c.google.com with SMTP id j7-20020a4ad6c7000000b0031c690e4123so8314061oot.11 for ; Tue, 22 Feb 2022 05:18:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BddlbliOr23dlDMdKBzq441XXaZGsl4trq5vl1IoJkg=; b=FUA2ctAo26U2VrMAKFt54E8PbaVy/9Q9zg1A3qXzzTgDZcTBWgReR8aOIbcyuhzsF5 eZs6UwHAOqyX2RmmHXchNyyGwfu4QHZGvtnkj1pLEHgLmIqBkMhgf438CjVIgFFuq63w 6LdcOTqLckFWTH8WJ7U5Tjr9h+muBirlacXpfy3sK/cBHVV9HOlUkfm9ri+eWH1MJ98I A6ZP8JyO+8MmfuedfI215qVFqwF1EX60l+jidbFr2G6Ie45RH+r86f5gArzwFc34SWsH vN67IJGYhoRz4fT7fTkk552gB+68Q2EyCqicVWLvrhtVtUSS3UP6FyGb7EoQRlFzMrO5 N3Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BddlbliOr23dlDMdKBzq441XXaZGsl4trq5vl1IoJkg=; b=Gtf5W05Hhl6pFMpQZrd8hv7mIsRFrO0hLP7eTEtN+QcKHzNPTREVMZQTFb82osdwOp BUhBix4cdScVPt39ZNPcgsH+PJuVjQDX8aiQLWpcpmP3sy6m+Nu8r5zPtJcKLTlDzLro VkP/yMDWheVyBbPRv1XXn3uqGLKvmZtjTzx6HMi7Fi5M4fsoLam+HJdukc3w00837C6O UbTK+Y+IoCgH0+Wp4mGy8xyQxWbEezG8HVedNrtPfQS2cmj4XX4C5N+in1caFDY0V3WJ yLQZ2vMIx/Oic+t42zabc91oT4aQcV5G73rYhUwdbiJJFOZttnoeqNZKbz/WEW6gDN08 uPqg== X-Gm-Message-State: AOAM531dR7LSx8jn6fMAJ3Gek8lSCyi55nR4OfABJxSgGtC5vMtKTiWs pbacdV00CTqv2202A3tPOMeMLQ== X-Google-Smtp-Source: ABdhPJxEyM6aUtyhGo6ZTsWyPOth67Mi4P+5opQjl7KNJFm0YuxYey03Zaf5skFdls+byx/d7c4Vxg== X-Received: by 2002:a05:6870:d59a:b0:c4:7dc0:d72a with SMTP id u26-20020a056870d59a00b000c47dc0d72amr1498997oao.253.1645535895164; Tue, 22 Feb 2022 05:18:15 -0800 (PST) Received: from fedora.. ([187.36.236.204]) by smtp.gmail.com with ESMTPSA id c9sm6325050otd.26.2022.02.22.05.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 05:18:14 -0800 (PST) From: =?UTF-8?q?Ma=C3=ADra=20Canal?= To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, Hawking.Zhang@amd.com, john.clements@amd.com, tao.zhou1@amd.com, YiPeng.Chai@amd.com, luben.tuikov@amd.com, Stanley.Yang@amd.com, Dennis.Li@amd.com, mukul.joshi@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, Anthony.Koo@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, magalilemes00@gmail.com, mwen@igalia.com, isabbasso@riseup.net, =?UTF-8?q?Ma=C3=ADra=20Canal?= Subject: [PATCH 06/10] drm/amd/display: Remove vupdate_int_entry definition Date: Tue, 22 Feb 2022 10:16:57 -0300 Message-Id: <20220222131701.356117-7-maira.canal@usp.br> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222131701.356117-1-maira.canal@usp.br> References: <20220222131701.356117-1-maira.canal@usp.br> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the vupdate_int_entry definition and utilization to avoid the following warning by Clang: drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:410:= 2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides] vupdate_no_lock_int_entry(0), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:280:= 39: note: expanded from macro 'vupdate_no_lock_int_entry' [DC_IRQ_SOURCE_VUPDATE1 + reg_num] =3D {\ ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:404:= 2: note: previous initialization is here vupdate_int_entry(0), ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:269:= 39: note: expanded from macro 'vupdate_int_entry' [DC_IRQ_SOURCE_VUPDATE1 + reg_num] =3D {\ ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:411:= 2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides] vupdate_no_lock_int_entry(1), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:280:= 39: note: expanded from macro 'vupdate_no_lock_int_entry' [DC_IRQ_SOURCE_VUPDATE1 + reg_num] =3D {\ ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:405:= 2: note: previous initialization is here vupdate_int_entry(1), ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:269:= 39: note: expanded from macro 'vupdate_int_entry' [DC_IRQ_SOURCE_VUPDATE1 + reg_num] =3D {\ ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:412:= 2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides] vupdate_no_lock_int_entry(2), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:280:= 39: note: expanded from macro 'vupdate_no_lock_int_entry' [DC_IRQ_SOURCE_VUPDATE1 + reg_num] =3D {\ ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:406:= 2: note: previous initialization is here vupdate_int_entry(2), ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:269:= 39: note: expanded from macro 'vupdate_int_entry' [DC_IRQ_SOURCE_VUPDATE1 + reg_num] =3D {\ ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:413:= 2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides] vupdate_no_lock_int_entry(3), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:280:= 39: note: expanded from macro 'vupdate_no_lock_int_entry' [DC_IRQ_SOURCE_VUPDATE1 + reg_num] =3D {\ ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:407:= 2: note: previous initialization is here vupdate_int_entry(3), ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:269:= 39: note: expanded from macro 'vupdate_int_entry' [DC_IRQ_SOURCE_VUPDATE1 + reg_num] =3D {\ ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:414:= 2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides] vupdate_no_lock_int_entry(4), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:280:= 39: note: expanded from macro 'vupdate_no_lock_int_entry' [DC_IRQ_SOURCE_VUPDATE1 + reg_num] =3D {\ ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:408:= 2: note: previous initialization is here vupdate_int_entry(4), ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:269:= 39: note: expanded from macro 'vupdate_int_entry' [DC_IRQ_SOURCE_VUPDATE1 + reg_num] =3D {\ ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:415:= 2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides] vupdate_no_lock_int_entry(5), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:280:= 39: note: expanded from macro 'vupdate_no_lock_int_entry' [DC_IRQ_SOURCE_VUPDATE1 + reg_num] =3D {\ ^~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:409:= 2: note: previous initialization is here vupdate_int_entry(5), ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:269:= 39: note: expanded from macro 'vupdate_int_entry' [DC_IRQ_SOURCE_VUPDATE1 + reg_num] =3D {\ ^~ 6 warnings generated. fixes: 688f97ed ("drm/amd/display: Add vupdate_no_lock interrupts for DCN2.1") Signed-off-by: Ma=C3=ADra Canal --- .../amd/display/dc/irq/dcn21/irq_service_dcn21.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c b= /drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c index 0f15bcada4e9..717977aec6d0 100644 --- a/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c @@ -265,14 +265,6 @@ static const struct irq_source_info_funcs vline0_irq_i= nfo_funcs =3D { .funcs =3D &pflip_irq_info_funcs\ } =20 -#define vupdate_int_entry(reg_num)\ - [DC_IRQ_SOURCE_VUPDATE1 + reg_num] =3D {\ - IRQ_REG_ENTRY(OTG, reg_num,\ - OTG_GLOBAL_SYNC_STATUS, VUPDATE_INT_EN,\ - OTG_GLOBAL_SYNC_STATUS, VUPDATE_EVENT_CLEAR),\ - .funcs =3D &vblank_irq_info_funcs\ - } - /* vupdate_no_lock_int_entry maps to DC_IRQ_SOURCE_VUPDATEx, to match sema= ntic * of DCE's DC_IRQ_SOURCE_VUPDATEx. */ @@ -401,12 +393,6 @@ irq_source_info_dcn21[DAL_IRQ_SOURCES_NUMBER] =3D { dc_underflow_int_entry(6), [DC_IRQ_SOURCE_DMCU_SCP] =3D dummy_irq_entry(), [DC_IRQ_SOURCE_VBIOS_SW] =3D dummy_irq_entry(), - vupdate_int_entry(0), - vupdate_int_entry(1), - vupdate_int_entry(2), - vupdate_int_entry(3), - vupdate_int_entry(4), - vupdate_int_entry(5), vupdate_no_lock_int_entry(0), vupdate_no_lock_int_entry(1), vupdate_no_lock_int_entry(2), --=20 2.35.1 From nobody Fri Jun 26 16:02:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27C8DC433EF for ; Tue, 22 Feb 2022 13:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232361AbiBVNSx (ORCPT ); Tue, 22 Feb 2022 08:18:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231934AbiBVNSt (ORCPT ); Tue, 22 Feb 2022 08:18:49 -0500 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DECBC12D0 for ; Tue, 22 Feb 2022 05:18:22 -0800 (PST) Received: by mail-ot1-x331.google.com with SMTP id l25-20020a9d7a99000000b005af173a2875so5096234otn.2 for ; Tue, 22 Feb 2022 05:18:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sDN/q36ne++w24m6ta6Mu8DvTucc3A8JRf+sG15A4uk=; b=gwNgQ82BffFNGYRWppEJcVbH9lkHH4pDVyKTZaRhGLp+f2xO5A1Rx15s9yci3hHm4w FR1uQhg8pvxh6Nres53U9+5PeQJjeY4FqukANXW+8jQxQv139/laPSL8d4aiynsMT7my oM5Wamd+Hc1OYtVIoCGTe5UqhD9E3zG6UB+aAagv3NxkPhAqTy845/1Yegz+Ca/xHwmK YaQM48FZyG/26ee4ISyofDBH3oxrbmeQdpILyFa49nlOGi9EKrN2uGD9mf6DccDzN5M1 DUU+/U+aSWi9pPrfoohDvEJclSE8CUZvlfVrqhZg4DwOkDj8i05D6c/wK2OrBZbxVyJ3 DXkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sDN/q36ne++w24m6ta6Mu8DvTucc3A8JRf+sG15A4uk=; b=HQ2Ezb5aCrDwQZewMX5N5ZsCQe6hPZ6DnR2sY1SE0erTlIKss4HFWqfQp1Db7fp/k8 zpvlqf+CygR3ujTASel+0+JTbT/QZGP167FJMW6Fq2Uq0g0zHsA2WzBdayo9vTcvygHS GdNfkNfPBJVvCMC8KFUtGjvX14Az9yVvFKvZtY+s9S2LJidGxNWbQCD2dK8K7+XnWZeJ ssXIYe2ig1hg173qHAn1DpDF0HH2hILWXAmKP4wgjxzL5+ZBfiLVVqgWFROD+BfjzMaS 4ouRHyJKgS87ur+UW2CnsGXvWPyjekVH6cbw2OAAoyIGbWcxbG4CfjM5aIuiwWh0/tmT CgGQ== X-Gm-Message-State: AOAM530+XFkACXgQiBdH298tEPBoNs3nrT84I/SQi0zy+X/JRDVFX4kT +4wUAvDDrsk9d8A+y3t/0ZMc6Q== X-Google-Smtp-Source: ABdhPJyc2O86+E0dEG/No0hmALq+XxmG2EgDiNrBeWwpqJKHrw0001sfFqK9Y7CYkpxQ9BvdfQuGzg== X-Received: by 2002:a9d:714a:0:b0:5ad:f8f9:b50d with SMTP id y10-20020a9d714a000000b005adf8f9b50dmr4817459otj.47.1645535902206; Tue, 22 Feb 2022 05:18:22 -0800 (PST) Received: from fedora.. ([187.36.236.204]) by smtp.gmail.com with ESMTPSA id c9sm6325050otd.26.2022.02.22.05.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 05:18:21 -0800 (PST) From: =?UTF-8?q?Ma=C3=ADra=20Canal?= To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, Hawking.Zhang@amd.com, john.clements@amd.com, tao.zhou1@amd.com, YiPeng.Chai@amd.com, luben.tuikov@amd.com, Stanley.Yang@amd.com, Dennis.Li@amd.com, mukul.joshi@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, Anthony.Koo@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, magalilemes00@gmail.com, mwen@igalia.com, isabbasso@riseup.net, =?UTF-8?q?Ma=C3=ADra=20Canal?= Subject: [PATCH 07/10] drm/amd/display: Remove unused dmub_outbox_irq_info_funcs variable Date: Tue, 22 Feb 2022 10:16:58 -0300 Message-Id: <20220222131701.356117-8-maira.canal@usp.br> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222131701.356117-1-maira.canal@usp.br> References: <20220222131701.356117-1-maira.canal@usp.br> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the unused struct irq_source_info_funcs dmub_outbox_irq_info_funcs from the file, which was declared but never hooked up. This was pointed by clang with the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn201/irq_service_dcn201.c:14= 1:43: warning: unused variable 'dmub_outbox_irq_info_funcs' [-Wunused-const-variable] static const struct irq_source_info_funcs dmub_outbox_irq_info_funcs =3D { ^ Signed-off-by: Ma=C3=ADra Canal --- .../gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c= b/drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c index aa708b61142f..45f99351a0ab 100644 --- a/drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c @@ -138,11 +138,6 @@ static const struct irq_source_info_funcs vupdate_no_l= ock_irq_info_funcs =3D { .ack =3D NULL }; =20 -static const struct irq_source_info_funcs dmub_outbox_irq_info_funcs =3D { - .set =3D NULL, - .ack =3D NULL -}; - #undef BASE_INNER #define BASE_INNER(seg) DMU_BASE__INST0_SEG ## seg =20 --=20 2.35.1 From nobody Fri Jun 26 16:02:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46526C433F5 for ; Tue, 22 Feb 2022 13:18:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232360AbiBVNTB (ORCPT ); Tue, 22 Feb 2022 08:19:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232374AbiBVNS7 (ORCPT ); Tue, 22 Feb 2022 08:18:59 -0500 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B503FC087C for ; Tue, 22 Feb 2022 05:18:30 -0800 (PST) Received: by mail-oi1-x236.google.com with SMTP id p15so14411274oip.3 for ; Tue, 22 Feb 2022 05:18:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mAHBtmtMrIy2W3kHZTCvcn0QTbxMEFt0geIwL6YcBKU=; b=nwAqmSQ2vzkc3R4j/kHBj0KGZ82kOVGgV5IRWLnHakRqcnRlMTi9QWOODmUlZsR7Rn o5IZ/CoGQE9VyVOfT0qR0kyflmOFoLDdau0bR8Qx7YSRA9/5elfqnOn/Db86bYKBkTeG 0FuUP7l9/VpIBYdcnESdf/CvwXHQQLYEOB0EVwZ28H8YarTK9fUla0EAV4crC8sBDwSK vK5gyqkTUzozj5/qxd5GkZ5NhYLamohIpzpxY8vU8KW8athgQctX6BWp5EFF6/l+oZxt TJKlTbCIQ94AB6watlHLY3iubMMGfwBc7yDlOMTMT2vEHeGzMGLD1S5iJBJVQ0MbIGtX 2MiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mAHBtmtMrIy2W3kHZTCvcn0QTbxMEFt0geIwL6YcBKU=; b=ER2oXlG8/uGeHfhqxIbDGzTogOIyzD8lRerRPne8sYjW4yFoCINCqAEewoWA3EHRUx g+Jqn9YBLA3Ivqaor1k/GvRoyozlrIUwYvB32+wTOaUJ98QHB6ZUI4xqFNZNZczS6Yzr 7g4c0tNRnySdA8oJQzsVOePHKZQXaJfda/myXVwLZndArhO3iH5lmGWT0smXdgLD5Z4r 2h0RgbXamxVyjjxCPfZr2xD3gzbrw+VPDsmUTDw39zDK1OXrpPe8mKdUktZYPqLzm/Zt 0WpSZFBB7TGPMxNrjnno/3zwYnIQMiTq2fh2czECNQk08b37oZjBMiEodQef8+C+ZDBw kWxg== X-Gm-Message-State: AOAM532QUAvgb1zVSCqdQoQzqVGlIl5hl47EhsiVmiiSl/rr9OkMVKbL aX5PSjZ3LqlnqyLsPGSGWKY5OA== X-Google-Smtp-Source: ABdhPJx8Rjrh7CF6sfeCwjuZInz6fzuEKQI/zgh6IVqdopcXaKbEaCWXyeks31/XR48U1/2OPddz9g== X-Received: by 2002:a05:6808:1646:b0:2d4:428c:659e with SMTP id az6-20020a056808164600b002d4428c659emr1885513oib.20.1645535910109; Tue, 22 Feb 2022 05:18:30 -0800 (PST) Received: from fedora.. ([187.36.236.204]) by smtp.gmail.com with ESMTPSA id c9sm6325050otd.26.2022.02.22.05.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 05:18:29 -0800 (PST) From: =?UTF-8?q?Ma=C3=ADra=20Canal?= To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, Hawking.Zhang@amd.com, john.clements@amd.com, tao.zhou1@amd.com, YiPeng.Chai@amd.com, luben.tuikov@amd.com, Stanley.Yang@amd.com, Dennis.Li@amd.com, mukul.joshi@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, Anthony.Koo@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, magalilemes00@gmail.com, mwen@igalia.com, isabbasso@riseup.net, =?UTF-8?q?Ma=C3=ADra=20Canal?= Subject: [PATCH 08/10] drm/amd/display: Remove unused variable Date: Tue, 22 Feb 2022 10:16:59 -0300 Message-Id: <20220222131701.356117-9-maira.canal@usp.br> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222131701.356117-1-maira.canal@usp.br> References: <20220222131701.356117-1-maira.canal@usp.br> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the variable clamshell_closed from the function dcn10_align_pixel_clocks. This was pointed by clang with the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2063:7: warning: variable 'clamshell_closed' set but not used [-Wunused-but-set-variable] bool clamshell_closed =3D false; ^ Signed-off-by: Ma=C3=ADra Canal --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/dr= ivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c index 8dc1afc03961..559aa45f27e7 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c @@ -2060,14 +2060,11 @@ static int dcn10_align_pixel_clocks(struct dc *dc, = int group_size, uint32_t embedded_pix_clk_100hz; uint16_t embedded_h_total; uint16_t embedded_v_total; - bool clamshell_closed =3D false; uint32_t dp_ref_clk_100hz =3D dc->res_pool->dp_clock_source->ctx->dc->clk_mgr->dprefclk_khz*10; =20 if (dc->config.vblank_alignment_dto_params && dc->res_pool->dp_clock_source->funcs->override_dp_pix_clk) { - clamshell_closed =3D - (dc->config.vblank_alignment_dto_params >> 63); embedded_h_total =3D (dc->config.vblank_alignment_dto_params >> 32) & 0x7FFF; embedded_v_total =3D --=20 2.35.1 From nobody Fri Jun 26 16:02:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92048C433F5 for ; Tue, 22 Feb 2022 13:18:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232371AbiBVNTI (ORCPT ); Tue, 22 Feb 2022 08:19:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232364AbiBVNTF (ORCPT ); Tue, 22 Feb 2022 08:19:05 -0500 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73E3EC3307 for ; Tue, 22 Feb 2022 05:18:38 -0800 (PST) Received: by mail-oi1-x230.google.com with SMTP id j2so14402121oie.7 for ; Tue, 22 Feb 2022 05:18:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5Qcw9bKKE/I3YtOTGrr/IloXYnLQKsqmcABj+F9w5gU=; b=c8BAJ4m67w3KkA6R8MfDkVVbI33E3DVexeALTYofb5l6z5ouhhOz4fZsya2JyYKPgi sat/gkEnc4YCyfXFmsZ6JizPCfEvFBKy3sUlF5kqA1LOCaburVgG3znbklkOywSEkBWA G4dNPu+gyva002SGyTd8sipk9LyYX5MNusk7OkITM29UMV63h0QVBRWT6pIy3yDo9idu jgK7nVvQLQAScQ/Glv4ROveNyabb2dodxJT5dc5JgNJIC0pXpAIFcfOgR8kMlIPvhSdn hLddDjV84SiN5tH1H6kiw2/03Ghq9xeP9fyF2dPGNWNLtG9Zvhe8yLlqRFgwIim9Y3FD ZvFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5Qcw9bKKE/I3YtOTGrr/IloXYnLQKsqmcABj+F9w5gU=; b=upiVh9BZSIuLHM/FjoemyJ6Qa4qj8ereeuWNtQZHP/mMfWe2oadrWITId9uTL/wgIq gJ4t9TDPHTDJrqB5HjJvNtUk7e1X0f7jq8b74CYm/AiShb/XYWxVFCTqR3aJcCY/J26t 8ikjJsCIS97DoJXNlvf2gPOddRua9TSrrVxkn2OU5b4BKBVLe8pRtdsN4QS2mWyKdFWd OeFoLfC9hrsO1FAwF4JbI5aptPCOjgDl/aV2HUr2LsJLvP94Ie9/WF5eOTwOrnSrcnSz DZ8c/2qTvqQgwyPsnizN5S+CjS2uyEBqYNcoVjQ/+IpxS9rFOjbqSj1B2r03xLMoJV99 DmhQ== X-Gm-Message-State: AOAM532UbO0QDHo45kyBhX/JIbrc+mG2DWlnGAsyN515YKuAxCQtgwbp KLOPuM9I87687nSvlOHBAp6JbA== X-Google-Smtp-Source: ABdhPJxEgvmm3gdK2nB9u+S/MLEXPpJvc+viMUQ4NlZZF4yuwT7VswodNQo1pHuKz6DJMA/hokhwcg== X-Received: by 2002:a05:6808:11cc:b0:2d4:9b7c:6d76 with SMTP id p12-20020a05680811cc00b002d49b7c6d76mr1803271oiv.193.1645535917778; Tue, 22 Feb 2022 05:18:37 -0800 (PST) Received: from fedora.. ([187.36.236.204]) by smtp.gmail.com with ESMTPSA id c9sm6325050otd.26.2022.02.22.05.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 05:18:37 -0800 (PST) From: =?UTF-8?q?Ma=C3=ADra=20Canal?= To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, Hawking.Zhang@amd.com, john.clements@amd.com, tao.zhou1@amd.com, YiPeng.Chai@amd.com, luben.tuikov@amd.com, Stanley.Yang@amd.com, Dennis.Li@amd.com, mukul.joshi@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, Anthony.Koo@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, magalilemes00@gmail.com, mwen@igalia.com, isabbasso@riseup.net, =?UTF-8?q?Ma=C3=ADra=20Canal?= Subject: [PATCH 09/10] drm/amd/display: Add missing prototypes to dcn201_init Date: Tue, 22 Feb 2022 10:17:00 -0300 Message-Id: <20220222131701.356117-10-maira.canal@usp.br> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222131701.356117-1-maira.canal@usp.br> References: <20220222131701.356117-1-maira.canal@usp.br> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Include the header with the prototype to silence the following clang warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_init.c:127:6: warning: no previous prototype for function 'dcn201_hw_sequencer_construct' [-Wmissing-prototypes] void dcn201_hw_sequencer_construct(struct dc *dc) ^ Signed-off-by: Ma=C3=ADra Canal --- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_init.c b/drivers/= gpu/drm/amd/display/dc/dcn201/dcn201_init.c index f1f89f93603f..1826dd7f3da1 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_init.c +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_init.c @@ -27,6 +27,7 @@ #include "dcn10/dcn10_hw_sequencer.h" #include "dcn20/dcn20_hwseq.h" #include "dcn201_hwseq.h" +#include "dcn201_init.h" =20 static const struct hw_sequencer_funcs dcn201_funcs =3D { .program_gamut_remap =3D dcn10_program_gamut_remap, --=20 2.35.1 From nobody Fri Jun 26 16:02:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C3DC433EF for ; Tue, 22 Feb 2022 13:18:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232382AbiBVNTQ (ORCPT ); Tue, 22 Feb 2022 08:19:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232365AbiBVNTL (ORCPT ); Tue, 22 Feb 2022 08:19:11 -0500 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C41C7C2E6E for ; Tue, 22 Feb 2022 05:18:45 -0800 (PST) Received: by mail-ot1-x32d.google.com with SMTP id w3-20020a056830060300b005ad10e3becaso9605266oti.3 for ; Tue, 22 Feb 2022 05:18:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m7m0+PF7saTzmzCja9hykhB/MRHQ+aIAgZTpGlXhHzw=; b=ubi5Nm/hc13TZrLP09ZiZRLp3a2ho4dHP2ehi7CFHPZ2s6iZ0e3mlYsRva1Lo79rof meuN9eLCrtEoUc2bmNz8XfqhPigO2am6hz09EKWPa5tYM4mkQjkHmB4qmkgP6wysKRSp MYcDxon4lPSJgg20sSlxVY/SDgzPwLvjUDgt3YmbkhU8/u3rhab/RurOUlKHmgC50WKg FVi5Zyc72Oxho4L2Rqgl1V2Q8nWaSRqR7Yqu9aZdVQcu8hvak1SgPfdx1yxVpsGKtzJM UXec4VOo7nf+J0oBnWsFRjoIEKP2D37OAkq6NiDruGUON4PMb3jdr1chSd9Z5zSf6E0k u7pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m7m0+PF7saTzmzCja9hykhB/MRHQ+aIAgZTpGlXhHzw=; b=bIHJpzVY93Diom+UJwXVGZQ4T3N1+3bjOaPBxNuBDKAFRUsPMxyMgTyDa7PR6CyQdo XGupff9o4idB6LeglCVCkl18j9vEwOsCUUKScbCuMSiiFjfibzSn5JlXRLlB4PORfl2h zEmuq5mWJQy4EvdwsQiniJewF6gTKX9oKADor3yHQODGGsPzIEjS2f9lr3ieY5rilPmt ozSuSezz9hJQ/zIWBgeVdzta3pm9CyD9KkxTkl73KfQzUOAIiUhjo+7Bcevz4RPxkxpG 1rYDyCxZ9HPIJEd3jgh45sAq9Kfq6a9CDJDTUf8b/sLHQ9gvvJTb9XoY6pQYrjlfIOyE IkhQ== X-Gm-Message-State: AOAM53091tzcz1WgE9zsN63EolbnWhKHUKStGeAEwm3xKmcxbS1TEm0I x7wQik/E0oeZys7PZckJtR7RPg== X-Google-Smtp-Source: ABdhPJwXb2Ih6ABCM4wFKq+J7EONDr5AujGDHaz2bmBm8K1zfSsUX01jAP2smZyZy7rVzqADpM/0Dg== X-Received: by 2002:a05:6830:40c6:b0:5a0:4cee:1e7d with SMTP id h6-20020a05683040c600b005a04cee1e7dmr8308902otu.121.1645535925058; Tue, 22 Feb 2022 05:18:45 -0800 (PST) Received: from fedora.. ([187.36.236.204]) by smtp.gmail.com with ESMTPSA id c9sm6325050otd.26.2022.02.22.05.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 05:18:44 -0800 (PST) From: =?UTF-8?q?Ma=C3=ADra=20Canal?= To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, Hawking.Zhang@amd.com, john.clements@amd.com, tao.zhou1@amd.com, YiPeng.Chai@amd.com, luben.tuikov@amd.com, Stanley.Yang@amd.com, Dennis.Li@amd.com, mukul.joshi@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, Anthony.Koo@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, magalilemes00@gmail.com, mwen@igalia.com, isabbasso@riseup.net, =?UTF-8?q?Ma=C3=ADra=20Canal?= Subject: [PATCH 10/10] drm/amd/display: Turn global functions into static functions Date: Tue, 22 Feb 2022 10:17:01 -0300 Message-Id: <20220222131701.356117-11-maira.canal@usp.br> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222131701.356117-1-maira.canal@usp.br> References: <20220222131701.356117-1-maira.canal@usp.br> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Turn previously global functions into static functions to avoid -Wmissing-prototype warnings, such as: drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50:2= 0: warning: no previous prototype for function 'to_dal_irq_source_dcn30' [-Wmissing-prototypes] enum dc_irq_source to_dal_irq_source_dcn30( ^ drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50:1: note: declare 'static' if the function is not intended to be used outside of this translation unit enum dc_irq_source to_dal_irq_source_dcn30( ^ static 1 warning generated. drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c:48= 8:6: warning: no previous prototype for function 'dcn316_clk_mgr_helper_populate_bw_params' [-Wmissing-prototypes] void dcn316_clk_mgr_helper_populate_bw_params( ^ drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c:48= 8:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void dcn316_clk_mgr_helper_populate_bw_params( ^ static 1 warning generated. Signed-off-by: Ma=C3=ADra Canal --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- .../drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c | 3 ++- .../gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c | 2 +- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 2 +- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c | 2 +- drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c | 2 +- 8 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index c9ca328d34e3..a99b92526b55 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -6362,7 +6362,7 @@ static bool is_freesync_video_mode(const struct drm_d= isplay_mode *mode, return true; } =20 -struct dc_stream_state * +static struct dc_stream_state * create_stream_for_sink(struct amdgpu_dm_connector *aconnector, const struct drm_display_mode *drm_mode, const struct dm_connector_state *dm_state, @@ -10189,7 +10189,7 @@ static void set_freesync_fixed_config(struct dm_crt= c_state *dm_new_crtc_state) { dm_new_crtc_state->freesync_config.fixed_refresh_in_uhz =3D res; } =20 -int dm_update_crtc_state(struct amdgpu_display_manager *dm, +static int dm_update_crtc_state(struct amdgpu_display_manager *dm, struct drm_atomic_state *state, struct drm_crtc *crtc, struct drm_crtc_state *old_crtc_state, diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/= drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c index 389b0cb37995..05573f073b21 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c @@ -213,7 +213,7 @@ static bool validate_dsc_caps_on_connector(struct amdgp= u_dm_connector *aconnecto return true; } =20 -bool retrieve_downstream_port_device(struct amdgpu_dm_connector *aconnecto= r) +static bool retrieve_downstream_port_device(struct amdgpu_dm_connector *ac= onnector) { union dp_downstream_port_present ds_port_present; =20 diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios= _smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu= .c index 06bab24d8e27..450eaead4f20 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c @@ -101,7 +101,8 @@ static uint32_t rv1_smu_wait_for_response(struct clk_mg= r_internal *clk_mgr, unsi return res_val; } =20 -int rv1_vbios_smu_send_msg_with_param(struct clk_mgr_internal *clk_mgr, un= signed int msg_id, unsigned int param) +static int rv1_vbios_smu_send_msg_with_param(struct clk_mgr_internal *clk_= mgr, + unsigned int msg_id, unsigned int param) { uint32_t result; =20 diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c= b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c index ffd3d5cb9871..02a59adff90d 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c @@ -485,7 +485,7 @@ static unsigned int find_clk_for_voltage( return clock; } =20 -void dcn316_clk_mgr_helper_populate_bw_params( +static void dcn316_clk_mgr_helper_populate_bw_params( struct clk_mgr_internal *clk_mgr, struct integrated_info *bios_info, const DpmClocks_316_t *clock_table) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c b/d= rivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c index fd6497fd2dc5..128614dff108 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c @@ -111,7 +111,7 @@ static uint32_t dcn316_smu_wait_for_response(struct clk= _mgr_internal *clk_mgr, u return res_val; } =20 -int dcn316_smu_send_msg_with_param( +static int dcn316_smu_send_msg_with_param( struct clk_mgr_internal *clk_mgr, unsigned int msg_id, unsigned int param) { diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gp= u/drm/amd/display/dc/core/dc_resource.c index 19b56f9acf84..29ab67f42d92 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c @@ -1622,7 +1622,7 @@ bool dc_add_all_planes_for_stream( return add_all_planes_for_stream(dc, stream, &set, 1, context); } =20 -bool is_timing_changed(struct dc_stream_state *cur_stream, +static bool is_timing_changed(struct dc_stream_state *cur_stream, struct dc_stream_state *new_stream) { if (cur_stream =3D=3D NULL) diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c b= /drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c index c4b067d01895..93c31111500b 100644 --- a/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c @@ -40,7 +40,7 @@ =20 #include "ivsrcid/dcn/irqsrcs_dcn_1_0.h" =20 -enum dc_irq_source to_dal_irq_source_dcn20( +static enum dc_irq_source to_dal_irq_source_dcn20( struct irq_service *irq_service, uint32_t src_id, uint32_t ext_id) diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c b= /drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c index 0b68c08fac3f..ac0c6a62d17b 100644 --- a/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c @@ -47,7 +47,7 @@ =20 #include "ivsrcid/dcn/irqsrcs_dcn_1_0.h" =20 -enum dc_irq_source to_dal_irq_source_dcn30( +static enum dc_irq_source to_dal_irq_source_dcn30( struct irq_service *irq_service, uint32_t src_id, uint32_t ext_id) --=20 2.35.1