From nobody Sat Jun 27 21:23:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F160CC433EF for ; Sun, 20 Feb 2022 15:15:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244138AbiBTPQP (ORCPT ); Sun, 20 Feb 2022 10:16:15 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244057AbiBTPQM (ORCPT ); Sun, 20 Feb 2022 10:16:12 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5382434BA8 for ; Sun, 20 Feb 2022 07:15:51 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id n8so8119623wms.3 for ; Sun, 20 Feb 2022 07:15:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PTxil4tJAf7UWV/C+fdAyAmzi/s2rC1+JHkkEn5O+kc=; b=W6jE4/hlEtzS/97aFCDxz1egBSagCoiMlFBkAw2mMapYpV/64jueKf+g2IXT0dq0oU o+seqx2E98v25O3UpymfVb0sAgYFKD1QOcVW5fc6qRbIYDaN4W5y2u6bHr61bcBjF8Ow DyUvoFSnah5ig8CNQEkccmSA7p9e7Ks566Gv/+aeepskukN+FepVgVZwyOxnjvhftW46 TfjSFqND32K6J8e/+emj4jqct/ZPJcDayv1zTyhC5Ay6V9HBphWnE6SNKHgGR2UHcBlU KUeTQp5VfD3H/Q+e+A+Bit+PvOJigv9+HeFz5/ZUpobFeq7fypqL9uhQlgQ9n77DqvyS UoLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PTxil4tJAf7UWV/C+fdAyAmzi/s2rC1+JHkkEn5O+kc=; b=5VXuEuz5vJioMkhVPUBX6fLu/4O6MNNnmRDfh7AZai2GSh1Y5q4Xk50/nJb3N/FSb4 llA+Ikyk5BqHA3qKo4DNSeiqNGILKVHmyzCkwjBmk5qeFFZhyhb//Bxvsmo5+52CAUet ar4y9k/WUAZrZ37wulCrdkqFN2+WUj2uANQbgHXCj52eWd4LMJP4i36xtv20KY386Uqo e+atKp4Mbgzuq2k4B/OClRhMiCuWcOhrTi9FcdvJTgE/felofs4ILskoFE3c3MQV1SdW EYAXaIn/TRykVPlZbWr6h1iiMptd3Pu+ElbK4VxhfHJItNtekeFlopCxOIy7asyA+QCz tXGA== X-Gm-Message-State: AOAM533A9QMpG27efFMSnYehQQI1xgjOta6O6YYZj7kF5FfJbpWglD/q MHLVVfuMZwXm0m/Tu6T921K0lA== X-Google-Smtp-Source: ABdhPJxodz3Wa8AyRRUgIvZmgYEH8Ien0j7scKm5f9ldW92NAk//RZkYT9xo6oUiayXz8T6X7H/OjQ== X-Received: by 2002:a05:600c:2f01:b0:37b:aa49:3864 with SMTP id r1-20020a05600c2f0100b0037baa493864mr14495015wmn.74.1645370149750; Sun, 20 Feb 2022 07:15:49 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id h7sm28687749wru.41.2022.02.20.07.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 07:15:49 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Andy Shevchenko , Srinivas Kandagatla Subject: [PATCH 01/13] nvmem: core: Remove unused devm_nvmem_unregister() Date: Sun, 20 Feb 2022 15:15:15 +0000 Message-Id: <20220220151527.17216-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> References: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko There are no users and seems no will come of the devm_nvmem_unregister(). Remove the function and remove the unused devm_nvmem_match() along with it. Signed-off-by: Andy Shevchenko Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 22 ---------------------- include/linux/nvmem-provider.h | 8 -------- 2 files changed, 30 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 9fd1602b539d..39cb659ea580 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -945,28 +945,6 @@ struct nvmem_device *devm_nvmem_register(struct device= *dev, } EXPORT_SYMBOL_GPL(devm_nvmem_register); =20 -static int devm_nvmem_match(struct device *dev, void *res, void *data) -{ - struct nvmem_device **r =3D res; - - return *r =3D=3D data; -} - -/** - * devm_nvmem_unregister() - Unregister previously registered managed nvmem - * device. - * - * @dev: Device that uses the nvmem device. - * @nvmem: Pointer to previously registered nvmem device. - * - * Return: Will be negative on error or zero on success. - */ -int devm_nvmem_unregister(struct device *dev, struct nvmem_device *nvmem) -{ - return devres_release(dev, devm_nvmem_release, devm_nvmem_match, nvmem); -} -EXPORT_SYMBOL(devm_nvmem_unregister); - static struct nvmem_device *__nvmem_device_get(void *data, int (*match)(struct device *dev, const void *data)) { diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h index c9a3ac9efeaa..50caa117cb62 100644 --- a/include/linux/nvmem-provider.h +++ b/include/linux/nvmem-provider.h @@ -135,8 +135,6 @@ void nvmem_unregister(struct nvmem_device *nvmem); struct nvmem_device *devm_nvmem_register(struct device *dev, const struct nvmem_config *cfg); =20 -int devm_nvmem_unregister(struct device *dev, struct nvmem_device *nvmem); - void nvmem_add_cell_table(struct nvmem_cell_table *table); void nvmem_del_cell_table(struct nvmem_cell_table *table); =20 @@ -155,12 +153,6 @@ devm_nvmem_register(struct device *dev, const struct n= vmem_config *c) return nvmem_register(c); } =20 -static inline int -devm_nvmem_unregister(struct device *dev, struct nvmem_device *nvmem) -{ - return -EOPNOTSUPP; -} - static inline void nvmem_add_cell_table(struct nvmem_cell_table *table) {} static inline void nvmem_del_cell_table(struct nvmem_cell_table *table) {} =20 --=20 2.21.0 From nobody Sat Jun 27 21:23:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C827DC433FE for ; Sun, 20 Feb 2022 15:15:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244149AbiBTPQT (ORCPT ); Sun, 20 Feb 2022 10:16:19 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244119AbiBTPQN (ORCPT ); Sun, 20 Feb 2022 10:16:13 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2957034BAA for ; Sun, 20 Feb 2022 07:15:52 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id f3so22705519wrh.7 for ; Sun, 20 Feb 2022 07:15:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mKYmgngOL/OskIpQJEL8+lpXd5cce8putN6D5KkxR1I=; b=XmEOTetEPq+ebguMkv5DCUekep7Ry8fBV+KVFTEx0YqVaaE09HLIEkimDlqeRwcQ3K xIyt9M6DOVhFR4sb3XWJWvzkm75+w82tfavjCjbAFHW1kLBN7/Idy1YnacNC/jsZds1G 5x2r5KF5ECu4cAOTyDtKLm9fstLjtEc4gUD2Yx1mcJhztjq1qmxz5WZK0X8o57cf0+Jd AaLsHn/FatiTnsETIArlKDc6e0i+zDsjZQBJ6GBVo4IUi33Dy24KfdIC6GPLN1IzBW9p qzDG0BUqv6xRzhm6rRUFr3/DvqFFc0ehjxlttw8eB6KoAYiniGGlw9JePLU/9eXGxegl 5mZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mKYmgngOL/OskIpQJEL8+lpXd5cce8putN6D5KkxR1I=; b=2GEh2rCpBcN+XaKsGJtdvO6LzJYe4abysRlko8582m7RbVFuomG4fSp1IPoGvyWGmu Jy+raz362GV0OiI9wffdjiB3Zf6s3Hmm0QhH5LQvMs5sRLS4fr85CacRi0AZ1Lt/0gr+ GriuqCguVXUgprbx3YRJvs6ANPfJmqkq9NGbccZ5dYlczWHKH519MsS2N9JhLpZkFmTV VuWKblX0HLUX/DRJPOZf57leUrz9AFrPf+uIfXwloJXkljZuGfL8f79Y3hEBXNRKw/Y9 3RbJhrc6wbdtj5ljxwrTUqpFiVBv3CGZTxpZnsBCWfkBA/yyFfStLIDPODCQQunrwxwC kJnA== X-Gm-Message-State: AOAM530CXEHZOBgAFdEDqVV10eLgwUZ3JwvVUUxEkpiTODPNKui8MVMY I+Q3ug5x0xU7b8n3p049m3SKlW8ozCPz2A== X-Google-Smtp-Source: ABdhPJyApZq+MHcbJ0UlvMxzfuc+zyXoO8IQ2MemQaQYnY2bbCTg1zOX7dGEckQgfYvtdYf0hG/Dlw== X-Received: by 2002:adf:e98d:0:b0:1e7:5ea6:7222 with SMTP id h13-20020adfe98d000000b001e75ea67222mr12537933wrm.579.1645370150766; Sun, 20 Feb 2022 07:15:50 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id h7sm28687749wru.41.2022.02.20.07.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 07:15:50 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Andy Shevchenko , Srinivas Kandagatla Subject: [PATCH 02/13] nvmem: core: Use devm_add_action_or_reset() Date: Sun, 20 Feb 2022 15:15:16 +0000 Message-Id: <20220220151527.17216-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> References: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko Slightly simplify the devm_nvmem_register() by using the devm_add_action_or_reset(). Signed-off-by: Andy Shevchenko Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 39cb659ea580..327c88c432f0 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -907,9 +907,9 @@ void nvmem_unregister(struct nvmem_device *nvmem) } EXPORT_SYMBOL_GPL(nvmem_unregister); =20 -static void devm_nvmem_release(struct device *dev, void *res) +static void devm_nvmem_unregister(void *nvmem) { - nvmem_unregister(*(struct nvmem_device **)res); + nvmem_unregister(nvmem); } =20 /** @@ -926,20 +926,16 @@ static void devm_nvmem_release(struct device *dev, vo= id *res) struct nvmem_device *devm_nvmem_register(struct device *dev, const struct nvmem_config *config) { - struct nvmem_device **ptr, *nvmem; - - ptr =3D devres_alloc(devm_nvmem_release, sizeof(*ptr), GFP_KERNEL); - if (!ptr) - return ERR_PTR(-ENOMEM); + struct nvmem_device *nvmem; + int ret; =20 nvmem =3D nvmem_register(config); + if (IS_ERR(nvmem)) + return nvmem; =20 - if (!IS_ERR(nvmem)) { - *ptr =3D nvmem; - devres_add(dev, ptr); - } else { - devres_free(ptr); - } + ret =3D devm_add_action_or_reset(dev, devm_nvmem_unregister, nvmem); + if (ret) + return ERR_PTR(ret); =20 return nvmem; } --=20 2.21.0 From nobody Sat Jun 27 21:23:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD6C6C433EF for ; Sun, 20 Feb 2022 15:16:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244161AbiBTPQV (ORCPT ); Sun, 20 Feb 2022 10:16:21 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244126AbiBTPQO (ORCPT ); Sun, 20 Feb 2022 10:16:14 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14EE634BB1 for ; Sun, 20 Feb 2022 07:15:53 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id c192so8135839wma.4 for ; Sun, 20 Feb 2022 07:15:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AjbCoFPHwgXlgVhaHAoW47X9tb9L1pRYHiXqltbW+iI=; b=F7r6smAuasKrsIW1o21RG/D+0ZGoEoQM/S5iu5VNpy7tAQX5NpGfvAK06AeIDggyIc UPfKFtqX+dJch1F+xhLRrb/8pb/HLnjAPOwXve0HvxVYVJzFaEkqIKsb397NCVoxjwFP X+KjLN/xe5vc9A9I6EE4zBX+Ix666ReazrzSxgJDqAS7FSuh+6IFq7DA1BDzcBbFxdam ZzRtUz+UVTavm2KR6y/4jFIV0px2UjsFDVqStdE9D1zyVv0RcVvZUSYHwwo/3R5gkHJN 1Tz9zxfAtNAPYCbnREaWm9v5nst48Jkgq7oobG+KhagFTd9JKoHyJAPtv5OT+leL5mAP 69pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AjbCoFPHwgXlgVhaHAoW47X9tb9L1pRYHiXqltbW+iI=; b=zc68OR1FhVOaw9SZc4ehg4TgQiF1qTd+wChQZvZSKDuMHbNkced78ZOIEYsNnzR/61 e+h4xJNMylyfrNCvnQh5oTExR5rt5sB1DjwcqRjk4qdN9XOaYBpjDLVXgAZq3Jm57YLn 7pX+pBe63nGpB6YZ/Z0Ld00AXFyXDsp7XOwPdjyxrkEACQFVR6TdDuvyO3Kkzx3/R1j9 iLLeV6Ou8AVOecGQflgQ/C3bZI5nyfY5/PX5lWuJ1bT3zpd8IzAFNiXTK1rgrs1VraZV MQj1AopEgbbCBzAXgwbvI2X9s5+qOolrh7cJtIlf6/lxYzk1+Qtz00G06m/Qtzb9wRyF 2iIg== X-Gm-Message-State: AOAM5334SDmZB7udNeRb+e38SEwj5B1qaubD6Tljh/TrXDYuOcNCORFh JbIB8J0aZZgK1iWhWfnbeNRpe8I6HP593A== X-Google-Smtp-Source: ABdhPJx1hTDBEGOH7VBzcafFAueFaoRh011MCubD53+Vy4xLw1ZjZeOvHwEgehH3ZGp4ovbM+qeNLw== X-Received: by 2002:a05:600c:3512:b0:352:d502:bd0c with SMTP id h18-20020a05600c351200b00352d502bd0cmr17751784wmq.164.1645370151696; Sun, 20 Feb 2022 07:15:51 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id h7sm28687749wru.41.2022.02.20.07.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 07:15:51 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Andy Shevchenko , Srinivas Kandagatla Subject: [PATCH 03/13] nvmem: core: Check input parameter for NULL in nvmem_unregister() Date: Sun, 20 Feb 2022 15:15:17 +0000 Message-Id: <20220220151527.17216-4-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> References: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko nvmem_unregister() frees resources and standard pattern is to allow caller to not care if it's NULL or not. This will reduce burden on the callers to perform this check. Signed-off-by: Andy Shevchenko Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 327c88c432f0..f58d9bc7aa08 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -903,7 +903,8 @@ static void nvmem_device_release(struct kref *kref) */ void nvmem_unregister(struct nvmem_device *nvmem) { - kref_put(&nvmem->refcnt, nvmem_device_release); + if (nvmem) + kref_put(&nvmem->refcnt, nvmem_device_release); } EXPORT_SYMBOL_GPL(nvmem_unregister); =20 --=20 2.21.0 From nobody Sat Jun 27 21:23:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5470DC433EF for ; Sun, 20 Feb 2022 15:16:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244183AbiBTPQY (ORCPT ); Sun, 20 Feb 2022 10:16:24 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244137AbiBTPQP (ORCPT ); Sun, 20 Feb 2022 10:16:15 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07DEB34BA8 for ; Sun, 20 Feb 2022 07:15:54 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id l123-20020a1c2581000000b0037b9d960079so11963000wml.0 for ; Sun, 20 Feb 2022 07:15:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Pf5vtF70QE670/zy9x2D9iO6InpzY2CVU4NmEaKqKg8=; b=BMMOl1xMnBQf1ucf5/yvGfCNwbTEvqry0jwNgBq0Xd4MhaMPMgdCHZ5+lp3hqFomhC 3aur/ibsios9v6rS8YHQ4vntpZhwSv+vndrGjmxW21rBa7+htjyFDJ6yKE4o6HDj7/bp q+FkxLqcUUo50jZXZg8Q34upkxT6PcNxRLYLsRaufFIyyQIKjW+AegEuSXS8WdQ3pziN 6/pSO1m8w1HgiHRQqq51JtfA40ZLod5uuxq8ooHDLWYc4KNn1FFq39f9quZ0ATkxwzcI jtmg2xjAuB713l1gCbsGrpThpw5KnYiu5EgidTG+C/qdT+kt88B3k0cP/jm0WS4rxcCM f24w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Pf5vtF70QE670/zy9x2D9iO6InpzY2CVU4NmEaKqKg8=; b=Oc2QXPdn3mLW5zHg/GQRJVvEBJpIRMBSqCnFFHAEaEfGKnotHH9uvrz4QEUMpbNq3G Fehf+iO4PstnEeNtJH2OXXQQfWXJe20hL8CDsgAjnv7QAuvS3S7oU6/UQUx0/6RIdrvT RLBE6qMVzwJXKPuAvb4Qz8Av1OBKEApHOKXtnrfbdg3xylWKCnGZ5kZDrVy0MqpP6oiz 8lqHpKCT8HgJshm9lbEvJbS7aDhCcAVQUsWk4FwH6OYcrz8MKOrbM88n4dtDkcfuPek4 eJ3eTYWwwMuz/zkgLXOh0x8M1qzRvGVScd7VPW55hEyaxoucT7M/RzNYP9qVLzbla2b3 iQ7w== X-Gm-Message-State: AOAM533zfwmsm3QQvoqesTOdla4jiVbHELdy3k0qvutnirLIU2R+/G76 /MFNEVEn6+vTsB1kalttZNzqgoQcOYi92A== X-Google-Smtp-Source: ABdhPJzDWjwCBaTvu+yfVT9JaXW+sRUidaWczhorhNHafST4svo0ybZoy+srqTY9RNNzsRg/3AtYng== X-Received: by 2002:a05:600c:3c8e:b0:350:5358:99bb with SMTP id bg14-20020a05600c3c8e00b00350535899bbmr15071548wmb.13.1645370152634; Sun, 20 Feb 2022 07:15:52 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id h7sm28687749wru.41.2022.02.20.07.15.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 07:15:52 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 04/13] nvmem: qfprom: fix kerneldoc warning Date: Sun, 20 Feb 2022 15:15:18 +0000 Message-Id: <20220220151527.17216-5-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> References: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch fixes below kernel doc warning, warning: expecting prototype for qfprom_efuse_reg_write(). Prototype was for qfprom_reg_write() instead No code changes. Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/qfprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c index c500d6235bf6..061293f9136b 100644 --- a/drivers/nvmem/qfprom.c +++ b/drivers/nvmem/qfprom.c @@ -244,7 +244,7 @@ static int qfprom_enable_fuse_blowing(const struct qfpr= om_priv *priv, } =20 /** - * qfprom_efuse_reg_write() - Write to fuses. + * qfprom_reg_write() - Write to fuses. * @context: Our driver data. * @reg: The offset to write at. * @_val: Pointer to data to write. --=20 2.21.0 From nobody Sat Jun 27 21:23:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB911C433F5 for ; Sun, 20 Feb 2022 15:16:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244186AbiBTPQ0 (ORCPT ); Sun, 20 Feb 2022 10:16:26 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244139AbiBTPQQ (ORCPT ); Sun, 20 Feb 2022 10:16:16 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E71B134BB2 for ; Sun, 20 Feb 2022 07:15:54 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id e3so22917506wra.0 for ; Sun, 20 Feb 2022 07:15:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ywyf682k4IPGploknsa9+UktKQX+UFNPY0KByqqQCSI=; b=o6DIr3PEoz7jjmXRjayAjxTW780wquOUN9ih6DCVxjsayQqPV8fTDjC+i1XWFrj9V6 bkpDTiPWiGQKxs2GwxzcK1OjSSBR9RBFolfE4NPf8/cfnqxeoqTzbsxuFlg8ziNmmcod R8oKKTN0znXBrmp8nvN7ZvgDFJbu8uT/SI/18Hc0oVSp3wKn8DLMoYQUmomJBvrnSB/y oIgj5bFOjBMzi406/QclSTHw7qagSNwCLDhwyClm9lmKswDYiarTDeOcvi0HGvSON6OU Lj5FK6rMGn6nYl5qxDMKMuI0hvgO+DCTa2msgSD+e97KSfNgvR5G5uTiB6T49v7XAZtk mEhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ywyf682k4IPGploknsa9+UktKQX+UFNPY0KByqqQCSI=; b=7XhuUr5irewndie9tEoxp1WhRn1OXWOvKBvNJotTQ0qcLDpy2Hch+qfw5hNIEP2h2R ADM9hsjapsuW5ZQNQrnDlgE9nJpegfLVdYA9ywqkw26DxP3lqG2+SAgWV1wZzpYNS5j7 r6RPwbKL2wsd/Ig9DV5NdzClvEAvXJN1t+z9VkaoPXFPbfz6tVL31qDl1ImTMt/NNYNP prQ9NQrj2W6BKT+NBTpxR7BXVx+bWdj5xbasJBmtC24lpqgWJ02ZYLRE9D/NnibeHRJk ohz5THE+MCT1ozc+MFG0bbI6ypAVs/vj8Fiez92CvuEmayvUBYF6up3fxvwB+4iOrVJD n6uw== X-Gm-Message-State: AOAM532qY56kmTB21TF4UzWlQI9KL/irZx9ygT+pmyz9iJT7K5yXUAFu FLpahXDf0FZAax0ouCOn3i173A== X-Google-Smtp-Source: ABdhPJzTxc+CVIjKg2DGLKaRiJ4oA8QkSIXrKXYdvKOmXEPSOM6CUFvBbb+XwyFmW+nsC0ZiQrBcAA== X-Received: by 2002:a05:6000:18c3:b0:1e5:82d3:e4e2 with SMTP id w3-20020a05600018c300b001e582d3e4e2mr12770894wrq.575.1645370153529; Sun, 20 Feb 2022 07:15:53 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id h7sm28687749wru.41.2022.02.20.07.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 07:15:53 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Samuel Holland , Rob Herring , Srinivas Kandagatla Subject: [PATCH 05/13] dt-bindings: nvmem: SID: Add compatible for D1 Date: Sun, 20 Feb 2022 15:15:19 +0000 Message-Id: <20220220151527.17216-6-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> References: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Samuel Holland D1 has a SID like other Allwinner SoCs, but with a unique eFuse layout. Add a new compatible string for it. Signed-off-by: Samuel Holland Acked-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- .../devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-si= d.yaml b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.ya= ml index 6687ab720304..e558587ff885 100644 --- a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml +++ b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml @@ -20,6 +20,7 @@ properties: - const: allwinner,sun7i-a20-sid - const: allwinner,sun8i-a83t-sid - const: allwinner,sun8i-h3-sid + - const: allwinner,sun20i-d1-sid - const: allwinner,sun50i-a64-sid - items: - const: allwinner,sun50i-a100-sid --=20 2.21.0 From nobody Sat Jun 27 21:23:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D06BC433FE for ; Sun, 20 Feb 2022 15:16:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244198AbiBTPQ3 (ORCPT ); Sun, 20 Feb 2022 10:16:29 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244144AbiBTPQR (ORCPT ); Sun, 20 Feb 2022 10:16:17 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D71B234BB3 for ; Sun, 20 Feb 2022 07:15:55 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id o24so22874445wro.3 for ; Sun, 20 Feb 2022 07:15:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BNiRHWO4HLFv+UVov8z2shlE8WSMm7D0PfvatmCO+8U=; b=N7V/I4j8PzHey8p1AFUCuSEr7LELjsKsOjoLstg9JmC3mbmQZBvRF2HsdcsZ44Uk28 PiWJ1AT3fVDAzuZQDGRHBM6Ygya52JFzQTgts4HiXfkOYd0Rh29bYWOESrgFeAv5Lwqq KyZ2WYfkZrcbjSVyCeXeCPSAHL7XpukcGr8r/MsB6lGelZ19Ff3OE8/LokJ1xlwwNzGL tbOQtM1WMusfMwgleCOG6gEwcpFTJcI9brqYbHknliwvuus1kvY6sQ8kJZjkd/JEMRkV TDi+6leGWaWkSdimIsx+ko5oF7R0k6FzRvcxsPhDSshJql+am3HBoevr4aqgNBCVjTdb CRkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BNiRHWO4HLFv+UVov8z2shlE8WSMm7D0PfvatmCO+8U=; b=22y9lE0zI8DKNUh3FhnsgRnuBA71G188bHDvftutd7vPQLH+5oo33ORF91kp7KaLLS C0I25BlQRn4RWn6OtBZySqyhK6v+RAhqXQLcJjOaE+WepwrbrfslaB4+YmE1TMnoLtjg +C5LqoztmWrozMVdbeVxIKIK80308S5iwv233Ch1riDqnTPcujvzTaqwfPQllhexRERd DgT716bGHp6D3KhI4k9eSmVGiHOyYgLzrkL1DpMyuAfzjGmFGOUiXCvted5BvTthZNks S2LWG2QQxUHRPPc7H8Cg39ABUZCtski+92Q1q+P0vfp/IrwqhZwf9HFwiD08Pa7M2M7L elOQ== X-Gm-Message-State: AOAM533c6L634JIUTH7aYGunbTMmc4KhigHiNkhJ71g+NbAR+NKI63/h DmJLcoKQqXDP0LNhRQMyXYFCjtkg7XSVPw== X-Google-Smtp-Source: ABdhPJyakR4a/iE02zTmqIAPt2wTWDG+ZbxmeT8aPIAwTrqaIBHT0QewXJ0HBLy6kQ7DYlM0sbtgqg== X-Received: by 2002:adf:eace:0:b0:1e7:6884:45a5 with SMTP id o14-20020adfeace000000b001e7688445a5mr12733333wrn.197.1645370154500; Sun, 20 Feb 2022 07:15:54 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id h7sm28687749wru.41.2022.02.20.07.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 07:15:54 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Samuel Holland , Srinivas Kandagatla Subject: [PATCH 06/13] nvmem: sunxi_sid: Add support for D1 variant Date: Sun, 20 Feb 2022 15:15:20 +0000 Message-Id: <20220220151527.17216-7-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> References: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Samuel Holland D1 has a smaller eFuse block than some other recent SoCs, and it no longer requires a workaround to read the eFuse data. Signed-off-by: Samuel Holland Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/sunxi_sid.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c index 275b9155e473..5750e1f4bcdb 100644 --- a/drivers/nvmem/sunxi_sid.c +++ b/drivers/nvmem/sunxi_sid.c @@ -184,6 +184,11 @@ static const struct sunxi_sid_cfg sun8i_h3_cfg =3D { .need_register_readout =3D true, }; =20 +static const struct sunxi_sid_cfg sun20i_d1_cfg =3D { + .value_offset =3D 0x200, + .size =3D 0x100, +}; + static const struct sunxi_sid_cfg sun50i_a64_cfg =3D { .value_offset =3D 0x200, .size =3D 0x100, @@ -200,6 +205,7 @@ static const struct of_device_id sunxi_sid_of_match[] = =3D { { .compatible =3D "allwinner,sun7i-a20-sid", .data =3D &sun7i_a20_cfg }, { .compatible =3D "allwinner,sun8i-a83t-sid", .data =3D &sun50i_a64_cfg }, { .compatible =3D "allwinner,sun8i-h3-sid", .data =3D &sun8i_h3_cfg }, + { .compatible =3D "allwinner,sun20i-d1-sid", .data =3D &sun20i_d1_cfg }, { .compatible =3D "allwinner,sun50i-a64-sid", .data =3D &sun50i_a64_cfg }, { .compatible =3D "allwinner,sun50i-h5-sid", .data =3D &sun50i_a64_cfg }, { .compatible =3D "allwinner,sun50i-h6-sid", .data =3D &sun50i_h6_cfg }, --=20 2.21.0 From nobody Sat Jun 27 21:23:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16DB9C433EF for ; Sun, 20 Feb 2022 15:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244212AbiBTPQc (ORCPT ); Sun, 20 Feb 2022 10:16:32 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244162AbiBTPQW (ORCPT ); Sun, 20 Feb 2022 10:16:22 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3185834BBA for ; Sun, 20 Feb 2022 07:15:57 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id p9so22804741wra.12 for ; Sun, 20 Feb 2022 07:15:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CoWqM2l43A/te3Ur17qgQhFWUP8Vq6EXRZYnZTGBH/g=; b=SPvPyJ3sGYx36ctC/gjYjNfy5zsbC6v5XjQQZOE+TRYSIEZO8jaASlc0SrpqB9zEUe 6JWanLcklXJV8BcF4eOSjz9e2tW5OLebkQ4qoyxBUj9ZWk35mwKbSctcFyuKZvn2ro75 Tn7QrYmz5MNW+m00iUKPHz3NfRtdjnaO9n2gHTbh0962pxwPptJY0tOhn/vxj6FlsjLQ cUi3qjENX4CVrGB8B9UjNJ+eMFZbScpEPapvlNEPURSZxEH1D7TBdZM9tWyMBhXgjF35 /UliI1CLraylFz2h7MHcLSJVpgvbZkYC5v5Ti7oYotxaI0EMJQckVCyTcbp3CuVl9rDF fCWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CoWqM2l43A/te3Ur17qgQhFWUP8Vq6EXRZYnZTGBH/g=; b=ef0IvHZo046GdYp0v0dg5bv3M8ZgENudN/VBd/wA4yJfKO1ZaJemEAOiUo4kkyQXqh SbT6xbWzle5rAIs4mnAcNlOKpQQhkEbSwvjOFqI4fnHHJn1JYXMJInBrA0gHW12S81bw g7wY/WPboPu3JhnsBMAQ9nFqwkUkUN1jZDyyQpZedFV7XVEitRsayrfGoTOL0HA3wDJ4 LI/yDTZS2tq4sg0na/VNqdqvwuOiOE82nLfj+Y2sQoOoRIXsHG439X4UJClUWnIGWQFn OvzdoGC6rWkM2N55jmxOmU4n9KekIO+8sVa25XmYQ3dW/wtKhXPGIxImX0v35zXJCHIa OKkw== X-Gm-Message-State: AOAM532kP5RqANcClDAuWwMFi9gUsck3J5Z+scdkNO0zk5IyM9Und9zy +OYNRyDw+CFNKgJRb9qA8Dvk7g== X-Google-Smtp-Source: ABdhPJxX/7lBlES0VDcR5um2H0CrrDMY/XCV+ngbPFAqPEGvYRF82EU1+uBVBsUjGiVKU9sxYma1wg== X-Received: by 2002:a5d:6dab:0:b0:1ea:1c5d:904d with SMTP id u11-20020a5d6dab000000b001ea1c5d904dmr1815499wrs.51.1645370155769; Sun, 20 Feb 2022 07:15:55 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id h7sm28687749wru.41.2022.02.20.07.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 07:15:54 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Xiaoke Wang , Martin Blumenstingl , Srinivas Kandagatla Subject: [PATCH 07/13] nvmem: meson-mx-efuse: replace unnecessary devm_kstrdup() Date: Sun, 20 Feb 2022 15:15:21 +0000 Message-Id: <20220220151527.17216-8-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> References: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Xiaoke Wang Replace unnecessary devm_kstrdup() so to avoid redundant memory allocation. Suggested-by: Martin Blumenstingl Signed-off-by: Xiaoke Wang Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/meson-mx-efuse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/nvmem/meson-mx-efuse.c b/drivers/nvmem/meson-mx-efuse.c index 07c9f38c1c60..13eb14316f46 100644 --- a/drivers/nvmem/meson-mx-efuse.c +++ b/drivers/nvmem/meson-mx-efuse.c @@ -209,8 +209,7 @@ static int meson_mx_efuse_probe(struct platform_device = *pdev) if (IS_ERR(efuse->base)) return PTR_ERR(efuse->base); =20 - efuse->config.name =3D devm_kstrdup(&pdev->dev, drvdata->name, - GFP_KERNEL); + efuse->config.name =3D drvdata->name; efuse->config.owner =3D THIS_MODULE; efuse->config.dev =3D &pdev->dev; efuse->config.priv =3D efuse; --=20 2.21.0 From nobody Sat Jun 27 21:23:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E868CC433EF for ; Sun, 20 Feb 2022 15:16:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244203AbiBTPQf (ORCPT ); Sun, 20 Feb 2022 10:16:35 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244133AbiBTPQW (ORCPT ); Sun, 20 Feb 2022 10:16:22 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E33834BBE for ; Sun, 20 Feb 2022 07:15:58 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id d3so7198198wrf.1 for ; Sun, 20 Feb 2022 07:15:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y9birgiS9Q1LdTibjI1qpS+INxYgCkhdm/5O40p8Ub8=; b=FGBW9qbGDlq6nxvPRK/HUbQ5I8vPFFMIt5zeUvx+pbnwmJrseZRG6W8Gs/hOfk86Xj mBlFn5pusTk67QxaaetMyGemCImqfFJBThhEHToSwuoGQIGvv+H/9hwp92AbctKRUgNx ZPCIIGtGZcKMUZ6hOotftwXRLJb9nkkZRNrpn/5o7zcl9AXD8WVAir0avqdV6Hju64hi cABuODa7KLHyCNjyGfeP6ybVKUAwCu2jzGZvXXk4seuRevdO4nMABA/C6ZsHJgkpnY9d 4B477obfb+Qy4SLCvljH+p1d5XvyfMZLDQ8xKnQD79GAzvzNeTaRzD0RG6Ua9GvJDd+x rtJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y9birgiS9Q1LdTibjI1qpS+INxYgCkhdm/5O40p8Ub8=; b=NdIuXg/PI9uErERyJY2pLt4aLmLZ9Y9SNVLO+2yT6MivbKGj0uJ5BObKsubOCgkIys uXt2IUVaetIQ09GpYMXpaQzExOfU6Gmjgw2ioUnznXA0lbJv+xnHu4CS9R5rzYGKz7Ls LXe7f90eZFzCagd0TL56Glew08T8MWPlKrDEX6ZjBP7pUo3RAE3rsrgmiUTHKfdZjUKb /OnF+CokJsLUxIsHegW9QKpgkncBkJu9aJjQThKEiUyb8Y/Z2dqCL3gP01XibK5TC1ZU qQEfcEM3GcmMZEhEr2cYd+kBMLV8cZ59OWihtQbZoFju7qggr/8gliwc/e+GigkR5vBY xmSQ== X-Gm-Message-State: AOAM530GoDUaglNKCTubxHPOZEnxENvqmxgkveGt1NvbZsUW6lPUiggI Johm1l7bQgD8F/EstzXNsj975A== X-Google-Smtp-Source: ABdhPJz4wOMRsj8Zdwrw44uV2D14PB78jcXKSQf1Girb0abQRhKGiEDFC6UTMpJHOMLCM3MrVkc51Q== X-Received: by 2002:a5d:6b4c:0:b0:1e6:8ece:62e8 with SMTP id x12-20020a5d6b4c000000b001e68ece62e8mr12856136wrw.201.1645370156776; Sun, 20 Feb 2022 07:15:56 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id h7sm28687749wru.41.2022.02.20.07.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 07:15:56 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Michael Walle , Rob Herring , Srinivas Kandagatla Subject: [PATCH 08/13] dt-bindings: nvmem: add fsl,layerscape-sfp binding Date: Sun, 20 Feb 2022 15:15:22 +0000 Message-Id: <20220220151527.17216-9-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> References: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Michael Walle The Security Fuse Processor provides efuses and is responsible for reading it at SoC startup and configuring it accordingly. Signed-off-by: Michael Walle Reviewed-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- .../bindings/nvmem/fsl,layerscape-sfp.yaml | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/nvmem/fsl,layerscape-= sfp.yaml diff --git a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yam= l b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml new file mode 100644 index 000000000000..80914b93638e --- /dev/null +++ b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml @@ -0,0 +1,38 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/nvmem/fsl,layerscape-sfp.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale Layerscape Security Fuse Processor + +maintainers: + - Michael Walle + +description: | + SFP is the security fuse processor which among other things provide a + unique identifier per part. + +allOf: + - $ref: "nvmem.yaml#" + +properties: + compatible: + enum: + - fsl,ls1028a-sfp + + reg: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + efuse@1e80000 { + compatible =3D "fsl,ls1028a-sfp"; + reg =3D <0x1e80000 0x8000>; + }; --=20 2.21.0 From nobody Sat Jun 27 21:23:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA622C433EF for ; Sun, 20 Feb 2022 15:16:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241687AbiBTPQi (ORCPT ); Sun, 20 Feb 2022 10:16:38 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244163AbiBTPQW (ORCPT ); Sun, 20 Feb 2022 10:16:22 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30F6334BBF for ; Sun, 20 Feb 2022 07:15:59 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id d27so22869294wrb.5 for ; Sun, 20 Feb 2022 07:15:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/KX5uTkgk9W92gKlHSkFsOzce2NpLBrMlSSVzMx4nOs=; b=cRGwU1BsgWpldoqsENJ9J08eoraP2joeWa2nNnkg/CeTi1kuXAAI0sDTeUhfUxhge1 OBEKe8d4FuRAuJlbN1SNz59A8J6UjBaCAQi6PjAwgf/68Ayg8oO2DsUSsUT++CH1mmCc x8hnGsljSOmJjyUM7VWVpspnEb4qQAxjzb3HXHi8PCYceXCUvB1HM3aaU8eWxFyjGJr7 lkH6OYtrnKDbCkPn8kyr2QXDQ8LnTcve1BGi8ihpQqV3W5gXU386re5mVxFRH2h2yUl6 SkMZ1D5TmxeyoqS9vUNuVvmiTMqpzl7tc1M8qCrC4axvO5318bUwLeiUOjk3E5t1VLHl GREg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/KX5uTkgk9W92gKlHSkFsOzce2NpLBrMlSSVzMx4nOs=; b=Zm/2XIFGA3gZ6/CI3KN9x5IFQArfCJssgn/qy7OANfIFGvBvWW106M5Epv8TVR72vd AGMw01Pvs9bAr/2CwrODNEhM9VbNmg+Z0HrYc3Tvvlh72FYKlzfgHJSmFU6T1jY5Z5ln f2oDlhifd5MlN3xJpqmGcQiHaMA68k+5UKW4VK8hCKO3UBO/BePGVxGcQKHrk5ZQ1mvT o/foS6AmPfBh55KRTHW2sGOePuW/rATI+7M8fU5B2QRBnQYdcrGCGjGdw8ZUbkXUvYXg 6gXWZMcS0waVxLeX0uv18lOmjURYgseJ87FXgxo0QMbthwBbJsgIt0a6zwGBy/qxQHGc 0Pvg== X-Gm-Message-State: AOAM532wqb2yg/rloQE2HfwS+LPoRKTe7nqlyqzpTgpdt8cXiC7Qbily rMdqLjTLeGDjU6ysWRa3GoIfxBG5X6wgCw== X-Google-Smtp-Source: ABdhPJz9JJZGINe7AA5kaxjB2L/8l4FKTcx8dZqJ0mTmsf0v4Aqq0RKR/e3smplf8gUjJMEEinjzlg== X-Received: by 2002:adf:fd4b:0:b0:1e4:9a8a:2ef7 with SMTP id h11-20020adffd4b000000b001e49a8a2ef7mr12874497wrs.659.1645370157784; Sun, 20 Feb 2022 07:15:57 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id h7sm28687749wru.41.2022.02.20.07.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 07:15:57 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Michael Walle , Srinivas Kandagatla Subject: [PATCH 09/13] nvmem: add driver for Layerscape SFP (Security Fuse Processor) Date: Sun, 20 Feb 2022 15:15:23 +0000 Message-Id: <20220220151527.17216-10-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> References: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Michael Walle Add support for the Security Fuse Processor found on Layerscape SoCs. This driver implements basic read access. Signed-off-by: Michael Walle Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/Kconfig | 12 +++++ drivers/nvmem/Makefile | 2 + drivers/nvmem/layerscape-sfp.c | 89 ++++++++++++++++++++++++++++++++++ 3 files changed, 103 insertions(+) create mode 100644 drivers/nvmem/layerscape-sfp.c diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig index da414617a54d..4063ea15f7d2 100644 --- a/drivers/nvmem/Kconfig +++ b/drivers/nvmem/Kconfig @@ -300,4 +300,16 @@ config NVMEM_BRCM_NVRAM This driver provides support for Broadcom's NVRAM that can be accessed using I/O mapping. =20 +config NVMEM_LAYERSCAPE_SFP + tristate "Layerscape SFP (Security Fuse Processor) support" + depends on ARCH_LAYERSCAPE || COMPILE_TEST + depends on HAS_IOMEM + help + This driver provides support to read the eFuses on Freescale + Layerscape SoC's. For example, the vendor provides a per part + unique ID there. + + This driver can also be built as a module. If so, the module + will be called layerscape-sfp. + endif diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile index dcbbde35b6a8..d4e1052d2b95 100644 --- a/drivers/nvmem/Makefile +++ b/drivers/nvmem/Makefile @@ -61,3 +61,5 @@ obj-$(CONFIG_NVMEM_RMEM) +=3D nvmem-rmem.o nvmem-rmem-y :=3D rmem.o obj-$(CONFIG_NVMEM_BRCM_NVRAM) +=3D nvmem_brcm_nvram.o nvmem_brcm_nvram-y :=3D brcm_nvram.o +obj-$(CONFIG_NVMEM_LAYERSCAPE_SFP) +=3D nvmem-layerscape-sfp.o +nvmem-layerscape-sfp-y :=3D layerscape-sfp.o diff --git a/drivers/nvmem/layerscape-sfp.c b/drivers/nvmem/layerscape-sfp.c new file mode 100644 index 000000000000..e591c1511e33 --- /dev/null +++ b/drivers/nvmem/layerscape-sfp.c @@ -0,0 +1,89 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Layerscape SFP driver + * + * Copyright (c) 2022 Michael Walle + * + */ + +#include +#include +#include +#include +#include +#include +#include + +#define LAYERSCAPE_SFP_OTP_OFFSET 0x0200 + +struct layerscape_sfp_priv { + void __iomem *base; +}; + +struct layerscape_sfp_data { + int size; +}; + +static int layerscape_sfp_read(void *context, unsigned int offset, void *v= al, + size_t bytes) +{ + struct layerscape_sfp_priv *priv =3D context; + + memcpy_fromio(val, priv->base + LAYERSCAPE_SFP_OTP_OFFSET + offset, + bytes); + + return 0; +} + +static struct nvmem_config layerscape_sfp_nvmem_config =3D { + .name =3D "fsl-sfp", + .reg_read =3D layerscape_sfp_read, +}; + +static int layerscape_sfp_probe(struct platform_device *pdev) +{ + const struct layerscape_sfp_data *data; + struct layerscape_sfp_priv *priv; + struct nvmem_device *nvmem; + + priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(priv->base)) + return PTR_ERR(priv->base); + + data =3D device_get_match_data(&pdev->dev); + + layerscape_sfp_nvmem_config.size =3D data->size; + layerscape_sfp_nvmem_config.dev =3D &pdev->dev; + layerscape_sfp_nvmem_config.priv =3D priv; + + nvmem =3D devm_nvmem_register(&pdev->dev, &layerscape_sfp_nvmem_config); + + return PTR_ERR_OR_ZERO(nvmem); +} + +static const struct layerscape_sfp_data ls1028a_data =3D { + .size =3D 0x88, +}; + +static const struct of_device_id layerscape_sfp_dt_ids[] =3D { + { .compatible =3D "fsl,ls1028a-sfp", .data =3D &ls1028a_data }, + {}, +}; +MODULE_DEVICE_TABLE(of, layerscape_sfp_dt_ids); + +static struct platform_driver layerscape_sfp_driver =3D { + .probe =3D layerscape_sfp_probe, + .driver =3D { + .name =3D "layerscape_sfp", + .of_match_table =3D layerscape_sfp_dt_ids, + }, +}; +module_platform_driver(layerscape_sfp_driver); + +MODULE_AUTHOR("Michael Walle "); +MODULE_DESCRIPTION("Layerscape Security Fuse Processor driver"); +MODULE_LICENSE("GPL"); --=20 2.21.0 From nobody Sat Jun 27 21:23:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23350C433F5 for ; Sun, 20 Feb 2022 15:16:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244194AbiBTPQr (ORCPT ); Sun, 20 Feb 2022 10:16:47 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244174AbiBTPQW (ORCPT ); Sun, 20 Feb 2022 10:16:22 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17A2D3524F for ; Sun, 20 Feb 2022 07:16:00 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id x5so17986950wrg.13 for ; Sun, 20 Feb 2022 07:16:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O/VvSdH35ggdYDcqIG7rPDjoDjcMStnpl398SZrCoVM=; b=sBv2S4ThUynti8f6Ov4KGbgmJQjGpaq9nYPYhwFS75TV/dPTMnhi1ZJ9GL7qtg9i71 /IzIX+JjfmIGvHuIY3al4rQl2j2KrcUEnG6Q2C9SkgUqce86+HexGgfMqDgxQ5BYSe7B 1yhwkUuQeEMRUsDKlh27VcRBRuSKTqrxS8G4h2dYRHBuNV9D2WWnAE09zmPEVrW+JlhO s3ws94MUSonz9tcsdblgew6ofU8wdeUzw/prDMvNvFOl5dyX9evv17iHtwOU3NcY3DIS gpv+pMDo4hOhxefJOyuhmTQuPtjBHeRZeDHh5ET8SiSLRH0jPqLrIzhk1CvmFRMioam8 4yAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O/VvSdH35ggdYDcqIG7rPDjoDjcMStnpl398SZrCoVM=; b=Vb9+nQQlgxmOc5BNTsruMijUB9cQ8PfRqaTBxvUWwnnzEvvvpEW2VPgFFKZobwykNT L0UPfVAT1J+gdLxcbMYeDe/NlwIktQPGJ+dm1xbPUig+vJsD602lBIg0pcZqZkYP067R rKFQ3RK4dsZpyvxChQ4o9FjycDbmqIDITwMeJHp8Bk4M5RCKY3amZl8NS6q9kZxbDfOM KyQsbjGL4JpwFqFK8pH1PxbgYh0Jo1o/6qSYF+xRzjK7smsY5VWs0AjWWYl0xAfGzRPI aY+Z8Jwa+OP6EM2Y1q04gMQnCdcoN96FL1MNyycd1LSZNN/p1sOf7gLhHgimVbUEnrEd V/SA== X-Gm-Message-State: AOAM531yEjIhK9MYpFuNtkDIYpvzvr6EfDHUeq8kBrzJD7zncT0tmAGI D7/tjXdN9mIXyfmCcn+Lg5T3aQzFtAtNPA== X-Google-Smtp-Source: ABdhPJxTxkdJtYzYi5GuA97M550o0mpl5acA+YAXlVRU0AFRSd7fEnOiP4Ql+bz6fUmKYaYeUaxRVw== X-Received: by 2002:adf:face:0:b0:1e3:260c:f824 with SMTP id a14-20020adfface000000b001e3260cf824mr12570884wrs.181.1645370158718; Sun, 20 Feb 2022 07:15:58 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id h7sm28687749wru.41.2022.02.20.07.15.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 07:15:58 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Sean Anderson , Srinivas Kandagatla Subject: [PATCH 10/13] doc: nvmem: Remove references to regmap Date: Sun, 20 Feb 2022 15:15:24 +0000 Message-Id: <20220220151527.17216-11-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> References: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Sean Anderson Since commit 795ddd18d38f ("nvmem: core: remove regmap dependency"), nvmem devices do not use the regmap API. Remove references to it from the documentation. Signed-off-by: Sean Anderson Signed-off-by: Srinivas Kandagatla --- Documentation/driver-api/nvmem.rst | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/Documentation/driver-api/nvmem.rst b/Documentation/driver-api/= nvmem.rst index 287e86819640..56352ad1b1b0 100644 --- a/Documentation/driver-api/nvmem.rst +++ b/Documentation/driver-api/nvmem.rst @@ -26,9 +26,7 @@ was a rather big abstraction leak. =20 This framework aims at solve these problems. It also introduces DT representation for consumer devices to go get the data they require (MAC -Addresses, SoC/Revision ID, part numbers, and so on) from the NVMEMs. This -framework is based on regmap, so that most of the abstraction available in -regmap can be reused, across multiple types of buses. +Addresses, SoC/Revision ID, part numbers, and so on) from the NVMEMs. =20 NVMEM Providers +++++++++++++++ @@ -60,9 +58,6 @@ For example, a simple qfprom case:: ... } =20 -It is mandatory that the NVMEM provider has a regmap associated with its -struct device. Failure to do would return error code from nvmem_register(). - Users of board files can define and register nvmem cells using the nvmem_cell_table struct:: =20 --=20 2.21.0 From nobody Sat Jun 27 21:23:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F553C433EF for ; Sun, 20 Feb 2022 15:16:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244216AbiBTPQm (ORCPT ); Sun, 20 Feb 2022 10:16:42 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244171AbiBTPQW (ORCPT ); Sun, 20 Feb 2022 10:16:22 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B4993527E for ; Sun, 20 Feb 2022 07:16:01 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id k41so8152239wms.0 for ; Sun, 20 Feb 2022 07:16:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8kpOgd/mbbp4xC3u6NnhKQ40akLsMpySOQSsC87tSzg=; b=z1TfAcl+EIvdi3a1jMqc2vwbel5X71Xp4Tz64WSWTGErR1jyE2S8868wdAD9KL4hCU cJgEc9sOSoNC7/ildClbpOSqHnc1DVJAoO3G3rxU4zMlbas9VXpaRjOyJPKmr31cO94P VV9S87DuZxXw/W/ZEk/LmRFZ/V4M8BbY8SXQBX2uv35smCC9AnNG+rIZXmkMSGCvQ3b8 X5P1T/DNsU20bJV+/9CGudjn8wTcq2alIjtrEzo+TPQawMbraH+/PQS2Bfj/x35svu5F HHBCfmbpPqtCwPOKWxNszIkDT/Q48Saqv42aYuqrk4qL6MLFuNivN9LJFvJadaHapJkb 1TAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8kpOgd/mbbp4xC3u6NnhKQ40akLsMpySOQSsC87tSzg=; b=J/5Fbu+3mc9AKdNVcLacPf2JNVgOLeIV/M7oCZ1Js2VdOqcm3+HPeA3NrIJK64CUsG /L4q6EWr1n1+N4vmI+uFlTURLWr0cNlOu1F4d0BJEuGnMhuzapkmiYGQXbUP1s2b5Ir9 5CPNbmUXP9AukBDagymbeFVw5iMZMCSuNtpYzsWiWQh25OhKAU8ky7V2sSY26rINslzO GgqXiWuJiHbH8tMBoZ/xD5KAnvkhEDxx+rFn88XZ2zIv68fObSnTcFy+R2IrjeBPG7ED FUkyyonKSwahmFxMtP8f9rLGjaXVdLtctykEuAHFyrbArsF19HkLIia++d56upw+Tv+/ tMgw== X-Gm-Message-State: AOAM531Yqm8RpVRHlpaPUY20u6lZ8h0E05xJydH6Mh3kfIpxg2SsIOT7 yxi1LOi5bLJBsfQMMq+/0e9bxQ== X-Google-Smtp-Source: ABdhPJyAFGk0bZ3Gv4Nl5kc2QuloNxbKyqKiERG6K6djqIuRq8KFGEBdX7gRL5ripblYy/jmMKZ4MA== X-Received: by 2002:a05:600c:1d27:b0:37c:74bb:2b4d with SMTP id l39-20020a05600c1d2700b0037c74bb2b4dmr18038411wms.82.1645370159634; Sun, 20 Feb 2022 07:15:59 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id h7sm28687749wru.41.2022.02.20.07.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 07:15:59 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Sean Anderson , Srinivas Kandagatla Subject: [PATCH 11/13] doc: nvmem: Update example Date: Sun, 20 Feb 2022 15:15:25 +0000 Message-Id: <20220220151527.17216-12-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> References: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Sean Anderson Update the example to reflect the new API. I have chosen the brcm-nvram driver since it seems to be simpler than the qfprom driver. Signed-off-by: Sean Anderson Signed-off-by: Srinivas Kandagatla --- Documentation/driver-api/nvmem.rst | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/Documentation/driver-api/nvmem.rst b/Documentation/driver-api/= nvmem.rst index 56352ad1b1b0..e3366322d46c 100644 --- a/Documentation/driver-api/nvmem.rst +++ b/Documentation/driver-api/nvmem.rst @@ -43,19 +43,20 @@ nvmem_device pointer. =20 nvmem_unregister(nvmem) is used to unregister a previously registered prov= ider. =20 -For example, a simple qfprom case:: +For example, a simple nvram case:: =20 - static struct nvmem_config econfig =3D { - .name =3D "qfprom", - .owner =3D THIS_MODULE, - }; - - static int qfprom_probe(struct platform_device *pdev) + static int brcm_nvram_probe(struct platform_device *pdev) { + struct nvmem_config config =3D { + .name =3D "brcm-nvram", + .reg_read =3D brcm_nvram_read, + }; ... - econfig.dev =3D &pdev->dev; - nvmem =3D nvmem_register(&econfig); - ... + config.dev =3D &pdev->dev; + config.priv =3D priv; + config.size =3D resource_size(res); + + devm_nvmem_register(&config); } =20 Users of board files can define and register nvmem cells using the --=20 2.21.0 From nobody Sat Jun 27 21:23:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99887C433EF for ; Sun, 20 Feb 2022 15:16:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244241AbiBTPQv (ORCPT ); Sun, 20 Feb 2022 10:16:51 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244126AbiBTPQX (ORCPT ); Sun, 20 Feb 2022 10:16:23 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 196F734BA7 for ; Sun, 20 Feb 2022 07:16:02 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id u1so22822359wrg.11 for ; Sun, 20 Feb 2022 07:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s4avYTwyzOebeNnD3c9KYG3x29F/g/qJAaU+xvILJYI=; b=CyvN1XIDtWg75xXtJrI6e/JFb+l8W5fc/x1tgXu/uo/QvyxASasB0e/Ucgk5cL22uq J4iO65m4myKX0yElNJ1CjsjgFDOflMyuL3xmRq0LsqriZkfb/da21PMaxtEZP598xGUD vjehGlzrausTrJIc7Ki6n/FkCN3GmOwxakwYrIilX+u+Ok4Nl+8DOTi+kzhpQrRHXzZ9 LNARSTjyeUMzFrd0JoInhyg1HaDShd4jxp4htwdBo3aOkNGXn/lwwqL2nlh/rOI9owMe KQKIdqrp7q4qruOdpG6p9JT2ZZ08LLNrSHIZbofnparUcKl+Q14tWD/XQ/kRcEasl2GF v5mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s4avYTwyzOebeNnD3c9KYG3x29F/g/qJAaU+xvILJYI=; b=sRyTzag6N9a3x4utfyUY11UtaYr3solq9fI2c4ZXGtnef6RRRv0ihl9ZTJhkKt5HnW kjNyyDC03f80okqpNMxT3jPIGUQNAz7PGwyc69+KxNy06q/Gjw7hOctXjN87tAlZtmlB MbxZZscx8ncGSGt/K0IG7+SWFrtuBHoV8nATfxjT6pfV3ppVXcTPmK1gqy+HzMR+KsrH aHsRnMSD0HggphUCdFB3S+av9fe0XEwOd9+iMieCknyYnXDt5HU913bS1yw3BN+sDnXD c1iyt8objnBeSr8cXBZqsoGZN6xRuLkHmRrtX+DPhEMJmcC9ok3Y4FTiHqcSlZaUFSb0 MOWw== X-Gm-Message-State: AOAM530bbXEz3n3+Lj1ZoD3tw5+PkkkFL/uUB3VX3ZeUeD94R/We8oEj Rdo2SQThG9QkXeEDl13snTkCYQ== X-Google-Smtp-Source: ABdhPJzruCjXO7Zg4NObI0xSV/ELqzdIvudg+xrfspTKPluY+yIrtpO5Xi22cw+86bnCaxdV3z9o1Q== X-Received: by 2002:adf:fb4e:0:b0:1e3:3e66:d5f6 with SMTP id c14-20020adffb4e000000b001e33e66d5f6mr13203959wrs.615.1645370160720; Sun, 20 Feb 2022 07:16:00 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id h7sm28687749wru.41.2022.02.20.07.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 07:16:00 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Andy Shevchenko , Miquel Raynal , Srinivas Kandagatla Subject: [PATCH 12/13] mtd: core: Drop duplicate NULL checks around nvmem_unregister() Date: Sun, 20 Feb 2022 15:15:26 +0000 Message-Id: <20220220151527.17216-13-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> References: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko Since nvmem_unregister() checks for NULL, no need to repeat in the caller. Drop duplicate NULL checks. Signed-off-by: Andy Shevchenko Acked-by: Miquel Raynal Signed-off-by: Srinivas Kandagatla --- drivers/mtd/mtdcore.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index eef87b28d6c8..fc6090366684 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -743,8 +743,7 @@ int del_mtd_device(struct mtd_info *mtd) debugfs_remove_recursive(mtd->dbg.dfs_dir); =20 /* Try to remove the NVMEM provider */ - if (mtd->nvmem) - nvmem_unregister(mtd->nvmem); + nvmem_unregister(mtd->nvmem); =20 device_unregister(&mtd->dev); =20 @@ -923,8 +922,7 @@ static int mtd_otp_nvmem_add(struct mtd_info *mtd) return 0; =20 err: - if (mtd->otp_user_nvmem) - nvmem_unregister(mtd->otp_user_nvmem); + nvmem_unregister(mtd->otp_user_nvmem); return err; } =20 @@ -1028,11 +1026,8 @@ int mtd_device_unregister(struct mtd_info *master) memset(&master->reboot_notifier, 0, sizeof(master->reboot_notifier)); } =20 - if (master->otp_user_nvmem) - nvmem_unregister(master->otp_user_nvmem); - - if (master->otp_factory_nvmem) - nvmem_unregister(master->otp_factory_nvmem); + nvmem_unregister(master->otp_user_nvmem); + nvmem_unregister(master->otp_factory_nvmem); =20 err =3D del_mtd_partitions(master); if (err) --=20 2.21.0 From nobody Sat Jun 27 21:23:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE99DC433EF for ; Sun, 20 Feb 2022 15:16:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238649AbiBTPQ4 (ORCPT ); Sun, 20 Feb 2022 10:16:56 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244143AbiBTPQY (ORCPT ); Sun, 20 Feb 2022 10:16:24 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 255AB34BA8 for ; Sun, 20 Feb 2022 07:16:03 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id p9so22805088wra.12 for ; Sun, 20 Feb 2022 07:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QPxVOPedb7VSlKJrNqeXgyqzEIVCKAODI2AGkqq7jh0=; b=YGrymPtMsXeZaHEpHtmPZMlg3m+LYLl71bOPVMnvF/ikOOpY1R326ccQHH77Tz7CwM 66tLMVK0kGZudM/UgNRSMDqPnFKGlzlniu05V0P8tl39/xzGON45pSrOPxSOI4BpCgsZ 762VoLHvjM6+3HAPk0s84HgAZd1DjSMiG+t14TpvvkeuYgkBmjQG3wQqLRXg9pW0//o/ 3Lvakym+02l3Uuk0jwiSVjJKzj79hs2w9l+ZLy7JJXufxDFMgvs6EwPjysvzTww88L9F VUPiQN9uuBpRQkDBWdxqII9HTBtxPDWjISMr/4l6qfwI/ebblm0PpIMcvhmIb1gcmfHy i27g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QPxVOPedb7VSlKJrNqeXgyqzEIVCKAODI2AGkqq7jh0=; b=qoXHljor20ZjQ5svblFNYJ2Lt8S1VlDMKNGT0a7hBc3M4aOFIHccLuhg7/pIq6KY/U lnyohKbdm3X6k+19PWfLfxqtuVqPfKjREpVzmpyKZHEBvEzpCXeG6k9p4gKdW2Mr8cBB P92ag7PENdpSsPtFhJDQWfa+uUw8F1vEXpX8kGgB+npu9EaAQcFdMzoZbt1eMaAe7euV THejBczV43g6SoyC5tFS6Mgoo4Z8BP82VloaAwKmFDL3uQrF7EHjxcBHpzPdDOavw/nW HfmbTqDfdCHxZfFsLTupsOH7+g7TsXGcceX8iVK+Lb4b3tmzgNW2TjsYd2qdtlq29f95 /y5w== X-Gm-Message-State: AOAM532b4Y/LR+Qa35QNkJPP9qHki+ydnqh8DU8LxLjov8djeRabNEFe YVZgXV8SoHXCaU50XC+NQXnJQA== X-Google-Smtp-Source: ABdhPJzoK0LZ8FPn8rmbGAiwjODLqINRZujKRulVkIZMKPBEB7QQS5ZgLH3spfqaJwJPiGfgysMM+g== X-Received: by 2002:adf:df0b:0:b0:1e4:979f:a56f with SMTP id y11-20020adfdf0b000000b001e4979fa56fmr12356206wrl.686.1645370161675; Sun, 20 Feb 2022 07:16:01 -0800 (PST) Received: from srini-hackbox.lan (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.gmail.com with ESMTPSA id h7sm28687749wru.41.2022.02.20.07.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 07:16:01 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Andy Shevchenko , Mika Westerberg , Srinivas Kandagatla Subject: [PATCH 13/13] thunderbolt: Drop duplicate NULL checks around nvmem_unregister() Date: Sun, 20 Feb 2022 15:15:27 +0000 Message-Id: <20220220151527.17216-14-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> References: <20220220151527.17216-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko Since nvmem_unregister() checks for NULL, no need to repeat in the caller. Drop duplicate NULL checks. Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg Signed-off-by: Srinivas Kandagatla --- drivers/thunderbolt/nvm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/thunderbolt/nvm.c b/drivers/thunderbolt/nvm.c index 3a5336913cca..b3f310389378 100644 --- a/drivers/thunderbolt/nvm.c +++ b/drivers/thunderbolt/nvm.c @@ -154,10 +154,8 @@ int tb_nvm_add_non_active(struct tb_nvm *nvm, size_t s= ize, void tb_nvm_free(struct tb_nvm *nvm) { if (nvm) { - if (nvm->non_active) - nvmem_unregister(nvm->non_active); - if (nvm->active) - nvmem_unregister(nvm->active); + nvmem_unregister(nvm->non_active); + nvmem_unregister(nvm->active); vfree(nvm->buf); ida_simple_remove(&nvm_ida, nvm->id); } --=20 2.21.0