From nobody Sat Jun 27 22:29:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 586BCC433EF for ; Fri, 18 Feb 2022 09:31:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233589AbiBRJbY (ORCPT ); Fri, 18 Feb 2022 04:31:24 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233578AbiBRJbB (ORCPT ); Fri, 18 Feb 2022 04:31:01 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64B7B253BD9 for ; Fri, 18 Feb 2022 01:30:45 -0800 (PST) Received: from dslb-178-004-174-047.178.004.pools.vodafone-ip.de ([178.4.174.47] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nKzb6-0005VT-Ef; Fri, 18 Feb 2022 10:30:40 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 1/4] staging: r8188eu: RxMIMOSignalQuality is set but not used Date: Fri, 18 Feb 2022 10:30:31 +0100 Message-Id: <20220218093034.854049-2-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220218093034.854049-1-martin@kaiser.cx> References: <20220218093034.854049-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The RxMIMOSignalQuality array in struct signal_stat is set but not used. Remove it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 6 ------ drivers/staging/r8188eu/include/rtw_recv.h | 1 - 2 files changed, 7 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r= 8188eu/hal/odm_HWConfig.c index dcc38b036280..8ebcd3050892 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -67,9 +67,6 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm_d= m_struct *dm_odm, =20 isCCKrate =3D ((pPktinfo->Rate >=3D DESC92C_RATE1M) && (pPktinfo->Rate <= =3D DESC92C_RATE11M)) ? true : false; =20 - pPhyInfo->RxMIMOSignalQuality[RF_PATH_A] =3D -1; - pPhyInfo->RxMIMOSignalQuality[RF_PATH_B] =3D -1; - if (isCCKrate) { u8 cck_agc_rpt; =20 @@ -150,8 +147,6 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm= _dm_struct *dm_odm, SQ =3D ((64 - SQ_rpt) * 100) / 44; } pPhyInfo->SignalQuality =3D SQ; - pPhyInfo->RxMIMOSignalQuality[RF_PATH_A] =3D SQ; - pPhyInfo->RxMIMOSignalQuality[RF_PATH_B] =3D -1; } } else { /* is OFDM rate */ dm_odm->PhyDbgInfo.NumQryPhyStatusOFDM++; @@ -203,7 +198,6 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm= _dm_struct *dm_odm, if (pPktinfo->bPacketMatchBSSID) { if (i =3D=3D RF_PATH_A) /* Fill value in RFD, Get the first spatial s= tream only */ pPhyInfo->SignalQuality =3D (u8)(EVM & 0xff); - pPhyInfo->RxMIMOSignalQuality[i] =3D (u8)(EVM & 0xff); } } } diff --git a/drivers/staging/r8188eu/include/rtw_recv.h b/drivers/staging/r= 8188eu/include/rtw_recv.h index 920f33235e00..f82a26a675c0 100644 --- a/drivers/staging/r8188eu/include/rtw_recv.h +++ b/drivers/staging/r8188eu/include/rtw_recv.h @@ -72,7 +72,6 @@ struct signal_stat { struct phy_info { u8 RxPWDBAll; u8 SignalQuality; /* in 0-100 index. */ - u8 RxMIMOSignalQuality[MAX_PATH_NUM_92CS]; /* EVM */ u8 RxMIMOSignalStrength[MAX_PATH_NUM_92CS];/* in 0~100 index */ s8 RxPower; /* in dBm Translate from PWdB */ /* Real power in dBm for this packet, no beautification and aggregation. --=20 2.30.2 From nobody Sat Jun 27 22:29:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B0ECC433EF for ; Fri, 18 Feb 2022 09:31:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233599AbiBRJbU (ORCPT ); Fri, 18 Feb 2022 04:31:20 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233569AbiBRJbB (ORCPT ); Fri, 18 Feb 2022 04:31:01 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64D2F253BDA for ; Fri, 18 Feb 2022 01:30:45 -0800 (PST) Received: from dslb-178-004-174-047.178.004.pools.vodafone-ip.de ([178.4.174.47] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nKzb7-0005VT-9z; Fri, 18 Feb 2022 10:30:41 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 2/4] staging: r8188eu: RxSNR is set but not used Date: Fri, 18 Feb 2022 10:30:32 +0100 Message-Id: <20220218093034.854049-3-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220218093034.854049-1-martin@kaiser.cx> References: <20220218093034.854049-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The RxSNR array in struct phy_info is set but not used. Remove it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 1 - drivers/staging/r8188eu/include/rtw_recv.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r= 8188eu/hal/odm_HWConfig.c index 8ebcd3050892..7d47ecd53757 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -171,7 +171,6 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm= _dm_struct *dm_odm, pPhyInfo->RxMIMOSignalStrength[i] =3D (u8)RSSI; =20 /* Get Rx snr value in DB */ - pPhyInfo->RxSNR[i] =3D (s32)(pPhyStaRpt->path_rxsnr[i] / 2); dm_odm->PhyDbgInfo.RxSNRdB[i] =3D (s32)(pPhyStaRpt->path_rxsnr[i] / 2); } /* (2)PWDB, Average PWDB cacluated by hardware (for rate adaptive) */ diff --git a/drivers/staging/r8188eu/include/rtw_recv.h b/drivers/staging/r= 8188eu/include/rtw_recv.h index f82a26a675c0..5e65cf6b87bc 100644 --- a/drivers/staging/r8188eu/include/rtw_recv.h +++ b/drivers/staging/r8188eu/include/rtw_recv.h @@ -79,7 +79,6 @@ struct phy_info { s8 recvpower; u8 SignalStrength; /* in 0-100 index. */ u8 RxPwr[MAX_PATH_NUM_92CS];/* per-path's pwdb */ - u8 RxSNR[MAX_PATH_NUM_92CS];/* per-path's SNR */ }; =20 struct rx_pkt_attrib { --=20 2.30.2 From nobody Sat Jun 27 22:29:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554ABC433F5 for ; Fri, 18 Feb 2022 09:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233598AbiBRJbP (ORCPT ); Fri, 18 Feb 2022 04:31:15 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233580AbiBRJbB (ORCPT ); Fri, 18 Feb 2022 04:31:01 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9BE425038B for ; Fri, 18 Feb 2022 01:30:44 -0800 (PST) Received: from dslb-178-004-174-047.178.004.pools.vodafone-ip.de ([178.4.174.47] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nKzb8-0005VT-8O; Fri, 18 Feb 2022 10:30:42 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 3/4] staging: r8188eu: NumQryPhyStatusCCK is set but not used Date: Fri, 18 Feb 2022 10:30:33 +0100 Message-Id: <20220218093034.854049-4-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220218093034.854049-1-martin@kaiser.cx> References: <20220218093034.854049-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" NumQryPhyStatusCCK in struct odm_phy_dbg_info is set but not used. Remove it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 1 - drivers/staging/r8188eu/include/odm.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r= 8188eu/hal/odm_HWConfig.c index 7d47ecd53757..833c8fd7fb0c 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -70,7 +70,6 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm_d= m_struct *dm_odm, if (isCCKrate) { u8 cck_agc_rpt; =20 - dm_odm->PhyDbgInfo.NumQryPhyStatusCCK++; /* (1)Hardware does not provide RSSI for CCK */ /* (2)PWDB, Average PWDB cacluated by hardware (for rate adaptive) */ =20 diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188e= u/include/odm.h index 9fb09e0a0df9..66b5413b6846 100644 --- a/drivers/staging/r8188eu/include/odm.h +++ b/drivers/staging/r8188eu/include/odm.h @@ -86,7 +86,6 @@ struct odm_phy_dbg_info { /* ODM Write,debug info */ s8 RxSNRdB[MAX_PATH_NUM_92CS]; u64 NumQryPhyStatus; - u64 NumQryPhyStatusCCK; u64 NumQryPhyStatusOFDM; /* Others */ s32 RxEVM[MAX_PATH_NUM_92CS]; --=20 2.30.2 From nobody Sat Jun 27 22:29:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 849C3C433FE for ; Fri, 18 Feb 2022 09:31:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233607AbiBRJb0 (ORCPT ); Fri, 18 Feb 2022 04:31:26 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:38078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233602AbiBRJbP (ORCPT ); Fri, 18 Feb 2022 04:31:15 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0620D256EFD for ; Fri, 18 Feb 2022 01:30:49 -0800 (PST) Received: from dslb-178-004-174-047.178.004.pools.vodafone-ip.de ([178.4.174.47] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nKzbA-0005VT-3F; Fri, 18 Feb 2022 10:30:44 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 4/4] staging: r8188eu: NumQryPhyStatusOFDM is set but not used Date: Fri, 18 Feb 2022 10:30:34 +0100 Message-Id: <20220218093034.854049-5-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220218093034.854049-1-martin@kaiser.cx> References: <20220218093034.854049-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" NumQryPhyStatusOFDM in struct odm_phy_dbg_info is set but not used. Remove it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 2 -- drivers/staging/r8188eu/include/odm.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r= 8188eu/hal/odm_HWConfig.c index 833c8fd7fb0c..87e9a5270be0 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -148,8 +148,6 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm= _dm_struct *dm_odm, pPhyInfo->SignalQuality =3D SQ; } } else { /* is OFDM rate */ - dm_odm->PhyDbgInfo.NumQryPhyStatusOFDM++; - /* (1)Get RSSI for HT rate */ =20 for (i =3D RF_PATH_A; i < RF_PATH_MAX; i++) { diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188e= u/include/odm.h index 66b5413b6846..4c97f222987a 100644 --- a/drivers/staging/r8188eu/include/odm.h +++ b/drivers/staging/r8188eu/include/odm.h @@ -86,7 +86,6 @@ struct odm_phy_dbg_info { /* ODM Write,debug info */ s8 RxSNRdB[MAX_PATH_NUM_92CS]; u64 NumQryPhyStatus; - u64 NumQryPhyStatusOFDM; /* Others */ s32 RxEVM[MAX_PATH_NUM_92CS]; }; --=20 2.30.2