From nobody Sun Jun 28 08:40:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C04DEC433EF for ; Wed, 16 Feb 2022 19:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238516AbiBPT7x (ORCPT ); Wed, 16 Feb 2022 14:59:53 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:53096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238492AbiBPT7v (ORCPT ); Wed, 16 Feb 2022 14:59:51 -0500 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2D23224968 for ; Wed, 16 Feb 2022 11:59:37 -0800 (PST) Received: by mail-pj1-x102e.google.com with SMTP id m7so3508567pjk.0 for ; Wed, 16 Feb 2022 11:59:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vHd6VxD3pISdJKOlDiTb4+AqZmiLYkQPRdmG+nB1JTc=; b=Fh17Yn70lbEn1UoieQE1xysG5dalZyz06ZVVRhDL5peLtqwGPyr9lLzz8TFdpGQ7+8 AzPZMmtqK1vPiXYpjLLdGaEujy4M1oJnBrsx9M990wg0kc5jfhBc55IDftlzHK65z42x RtTqPMM8hlG/LlJszXonjkBRRlOx2zq3Fnuqs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vHd6VxD3pISdJKOlDiTb4+AqZmiLYkQPRdmG+nB1JTc=; b=yzvlv+PjXkJKuO2IqSlc2lkB5Pf0ToBt4Fyd41qTvhu26WHNBgSGwqWEdXIm0K+sve qhjKgpYczvenAcwHgmzGPag2ewBlvqR3ACU1GDExf8KImaRcqgTr9vo39k3UQK8aqRjV 2bpRmRw2a8AErQRAC61fWyohGci4AXDaAtTH4ZO1/7ZO3i2lKuPBrbF6tJZxkKezP8cM 9t1UqM18/Hvu6hJEVYhB913F0BEJIK3NXdchgOynxPNXS8yYpIQklEPr/hH33P14tS5v 2YhZYf+1wNo5F3XCC6br2QhcXY0zVMz/ymoYOkqLqVKJZ5w6a9TiLUR+WAHJoQrp1TBb W8FA== X-Gm-Message-State: AOAM531gHAwT2sX/OacZTZ7dBCg512W4+u4k7r0f119fmG4GJ8bE4QCh eVSLDsyEk2l1vfEizlBS4eB8nA== X-Google-Smtp-Source: ABdhPJxFbYFIiaCMHyzuE9Lo+lXMT0G0Ytnx6QYHtC/R5ZuGNI5uj3ewfIJQWgyF0cFrSKYOm9PAew== X-Received: by 2002:a17:90a:f482:b0:1bb:8504:864c with SMTP id bx2-20020a17090af48200b001bb8504864cmr3630264pjb.161.1645041577199; Wed, 16 Feb 2022 11:59:37 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:202:201:5f39:68a1:3c2b:3486]) by smtp.gmail.com with ESMTPSA id u16sm6078840pgh.54.2022.02.16.11.59.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 11:59:36 -0800 (PST) From: Stephen Boyd To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, Jiri Kosina , linux-input@vger.kernel.org, "Sean O'Brien" , Douglas Anderson , Zhengqiao Xia Subject: [PATCH v4 1/4] Input: Extract ChromeOS vivaldi physmap show function Date: Wed, 16 Feb 2022 11:58:58 -0800 Message-Id: <20220216195901.1326924-2-swboyd@chromium.org> X-Mailer: git-send-email 2.35.1.265.g69c8d7142f-goog In-Reply-To: <20220216195901.1326924-1-swboyd@chromium.org> References: <20220216195901.1326924-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Let's introduce a common library file for the physmap show function duplicated between three different keyboard drivers. This largely copies the code from cros_ec_keyb.c which has the most recent version of the show function, while using the vivaldi_data struct from the hid-vivaldi driver. This saves a small amount of space in an allyesconfig build. $ ./scripts/bloat-o-meter vmlinux.before vmlinux.after add/remove: 3/0 grow/shrink: 2/3 up/down: 412/-720 (-308) Function old new delta vivaldi_function_row_physmap_show - 292 +292 _sub_I_65535_1 1057564 1057616 +52 _sub_D_65535_0 1057564 1057616 +52 e843419@49f2_00062737_9b04 - 8 +8 e843419@20f6_0002a34d_35bc - 8 +8 atkbd_parse_fwnode_data 480 472 -8 atkbd_do_show_function_row_physmap 316 76 -240 function_row_physmap_show 620 148 -472 Total: Before=3D285581925, After=3D285581617, chg -0.00% Cc: Jiri Kosina Cc: Dmitry Torokhov Tested-by: "Sean O'Brien" Cc: Douglas Anderson Cc: Zhengqiao Xia Signed-off-by: Stephen Boyd --- drivers/hid/Kconfig | 1 + drivers/hid/hid-vivaldi.c | 27 +++++-------------- drivers/input/Kconfig | 7 +++++ drivers/input/Makefile | 1 + drivers/input/keyboard/Kconfig | 2 ++ drivers/input/keyboard/atkbd.c | 22 +++++---------- drivers/input/keyboard/cros_ec_keyb.c | 32 ++++++++-------------- drivers/input/vivaldi-fmap.c | 39 +++++++++++++++++++++++++++ include/linux/input/vivaldi-fmap.h | 28 +++++++++++++++++++ 9 files changed, 102 insertions(+), 57 deletions(-) create mode 100644 drivers/input/vivaldi-fmap.c create mode 100644 include/linux/input/vivaldi-fmap.h diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index f5544157576c..5569a2029dab 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -411,6 +411,7 @@ config HID_GOOGLE_HAMMER =20 config HID_VIVALDI tristate "Vivaldi Keyboard" + select INPUT_VIVALDIFMAP depends on HID help Say Y here if you want to enable support for Vivaldi keyboards. diff --git a/drivers/hid/hid-vivaldi.c b/drivers/hid/hid-vivaldi.c index efa6140915f4..adb56b342948 100644 --- a/drivers/hid/hid-vivaldi.c +++ b/drivers/hid/hid-vivaldi.c @@ -8,37 +8,22 @@ =20 #include #include +#include #include #include #include =20 -#define MIN_FN_ROW_KEY 1 -#define MAX_FN_ROW_KEY 24 #define HID_VD_FN_ROW_PHYSMAP 0x00000001 #define HID_USAGE_FN_ROW_PHYSMAP (HID_UP_GOOGLEVENDOR | HID_VD_FN_ROW_PHYS= MAP) =20 -struct vivaldi_data { - u32 function_row_physmap[MAX_FN_ROW_KEY - MIN_FN_ROW_KEY + 1]; - int max_function_row_key; -}; - static ssize_t function_row_physmap_show(struct device *dev, struct device_attribute *attr, char *buf) { struct hid_device *hdev =3D to_hid_device(dev); struct vivaldi_data *drvdata =3D hid_get_drvdata(hdev); - ssize_t size =3D 0; - int i; - - if (!drvdata->max_function_row_key) - return 0; =20 - for (i =3D 0; i < drvdata->max_function_row_key; i++) - size +=3D sprintf(buf + size, "%02X ", - drvdata->function_row_physmap[i]); - size +=3D sprintf(buf + size, "\n"); - return size; + return vivaldi_function_row_physmap_show(drvdata, buf); } =20 static DEVICE_ATTR_RO(function_row_physmap); @@ -86,10 +71,10 @@ static void vivaldi_feature_mapping(struct hid_device *= hdev, return; =20 fn_key =3D (usage->hid & HID_USAGE); - if (fn_key < MIN_FN_ROW_KEY || fn_key > MAX_FN_ROW_KEY) + if (fn_key < VIVALDI_MIN_FN_ROW_KEY || fn_key > VIVALDI_MAX_FN_ROW_KEY) return; - if (fn_key > drvdata->max_function_row_key) - drvdata->max_function_row_key =3D fn_key; + if (fn_key > drvdata->num_function_row_keys) + drvdata->num_function_row_keys =3D fn_key; =20 report_data =3D buf =3D hid_alloc_report_buf(report, GFP_KERNEL); if (!report_data) @@ -134,7 +119,7 @@ static void vivaldi_feature_mapping(struct hid_device *= hdev, goto out; } =20 - drvdata->function_row_physmap[fn_key - MIN_FN_ROW_KEY] =3D + drvdata->function_row_physmap[fn_key - VIVALDI_MIN_FN_ROW_KEY] =3D field->value[usage->usage_index]; =20 out: diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig index 5baebf62df33..e2752f7364bc 100644 --- a/drivers/input/Kconfig +++ b/drivers/input/Kconfig @@ -77,6 +77,13 @@ config INPUT_MATRIXKMAP To compile this driver as a module, choose M here: the module will be called matrix-keymap. =20 +config INPUT_VIVALDIFMAP + tristate + help + ChromeOS Vivaldi keymap support library. This is a hidden + option so that drivers can use common code to parse and + expose the vivaldi function row keymap. + comment "Userland interfaces" =20 config INPUT_MOUSEDEV diff --git a/drivers/input/Makefile b/drivers/input/Makefile index 037cc595106c..f91874e76567 100644 --- a/drivers/input/Makefile +++ b/drivers/input/Makefile @@ -9,6 +9,7 @@ obj-$(CONFIG_INPUT) +=3D input-core.o input-core-y :=3D input.o input-compat.o input-mt.o input-poller.o ff-core= .o input-core-y +=3D touchscreen.o =20 +obj-$(CONFIG_INPUT_VIVALDIFMAP) +=3D vivaldi-fmap.o obj-$(CONFIG_INPUT_FF_MEMLESS) +=3D ff-memless.o obj-$(CONFIG_INPUT_SPARSEKMAP) +=3D sparse-keymap.o obj-$(CONFIG_INPUT_MATRIXKMAP) +=3D matrix-keymap.o diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index 0c607da9ee10..8b4477e54a01 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -103,6 +103,7 @@ config KEYBOARD_ATKBD select SERIO_LIBPS2 select SERIO_I8042 if ARCH_MIGHT_HAVE_PC_SERIO select SERIO_GSCPS2 if GSC + select INPUT_VIVALDIFMAP help Say Y here if you want to use a standard AT or PS/2 keyboard. Usually you'll need this, unless you have a different type keyboard (USB, ADB @@ -749,6 +750,7 @@ config KEYBOARD_XTKBD config KEYBOARD_CROS_EC tristate "ChromeOS EC keyboard" select INPUT_MATRIXKMAP + select INPUT_VIVALDIFMAP depends on CROS_EC help Say Y here to enable the matrix keyboard used by ChromeOS devices diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c index fbdef95291e9..fc980435c97a 100644 --- a/drivers/input/keyboard/atkbd.c +++ b/drivers/input/keyboard/atkbd.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include @@ -237,8 +238,7 @@ struct atkbd { /* Serializes reconnect(), attr->set() and event work */ struct mutex mutex; =20 - u32 function_row_physmap[MAX_FUNCTION_ROW_KEYS]; - int num_function_row_keys; + struct vivaldi_data vdata; }; =20 /* @@ -308,17 +308,9 @@ static struct attribute *atkbd_attributes[] =3D { =20 static ssize_t atkbd_show_function_row_physmap(struct atkbd *atkbd, char *= buf) { - ssize_t size =3D 0; - int i; - - if (!atkbd->num_function_row_keys) - return 0; + const struct vivaldi_data *data =3D &atkbd->vdata; =20 - for (i =3D 0; i < atkbd->num_function_row_keys; i++) - size +=3D scnprintf(buf + size, PAGE_SIZE - size, "%02X ", - atkbd->function_row_physmap[i]); - size +=3D scnprintf(buf + size, PAGE_SIZE - size, "\n"); - return size; + return vivaldi_function_row_physmap_show(data, buf); } =20 static umode_t atkbd_attr_is_visible(struct kobject *kobj, @@ -329,7 +321,7 @@ static umode_t atkbd_attr_is_visible(struct kobject *ko= bj, struct atkbd *atkbd =3D serio_get_drvdata(serio); =20 if (attr =3D=3D &atkbd_attr_function_row_physmap.attr && - !atkbd->num_function_row_keys) + !atkbd->vdata.num_function_row_keys) return 0; =20 return attr->mode; @@ -1208,8 +1200,8 @@ static void atkbd_parse_fwnode_data(struct serio *ser= io) n =3D device_property_count_u32(dev, "function-row-physmap"); if (n > 0 && n <=3D MAX_FUNCTION_ROW_KEYS && !device_property_read_u32_array(dev, "function-row-physmap", - atkbd->function_row_physmap, n)) { - atkbd->num_function_row_keys =3D n; + atkbd->vdata.function_row_physmap, n)) { + atkbd->vdata.num_function_row_keys =3D n; dev_dbg(dev, "FW reported %d function-row key locations\n", n); } } diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard= /cros_ec_keyb.c index fc02c540636e..3151e887b0f1 100644 --- a/drivers/input/keyboard/cros_ec_keyb.c +++ b/drivers/input/keyboard/cros_ec_keyb.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -44,9 +45,7 @@ * @idev: The input device for the matrix keys. * @bs_idev: The input device for non-matrix buttons and switches (or NULL= ). * @notifier: interrupt event notifier for transport devices - * @function_row_physmap: An array of the encoded rows/columns for the top - * row function keys, in an order from left to right - * @num_function_row_keys: The number of top row keys in a custom keyboard + * @vdata: vivaldi function row data */ struct cros_ec_keyb { unsigned int rows; @@ -64,8 +63,7 @@ struct cros_ec_keyb { struct input_dev *bs_idev; struct notifier_block notifier; =20 - u16 function_row_physmap[MAX_NUM_TOP_ROW_KEYS]; - size_t num_function_row_keys; + struct vivaldi_data vdata; }; =20 /** @@ -537,7 +535,7 @@ static int cros_ec_keyb_register_matrix(struct cros_ec_= keyb *ckdev) int err; struct property *prop; const __be32 *p; - u16 *physmap; + u32 *physmap; u32 key_pos; int row, col; =20 @@ -591,10 +589,10 @@ static int cros_ec_keyb_register_matrix(struct cros_e= c_keyb *ckdev) ckdev->idev =3D idev; cros_ec_keyb_compute_valid_keys(ckdev); =20 - physmap =3D ckdev->function_row_physmap; + physmap =3D ckdev->vdata.function_row_physmap; of_property_for_each_u32(dev->of_node, "function-row-physmap", prop, p, key_pos) { - if (ckdev->num_function_row_keys =3D=3D MAX_NUM_TOP_ROW_KEYS) { + if (ckdev->vdata.num_function_row_keys =3D=3D MAX_NUM_TOP_ROW_KEYS) { dev_warn(dev, "Only support up to %d top row keys\n", MAX_NUM_TOP_ROW_KEYS); break; @@ -603,7 +601,7 @@ static int cros_ec_keyb_register_matrix(struct cros_ec_= keyb *ckdev) col =3D KEY_COL(key_pos); *physmap =3D MATRIX_SCAN_CODE(row, col, ckdev->row_shift); physmap++; - ckdev->num_function_row_keys++; + ckdev->vdata.num_function_row_keys++; } =20 err =3D input_register_device(ckdev->idev); @@ -619,18 +617,10 @@ static ssize_t function_row_physmap_show(struct devic= e *dev, struct device_attribute *attr, char *buf) { - ssize_t size =3D 0; - int i; - struct cros_ec_keyb *ckdev =3D dev_get_drvdata(dev); - u16 *physmap =3D ckdev->function_row_physmap; - - for (i =3D 0; i < ckdev->num_function_row_keys; i++) - size +=3D scnprintf(buf + size, PAGE_SIZE - size, - "%s%02X", size ? " " : "", physmap[i]); - if (size) - size +=3D scnprintf(buf + size, PAGE_SIZE - size, "\n"); + const struct cros_ec_keyb *ckdev =3D dev_get_drvdata(dev); + const struct vivaldi_data *data =3D &ckdev->vdata; =20 - return size; + return vivaldi_function_row_physmap_show(data, buf); } =20 static DEVICE_ATTR_RO(function_row_physmap); @@ -648,7 +638,7 @@ static umode_t cros_ec_keyb_attr_is_visible(struct kobj= ect *kobj, struct cros_ec_keyb *ckdev =3D dev_get_drvdata(dev); =20 if (attr =3D=3D &dev_attr_function_row_physmap.attr && - !ckdev->num_function_row_keys) + !ckdev->vdata.num_function_row_keys) return 0; =20 return attr->mode; diff --git a/drivers/input/vivaldi-fmap.c b/drivers/input/vivaldi-fmap.c new file mode 100644 index 000000000000..6dae83d96806 --- /dev/null +++ b/drivers/input/vivaldi-fmap.c @@ -0,0 +1,39 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Helpers for ChromeOS Vivaldi keyboard function row mapping + * + * Copyright (C) 2022 Google, Inc + */ + +#include +#include +#include +#include +#include + +/** + * vivaldi_function_row_physmap_show - Print vivaldi function row physmap = attribute + * @data: The vivaldi function row map + * @buf: Buffer to print the function row phsymap to + */ +ssize_t vivaldi_function_row_physmap_show(const struct vivaldi_data *data, + char *buf) +{ + ssize_t size =3D 0; + int i; + const u32 *physmap =3D data->function_row_physmap; + + if (!data->num_function_row_keys) + return 0; + + for (i =3D 0; i < data->num_function_row_keys; i++) + size +=3D scnprintf(buf + size, PAGE_SIZE - size, + "%s%02X", size ? " " : "", physmap[i]); + if (size) + size +=3D scnprintf(buf + size, PAGE_SIZE - size, "\n"); + + return size; +} +EXPORT_SYMBOL_GPL(vivaldi_function_row_physmap_show); + +MODULE_LICENSE("GPL"); diff --git a/include/linux/input/vivaldi-fmap.h b/include/linux/input/vival= di-fmap.h new file mode 100644 index 000000000000..57563d9da022 --- /dev/null +++ b/include/linux/input/vivaldi-fmap.h @@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _VIVALDI_KEYMAP_H +#define _VIVALDI_KEYMAP_H + +#include + +#define VIVALDI_MIN_FN_ROW_KEY 1 +#define VIVALDI_MAX_FN_ROW_KEY 24 + +/** + * struct vivaldi_data - Function row keymap data for ChromeOS vivaldi key= boards + * @function_row_physmap: An array of the encoded rows/columns for the top + * row function keys, in an order from left to right + * @num_function_row_keys: The number of top row keys in a custom keyboard + * + * This structure is supposed to be used by ChromeOS keyboards using + * the vivaldi keyboard function row design. + */ +struct vivaldi_data { + u32 function_row_physmap[VIVALDI_MAX_FN_ROW_KEY - VIVALDI_MIN_FN_ROW_KEY = + 1]; + int num_function_row_keys; +}; + + +ssize_t vivaldi_function_row_physmap_show(const struct vivaldi_data *data, + char *buf); + +#endif /* _VIVALDI_KEYMAP_H */ --=20 https://chromeos.dev From nobody Sun Jun 28 08:40:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A5EEC433FE for ; Wed, 16 Feb 2022 19:59:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238536AbiBPT74 (ORCPT ); Wed, 16 Feb 2022 14:59:56 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:53162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238493AbiBPT7w (ORCPT ); Wed, 16 Feb 2022 14:59:52 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED669224975 for ; Wed, 16 Feb 2022 11:59:38 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id w20so2795884plq.12 for ; Wed, 16 Feb 2022 11:59:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7zzRJgn+FCqoLjAj0MMNkZ7DXS/JRbjZIdc8xEusdU0=; b=FESKl7EcH8w3bXRbOBtd9IVuVSuTewjG/ItFO8Gkltb5HPM2aDHbpr0tRNQ+u3akLG MsbArPM9yY/periuuZDq0nKvJUt/Xf1kMoFio5qmRsAhILO0qRxtnmAeI0NDiItuqDY/ TpCVjzGeg5hCFYsc7MkAPR9gjw1aVDnQOaCek= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7zzRJgn+FCqoLjAj0MMNkZ7DXS/JRbjZIdc8xEusdU0=; b=cNSyiUOlua2ywdQvodTY9N6l7KxZZxckMlXGBFjIliXTmOu7wZA/TuHZOf73KefTUK U1Tj06bdtB+zHZ1YW8Mcx6js2ws+4UU+AMJb0PZngay8gwOn12m3xNRhS59jy81U5BMa /LULYOo7HJyp7SUcsXg9TyLZqBpe6dpmtuEzt+1tanXlVrEKU7LVyNoPTIk0slJa57bq X8xGtrc1p/0avYWpvI8c6ldhDWZEkOSXUvbE12LnzirrN30zN/XfCVYv+YF99+/409xU UGRSN4y6Z8nvax2S3KiOgdK1mh9acSFCOAxm+4c1wFmfDYnHGlJDW8+RDlSpL3PmL5OS HpyQ== X-Gm-Message-State: AOAM533ROzPL+omljlak1xERhfr3/WVV4ailOTJi00ODYCInPMQMBuzQ rS6Y+IYwht83C8wUlejDBjrMaw== X-Google-Smtp-Source: ABdhPJzYQ/hJ/ixvFZtfAt3j0PWv257QwkVc7Cg7yR4GJiXLrar2/Y2vjByEBfSRgYD6Loalw/FIEw== X-Received: by 2002:a17:902:82cc:b0:14d:93ce:5bef with SMTP id u12-20020a17090282cc00b0014d93ce5befmr4053327plz.39.1645041578424; Wed, 16 Feb 2022 11:59:38 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:202:201:5f39:68a1:3c2b:3486]) by smtp.gmail.com with ESMTPSA id u16sm6078840pgh.54.2022.02.16.11.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 11:59:38 -0800 (PST) From: Stephen Boyd To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, Jiri Kosina , linux-input@vger.kernel.org, "Sean O'Brien" , Douglas Anderson , Zhengqiao Xia , Jiri Kosina Subject: [PATCH v4 2/4] HID: Extract vivaldi hid feature mapping for use in hid-hammer Date: Wed, 16 Feb 2022 11:58:59 -0800 Message-Id: <20220216195901.1326924-3-swboyd@chromium.org> X-Mailer: git-send-email 2.35.1.265.g69c8d7142f-goog In-Reply-To: <20220216195901.1326924-1-swboyd@chromium.org> References: <20220216195901.1326924-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" We need to support parsing the HID device in both the vivaldi and the hammer drivers so that we can properly expose the function row physmap to userspace when a hammer device uses a vivaldi keyboard layout for the function row keys. Extract the feature mapping logic from the vivaldi driver into an hid specific vivaldi library so we can use it from both HID drivers. Cc: Jiri Kosina Cc: Dmitry Torokhov Tested-by: "Sean O'Brien" Cc: Douglas Anderson Cc: Zhengqiao Xia Acked-by: Jiri Kosina Signed-off-by: Stephen Boyd --- drivers/hid/Kconfig | 9 +++ drivers/hid/Makefile | 1 + drivers/hid/hid-vivaldi-common.c | 97 ++++++++++++++++++++++++++++++ drivers/hid/hid-vivaldi.c | 69 +-------------------- include/linux/input/vivaldi-fmap.h | 9 +++ 5 files changed, 118 insertions(+), 67 deletions(-) create mode 100644 drivers/hid/hid-vivaldi-common.c diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 5569a2029dab..ea8fa71c9e9c 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -403,14 +403,23 @@ config HOLTEK_FF Say Y here if you have a Holtek On Line Grip based game controller and want to have force feedback support for it. =20 +config HID_VIVALDI_COMMON + tristate + help + ChromeOS Vivaldi HID parsing support library. This is a hidden + option so that drivers can use common code to parse the HID + descriptors for vivaldi function row keymap. + config HID_GOOGLE_HAMMER tristate "Google Hammer Keyboard" + select HID_VIVALDI_COMMON depends on USB_HID && LEDS_CLASS && CROS_EC help Say Y here if you have a Google Hammer device. =20 config HID_VIVALDI tristate "Vivaldi Keyboard" + select HID_VIVALDI_COMMON select INPUT_VIVALDIFMAP depends on HID help diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile index 6d3e630e81af..469a6159ebae 100644 --- a/drivers/hid/Makefile +++ b/drivers/hid/Makefile @@ -50,6 +50,7 @@ obj-$(CONFIG_HID_FT260) +=3D hid-ft260.o obj-$(CONFIG_HID_GEMBIRD) +=3D hid-gembird.o obj-$(CONFIG_HID_GFRM) +=3D hid-gfrm.o obj-$(CONFIG_HID_GLORIOUS) +=3D hid-glorious.o +obj-$(CONFIG_HID_VIVALDI_COMMON) +=3D hid-vivaldi-common.o obj-$(CONFIG_HID_GOOGLE_HAMMER) +=3D hid-google-hammer.o obj-$(CONFIG_HID_VIVALDI) +=3D hid-vivaldi.o obj-$(CONFIG_HID_GT683R) +=3D hid-gt683r.o diff --git a/drivers/hid/hid-vivaldi-common.c b/drivers/hid/hid-vivaldi-com= mon.c new file mode 100644 index 000000000000..8a5074fd63b7 --- /dev/null +++ b/drivers/hid/hid-vivaldi-common.c @@ -0,0 +1,97 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Helpers for ChromeOS HID Vivaldi keyboards + * + * Copyright (C) 2022 Google, Inc + */ + +#include +#include +#include +#include +#include +#include + +#define HID_VD_FN_ROW_PHYSMAP 0x00000001 +#define HID_USAGE_FN_ROW_PHYSMAP (HID_UP_GOOGLEVENDOR | HID_VD_FN_ROW_PHYS= MAP) + +/** + * vivaldi_hid_feature_mapping - Fill out vivaldi keymap data exposed via = HID + * @data: The vivaldi function keymap + * @hdev: HID device to parse + * @field: HID field to parse + * @usage: HID usage to parse + */ +void vivaldi_hid_feature_mapping(struct vivaldi_data *data, + struct hid_device *hdev, + struct hid_field *field, + struct hid_usage *usage) +{ + struct hid_report *report =3D field->report; + int fn_key; + int ret; + u32 report_len; + u8 *report_data, *buf; + + if (field->logical !=3D HID_USAGE_FN_ROW_PHYSMAP || + (usage->hid & HID_USAGE_PAGE) !=3D HID_UP_ORDINAL) + return; + + fn_key =3D (usage->hid & HID_USAGE); + if (fn_key < VIVALDI_MIN_FN_ROW_KEY || fn_key > VIVALDI_MAX_FN_ROW_KEY) + return; + if (fn_key > data->num_function_row_keys) + data->num_function_row_keys =3D fn_key; + + report_data =3D buf =3D hid_alloc_report_buf(report, GFP_KERNEL); + if (!report_data) + return; + + report_len =3D hid_report_len(report); + if (!report->id) { + /* + * hid_hw_raw_request() will stuff report ID (which will be 0) + * into the first byte of the buffer even for unnumbered + * reports, so we need to account for this to avoid getting + * -EOVERFLOW in return. + * Note that hid_alloc_report_buf() adds 7 bytes to the size + * so we can safely say that we have space for an extra byte. + */ + report_len++; + } + + ret =3D hid_hw_raw_request(hdev, report->id, report_data, + report_len, HID_FEATURE_REPORT, + HID_REQ_GET_REPORT); + if (ret < 0) { + dev_warn(&hdev->dev, "failed to fetch feature %d\n", + field->report->id); + goto out; + } + + if (!report->id) { + /* + * Undo the damage from hid_hw_raw_request() for unnumbered + * reports. + */ + report_data++; + report_len--; + } + + ret =3D hid_report_raw_event(hdev, HID_FEATURE_REPORT, report_data, + report_len, 0); + if (ret) { + dev_warn(&hdev->dev, "failed to report feature %d\n", + field->report->id); + goto out; + } + + data->function_row_physmap[fn_key - VIVALDI_MIN_FN_ROW_KEY] =3D + field->value[usage->usage_index]; + +out: + kfree(buf); +} +EXPORT_SYMBOL_GPL(vivaldi_hid_feature_mapping); + +MODULE_LICENSE("GPL"); diff --git a/drivers/hid/hid-vivaldi.c b/drivers/hid/hid-vivaldi.c index adb56b342948..f70cab6a192b 100644 --- a/drivers/hid/hid-vivaldi.c +++ b/drivers/hid/hid-vivaldi.c @@ -13,9 +13,6 @@ #include #include =20 -#define HID_VD_FN_ROW_PHYSMAP 0x00000001 -#define HID_USAGE_FN_ROW_PHYSMAP (HID_UP_GOOGLEVENDOR | HID_VD_FN_ROW_PHYS= MAP) - static ssize_t function_row_physmap_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -60,70 +57,8 @@ static void vivaldi_feature_mapping(struct hid_device *h= dev, struct hid_usage *usage) { struct vivaldi_data *drvdata =3D hid_get_drvdata(hdev); - struct hid_report *report =3D field->report; - int fn_key; - int ret; - u32 report_len; - u8 *report_data, *buf; - - if (field->logical !=3D HID_USAGE_FN_ROW_PHYSMAP || - (usage->hid & HID_USAGE_PAGE) !=3D HID_UP_ORDINAL) - return; - - fn_key =3D (usage->hid & HID_USAGE); - if (fn_key < VIVALDI_MIN_FN_ROW_KEY || fn_key > VIVALDI_MAX_FN_ROW_KEY) - return; - if (fn_key > drvdata->num_function_row_keys) - drvdata->num_function_row_keys =3D fn_key; - - report_data =3D buf =3D hid_alloc_report_buf(report, GFP_KERNEL); - if (!report_data) - return; - - report_len =3D hid_report_len(report); - if (!report->id) { - /* - * hid_hw_raw_request() will stuff report ID (which will be 0) - * into the first byte of the buffer even for unnumbered - * reports, so we need to account for this to avoid getting - * -EOVERFLOW in return. - * Note that hid_alloc_report_buf() adds 7 bytes to the size - * so we can safely say that we have space for an extra byte. - */ - report_len++; - } - - ret =3D hid_hw_raw_request(hdev, report->id, report_data, - report_len, HID_FEATURE_REPORT, - HID_REQ_GET_REPORT); - if (ret < 0) { - dev_warn(&hdev->dev, "failed to fetch feature %d\n", - field->report->id); - goto out; - } - - if (!report->id) { - /* - * Undo the damage from hid_hw_raw_request() for unnumbered - * reports. - */ - report_data++; - report_len--; - } - - ret =3D hid_report_raw_event(hdev, HID_FEATURE_REPORT, report_data, - report_len, 0); - if (ret) { - dev_warn(&hdev->dev, "failed to report feature %d\n", - field->report->id); - goto out; - } - - drvdata->function_row_physmap[fn_key - VIVALDI_MIN_FN_ROW_KEY] =3D - field->value[usage->usage_index]; - -out: - kfree(buf); + + vivaldi_hid_feature_mapping(drvdata, hdev, field, usage); } =20 static int vivaldi_input_configured(struct hid_device *hdev, diff --git a/include/linux/input/vivaldi-fmap.h b/include/linux/input/vival= di-fmap.h index 57563d9da022..c736200b4511 100644 --- a/include/linux/input/vivaldi-fmap.h +++ b/include/linux/input/vivaldi-fmap.h @@ -4,6 +4,10 @@ =20 #include =20 +struct hid_device; +struct hid_field; +struct hid_usage; + #define VIVALDI_MIN_FN_ROW_KEY 1 #define VIVALDI_MAX_FN_ROW_KEY 24 =20 @@ -25,4 +29,9 @@ struct vivaldi_data { ssize_t vivaldi_function_row_physmap_show(const struct vivaldi_data *data, char *buf); =20 +void vivaldi_hid_feature_mapping(struct vivaldi_data *data, + struct hid_device *hdev, + struct hid_field *field, + struct hid_usage *usage); + #endif /* _VIVALDI_KEYMAP_H */ --=20 https://chromeos.dev From nobody Sun Jun 28 08:40:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87691C433EF for ; Wed, 16 Feb 2022 19:59:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238544AbiBPT77 (ORCPT ); Wed, 16 Feb 2022 14:59:59 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:53306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238503AbiBPT7x (ORCPT ); Wed, 16 Feb 2022 14:59:53 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31FE1225D25 for ; Wed, 16 Feb 2022 11:59:40 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id l8so2813182pls.7 for ; Wed, 16 Feb 2022 11:59:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZsArcPLzwU139LqlYjrn4d9c9GOUY8IaJObBEiXsIzE=; b=YIw/L774Mbxh0MZaNq5KMenlLvyZDjU6/aA40MeTaMZl2Ph4SvvbQjHsqzQy4fZHNY ZiTuUe6r0XaSjohqyYy0fqpXLWogwzPwvwAb883EnHllyDGU+Y85LC8YO9ytFwMGbkIE QN+bMxHeRIW7Mg3bYCJXCrt2IviKEJaBsW8t8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZsArcPLzwU139LqlYjrn4d9c9GOUY8IaJObBEiXsIzE=; b=DOQU7/esucBvhBUUjL+ldzrYO5XzWaYGhcWrw7MkvwaFVld1FdB0YOcmnmJgD7Lac0 dyhIarAiU3xXCNeK/klEolKk5SmBLo17PJyhCUNGMdHHy5Kn1EEaCLdYm6QTC0R31n1z 6XefzkEHpVk+TnFqgfdw1Rn+ODFKcgAIaxu95fjovyhAUqzOGYr8G8qYQCJoCVByASnj ij+lS6EJOpH96Tpg0IQB0XIx9JMRfLJF+RE+0KZV8hKJySzj5j4T+XSHhUiCewaTpX0I 1GXV6Te7dS8XzUUv62iFSBkwCF3vEAkef5aG+4UsD/GvidvjuSeMpPRYOUPWdm9yqZiN qt0Q== X-Gm-Message-State: AOAM53299K5P+uF5pDMpTvm9xlCZFT2vRJcDz6b+U9MP/dqzrUaOiy0q w4zBQf/MOk09sSBS2YN6Wh4qyQ== X-Google-Smtp-Source: ABdhPJwXZEChPlCeDDQSOO5I9FClC5QEGq/U47IvxZTa6AwJnNy8xFg2oRS3hOjEPTCJn9NB9L+Dxw== X-Received: by 2002:a17:90a:588c:b0:1b8:8780:5ce with SMTP id j12-20020a17090a588c00b001b8878005cemr3545673pji.187.1645041579490; Wed, 16 Feb 2022 11:59:39 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:202:201:5f39:68a1:3c2b:3486]) by smtp.gmail.com with ESMTPSA id u16sm6078840pgh.54.2022.02.16.11.59.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 11:59:39 -0800 (PST) From: Stephen Boyd To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, Jiri Kosina , linux-input@vger.kernel.org, "Sean O'Brien" , Douglas Anderson , Zhengqiao Xia , Jiri Kosina Subject: [PATCH v4 3/4] HID: google: Add support for vivaldi to hid-hammer Date: Wed, 16 Feb 2022 11:59:00 -0800 Message-Id: <20220216195901.1326924-4-swboyd@chromium.org> X-Mailer: git-send-email 2.35.1.265.g69c8d7142f-goog In-Reply-To: <20220216195901.1326924-1-swboyd@chromium.org> References: <20220216195901.1326924-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support to the hammer driver to parse vivaldi keyboard layouts and expose them to userspace. This allows hammer devices to use vivaldi function row keys while also supporting the other features this driver supports, like the CBAS (chrome base attached switch) and a keyboard backlight. Cc: Jiri Kosina Cc: Dmitry Torokhov Tested-by: "Sean O'Brien" Cc: Douglas Anderson Cc: Zhengqiao Xia Acked-by: Jiri Kosina Signed-off-by: Stephen Boyd --- drivers/hid/Kconfig | 1 + drivers/hid/hid-google-hammer.c | 95 +++++++++++++++++++++++++-------- 2 files changed, 75 insertions(+), 21 deletions(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index ea8fa71c9e9c..4bea966e617b 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -413,6 +413,7 @@ config HID_VIVALDI_COMMON config HID_GOOGLE_HAMMER tristate "Google Hammer Keyboard" select HID_VIVALDI_COMMON + select INPUT_VIVALDIFMAP depends on USB_HID && LEDS_CLASS && CROS_EC help Say Y here if you have a Google Hammer device. diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hamme= r.c index 0403beb3104b..f8e6dccf6ed8 100644 --- a/drivers/hid/hid-google-hammer.c +++ b/drivers/hid/hid-google-hammer.c @@ -15,6 +15,7 @@ =20 #include #include +#include #include #include #include @@ -22,6 +23,7 @@ #include #include #include +#include #include =20 #include "hid-ids.h" @@ -300,6 +302,11 @@ struct hammer_kbd_leds { u8 buf[2] ____cacheline_aligned; }; =20 +struct hammer_drvdata { + struct vivaldi_data vdata; + struct hammer_kbd_leds leds; +}; + static int hammer_kbd_brightness_set_blocking(struct led_classdev *cdev, enum led_brightness br) { @@ -337,15 +344,11 @@ static int hammer_kbd_brightness_set_blocking(struct = led_classdev *cdev, return ret; } =20 -static int hammer_register_leds(struct hid_device *hdev) +static int hammer_register_leds(struct hammer_drvdata *hdata, struct hid_d= evice *hdev) { struct hammer_kbd_leds *kbd_backlight; - int error; - - kbd_backlight =3D kzalloc(sizeof(*kbd_backlight), GFP_KERNEL); - if (!kbd_backlight) - return -ENOMEM; =20 + kbd_backlight =3D &hdata->leds; kbd_backlight->hdev =3D hdev; kbd_backlight->cdev.name =3D "hammer::kbd_backlight"; kbd_backlight->cdev.max_brightness =3D MAX_BRIGHTNESS; @@ -356,26 +359,16 @@ static int hammer_register_leds(struct hid_device *hd= ev) /* Set backlight to 0% initially. */ hammer_kbd_brightness_set_blocking(&kbd_backlight->cdev, 0); =20 - error =3D led_classdev_register(&hdev->dev, &kbd_backlight->cdev); - if (error) - goto err_free_mem; - - hid_set_drvdata(hdev, kbd_backlight); - return 0; - -err_free_mem: - kfree(kbd_backlight); - return error; + return led_classdev_register(&hdev->dev, &kbd_backlight->cdev); } =20 static void hammer_unregister_leds(struct hid_device *hdev) { - struct hammer_kbd_leds *kbd_backlight =3D hid_get_drvdata(hdev); + struct hammer_drvdata *hdata =3D hid_get_drvdata(hdev); + struct hammer_kbd_leds *kbd_backlight =3D &hdata->leds; =20 - if (kbd_backlight) { + if (kbd_backlight) led_classdev_unregister(&kbd_backlight->cdev); - kfree(kbd_backlight); - } } =20 #define HID_UP_GOOGLEVENDOR 0xffd10000 @@ -385,6 +378,58 @@ static void hammer_unregister_leds(struct hid_device *= hdev) /* HID usage for keyboard backlight (Alphanumeric display brightness) */ #define HID_AD_BRIGHTNESS 0x00140046 =20 +static void hammer_feature_mapping(struct hid_device *hdev, + struct hid_field *field, + struct hid_usage *usage) +{ + struct hammer_drvdata *hdata =3D hid_get_drvdata(hdev); + + vivaldi_hid_feature_mapping(&hdata->vdata, hdev, field, usage); +} + +static ssize_t function_row_physmap_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct hid_device *hdev =3D to_hid_device(dev); + struct hammer_drvdata *hdata =3D hid_get_drvdata(hdev); + struct vivaldi_data *vdata =3D &hdata->vdata; + + return vivaldi_function_row_physmap_show(vdata, buf); +} + +static DEVICE_ATTR_RO(function_row_physmap); +static struct attribute *hammer_sysfs_attrs[] =3D { + &dev_attr_function_row_physmap.attr, + NULL +}; + +static umode_t hammer_attr_is_visible(struct kobject *kobj, + struct attribute *attr, int n) +{ + struct device *dev =3D kobj_to_dev(kobj); + struct hid_device *hdev =3D to_hid_device(dev); + struct hammer_drvdata *hdata =3D hid_get_drvdata(hdev); + struct vivaldi_data *vdata =3D &hdata->vdata; + + if (attr =3D=3D &dev_attr_function_row_physmap.attr && + !vdata->num_function_row_keys) + return 0; + + return attr->mode; +} + +static const struct attribute_group input_attribute_group =3D { + .is_visible =3D hammer_attr_is_visible, + .attrs =3D hammer_sysfs_attrs, +}; + +static int hammer_input_configured(struct hid_device *hdev, + struct hid_input *hidinput) +{ + return sysfs_create_group(&hdev->dev.kobj, &input_attribute_group); +} + static int hammer_input_mapping(struct hid_device *hdev, struct hid_input = *hi, struct hid_field *field, struct hid_usage *usage, @@ -516,6 +561,12 @@ static int hammer_probe(struct hid_device *hdev, const struct hid_device_id *id) { int error; + struct hammer_drvdata *hdata; + + hdata =3D devm_kzalloc(&hdev->dev, sizeof(*hdata), GFP_KERNEL); + if (!hdata) + return -ENOMEM; + hid_set_drvdata(hdev, hdata); =20 error =3D hid_parse(hdev); if (error) @@ -541,7 +592,7 @@ static int hammer_probe(struct hid_device *hdev, } =20 if (hammer_has_backlight_control(hdev)) { - error =3D hammer_register_leds(hdev); + error =3D hammer_register_leds(hdata, hdev); if (error) hid_warn(hdev, "Failed to register keyboard backlight: %d\n", @@ -610,6 +661,8 @@ static struct hid_driver hammer_driver =3D { .id_table =3D hammer_devices, .probe =3D hammer_probe, .remove =3D hammer_remove, + .feature_mapping =3D hammer_feature_mapping, + .input_configured =3D hammer_input_configured, .input_mapping =3D hammer_input_mapping, .event =3D hammer_event, }; --=20 https://chromeos.dev From nobody Sun Jun 28 08:40:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8DC9C433EF for ; Wed, 16 Feb 2022 19:59:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238551AbiBPUAB (ORCPT ); Wed, 16 Feb 2022 15:00:01 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:53316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238509AbiBPT7x (ORCPT ); Wed, 16 Feb 2022 14:59:53 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA3E225D3C for ; Wed, 16 Feb 2022 11:59:41 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id x4so2820247plb.4 for ; Wed, 16 Feb 2022 11:59:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gKkiGODEySwn5Ud6cwmFKt9S5uiVPYEjk/1FwzY1D7M=; b=FbCQhqCgY7+53halAemFJqR+/yEcT2gQBP93JU9UC8PAh275Z04yeP2cnPk8Byycoa /6zwqH/8Dl7HBUIlAHe1l1LWGmjjWLR4OXWCNR8gwqRgFZXOvrZ0JahDSAUi2NXaAJf3 UKiz/7cjikcMEKRvFhkHpKC42JAbLsbQvj5zA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gKkiGODEySwn5Ud6cwmFKt9S5uiVPYEjk/1FwzY1D7M=; b=JteN8Z3Lym1fw1sOTrcWH3pOdZgYhJFp4hR0jy/wHstSJf2epURMGkS8U9g57QBLLy 9sMPb13uiUfl5xLCgUw8SA4T9w1GmAv6VX47el1euCxnlh5yWzgZa+ffOA/Jl2OJtwzG gy2kirWc6iEF8XqUhuKt6TUfaldcWcQYWyVqWFr8zO1+rJsCDi+zzYNLn3ly3yDcvcEy AEgQPTmuDaPw8xmV2D3tHbaA/RjCWsqAkqUh/mJ+6tA/lHH77xHcPSFMULCgpofNz/sY 8vpj69N/S0eej3wD520+WvJhw6M658ztsc777PhunJdhPVpwN/9bACiwao/ydbRDV2bv tElw== X-Gm-Message-State: AOAM533c6igDf+RrwCpe20m/8UCABEl2qPJNUee/NocNgNlFU9vwB5mo FEhe/Gg1nGlWT393cag2IKyqDqfWnAFMOA== X-Google-Smtp-Source: ABdhPJwjYxlN7gSR+7kFrYETcwqEK3eVK6gnPbD8ydzhwRC3qOldpUKOhhtBXZcjj79BjVyZBXsn2w== X-Received: by 2002:a17:902:b116:b0:14f:460d:bf42 with SMTP id q22-20020a170902b11600b0014f460dbf42mr4195532plr.108.1645041580606; Wed, 16 Feb 2022 11:59:40 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:202:201:5f39:68a1:3c2b:3486]) by smtp.gmail.com with ESMTPSA id u16sm6078840pgh.54.2022.02.16.11.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 11:59:40 -0800 (PST) From: Stephen Boyd To: Dmitry Torokhov Cc: Zhengqiao Xia , linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, Jiri Kosina , linux-input@vger.kernel.org, "Sean O'Brien" , Douglas Anderson , Jiri Kosina Subject: [PATCH v4 4/4] HID: google: modify HID device groups of eel Date: Wed, 16 Feb 2022 11:59:01 -0800 Message-Id: <20220216195901.1326924-5-swboyd@chromium.org> X-Mailer: git-send-email 2.35.1.265.g69c8d7142f-goog In-Reply-To: <20220216195901.1326924-1-swboyd@chromium.org> References: <20220216195901.1326924-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Zhengqiao Xia If HID_GROUP of eel is set to HID_GROUP_GENERIC, Whiskers Tablet Mode Switch of eel hammer will not be detected by system because the hid-vivaldi driver probes the device. When it is set to HID_GROUP_VIVALDI, system will detect Whiskers Tablet Mode Switch successfully and also support the vivaldi keyboard layout. Cc: Jiri Kosina Cc: Dmitry Torokhov Tested-by: "Sean O'Brien" Cc: Douglas Anderson Acked-by: Jiri Kosina Signed-off-by: Zhengqiao Xia [swboyd@chromium.org: Expand on commit text] Signed-off-by: Stephen Boyd --- drivers/hid/hid-google-hammer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hamme= r.c index f8e6dccf6ed8..8c4881796a0c 100644 --- a/drivers/hid/hid-google-hammer.c +++ b/drivers/hid/hid-google-hammer.c @@ -636,7 +636,7 @@ static void hammer_remove(struct hid_device *hdev) static const struct hid_device_id hammer_devices[] =3D { { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC, USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_DON) }, - { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC, + { HID_DEVICE(BUS_USB, HID_GROUP_VIVALDI, USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_EEL) }, { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC, USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_HAMMER) }, --=20 https://chromeos.dev