From nobody Sun Jun 28 05:34:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85C30C433F5 for ; Mon, 14 Feb 2022 05:37:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240454AbiBNFhm (ORCPT ); Mon, 14 Feb 2022 00:37:42 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239471AbiBNFhi (ORCPT ); Mon, 14 Feb 2022 00:37:38 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF9324EA18 for ; Sun, 13 Feb 2022 21:37:29 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id m10-20020a25800a000000b0061daa5b7151so31693545ybk.10 for ; Sun, 13 Feb 2022 21:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=RM7B/VP3RiMIbRxHXAkoswg4A5f1B95tqoOVGTsgT8Q=; b=TTbMKvwz6PseJb5lRAXLQiBv75QGAS10Z9JTQyCyZ32BBng4ecFDNGi05LGrA57+Fv +cgxTg66+Ae6IeLW50dDVi+h2CZqYrwt9erF1a+Qa3ZqUuQnXUpkEhOLGdZEDsmEtlOD aa4oKgzbTO7qdsYuMM9iefxLmoVMihDg2tb+VlAp/Hdb2c5gQwONJz1XJ01Jl5Ln9xl7 jq4QV7B/naowDN69QoT8aNjnfHnCL5sbZxKazEBN2lAJpA8RKeNzdRDr0T2UqrxznoZr FC8aW/1Lq/VsZWV1tzNCy/EIcMbu6uaLKupmhBW6xUQeT0FcH85gsLXHR3nPNvCTJQ4R vDbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=RM7B/VP3RiMIbRxHXAkoswg4A5f1B95tqoOVGTsgT8Q=; b=1QS55yfjV7rllizRfsznIKyvJT8y3bsJKlpJkHXq4gghxcC4mljF506MBJpElMeNnR I4m1nSbzlgcQOu1dB4GCJEREFrzpOiyD0krU0WluyAtD/m0I5H49Qfn2kct6t/TKj6UI 0ckpLORFOFlZnJC0iT3q6foyV2Qx91m/MCkM2SVke4wYF3fnIOnDJc6Nn+zC+8BqvHrF Ph4lJiVXnafoRsN5kJD5B9Pv9jIWEI96Kos1+Ujq3rWHIWz7wOgdY9az2InGeRpZT0dh xDcT8zdtsk1yf1RiDijEXmVgURktc7XN1LGT1HeKsoYF3vDrpVoesQpOfMfTDAmRvne/ vorw== X-Gm-Message-State: AOAM530RakpgGs/K5IgtJMopVJJZi1qG7L3fp9/azd+DK8gbo8Jgf/uz IdqZIDl37uyv1vADiQR0UJ6aVgx6Ft+b X-Google-Smtp-Source: ABdhPJx+13Gw/OOKY8khKfw7V8FFpvA8xTR4gZkToZpRpsfvFKIV+UFm7cr8RGYsxDkI86AyD9bMelqUh6+q X-Received: from tzungbi-z840.tpe.corp.google.com ([2401:fa00:1:10:f315:f92d:e3d3:2539]) (user=tzungbi job=sendgmr) by 2002:a25:e705:: with SMTP id e5mr786251ybh.216.1644817049075; Sun, 13 Feb 2022 21:37:29 -0800 (PST) Date: Mon, 14 Feb 2022 13:36:42 +0800 In-Reply-To: <20220214053646.3088298-1-tzungbi@google.com> Message-Id: <20220214053646.3088298-2-tzungbi@google.com> Mime-Version: 1.0 References: <20220214053646.3088298-1-tzungbi@google.com> X-Mailer: git-send-email 2.35.1.265.g69c8d7142f-goog Subject: [PATCH 1/5] platform/chrome: cros_kbd_led_backlight: sort headers alphabetically From: Tzung-Bi Shih To: bleung@chromium.org, groeck@chromium.org, robh+dt@kernel.org Cc: chrome-platform@lists.linux.dev, tzungbi@google.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Tzung-Bi Shih --- drivers/platform/chrome/cros_kbd_led_backlight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/pla= tform/chrome/cros_kbd_led_backlight.c index aa409f0201fb..f9587a562bb7 100644 --- a/drivers/platform/chrome/cros_kbd_led_backlight.c +++ b/drivers/platform/chrome/cros_kbd_led_backlight.c @@ -4,12 +4,12 @@ // Copyright (C) 2012 Google, Inc. =20 #include -#include #include #include -#include #include #include +#include +#include #include #include =20 --=20 2.35.1.265.g69c8d7142f-goog From nobody Sun Jun 28 05:34:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FBB0C433EF for ; Mon, 14 Feb 2022 05:37:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240481AbiBNFhp (ORCPT ); Mon, 14 Feb 2022 00:37:45 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240460AbiBNFhl (ORCPT ); Mon, 14 Feb 2022 00:37:41 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 156B74EA35 for ; Sun, 13 Feb 2022 21:37:34 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id c10-20020a251c0a000000b0062272fc32bfso7053389ybc.17 for ; Sun, 13 Feb 2022 21:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=mvUncpaYliSmeR41+C/l/4otzikQqLf0u/Gn7UTF124=; b=CgnY/Etxq1CyrqQlo1UL4rL1ybmB5rCQ+6pY/MvGGHYyeaRQsk2wYMLegZQZEcwZsJ NyGIccHYFaOnm98G3N7N85lg3DLRQ7xGG5rxkwVD7W95E1+D1weAeD1yk3Q10IZ6Amt0 Hw8qX+xAGOHGlE0R+X5VypIs+M8lpKY2gB5VlccfDK524l+q/KlnvnXOk3phmLmmhOdC TWGytAKQp4Gjxj/7h2Ud6bRoDWdzV9b0SiI//E+GziCKNvcwaptlfJuY47cilCo+nf3/ m9Jx0k1qUxPpzzVO1nVgKvVuUO5dymF7qS3N42RoXWnbLGLQh/LgCxMxVBKPecZ3yFY9 XkXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=mvUncpaYliSmeR41+C/l/4otzikQqLf0u/Gn7UTF124=; b=nwIVFPLn/BhEjnNpKeLY2HUkISBFU8SG2TDmQm+197Op0kkUCXaaM5H7jWKUH/P8xI 4n7/zMED7OYtuDP5zxZUAL58FrxZbg29OmkJhZSYgiWacO7Evm01kD9hqRf0KjOTj97R ynZWHm1/wV28lhzMR2rI13nEPktYaANaJm0UKyweuRzpKGO/ymP3DJYE7ltX2SY/jjEJ 3z7vLBjk/FjmxwpBVrg4BXgscf5MDux1Dm8W7FCEGX6Z45ZC3C15rHOOH81oF4zzIxzb mwvCbuHT6fibgPA6KghUfElsuyKbOHrqwvdnNsRfFmfgWzISt2FeBiU0gLrjofBdMNoB IqNA== X-Gm-Message-State: AOAM5326+azHVgGHg1aS9QlWhNoIhfqg0YqNH9Ljk+3ZQqECKjagb5rD 4evbcdpMZEyDGXbC3BX/cZuC1SkLn/lm X-Google-Smtp-Source: ABdhPJyvjfHE/YYj+ehvCI5kt0131cYqhmHlQgRbK0thqB8SDSpmLWhwKARAD9ExhYgg6qDWIzUjIoLS8icM X-Received: from tzungbi-z840.tpe.corp.google.com ([2401:fa00:1:10:f315:f92d:e3d3:2539]) (user=tzungbi job=sendgmr) by 2002:a25:d9ce:: with SMTP id q197mr10879482ybg.739.1644817053360; Sun, 13 Feb 2022 21:37:33 -0800 (PST) Date: Mon, 14 Feb 2022 13:36:43 +0800 In-Reply-To: <20220214053646.3088298-1-tzungbi@google.com> Message-Id: <20220214053646.3088298-3-tzungbi@google.com> Mime-Version: 1.0 References: <20220214053646.3088298-1-tzungbi@google.com> X-Mailer: git-send-email 2.35.1.265.g69c8d7142f-goog Subject: [PATCH 2/5] platform/chrome: cros_kbd_led_backlight: separate ACPI backend From: Tzung-Bi Shih To: bleung@chromium.org, groeck@chromium.org, robh+dt@kernel.org Cc: chrome-platform@lists.linux.dev, tzungbi@google.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" cros_kbd_led_backlight uses ACPI_KEYBOARD_BACKLIGHT_WRITE and ACPI_KEYBOARD_BACKLIGHT_READ for setting and getting the brightness respectively. Separate ACPI operations as an independent option for preparing the driver to support other backends. Signed-off-by: Tzung-Bi Shih --- drivers/platform/chrome/Kconfig | 8 +- .../platform/chrome/cros_kbd_led_backlight.c | 91 ++++++++++++++++--- 2 files changed, 85 insertions(+), 14 deletions(-) diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kcon= fig index ccc23d8686e8..3f74679a556c 100644 --- a/drivers/platform/chrome/Kconfig +++ b/drivers/platform/chrome/Kconfig @@ -128,7 +128,7 @@ config CROS_EC_PROTO =20 config CROS_KBD_LED_BACKLIGHT tristate "Backlight LED support for Chrome OS keyboards" - depends on LEDS_CLASS && ACPI + depends on LEDS_CLASS help This option enables support for the keyboard backlight LEDs on select Chrome OS systems. @@ -136,6 +136,12 @@ config CROS_KBD_LED_BACKLIGHT To compile this driver as a module, choose M here: the module will be called cros_kbd_led_backlight. =20 +config CROS_KBD_LED_BACKLIGHT_ACPI + bool "ChromeOS keyboard backlight ACPI backend" + depends on ACPI && CROS_KBD_LED_BACKLIGHT + help + ChromeOS keyboard backlight ACPI backend. + config CROS_EC_CHARDEV tristate "ChromeOS EC miscdevice" depends on MFD_CROS_EC_DEV diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/pla= tform/chrome/cros_kbd_led_backlight.c index f9587a562bb7..814f2b74c602 100644 --- a/drivers/platform/chrome/cros_kbd_led_backlight.c +++ b/drivers/platform/chrome/cros_kbd_led_backlight.c @@ -13,6 +13,33 @@ #include #include =20 +/** + * struct keyboard_led_drvdata - keyboard LED driver data. + * @init: Init function. + * @brightness_get: Get LED brightness level. + * @brightness_set: Set LED brightness level. Must not sleep. + * @brightness_set_blocking: Set LED brightness level. It can block the + * caller for the time required for accessing a + * LED device register + * @max_brightness: Maximum brightness. + * + * See struct led_classdev in include/linux/leds.h for more details. + */ +struct keyboard_led_drvdata { + int (*init)(struct platform_device *pdev); + + enum led_brightness (*brightness_get)(struct led_classdev *led_cdev); + + void (*brightness_set)(struct led_classdev *led_cdev, + enum led_brightness brightness); + int (*brightness_set_blocking)(struct led_classdev *led_cdev, + enum led_brightness brightness); + + enum led_brightness max_brightness; +}; + +#if IS_ENABLED(CONFIG_CROS_KBD_LED_BACKLIGHT_ACPI) + /* Keyboard LED ACPI Device must be defined in firmware */ #define ACPI_KEYBOARD_BACKLIGHT_DEVICE "\\_SB.KBLT" #define ACPI_KEYBOARD_BACKLIGHT_READ ACPI_KEYBOARD_BACKLIGHT_DEVICE ".KBQC" @@ -20,8 +47,8 @@ =20 #define ACPI_KEYBOARD_BACKLIGHT_MAX 100 =20 -static void keyboard_led_set_brightness(struct led_classdev *cdev, - enum led_brightness brightness) +static void keyboard_led_set_brightness_acpi(struct led_classdev *cdev, + enum led_brightness brightness) { union acpi_object param; struct acpi_object_list input; @@ -40,7 +67,7 @@ static void keyboard_led_set_brightness(struct led_classd= ev *cdev, } =20 static enum led_brightness -keyboard_led_get_brightness(struct led_classdev *cdev) +keyboard_led_get_brightness_acpi(struct led_classdev *cdev) { unsigned long long brightness; acpi_status status; @@ -56,12 +83,10 @@ keyboard_led_get_brightness(struct led_classdev *cdev) return brightness; } =20 -static int keyboard_led_probe(struct platform_device *pdev) +static int keyboard_led_init_acpi(struct platform_device *pdev) { - struct led_classdev *cdev; acpi_handle handle; acpi_status status; - int error; =20 /* Look for the keyboard LED ACPI Device */ status =3D acpi_get_handle(ACPI_ROOT_OBJECT, @@ -73,15 +98,55 @@ static int keyboard_led_probe(struct platform_device *p= dev) return -ENXIO; } =20 + return 0; +} + +static const struct keyboard_led_drvdata keyboard_led_drvdata_acpi =3D { + .init =3D keyboard_led_init_acpi, + .brightness_set =3D keyboard_led_set_brightness_acpi, + .brightness_get =3D keyboard_led_get_brightness_acpi, + .max_brightness =3D ACPI_KEYBOARD_BACKLIGHT_MAX, +}; + +#else /* IS_ENABLED(CONFIG_CROS_KBD_LED_BACKLIGHT_ACPI) */ + +static int keyboard_led_init_acpi_null(struct platform_device *pdev) +{ + return -EOPNOTSUPP; +} + +static const struct keyboard_led_drvdata keyboard_led_drvdata_acpi =3D { + .init =3D keyboard_led_init_acpi_null, +}; + +#endif /* IS_ENABLED(CONFIG_CROS_KBD_LED_BACKLIGHT_ACPI) */ + +static int keyboard_led_probe(struct platform_device *pdev) +{ + struct led_classdev *cdev; + const struct keyboard_led_drvdata *drvdata; + int error; + + drvdata =3D acpi_device_get_match_data(&pdev->dev); + if (!drvdata) + return -EINVAL; + + if (drvdata->init) { + error =3D drvdata->init(pdev); + if (error) + return error; + } + cdev =3D devm_kzalloc(&pdev->dev, sizeof(*cdev), GFP_KERNEL); if (!cdev) return -ENOMEM; =20 cdev->name =3D "chromeos::kbd_backlight"; - cdev->max_brightness =3D ACPI_KEYBOARD_BACKLIGHT_MAX; cdev->flags |=3D LED_CORE_SUSPENDRESUME; - cdev->brightness_set =3D keyboard_led_set_brightness; - cdev->brightness_get =3D keyboard_led_get_brightness; + cdev->max_brightness =3D drvdata->max_brightness; + cdev->brightness_set =3D drvdata->brightness_set; + cdev->brightness_set_blocking =3D drvdata->brightness_set_blocking; + cdev->brightness_get =3D drvdata->brightness_get; =20 error =3D devm_led_classdev_register(&pdev->dev, cdev); if (error) @@ -90,16 +155,16 @@ static int keyboard_led_probe(struct platform_device *= pdev) return 0; } =20 -static const struct acpi_device_id keyboard_led_id[] =3D { - { "GOOG0002", 0 }, +static const struct acpi_device_id keyboard_led_acpi_match[] =3D { + { "GOOG0002", (kernel_ulong_t)&keyboard_led_drvdata_acpi }, { } }; -MODULE_DEVICE_TABLE(acpi, keyboard_led_id); +MODULE_DEVICE_TABLE(acpi, keyboard_led_acpi_match); =20 static struct platform_driver keyboard_led_driver =3D { .driver =3D { .name =3D "chromeos-keyboard-leds", - .acpi_match_table =3D ACPI_PTR(keyboard_led_id), + .acpi_match_table =3D ACPI_PTR(keyboard_led_acpi_match), }, .probe =3D keyboard_led_probe, }; --=20 2.35.1.265.g69c8d7142f-goog From nobody Sun Jun 28 05:34:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A5ECC433EF for ; Mon, 14 Feb 2022 05:37:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240503AbiBNFiC (ORCPT ); Mon, 14 Feb 2022 00:38:02 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240487AbiBNFhp (ORCPT ); Mon, 14 Feb 2022 00:37:45 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 896824EF6E for ; Sun, 13 Feb 2022 21:37:38 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id t8-20020a259ac8000000b00619a3b5977fso31963163ybo.5 for ; Sun, 13 Feb 2022 21:37:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=DQT1njARcAhQIihUotwILwK0baqFsKzs/qdOQYfjv+Y=; b=oMvKMnKWvbRtr0l3jGrkdm9p29tjSHtw95L8IvCbwaufLdZ58bkWoR/MIAGbmxIDNO 74swf8EoSGgOIV9tdjWYPg8p+3lenYCFrs0vZKplemvO4UvcORH+n7Mhy+auqOZ2vd+q otqKjMDl2eS/6jYwLKo+yju3h1BsAX6WnMrB5qCjKGSBqKss8Kmt66ve3GtbSFvd/EQx 4PRLsvvjRxehPpufJfqfekjZmzEU4ob0pYTOPHlv1OZFMkkIq+tJA534UOpV769Gbzt3 NRdZv8XhxXniBv858yKjIfAMxqOwVLivC2/NjUtdoi88OfxIBEXVGAUKzLRru1X+KCHg OQxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=DQT1njARcAhQIihUotwILwK0baqFsKzs/qdOQYfjv+Y=; b=dfPLS/yNjkNHQ36Lud2omiZfPDrR2By8sUpq3KI5+mXH5orkE3T92C5o7A5C4mha4G q5SuzghRpjLg70p9IdcMlgPNCVDmfwysHkrEqNDjyKDljPX2EHLcklYja7on87Wb5q7I bJCRD88dWSM+lSM/1+gH+T+RvVavhSwiH0rZdX8Wr4Tjm5rXe/IfBCPQVYUUQ+CCx/S8 uSNLXG9eudSKQ6yI93aLTUrIjIHBqwV7DU6JSQmq8ltxpeOId2O2qXOf9Iheh5WbdJ7A r2ucYFsLQIyO+cHX+eI7iUx+bP1p88wMxI1j9WbiDrMoouumfPkeGkQoGppJhbT5maHE WAag== X-Gm-Message-State: AOAM531/SjDuXaSmCnfaHe2hQNQ4KV0vQkmCSEo0pqCn1SizMpXwYBmx Ya5en1MGof5KtAaVEe89qGXrJdMQktCU X-Google-Smtp-Source: ABdhPJxOzKq6UNR5brAsM1MXIf51Dq60vdHRApus/HRyC/6Y4e0TFqZsk5zbI7Qfdjv+7pQmG53gsfD841a+ X-Received: from tzungbi-z840.tpe.corp.google.com ([2401:fa00:1:10:f315:f92d:e3d3:2539]) (user=tzungbi job=sendgmr) by 2002:a81:a391:: with SMTP id a139mr12318940ywh.432.1644817057814; Sun, 13 Feb 2022 21:37:37 -0800 (PST) Date: Mon, 14 Feb 2022 13:36:44 +0800 In-Reply-To: <20220214053646.3088298-1-tzungbi@google.com> Message-Id: <20220214053646.3088298-4-tzungbi@google.com> Mime-Version: 1.0 References: <20220214053646.3088298-1-tzungbi@google.com> X-Mailer: git-send-email 2.35.1.265.g69c8d7142f-goog Subject: [PATCH 3/5] dt-bindings: add google,cros-kbd-led-backlight From: Tzung-Bi Shih To: bleung@chromium.org, groeck@chromium.org, robh+dt@kernel.org Cc: chrome-platform@lists.linux.dev, tzungbi@google.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Tzung-Bi Shih --- .../chrome/google,cros-kbd-led-backlight.yaml | 35 +++++++++++++++++++ .../bindings/mfd/google,cros-ec.yaml | 3 ++ 2 files changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/chrome/google,cros-kb= d-led-backlight.yaml diff --git a/Documentation/devicetree/bindings/chrome/google,cros-kbd-led-b= acklight.yaml b/Documentation/devicetree/bindings/chrome/google,cros-kbd-le= d-backlight.yaml new file mode 100644 index 000000000000..104299e09cbb --- /dev/null +++ b/Documentation/devicetree/bindings/chrome/google,cros-kbd-led-backligh= t.yaml @@ -0,0 +1,35 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/chrome/google,cros-kbd-led-backlight.ya= ml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ChromeOS keyboard backlight LED driver. + +maintainers: + - Tzung-Bi Shih + +properties: + compatible: + const: google,cros-kbd-led-backlight + +required: + - compatible + +additionalProperties: false + +examples: + - | + spi0 { + #address-cells =3D <1>; + #size-cells =3D <0>; + + cros_ec: ec@0 { + compatible =3D "google,cros-ec-spi"; + reg =3D <0>; + + kbd-led-backlight { + compatible =3D "google,cros-kbd-led-backlight"; + }; + }; + }; diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Do= cumentation/devicetree/bindings/mfd/google,cros-ec.yaml index d1f53bd449f7..1815ca0e8ebc 100644 --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml @@ -90,6 +90,9 @@ properties: ec-pwm: $ref: "/schemas/pwm/google,cros-ec-pwm.yaml#" =20 + kbd-led-backlight: + $ref: "/schemas/chrome/google,cros-kbd-led-backlight.yaml#" + keyboard-controller: $ref: "/schemas/input/google,cros-ec-keyb.yaml#" =20 --=20 2.35.1.265.g69c8d7142f-goog From nobody Sun Jun 28 05:34:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ED00C433F5 for ; Mon, 14 Feb 2022 05:37:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239726AbiBNFh6 (ORCPT ); Mon, 14 Feb 2022 00:37:58 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240499AbiBNFhu (ORCPT ); Mon, 14 Feb 2022 00:37:50 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8D9D50458 for ; Sun, 13 Feb 2022 21:37:42 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id k7-20020a255607000000b00621afc793b8so11205566ybb.1 for ; Sun, 13 Feb 2022 21:37:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=VQ0fcrLFQa5SytEe7w/qOoQOsJ7lIVCuuogL1feOzv4=; b=jALbtnI4xhmtv743R1KcTnGNyCR/hveB1agW+EITuGYYJjN7VjULLeZUpg1jpOa+do KRXfiDuV651LoMpFUBBLV/zeK8X2XWUJ/ELowaltEMBWhIN7n4bPNHlzrXe+OkD1oWqP gxnoayl1wJdVDryxOF/6X366MTp57R+/sdu/hri/7v0/pNMNQANSN3weCfwaxvyX82nT esiQTwWunoufA1dWXVdQsue/AV3qEc1DcxLFzDu5Lf/kNmiYYpKKcTCh3wcMKeVSPCKf trUt8WyUNoT3bT4CPlw1ssBdYB7X34gQnrZ0YoGtOnQ56HWce0GRObKu4l8u2y2wRu1J YOEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=VQ0fcrLFQa5SytEe7w/qOoQOsJ7lIVCuuogL1feOzv4=; b=2I0DnfrC4INTGTGTXgCBs4dVRxM2JO8pnxBooNzTGdKe1qOYMdOOSRYk6z9nb8fZjh zX5ZZiYZCm1LgCg8wypoyKFFY4KUBlppe0GFOo/GyHQDSx1UbWVTS0ARkOV4CYecS0Dy KORkvHFudrLVTIxSca0JWnCyKirKIivC8dOeQWsEQJNEisOgr0L7sDyn9dOs376IBoqn pkCA4isD2j7fMs+stwsnUeHukGtSgk12621+HlbVqhsEJXK15vbZmkRpxA1zNaiheVFM cJll2CTy94lPJPnbm7NZ484Y5Roq8q77GxfX61Rfv87RobxGvBFu/nY7AUlrmHcH2P24 IjFA== X-Gm-Message-State: AOAM530mnIdfAiSp+GI1Z9k6xP/ysO+xXbWzWLdQ/rhr/RIfFfn3VGfo QOcHmseAgIwPEyTE51o13gLJRdBVl6ny X-Google-Smtp-Source: ABdhPJyOH81PjOmuwdU6s3uLtdosLovDzjzTPjpE/E0VxwmsccbFz1wTIadjdqBnfoDQauwB5X/1krvPmrru X-Received: from tzungbi-z840.tpe.corp.google.com ([2401:fa00:1:10:f315:f92d:e3d3:2539]) (user=tzungbi job=sendgmr) by 2002:a25:5185:: with SMTP id f127mr10214317ybb.396.1644817062104; Sun, 13 Feb 2022 21:37:42 -0800 (PST) Date: Mon, 14 Feb 2022 13:36:45 +0800 In-Reply-To: <20220214053646.3088298-1-tzungbi@google.com> Message-Id: <20220214053646.3088298-5-tzungbi@google.com> Mime-Version: 1.0 References: <20220214053646.3088298-1-tzungbi@google.com> X-Mailer: git-send-email 2.35.1.265.g69c8d7142f-goog Subject: [PATCH 4/5] platform/chrome: cros_kbd_led_backlight: support OF match From: Tzung-Bi Shih To: bleung@chromium.org, groeck@chromium.org, robh+dt@kernel.org Cc: chrome-platform@lists.linux.dev, tzungbi@google.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Tzung-Bi Shih --- .../platform/chrome/cros_kbd_led_backlight.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/pla= tform/chrome/cros_kbd_led_backlight.c index 814f2b74c602..ba853e55d29a 100644 --- a/drivers/platform/chrome/cros_kbd_led_backlight.c +++ b/drivers/platform/chrome/cros_kbd_led_backlight.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include =20 @@ -128,8 +129,11 @@ static int keyboard_led_probe(struct platform_device *= pdev) int error; =20 drvdata =3D acpi_device_get_match_data(&pdev->dev); - if (!drvdata) - return -EINVAL; + if (!drvdata) { + drvdata =3D of_device_get_match_data(&pdev->dev); + if (!drvdata) + return -EINVAL; + } =20 if (drvdata->init) { error =3D drvdata->init(pdev); @@ -161,10 +165,19 @@ static const struct acpi_device_id keyboard_led_acpi_= match[] =3D { }; MODULE_DEVICE_TABLE(acpi, keyboard_led_acpi_match); =20 +static const struct of_device_id keyboard_led_of_match[] =3D { + { + .compatible =3D "google,cros-kbd-led-backlight", + }, + {} +}; +MODULE_DEVICE_TABLE(of, keyboard_led_of_match); + static struct platform_driver keyboard_led_driver =3D { .driver =3D { .name =3D "chromeos-keyboard-leds", .acpi_match_table =3D ACPI_PTR(keyboard_led_acpi_match), + .of_match_table =3D of_match_ptr(keyboard_led_of_match), }, .probe =3D keyboard_led_probe, }; --=20 2.35.1.265.g69c8d7142f-goog From nobody Sun Jun 28 05:34:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80224C433F5 for ; Mon, 14 Feb 2022 05:38:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240510AbiBNFiI (ORCPT ); Mon, 14 Feb 2022 00:38:08 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:38030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230083AbiBNFhy (ORCPT ); Mon, 14 Feb 2022 00:37:54 -0500 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F41864EA1B for ; Sun, 13 Feb 2022 21:37:46 -0800 (PST) Received: by mail-pj1-x1049.google.com with SMTP id s10-20020a17090a948a00b001b96be201f6so6034966pjo.4 for ; Sun, 13 Feb 2022 21:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=29uHVdHAQSqiT8vvfXqlsD57wZoWh7bXiS10RQ7W7Qg=; b=Pr0sIocwVERST9JG5yNYFzh4bfH0oj29aF92lMVCUeQOm5sHkFEyreYdobAZHbm+fl yoZIypGvnAv5RfDCLvM/pLGbDC4x0obhy9+lnxLPI5zUEzjeypIr9E28KbcI4AeFqjJu ZeWzJay7J/rvPFUygr8T5Jl+7ceUQ7RCI3sZJK1Vqi2yfFkBynrs9FPgUcW3KegJdiPg ESxlTYktuJa4Gwj08a7M7G61QWkd6KA6+UCFSEMm6Ox+k6MmkjO8CFPRxQ8xtb5ldNAr g6r6P4K5nvWlvrYrCJBurEVE4CIehOCiipVhujNJzPHQzoUwAUPSxafHl7bZMF/mcdX2 SLHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=29uHVdHAQSqiT8vvfXqlsD57wZoWh7bXiS10RQ7W7Qg=; b=PHhaYGsoeeAU6k3TwXlH+XYnjwhJ0En7DOiE5D7yEqutsf6d83TPhTpqtNw3T4P9PK JIXq7JhwnbXzgd7d4VAvrbjehEyzwyzvw7gcMp0KfcRG2EOUneBGJpT2QEWr8cvJYXCw 4nSt/AMkMUt0hJCmP2BGg4mjejkNE+xMYU5BhNjW9YZeVoII5dXdEXzVA/G3qkCuUF1a yIxquJR6aK4WPPaaH7cBy7YjIK4/C3P8nXzWFiPO+VQRGdXXF6mUIyFuLLUdc5Ws/Snu cxaIygmmaagLgYYcvoWM2IGhElXgfQgjFlV8ikFSnWjsYru7O+2v0AxtZzCNRGK37aB8 yNZg== X-Gm-Message-State: AOAM532GCj6HuJCC1PcUZo0AV911GxpZKdTeJRokAXLN6GcDQP9O+621 y2qJdeKRNuqM8kSeVKIhPhwfqpyXv7Ck X-Google-Smtp-Source: ABdhPJxKNKGdvDYl8ykS+dHO1ASu06EfmVMuaH4MZLhystWtVyLkcNMLBCQkNjLLUXLqBRdA9t3NMsHsmNHz X-Received: from tzungbi-z840.tpe.corp.google.com ([2401:fa00:1:10:f315:f92d:e3d3:2539]) (user=tzungbi job=sendgmr) by 2002:a62:ce06:: with SMTP id y6mr1345902pfg.85.1644817066460; Sun, 13 Feb 2022 21:37:46 -0800 (PST) Date: Mon, 14 Feb 2022 13:36:46 +0800 In-Reply-To: <20220214053646.3088298-1-tzungbi@google.com> Message-Id: <20220214053646.3088298-6-tzungbi@google.com> Mime-Version: 1.0 References: <20220214053646.3088298-1-tzungbi@google.com> X-Mailer: git-send-email 2.35.1.265.g69c8d7142f-goog Subject: [PATCH 5/5] platform/chrome: cros_kbd_led_backlight: support EC PWM backend From: Tzung-Bi Shih To: bleung@chromium.org, groeck@chromium.org, robh+dt@kernel.org Cc: chrome-platform@lists.linux.dev, tzungbi@google.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" EC PWM backend uses EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT and EC_CMD_PWM_GET_KEYBOARD_BACKLIGHT for setting and getting the brightness respectively. Signed-off-by: Tzung-Bi Shih --- drivers/platform/chrome/Kconfig | 6 + .../platform/chrome/cros_kbd_led_backlight.c | 126 +++++++++++++++--- 2 files changed, 117 insertions(+), 15 deletions(-) diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kcon= fig index 3f74679a556c..298a49550857 100644 --- a/drivers/platform/chrome/Kconfig +++ b/drivers/platform/chrome/Kconfig @@ -142,6 +142,12 @@ config CROS_KBD_LED_BACKLIGHT_ACPI help ChromeOS keyboard backlight ACPI backend. =20 +config CROS_KBD_LED_BACKLIGHT_EC_PWM + tristate "ChromeOS keyboard backlight EC PWM backend" + depends on CROS_EC && CROS_KBD_LED_BACKLIGHT + help + ChromeOS keyboard backlight EC PWM backend. + config CROS_EC_CHARDEV tristate "ChromeOS EC miscdevice" depends on MFD_CROS_EC_DEV diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/pla= tform/chrome/cros_kbd_led_backlight.c index ba853e55d29a..d655cf5bc960 100644 --- a/drivers/platform/chrome/cros_kbd_led_backlight.c +++ b/drivers/platform/chrome/cros_kbd_led_backlight.c @@ -11,9 +11,16 @@ #include #include #include +#include +#include #include #include =20 +struct keyboard_led_private { + struct led_classdev cdev; + struct cros_ec_device *ec; +}; + /** * struct keyboard_led_drvdata - keyboard LED driver data. * @init: Init function. @@ -39,6 +46,8 @@ struct keyboard_led_drvdata { enum led_brightness max_brightness; }; =20 +#define KEYBOARD_BACKLIGHT_MAX 100 + #if IS_ENABLED(CONFIG_CROS_KBD_LED_BACKLIGHT_ACPI) =20 /* Keyboard LED ACPI Device must be defined in firmware */ @@ -46,8 +55,6 @@ struct keyboard_led_drvdata { #define ACPI_KEYBOARD_BACKLIGHT_READ ACPI_KEYBOARD_BACKLIGHT_DEVICE ".KBQC" #define ACPI_KEYBOARD_BACKLIGHT_WRITE ACPI_KEYBOARD_BACKLIGHT_DEVICE ".KBC= M" =20 -#define ACPI_KEYBOARD_BACKLIGHT_MAX 100 - static void keyboard_led_set_brightness_acpi(struct led_classdev *cdev, enum led_brightness brightness) { @@ -106,7 +113,7 @@ static const struct keyboard_led_drvdata keyboard_led_d= rvdata_acpi =3D { .init =3D keyboard_led_init_acpi, .brightness_set =3D keyboard_led_set_brightness_acpi, .brightness_get =3D keyboard_led_get_brightness_acpi, - .max_brightness =3D ACPI_KEYBOARD_BACKLIGHT_MAX, + .max_brightness =3D KEYBOARD_BACKLIGHT_MAX, }; =20 #else /* IS_ENABLED(CONFIG_CROS_KBD_LED_BACKLIGHT_ACPI) */ @@ -122,10 +129,97 @@ static const struct keyboard_led_drvdata keyboard_led= _drvdata_acpi =3D { =20 #endif /* IS_ENABLED(CONFIG_CROS_KBD_LED_BACKLIGHT_ACPI) */ =20 +#if IS_ENABLED(CONFIG_CROS_KBD_LED_BACKLIGHT_EC_PWM) + +static int +keyboard_led_set_brightness_blocking_ec_pwm(struct led_classdev *cdev, + enum led_brightness brightness) +{ + struct { + struct cros_ec_command msg; + struct ec_params_pwm_set_keyboard_backlight params; + } __packed buf; + struct ec_params_pwm_set_keyboard_backlight *params =3D &buf.params; + struct cros_ec_command *msg =3D &buf.msg; + struct keyboard_led_private *private =3D + container_of(cdev, struct keyboard_led_private, cdev); + + memset(&buf, 0, sizeof(buf)); + + msg->version =3D 0; + msg->command =3D EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT; + msg->insize =3D 0; + msg->outsize =3D sizeof(*params); + + params->percent =3D brightness; + + return cros_ec_cmd_xfer_status(private->ec, msg); +} + +static enum led_brightness +keyboard_led_get_brightness_ec_pwm(struct led_classdev *cdev) +{ + struct { + struct cros_ec_command msg; + struct ec_response_pwm_get_keyboard_backlight resp; + } __packed buf; + struct ec_response_pwm_get_keyboard_backlight *resp =3D &buf.resp; + struct cros_ec_command *msg =3D &buf.msg; + struct keyboard_led_private *private =3D + container_of(cdev, struct keyboard_led_private, cdev); + int ret; + + memset(&buf, 0, sizeof(buf)); + + msg->version =3D 0; + msg->command =3D EC_CMD_PWM_GET_KEYBOARD_BACKLIGHT; + msg->insize =3D sizeof(*resp); + msg->outsize =3D 0; + + ret =3D cros_ec_cmd_xfer_status(private->ec, msg); + if (ret < 0) + return ret; + + return resp->percent; +} + +static int keyboard_led_init_ec_pwm(struct platform_device *pdev) +{ + struct keyboard_led_private *private =3D platform_get_drvdata(pdev); + + private->ec =3D dev_get_drvdata(pdev->dev.parent); + if (!private->ec) { + dev_err(&pdev->dev, "no parent EC device\n"); + return -EINVAL; + } + + return 0; +} + +static const struct keyboard_led_drvdata keyboard_led_drvdata_ec_pwm =3D { + .init =3D keyboard_led_init_ec_pwm, + .brightness_set_blocking =3D keyboard_led_set_brightness_blocking_ec_pwm, + .brightness_get =3D keyboard_led_get_brightness_ec_pwm, + .max_brightness =3D KEYBOARD_BACKLIGHT_MAX, +}; + +#else /* IS_ENABLED(CONFIG_CROS_KBD_LED_BACKLIGHT_EC_PWM) */ + +static int keyboard_led_init_ec_pwm_null(struct platform_device *pdev) +{ + return -EOPNOTSUPP; +} + +static const struct keyboard_led_drvdata keyboard_led_drvdata_ec_pwm =3D { + .init =3D keyboard_led_init_ec_pwm_null, +}; + +#endif /* IS_ENABLED(CONFIG_CROS_KBD_LED_BACKLIGHT_EC_PWM) */ + static int keyboard_led_probe(struct platform_device *pdev) { - struct led_classdev *cdev; const struct keyboard_led_drvdata *drvdata; + struct keyboard_led_private *private; int error; =20 drvdata =3D acpi_device_get_match_data(&pdev->dev); @@ -135,24 +229,25 @@ static int keyboard_led_probe(struct platform_device = *pdev) return -EINVAL; } =20 + private =3D devm_kzalloc(&pdev->dev, sizeof(*private), GFP_KERNEL); + if (!private) + return -ENOMEM; + platform_set_drvdata(pdev, private); + if (drvdata->init) { error =3D drvdata->init(pdev); if (error) return error; } =20 - cdev =3D devm_kzalloc(&pdev->dev, sizeof(*cdev), GFP_KERNEL); - if (!cdev) - return -ENOMEM; - - cdev->name =3D "chromeos::kbd_backlight"; - cdev->flags |=3D LED_CORE_SUSPENDRESUME; - cdev->max_brightness =3D drvdata->max_brightness; - cdev->brightness_set =3D drvdata->brightness_set; - cdev->brightness_set_blocking =3D drvdata->brightness_set_blocking; - cdev->brightness_get =3D drvdata->brightness_get; + private->cdev.name =3D "chromeos::kbd_backlight"; + private->cdev.flags |=3D LED_CORE_SUSPENDRESUME; + private->cdev.max_brightness =3D drvdata->max_brightness; + private->cdev.brightness_set =3D drvdata->brightness_set; + private->cdev.brightness_set_blocking =3D drvdata->brightness_set_blockin= g; + private->cdev.brightness_get =3D drvdata->brightness_get; =20 - error =3D devm_led_classdev_register(&pdev->dev, cdev); + error =3D devm_led_classdev_register(&pdev->dev, &private->cdev); if (error) return error; =20 @@ -168,6 +263,7 @@ MODULE_DEVICE_TABLE(acpi, keyboard_led_acpi_match); static const struct of_device_id keyboard_led_of_match[] =3D { { .compatible =3D "google,cros-kbd-led-backlight", + .data =3D &keyboard_led_drvdata_ec_pwm, }, {} }; --=20 2.35.1.265.g69c8d7142f-goog