From nobody Mon Jun 29 08:56:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CC95C433EF for ; Sat, 12 Feb 2022 13:27:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235645AbiBLN2B (ORCPT ); Sat, 12 Feb 2022 08:28:01 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231276AbiBLN2A (ORCPT ); Sat, 12 Feb 2022 08:28:00 -0500 Received: from smtp.smtpout.orange.fr (smtp01.smtpout.orange.fr [80.12.242.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A6BC22B15 for ; Sat, 12 Feb 2022 05:27:55 -0800 (PST) Received: from localhost.localdomain ([124.33.176.97]) by smtp.orange.fr with ESMTPA id IsR7niVP1u3WEIsRKn94XY; Sat, 12 Feb 2022 14:27:53 +0100 X-ME-Helo: localhost.localdomain X-ME-Auth: MDU0YmViZGZmMDIzYiBlMiM2NTczNTRjNWZkZTMwOGRiOGQ4ODf3NWI1ZTMyMzdiODlhOQ== X-ME-Date: Sat, 12 Feb 2022 14:27:53 +0100 X-ME-IP: 124.33.176.97 From: Vincent Mailhol To: netdev@vger.kernel.org, David Ahern , Stephen Hemminger , linux-can@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Marc Kleine-Budde , Vincent Mailhol Subject: [PATCH iproute2] iplink_can: print_usage: typo fix, add missing spaces Date: Sat, 12 Feb 2022 22:27:27 +0900 Message-Id: <20220212132727.3710-1-mailhol.vincent@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The can help menu misses three spaces for the TDCV, TDCO and TDCF parameters, making the closing curly bracket unaligned. For reference, before this patch: | $ ip link help can | Usage: ip link set DEVICE type can | [ bitrate BITRATE [ sample-point SAMPLE-POINT] ] | | [ tq TQ prop-seg PROP_SEG phase-seg1 PHASE-SEG1 | phase-seg2 PHASE-SEG2 [ sjw SJW ] ] | | [ dbitrate BITRATE [ dsample-point SAMPLE-POINT] ] | | [ dtq TQ dprop-seg PROP_SEG dphase-seg1 PHASE-SEG1 | dphase-seg2 PHASE-SEG2 [ dsjw SJW ] ] | [ tdcv TDCV tdco TDCO tdcf TDCF ] | | [ loopback { on | off } ] | [ listen-only { on | off } ] | [ triple-sampling { on | off } ] | [ one-shot { on | off } ] | [ berr-reporting { on | off } ] | [ fd { on | off } ] | [ fd-non-iso { on | off } ] | [ presume-ack { on | off } ] | [ cc-len8-dlc { on | off } ] | [ tdc-mode { auto | manual | off } ] | | [ restart-ms TIME-MS ] | [ restart ] | | [ termination { 0..65535 } ] | | Where: BITRATE :=3D { NUMBER in bps } | SAMPLE-POINT :=3D { 0.000..0.999 } | TQ :=3D { NUMBER in ns } | PROP-SEG :=3D { NUMBER in tq } | PHASE-SEG1 :=3D { NUMBER in tq } | PHASE-SEG2 :=3D { NUMBER in tq } | SJW :=3D { NUMBER in tq } | TDCV :=3D { NUMBER in tc} | TDCO :=3D { NUMBER in tc} | TDCF :=3D { NUMBER in tc} | RESTART-MS :=3D { 0 | NUMBER in ms } ... and after this patch: | $ ip link help can | Usage: ip link set DEVICE type can | [ bitrate BITRATE [ sample-point SAMPLE-POINT] ] | | [ tq TQ prop-seg PROP_SEG phase-seg1 PHASE-SEG1 | phase-seg2 PHASE-SEG2 [ sjw SJW ] ] | | [ dbitrate BITRATE [ dsample-point SAMPLE-POINT] ] | | [ dtq TQ dprop-seg PROP_SEG dphase-seg1 PHASE-SEG1 | dphase-seg2 PHASE-SEG2 [ dsjw SJW ] ] | [ tdcv TDCV tdco TDCO tdcf TDCF ] | | [ loopback { on | off } ] | [ listen-only { on | off } ] | [ triple-sampling { on | off } ] | [ one-shot { on | off } ] | [ berr-reporting { on | off } ] | [ fd { on | off } ] | [ fd-non-iso { on | off } ] | [ presume-ack { on | off } ] | [ cc-len8-dlc { on | off } ] | [ tdc-mode { auto | manual | off } ] | | [ restart-ms TIME-MS ] | [ restart ] | | [ termination { 0..65535 } ] | | Where: BITRATE :=3D { NUMBER in bps } | SAMPLE-POINT :=3D { 0.000..0.999 } | TQ :=3D { NUMBER in ns } | PROP-SEG :=3D { NUMBER in tq } | PHASE-SEG1 :=3D { NUMBER in tq } | PHASE-SEG2 :=3D { NUMBER in tq } | SJW :=3D { NUMBER in tq } | TDCV :=3D { NUMBER in tc } | TDCO :=3D { NUMBER in tc } | TDCF :=3D { NUMBER in tc } | RESTART-MS :=3D { 0 | NUMBER in ms } Fixes: 0c263d7c36ff ("iplink_can: add new CAN FD bittiming parameters: Transmitter Delay Compensat ion (TDC)") Signed-off-by: Vincent Mailhol Acked-by: Marc Kleine-Budde --- ip/iplink_can.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ip/iplink_can.c b/ip/iplink_can.c index 6ea02a2a..0e670a6c 100644 --- a/ip/iplink_can.c +++ b/ip/iplink_can.c @@ -53,9 +53,9 @@ static void print_usage(FILE *f) "\t PHASE-SEG1 :=3D { NUMBER in tq }\n" "\t PHASE-SEG2 :=3D { NUMBER in tq }\n" "\t SJW :=3D { NUMBER in tq }\n" - "\t TDCV :=3D { NUMBER in tc}\n" - "\t TDCO :=3D { NUMBER in tc}\n" - "\t TDCF :=3D { NUMBER in tc}\n" + "\t TDCV :=3D { NUMBER in tc }\n" + "\t TDCO :=3D { NUMBER in tc }\n" + "\t TDCF :=3D { NUMBER in tc }\n" "\t RESTART-MS :=3D { 0 | NUMBER in ms }\n" ); } --=20 2.34.1