From nobody Sun Jun 28 08:36:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56062C433EF for ; Wed, 9 Feb 2022 19:59:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230264AbiBIT7c (ORCPT ); Wed, 9 Feb 2022 14:59:32 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:52702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230016AbiBIT7X (ORCPT ); Wed, 9 Feb 2022 14:59:23 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16CE9E06C41B for ; Wed, 9 Feb 2022 11:59:18 -0800 (PST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 219HQFZo020151; Wed, 9 Feb 2022 19:57:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=ZgkuZ8r/VymLdhLJB2PMa9DE7jwyd1kzggyTkOXJs4M=; b=J10VBaVi9FiJ+cVVOh+xRvssRPodyFrgG+2IUxJni0CICa8l8Cg+I2w3LNftTxUXDaZU uuXFDEc22RByczPGW/by7D2GJU5aJ8cWT/tEG1yaa3TpIPTbhFrYau1R8sFGo1htNe15 b9K/dFFNje6jJItAEsKyOkJAgyJzM5epP7kqZODhIaDLYnbpCSuuNZggfp5Optf2ENnt ofIoU6gCe5ZxwtG6Ul4meHZN05CEPspcdpg/U+9wO6Ffkn5xcMID0+zFYmG3Q/tbk56a qYcNg96XJnvcThIcJnkj2Wa3bYPK5M0jMf9Ixn+6jD96RNH3DP3gXLqIylCkK4o3vEOZ DA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3e366wxyj8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:25 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 219JuGjJ095815; Wed, 9 Feb 2022 19:57:24 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2174.outbound.protection.outlook.com [104.47.58.174]) by aserp3030.oracle.com with ESMTP id 3e1f9hy63q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZfmZ9JOA+ghOrXXIOR4Q3sZtKS1Cr624GuPBM2RzW2WWb9VGor50Nm/jR4yau3G2VjdkqorkwSOO4rQOOFr5bucbIGq4JXdXHY2nvjfAalQy0CXPQSXJk/hcsnXd6RHFOAzeZzcI2mfRnjMidwYj83k4maYKuP+wxXzFTaXDida1VfgWcd8MDMjxbkAEOU+3mqb+RVh/frF5H5pxRyIax9BtCtdkuPjC7wA0mXnYhBxsrQ6Rj2JNUxGN+retTPC+rTbyWesdpFLibvFp5LNVJDUlfqkJSrP9RwHqs+2cdflVgyXmrNxJVdiO6M+f+VfJziEQKmWg/gZH+9MKK/q4DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZgkuZ8r/VymLdhLJB2PMa9DE7jwyd1kzggyTkOXJs4M=; b=DN5PtjgygjlQ+sUKaFwo8ViceSTJthkrYYlFcFmHozmyr6EM05Le+O6o1lGWBtutglEJS249t9HfhX4FAghWPbb7St0it0FLWnfPK6ymraTXNQVXqahGCC1s+ITvZ219/6bji8ju9FWTtJZTdu1i0/U6cB0HoRyNzK3VE7Yv49nqxo0OptUQI8JONgTP5eue2ysD5/0ZSN/ZcJmfJE+mhsBwFt7mwx1d0lb9g6ycJ9GdxU6VjKnreU4NfU0tu51/e3K0xxgqCdsAHm2YbBSyQQ9ipGBhm+8TIkoh5dytsRFnoMSoOVzncDj/2iwp5Mw9Yx+kXqa+lUT3t4nlJVGfyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZgkuZ8r/VymLdhLJB2PMa9DE7jwyd1kzggyTkOXJs4M=; b=yyNZLD/ArfqNjy+ghqt/8gaNty3n3weJPRkYzC+mML0i8zkhFZWXAJ2jNZ/QiSP/N7FVQS8Tm1om05A0iMH/lvTnGuycZIFTNxm2tu+R22glrF1Jj1MEMCSLjVsK117zRaVMksHI7WtCTdpN0mzDuUStl1HX9C+PcsVMYNuwGQY= Received: from CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) by DM6PR10MB3721.namprd10.prod.outlook.com (2603:10b6:5:156::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 9 Feb 2022 19:57:22 +0000 Received: from CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c]) by CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c%5]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 19:57:21 +0000 From: Eric DeVolder To: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, eric.devolder@oracle.com Subject: [PATCH v4 01/10] crash: fix minor typo/bug in debug message Date: Wed, 9 Feb 2022 14:56:57 -0500 Message-Id: <20220209195706.51522-2-eric.devolder@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220209195706.51522-1-eric.devolder@oracle.com> References: <20220209195706.51522-1-eric.devolder@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR05CA0046.namprd05.prod.outlook.com (2603:10b6:5:335::15) To CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 014c89ee-d4ac-45ed-d68b-08d9ec06628b X-MS-TrafficTypeDiagnostic: DM6PR10MB3721:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9bs7mvm4EBP/KyK6OyCXu4BZQOawkwvrEQsbycIWQHcWk7A9bv2Z+K0omu1DSN8VDGfUpQPXL8O8CyMfaryHAjnc5Od0H4x893tnHXXUfmxnGU8NZj3QNlO71um35vj+hZrS7dYat3dx4EgFMBGlPyiw04Bwl8V7UPxJVVVgMKnBfHnohtHx3lAM+uxllXDa9U/nN0CmRcZ1zWNkQt1tCAn9c0ppJsMjekHpFt62UTm7AMKxiHTWjShnV59OQbPL6TPRWVfUdn3c3cYvzMKNDk7CctvUbIPwnHs8nL+Qfn9/ZFOQCWnMO9GHd/okItrWqGoyElZtJXJbn/bvhAhTKoEzbzdFEAvKxUCmyeqDeFyDUFAnW5JEX8WQcbudWu6Ffl4anTHviZQdpOF7HjjqFMeGcLL7B6psmbHe/i8JvR0Jxtjd2vzSgUfKOjqdwIJjAtWYagILEsfVQKWZ4A1jUrKPcBxmUb/4S1Mm9JSdx2fsB8BiWXirg2NmiXPAsSDOVIB//1FS3LFXhZ+OfQwTBEfJyDszcu2e2nItm4FKaN4vGS5nc7UJP7qmMdkOfPJo7B8yecSCmXPx6SNhZHvmEvhxdsKySTeeq5x7jDBqYTPDj+OggUMNLDe+uTvz6rul+7BywgNaADavpiiGuUrqIOOMf3vVVt9da1icS7JYIif1uXcXzQ2Whpna4oWrEgD6y/G4HnOm6fC7ZwaQlxeVKw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4531.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(2616005)(5660300002)(26005)(107886003)(1076003)(2906002)(6666004)(508600001)(36756003)(38350700002)(6486002)(38100700002)(7416002)(6512007)(4744005)(52116002)(4326008)(316002)(66946007)(86362001)(8676002)(6506007)(8936002)(66476007)(83380400001)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9xa8x88pbgOYgAmMh9WtLOZ25YLb8r/xyGL7B6Y17Yiivw+5i21Pi4sAiHee?= =?us-ascii?Q?g9vF+Z1BuYku6uDKGydZcdz/45MQJSXrCxZeyG+w1y/+MUVE74B9TKt2QYaa?= =?us-ascii?Q?mD5KY4OXoXgFrnbrnkqjC1E1HWDguvIlCKDOnuW0AXQedDrzXAjt70EFZWsO?= =?us-ascii?Q?pePr4A+LeU2pa9q8ixfB05UKX1sR770l1Q42S5Co3/L1S2ayh/i5wh5ztNpl?= =?us-ascii?Q?wxMr/JjXlejTR/+CBlCCjWtIzcKoRMhiT5D/xNQG1uQYMVPRZ501ufF1hRNx?= =?us-ascii?Q?rDN5lLXUpigQpkB6MvqkIXI159PbwsSdRF85r7+r9CI40yMhhb/bZUnEEB1A?= =?us-ascii?Q?VfP9LSGroA7iPeHUgHSJmz1X02LIvHHs00hVJjV33V96YPpijvXY0KezRgzu?= =?us-ascii?Q?oWMtOdiMk+jT4srP2RC9vmgthOTFwBYkuGPqjhf5RIOxLEa5rxKLauJVNajP?= =?us-ascii?Q?zGbDZNQX9E+Yo1icwt7/+nC5dS12FSXbEFcKosxrnNgHQSk0vhvpPKfmHiHy?= =?us-ascii?Q?NrW53x9zvKyxfjmdS8HZzCHp9PElRSxFSs/Emzkwxqe2Vf/xR/jPGDB3dHfq?= =?us-ascii?Q?ETOC621lIwiRSh+/VjjDtWqfSXXaAddxNFrA3zsLO/0cLBfM8Ms/DgJ1+3/E?= =?us-ascii?Q?6nRLcrWGFbdrGUOfXc2W7M2Kw21ufi5GqY70fLGFuSvQtp2ffnZmo7s8AaCD?= =?us-ascii?Q?KDtoSjQ5qBmZEFYaTkhsjRI8A5fUerE/wFeO9UBvqZsj6gAU+DDQFHgKkZh6?= =?us-ascii?Q?sd/JA4JHTu6JAKXA/s8gWe4PqLrhTRJPT5YPzUCPED4MkXkMffZhBnQL7m0e?= =?us-ascii?Q?LpO2K1659WkiPCMCsFafu3bRvyiKZ6MzwIUhdTyMRmMHlO9XheZn9dqkS9id?= =?us-ascii?Q?79DEMkcRoUEphArZbS2H+rHTUfOKSqaQmO+n2xtmx+HAptgDXCuO8e88+nef?= =?us-ascii?Q?rFJdF6O2aUv75VUS4tzsOGHVVFtNkNqbq/7yBXBaAm0ydlkHI9r+V412hnwL?= =?us-ascii?Q?nrbHio78SgRjzFLeix/77O4SV/yCrTxyEjbGN3gkoEEsvkv/vUtrqvKbEagY?= =?us-ascii?Q?h2C3BTw6ICMOvxp5aE5fr+fBBIHYxIg1iVI+uz7T2Ys8tsjjbVQK5NgEnas8?= =?us-ascii?Q?QM2fGpPxEvHA9kJfLHyHuuWxAYNRaLqD/OaozCh/f1hm6eXhXBFzWN3VWzPR?= =?us-ascii?Q?gIlrj2cAoseUqXhOUXMxaInBhDSWA28qCTiEdjmZa83D+xSm+ZBd1V0VKHgG?= =?us-ascii?Q?EmJufQkdKfjP/DhHb1IBA1VjzW+NDciwFuAHGi2EYx0JktQDZOTtnFdCv3Zj?= =?us-ascii?Q?/vM938j+FFc01vkRCEN/ArcmEmLtN9k3LNylU7DdQ3TzFh49Z/c8Kykn6z65?= =?us-ascii?Q?oJtKcdGUKFLMjbORwVD4fZHLk3aKmu+xihjZPWYMEnr56m7WwECJE3wmI2tq?= =?us-ascii?Q?foCtDrVoNwfSJKMWpyHEpqtkM7mZRO/FeanxQQ28VJnI2p1E/qUUqiFnALtO?= =?us-ascii?Q?iPs+LwjUAjfOygCNf7in3BMqQaS1nf5uGehIgLcgG1wQk+4h19CW6t/iMue7?= =?us-ascii?Q?n/uBnzKZLUI+OM5mBCT7N7o4AT4Y8udOf76vlR9Weq6Pf5OpAH4P3oX+m4GY?= =?us-ascii?Q?p11mBNVSSIKCN67oJ8YLYLYTUp4Rl+5oFnnqcAtHbNqr9x7zG4NspvYOF/oW?= =?us-ascii?Q?wTG4RQ=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 014c89ee-d4ac-45ed-d68b-08d9ec06628b X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 19:57:21.8801 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +TpSpYHv74e6umZBTG9PYSfmuu/E7z/b19M+QEu5Kl3rahNjmexAB/WyVrT+EbTipJ/TTJrnH1Ar/Y5AXQWh971v6KO6uSJAAjjpHJTd2d4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3721 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202090106 X-Proofpoint-GUID: JtPs_LH4agUDwEAMv3heDCQFfOM9Y2FV X-Proofpoint-ORIG-GUID: JtPs_LH4agUDwEAMv3heDCQFfOM9Y2FV Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The pr_debug() intends to display the memsz member, but the parameter is actually the bufsz member (which is already displayed). Correct this to display memsz value. Signed-off-by: Eric DeVolder Acked-by: Baoquan He --- arch/x86/kernel/crash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c index e8326a8d1c5d..9730c88530fc 100644 --- a/arch/x86/kernel/crash.c +++ b/arch/x86/kernel/crash.c @@ -407,7 +407,7 @@ int crash_load_segments(struct kimage *image) } image->elf_load_addr =3D kbuf.mem; pr_debug("Loaded ELF headers at 0x%lx bufsz=3D0x%lx memsz=3D0x%lx\n", - image->elf_load_addr, kbuf.bufsz, kbuf.bufsz); + image->elf_load_addr, kbuf.bufsz, kbuf.memsz); =20 return ret; } --=20 2.27.0 From nobody Sun Jun 28 08:36:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0571EC433F5 for ; Wed, 9 Feb 2022 20:00:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230471AbiBIUAE (ORCPT ); Wed, 9 Feb 2022 15:00:04 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:53560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230274AbiBIT7e (ORCPT ); Wed, 9 Feb 2022 14:59:34 -0500 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E6E7E039C4E for ; Wed, 9 Feb 2022 11:59:26 -0800 (PST) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 219HURkU013354; Wed, 9 Feb 2022 19:57:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=ZRncpHAHj2qu/zCatvrXg0NFBmwphPEcMEWr3R4gXrA=; b=D1tpLKdTO/5V0rt47VUxJJqdKDY8PkJMhzEfpo3fVTtUBSRRdgN3uLAee7neWjSwyj3d dTkQ9DIbLhLxlK/MmHN6L3fH8l7zJ90SMkYubOERHicw2mSDN2E3PGzu2UYKbR4xBY1Z Pkp4cU8Bj2sfcOm13oOq9hu8Q5IABD3JTg+B2FRka5oqWCEueaqHtHNdcHkKrKPlzltU aGwb/Nl7Wx2dHma2bIHuXn+aIrhev8pN/TOU37wU/uj4C4ZvBA0i2rYjo/q91TGYYuP+ QuFJ5ylTUXhffVYc63DVOPQzwh8dda83AVDHJQzVxohK7U3af0LxsrXAzb8Y3Q09E2xS uQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3e368txv3f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:28 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 219JtqDU046306; Wed, 9 Feb 2022 19:57:26 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2174.outbound.protection.outlook.com [104.47.58.174]) by userp3030.oracle.com with ESMTP id 3e1ec3b055-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PvJnAdmRehYRngg7W74VOVH9gB1Pp505hkdHZA5xiKzoPz+nObgoC0EuyEaePeJvZI9hBuYTMSygXuh9Izr4rsQKR49Me8NfJVKwAq3aUaDIojyDpRSLBe/stK36hVx9bsEsBoDTBRD8XZA96R4Dan901hKk+9ZzzrU2/XtJCHph6xcyrVJF9bioSQwQvG54zMQKJIDx4vPR4c3SD2xOYrvKrNod1kZvS+PNgWKAf827Wr831DYIuxdumTTfQpwC3h4M/dKweyVBjNzcElHtrsGGzqhgjwUsvfQpzObHwxMwHY2uhS0W/XiLvZvP18u/JTSHY9Tn5mIJMHRxFjdECQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZRncpHAHj2qu/zCatvrXg0NFBmwphPEcMEWr3R4gXrA=; b=oAUznhu+RpkMISnaHlQLXxk9GpX5uA68KKsBZQgPG7cv1QldqUljZv0XAflVgJ7UFsuAo3i6GQDthN87HxWgbC9x6urrzau1Arcew4kgiFktg5kDhOYHjZb0dLwaNgVm4mSdfYaWpwQyWR7a6HRWrSGqj7oTTouFSkgVwslvP5DPnzziWe4G+1uqbOOvFcClA9tvGIDHlLvSvxKuHCPKO96z0lm+MBjJoLBtE7XM3of6mcsiql0hRLDarnssbm58AzbCebRNimqwzfABZnRr4CFqLGBqvo7+cXkl0uey72A/xhaVFAtD8iHgoieaZGKiBmZPXL/9eP/7WdN7tBJT5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZRncpHAHj2qu/zCatvrXg0NFBmwphPEcMEWr3R4gXrA=; b=EXHoBhoQo9+mVz215HWbaRoK7y+vErwjzWTAWvxhkgR9r0OW5yQ5LL7b65Sc+hukm2QWePBXvQK8gZKq10XXvzWOGYwilyhfQGEUwbaZ28B69I1Ad/hg/6htCHlIiUzRdWuCiL44/lg/7CQhFwLd5SVALMwJizedhyh0Wp2u/mc= Received: from CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) by DM6PR10MB3721.namprd10.prod.outlook.com (2603:10b6:5:156::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 9 Feb 2022 19:57:24 +0000 Received: from CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c]) by CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c%5]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 19:57:24 +0000 From: Eric DeVolder To: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, eric.devolder@oracle.com Subject: [PATCH v4 02/10] crash hp: Introduce CRASH_HOTPLUG configuration options Date: Wed, 9 Feb 2022 14:56:58 -0500 Message-Id: <20220209195706.51522-3-eric.devolder@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220209195706.51522-1-eric.devolder@oracle.com> References: <20220209195706.51522-1-eric.devolder@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR05CA0046.namprd05.prod.outlook.com (2603:10b6:5:335::15) To CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8cf3fd05-da00-40c4-0eaa-08d9ec0663ef X-MS-TrafficTypeDiagnostic: DM6PR10MB3721:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RyXKo0OjaJnSdtLZHcwCr2ltkfcLouvRYQDq7bjX6FZdNGcHsk3l8qPZoYkNab4LSODG7g/GBnpv7kK8dp24eK8kFC3kyI+kXnwArjBf0OzcaGHalFBolgmADJwBUblsEpj6qvUKnEnIRT3i3vf/wJ6COTvZCF0RGtxqjwLXsjb2uJszmTTXciDw31HoMb5K0ep73zALSHW0RuklmchDCc6c4+g5wu3ZSQSqncZm6RycK+zmAs3GyMUiFUA7zLbvvN4x2jX0XUhz7Jr1W/TMTqvdSTVaPQEw8b1t9hUbi2HObteBfVmq7dW88/KLGYzEGL3WdhgsioNfVSjx2yG3SYdkpzfMdMgl0bVZKnblVb1ryEBvmjlMKn2tQAinUqoUjqJNQCZ59oY0O1+8ArzTAhw8p//m/dZtBcAFGCcvz/9/4IjmEGOjveHuUuzEi750xzA2WgzNg8lXA2RSKm7PZ3XeKIpU4bxNuzX8URkM5l5pv23rVu3cxaGfpxE1cZYAatwv7Xm7eUwSofcD92HArwFNoJQCtfsTANdrnbh1fUyUgJxQ9Od9m0WsOwfMgF4iB+2BXyATwJceo+l1eIykt4mtX/ADC2bH5gHdzYz4/mocZ80bRKqhqweGHPl4Ufga6Ite4Lw9kmuO8MTbR2bcg+6XmUa3QYwYV0M33AkMkFNl93EDzOmohhAlDANSF7bDAUifVd7k6iQ70ZcBQoasGg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4531.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(2616005)(5660300002)(26005)(107886003)(1076003)(2906002)(6666004)(508600001)(36756003)(38350700002)(6486002)(38100700002)(7416002)(6512007)(52116002)(4326008)(316002)(66946007)(86362001)(8676002)(6506007)(8936002)(66476007)(83380400001)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bxl9zbKtfBaDo9+efrdM17hbJAemjg0nY5KCetHO8EnIil/50kH0N7LaMWVP?= =?us-ascii?Q?II2zkqvO8zoAZs9JKfXIPK8bwkT2F2npArQgnw7/VlxefgS54QoFZVffqV42?= =?us-ascii?Q?sFhnM5uoOSxfNZiJSi/GnkO4erckYK4SilTe5lgQqaIfgPwHZ+oJAZunU3JS?= =?us-ascii?Q?P1G1YNmO/meufuTlybHtbCSCtSaRsXYrT5YWIOSUbhMeHHChVZ3XPKXmgMsv?= =?us-ascii?Q?sfS4rJuUcPb+tuC2Fhhycxp8Ro7AKyBP6uvbL3W0+TPYGSpLM78pO2LtPGlY?= =?us-ascii?Q?Yd1hV8Vsdk/sSL8TdciXL5ItWzCl3yH1mEJPvuNhenRdTso9KUHwGoa+chCw?= =?us-ascii?Q?TVqV93AowoK12AdeROtu8xXqHvQZKPoR1S95QpohG1ozP9hun5N+c4jDbYXy?= =?us-ascii?Q?ZMVSvipHuldUCzAtn2uWjNBs3BmPq70hopBt2vNKFq7sSNRAajjTdMfAOJdv?= =?us-ascii?Q?buGRfitDmsGy5K29rRUhVW3vnw/cWEbxt4ybPmSQWHq7TggKQRgjia16R2+H?= =?us-ascii?Q?itIUM2AgDaP7AbTCs2H8GYPULiS8rUIhIlLjLoDC0KWklS/DsE3EXQuft12m?= =?us-ascii?Q?7C6MRm9BsEa+d4vndLNxfyYDIWtRc7+bZRwaVcIl3K7UCVXr97qNTWuo7U5q?= =?us-ascii?Q?urILUGJnInj2fIjobkR2FCe0bAL0GwwQG0tTrbl8on/0d4duz8RGMDTNth1/?= =?us-ascii?Q?efb7CrBJGWIWSHLnA2DDfY3pQArhoolhbA8rMiId6nQJFplHy1n+/leSD/rI?= =?us-ascii?Q?yn22FRLWRo6WUd9oN45E5AqYNXYQ6pv1CAvqH0QAlaG5BkWmYp2SPI/LIZG4?= =?us-ascii?Q?Dz8QWYb9S/YC5pYldsXBA7UcaBEG3xGAjy1wlCvHCGOBoZBda/nQvkIM5zJC?= =?us-ascii?Q?QjvOXtpmOAOQ6AnnU7ccOGDEijqIV2snVDyFthKr9Yfh/bV1kUxkvB1wTZzy?= =?us-ascii?Q?z12NPUZxAukzPASMTjJen3SD4D9MPZz18JO6ABWIFj1CvqOH0mxlsOMWRiCp?= =?us-ascii?Q?mXOCn5+ResRjBHJhPWbtEcTBi4K6kihHtLD/IV7ijYs+HntqknNumEKBVdR4?= =?us-ascii?Q?h3u4e+BTvw/Vjn/vxmADXCSC3rhoY/yGRNxDDL+1GsyvFQhxlyMg1+fpO9m3?= =?us-ascii?Q?0GI628sjNvsDatpT31bbTAPFF4mQ93Wcb3WyC0OpHpiBrFSdFkMHpyD4HOP1?= =?us-ascii?Q?d7jCdocoYdPOvLusLF8q5NmtGjEDNq/b2EzJByAmf6JX7mhvBNkIbqOfD5Vw?= =?us-ascii?Q?oFIokpw8FyUrviA3N212cUkI1H2I3vXtKWDj9qA0da0kOIDj0wsJaKKLLlIZ?= =?us-ascii?Q?HTOIukzzswsqJ2mJ/aCFHOc4aPRDO9ibhbW370xDbGGEZLVKAJhY9H18U0Id?= =?us-ascii?Q?wTnr7GRh7VoUN4Dgxe6AJegnmsFWX5qDArsUtgqRGECfMpT2GF3YwA6QQAQ/?= =?us-ascii?Q?Sku4mn1MbdC8QOvVmYuX9VLWI5pkvjEqsG3u4sWJOQ38bGvoGXYG0iOrMP++?= =?us-ascii?Q?HkVOxE7Ncev38ZSJXasDlM/A4lsbng5vlgCc7SnIHz5We5KEkB0pz1LynHk2?= =?us-ascii?Q?e7Z6jp/Ot0QGfwOTi2gDt0tEKNhIpnXn2ocs/ir2EKh3EqWdQyxFN7KL4gkg?= =?us-ascii?Q?cZrckYm7gCtS2IyX/IkosiakUAWiaCmyQOp+vUXjnXrsuSa/QBO4VExsfCCo?= =?us-ascii?Q?Q3im3w=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cf3fd05-da00-40c4-0eaa-08d9ec0663ef X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 19:57:24.2549 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m3jxjUFalen7SVZM+kt3sMlMYmE3b+HlfbeEBZbil+7sRMR07fYlYllAnSlNjGxKmmAOdP6qD4/RGLEuOJbxJn4jqFL+3JFVPTFh4WUs2kk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3721 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202090106 X-Proofpoint-ORIG-GUID: K6F_XD6l24j7pJDiDwUH7uodwpmkT02M X-Proofpoint-GUID: K6F_XD6l24j7pJDiDwUH7uodwpmkT02M Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Support for CPU and memory hotplug for crash is controlled by the CRASH_HOTPLUG configuration option, introduced by this patch. The CRASH_HOTPLUG_ELFCOREHDR_SZ related configuration option is also introduced with this patch. Signed-off-by: Eric DeVolder --- arch/x86/Kconfig | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index ebe8fc76949a..4e3374edab02 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -2060,6 +2060,32 @@ config CRASH_DUMP (CONFIG_RELOCATABLE=3Dy). For more details see Documentation/admin-guide/kdump/kdump.rst =20 +config CRASH_HOTPLUG + bool "kernel updates of crash elfcorehdr" + depends on CRASH_DUMP && (HOTPLUG_CPU || MEMORY_HOTPLUG) && KEXEC_FILE + help + Enable the kernel to update the crash elfcorehdr (which contains + the list of CPUs and memory regions) directly when hot plug/unplug + of CPUs or memory. Otherwise userspace must monitor these hot + plug/unplug change notifications via udev in order to + unload-then-reload the crash kernel so that the list of CPUs and + memory regions is kept up-to-date. Note that the udev CPU and + memory change notifications still occur (however, userspace is not + required to monitor for crash dump purposes). + +config CRASH_HOTPLUG_ELFCOREHDR_SZ + depends on CRASH_HOTPLUG + int + default 131072 + help + Specify the maximum size of the elfcorehdr buffer/segment. + The 128KiB default is sized so that it can accommodate 2048 + Elf64_Phdr, where each Phdr represents either a CPU or a + region of memory. + For example, this size can accommodate hotplugging a machine + with up to 1024 CPUs and up to 1024 memory regions (e.g. 1TiB + with 1024 1GiB memory DIMMs). + config KEXEC_JUMP bool "kexec jump" depends on KEXEC && HIBERNATION --=20 2.27.0 From nobody Sun Jun 28 08:36:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF94AC433F5 for ; Wed, 9 Feb 2022 19:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230140AbiBIT71 (ORCPT ); Wed, 9 Feb 2022 14:59:27 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:52684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229981AbiBIT7X (ORCPT ); Wed, 9 Feb 2022 14:59:23 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16EC0E06C42B for ; Wed, 9 Feb 2022 11:59:18 -0800 (PST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 219HK0eP020152; Wed, 9 Feb 2022 19:57:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=zWuAGEPnxML/EZcjnzCwskuUNhD3Rjrsbq7/CLvb68k=; b=CDgSFEGuQJBMIlWEo77OTYJUksn2Zqww1UFh0cjnZCwxdLJDSWGE5KkdwSjVWEs3yRO9 JO35U/d+MxH5trxHjG/IZkJTUs1F4YC6JjFfkvfLULZKaIb3vfF12Lo/y8Wnpjj8H6pZ EwC1GjKlLvNR/I4ehM0pN8yVXG8vDU3vA8I1EoLuRAXIwKAS/wgsPO3lEZU2kb6iYJrp hvK9ITAZJiSn/EX5iVYvMFjBJRbAv9o1vuO02xiyfOkXwHwKIua0W//SiCLkszumnrz0 HjcSzGH8fJEwiosVw+r6Uc6x+oIk2exNX+obg3VFeGFlbw7WjxhPQaEwYrJpwzYxauxp Mw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3e366wxyje-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:29 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 219JtqWK046284; Wed, 9 Feb 2022 19:57:28 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2105.outbound.protection.outlook.com [104.47.58.105]) by userp3030.oracle.com with ESMTP id 3e1ec3b07a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cvb1BKhZlpKz28ajZ+/AgxjExvieru0J5WKF1dRcDtDnqm7W6G/pG3a7rG44zj3VR7NGXY9S55xK1K82Y/Gl+3/ejz+PSaZmtbaSPLYglIa3uXVzHloTIN2/8/IPWe79Rn5Sj40JeEdyJm+ZU7mmgISA4O3ZOfPeMGCxHeMAuFXZ0+8IpN3bszggTyBz9mYFZ5DBHRanvoJkD6byongHFvygES9y0YGRZIdg07lI6SXzqb3YDE8xydsZIpOC9E6Iiu6zfJrfrbvJqru+ESlFcNqmxxku2zYcerzW42blEnlxr4ZCOQuZSjiLkpzySBqEAHy2EdmDo+qrD4ZS0TbqWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zWuAGEPnxML/EZcjnzCwskuUNhD3Rjrsbq7/CLvb68k=; b=SPO9PhuRp8pCyggqA5n7mrgEBI0vYChKA3Q5u2uStjoSPgXI+vmUBJ2tpqkqe2bTHnEmyZpleheer7d/Sy0gbb212LM/bTHoT2hdSDgfSXXZpzRHaDl3I4dM0blrqUcdvQva3wZZaNt+Ai/Y0wQqec1Dd/kqxcE2APOJ8bVAqF/JEtiT1bLsNRfbW1Fpf1ZqB27ip9WtY1PFg4fhgBtZ647Gdh7Y0E6ds2gxeHNgOg0L7lfTOl7Blfnja9IScd3PVcr7VOSmTy8rvmp9l5QBr2mWXn/Xg9bq6MF1ZjZNL7X9HRGU8D/w3BrTjFvsdf5cQHrfvrx6jJrXZntS+0H29w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zWuAGEPnxML/EZcjnzCwskuUNhD3Rjrsbq7/CLvb68k=; b=L2Tm5r0xg5I+mgc5QmPGQSrBHZB50tLVtwvW7nWRSai/41Exb7DxoiC1KDSENHqjkbyOa4ouE5CUul71KqGKN31/2mJ5qgpxxEjDJ8dbqFRtnnh1GNO/vBNAmYYceta+5nO8hdrUwbNZWpuJcJ1VeYjt/+DONwe+A2YGrQpA94Y= Received: from CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) by MW4PR10MB5701.namprd10.prod.outlook.com (2603:10b6:303:18b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 19:57:26 +0000 Received: from CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c]) by CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c%5]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 19:57:26 +0000 From: Eric DeVolder To: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, eric.devolder@oracle.com Subject: [PATCH v4 03/10] crash hp: definitions and prototype changes Date: Wed, 9 Feb 2022 14:56:59 -0500 Message-Id: <20220209195706.51522-4-eric.devolder@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220209195706.51522-1-eric.devolder@oracle.com> References: <20220209195706.51522-1-eric.devolder@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR05CA0046.namprd05.prod.outlook.com (2603:10b6:5:335::15) To CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d7a162d-7074-4f7d-9660-08d9ec066559 X-MS-TrafficTypeDiagnostic: MW4PR10MB5701:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1850; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yd5VuPJupO2Hu0LP0C8n0pN8H8eNoc3BESFLyP7wdRN5wbWyVHczeB7cP7i4T+tWpzCJpT4GcLh+P7AukqzkywDukd7+qfsrPBkN+CHW0FMFV/JQ1gejnieTnuZ0Paogd8Jsl3pu7dDCIYtyVHJzDKsfmF08+Br3m8/SzlBWS3ysKGW7bfKXCK2JGxFxkDwrhf+C3AI6QTWBcvR1bombfqh102HEfCwQ2lsxM69+7bm9zT3G/itwm8hrb+dO0e3vvMJ4ciVZrhW1/UX3W5VMuIAf2ct4867SY6ak8aj18zROTZCUxOY0RoeopLVmOeUqKSAa1FmSh2sTPgRuUvDeRbP40uyf+cR4DkoZOxfGc0ER/OGcY8qW76lnN88UC0Gsn7kGW2CbcQejCmYHcWN0aCOggKZyZHyD9uhR0bl6iDyXUolbDg22oMTsJbIrYp7K2Ftt2dHGkPO/iKPAMCw13LU37VAfb4W55vz+QQPwUIWnIpLoA6+RE/ciHN2Mo4cbXZPueMafAYjzPxAhI+9sx3A/+7DsVCsfdx87RCyAFM7EutpQa7dDqODJTyZdM5qTVySwlLj/beFkXLS1/T5F+M1sGT9W/1mlp6ShxE/zD8oFW+DfIPrf1JcVH5bcvSLKdHVSKJ1Bjx1SW2rgqBAPwdhI4fL2mlMePR4YM2pPWnvHm5pcxxgtiPTTGfxapc4k87FaZWMxjDrYaJBOhW8LsQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4531.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(7416002)(5660300002)(1076003)(26005)(107886003)(2616005)(186003)(38100700002)(2906002)(38350700002)(8676002)(86362001)(316002)(6486002)(508600001)(6666004)(6512007)(52116002)(6506007)(8936002)(4326008)(66946007)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IHdtQy024+uHycREsj1jg3lpWcYXtjwFmgW3w62aDBi59lIHQlkRueYRvkTs?= =?us-ascii?Q?yj9R5T1BHjA4yfzTZJqfIq8Tf+8yJMdVp0Ww3bXCvYyT+D096JTzdx671eMB?= =?us-ascii?Q?dgqUfwKIxStdJdFHbJB+BZWGY9L5m6CL3mgqTIWvYNe3KIKR6Ajpmx7MYimT?= =?us-ascii?Q?Cnv9iRDXBHCyghhlBwWz6T6fgblN3Yjc3rYDxvCfpYMf8R6IZi1yylBG1lXX?= =?us-ascii?Q?5KrQO7GeKlJr7kJBfXpmqEGk0WmVg6Shkcf/KfAVqo6yrGTx3L78nyI87nOS?= =?us-ascii?Q?DXeVP09Fe0s0rzbnf2FKaM8YjUactKyV7uTt3QJBLZk0D5ZaprL+02tDZeRc?= =?us-ascii?Q?P2h1efiUsdXRA6PN3ymHJGKP7o5BiMFC2ZppoEH0UqlCtMqjxHOGgJC47Gnn?= =?us-ascii?Q?rN9iuyiTaFk8Gb/H9luKcvoqvskcSHNoNCnMZ5GTd6SR33TwH3bfeC7ezgFt?= =?us-ascii?Q?PPZbQIrxTFFmUSP+O0n0ysfdujyYFxWoGBTgvA3WRz3wtjaSK4ORO9kyjUVu?= =?us-ascii?Q?T9xyIe7XEF3F83EJ0rv4MhSN2B+4TCVN/KHh2aOr0R7gHaIMUq4atigcNja7?= =?us-ascii?Q?XdKC4BxhVD83CE9tl02sEDwprQjFKgIqoNMK9L6uQYMlaAGhyrzEBAEpPcN+?= =?us-ascii?Q?vns+IiDMmQtys9pP0/23seLWurWmJWnFq495Bl4jdbpd8xn7Xzfx20a/gxqs?= =?us-ascii?Q?wqaEROW8c5SkOLvm+jm4tyu46uTRpCNunrBXybLH+KgNXlokgEk+r9/ITaJV?= =?us-ascii?Q?3YnApn3hT56A7FlAhor8a9PrLVyo7fRiPNMwFZc8gA0DifhVgyWaEGtDJ5y1?= =?us-ascii?Q?oQsKufhQ3hD376KKLJ4Zk83836kEAPfdPTGn1wGH8iJ+a6129ouIPfqi5cYa?= =?us-ascii?Q?iYbljHCf6qnCKValC4a8pmpy4mU+t8YGZ3QN6JgQSa7E2J9Y2IQrl40qIhrB?= =?us-ascii?Q?FH5nDn6qKeOyy5ZbvOf6LaiKLrWG/RjaJfv43iLHZYL0QhgEn3mem6ThU+G/?= =?us-ascii?Q?S0MMIkoztk5R4jeQgs3Y0lJX+sWbBsLxBLwFqVC7vu8bYU3isp5NX+9KCA4d?= =?us-ascii?Q?nDRuNBJAYW+SSY0WY8TZ403Qy7tUsIWsETjaH7210mzhSTWXgWu+lfVUaTMj?= =?us-ascii?Q?rwwrHLMyZCvG2bbuHt9po7tw/dhC4fuYPzGoLi+3vMHR23IfYIoEqXrL1Mzm?= =?us-ascii?Q?lP4XfmT666UpjmBKE6K3xR0MfzmtJw4KO5P+40M2laPLheJEN52NcT2W/e/P?= =?us-ascii?Q?efSKhTUeB3vbjAGxYXYb3U2jX8c5BXsK3Gy5TFbl4CeGjW50hDK+9yZ/AVQS?= =?us-ascii?Q?bkNTV29ZAd0U8onfVQa2cmo53o4c6JX4H6eu1baYt6DZWEthKylxnRNRS2wD?= =?us-ascii?Q?Ru9He1FfoOjQ/IbmUjzUwCphXb/fO0DmoRaGsEF3A1Qvh13DaP/NRvu3rzLh?= =?us-ascii?Q?TLFJVpo288d4Tbeh9cBRunMQAqbzofAmdygP8FCPQRuCah6DK5KBnzwOgWub?= =?us-ascii?Q?0x6MeH8xuja7dX3AOqrX7azgs2CMXCwXmDLwS3XK/O3LOZTQsw0n7gPugjwG?= =?us-ascii?Q?7OYBcCTg1eWDYjkJrNbCmoOBPJNfbV04KTtgwQaJABpYqzvAu/hplkxZfRum?= =?us-ascii?Q?2eAatqGTSGe/HxIal0dxSY18MrGCvbzpt8gD7rctetmEJEYfAVcYcJ2lm88Z?= =?us-ascii?Q?GrMXiw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d7a162d-7074-4f7d-9660-08d9ec066559 X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 19:57:26.5526 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5WTPMnxEcOpL7r0Q6I2kb4kMdo5101o4PeMpyVgKgFZUJTKNOzx9BQz6KiedUzgK08TAGUPibf2bsz4OpiT7VLVkzW9eHpiY8Cl8/GQ5494= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5701 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202090106 X-Proofpoint-GUID: ddJlKh0XWCcWpIh9UiVM8OH-Nd3WTO8N X-Proofpoint-ORIG-GUID: ddJlKh0XWCcWpIh9UiVM8OH-Nd3WTO8N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This change adds members to struct kimage to facilitate crash hotplug support. This change also defines crash hotplug events and associated prototypes. Signed-off-by: Eric DeVolder --- include/linux/kexec.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/linux/kexec.h b/include/linux/kexec.h index 0c994ae37729..13c238c2da48 100644 --- a/include/linux/kexec.h +++ b/include/linux/kexec.h @@ -299,6 +299,13 @@ struct kimage { =20 /* Information for loading purgatory */ struct purgatory_info purgatory_info; + +#ifdef CONFIG_CRASH_HOTPLUG + bool hotplug_event; + int offlinecpu; + bool elf_index_valid; + int elf_index; +#endif #endif =20 #ifdef CONFIG_IMA_KEXEC @@ -315,6 +322,15 @@ struct kimage { unsigned long elf_load_addr; }; =20 +#ifdef CONFIG_CRASH_HOTPLUG +void arch_crash_hotplug_handler(struct kimage *image, + unsigned int hp_action, unsigned long a, unsigned long b); +#define KEXEC_CRASH_HP_REMOVE_CPU 0 +#define KEXEC_CRASH_HP_ADD_CPU 1 +#define KEXEC_CRASH_HP_REMOVE_MEMORY 2 +#define KEXEC_CRASH_HP_ADD_MEMORY 3 +#endif /* CONFIG_CRASH_HOTPLUG */ + /* kexec interface functions */ extern void machine_kexec(struct kimage *image); extern int machine_kexec_prepare(struct kimage *image); --=20 2.27.0 From nobody Sun Jun 28 08:36:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19A98C433F5 for ; Wed, 9 Feb 2022 20:00:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230521AbiBIUAM (ORCPT ); Wed, 9 Feb 2022 15:00:12 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:53570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230270AbiBIT7e (ORCPT ); Wed, 9 Feb 2022 14:59:34 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C5F1E04ACB0 for ; Wed, 9 Feb 2022 11:59:27 -0800 (PST) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 219H6fo1027623; Wed, 9 Feb 2022 19:57:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=4CHoi8tqlVL0/7RbUyPcGVvdE6vnARDE3PCOqd5z3ts=; b=Tj6tggintmXlG89beKDEXgWARvZbUSqOXu0nbf2Ha0YHV9+hoxrUxPaMetwD4ii8ssuX 7K0nzvjPbuF78L1l4dS0hhIYBFjYOc31ToLt1usMXPkhEpCvJ2uPFV7+aCSvcS2/ihZ+ /X0F7Ej9MF0xajrLgfiotJRRxbLhB0D6duqX1EODBmrksyjzUfnrFWQlBiIztBPdezTY 54rJwDKUroAs4fSupAntjVBVhmH8Bhbde1bWhQ6mo/hnJHaCy2FJSGgDNeGwhLupXoUD XWL0lvLIKliPgk0frI3QblS/qWraQ1WTwZoK/f4sKs/32jrUClLpE6ptzRnTmsn1TjoP LQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3e3hdswn2n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:32 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 219Jtqh3046293; Wed, 9 Feb 2022 19:57:31 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2109.outbound.protection.outlook.com [104.47.58.109]) by userp3030.oracle.com with ESMTP id 3e1ec3b09u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e9nbYJyy09yjCEkFHrzsIe1EsXLUvZIHwHzNrMuMyG1Z6+oCanemoE9PyrM159/4g7dWkdiHYiShZrC7CEVt5W2McE2Az1W7j052Wr8detR3K4OKPtgDz51G1T3bTlG9xWtPKR/gLoq2zblIRkU6gEytWXt4OWAbTQqOaUNxLj/N8rSac+645Tc0fEkeyQ+0d0EifE8KQHCoCaTjhcRB29OoS/fJ3p/42dd5DSkSvFERo/9M1VGtxIvjzc5zqD7Wh9xEO9ZpMggLUThNb85ztSxhU7fwh06U3lObq64i8JRfXfltioh7289ie4NW9v6AMWMXs7iTVktv12+goqd3uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4CHoi8tqlVL0/7RbUyPcGVvdE6vnARDE3PCOqd5z3ts=; b=D73j7sFMRA7iGbveKbpyO6LdoCKZG6Lo6R5b+XBURNrPOUMeihaddmfPgDq8J3gjjH6X1bY2ZlH/ZP33W7LhLXUDt5Yu5Pyh2iw7vDcrLk+WS4d4MM5XVA68TWGJT0vm3onTOnY7GVxo4Kdl9Dzj6Ju3cwgQZ8MeaI3TZdbDGQwIOixYGDbYwGDSOsFkSY2VeDIenbtSo6MU1VuGsr4S5fR7hCI/M3b0VhmZXfzHSPN/kHVP0Oqz1MMWzCqE9R256DRii1BIAn7TOceDjszEAkxhGPHk3gaiSg12ojQ0xgXl4mFCfcs7TWEVMA7mN/gVhKGtNiRXk6qethAqSti29w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4CHoi8tqlVL0/7RbUyPcGVvdE6vnARDE3PCOqd5z3ts=; b=faomw66Z9KxkyOnckZdnr9K5R7seZN9Cr5yiSk+ObDqJH66ma951TqMk9y9na3a3DYm4sTp5E69m4fuhw5AL9f5PeZwlXTZFp83sjTM19Ii8NtvCgVBz8Fd1qy52lEeHlHOsnrOZ5v9DbpunY2TePKJuTuBI3MPRl+//Frxb4OY= Received: from CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) by MW4PR10MB5701.namprd10.prod.outlook.com (2603:10b6:303:18b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 19:57:29 +0000 Received: from CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c]) by CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c%5]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 19:57:29 +0000 From: Eric DeVolder To: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, eric.devolder@oracle.com Subject: [PATCH v4 04/10] crash hp: prototype change for crash_prepare_elf64_headers Date: Wed, 9 Feb 2022 14:57:00 -0500 Message-Id: <20220209195706.51522-5-eric.devolder@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220209195706.51522-1-eric.devolder@oracle.com> References: <20220209195706.51522-1-eric.devolder@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR05CA0046.namprd05.prod.outlook.com (2603:10b6:5:335::15) To CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f27f7fe-7330-40a2-9f0e-08d9ec0666ba X-MS-TrafficTypeDiagnostic: MW4PR10MB5701:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ce69bnK1YgeKbWhnWfJ14ciHfTMtud0GAOI3Sips0JEawagtfliM9/2tJdPv6riKNaUMW/40AnlfB7RzFMHJHraagQewx322oZOAV4Eq7OaV3FyM0v0g1iuYgKw61NS2eEvjM525OAyXuUz6cqnG+l38DdR6OpYDE/UnlYy1Fj3dW3sUQpyRyCcBUj7LW5LJxRnprBR5CQjEp5Fexb1rYqI9eUh6sUyCcjitnlQOwTp4NdZ6jhxY8a7R4aEXa+YYcrVtIwtPCL7i8BH1evjp+2xKlbgu7343yFzhUa0FQ7kPUYS9xbg5XAshfzbxzfg1+sHEl+sB29GxfahNB8Wy6+bVqoGNbR9jzgxeQdfibOBF8ZRjgzKL3F7BJB034VYwkPYq3jwAsm5JqL4CSJXisW6QYoU7KMF8tiFST0yioBUtls84HXWQ1QNtEpdwmDDWd/fPdAw+S+XAwgYz2aPr5AOSz5e0Y4I/ejvWsQb3b3JxPNCf8l8wEHeBWsH/3NUlaNBIZs5IzTRaKMr9KHFbYLi5/Utu9QzQLWTLqXYxuZvKFr79ubJF27BmkjIgMuuQBJJ0OTKPUuB4UH8zeU1aVyL8ROPfQUClb4TknpfFTR5QmWHYng/6kHSC4qzktAn09C6d6GY9oNn5I4WIAWgI3C1S+J6wqEojOVEAHpSV7UtlazIYRc7Y3fGSuIxAyZuZMTOEeF8z6b7Vst9fvIq+kw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4531.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(83380400001)(7416002)(5660300002)(1076003)(26005)(107886003)(2616005)(186003)(38100700002)(2906002)(38350700002)(8676002)(86362001)(316002)(6486002)(508600001)(6666004)(6512007)(52116002)(6506007)(8936002)(4326008)(66946007)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rj7xD5mfFcCKlQ245DC9VOiyvhzbiiAy9PMBmIx2JRKMAScw2kmXQXTsFqUf?= =?us-ascii?Q?mGbkbOma4VQhxJnPf66aeSRetpzpvsBKbOTsJ68SWE8AAlVEKXtSOioMjwxh?= =?us-ascii?Q?Jx/awA2WMdFLFDGk2TqBpFTDnj94vbHRsZ0VQTAKD2IUgqC+iTyq3pYpVnaJ?= =?us-ascii?Q?dq2QftGjF58gkfGAadH0s6HuqKSvp+Uhli2zh9cFaObP96LtZhJV5KE2Lr2u?= =?us-ascii?Q?xcznnpMtgYkzFk5B5IKMnohwY/4H3OjZz7ZW/DT4LC1Jg3d/2YNSKY3XqcqR?= =?us-ascii?Q?5BhzHBq6R1sPObSb0AcmxBm8GVXGvI2d8uvnXTupNTq6gGNeXIvd+WRWXjkR?= =?us-ascii?Q?LfbtBklWJ4nPHlVp66eNb5GKxmZDwrNlo6TWQ/NqJRWaYuK00Z0mjWevYB4M?= =?us-ascii?Q?S8HTdB+2mQLJrLcMHG6lGhaKKgw7ZKLKSZhYUmYV9pJ84pPanxhm/1kZVxtD?= =?us-ascii?Q?vlOgI7JG/dnLCOTv4tXtKMe8U6rBZJrtjya85laR5qwIrOjMti7cyFST3lYn?= =?us-ascii?Q?PQrIj8mMSm3lc3ndA9alCzPeglB6KnSR0+7HH53x6BcalMH83YVMu0C1ajA/?= =?us-ascii?Q?gjLvbHC267MBzdjpq7ljBfVCmjdx4ooOMT3C0GTKuAl7UJMuaMMhICLSPWmg?= =?us-ascii?Q?DiLzO3Gc5wJ+Szeflo3P2KmKO77C+dXuJbjCGJjZTILRmE+czWPHQk17xOFB?= =?us-ascii?Q?QKu3CfIzs7r6+OXHmtGNHz7OUrZ9NoZEq+iIlnWsSWY2pTWZT4B1FH+ncid8?= =?us-ascii?Q?5e/TjEKQPtyDZbaDVKtBUeHtrzV+ZShaSRUzj1kqOHEhEg23Gfzd7OsgV+AT?= =?us-ascii?Q?cE52+4+5MIdOxSXpwRFc1O+lIGiko+70bhDb1zV5wvWvGasOigTEAd7gfhCu?= =?us-ascii?Q?fMXhPUvzNHUmum1ol/za48e8iYcPM8dfj8Rai59InTco3wdVt4F5BsVJsbVs?= =?us-ascii?Q?RZKSx81MO412bU8fE/jUZBX5RZZb2bZ92NdJONt71+BO5vV8vwC8vBZSOvIz?= =?us-ascii?Q?C5baRZjJrRbjfxGxXq0e2zG/2DwCJaIOrQ8Cm/nCkQiH4KoIuteI0XJ+FByS?= =?us-ascii?Q?s4ymedIJ0w+hFEag119Wp0l5FThhceJi0RnjXEWLpa764do/8JJkIkewjZx4?= =?us-ascii?Q?FFeo1p5/ZqJFPtF0KRnbVHVbav154rGDurb6Vaa8hsJRWSkV32b5CcAVoMcy?= =?us-ascii?Q?cjMK4KT3nFdsz8zmAv+IDr3BWjsWJO1C2rR1ZR4tm0AI1QF3Osl4gU9kiFK+?= =?us-ascii?Q?CB8HYzmVgOxdEZHVhfEKI483Aq4cCh7CiT5KVLEksHUltU9Ko2v+C6z15wcS?= =?us-ascii?Q?Kl/dir1Mn5YDL+LlQ5V75/5YglHYPQ9sCsEE4PhIGtbMct10xpr/019X+1FF?= =?us-ascii?Q?CaLQjtl37FiOp1ANah267CJALbX755K/HA4SoRXnGrSF8WpkX1GUMxO2FWxH?= =?us-ascii?Q?4MQyf2mfSfAcbMZ9lh4g0dRvwdAcLNMS5Zshy5ZtPw5STU86VeC+YR2QMDx+?= =?us-ascii?Q?uSvtVEMml0G43+RakJ3RyRNxPAelkG9uXk00VI97zjSWw/NjvivmLgxBXaRV?= =?us-ascii?Q?qejHSKbjWfjL4oeBKNj+fms1hipEO56oFE3ci2dqhsRfhGYxIxgkh34Cfg0f?= =?us-ascii?Q?tJg223C/x3jtQ5FsIhDPz+UTgUita00ukXn3cdyk65BVphIlmewvjH1hj7L9?= =?us-ascii?Q?6m0XJg=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f27f7fe-7330-40a2-9f0e-08d9ec0666ba X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 19:57:29.0850 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7mEyHUM0T095I5bl9S8HpF9qJbrRgAkIZ66LovnwqSXA/xG8G1+tLn9jn4Z9VCzAC2AW4OUBk6KjZzu/m8uL6SrIMa9EQl8sIazRaeaeEC4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5701 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202090106 X-Proofpoint-GUID: vUXE5iohOFkzPRCGi7WbH4qmkQEywj8o X-Proofpoint-ORIG-GUID: vUXE5iohOFkzPRCGi7WbH4qmkQEywj8o Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From within crash_prepare_elf64_headers() there is a need to reference the struct kimage hotplug members. As such, this change passes the struct kimage as a parameter to the crash_prepare_elf64_headers(). Signed-off-by: Eric DeVolder Acked-by: Baoquan He --- arch/arm64/kernel/machine_kexec_file.c | 6 +++--- arch/powerpc/kexec/file_load_64.c | 2 +- arch/x86/kernel/crash.c | 3 ++- include/linux/kexec.h | 5 +++-- kernel/kexec_file.c | 4 ++-- 5 files changed, 11 insertions(+), 9 deletions(-) diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/mac= hine_kexec_file.c index 59c648d51848..7dbafb42ecf2 100644 --- a/arch/arm64/kernel/machine_kexec_file.c +++ b/arch/arm64/kernel/machine_kexec_file.c @@ -39,7 +39,7 @@ int arch_kimage_file_post_load_cleanup(struct kimage *ima= ge) return kexec_image_post_load_cleanup_default(image); } =20 -static int prepare_elf_headers(void **addr, unsigned long *sz) +static int prepare_elf_headers(struct kimage *image, void **addr, unsigned= long *sz) { struct crash_mem *cmem; unsigned int nr_ranges; @@ -67,7 +67,7 @@ static int prepare_elf_headers(void **addr, unsigned long= *sz) ret =3D crash_exclude_mem_range(cmem, crashk_res.start, crashk_res.end); =20 if (!ret) - ret =3D crash_prepare_elf64_headers(cmem, true, addr, sz); + ret =3D crash_prepare_elf64_headers(image, cmem, true, addr, sz); =20 kfree(cmem); return ret; @@ -96,7 +96,7 @@ int load_other_segments(struct kimage *image, =20 /* load elf core header */ if (image->type =3D=3D KEXEC_TYPE_CRASH) { - ret =3D prepare_elf_headers(&headers, &headers_sz); + ret =3D prepare_elf_headers(image, &headers, &headers_sz); if (ret) { pr_err("Preparing elf core header failed\n"); goto out_err; diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_lo= ad_64.c index b4981b651d9a..07da6bf1cf24 100644 --- a/arch/powerpc/kexec/file_load_64.c +++ b/arch/powerpc/kexec/file_load_64.c @@ -797,7 +797,7 @@ static int load_elfcorehdr_segment(struct kimage *image= , struct kexec_buf *kbuf) goto out; =20 /* Setup elfcorehdr segment */ - ret =3D crash_prepare_elf64_headers(cmem, false, &headers, &headers_sz); + ret =3D crash_prepare_elf64_headers(image, cmem, false, &headers, &header= s_sz); if (ret) { pr_err("Failed to prepare elf headers for the core\n"); goto out; diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c index 9730c88530fc..9db41cce8d97 100644 --- a/arch/x86/kernel/crash.c +++ b/arch/x86/kernel/crash.c @@ -265,7 +265,8 @@ static int prepare_elf_headers(struct kimage *image, vo= id **addr, goto out; =20 /* By default prepare 64bit headers */ - ret =3D crash_prepare_elf64_headers(cmem, IS_ENABLED(CONFIG_X86_64), add= r, sz); + ret =3D crash_prepare_elf64_headers(image, cmem, + IS_ENABLED(CONFIG_X86_64), addr, sz); =20 out: vfree(cmem); diff --git a/include/linux/kexec.h b/include/linux/kexec.h index 13c238c2da48..b11d75a6b2bc 100644 --- a/include/linux/kexec.h +++ b/include/linux/kexec.h @@ -221,8 +221,9 @@ struct crash_mem { extern int crash_exclude_mem_range(struct crash_mem *mem, unsigned long long mstart, unsigned long long mend); -extern int crash_prepare_elf64_headers(struct crash_mem *mem, int kernel_m= ap, - void **addr, unsigned long *sz); +extern int crash_prepare_elf64_headers(struct kimage *image, + struct crash_mem *mem, int kernel_map, + void **addr, unsigned long *sz); #endif /* CONFIG_KEXEC_FILE */ =20 #ifdef CONFIG_KEXEC_ELF diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c index 8347fc158d2b..801d0d0a5012 100644 --- a/kernel/kexec_file.c +++ b/kernel/kexec_file.c @@ -1260,8 +1260,8 @@ int crash_exclude_mem_range(struct crash_mem *mem, return 0; } =20 -int crash_prepare_elf64_headers(struct crash_mem *mem, int kernel_map, - void **addr, unsigned long *sz) +int crash_prepare_elf64_headers(struct kimage *image, struct crash_mem *me= m, + int kernel_map, void **addr, unsigned long *sz) { Elf64_Ehdr *ehdr; Elf64_Phdr *phdr; --=20 2.27.0 From nobody Sun Jun 28 08:36:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4208C433EF for ; Wed, 9 Feb 2022 19:59:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230355AbiBIT7k (ORCPT ); Wed, 9 Feb 2022 14:59:40 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:53562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230286AbiBIT7e (ORCPT ); Wed, 9 Feb 2022 14:59:34 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9A81E06C407 for ; Wed, 9 Feb 2022 11:59:26 -0800 (PST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 219HQ89m020178; Wed, 9 Feb 2022 19:57:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=3Nq4MkJMFFvq2gmL3qOU5qrvS3ywvSPoY6fn4Kkgsj4=; b=coYom47f+ZFRQBa4Pwz5BUIxB3qHBKK5CTimz61TzHzKtSLMNpj32Tv/B4GNV04aglZM 5ejgWfPLU5OwoQ1CTHlfR2+ImdHQzF+LPQ69OWC0x7XoDSLS1YNF77qgCp3bMNIsj14j 5gIWizTB3N71nYH9iF585WcnATcp+3gIrky9ZSNqN3gE4MBAifUA3YVeUxhiBt+atu1o 3zTNGSA9S3bIjV2VmLmAALFVm/EATBM87HcASSqN2jLzGOlU+K5nXqTzCPNiFL1mj5CF 0d3dp4CxIPC2ytCltb/epVZpZme5SPwHjNMNcHoHZxgowQ+hJslfY3d+1KyqLFyR1pU+ ug== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3e366wxyjn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:33 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 219JuBUZ095710; Wed, 9 Feb 2022 19:57:33 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2104.outbound.protection.outlook.com [104.47.58.104]) by aserp3030.oracle.com with ESMTP id 3e1f9hy672-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P8FjpG0cOkaZ2th2D4df5wJh+bjox1dJewwcsKKQGmG6XvPHwhoSCkLbweYjCP3Y5N1mComMG/tGVtYNm06N447K2uvuB0N6S5JrYHIKSh8sU0J77CdJ/YdMVWbR+/qYsZV3A4pcJEP3eTBbZWOszmPssLReYLeh/m/UCloEOIjIWoX2iUmu9BD00Pjm80FQeQdxq5B17lZG8yqFlTYYORn5hs41a3wgpfaE/rXXBNG1YA/9vmRRxiTQKLTro8J+5kkgC8+xRldH+op1bV7CPYPWGFscbWMvbVJYtO51Y2rzU3Af3rJ+LSzCiVigg0RH1uwzDQggfqfgFdbn5bpX8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Nq4MkJMFFvq2gmL3qOU5qrvS3ywvSPoY6fn4Kkgsj4=; b=UayErf+k3KjsfMvJzLcpaIOkVJzGWEX9BNFB/ZNMMLknhaPmzMAmsNDZ2xG7MFy6p1ZcwlMLR0gjySySvXF32wWxhUaGxIQ/dSPwdNkUEVDubCJ1d/TLyI+SripPqz/vXDZ/ZyDY+l5rsyCszuZtVeLLcy6XugErIMAIJbGRg5JjIh4qUyH6PVg6PU1jNYhi9qoq/ELWVf5bWTI0+SF//GZViX1ERkxQ32VCJnjxC73bUGqNs5Z+Y6dAGYWfROUWFArAkhNdkODRGr2yutQSrXe2/iKEX+tivYWa/nOp1I5q4NEg75yF0AA/ibdSWOdA2TFIkBgth/zqklwgXO0ZqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Nq4MkJMFFvq2gmL3qOU5qrvS3ywvSPoY6fn4Kkgsj4=; b=JKmk764FrEQr3qN3G3OCI4d5ehkVCfUG9mJlQY2Zk9lBWtm9raLkso+OpVj6xpMexVC8c1ldNx6WYrAR66coVuC0fVuxUKxn/Vi966b8n380FXpfgNKx8c5Sz+eKK5PCDsdaJqXPbxelb+pMGKSRruopErFmNXp2NBRtbM9s9FM= Received: from CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) by MW4PR10MB5701.namprd10.prod.outlook.com (2603:10b6:303:18b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 19:57:31 +0000 Received: from CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c]) by CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c%5]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 19:57:31 +0000 From: Eric DeVolder To: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, eric.devolder@oracle.com Subject: [PATCH v4 05/10] crash hp: introduce helper functions un/map_crash_pages Date: Wed, 9 Feb 2022 14:57:01 -0500 Message-Id: <20220209195706.51522-6-eric.devolder@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220209195706.51522-1-eric.devolder@oracle.com> References: <20220209195706.51522-1-eric.devolder@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR05CA0046.namprd05.prod.outlook.com (2603:10b6:5:335::15) To CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62e775c0-b33f-432b-9d23-08d9ec06683a X-MS-TrafficTypeDiagnostic: MW4PR10MB5701:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Rg/VZ9MRl4va6uuVtFKK+OuwzgVmTWGEJolbN5NHy06XrnWbltb8vvYNbTuqQXUvy0zf0f0A7waWNzNdKEWN2N/2aIGi/HE5QrT+PUIUP3mlMMXuJCAfMUXkZb1UOgonIhnZ2DKGf8qHmdJqVzD9S/0hvo8oB1eFkvvKpc3SfqBy0gwhlPtRHnMYevnAsGCMc5ZexSeRhKNXta/6hUFWn5pNCcK2Ye/6H6/k0GEKik2YHoqE3p35k690okr8V12yPZ0UCbjBxoXRp/58wVlur+bEqN5qIz25+6pundqADcIZBW8+ebo735Ch3nWpda4dkbbzdftSeF1dsRSUGmgaD4bRooKflaD/qw/QIsDlRrL9lEOEJUlUxL9yWxHG5hMIVIADKT2bAOinrEH/Vljce3BjDSDiTZ2D3qPnAAQ2fii45r/Gr6CglFDFVqGsXCqSUxFSrcao+2CagnkblqXdJIJ0ICbsa1IJlvegMkVMDrM4Edglmw6XcQ81WE0GmcJG8kbVGgeDWNOl7QYcbMMEUm60d3k8xaWEcZHNpSfenO/bdbHDxmFQTfe1/H5qKoxG2gEEYqvoilbhBbgMZ2Ny6kajSfy2JGn7f4thrvcULyTK6GReJ942J1OFc5p0JbYIj6c+CfT/os+5DYNQRgfhwkBSEjAfeXuurN2a+5CUmOhmGaPDTUcj2R/HBb28jtr4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4531.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(83380400001)(7416002)(5660300002)(1076003)(26005)(107886003)(2616005)(186003)(38100700002)(2906002)(38350700002)(8676002)(86362001)(316002)(6486002)(508600001)(6666004)(6512007)(52116002)(6506007)(8936002)(4326008)(66946007)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SDisjgfmblDJDhdS7O21ogvKjWqBWGNzAhs87WEXriTBBimSC08CRQG91KZM?= =?us-ascii?Q?nLb1UcUZtKGJoBONJMUkvOic/3FrJ1Em8uSvZr+l1DWy1EQAvnnAtqAE0+KE?= =?us-ascii?Q?0HwSEO5rozp2DJLkDXZECQGCLujWo9XL3oC8ZkK2UndheYAgODdU3aiVwmMw?= =?us-ascii?Q?CGuuHix3gMiDUJ1QjQWqbkXIugNZISKxbKGdAzWE+y2lD3HDUtAyVhax4wl6?= =?us-ascii?Q?irh3deCikDkHvwFkR0TY9TwcZ2kXj8Fg6gdCK+6ayJ3CFw4vU1CEGbNnLtaw?= =?us-ascii?Q?xq/S+ORWYFVntTbUh6HXl85QuV4nDoiyAyEJbLgm3qhbhVOMcdQGt/zdY2oB?= =?us-ascii?Q?yYrF35jahOVEcrRxmGmbof7/g2fHgiFs4ZxhdKmLw5O3I9PgsJ4w6tyqaBI/?= =?us-ascii?Q?qh0D+2IHE1e/PTjprCOdf7ZWh6cKal+TC4yFl/LpBmxt8Io7BNPVBzrcd0YE?= =?us-ascii?Q?m7vdWegybJB86OgrhTRzvAb4LJwpq+QMeQDpgbD549uT/lYlqFilVncpSTmb?= =?us-ascii?Q?sq3GKV1fe4ZXDtdHIKuTshjipWCkuyEXkNIha1kfj4NpMhDtRUYDAwXwEosw?= =?us-ascii?Q?6Z1coi6CmEwYN4P+UVrilJTywXcGhfj2TJTyLecdvXRFc3ibzvQs7lpCCkwM?= =?us-ascii?Q?Wi9cKCUB2ouwt5k59CvuR0PQYckGD8QO8ujIerVz3rSkuiM2IYAYRo7mw+hv?= =?us-ascii?Q?Hk+lTU1zPJxxCwuFFNbD+X6GvaKiu67QFtiYV2S+brpCBAvgNbkL10HDw9gk?= =?us-ascii?Q?M4fyIQv1SR5grxyVPmhSS0L8FznIuur6uW0SGwNogjQZ7FXZBpkzUz477D1S?= =?us-ascii?Q?KuYr3HSiSQEcUbsSF3nos8KTHFGzO1qK83AUeCYKZrvN3WmOBU0IqR8vaIUK?= =?us-ascii?Q?l6XT204hwqnkbwAtF54Fy962tIEMG8IYWi/6T3ZmygldBkCi7m2e2rRIymyi?= =?us-ascii?Q?IJP/JNTryTeY7cWFHbr6y/i/8dff4jBmrTMDdzew5Y8VnlRHa8hE6WFY1Enx?= =?us-ascii?Q?OLjXdYMp0suq0lCTRt1JYvcm7f2dKfSy8qI9jk646fpGblTaPf9htGfrcXVA?= =?us-ascii?Q?9wFDacP4EPQw6YSaQjGzZevz1u7tgXxzlep1C5JBW0hzm8dvYdOdby3G6aM3?= =?us-ascii?Q?c/92q67ZgGnsBt+aQVoP8djoaJGIi9E/BA8vgjsjZf45Edw0/d8Ghw4rMpVe?= =?us-ascii?Q?0zexKOA8ikbf90e9GsnU6LuI+91BpMkVU9MK2sNAKEcGYXRS7QicigM5c13U?= =?us-ascii?Q?fSh5opu2nHHNK6X9jreWHiCWNEvei4o8uHwVbd6Ab88expfKq126Dyt2Hhje?= =?us-ascii?Q?fA4Yw9qnxDxkzfvQqb8obGQ5exLLIYmCgQ3u8CZKJXzQ2abnBk74OkkSXD82?= =?us-ascii?Q?b/1TdIZ4518rSmRi1n0HpDhj8BvMwxwTEYsveUcMpmY5eugELSJsP7p2daBy?= =?us-ascii?Q?ukKkjYcC15v25Z9OPX2mXRQa8F1IrbVEdiysZDOLF3/01LrgeHjDRwe7qjVf?= =?us-ascii?Q?RWy6LxrLwHjFvK9ao70gkHpS3F7nl5N7sJBi3ZHIv8EMACPLDqaTaaDjIQ9k?= =?us-ascii?Q?yA+1Q+ncfQKTpxkCFJkAa+6qShiBMg9lPS6TdndaVUMcmICmRX5JZG+dJ0tx?= =?us-ascii?Q?WCiyIHeOMdpRQkUb790tXWwBXEP76RlHke1VXMI8G7Et50vIaLAf9NTtPscN?= =?us-ascii?Q?eaZ4Tw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62e775c0-b33f-432b-9d23-08d9ec06683a X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 19:57:31.3828 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qV4ypv0SA9DOjbMRzt+Ea3r/p06++rIfjKkCM9zLl7LQm1Vs95YiSqJ98TCRpWrUIGCYITHr3Luuh95uAQ13i4gowAhC50jKjcSDGCwcTmw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5701 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202090106 X-Proofpoint-GUID: 4Q_OLwA1WI2fBBb4VBsnF-yPvhlX5mgL X-Proofpoint-ORIG-GUID: 4Q_OLwA1WI2fBBb4VBsnF-yPvhlX5mgL Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This change introduces two new functions un/map_crash_pages() which are used to enable/disable access to the segments in the crash memory region. (Upon loading of a crash kernel, the crash memory regions are made inaccessible for integrity purposes.) For example, on x86_64, one of the segments is the elfcorehdr, which contains the list of CPUs and memories. This segment needs to be modified in response to hotplug events. These functions are used to obtain (and subsequenntly release) access to the crash memory region in order to make the modifications. QUESTION: These might need to be in arch/x86 as I'm not certain the implementatin is valid for all archs? Signed-off-by: Eric DeVolder --- include/linux/kexec.h | 2 ++ kernel/crash_core.c | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/include/linux/kexec.h b/include/linux/kexec.h index b11d75a6b2bc..e00c373c4095 100644 --- a/include/linux/kexec.h +++ b/include/linux/kexec.h @@ -324,6 +324,8 @@ struct kimage { }; =20 #ifdef CONFIG_CRASH_HOTPLUG +void *map_crash_pages(unsigned long paddr, unsigned long size); +void unmap_crash_pages(void **ptr); void arch_crash_hotplug_handler(struct kimage *image, unsigned int hp_action, unsigned long a, unsigned long b); #define KEXEC_CRASH_HP_REMOVE_CPU 0 diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 256cf6db573c..0ff06d0698ad 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -9,6 +9,7 @@ #include #include #include +#include =20 #include #include @@ -491,3 +492,34 @@ static int __init crash_save_vmcoreinfo_init(void) } =20 subsys_initcall(crash_save_vmcoreinfo_init); + +#ifdef CONFIG_CRASH_HOTPLUG +void *map_crash_pages(unsigned long paddr, unsigned long size) +{ + /* + * NOTE: The addresses and sizes passed to this routine have + * already been fully aligned on page boundaries. There is no + * need for massaging the address or size. + */ + void *ptr =3D NULL; + + /* NOTE: requires arch_kexec_[un]protect_crashkres() for write access */ + if (size > 0) { + struct page *page =3D pfn_to_page(paddr >> PAGE_SHIFT); + + ptr =3D kmap(page); + } + + return ptr; +} + +void unmap_crash_pages(void **ptr) +{ + if (ptr) { + if (*ptr) + kunmap(*ptr); + *ptr =3D NULL; + } +} +#endif + --=20 2.27.0 From nobody Sun Jun 28 08:36:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 789E5C433EF for ; Wed, 9 Feb 2022 19:58:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230051AbiBIT6O (ORCPT ); Wed, 9 Feb 2022 14:58:14 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:46136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230016AbiBIT6K (ORCPT ); Wed, 9 Feb 2022 14:58:10 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6133E067871 for ; Wed, 9 Feb 2022 11:58:07 -0800 (PST) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 219HGoli013543; Wed, 9 Feb 2022 19:57:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=4lq10SfzIqDtmItrYsFNHjd/1F+h378qjqN5ixNQsYs=; b=P2/wLfmbixNt0R5VveZ+5Lu0nVXRyKv0xRZtfyyeJxn2Jk3etY8NPFpNOltydXVbMKqG t40QINlbXkea3/mopXVlMJjTkJ6N5SPdwGGYlmBpKdwyPqgDWwzgfcFl8zCHWm1UbDyI CZ7IvWMJ8cV5xypvo8admSG7eEWBcRPIguA9KZbBjUUc2OPuDAmoE2SjKO4fhuQ8VltB T59/dyupHB2If469LJRjAgxAYrCvfBAv9yNjGJhQ5jGEOTTAk6Baa58ElN6OAYNR27GD NWrw9XPhYt1VOZ/p5+8M4vB1/4USuqRikXlJ5iAfTa+0VngXBI5EbQUdpsANkHRIIlIS wA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3e345sqkg6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:36 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 219JtbFB130738; Wed, 9 Feb 2022 19:57:35 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2104.outbound.protection.outlook.com [104.47.58.104]) by aserp3020.oracle.com with ESMTP id 3e1h28vx63-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pl9OA9+uPV5j1Dfw2CcXSFs6q39LaEXBTrWkNrwQiUVuu0HkuUNl9f2UZrs8LtBsjpCvRpkbB/zLaoEzsub/u1er3t/X3MY6+NG8NuNfJ6w2tYEczaSihFICoP16RiKewzqA6V0hHWIuXOQYTZufdVKguwsgYZ0MqBGZ12q/+UoxwsGAh3jsGJIhdBCN+IWcKXjzde4ghQLw2FvJS3gM9xKDJB1di66c04XHX8GFwnY9clS8m2+BvbDhRGBVu+vr+nEgqNN7i2Y1N2i4UjALWRuwpmLkyXyI8JfLTw8p07sw1Rcoo6LhO861u83XhSUnBOkXoUNkcdRENnUe/I4dvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4lq10SfzIqDtmItrYsFNHjd/1F+h378qjqN5ixNQsYs=; b=NmCZtUVmvDCm7xg6843DGRfj6x2H77OcRZ+LOEHNpih31sAyYPWbWLJ+XjMBahYEaJgdFQkWL7nmDApR9GYDmNOe9yTLnRwXp4Off7ojc4xpn1NyStT8YjZkmlc8P81E7X8fNZPA8qX/xSb4CdmsvSbO+FYctS6Il/h+glchuwer04nsSmFVSKv5uHvkZcCYk93I82Qf6ZbtRs7FQSQIQnjzQZGRgoqsRo4rJ6exZFxSRP8edqgf0RRaHf8s/Zm4Qz/krCToXzf61FDOh2KTMjUoICwaLksjqaZncZ+1roWjn4V6IF+4reiiWNkHrR6AZJG14caE2DMRJy3DIKmsMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4lq10SfzIqDtmItrYsFNHjd/1F+h378qjqN5ixNQsYs=; b=BpBxvyeNAg0Ue6tulE9Vq5FSSkEJjdu8BAEoMFMsx03tQXbusy0sBRhBKD4NYz/4X09++WCxup3opzBIKiB5qMvhEvtvzrXpSBrXSTar1/ehCO4bh0+Rb9bVp3LQpUZlx0KX+jERe4F6p83OcizhnUrVM8W4+P299PR+B2+X6aY= Received: from CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) by MW4PR10MB5701.namprd10.prod.outlook.com (2603:10b6:303:18b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 19:57:33 +0000 Received: from CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c]) by CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c%5]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 19:57:33 +0000 From: Eric DeVolder To: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, eric.devolder@oracle.com Subject: [PATCH v4 06/10] crash hp: generic crash hotplug support infrastructure Date: Wed, 9 Feb 2022 14:57:02 -0500 Message-Id: <20220209195706.51522-7-eric.devolder@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220209195706.51522-1-eric.devolder@oracle.com> References: <20220209195706.51522-1-eric.devolder@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR05CA0046.namprd05.prod.outlook.com (2603:10b6:5:335::15) To CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 51a313be-3b9c-4dde-da4a-08d9ec066996 X-MS-TrafficTypeDiagnostic: MW4PR10MB5701:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FmxqSx7QBc0tS70AAXTBU65VmlEPvHiyeghUb0mXrAHWbdSpqMdlxPo796t49G3oUGOOIrm7srywe7m1ThS1S9zBhEufrc+pgRFKkRQALWWdgFaN+PNCSoTr3MslD6KTN6P+mMkTwZKUvtiZSRRwTeTNwjQFnrm0W4GBUxyVa1iR0chw3RzIfQG1lA4r/tx4OAye68NJe8eehGVDD6Ta1RG9TlndH7Iev6syMy35PyJhREsfOVeSOg7gzcX5fyyyzlwcF41A+qcAPQn+INy686v5KblEF+KT2pU3Nsm2m0iHMO2/RIjsJTC9Vh6TWzxPtA4MuVJQ/m0r8eey8xRk0JypyjDAeQQnyreN5UYBfoXCwZEVpTfT6P07VEzNd3btTnlLrnEvagq0/9Rq5no8Htv6gTsU/OlyS1ifGzbZPV926jzNmDglA+g0Jo02CJe1SCcSl61rxlIqJinaKVIxS1jLyCBXEsIVapG1d1j4vjFTi4SY+XA8eCK40S+2zyM0r2ln65SNkTaPlh+YsVdpL+Mq88EVVx2WrrJaYeAWQRBj4ewoDoI1CxOOENPmBsr7mieuOdqvwcAA4BsB7EaJ8zV87MWZfNoeI2p/miXbyc+p+7oIgh7O6Yn8MNVyY/S255m39bYdsw3x45EucT8/CyJt9GzI/qOE7eC/I99tcLzDZIjKURE00b5aOlQ5+tTefqeUdMbX2vRU2/LlpsQtfZtfUUHUlSsw64NqGPytBXg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4531.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(83380400001)(7416002)(5660300002)(1076003)(26005)(107886003)(2616005)(186003)(38100700002)(2906002)(38350700002)(8676002)(86362001)(316002)(6486002)(508600001)(6666004)(6512007)(52116002)(6506007)(8936002)(4326008)(66946007)(66556008)(66476007)(41533002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4jeiffAFVrH4x/tHm7Oe8vFDHNnYBVWXRXkNMoikBLnn4aaqZnc6VLsT11No?= =?us-ascii?Q?9/b96RHjvMsKDLZaJr7sZRtxHd49oiO7UpcrYWBqiwG9Nmf6Fp5vLwnWVfCD?= =?us-ascii?Q?cy1JKkbXDzCTi9fKrrppst+XMyjPQyq8t8md6ex1lYqsjEOfphRiMdj9iG9A?= =?us-ascii?Q?g4fOk66eoBtU0qKnjhQ4ag7tIX3hAi4sQ2KzLVdSElmI27VEazBbzbuzZVC6?= =?us-ascii?Q?Sl5h7GrmoNaAf/X9HgLUfAumYGg6ZxGvwM1rHFFt4C3gtM/2cdGVwv7l9nfq?= =?us-ascii?Q?LT2CbbIeGm3/wWlck5yo8YiVTKsapvN5fYiV4SFhHE1dLMabZGs0Gakk8EGi?= =?us-ascii?Q?jZVC2ap5tUXMvxUsWoRItdzG85fC2MdBCP8IIYSMoYLz3oK7JKvMtwOsdZfd?= =?us-ascii?Q?YZksLOeFEL5+/+rG3lmhbtnyxAwHFWOWCD6UN+ox3z5E34wOQAnqEvms/9Oo?= =?us-ascii?Q?qQekjkG5lzZAYnlmoLpIFaWXtGU/pcxZN4q1gJMHJVbRky4ACVg4tSeO3Jpz?= =?us-ascii?Q?CDEVPys3aNOxfePtoI2PX0szNAvB3UkRRtRVXUfHEZm5DF4Q13bqTRxNdiFq?= =?us-ascii?Q?HCjtmB+XxSGvTlcheRqEBuVm8RhLZ2XlidzzJVWJcAtVgvtSBOzDs+eaw6mJ?= =?us-ascii?Q?WCMSaH9YX/BJwdQj2x3+g46SsJn/ZeQMCbGKxhOxpjgShrjl/zqHlQQN/zOH?= =?us-ascii?Q?3b7vS4a9R02UQcSced3xlmaz+o+mJwDHFEtQRf+rbbI6hMD75mCa264OPsyZ?= =?us-ascii?Q?3TtgS4eRNKA/3sbHfPAHasJJC6tnIJnVkCl6s/xsVJtcYrmAE/4ZaKd8A32J?= =?us-ascii?Q?LN0hjEYGmfPjcQ8Bxegw4IbcRrY/bWVtRKCRhBZ0r1P35ESsu8Yv+TAbkg04?= =?us-ascii?Q?W5kEswq4WQO6rtdbuk0Aj7oEnOJHBfjxtuc8ZbI/wNM8a+1prd+WKhyFTAa2?= =?us-ascii?Q?nLCEWgBggi878+y1GBAthrX+ULQ8N+s016uiXBKorvdxbILofSYOeOp5Mgnl?= =?us-ascii?Q?OJt+UobvOUN9Z7rtB2ictT6lRrpUWiRrl/BPW6YlrfXRKWeElbHwAL16fGkK?= =?us-ascii?Q?63SEjIeVsj0B83lN3UfMsMGlq9x1CDSaYFaEAhaucjv3+Czv19CbTycn0S2F?= =?us-ascii?Q?vDevNerr4w4sIOpnA4/M+y3/K8OJdUl72qmSgT3oJdSyqKwLM05zdjpheZOb?= =?us-ascii?Q?U2rRLP80FFUb7wo80OY4VKUhpVWvh0bTmr9lnoEeUuZuH5pJF+Py/Qr4k0oA?= =?us-ascii?Q?FCwcTRD+jqvxMyZj7rNnosnNtPA+ENPyfFwqDpjzjojP1PAUZQLvMU2HCnwt?= =?us-ascii?Q?/0CisALm/L4H35dtUStGnm9SEtkPTsaXlVCJpx0VzPjSty/ghEbmamMre+YJ?= =?us-ascii?Q?1zQSnkeARgwGHf9M0xaII3YVEIg4nANEpvukxtJkFpnSyF9NtnAQ0N3LoKoc?= =?us-ascii?Q?SF/hXZSaA/Zy63pF06aslwnKqLcGwo84v4EEqm4e1vk/qqwrR3yUyEN5ish5?= =?us-ascii?Q?aDQcBPatBlGKwG0zfbXRx6lHEL0jOe5p+RUVMuVgHfw9JTZhZs0ViMIU8NEj?= =?us-ascii?Q?sIUhPoIP3yhNS7xO4DWaMucLMiQZHgW0eVVGzY9yQwFcdgpadt8spgSicaSP?= =?us-ascii?Q?Xyif4JeKbr09TqtaLikBUZiLE43arRk30Dx2JomOPUI3PZtj+hyur/I8nmeB?= =?us-ascii?Q?2hF04Q=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51a313be-3b9c-4dde-da4a-08d9ec066996 X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 19:57:33.6494 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OdmNFWItvrSbcdI4xcQdTJ41u6QHdSqyaT9VoGURwWnldoEp4Kmc07Ua2C+lKdPyocj2+1IqTTI8sddFc3ODpLc9UUSU2lR0yujpKuo3fog= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5701 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 bulkscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202090106 X-Proofpoint-GUID: _N15Xgnwhp-MIRT8EA7WkEKZELTpnXhz X-Proofpoint-ORIG-GUID: _N15Xgnwhp-MIRT8EA7WkEKZELTpnXhz Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch introduces a generic crash hot plug/unplug infrastructure for CPU and memory changes. Upon CPU and memory changes, a generic crash_hotplug_handler() obtains the appropriate lock, does some important house keeping and then dispatches the hot plug/unplug event to the architecture specific arch_crash_hotplug_handler(), and when that handler returns, the lock is released. This patch modifies crash_core.c to implement a subsys_initcall() function that installs handlers for hot plug/unplug events. If CPU hotplug is enabled, then cpuhp_setup_state() is invoked to register a handler for CPU changes. Similarly, if memory hotplug is enabled, then register_memory_notifier() is invoked to install a handler for memory changes. These handlers in turn invoke the common generic handler crash_hotplug_handler(). On the CPU side, cpuhp_setup_state_nocalls() is invoked with parameter CPUHP_AP_ONLINE_DYN. While this works, when a CPU is being unplugged, the CPU still shows up in foreach_present_cpu() during the regeneration of the new CPU list, thus the need to explicitly check and exclude the soon-to-be offlined CPU in crash_prepare_elf64_headers(). On the memory side, each un/plugged memory block passes through the handler. For example, if a 1GiB DIMM is hotplugged, that generate 8 memory events, one for each 128MiB memblock. Signed-off-by: Eric DeVolder --- kernel/crash_core.c | 104 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 104 insertions(+) diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 0ff06d0698ad..524470e18883 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -10,12 +10,16 @@ #include #include #include +#include +#include =20 #include #include =20 #include =20 +#include "kexec_internal.h" + /* vmcoreinfo stuff */ unsigned char *vmcoreinfo_data; size_t vmcoreinfo_size; @@ -521,5 +525,105 @@ void unmap_crash_pages(void **ptr) *ptr =3D NULL; } } + +void __weak arch_crash_hotplug_handler(struct kimage *image, + unsigned int hp_action, unsigned long a, unsigned long b) +{ + pr_warn("crash hp: %s not implemented", __func__); +} + +static void crash_hotplug_handler(unsigned int hp_action, + unsigned long a, unsigned long b) +{ + /* Obtain lock while changing crash information */ + if (!mutex_trylock(&kexec_mutex)) + return; + + /* Check kdump is loaded */ + if (kexec_crash_image) { + pr_debug("crash hp: hp_action %u, a %lu, b %lu", hp_action, + a, b); + + /* Needed in order for the segments to be updated */ + arch_kexec_unprotect_crashkres(); + + /* Flag to differentiate between normal load and hotplug */ + kexec_crash_image->hotplug_event =3D true; + + /* Now invoke arch-specific update handler */ + arch_crash_hotplug_handler(kexec_crash_image, hp_action, a, b); + + /* No longer handling a hotplug event */ + kexec_crash_image->hotplug_event =3D false; + + /* Change back to read-only */ + arch_kexec_protect_crashkres(); + } + + /* Release lock now that update complete */ + mutex_unlock(&kexec_mutex); +} + +#if defined(CONFIG_MEMORY_HOTPLUG) +static int crash_memhp_notifier(struct notifier_block *nb, + unsigned long val, void *v) +{ + struct memory_notify *mhp =3D v; + unsigned long start, end; + + start =3D mhp->start_pfn << PAGE_SHIFT; + end =3D ((mhp->start_pfn + mhp->nr_pages) << PAGE_SHIFT) - 1; + + switch (val) { + case MEM_ONLINE: + crash_hotplug_handler(KEXEC_CRASH_HP_ADD_MEMORY, + start, end-start); + break; + + case MEM_OFFLINE: + crash_hotplug_handler(KEXEC_CRASH_HP_REMOVE_MEMORY, + start, end-start); + break; + } + return NOTIFY_OK; +} + +static struct notifier_block crash_memhp_nb =3D { + .notifier_call =3D crash_memhp_notifier, + .priority =3D 0 +}; #endif =20 +#if defined(CONFIG_HOTPLUG_CPU) +static int crash_cpuhp_online(unsigned int cpu) +{ + crash_hotplug_handler(KEXEC_CRASH_HP_ADD_CPU, cpu, 0); + return 0; +} + +static int crash_cpuhp_offline(unsigned int cpu) +{ + crash_hotplug_handler(KEXEC_CRASH_HP_REMOVE_CPU, cpu, 0); + return 0; +} +#endif + +static int __init crash_hotplug_init(void) +{ + int result =3D 0; + +#if defined(CONFIG_MEMORY_HOTPLUG) + register_memory_notifier(&crash_memhp_nb); +#endif + +#if defined(CONFIG_HOTPLUG_CPU) + result =3D cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN, + "crash/cpuhp", + crash_cpuhp_online, crash_cpuhp_offline); +#endif + + return result; +} + +subsys_initcall(crash_hotplug_init); +#endif /* CONFIG_CRASH_HOTPLUG */ --=20 2.27.0 From nobody Sun Jun 28 08:36:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA15EC433EF for ; Wed, 9 Feb 2022 19:59:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230312AbiBIT7w (ORCPT ); Wed, 9 Feb 2022 14:59:52 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:53516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230118AbiBIT7e (ORCPT ); Wed, 9 Feb 2022 14:59:34 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9EECE06C412 for ; Wed, 9 Feb 2022 11:59:26 -0800 (PST) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 219HAbE1027666; Wed, 9 Feb 2022 19:57:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=j0oWpMhrVtFGnGj0GqWGztVHMmb4qcECw6VUMycpGKI=; b=0PRwB2aeB39K5QSYTh213Xcp7F9mXk3ZJATETtGZOZ05yVn6e3mppss0oDPcUEOOPgpn L1CNSNPRA5VHsMPI1Lj3/ADSkNvrYRu7+YA1DL4aabGArTCtZlZ+dOm3SWXDAJKFijt/ Lu320Pa6E3lFH5v9KDDxKrxQgShAM3wZvS+bOXg7JUQEl6fx68xp9Xl2OkcoGkdnOSps la/mAjCQaL5D8wfSX8PTo4X+V6Fwc7uYr36dQDWXEvP47etSnX2UaHamITpi4Z/FX/3T N1LUY+AW34hawQfNjKtuMsC2GOeMSFLkP5Aaf0ARqtmdDpj+v847wXQad1RgD5Byn3Ra hw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3e3hdswn35-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:41 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 219JtqrW046251; Wed, 9 Feb 2022 19:57:40 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2108.outbound.protection.outlook.com [104.47.58.108]) by userp3030.oracle.com with ESMTP id 3e1ec3b0ku-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VBBEL/llaCZ0t62ylMzYgQY/A5AaqrWkFma+wQZgVLK6WktbHXbpeEGTQixu5ksd8XCoFk6o0EhD85orSD7UCGqHs+htztGhcASwAzAZde4vKSrqKasWfG48e1tJ1qgV+uGjKmlBdHzYbrDbwekUDgdxt/BgaBZydFoFPwu8JtmDCSonRdL8/sMqjK5gILrNZ5PtTNYPj9z5Ujavl5AuEtmpn2K/UAliFcgm08jitZRZYBATuoH6HbyiwJG4UfSSD8nG16CdAayt6lckNIyBwo1KLR4rK2sl4bRy02hM996K5g0aqQQrZvJQhf4qE1cNYAN6UOrrIJ653/Xz/BYbDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j0oWpMhrVtFGnGj0GqWGztVHMmb4qcECw6VUMycpGKI=; b=cXKr2jVX9Mlq9+AkoWBqHerMgor1I4vn9Q3bf+UnPshUBv74Qqyog+raIzEu7VAhpA1YzISO1orB/Elm8Rd9JHoPgd0By3AJHLlw6ii1hpDkBcLtcgA5Nx396sKxrC8BypQ+ldYzQCBKQkZOrajHV/1NW5SR0hmyDFl2FcogQJ5IW0NGAlnl8oRsWpbQSQ0KQukH2iRsPnqo87sZYtrUi3JQTxs8rBolK2A1CP8OjqxgthbUSpBy6rQdDLHjbmOn/3l65gJVxfxpglOhgXNEtm8mn9QDGWvhAmeLsmmC+p0vUw46bfxkmJpIMEWINHSnEHHIFIjSx8JNKzKN+jKeKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j0oWpMhrVtFGnGj0GqWGztVHMmb4qcECw6VUMycpGKI=; b=HD/BzDxiTi1SGQL/kUNjoZMszVHiFCSN8CeVM3l3W9Zuqxj6HhfvgLr2ZlgC9EqJ2u1rFEqXwhrn7b2MyYk3+wZGY5kW7TCT6VRjaGUGZpWMe2CLPjBwz1ncAsH04XKyetNffIzg9Gv5w/NB231XDPKEMM9Ssqi8kK+AhC/y5Bs= Received: from CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) by MW4PR10MB5701.namprd10.prod.outlook.com (2603:10b6:303:18b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 19:57:36 +0000 Received: from CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c]) by CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c%5]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 19:57:36 +0000 From: Eric DeVolder To: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, eric.devolder@oracle.com Subject: [PATCH v4 07/10] crash hp: exclude elfcorehdr from the segment digest Date: Wed, 9 Feb 2022 14:57:03 -0500 Message-Id: <20220209195706.51522-8-eric.devolder@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220209195706.51522-1-eric.devolder@oracle.com> References: <20220209195706.51522-1-eric.devolder@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR05CA0046.namprd05.prod.outlook.com (2603:10b6:5:335::15) To CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d7775026-4561-4885-8d63-08d9ec066b01 X-MS-TrafficTypeDiagnostic: MW4PR10MB5701:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l23Opjep0BH4DUoBbQw8O4G0ZoKa6ciECvY2UYRTApvb9EK0TnKmShnln7hEQf6+Xh7Acw3gvHCBYDgcm/C2sQT1JYjpESmx2g+4rdEaHzMjmnyPLJ1q6tI/pJBGaVoX0fgI2Q/m9rpIGMQdbkOew45iGtuP9AUYjmax9K7wE1HNqlvJwccqxijPRO4LMx2sLCsB1qcL8uK0yOaGKlF5bZPvuK3JTkf7oytrkXLfAfJBgusOK4ZArMYpEHWfkvlqgA3E3fxYlKUJVStlATwxRpCN53wVvhhLLEH19i/kvOWUTQPlAlT3aaKFbFSeYme5eLRDjjvE4lZR7Ib1YUnBQ41uE+KZ3BmMnRJ3sDsxiNIj8ydczi7ozYiMwNg0Xyied9JpoJfZtcglU8SlBE002eYi60MoeDzYAQbDWBBIoDBM0WPhwSjE4D92+t71rlRyPQFl4M26TBwkIaDwK9mgZ3d1WOlTrg4uAOpHOFTAZaWV3gtnNQnTJa4EhIkCEIAOa4pTqFvc8QJYYlsuCKzmQayoFJlFU8lshvzL3gmM62eLm6AKriZBcWNpICpesiuWWJXRj2kd7CoRw1Uh3vify0ZIX2MGGDM1bBtN9H6jWvXkASDHKWVy+y7zmZWVZJwE9OJl9k135hH8e8SdDk1Y8JM2nSV9M5IeOYNuj71lIY/OflSM7GHJYi3+kwQ/Yt7gp/O/c0rBjtCvqx1sCTurRA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4531.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(7416002)(5660300002)(1076003)(26005)(107886003)(2616005)(186003)(38100700002)(2906002)(38350700002)(8676002)(86362001)(316002)(6486002)(508600001)(6666004)(6512007)(52116002)(6506007)(8936002)(4326008)(66946007)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8FU3cwS7cND82R/3Iduio1YGGOiVOc+fJeokujEHFrKRu3ZaAa+JGi6jBLET?= =?us-ascii?Q?1jPbW77+d77aSJ+BgyrZ+uNPob7vDW2gjGVLWKhAbAI0EVadngLyA8TvS9iv?= =?us-ascii?Q?PB4sym3gsoioDGbcpxVFGCMffqTIXctkKMQblr0aoWK+nT9gyzadaUhIQwe+?= =?us-ascii?Q?zTSAfeT2kzeI1jgqmIlYlfFlf5BcGY9G3JYYSx2JMzrR1SnMbs1IwW04URLL?= =?us-ascii?Q?PhUxWzoCC864Sej2xB7NHeOAXcZ/CqkR0qkYb2xYYqyMcUnjSvBGBsUTP7P5?= =?us-ascii?Q?bQhBoTGTB9FgpQPurb5YXmFS42LWc8wAz/jtzn0bqRhzeIt2dX8Q7/gR31Qy?= =?us-ascii?Q?OTlJgWOa5gisrAYwAU1HJl7AoW5QOERVpA94N99PwgYKFPLOZHh0QQ5+sOIF?= =?us-ascii?Q?Ln0Xa8aFfgWH2oMeDDgbdtQgj3LiVkB3G0IIIPBnUZO2VuYI4kArJBP1cOXF?= =?us-ascii?Q?s0Dc6o1CXU2fZpNljaIm1HYPHXbkyNZBEk/3J8OXz66jj1FlF6WCBVE/vS2G?= =?us-ascii?Q?ngOOqkVa63v7vJfMw2GZjbE+5bPRTZps8erC9jU3qbxfKzXpJhWV47hEfmez?= =?us-ascii?Q?s7L+xIsSNfPHqhk0S+FbrtVQJkRqvryUXDuWPbygghmjx9EUN/jYU6MoUJrM?= =?us-ascii?Q?MuN9z2yYgAeZcN2VPv7menGhQDhTX3Qb1AbBeU2YEKsgKwOlQQQ+i9Utr4Hy?= =?us-ascii?Q?4YDGZUHuE+6OUCVWtT/gJi1/QNQAqHTEjOIUJaGBAepAxTcKRfpkkxzlByKj?= =?us-ascii?Q?XPMF3lQNM9Q5InZYkfCCRBUgQeFNHxSzARw+umEUt1ABKyqw4FqKZdaP2s6I?= =?us-ascii?Q?Wg9fM7gAMXBbX8qrhaicPcflfCaXUSPFv1la3L+IsgFsZjgbpbZeB5loNfd+?= =?us-ascii?Q?QT3y9+v/V196KhNbCzyFVBfNPPoOqIyRPmiklDWBN6qR+VLZXP6jfgK7pGQJ?= =?us-ascii?Q?8UcDR0GWJbGPEJ8DKUIYBAwP8djmlO6E7URoXVHzm+tBK4+Llfs41qFwOjoX?= =?us-ascii?Q?FcpPGDOS/qzlti7sR63WJhKMOP3vyLkCiiJDA/FIU5LyGvKT29iJdSrmI2tu?= =?us-ascii?Q?waCEWfMlYdPmf06fXPN3TRQ9dXPnYMHmw1MoGPuPxkLGVRPqtnzG5mJeGYs+?= =?us-ascii?Q?vCAGZeMG34Hsk9NnH202ZKLQRGGVQUxb9TYoZG9eKvdtAvbrjvZUQZ7Jacw8?= =?us-ascii?Q?ZenxT5hi66lo2WpKPp7Rl8VCZFCFbanavfuTiY2F+nZG6YmgxPCV4VlbQ3BL?= =?us-ascii?Q?7bHqyHRo+6holP2cWBl+mrWVLZPdK6eVlsdXFLH77e/4xD8QyBKzeh6iZJ+C?= =?us-ascii?Q?t8E63HBKZtYtWEVJUv3Mv0Aumto1KoJuuwYhdD/yfe7dtAF3YGQ2S9RsOFjx?= =?us-ascii?Q?aiVI8M3qr7SErSz9L9kdBewFMkIbd8UsDD+oAhrBb8/n9LdtPHf4UiCsxzFq?= =?us-ascii?Q?YUSZBPOjNQnzU011KkqnY/Be/MtMmOtJVZD/mEbWLlX/UAQmsvGQLwW4/YJ6?= =?us-ascii?Q?oAzLri0ITJvl3gsHuqOqBEygY3UV0dzIlPP3noCxUW35NhNNX012yiORhMGI?= =?us-ascii?Q?0B0tTCTMv1GOz2Q7W43HZUWrmaipUKj4saeuBCz7sVXS24sy6KXwvMW5mtFo?= =?us-ascii?Q?r6epQe0hWRwWOngsxAnegqaPzToLrMjmyH60wYp9TyrPbqfW3WR2vmdO+Y9b?= =?us-ascii?Q?hlSw8A=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7775026-4561-4885-8d63-08d9ec066b01 X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 19:57:36.0108 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3Di9Mjy3eKHHwvuGinuyYw6RmLALWWdYXrdLKZD0gjQpBzh4InV/cno/xLDBXpehl5q79nYCcyqeZmicfXRLEcjvp2pSOZ7BrGlG9JuYmPE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5701 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202090106 X-Proofpoint-GUID: qj4BcoWoCvivL2DepstKwDiAoevd_BNY X-Proofpoint-ORIG-GUID: qj4BcoWoCvivL2DepstKwDiAoevd_BNY Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" When a crash kernel is loaded via the kexec_file_load syscall, the kernel places the various segments (ie crash kernel, crash initrd, boot_params, elfcorehdr, purgatory, etc) in memory. For those architectures that utilize purgatory, a hash digest of the segments is calculated for integrity checking. This digest is embedded into the purgatory image prior to placing purgatory in memory. Since hotplug events cause changes to the elfcorehdr, purgatory integrity checking fails (at crash time, and no kdump created). As a result, this change explicitly excludes the elfcorehdr segment from the list of segments used to create the digest. By doing so, this permits changes to the elfcorehdr in response to hotplug events, without having to also reload purgatory due to the change to the digest. Signed-off-by: Eric DeVolder Acked-by: Baoquan He --- kernel/kexec_file.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c index 801d0d0a5012..93bb0c0ce66c 100644 --- a/kernel/kexec_file.c +++ b/kernel/kexec_file.c @@ -765,6 +765,12 @@ static int kexec_calculate_store_digests(struct kimage= *image) for (j =3D i =3D 0; i < image->nr_segments; i++) { struct kexec_segment *ksegment; =20 +#ifdef CONFIG_CRASH_HOTPLUG + /* This segment excluded to allow future changes via hotplug */ + if (image->elf_index_valid && (j =3D=3D image->elf_index)) + continue; +#endif + ksegment =3D &image->segment[i]; /* * Skip purgatory as it will be modified once we put digest --=20 2.27.0 From nobody Sun Jun 28 08:36:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E04C433EF for ; Wed, 9 Feb 2022 19:59:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230377AbiBIT7o (ORCPT ); Wed, 9 Feb 2022 14:59:44 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:53568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230282AbiBIT7e (ORCPT ); Wed, 9 Feb 2022 14:59:34 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B3FCE04AAFD for ; Wed, 9 Feb 2022 11:59:27 -0800 (PST) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 219HL8uh013515; Wed, 9 Feb 2022 19:57:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=2Udk0cxklejMoIZNmK3NUQ3ADxvjgbDaJaMdjq9Qq/o=; b=RPMPldQWGZ3ePjahH1KuV4Fv2WyyJl7Iz2HGvZYYdk4berA78slIOnAz1061X+Q1lUlc 3cTe1loTtZtGdkAfct5jLCX3JtYuhKFKTKb2MEK+W+t9kqA7JgqGG55+Hey0Zd4vRG2b SRXIlukCxc5d/QUJ5ia/s9hdyZ6O2spjM5TeDfh2sT7SqeKKNvqV3JGKtvRaldcndPQ8 8jW00nhfVSpuOvH60i97A1Fu8qFkB2HGfgKFTbtT44mPEsUmqtEUw5rXakqIh9Jer2jM si8av4TBOKKqHHJPvQbhON8hGvip49NAuuBoRlEbP+wGZuW41jN/9iYoCG5mD4S6dUKY pg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3e345sqkgh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:42 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 219JtqrX046251; Wed, 9 Feb 2022 19:57:41 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2108.outbound.protection.outlook.com [104.47.58.108]) by userp3030.oracle.com with ESMTP id 3e1ec3b0ku-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GVGtgVOAfgoJvFRgDwiQo2FvX9W424BJjZeeNSTDzbS8QNzX0MuTlxmcpQQWNU8LEg3dMCskhvXcEHT6vv384/WLWuBNakhTJBCc/yeBdK+KgH6HfiqCp9VMz5D1jPJNY81bhnOuz0pBUnY4nq9j9K1XyctccavvWIECtwAZqtQsIeey4PlzySoNByPF31y1W1xZNbdXR+KDJONyP/+Qm0Ogph9HhFusUrGs41KynNkYvlk0PlowRQwBX8eMfWt87NdlyBQXnWojsF8zqj39E7jbYN6DKEyXxv2FuQDFn1RdyZxBguQPAgUgX2AvLkNhYPCG5zuTpUKI92xHsSBH2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Udk0cxklejMoIZNmK3NUQ3ADxvjgbDaJaMdjq9Qq/o=; b=mqExqE6Fet9QN/9J4KI47TiR+eQ+a3kReki/6pS3rQIeTrAFVz1IflDf2mUTb6sXNtdghJ287sWtMJWjPJPS5HFUMa2Oamyw+fyU9oILBb5BH3t4NW/r6uI5ggD/xY/QfSAdmAiVRZhyf8CmsFl7Tm2Meu8B//PzcYZ9PP+BFtk1EENRI95B4Q5lV9ulAScrBH0xdh4YeAakf0V3MXW6Cu38xm1MJaQpOxf+NKnwVWQOPcPKyDOgFRvq2hf2DzYC8k6cqET1YDTG71O+VvwHoEDDLM9K7vXNVQ4kGaqGKnaJIHnKq6Q4YybM/+wnIK7ATY7jnjlkQeheLw7xtUPYYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Udk0cxklejMoIZNmK3NUQ3ADxvjgbDaJaMdjq9Qq/o=; b=MI1F7ZTmUS4p9iPwt1z59lGM4MIW3S2zog0bkSy1rwcStbDlop/OTpUDTGj3f0snqr+bVLNq1BjYlBqlIrqh8fD5rBjl1FkJXqlmstN9q9XA4pltozMNibUqfU4Xlla6HJ5emsYHk6A+Imf+OAPACQZb6OQLd5xDSJJXYRXX6nM= Received: from CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) by MW4PR10MB5701.namprd10.prod.outlook.com (2603:10b6:303:18b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 19:57:39 +0000 Received: from CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c]) by CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c%5]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 19:57:39 +0000 From: Eric DeVolder To: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, eric.devolder@oracle.com Subject: [PATCH v4 08/10] crash hp: exclude hot remove cpu from elfcorehdr notes Date: Wed, 9 Feb 2022 14:57:04 -0500 Message-Id: <20220209195706.51522-9-eric.devolder@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220209195706.51522-1-eric.devolder@oracle.com> References: <20220209195706.51522-1-eric.devolder@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR05CA0046.namprd05.prod.outlook.com (2603:10b6:5:335::15) To CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b8b46b2a-fd5b-4d97-6361-08d9ec066c5b X-MS-TrafficTypeDiagnostic: MW4PR10MB5701:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ldo5O4zRQiB39RqCGIwxHk4rwaX4P2GGeHrUtIKg1mkiwdTAPK1tXf319WjoXgZk3Q8B5s3cwwPb/nmC6H2UZrW58KKwVtUNmvuhsxae0F2AFMH3CkxWR4Jd+or2+VgJyfcI716irnwVpaStc1+iu36MRqIzNjF++eICBJiwL1i88reL8sSWx/7JakTn8YqIjJe/S9lfUyVdPj4WEvVFp97RfX0FId0VDnbc3yXNj+5U8oZJ+3To1ynelr00+3tfM59Cn+cO46HfFC/t9dP/nLlcr5lGPIms6vtKuFg7rzX61ecQhLZIzgw4hOlB3WTg/jJrM0qN2MdFmiLDiOdivsmkBJiwltHpKOowadLJjYEAZfrz17k8l8tMVyODY9K0EFxPULLwBdq1cyxZ7FxSdFa/RX2uZcMWOYqFgoGTxwkvMSo3H2ler9gVqTEzk1pE8VGerzx9azBA13LdQtGN9U4x9+YxAJWuDPGGc59O/+rfos7khim8cEHKNiTwZ+lufdr+i1WxUkBeRMuNcrIwvB2LO2PbyvWKZ3YJWVy3CRaQXzlO7XXsTtx4BwfOWDRwLGOww/ELW9VHLM5LyhH7Ektq8xwJaHx/JBa2yRCTl+rQochFMwWN6fcrFKw15822pXDW7FtlUSOYSJoDoL7YmBYeJlwXRB8GwU32DOlW0d3QL9sGhaAgRnXvVDARysYT8puOdD6eA4CIfzmfqgy5/g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4531.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(83380400001)(7416002)(5660300002)(1076003)(26005)(107886003)(2616005)(186003)(38100700002)(2906002)(38350700002)(8676002)(86362001)(316002)(6486002)(508600001)(6666004)(6512007)(52116002)(6506007)(8936002)(4326008)(66946007)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6KYyXj230yqRCMnssrKn3Twdy0JqNceuNPuHcZJRcg/+zj/m7dUt8yrhxhqq?= =?us-ascii?Q?kOqEFwPYWw+rJEXCa4Ni6YgasSbj8dvdQMKhcUYvTeXs9UJ4FT6/lG3hzfbR?= =?us-ascii?Q?IKKTcudMTd3orQqR8nkhr0j6ESNBa7SiYKNMVtwHSw3tiNDByCe7535cDNDW?= =?us-ascii?Q?TSDPoTsTqxJ8GoE562QQabaCuAgopVUmIN7Y0EIkYCTXCrOANap/3ujqLg/m?= =?us-ascii?Q?OnjgaAuhS1TUGpkfvQFtVKEGseEmJZ9VFqjvYyfmaWBIdTB1bUpXraGvqRRe?= =?us-ascii?Q?XnCdNgToa8k7rTR+shPhw4oHq3OvpGdznYPTJ/7cybJsUqLjCQfWztWbMjiZ?= =?us-ascii?Q?oBCQ2LG3UmggutKSFLAWKQ52anVH3pfSugIG2NYQEdR1QsjbDrhmwPrK8YTu?= =?us-ascii?Q?poOgwFO2c6qTQ3OF5vkHFIIrfryITulkHxwnc0pJ4KZlB5CzBTvSAdgvnHqC?= =?us-ascii?Q?vYBcvYhN+ih+QROFKzPMvlZOUUhwBbItoWBxJv+6caFC9zqWeSwXCN1dVrSc?= =?us-ascii?Q?D7SFO2rVWw/8xviHJym2zZujOabBZvbyor0VRhzYTvrk+HazVR0kP11mmSzV?= =?us-ascii?Q?iSMnAApId8EM3JbQwxNsX5nthdPREG8Zd324s5nZbvbBMsrXSlK3bKqr/Zkj?= =?us-ascii?Q?RizYq+EG2XHCYGuc67/6FfqNWYJuSqzR54/H+t0IGDML8YtsbG3dGdlnDRG9?= =?us-ascii?Q?JWs5BGEay40ONy/pJzKveOJcBqiyL/gjyFCQYrD+4SXnL5QHsekgiGzJ7+1D?= =?us-ascii?Q?5Pi2C1JWZC/iFISOPWfLAUc2W/FkLqUFB/MvhkhrhlQjLJznLZx2RBjiGjF6?= =?us-ascii?Q?1WbsuRhxHv5r9zbqinyBfPvBOOhxm0bjV+oz7gdSWjJukblgO2fAphRt27Ex?= =?us-ascii?Q?Y/o4hq9l89LUc9EXwGd5L8PARm/H/VUJnXogmau47dDnvX5cbmRPPLSc++44?= =?us-ascii?Q?Kz/ttYPZB1Xativ43sygnMH0OScxkJ3llTwMwjDX/QJpkqOrYWos+snjvkCK?= =?us-ascii?Q?aZ+a5cIERgQZS9I843T6N8s6gBtyLbxTKmqWtZBqAZcRd6v8VVZ9eBmLkJmE?= =?us-ascii?Q?7m1tdCSXN7D3Ixu8IXPNrNAIVs3HUdT5tkhRI25UvWxz3DJcpZrNXp5JuaAB?= =?us-ascii?Q?kf+amAZYBWtpb+gRs1xhRYPPk736dIhGYQQJnJolCXGS9+/6Y+r9yJkSOGLP?= =?us-ascii?Q?Qb7UIpLvPDOcAsWy6gY1rB4SVq7xImNvEiLAVdl344ZMZYhGejTsYZlKrtAe?= =?us-ascii?Q?LCnKtbQ28SSEqJAzYVOE7ZzUidz20K6E97relBqE71hEjTniVmy1epNs401K?= =?us-ascii?Q?GOt7doeaNfDjsQy3Wk3ZY+PdF/rDP/+2xWK+b+9CjfuGTpidvfy4gzvKEIMz?= =?us-ascii?Q?Qriha7bbqKhfdXW7tEmZMBiUcLe3/HnjpRAb9z4GaY1AJfhLr/dsAIxWFtoh?= =?us-ascii?Q?O0Mh5PvWHKsBucW+vLt60uetu9oXIZmV1/VbalC3WJbQjKqaqBgwtFAh29tV?= =?us-ascii?Q?1m+SZklFG3UKrPPQMBXRqt18nGb1TjKFuFvCDpy9S16UwOWDDcU6V3oHw4Ln?= =?us-ascii?Q?Q1DXMd9jn7DvbjfhUN/ucP95Hr1JLsx7sn/eb4RmWxgl971jnJxGsfE3U8uu?= =?us-ascii?Q?C46zpjedrhPF0cZMo+JZyUJ8fsFYOH+dM4gt65J80JgSPJ/ZRxOhH+dIgXdl?= =?us-ascii?Q?UyOGCw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8b46b2a-fd5b-4d97-6361-08d9ec066c5b X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 19:57:38.3397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TvGw0BX9N0t2HSImwDuFlYfKyDAAzEaJMPu3ql++LHkLa+8Af8Ub/aIB7kCa15SSWy0H+eaERA395btHb7HF33IjYtBVfsWQQUT1JLNjtqc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5701 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202090106 X-Proofpoint-GUID: PdR-rPKa7d-YNBkx2VOW40srg98kJ-Iq X-Proofpoint-ORIG-GUID: PdR-rPKa7d-YNBkx2VOW40srg98kJ-Iq Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Due to use of CPUHP_AP_ONLINE_DYN, upon CPU unplug, the CPU is still in the for_each_present_cpu() list when within the crash_hotplug_handler(). Thus the CPU must be explicitly excluded when building the new list of CPUs. This change identifies in crash_hotplug_handler() the CPU to be excluded, and the check for excluding the CPU in crash_prepare_elf64_headers(). Signed-off-by: Eric DeVolder Acked-by: Baoquan He --- kernel/crash_core.c | 10 ++++++++++ kernel/kexec_file.c | 5 +++++ 2 files changed, 15 insertions(+) diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 524470e18883..b6942e04a188 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -550,6 +550,16 @@ static void crash_hotplug_handler(unsigned int hp_acti= on, /* Flag to differentiate between normal load and hotplug */ kexec_crash_image->hotplug_event =3D true; =20 + /* + * Due to use of CPUHP_AP_ONLINE_DYN, upon unplug and during + * this callback, the CPU is still in the for_each_present_cpu() + * list. Must explicitly look to exclude this CPU when building + * new list. + */ + kexec_crash_image->offlinecpu =3D + (hp_action =3D=3D KEXEC_CRASH_HP_REMOVE_CPU) ? + (unsigned int)a : ~0U; + /* Now invoke arch-specific update handler */ arch_crash_hotplug_handler(kexec_crash_image, hp_action, a, b); =20 diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c index 93bb0c0ce66c..339995d42169 100644 --- a/kernel/kexec_file.c +++ b/kernel/kexec_file.c @@ -1314,6 +1314,11 @@ int crash_prepare_elf64_headers(struct kimage *image= , struct crash_mem *mem, =20 /* Prepare one phdr of type PT_NOTE for each present CPU */ for_each_present_cpu(cpu) { +#ifdef CONFIG_CRASH_HOTPLUG + /* Skip the soon-to-be offlined cpu */ + if (image->hotplug_event && (cpu =3D=3D image->offlinecpu)) + continue; +#endif phdr->p_type =3D PT_NOTE; notes_addr =3D per_cpu_ptr_to_phys(per_cpu_ptr(crash_notes, cpu)); phdr->p_offset =3D phdr->p_paddr =3D notes_addr; --=20 2.27.0 From nobody Sun Jun 28 08:36:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E51C433EF for ; Wed, 9 Feb 2022 20:03:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231199AbiBIUDa (ORCPT ); Wed, 9 Feb 2022 15:03:30 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:44220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230446AbiBIUDU (ORCPT ); Wed, 9 Feb 2022 15:03:20 -0500 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF428E05025F for ; Wed, 9 Feb 2022 12:03:15 -0800 (PST) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 219HFfHp017435; Wed, 9 Feb 2022 19:57:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=QtGKe5zkdDHbOqZfoVX62iXOsdRoZLp5RadEORn0Egc=; b=x/aYUdlfrU9EH7nE8lueOdKZ2uubDaSk5d8NeigbT9nKxQ3QntyseGxlSNJLR6MUbdHG gXxRo+P0AfI6GjjNi7j+E2+ofIixVDdE0DEgfT3kEXzA9d9V5Lua7aY6dD22qut99Bek 86RD5mNP+vBcN5z1wio1kS2uIAUvaleh+/A15wtaNVwne6kYwe9BOSi/CIegtK0NnVuI utvMnZQqOUEMa1B6RE2HzCshIs+Kq2S2pdnvXhVX2NPj0UhDJ7//Oi8UZNY8FqeMGTyA o4y1FAnq+BCYwZx8hepVYrSysn6s+EzV8IGvhtCe1yEiHbIiDyNMnsRlGXH4jbvh4OlD AQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3e3h28nkw8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:43 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 219JtqrY046251; Wed, 9 Feb 2022 19:57:42 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2108.outbound.protection.outlook.com [104.47.58.108]) by userp3030.oracle.com with ESMTP id 3e1ec3b0ku-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=crWzKCDYjWl9oId5A2TS4gNTm998JkfXWWO/AteLSMloC7l3XvhD9qcaxKNZQhE2JLXJ+VhIB1WiCP6kY2y2HFJP0uAD2hEFcaJDXzHtlcLyPIdB+9+RMv0DEOGEj8h4HMavLThk4P1dBZeWKWLcUGHV5oYcaildWRIXvtrmpdxIYU1cJWNm6L+330A0/8M4S67AOitJZ+JcneyQzdnn/F1mhe1yKSsNEk4Xj+4ntU7/XF/9e+er03bV42Hs9NpvvxA8XNwRYS3m1ZD+pFaMkwHVct6NqCTM9QHc3+fxTm9GJkXtZcubzgQr0XOi0LNuVY/GcaKHp8s3NmADm1QvhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QtGKe5zkdDHbOqZfoVX62iXOsdRoZLp5RadEORn0Egc=; b=ddrsjlLKkI7oumLcx6liclBJ9kk3AIo6F9ozsvvg+Clesk2iKgDmhroSAVVjeF5Hn3uyRBA9JqgvWoWA6hyeYo+qx7JKeY9kZ9+1Iupfn/DU4pDPhUtHwlwr4Nd5KOXnihdRGgF90oAaLSGiZ6MbD73J5yR7lUjjfYpX1jtxYVvZ4+9gq7c+pAU+c8YPUELQZ9wmnw//2uBZrLCA/xLbTX/ZtTcpIUcMpBRzx5tdVoaZ1yJ66l4hvowNgcGzYmP6aPBOxoRAtnnhyzcpX5jMedXYXGTsoJy/th3fPvJnddowSjBNGjXWakJ46akXbAv/dFoGQjoy4UX7hnRDl9pSSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QtGKe5zkdDHbOqZfoVX62iXOsdRoZLp5RadEORn0Egc=; b=CvJVWYxZNO6KlrrJRA6x66LfpgIwYo9k7P5mUFn9CFi11mD4AKk3fa7oP+BlD9n82t/HA1Ekc5fIzq/Thb/4tD7Ir3ZWjocMAJznCxqQ1nIesQm1qzeFYxc6xmWQAu/mt5sgGhFt+KFiq3dx3PHlLUsMFiLagyL/c46dUvR1Vqo= Received: from CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) by MW4PR10MB5701.namprd10.prod.outlook.com (2603:10b6:303:18b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 19:57:40 +0000 Received: from CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c]) by CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c%5]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 19:57:40 +0000 From: Eric DeVolder To: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, eric.devolder@oracle.com Subject: [PATCH v4 09/10] crash hp: Add x86 crash hotplug support for kexec_file_load Date: Wed, 9 Feb 2022 14:57:05 -0500 Message-Id: <20220209195706.51522-10-eric.devolder@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220209195706.51522-1-eric.devolder@oracle.com> References: <20220209195706.51522-1-eric.devolder@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR05CA0046.namprd05.prod.outlook.com (2603:10b6:5:335::15) To CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44c4cf31-49d9-40a4-320d-08d9ec066dbc X-MS-TrafficTypeDiagnostic: MW4PR10MB5701:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i+8bHvAGWON8eV05iGttvwYoT5jthylPXWFpnWINWVKenTSRs2s9PP1J1CBW/1fquyGxuz+ClCW++EkoTjQhMouUdPWBAFK/rvv9/y8ahz6LhTMOLDnVxEHdBKrMZm/Jqi6rYtP+eVFiH2jvSeq5NGvhi5nTI6HSrlc6DvpyoAPlmthOiRl0KsXp/qhImv4nRRNtC5AWAe4sRpYJj+kkebdUGG6JX3hIBz4I6aCm51CQiPd9wmpj2C3v+92W/3Cj6ZysvnBJ8YI7rjlvRhOe7eHIj+cvlGGVYE/UgmWtc0m0yNeu6x6d6ugjDPJMmoBoR0Q9nQChV3HXCur7ZFAgBMjCV0FYCn5pI7zltVL/I3KnLYfnlzuazTHUHdD40K/c/LAcbQDfiRyeQansdsrwgysENPVpBovDbG7Vdl+FxaG9AvhQQ3GvzQrV0454bim/OsVGcux1JlDq/KkhDckhuLq4Rq5c0E0zub1tW1Qe4zfVZtOZevcHE4zzJNo0Gygl8mzo6wv9s8PfG6T1CK285Hw8rvIIzxBl0svKUPZWvK28umDwDAURIaFSwEUAgYEUIm/WPnNXc1k3CaqmEdNKLk4o4XdrKlqZHXY0yCaxMvrUmHiqey48kYifffhBfa6ygFuDtIlesf7MnQ1kwFNj/02QBlK4hlo9grYQHM1XehgPaQdX7SXpWv+wUhQqbppAeb7v+Ww63cLa9DieROEXVA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4531.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(83380400001)(7416002)(5660300002)(1076003)(26005)(107886003)(2616005)(186003)(38100700002)(2906002)(38350700002)(8676002)(86362001)(316002)(6486002)(508600001)(6666004)(6512007)(52116002)(6506007)(8936002)(4326008)(66946007)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BOFet9NCVIQVPuEfLT8IWFLAkBamodr7jKy7HVonIo4j42jXfPKCB0mTacX4?= =?us-ascii?Q?DVT74Lu1bXc9YUmFrV9r/LH1gj2xtBeLwPQf3jrRXoMJn6KmjtMV+AiGonYn?= =?us-ascii?Q?ZpNlujNx44i6aSR/GsW4SOtmw27+SwQpQb2IKIe3v87MQBJ7QfOKO4IuDhAE?= =?us-ascii?Q?QJqPAqO1O0m0axDLpG7Gz36iFsucvdU7AJXBR0j2g2muQOGVhPHC17SmXZzh?= =?us-ascii?Q?so3f/I6gV/t2KJDkUrQGP/FgZ6g0gF/KzHHcrNH8cLgfqegATJTKCFxDJ94o?= =?us-ascii?Q?TJjUuPgLyIh2xi/WT+4Lm75mU+C2QRIesPgCe21I1C/dwpGB7RutsdsNIWuk?= =?us-ascii?Q?xHPKh8/CBqaeQtM8SBVrwz3OufooecRUWl30xpI5Qq7SjjqnkUwAljjtUsBF?= =?us-ascii?Q?q+UsygUftWBJDi5gW2P3+dxX10529ebDn/UVjzUOS5I0h1kWBSdo/mAr5XJn?= =?us-ascii?Q?nU2aawB5o1SOoQD6Ym9QoWHqUsrkQyjaAO4zpfrd4bdSNfL5efVJE0SYd8gp?= =?us-ascii?Q?4HyR/8s13eY/rRfKIus1SDWWmE6tR6+99mAUo4nOhwYbtv3ZU9HDtLUXNCQH?= =?us-ascii?Q?yx4s2Ay3nlF2Uie8t6SqdFoO1EO1yX/Sboo5lLimLP9fzWS52cfa3njjlCoJ?= =?us-ascii?Q?WU8k3Z0okM+4CevZVrU8t0fLaqVt9n8aKexfInR9GeeQV5mdRmme7KuTN2gD?= =?us-ascii?Q?Hyif8+dT8mcPQv9098SUbd7uYcGKQ22JYAA/bAqeMbR6bpaR3gkJMar58Ljd?= =?us-ascii?Q?g0LLoqsPFWNuNjoTtGGPPerGc14lgu0FVFlH7f8C1Q7sdua6Nl/wzGyGJbgU?= =?us-ascii?Q?KnZbhn60NPz2RrWaUGSwPzD1aIGT8vyS+zKIlXY9e+Qa0KmK//TTCFlAFPSl?= =?us-ascii?Q?R4Fw4s5awjYYq4+ik0auhP/utubqcmGWTnd3v3DsrEo34dETrRPLuBYiXMYu?= =?us-ascii?Q?ffZ7tQ5+Y0o7c3qUY0Zosx2y8tJMtZYOSxeA9nH4PgETUH+mP0tmVJ4No3U1?= =?us-ascii?Q?YJ3bk7gWKtvc7WgGVb94a82FxSR5OQfiPjIza++/p4QiyAoR5eP3Hjx1RCiL?= =?us-ascii?Q?aupik4Nez2DTcJiXO2uVhgM9AHqImm9UfP3R4u8K5a98AlZo6BhNl5E2Gk2A?= =?us-ascii?Q?N6tbFbMn8zhtzps9pGex5KyQf/1g9d/F/rOOfviBJuUQB2QbZIMLZHsUUeqB?= =?us-ascii?Q?Eyis4XQgYi8AKfOcq2rDL2DFyqyt88k7Z/bgq5pigrV0SzCqZ7NkTQITynGt?= =?us-ascii?Q?pbXYepwAIzfRHye47I3N3QlSNam5yuBlDfstrGrHmg5hH2kFg6CkP+7VWLyB?= =?us-ascii?Q?L17EHpSTdDGalr+eAUjnW9DK+xuSOWCyfOGpLFb1F6FtSlz/+VCHCIPuyLog?= =?us-ascii?Q?o4xNSLZnXSImOcwiegnCFgvGBbi4GwpwwQp7pz7VO/VYMTJFIqN+L35lYziX?= =?us-ascii?Q?g5da/6BTFQm1oIE/11NlbprVzlgjPFXA7dKHdkwd58cCgET7gDHOAc7LYveh?= =?us-ascii?Q?z7PBsO3zoHV5NMzzNJUFcN6e5ziKN31eH6wSJA/i36WO+OaR2JIqAx4KUMkV?= =?us-ascii?Q?rO/tGnvVuG4foDU+g2TQ2DXMZry2E6H/w0chFjwpzhAuL9e3uluXRAnMd3/q?= =?us-ascii?Q?Y06UgL+Z/mmGSgtR7pke4Z8nRxn7ju76mgDaNP0USppSbxkdZtOfRGcoANBv?= =?us-ascii?Q?/AVGSQ=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44c4cf31-49d9-40a4-320d-08d9ec066dbc X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 19:57:40.6363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KJI0t086g86mRyOqKiGkQS8MIgBAPNgC6rZwJZqyj/0pnOCt5KhdWwdMSt+UIpZbNHgJc2opM7kow1gCK81d/dqTOL8loY/MVmGvzeidTbU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5701 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202090106 X-Proofpoint-ORIG-GUID: dbAX5WsMD-dfQtqAhjkRB693bolBEkpz X-Proofpoint-GUID: dbAX5WsMD-dfQtqAhjkRB693bolBEkpz Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" For x86_64, when CPU or memory is hot un/plugged, the crash elfcorehdr, which describes the CPUs and memory in the system, must also be updated. To update the elfcorehdr for x86_64, a new elfcorehdr must be generated from the available CPUs and memory. The new elfcorehdr is prepared into a buffer, and if no errors occur, it is installed over the top of the existing elfcorehdr. In the patch 'crash hp: exclude elfcorehdr from the segment digest' the need to update purgatory due to the change in elfcorehdr was eliminated. As a result, no changes to purgatory or boot_params (as the elfcorehdr=3D kernel command line parameter pointer remains unchanged and correct) are needed, just elfcorehdr. To accommodate a growing number of resources via hotplug, the elfcorehdr segment must be sufficiently large enough to accommodate changes, see the CRASH_HOTPLUG_ELFCOREHDR_SZ configure item. With this change, the kexec_file_load syscall (not kexec_load) is supported. When loading the crash kernel via kexec_file_load, the elfcorehdr is identified at load time in crash_load_segments(). Signed-off-by: Eric DeVolder --- arch/x86/kernel/crash.c | 92 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 92 insertions(+) diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c index 9db41cce8d97..6215c51919db 100644 --- a/arch/x86/kernel/crash.c +++ b/arch/x86/kernel/crash.c @@ -25,6 +25,7 @@ #include #include #include +#include =20 #include #include @@ -398,7 +399,17 @@ int crash_load_segments(struct kimage *image) image->elf_headers =3D kbuf.buffer; image->elf_headers_sz =3D kbuf.bufsz; =20 +#ifdef CONFIG_CRASH_HOTPLUG + /* Ensure elfcorehdr segment large enough for hotplug changes */ + kbuf.memsz =3D CONFIG_CRASH_HOTPLUG_ELFCOREHDR_SZ; + /* For marking as usable to crash kernel */ + image->elf_headers_sz =3D kbuf.memsz; + /* Record the index of the elfcorehdr segment */ + image->elf_index =3D image->nr_segments; + image->elf_index_valid =3D true; +#else kbuf.memsz =3D kbuf.bufsz; +#endif kbuf.buf_align =3D ELF_CORE_HEADER_ALIGN; kbuf.mem =3D KEXEC_BUF_MEM_UNKNOWN; ret =3D kexec_add_buffer(&kbuf); @@ -413,3 +424,84 @@ int crash_load_segments(struct kimage *image) return ret; } #endif /* CONFIG_KEXEC_FILE */ + +#ifdef CONFIG_CRASH_HOTPLUG +/** + * arch_crash_hotplug_handler() - Handle hotplug elfcorehdr changes + * @image: the active struct kimage + * @hp_action: the hot un/plug action being handled + * @a: first parameter dependent upon hp_action + * @b: first parameter dependent upon hp_action + * + * To accurately reflect hot un/plug changes, the elfcorehdr (which + * is passed to the crash kernel via the elfcorehdr=3D parameter) + * must be updated with the new list of CPUs and memories. The new + * elfcorehdr is prepared in a kernel buffer, and if no errors, + * then it is written on top of the existing/old elfcorehdr. + * + * For hotplug changes to elfcorehdr to work, two conditions are + * needed: + * First, the segment containing the elfcorehdr must be large enough + * to permit a growing number of resources. See + * CONFIG_CRASH_HOTPLUG_ELFCOREHDR_SZ. + * Second, purgatory must explicitly exclude the elfcorehdr from the + * list of segments it checks (since the elfcorehdr changes and thus + * would require an update to purgatory itself to update the digest). + * + */ +void arch_crash_hotplug_handler(struct kimage *image, + unsigned int hp_action, unsigned long a, unsigned long b) +{ + struct kexec_segment *ksegment; + unsigned char *ptr =3D NULL; + unsigned long elfsz =3D 0; + void *elfbuf =3D NULL; + unsigned long mem, memsz; + + /* Must have valid elfcorehdr index */ + if (!image->elf_index_valid) { + pr_err("crash hp: unable to locate elfcorehdr segment"); + goto out; + } + + ksegment =3D &image->segment[image->elf_index]; + mem =3D ksegment->mem; + memsz =3D ksegment->memsz; + + /* + * Create the new elfcorehdr reflecting the changes to CPU and/or + * memory resources. The elfcorehdr segment memsz must be + * sufficiently large to accommodate increases due to hotplug + * activity. See CRASH_HOTPLUG_ELFCOREHDR_SZ. + */ + if (prepare_elf_headers(image, &elfbuf, &elfsz)) { + pr_err("crash hp: unable to prepare elfcore headers"); + goto out; + } + if (elfsz > memsz) { + pr_err("crash hp: update elfcorehdr elfsz %lu > memsz %lu", + elfsz, memsz); + goto out; + } + + /* + * At this point, we are all but assured of success. + * Copy new elfcorehdr into destination. + */ + ptr =3D map_crash_pages(mem, memsz); + if (ptr) { + /* Temporarily invalidate the crash image while it is replaced */ + xchg(&kexec_crash_image, NULL); + /* Write the new elfcorehdr into memory */ + memcpy_flushcache((void *)ptr, elfbuf, elfsz); + /* The crash image is now valid once again */ + xchg(&kexec_crash_image, image); + } + unmap_crash_pages((void **)&ptr); + pr_debug("crash hp: re-loaded elfcorehdr at 0x%lx\n", mem); + +out: + if (elfbuf) + vfree(elfbuf); +} +#endif /* CONFIG_CRASH_HOTPLUG */ --=20 2.27.0 From nobody Sun Jun 28 08:36:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E05A0C433FE for ; Wed, 9 Feb 2022 20:03:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230519AbiBIUDU (ORCPT ); Wed, 9 Feb 2022 15:03:20 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:44096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbiBIUDT (ORCPT ); Wed, 9 Feb 2022 15:03:19 -0500 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ACA7E050250 for ; Wed, 9 Feb 2022 12:03:14 -0800 (PST) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 219HLb9p013346; Wed, 9 Feb 2022 19:57:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=HsrvstylsM0OYg6AycH8OOL4tqodYwvqcGLzbWaic9M=; b=KUz/osWdUOb+qphjeTVBEiosIniTyUakrkuNUa28IUbjwF6lbGS2ZtSCOruoDXwBUFMt ChMIBihwG9wc8+2mhENeOJ38qmiJKSyhk1b20mxLPN95/E3X60UCkGdgpR37sbOClFpG CM8MoyGGKgyKdFtHV2WKsY03Hz6x+hsCoo0ONyT1g3Mnr1X97sgetvspwdduZUmSKqao XlvDYgZU/ODQbVJLZyrHI/2Y5lLx4Zv9e3OQiTd6LkMcOpiXUk7HBOnBiv4Z0jlWZ/TL GBc5yTgWxDi3cB2J7fiTPOMZaWhU89KN3ZOVefnpoKGkhH+rihm/pG5rllVfHRt/c1qx 7A== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3e368txv42-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:46 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 219Jtqrb046251; Wed, 9 Feb 2022 19:57:45 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2102.outbound.protection.outlook.com [104.47.58.102]) by userp3030.oracle.com with ESMTP id 3e1ec3b0r4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Feb 2022 19:57:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PBKVbGyRuLfCs6S6UXRNbsFE5fGBR/SEAalCJbgSRT9HQaB6E19ewS6IxBGeWhQE4bMJHpebGfW0SOYkGHNxXfW3Zwvu9dYxrP1XXKhM6nCVXhGpRnEzK8xXP8Cfw90WSRMS4mETgUfm/2Ke6kcBZxsvO2a8OiptINzb5ibWk3hHkuFr5tCX2bs4ueLJ3dpQQZGuaEM/cLUYhdjhHvAei/jiBtJl7yItTrbenQbmW3zhnP9e1qUrKIeNvv7XGaNXhwJA5cVAlAzBWAsnupkNzcFR2MvNZShRLz9m6HriVAAhyEoWsgiBAZBA04ZRS7lBu4I+kYcGK0T7aj50iOM/lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HsrvstylsM0OYg6AycH8OOL4tqodYwvqcGLzbWaic9M=; b=Io+Y50BBaMEnetGY0mdz6qKgTnXWuOacgNuO7+RCEAvTZwEVLYsRN5+snC1693XxG/qtAg2i8fyF4iYUCVE5UkKc66yK1rsGWHZtGFzehShLrsh1nfQ9HqIc3U1xPHDesKYSRlIUAEDfBGd5LoVebIdogIPxYnOykUFa9jcEGv8Qufiaq35XDLai1PzTV3Vp4/21cQFOUXXZwtrTUpfIO+U/jqy+LxP+8E2mHp8OLbqFO9D3nqfq+0Bb989Y0gpyjOC0l5Y1wNcwsA7ry5YtlUmHE4QdJjTSFUC6QG3nWK2s7x2Z0foz0PYTi5M4eBQFS3/gtHhWX4SqGYQ+ByiuHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HsrvstylsM0OYg6AycH8OOL4tqodYwvqcGLzbWaic9M=; b=oDMBEmwrju2/QgtQoBRWma0OvAduCy60hMoz8USAjx5Kax5imrXdC6ZhOOYmAWb+oPgAz8balkrYVlcVeN9Q65CX0dusNm7vpJ0kIhNYgYB3Fss0RogUHtbIJ7eSiOg8CLoY1NtFap4O4f7gRA3C7iYEBEhylV7U/1Ph/OmjnlY= Received: from CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) by MW4PR10MB5701.namprd10.prod.outlook.com (2603:10b6:303:18b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 19:57:43 +0000 Received: from CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c]) by CO1PR10MB4531.namprd10.prod.outlook.com ([fe80::ac06:be4:5723:771c%5]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 19:57:43 +0000 From: Eric DeVolder To: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, eric.devolder@oracle.com Subject: [PATCH v4 10/10] crash hp: Add x86 crash hotplug support for kexec_load Date: Wed, 9 Feb 2022 14:57:06 -0500 Message-Id: <20220209195706.51522-11-eric.devolder@oracle.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220209195706.51522-1-eric.devolder@oracle.com> References: <20220209195706.51522-1-eric.devolder@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: DM6PR05CA0046.namprd05.prod.outlook.com (2603:10b6:5:335::15) To CO1PR10MB4531.namprd10.prod.outlook.com (2603:10b6:303:6c::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 67d13670-768a-4443-2cc8-08d9ec066f1c X-MS-TrafficTypeDiagnostic: MW4PR10MB5701:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JyajodsZ+7WTuyL9CIi2I/6Sff5qE7humu18+seaz7Va8DGq8NvUh3Kx3OyEI+83yVXWMq+N0QpfmxqmUS1CKZK9m3Tchqj/a7dKcS7Kfg+R7Dya2bhfWrAs83rFiOxdIvEJekhZtbqPao1R141keTsWKh36ET8jVqCm7AF8rSLwYswYdrERz5bgpnrK0bp6joKDuPSRIliokCkbIoZ6TTZWEC35IEnOpVI/ZFd2nU9dGWWp61bb/ZlgBzMxkkbc//tWpD26KmP7G9xWbutLCC+apgBRocwo2PqhQ5GHp27Em6Hf8m5IXJn3sJTlI2VGO45kJz134vYKuey+r1mEKXI4BrgASVYhZak5nSM9ndB2BvgM0d60sXUm3/VkJtkEUYdOjoPe5MxNX/fz+YCYe0cEQFJQP6o9J+XMODNS5+KoyaeRw/v8Qid7ETxmrfHX7z2mHcb0UFItA1BjKBj8otgD7o6aN/DAVmxolRqEtp4RkHB1LEyzn7wekoT5gs3YgjRqgczJE9TYeNOVD6KC/jsMnxkMbJstr74U36C62sFUhyFnJwT0LJ9Zd2MDzn/RTa8D2vKefAveBtXdj36QwpuHQn+6V7gn7m5ojDE/nMaary3ph0sXv5y0/ODlYF0tbObCGnFpjYhtjPvNI3YyaGU/IK20tDdPmpiTp5DMZmPSC2PNOF7XAjBg3TF0UcK2GW9Iv1u2IgWAVKAI5vhW6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4531.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(7416002)(5660300002)(1076003)(26005)(107886003)(2616005)(186003)(38100700002)(2906002)(38350700002)(8676002)(86362001)(316002)(6486002)(508600001)(6666004)(6512007)(52116002)(6506007)(8936002)(4326008)(66946007)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E1BGOwbVOPqqZ9/xwpLIYz8n+ex6YyrHE3yys15a149nDW3ATv+wry6lH0HR?= =?us-ascii?Q?/tBmc+WVRAAgyoCcKmPs8xtXmJMKO/QipPC16LAlIEePrVeJYUuNlW5zLJ0F?= =?us-ascii?Q?5PU2wVVFGbfUa4SVEEtwiAHRP9RqQjQn2uTtEtL31M9l1Zq4Q9c7Y+kmWoBw?= =?us-ascii?Q?+Hy3BwG1n5s3yhWNeyjZKsN+eFOOvrzAh3LAyH4DCEMCnZLE3Rt27hIQWgEt?= =?us-ascii?Q?IiMrkZtAqW6zLMadOIOzBtEZU8djHkGgIXdw84ugaQMF4oejMO/z8xWOPSwZ?= =?us-ascii?Q?98CxRPJBq7Kg+Pm8F7qby+pYbQyOorlx91tdWDJcBFEaKl4qmVy83gyyHpG9?= =?us-ascii?Q?aGYMrKhrX+41lCfEUx7YZyscaOl7ZOLUf6mryk/lIArRQrShsYUM28UVj03V?= =?us-ascii?Q?sQe+8qNhs/jWoLsb0kz+zwradJtDs5NazQeCZCl+fC5LyuDP04C/ckzxfLNS?= =?us-ascii?Q?8cqRvyMKQ+fiTyRndu3A+Oj1YCIqmdEGP4scYj2FY1n3n5l9YUXzCfWY9zgs?= =?us-ascii?Q?ngCsbB0AKwmc8x6mmO6BoZOKJtxt+Vj24M5dtkApwB2nD10nhuqKv6Rx2ev3?= =?us-ascii?Q?k1VsiFmTPObPh5lnWwyrH4laUehPlM5yEC+gFLj8u1Qnh9VtBjtV866KAViK?= =?us-ascii?Q?gv+PxTqjKu2O7KboHNpP0sk8BMWtXt+yUVUGB2nerlSEUNtErowfvIAVpo8w?= =?us-ascii?Q?gK4khh0ensGW+WA7lfaefDLUEnWnW5kP+fKWME2jsCUIVt4jfMDgzMPPbl4/?= =?us-ascii?Q?PtLX4BCLalghyJbZXZz93GdZaODKHX6q/L7445Z9hGC4kGZXrfveJJvzTOR3?= =?us-ascii?Q?of+hD3VtysGEZmvZS/eg43OjJu9qU2OILDAGV2t3ht+8rDWm8MTk93Zt5GSn?= =?us-ascii?Q?Lzk8D5FGE42qlZ7yi3VqnWsJ2stiHtYp9rDUnCNl56YL/wK8c6VdZTRDtrCq?= =?us-ascii?Q?BNHIuUO/N32AOZRdqEheMjiy6T7LaohrDunJLQqqfaYZSoNHsChXFc4yqjtY?= =?us-ascii?Q?Ee6iK7vo6Sh8vTHmtX1YsYQTN6kTzevlVj3ZimMtaliKmz0sE12bLFn1WrVU?= =?us-ascii?Q?bO6zelL8cBU+fsI6Ca4uU5jaHvTg1LWGfLPI9EHJuYsInZyrARwvAJEJTncR?= =?us-ascii?Q?HkideLNUfqgj8D19o1MUQlUzFAhyaX4jCFVFDTrOJsn6+4pPQuV8gphcVtmM?= =?us-ascii?Q?8QceYm0F6W9eMGDLJPJhVmM2TRLsLfLStdH/NYpPxva5d/ATjFn2t5MXgIzd?= =?us-ascii?Q?9mAMaC35RbW6n6E7ljJY4qkO5A9z07IuvnUgaRORMxJ8JSBhz2/+ylOgfOHf?= =?us-ascii?Q?2aNdzbQnvBGRdE0C7obxhlsKOA9eBC9Bjr9ug2XEU8ynRcP9Jkl6LttRH8wf?= =?us-ascii?Q?y55kHg/2IleNCtJc8pd2Mpt+V5PtZlaB8ZrToWSLuwZhhsmj6mhcFz4nOplv?= =?us-ascii?Q?YHfR03evlb9os3fbPR6WVYLhpqsCJZCvW7qLArz9QXPY+4PYBiH5JDjDdXjJ?= =?us-ascii?Q?7w8K5i9rG9t/7WHfNKsykz8Xd1KF8/l3peqUVD+RUEEMDYVT6MywpbkA88em?= =?us-ascii?Q?WYLYc1sbPtZoegYHUqoXsBmmb12ESV6WfCbFl1J0LLcbiytAmNKhCWuCNnuI?= =?us-ascii?Q?9D/+BE/zrtK41+aRhSC1Ts96T++C0T5LmVaIvT1ew95yFgcyaH8ku6XW6NU0?= =?us-ascii?Q?oryA5w=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67d13670-768a-4443-2cc8-08d9ec066f1c X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 19:57:42.9743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CaJljvaj9JC/geCeu8tzFPCTHtrgUNC1ouVazchicPe4G2IN1XeUty3qBaC2JdCxLBkFKryQPJqbVPzv0BqTd6ThE/G7vGsQZbTK3Ark+r4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5701 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10253 signatures=673431 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202090106 X-Proofpoint-ORIG-GUID: upeg15oOpP-cvAN8ySc-CaRv6vRL2928 X-Proofpoint-GUID: upeg15oOpP-cvAN8ySc-CaRv6vRL2928 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" For kexec_file_load support, the loading of the crash kernel occurs entirely within the kernel, and as such the elfcorehdr is readily identified (so that it can be modified upon hotplug events). This change enables support for kexec_load by identifying the elfcorehdr segment in the arch_crash_hotplug_handler(), if it has not already been identified. In general, support for kexec_load requires corresponding changes to the userspace kexec-tools utility. It is the responsibility of the userspace kexec utility to ensure that: - the elfcorehdr segment is sufficiently large enough to accommodate hotplug changes, ala CRASH_HOTPLUG_ELFCOREHDR_SZ. - provides a purgatory that excludes the elfcorehdr from its list of run-time segments to check. These changes to the userspace kexec utility are available, but not yet accepted upstream. Signed-off-by: Eric DeVolder --- arch/x86/kernel/crash.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c index 6215c51919db..1b3e5e4fb965 100644 --- a/arch/x86/kernel/crash.c +++ b/arch/x86/kernel/crash.c @@ -458,6 +458,32 @@ void arch_crash_hotplug_handler(struct kimage *image, void *elfbuf =3D NULL; unsigned long mem, memsz; =20 + /* + * When the struct kimage is alloced, it is wiped to zero, so + * the elf_index_valid defaults to false. It is set on the + * kexec_file_load path, or here for kexec_load. + */ + if (!image->elf_index_valid) { + unsigned int n; + + for (n =3D 0; n < image->nr_segments; n++) { + mem =3D image->segment[n].mem; + memsz =3D image->segment[n].memsz; + ptr =3D map_crash_pages(mem, memsz); + if (ptr) { + /* The segment containing elfcorehdr */ + if ((ptr[0] =3D=3D 0x7F) && + (ptr[1] =3D=3D 'E') && + (ptr[2] =3D=3D 'L') && + (ptr[3] =3D=3D 'F')) { + image->elf_index =3D (int)n; + image->elf_index_valid =3D true; + } + } + unmap_crash_pages((void **)&ptr); + } + } + /* Must have valid elfcorehdr index */ if (!image->elf_index_valid) { pr_err("crash hp: unable to locate elfcorehdr segment"); --=20 2.27.0