From nobody Sun Jun 28 10:34:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF64C433EF for ; Tue, 8 Feb 2022 18:04:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384455AbiBHSEq (ORCPT ); Tue, 8 Feb 2022 13:04:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353460AbiBHSEj (ORCPT ); Tue, 8 Feb 2022 13:04:39 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8240EC061576 for ; Tue, 8 Feb 2022 10:04:38 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id j5-20020a05600c1c0500b0034d2e956aadso2297998wms.4 for ; Tue, 08 Feb 2022 10:04:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cdlsppHiLZTOsM13z6W1Cp7fdsqKE9BaC7RMZ/J9wUY=; b=aiNV3vVZiXuLBKybeAPgsiWUsvt6pmq4xQAxUtys8cJQTrTNpeXd03r0zhH3GajZad LcGU8gmuoCruJvOB0A9A339LxEdh94m6W4k6iLGT3X1WpvJ9m4xmHbwCT/ewrUNiwMeM /TVG2P6AB3OQKgXJdxPxAVXCEtrGIUbWn1cTk6s7KGAWjQTEvL7rl9c33VrkMiW/B5T3 NapcckAB7O2wMj2hE8tz5D6fOpU2QhRLkqsr92N4HK54h+aNZ40nIh0CBCrZTP/jcu65 dO6B+ZuOIB009eV4MrogSOLrOokYmQWIopdmH02laCxzeRsy7ZKlyQrZsJjZhzeEi3pz qIEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cdlsppHiLZTOsM13z6W1Cp7fdsqKE9BaC7RMZ/J9wUY=; b=iCST0UYXYJOReCZl8iYI8ePCss8c5BkZFo5edWvsGxt6Ebt2V/NZy8HCjISVjAUBYv 05jh4u7niJWwEQl1Hub21mb2UW+3k5onUsaJq2LeVRc+se8RMZEzPEYjLh/CaoC5yR83 RpXhglh0YZonFvdyniYgKgusk9ZEZ5u6HfEiXOozIAAsSRaUI3Ig5oAHQrgev6TM2KwA BbolZDIO6NsL4uQmtzWBkmSj/KKCQpVJQMbydEcFrMVN5nqsahNJN2f9tCYpz1+iYVSO q8drDSVD9Fiv9w/T8+netQ4jfEj+Kyd8KbMelFMO70pM6lWrT34cWKHscGezOd/FUo2v LSfw== X-Gm-Message-State: AOAM532vhIFfMt6zGdRGyMheVatq+rEiTjcf7/JoVk3Z0LahkkES0BN2 /c2QJQZIO7Ihtqd8Lo2NnSo= X-Google-Smtp-Source: ABdhPJwDfPSnlQNtt4HwMMQ8J71qo1hxlwHsxo4zZE5//41TRPJYCa2mS1yiwpIBiagXaSHHrQPLEw== X-Received: by 2002:a7b:c74c:: with SMTP id w12mr2083514wmk.140.1644343477019; Tue, 08 Feb 2022 10:04:37 -0800 (PST) Received: from localhost.localdomain (host-95-245-2-16.retail.telecomitalia.it. [95.245.2.16]) by smtp.gmail.com with ESMTPSA id n26sm3176872wms.13.2022.02.08.10.04.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 10:04:36 -0800 (PST) From: "Fabio M. De Francesco" To: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: "Fabio M. De Francesco" Subject: [PATCH v2 1/2] staging: r8188eu: Use sizeof dereferenced pointer in kzalloc() Date: Tue, 8 Feb 2022 19:04:25 +0100 Message-Id: <20220208180426.27455-2-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220208180426.27455-1-fmdefrancesco@gmail.com> References: <20220208180426.27455-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" checkpatch.pl emits the following warning: CHECK: Prefer kzalloc(sizeof(*pcmd)...) over kzalloc(sizeof(struct cmd_obj)= ...) + pcmd =3D kzalloc(sizeof(struct cmd_obj), GFP_KERNEL); CHECK: Prefer kzalloc(sizeof(*psetkeyparm)...) over kzalloc(sizeof(struct s= etkey_parm)...) + psetkeyparm =3D kzalloc(sizeof(struct setkey_parm), GFP_KERNEL). According to the above "CHECK[S]", use the preferred style in the two kzall= oc() of rtw_set_key(). Signed-off-by: Fabio M. De Francesco --- drivers/staging/r8188eu/core/rtw_mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 038bddc361c3..f5b2df72e0f4 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -1600,12 +1600,12 @@ int rtw_set_key(struct adapter *adapter, struct sec= urity_priv *psecuritypriv, in struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; int res =3D _SUCCESS; =20 - pcmd =3D kzalloc(sizeof(struct cmd_obj), GFP_KERNEL); + pcmd =3D kzalloc(sizeof(*pcmd), GFP_KERNEL); if (!pcmd) { res =3D _FAIL; /* try again */ goto exit; } - psetkeyparm =3D kzalloc(sizeof(struct setkey_parm), GFP_KERNEL); + psetkeyparm =3D kzalloc(sizeof(*psetkeyparm), GFP_KERNEL); if (!psetkeyparm) { kfree(pcmd); res =3D _FAIL; --=20 2.34.1 From nobody Sun Jun 28 10:34:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C891C433EF for ; Tue, 8 Feb 2022 18:04:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384530AbiBHSEs (ORCPT ); Tue, 8 Feb 2022 13:04:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384451AbiBHSEq (ORCPT ); Tue, 8 Feb 2022 13:04:46 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22A67C06157B for ; Tue, 8 Feb 2022 10:04:43 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id e3so18296619wra.0 for ; Tue, 08 Feb 2022 10:04:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rd4kXiCHX1JiB3XHGRQrPutLCcRUBpsFocZnJyKVeYA=; b=Zekmcg/F0gXl2lTHQ+Iuf+YDVpXmk8DGyGcYKxpgugmaot8g+yWX82rTWFuFGN1kS5 aFJOxReAILg1ETjWOPttcJ6oI8xi2hhL2Zvjqe57i3V6opHKDjPWkkQPA1CPSYMJimmo 52obj1Tp1FohouuLlGKSbO8rTOcvnuO1Tmo1Zb0K/GULbxUS3kEUhvbQIVNWCTmYZlmQ 9JAZo8hD+RdE13bIDCngVhut0hagwfUVoxOtq8oKZKZDM0ANYGW6aXXKaqQ+SrKCr+g9 n2XYSpMiiNnD2er375NvRle9F0HI/p9bFB7iXMSE/sjgq8htImz9UTKk+cFxikC/WtB5 SRzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rd4kXiCHX1JiB3XHGRQrPutLCcRUBpsFocZnJyKVeYA=; b=OnAEejvFcsCYx7bdIy69KX5/f3Pytmqe8j2O78a0NtgCo0h7OXuWAt3QxSVyRJPfMs sVaRjsMPXsQATaL3xs07cnSI60ALDSJX5QTSqvJ5ru05WYgnFuQbP7dUWBq34Eg3bfaZ hJQE8N/PEbKYrWz6Cs5uvJ7GjB8k9VG5TelKxVxl73ln2e9ShkwZFsl4y5KZXH4+dguc fXvyCD1QtOpE2AYX8Th62ekXnBwKIithHW1WQP/FxTJEtiKScN49NEvSg+SzCcKyqEqD Jg8xf6yZqQCqaXtATsmds3NJ9paCOkBmXTMc9r/m7e7aTXcbefkLrnar2DMGr56ELnGk B7FQ== X-Gm-Message-State: AOAM532yFOt53MBonxIwG1oxxAnth13Zdc+lYxL4T/oRdW6LZ+RAtkQv gDnavUb0UKkRp4kScfstPzc= X-Google-Smtp-Source: ABdhPJz6VHSsE0bxxnuY/CnoGXeD4TPVnfrv8CkWjmRReX2sSZvNww99j70HMbHPdto99+fvEXXB5A== X-Received: by 2002:adf:e18d:: with SMTP id az13mr4632410wrb.521.1644343481727; Tue, 08 Feb 2022 10:04:41 -0800 (PST) Received: from localhost.localdomain (host-95-245-2-16.retail.telecomitalia.it. [95.245.2.16]) by smtp.gmail.com with ESMTPSA id n26sm3176872wms.13.2022.02.08.10.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 10:04:41 -0800 (PST) From: "Fabio M. De Francesco" To: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: "Fabio M. De Francesco" Subject: [PATCH v2 2/2] staging: r8188eu: Use kzalloc() with GFP_ATOMIC in atomic context Date: Tue, 8 Feb 2022 19:04:26 +0100 Message-Id: <20220208180426.27455-3-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220208180426.27455-1-fmdefrancesco@gmail.com> References: <20220208180426.27455-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use the GFP_ATOMIC flag of kzalloc() with two memory allocation in rtw_set_= key()=20 because it is not allowed to sleep while it executes in atomic context. With the GFP_ATOMIC type flag, the allocation is high priority and thus it=20 cannot sleep. This issue is detected by Smatch which emits the following warning: "drivers/staging/r8188eu/core/rtw_mlme.c:1603 rtw_set_key() warn: sleeping = in atomic context". Fixes: 79f712ea994d ("staging: r8188eu: Remove wrappers for kalloc() and kz= alloc()") Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188e= u driver") Signed-off-by: Fabio M. De Francesco --- drivers/staging/r8188eu/core/rtw_mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index f5b2df72e0f4..860835e29b79 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -1600,12 +1600,12 @@ int rtw_set_key(struct adapter *adapter, struct sec= urity_priv *psecuritypriv, in struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; int res =3D _SUCCESS; =20 - pcmd =3D kzalloc(sizeof(*pcmd), GFP_KERNEL); + pcmd =3D kzalloc(sizeof(*pcmd), GFP_ATOMIC); if (!pcmd) { res =3D _FAIL; /* try again */ goto exit; } - psetkeyparm =3D kzalloc(sizeof(*psetkeyparm), GFP_KERNEL); + psetkeyparm =3D kzalloc(sizeof(*psetkeyparm), GFP_ATOMIC); if (!psetkeyparm) { kfree(pcmd); res =3D _FAIL; --=20 2.34.1