From nobody Mon Jun 29 16:46:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9538CC3526C for ; Mon, 7 Feb 2022 10:41:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350675AbiBGKjS (ORCPT ); Mon, 7 Feb 2022 05:39:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236643AbiBGKdO (ORCPT ); Mon, 7 Feb 2022 05:33:14 -0500 Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83EE1C043181 for ; Mon, 7 Feb 2022 02:33:12 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R641e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0V3oaIP1_1644229903; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0V3oaIP1_1644229903) by smtp.aliyun-inc.com(127.0.0.1); Mon, 07 Feb 2022 18:33:10 +0800 From: Jiapeng Chong To: abbotti@mev.co.uk Cc: hsweeten@visionengravers.com, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] comedi: remove useless else if Date: Mon, 7 Feb 2022 18:31:41 +0800 Message-Id: <20220207103141.100004-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Eliminate the follow coccicheck warning: ./drivers/comedi/drivers/das1800.c:1300:8-10: WARNING: possible condition with no effect (if =3D=3D else). Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/comedi/drivers/das1800.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/comedi/drivers/das1800.c b/drivers/comedi/drivers/das1= 800.c index f09608c0f4ff..c4b6c68f3551 100644 --- a/drivers/comedi/drivers/das1800.c +++ b/drivers/comedi/drivers/das1800.c @@ -1297,14 +1297,13 @@ static int das1800_attach(struct comedi_device *dev, outb(DAC(i), dev->iobase + DAS1800_SELECT); outw(0, dev->iobase + DAS1800_DAC); } - } else if (board->id =3D=3D DAS1800_ID_AO) { + } else { /* + * the branch includes (board->id =3D=3D DAS1800_ID_AO). * 'ao' boards have waveform analog outputs that are not * currently supported. */ s->type =3D COMEDI_SUBD_UNUSED; - } else { - s->type =3D COMEDI_SUBD_UNUSED; } =20 /* Digital Input subdevice */ --=20 2.20.1.7.g153144c