From nobody Mon Jun 29 16:47:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54ADAC433FE for ; Mon, 7 Feb 2022 01:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348055AbiBGBxi (ORCPT ); Sun, 6 Feb 2022 20:53:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229839AbiBGBxf (ORCPT ); Sun, 6 Feb 2022 20:53:35 -0500 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60069.outbound.protection.outlook.com [40.107.6.69]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE29CC043184; Sun, 6 Feb 2022 17:53:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y4fChgLK5TjuhA0omlK8K8bA44/x/k+51sAPLX4z/TjBrt6wVY5nf9zKaYh3UNEhz4wiBM2NioztKKZkwLfF1u3k3uViWJ8AU8Tjh4YywqB8w3BGqiIGZfuwgT08+f8DLQ9Lw8q7WsVN5tS5GHse6GCOsopT48QgEuwYvLdfy8VtDCzLVpdYMzZzR4y0azgEgdtB9pKX8vWXzGTq1zCUxJ3pfwVdG4utO70hkXaHfYr2Z9faHVhpvA7d/E0gnGfkCsY6ZMw83gLvEibuhNMryMGuR2p6Es//FhQmXW9UV2+1eXBgNxrW1W9Buklg2eO/0Xl8BBEjgEV7gNZTYL2TOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aSpTTy5SnN9P+Pidv5lx41LPoGtkIBAQFMwe1b+9bBE=; b=kM6OX/kruBuDDT6N1Z1XQzuFOuxI3mUJ5pDjvXalvMRHWz/isELKca/Zh90w5GT1xND5JNTVfvqc54P3kDFo4ReepqDagg27YiK5tyrYStTU4Exw+HuvZZkDJS6jLu5p8nCDORVqHUNTIlnD63K+tGnqC9ASJ5mo2j/1tzhlWjpXM/URTpkETYCVwLrko2uD6SwQfVJb3PUlxXwMPF8JJXxjDDTidGv+8+I4IWbFUD5FfhVWSpZbNYC7i+nbsnFvJouQ6s3PkppjGiv/SjQxl8o08BZSKqBIsFV3QK9E82/b8QFsuIt9S/fACnIAZnJ6ZkWkU9zGQ7QKPQ3Z7quzLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aSpTTy5SnN9P+Pidv5lx41LPoGtkIBAQFMwe1b+9bBE=; b=mg757dlp4dImFkiXUra6PRbk1P2x3IXUxL3LBcFo4ilnNkRgSDWMipM048k54ASPcnpgjpoW7sl8aH5qmoEqW+CJK88FH9bzyOdrawMXwmbZI3QH65MACyMB5JcrS8Pi4f2S8k7kJg5eA9hN6LfE+fXSYY6eIJn4TloErBplP8I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VI1PR0401MB2493.eurprd04.prod.outlook.com (2603:10a6:800:58::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb 2022 01:53:31 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d4dc:8c9a:55d0:81d8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d4dc:8c9a:55d0:81d8%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022 01:53:31 +0000 From: "Peng Fan (OSS)" To: jassisinghbrar@gmail.com, robh+dt@kernel.org, shawnguo@kernel.org Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Robin Gong , Jacky Bai , Peng Fan Subject: [PATCH V2 1/6] mailbox: imx: fix wakeup failure from freeze mode Date: Mon, 7 Feb 2022 09:52:06 +0800 Message-Id: <20220207015211.394297-2-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220207015211.394297-1-peng.fan@oss.nxp.com> References: <20220207015211.394297-1-peng.fan@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2PR01CA0152.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::32) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 872f5676-7700-414d-1638-08d9e9dca46a X-MS-TrafficTypeDiagnostic: VI1PR0401MB2493:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: noY/jo+IINhjkpKj/AAjexNZUHdQKGaYIYpvcAwJs/WHPf9CusJQ/IWvuzvFs0MtgdBe5gUPOTpFp2yijSyW5HEHbK6piP868aJuQEmpKtG1D2ue8yR7NMH0goL5jiepDvv122cOfUGzUVxL659fmw0mEusSNYM/eBDMeicvm75QiStbegEHYU6rA6jAxBqVLxLLrUcL8O3SBen5ZTIiWmmCxKlo2b5NnRwnrcg6DVtMYELOObNpGu5OonUgxoQA6kBLYT+tBKSYIGIsYPU9Cgq6sQjlpFhbQe7WvsoYdh1Jj8Wz5GU9EI32CEVj18/8HWHlNpn6LEwiIvd1ZeUWYnKcAv8XobXPQi7GL1KFFjUIy4EyhDRrFM8ThGQug8XS+c+EVTFzvHNPsPQa4GtWepaLU/xjYh7FnqxP3/QS6gpqkPTA+HdJDbyt1mq0bThANml8oA/YMEMKmft1EWmrI/To1qAcl8ZjrZC5EKSpO7bxwMD2sdSVNuAvBY4xUt9V68iHNbvht+txNgdlAa+ak1Qd9j3huflNeyCM/mBQCSsLeB/NmS/vCS42uozySlIofj1YhATdxK9Jf7hWWODyuN3EE3HuVV3HGOIDdAv+tXkg6YcYCIVacpfm4PedDcTYsmCNc8KkAM7fKCOuGepSYx0eIfyXJ7RKsbAeskoAE9TTc6Kx2XSy/IqE/OVreHuxo/YuxmHoVOXco9v3V8Y9Qw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(52116002)(1076003)(6512007)(6506007)(6666004)(8676002)(8936002)(66946007)(508600001)(2616005)(66556008)(66476007)(26005)(186003)(38350700002)(54906003)(38100700002)(2906002)(316002)(6486002)(5660300002)(15650500001)(86362001)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vzj8QSN7WmCBqsbQIn9b6p+1SNyuEG+Kr3lxo8JRjefTjTxsQ9Ztxm/+WPLK?= =?us-ascii?Q?7PcUNHtGzWO3+yNLshMTGcu/N+bQfjpOslaMXDlfjYDCM0l9D1INsFxbejDt?= =?us-ascii?Q?twM+CrGerFEKD2JcMMIRe0wuoqeTrkt02bmebWRx1Mm0Kw/mtj0BXZwIAueU?= =?us-ascii?Q?tRn+aKRxWaqpKwi3Xv+r16a4Z/j5811HpNJ0DrpkHY/sRaGF5b3oalhDc2TR?= =?us-ascii?Q?mnYXf/AOafoOgtr6RRxaOpqlw5kg5EDBkifci0JkpAnZazG0oJo5UExKq19R?= =?us-ascii?Q?P/v8ds0W2PsEb98TYirTMs20grjjM+OPkjvuVt2gDh68aGQagGmJNiepeHFd?= =?us-ascii?Q?D+nZo4RiI85p/fgUw8FGFLL2M4dHFGvRupGsFxftbd894s7E2/NNJOB61x84?= =?us-ascii?Q?8plXoGgwRaREUHfTl7sPqnSd0isIAmHucn0YEB9pziFMzPA+ryTGZxvGaT4s?= =?us-ascii?Q?UWyRDr/iPsmbHEqOV7JWG9OEdGvcI284NZulKfkxsRT5VNH8NxlO/dqfqFKw?= =?us-ascii?Q?Bvg5XYBd925+I8/3K+p2Q0R9Wk/dnkHJa1YxA7S4u9huW26oJ/FnrGybkCzD?= =?us-ascii?Q?JlE+eF5oM665y+6xFTXs/S31z63xIFvUykWQZOi5XBmfhpgPDkSTjFecFmuq?= =?us-ascii?Q?DdokK/J+WIBP07PXbeJlhXZhNTUyfkUQdTSj6CWsuACjNkAnle4btF/qqmzl?= =?us-ascii?Q?pKq9dVKactfEzz5hs319NWHgmrqx8w66V+caZeJRYhUYt2UzAv+j6umo2ILP?= =?us-ascii?Q?n3RDjMC5LxTODrkTKLtkffDgsFzaG1pJFtWNEoBvNbligH7bC0bP31HzIONl?= =?us-ascii?Q?QoTrSxrBR/FLv9DY22Qyig6vlMF6eS0JMeQ+Ked8rGYvq9P4KvkyEyCMP17K?= =?us-ascii?Q?5ltDXOVgMt7BuVJx0wrb6FYWMqwcPFQ6DQ6FsUbQ4/Crn8ha2fYy4WqM84dy?= =?us-ascii?Q?XiC7OKLCRbVhvUSBGmJ8jCo86OgRbpwNGAm/UElf1IQx8rcgM3/rWzuSOkH8?= =?us-ascii?Q?Krp6YF9VQARllPqIZ1YOiTH84L6uCEg3Ehk8nQ1FfGIW4z+N88hX4zlxE8Rf?= =?us-ascii?Q?hn6KWkvGCzFCDETMjQn/DKkXvXavxcG6UhzkUosx5PgKVoWG0V3kaMiZ+puz?= =?us-ascii?Q?fMW2BMSs8m+1nU4TlU+bWC7inJz2Dy5Hsd/q9QEfCmh/VGEAIgiO7P6zMGJw?= =?us-ascii?Q?MPcknyqkXTXGFgu5j/JqOxw6WeevYYXQobItFfRa6rLTAEt4XdkBMzCYecXa?= =?us-ascii?Q?BFGeIAiT4BENzDqu5X8EULbeAtY7vu3GJW1kJ/YC/8KOedrWxZO4yxem33Um?= =?us-ascii?Q?7T7Bg0+4hcyQN/kMNQ1x+ASk+WX+DZFQzGXCfT+tUsXnb36LsNRjFWoAWDtc?= =?us-ascii?Q?IYO4/zMC7hA4vvCoRLBtZd83RdvAU6K+03WDCA8JJTh8SZxA3ZDVjVbu5svQ?= =?us-ascii?Q?otgGTol/RmFTcJ0StUw70O9dTeNtEi2llOr8wPgZSvPAjr1flkHqO7HAExSo?= =?us-ascii?Q?+amyz+UEnDEYsY6jg7eNevromFRo0h5a2tzkOuny9qhQumFOpEO2edY87L1g?= =?us-ascii?Q?7DAkFxXc0I6rpWEAIDpyRrA3E4B1M84CKdQysDjDkvdLQ9bWs2yZl9AemnTm?= =?us-ascii?Q?fDnZ+pvulW7Lx6p19rQepZ8=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 872f5676-7700-414d-1638-08d9e9dca46a X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 01:53:31.2003 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E0zuHncoOYUsLbtDbkjabc6nbDIl2uBt7gmId0qMxA+pBLqOctq+dPRCEwDLInsL/YokH1LwxaQfs2gZS0veVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2493 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Robin Gong Since IRQF_NO_SUSPEND used for imx mailbox driver, that means this irq can't be used for wakeup source so that can't wakeup from freeze mode. Add pm_system_wakeup() to wakeup from freeze mode. Fixes: b7b2796b9b31e("mailbox: imx: ONLY IPC MU needs IRQF_NO_SUSPEND flag") Reviewed-by: Jacky Bai Reviewed-by: Peng Fan Signed-off-by: Robin Gong Signed-off-by: Peng Fan --- drivers/mailbox/imx-mailbox.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c index 544de2db6453..8b1399e5d7bf 100644 --- a/drivers/mailbox/imx-mailbox.c +++ b/drivers/mailbox/imx-mailbox.c @@ -14,6 +14,7 @@ #include #include #include +#include #include =20 #define IMX_MU_CHANS 16 @@ -76,6 +77,7 @@ struct imx_mu_priv { const struct imx_mu_dcfg *dcfg; struct clk *clk; int irq; + bool suspend; =20 u32 xcr[4]; =20 @@ -334,6 +336,9 @@ static irqreturn_t imx_mu_isr(int irq, void *p) return IRQ_NONE; } =20 + if (priv->suspend) + pm_system_wakeup(); + return IRQ_HANDLED; } =20 @@ -702,6 +707,8 @@ static int __maybe_unused imx_mu_suspend_noirq(struct d= evice *dev) priv->xcr[i] =3D imx_mu_read(priv, priv->dcfg->xCR[i]); } =20 + priv->suspend =3D true; + return 0; } =20 @@ -723,6 +730,8 @@ static int __maybe_unused imx_mu_resume_noirq(struct de= vice *dev) imx_mu_write(priv, priv->xcr[i], priv->dcfg->xCR[i]); } =20 + priv->suspend =3D false; + return 0; } =20 --=20 2.25.1 From nobody Mon Jun 29 16:47:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDD34C433F5 for ; Mon, 7 Feb 2022 01:53:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348206AbiBGBxr (ORCPT ); Sun, 6 Feb 2022 20:53:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229839AbiBGBxj (ORCPT ); Sun, 6 Feb 2022 20:53:39 -0500 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60063.outbound.protection.outlook.com [40.107.6.63]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC131C043182; Sun, 6 Feb 2022 17:53:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b+oG/Vdfnkxqf5WGZzAOp9K0I1bmzzGG59SLwMqSLztF9HbfayikaiSd8Y5RYIMT1Lunu5oidmCdzy7Brw9ZTQH+rGDlriPgTCzbiLHK3nYQaDk1troLyZkvh37AL4miGcSbQ8ujrxYTq8ZIBzpTRyKtqNBXRzPju0I5V8GOMYJ3SbTwTmiFP9kuBg3GM4VFiumdnE4gPEg33lJ9xEyL3kiZh2Sm9f/dFo74q4+fl+UrUbplIiT9xs65qJA+jG12fWv8UqPMF1kAAHgO+NPJWx798ZaNiqKJV/ukGABJ33QGa9/EWpL2ec/MCNOLuV9ZA93rAyMFg2SuXweTLx63Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ySsx/LE/Po/G0LAozXRSIO6OhXxlmPuyVa+YCSo95BM=; b=C12Vl5/yKQ8E8ikf89TbnBamvJMNnJF4kQuHYqriDPecpeECkyXpyaZ7dJ4m83LL3JghW9N7QID0QAIbqxohuf9OATmbDsX2Sd//Uij+7ucLE3u1vAII9esqeGFXKDVRkzihMOIQ7/hmAnnjqntH75JYf1ELZFnTK8UqHDbQJr0ttJ7aYQAjHR/TW8gZC3vEWmCWr6Z/oYIuiWICQqoe3IsgMjG9oEzgNpXR8/P94Z93whaW8ojINoR+yqJW6lmK7RWIJ9i8+zBiUUFrUZA2ypKe0A84hG4hxv62pxPByDADM5ZpBqMX+w4+5forDKzwbvxPx0NF5RgUZkbMo4Jojg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ySsx/LE/Po/G0LAozXRSIO6OhXxlmPuyVa+YCSo95BM=; b=dItjrIma8QHTSIrTDI/gjkVrlo3JYjStFDetzJuzKj7H7X5Yoyl8X354pITy0CVoUOu7+kL6+87uh3MDHd3qZY4FIby1HJCqTWgvQzKmpJmWJc4ulDnChSr+O7RcyYMw5IsmvW7aLaAHq1BDxCA2jVWHINGWzUB5DdIfXxSRuok= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VI1PR0401MB2493.eurprd04.prod.outlook.com (2603:10a6:800:58::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb 2022 01:53:35 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d4dc:8c9a:55d0:81d8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d4dc:8c9a:55d0:81d8%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022 01:53:35 +0000 From: "Peng Fan (OSS)" To: jassisinghbrar@gmail.com, robh+dt@kernel.org, shawnguo@kernel.org Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Robin Gong , Jacky Bai , Peng Fan Subject: [PATCH V2 2/6] mailbox: imx: fix crash in resume on i.mx8ulp Date: Mon, 7 Feb 2022 09:52:07 +0800 Message-Id: <20220207015211.394297-3-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220207015211.394297-1-peng.fan@oss.nxp.com> References: <20220207015211.394297-1-peng.fan@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2PR01CA0152.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::32) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e7081f05-9e73-415f-dafe-08d9e9dca6ce X-MS-TrafficTypeDiagnostic: VI1PR0401MB2493:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2958; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: op2Y9NJLPuXosFU+wDqfBOZ2iZDHJOOh9T53slQ0OjM4/w0wVuwmjDfzMeu2ucv7q2+6sH80eDCRXkP1eXM9nFL2pOIGWyM6tOJcKJ844q+WB+ubHkfl/O3rPFyLCDIQJ62C8Hq5Ywsu3mBPBWa9jB3REqdZSoevOXPCQH9PrDIkmxqu+/CH4s56p6D8LWdEAxNSweh3yTE8FqLHhGauHcqcOvfsP3X3AF/zgtIj3XWKjHnvT9j/pr2hzksNN0GGR5t6VohJ43DquaoEOsRbzIy4Jw6Ird8fWiNsjkKK6PStlX9hTNuaxXYm/3msd3yN1lG4N1IhGpEmLY65/GiQDbeLGBGjBNwi7Kjo9RVoY2WRSbWOYFXy+w/Fbqabsd2aFfIidFoCrjklGV8/pxlfZFLTeuoFXk5R71FbLsbxMSoPiJR68XBg1YG9WZMprYbfsHzi+NKeQp2/63VsOfSQp/EqQFgC7IXueIudUJsaRNAR4pP1lyNlZWR2hCT36CTh5tmXCIdt2X81dZ4DQyOqq7d1OTYv/HmaUGpL1BAvTIF/T3qgbkyF1X++SCOaB/J6i/h4+vlNRWRW5df06w4DRAIGHGNIhaSK9wPKqYTB2rTG1B0isGne+o1CpY2punuvA28LBVVpjERM2MWN/RhCsInwZFz3uSXL44wdn8+saQ7YCV8JyENhsEuNZaciyO2A30LicdotkfzHzeoi1+CYPg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(52116002)(1076003)(6512007)(6506007)(6666004)(8676002)(8936002)(66946007)(508600001)(2616005)(66556008)(66476007)(26005)(186003)(38350700002)(54906003)(38100700002)(2906002)(316002)(6486002)(5660300002)(15650500001)(86362001)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+Y3y9miZhrfoCMON+EGkwgNbpRzt9vLKQbQe0XtGUgTccniilZvuVsSzyTsN?= =?us-ascii?Q?TdEQn/GM/GukrK9RfR6rdBtUBVx//9yahVeQYg057YnJ3c4iP4YRcB5j9OD8?= =?us-ascii?Q?BaxzgSEiamfR/Ch0k7QXgM6pyp8J6K4xUVmuy6kEtC4eHsGRV0mOqoatGSMy?= =?us-ascii?Q?yL5XnIK1EuxktFj0XEmhdWpqWSQG914yOtzl4la2G39B5p/0x6PhX32C/dSX?= =?us-ascii?Q?vOsa8DEaxO55DvmPuEJzmhuZsjsqjuIdQc4kiSdCGxIQ7ogxruj/5QkKc/XG?= =?us-ascii?Q?FWWDbyYayPMXW8O21/yruUTg3y6gNqIT2/VYSTis50XC6MZ+dYqQD8WADe5i?= =?us-ascii?Q?+OrfrRFb0bL3pnENU/tbiE1A0XxGGbBynHIaSwenLQGWVpRRREJH8v9Dh+0W?= =?us-ascii?Q?daicqGgnHWno1mVa66/HczJFVFkUUN/BcFvqgOsnmd5MHqVA7wcWkpy26r0D?= =?us-ascii?Q?EDzRiHGpW3L+YQWQcCBPdEoOtMgoUZ3FJ0eu/u9/JtkXIrZdu5NAmUKHGcb0?= =?us-ascii?Q?sFjeYimol6ZYkroNJVnad65xPwMwPUnSTDskd9OEbjRyZ1vhA+OyWYSp+0Ei?= =?us-ascii?Q?Ui7voBHdQRTYXQaetefW4Z5jIlG2SN9mheKBJujH9TFzHK9/d7iTfjeHPcw8?= =?us-ascii?Q?NcHuMn4QKBVhHWSWsxUcWxQwdRIfF6mqfGLi5qmNR1qJ9avxhidApr4OGJOE?= =?us-ascii?Q?ZLAn+XQJeeNTftkQJzaJQ03HRrDUZntrUFCCwDA/ukDI0MMdr0tbZUAaitRf?= =?us-ascii?Q?R5GimfbeZ2UIDqs5s0YCFT0QVnKc+JJkbuYBRS2DoFJ22KePXjlhCZCJyaC+?= =?us-ascii?Q?OllaqrIAzf+oO8bAqdNEN6niXNImdzhCewOmgJP9VnTu9Oyd0ZoXB4JdjKKL?= =?us-ascii?Q?y6wNWtrNorFC/XYrR+PD2hE8FBVNEjIUrPnObwSDeWIf755Yh9d3yfWZ3Afy?= =?us-ascii?Q?LOoXaFM7pmgAsNbd9HBP3zwhRPk0VRHTE5t9fDrWgUIGh049vE5pp3nJgLmL?= =?us-ascii?Q?2fmehIo5DyuoCtoIY2BJIVlA7vJ6BysGHZpQOTbxZEzkzM02Ods2F8jGW8wp?= =?us-ascii?Q?FAvSt7tcfKuQEuW1+gsmwRo5FlBesZz+k443faQsUP8Dpuh1tRf5hBQQtaKz?= =?us-ascii?Q?tm/a32PiW/cUV9sNjmQE11sWPXFtUgK1qHxgiHZnCbitS3PiZchKyjxV2AyT?= =?us-ascii?Q?GdUfSYiRxSjpSkfeyoX1J4SaNFwq1WRAFKABU2nX5SskDkHAaC1jOXo5IHdo?= =?us-ascii?Q?ebGaho+S8h2KzHOiDtfLss6O9ITMWmQN4C5ZaCTzpGQ8GZXhfhkcG5CP0ZzY?= =?us-ascii?Q?uJh9YqUl2YPrq7C8M2zyrDynWvYgj/bfJGePpeR19YrLuv28KW8VGNMWk015?= =?us-ascii?Q?jShVzxb6e5bNv2RAvmzC1GG/h3M5iTEPqDkLiDDNfknNAUdwR9+7UjDPMrSW?= =?us-ascii?Q?lBG8rxTCF17cb6+6YLYbxhqaacFCeQwu2bSDDAO25FIMhIqBMrV2R/yDKPbB?= =?us-ascii?Q?JEn0eUqhTMMuYJxXEUS+Ea+j1WO9OFVon6FgIQKDP9b6f1M95yIUSQb4gUmC?= =?us-ascii?Q?waaf5Zo1i85OCf/E+WV7WtDlzwRchknIxkoRug8V1lpfd2YPp3VIg0eWVuRE?= =?us-ascii?Q?v9hCS4DfnqHf7VllXU4XVbU=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7081f05-9e73-415f-dafe-08d9e9dca6ce X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 01:53:35.6067 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jgjgiZqxPSF6IrmdV6s24K61OOTuB+o1LUCJpzoNB12T0egui8RBPOYTy03CtOsoNG332CHvanL1hbEfM2Zzug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2493 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Robin Gong check 'priv->clk' before 'imx_mu_read()' otherwise crash happens on i.mx8ulp, since clock not enabled. Fixes: 4f0b776ef5831 ("mailbox: imx-mailbox: support i.MX8ULP MU") Reviewed-by: Jacky Bai Signed-off-by: Robin Gong Signed-off-by: Peng Fan --- drivers/mailbox/imx-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c index 8b1399e5d7bf..a0c252415c86 100644 --- a/drivers/mailbox/imx-mailbox.c +++ b/drivers/mailbox/imx-mailbox.c @@ -725,7 +725,7 @@ static int __maybe_unused imx_mu_resume_noirq(struct de= vice *dev) * send failed, may lead to system freeze. This issue * is observed by testing freeze mode suspend. */ - if (!imx_mu_read(priv, priv->dcfg->xCR[0]) && !priv->clk) { + if (!priv->clk && !imx_mu_read(priv, priv->dcfg->xCR[0])) { for (i =3D 0; i < IMX_MU_xCR_MAX; i++) imx_mu_write(priv, priv->xcr[i], priv->dcfg->xCR[i]); } --=20 2.25.1 From nobody Mon Jun 29 16:47:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D71C433F5 for ; Mon, 7 Feb 2022 01:53:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348393AbiBGBxt (ORCPT ); Sun, 6 Feb 2022 20:53:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348292AbiBGBxn (ORCPT ); Sun, 6 Feb 2022 20:53:43 -0500 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60054.outbound.protection.outlook.com [40.107.6.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F66CC0401C8; Sun, 6 Feb 2022 17:53:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eoRX69ETSzuqGfe16bxCR+r633RXdbvcWxYik97ThxGapDk7yf3EG7TFk93vW81AN2cJy+YDot85qWs8TJSpw+hT665EKJPxT8g0zGNGqJ/of3tEajFckV4dntn17Xl391MbK8kSS6vsZ7sAQrHMyXLK5vRvy2ABBRse6NthtWtKMXpPJH4p9uALBtZz7qsDg/Tw+PE6h5DhsCxo8B56iSUGPv7RkI8ZjFXL5Ous5CqWyx3cWY+ESfDjGctnpvKLo1Zur84B3pnxSl+MVEaTeCZx0z6dqfewuRBVQWRyNnlHpXEYAp3rXZbcZx2wNV3hJbmjc/dAje7wPWhDqwaAdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w/mYgjP1X/sEqbEKahMjLus6ygwYUuPICUDXCPknzgo=; b=ikWIiTtht3KamN5KBUP0ED8gxBKevBXjMNyxL2Zsio1IIkzcOoOIbZPwYQT0RfGDu38fiRbZUk2XatI4ryFfadHlo/Sj4ql3tUPa4ytDoE0HAkrfqrYOStAcrY+jQjU7DeTDiEptRQwbdaDQUHWTrI8bmZFCJdES3hCwfLMDxoloMqScDKPB1jJOW+RR+gq/acAfLMHJVXF/1XOEJl/Mks9sThHgQH0DliT5CwotaVRrBjOc0aMH55zvIpfe+xuqp4G5fQeBcv5mbojhZjgX3DxoURpmQQE8ZtKkGG4tbjwVDDDMtHpZMwGI22xGtO3jFV917NnoRLvbwHYT0OgnXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w/mYgjP1X/sEqbEKahMjLus6ygwYUuPICUDXCPknzgo=; b=jULV9RD+2FWvUo7gQ5RmwLFX670L6f5UNQp7qI7HH3WcVVehfIPFNnu9grhnGa+vEgvetWQRaOqXjUNgPXWqfvhoPyX/AlIr+pMgrv5szuJ6EApM96Otkh7O5GQakQu4gu8ZAIBQ7HNnKX0tWxJgWvdzjz0zN9lSoYoeBsfd7kg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VI1PR0401MB2493.eurprd04.prod.outlook.com (2603:10a6:800:58::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb 2022 01:53:39 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d4dc:8c9a:55d0:81d8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d4dc:8c9a:55d0:81d8%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022 01:53:39 +0000 From: "Peng Fan (OSS)" To: jassisinghbrar@gmail.com, robh+dt@kernel.org, shawnguo@kernel.org Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ranjani Vaidyanathan , Peng Fan Subject: [PATCH V2 3/6] mailbox: imx: enlarge timeout while reading/writing messages to SCFW Date: Mon, 7 Feb 2022 09:52:08 +0800 Message-Id: <20220207015211.394297-4-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220207015211.394297-1-peng.fan@oss.nxp.com> References: <20220207015211.394297-1-peng.fan@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2PR01CA0152.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::32) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e3bb10a-c7c5-4678-5666-08d9e9dca94b X-MS-TrafficTypeDiagnostic: VI1PR0401MB2493:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hxorawF9BbaTLHUL/4gBoN/pKDChfwqZvXJc1Zv9t/ifmQ3luWkV2c3/urQmLDhkf1RtmKvLSba1HfibyHFY8OCiccejbKciiBaRbzxN8IX+GXgZv+pRG2gHbr/y+TSxEoZx+ncE9HarZqv236IlNll/FQRVFnB5pygSbjXV1nNbD4HDB/pgt5UYlagJIqYPPhgC2MIJq2AcGc256mgLnBImsM2s/3GZ3HMtvxlg7D7iTLXD3RnPYWP5slYiNehjFHLr2TiLVqfneuSJiWYNQhl4Uyn9p+6FRPb8L7IVrN9u9cH3cjE6ubjAX8MEprN1dEWeXV5NyWySVmmlZIVpc0IAtPeblict4eg+7qHl3iop+yt4fiClYn3Ds6MPCVxJFDNQSjABTtzQYDdV21mxP5q02LlhqYkKVr+xE/aBuO5mdpiwhf9P76XPDGLg37ZbApj3NbRISYPTYqUffzDrwGozcJwHw+tyNVIBD83Ops0byIgxAtQr5Rr2mYAeowKTXYcz//hVtxI4bQzU3v+2IkJmp5vCy6SmhhckUQv2+2GFcadJbuOq5NW5oKmYWLDkQa3YEgmuUREDjDKpHqauPmQqQvA3WAMnEJv8jQrCs+htmz7fLQwLqYTWWZ0F/xbmEYjM5DbCXzf7f4FIIOfc6Cgh4uBOtHXdN2ITMQEnFiOTrbcTE8uxb3r6z0CYbbinxzEA+Du/505pGlZ9cehin/4lttMFTec/IAb0ve0nLDvkEFn6wBto06KAYFao4Dm87DnWQzdrf+efVENNRLLqJg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(52116002)(1076003)(6512007)(6506007)(6666004)(8676002)(8936002)(66946007)(508600001)(2616005)(66556008)(66476007)(26005)(186003)(38350700002)(54906003)(38100700002)(2906002)(316002)(6486002)(5660300002)(15650500001)(86362001)(4326008)(161623001)(147533002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pyChvi2FT+pAkIcr7gYNfbYyQIEzTryW7ZOoHoSjjpOLRH3aJUQ7eZCSf/SG?= =?us-ascii?Q?7p/N5/IB4MHmdeVZOPwE455+E88AaYbxJDWqGP8U92AKll+ACOtk5ytR1D4f?= =?us-ascii?Q?F/ri/f90XZvG8Y1KrjRrfPYeBY2VLz1lh9dAWb20B95PtJUCZAyDKjqHGekL?= =?us-ascii?Q?Jt94Wrv4ArN+oYDWagl2uPC7Qroz+0L+c5b7WvKholFe7NChV88e94gg+27J?= =?us-ascii?Q?tTAoiVKsBA+jN1PI3zewtkctO+GotWKGeC2EoyFzY3B8hBnfbVTP6TWwUF20?= =?us-ascii?Q?VUDPCmjO5Lsgs0Pho9iK/SCjkwTXp6zvc47v2+aC75O0NoNtKpSoTYb6QuX+?= =?us-ascii?Q?+3j+xv62G704GXcZCfRo+VLRS6WAZlccTxPmYCTQhkJ2kn6wbdmr2joZ3fXC?= =?us-ascii?Q?vrYyUtICMrfhDJBienvkHMb9B0Akd/fQ5uY9udcsnrWmkdX4b1t/kA88D6Np?= =?us-ascii?Q?7RQ+ZsE1kXPWDLT6W1FYLlxpLxqmSjKuDd1ReEqMFj0nd2rmJz3kt9S7va6X?= =?us-ascii?Q?ie8HUZHEl8jLv4p9OoYEHuyX6ZtZ7h6EQe3NMPxqKE/6fsl9sG/8fSrxvd0V?= =?us-ascii?Q?zMl8ffA1VGuUXilJEOlEq4tXtiODWCxSO2UbfOKAN9c42IVzMkrmv6pdK3ba?= =?us-ascii?Q?HDBBGVjtVVBJq1ClFyoLVywU75GLt9CD1sNRCFFStuPQgbAVC+/EOrCXSxKb?= =?us-ascii?Q?gfXPHdCbxcaMVXRl+ssXiyoUqklxB0D24og8KnNaDXLPVcm5ZfGGMAN3a9rO?= =?us-ascii?Q?l6GGrr3K5JKT7S7o0+Zkzhn+fxFncVzE+8fySvBVIz3V+DgEbqtkMeVp4bQ/?= =?us-ascii?Q?Rexk8wT520N2NMIXSvBl735dg8bPaX6Al3GFt7wfbs1EZExLO1lqhRPyHO6w?= =?us-ascii?Q?qY29rPUjXfY4ngn/1c2RqXX7YyUfbH94COX653NBWHSbOb9ikgy3ogHuP8OT?= =?us-ascii?Q?h9+CvmPlY28vFzvBZWvHIuDSNvi5hzYnN7/jt5Yfxy9CTdXypYpDHGNwHh54?= =?us-ascii?Q?bfZ/UZ3jky6wQWNHx6EfZsvvVto5Ae+MImBfWOu4BFIjiFBBqcT9xX/c9uCI?= =?us-ascii?Q?Cu024yXPO6tFTQBrpr8BUha6fsUvEsKvT8FZCbuesS2Cn0PVIWtkQRpmVVUO?= =?us-ascii?Q?tNwRU90LRKrn9BfaRQ2lEowBzRkwRaO7jNCEt0L72ThxD+qXuCqv86TbNClW?= =?us-ascii?Q?WlbieBwv1q4kUcUvwjII+iQDjZ8+PBD3LyTVOVzr6DUJXznVGc43t9f1rM1u?= =?us-ascii?Q?Y1OjUmRW0+lm7icD/vSvqBvN8EyZUT+X8zTgI03vf0vhAM1MODNDgpPvqFpx?= =?us-ascii?Q?hFKfbPvEO2hstdydKU78XYfczzyS9eG2qc2Ox/4Wxzi4SHJNvvxuWzgRwqmv?= =?us-ascii?Q?6jYqNO0bJsfeYFGmDFl7nsm9lYfyaILywBz5VqU/QbNmJTgpmMcggmeur4dM?= =?us-ascii?Q?n+4px/XUZniGn5YeevzLP4ZqbPNvKeoEoFGDcnVytClgAZrAwLBlYTd/VoQ0?= =?us-ascii?Q?o80SonGnXrUoTdZAwpnyzmV5Hb0FlVkLM8C9ocUEhVFTkWd592F+VHGbvitV?= =?us-ascii?Q?WSI1PHHAyLV+naS8LIf6FjJDLZwe99jqdIffJAjn2l9ilRZLM/x2+EgWv+TS?= =?us-ascii?Q?JtEE7LpchWfB3BEEqbm9dVU=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e3bb10a-c7c5-4678-5666-08d9e9dca94b X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 01:53:39.4812 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rgmEXcPlwdp6dte4TPhkTzIpM4oMs4KjF29eyAu3kTxltUsZLb1MtxQcRHCVbZEpC58gAIiPY4hD5Sa6/EFI/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2493 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Ranjani Vaidyanathan Mailbox driver needs to wait and read all the words in response to a SCFW API call, else the protocol gets messed up and results in kernel hang. When the responses are longer than 3 words its possible that SCFW will take some time to fill up the rest of the words in the MU, a timeout of 100us is arbritrary and too short. While waiting for Linux to consume the first 3 words of the response SCFW can be busy doing other stuff and hence Linux needs to wait for the rest of the words. Similar restriction applies when writing messages that are longer than 3 words. This patch increases the timeout to 5secs while waiting for response or writing long messages to SCFW. Signed-off-by: Ranjani Vaidyanathan Signed-off-by: Peng Fan --- drivers/mailbox/imx-mailbox.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c index a0c252415c86..a29f8006ad0d 100644 --- a/drivers/mailbox/imx-mailbox.c +++ b/drivers/mailbox/imx-mailbox.c @@ -218,7 +218,7 @@ static int imx_mu_specific_tx(struct imx_mu_priv *priv,= struct imx_mu_con_priv * ret =3D readl_poll_timeout(priv->base + priv->dcfg->xSR[IMX_MU_TSR], xsr, xsr & IMX_MU_xSR_TEn(priv->dcfg->type, i % num_tr), - 0, 100); + 0, 5 * USEC_PER_SEC); if (ret) { dev_err(priv->dev, "Send data index: %d timeout\n", i); return ret; @@ -263,7 +263,8 @@ static int imx_mu_specific_rx(struct imx_mu_priv *priv,= struct imx_mu_con_priv * =20 for (i =3D 1; i < size; i++) { ret =3D readl_poll_timeout(priv->base + priv->dcfg->xSR[IMX_MU_RSR], xsr, - xsr & IMX_MU_xSR_RFn(priv->dcfg->type, i % 4), 0, 100); + xsr & IMX_MU_xSR_RFn(priv->dcfg->type, i % 4), 0, + 5 * USEC_PER_SEC); if (ret) { dev_err(priv->dev, "timeout read idx %d\n", i); return ret; --=20 2.25.1 From nobody Mon Jun 29 16:47:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F23FCC433F5 for ; Mon, 7 Feb 2022 01:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240941AbiBGBxy (ORCPT ); Sun, 6 Feb 2022 20:53:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348207AbiBGBxr (ORCPT ); Sun, 6 Feb 2022 20:53:47 -0500 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60058.outbound.protection.outlook.com [40.107.6.58]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F05DC043183; Sun, 6 Feb 2022 17:53:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F00HeCEGosSrUvUk8k4WDj2Ihr07flTw7YqI8M3waUJKTXnDqtH2DO5Ckhk+iCQJf2NMvYak6HVv9o0YJE8oD6HrE5AOrMaOR6oU4a5iTpOGmMFLQmKKmcOFkkcjGQ6J3Ly/LoKRgm1JnrjMspqrual8qz4bd9feOwAF+Zb/djuqDM4nfv/XSteEOOB+ZJQAC4vSbXyzDLYSliOowS5cHyhVUYH19KNWVwX5rgo8+P93Nc1v1Q7uy7+ly+nmQHK++1EWbjugSeSzWUSZcpFcvtVMis/xGlLiQtmlXFQST+cr9tTOUh4t9Ox17BoLZBEG1c7PDp5N08ppKeAWQZWeCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bULUEMd590ikObpv4WQrPTOAOgjCIgU2Vryb6sCI+Js=; b=IeUNQotql/b0wIkNFLCCadekMb8fn2dHKboCqXUwRfOSMTkBW1aGTV05FKZXUBwA+pJHDVpYegq9A+zxZE4weXIDJX9ZG4ILkSVAHdL3TqugNuTTJ8KBvVihLVxgoPd1pvhj1+IWt00IUmwzVn1xrKmcQ5yu96YrtgNhjTeUpjhd8rgTHFAZL3iEQu8xZxLuFh1Pak3FO6w8crTX8ryF03ell5nLnlnWesvJmKqpp7u9uynBzHV/jcwhUSeLq9PIE6vrpPuaGQuk19U56LXuu4J7hBePGA1CY9jRRfQ/FH31g03l3/xn/uzbpDswNgDOrUxw1iinE0pjraTY5CYxJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bULUEMd590ikObpv4WQrPTOAOgjCIgU2Vryb6sCI+Js=; b=ZBGFWCXxLcZy/7ivyg2vmeWPMvGv3Ing/73OAxel2XQk057Xj2/M8Q2OCo9kR4aNb4U2f6owXOMYDvK0EKUmicBNwjFPq2U+YP4Zs5CQbod3SmJaGbdkFLl3NCOQe4vXVZCR+F0LGiZ6yEUDsm2gf317FhQsDNCyUNJ285DWS10= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VI1PR0401MB2493.eurprd04.prod.outlook.com (2603:10a6:800:58::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb 2022 01:53:43 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d4dc:8c9a:55d0:81d8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d4dc:8c9a:55d0:81d8%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022 01:53:43 +0000 From: "Peng Fan (OSS)" To: jassisinghbrar@gmail.com, robh+dt@kernel.org, shawnguo@kernel.org Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan , Rob Herring Subject: [PATCH V2 4/6] dt-bindings: mailbox: imx-mu: add i.MX8 SECO MU support Date: Mon, 7 Feb 2022 09:52:09 +0800 Message-Id: <20220207015211.394297-5-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220207015211.394297-1-peng.fan@oss.nxp.com> References: <20220207015211.394297-1-peng.fan@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2PR01CA0152.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::32) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8f574073-41e4-4e31-bd7a-08d9e9dcabaf X-MS-TrafficTypeDiagnostic: VI1PR0401MB2493:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1850; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pb/a/6/tEoBkYXA9anLjVhzcUE9iRyhkUyCx0qgREiAUBf6iR6+gETNf9NyijUaqbcEW+y/d2QQaOXfEbXmzUy7aB6YJdHiBpKCQygn7UEgzPOE5bYhU6d9DSgWsJ0SkvEIszn/0DJgV3h9owOpO1q74lazzlGNDAwLUXrldjncoddLY/y6CCsDuo/x4cR6upzwjZfo1gDdsX7MDpQmbGt5PQYQGZOJ+8K9hMz7OL+6cKyiPtPR7nhbzR6X+b8XNSAEtlYkxxkJcu07FkV836M16imj0OAAGx6eXzpQUGVi0Uwo2wUbx7P/dTWvXTyxA+hm8QD+DCi9PxvGCjmh0Hf9omwMZQoeAkPqqbwh+V305KfDtWRcchmE9NReXbzi42n6Cz4PJF/4RbkvyOGeBWXbqSM+BqK7WYbC3ww1ks5qGd5SonmC3faf/O24uUJLyMSlE9Kuo4zE5ta63utcVaR6Ci/hYSXKwRtI8KtUgDraWZCxaUQwdjJ8dw8wp4l8Rus4NK7oSTH9x2p2AxmmZHq4YyfPZHCGxDnLLXd44WwwC6vPncUAQH4jIMIPpvpDrUvUXppchNwQkQzB5HzP/BzUh/qVI8/r9LhpGaDanwXRlWsSfiBMvRqY2WcSGzmzAup+HrDfD2P06+MnT06wkruR82a6HOTkCnV6zI7jXBcE17RodwqaLAglDid8aszFx2egd8WHs3WfMiYSaC2lD0w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(52116002)(1076003)(6512007)(6506007)(6666004)(8676002)(8936002)(66946007)(508600001)(2616005)(66556008)(66476007)(26005)(186003)(7416002)(38350700002)(54906003)(38100700002)(2906002)(316002)(6486002)(5660300002)(15650500001)(4744005)(86362001)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yQIJbbtjt20DyaRTCbVXpy/9watyjn7f2oeNEjtCiI86sh1813gBCV72qvs4?= =?us-ascii?Q?m0Sk0NIcO7DbGMA/GpNbTuSQEpq2mQGMd8mjbgZtHwY+dqK27CgBAFxHCQPo?= =?us-ascii?Q?kqJvBcVyoxY0PtO+0I6U7y9rw52IYlkhJXyoFIbhj7AkdxvllbY1sQeYSqyC?= =?us-ascii?Q?30cHxEo66VQFFKbdAr72dR887nt3nH4zsSpIFrmsJ9yHnLX9dHXcLIsdKth9?= =?us-ascii?Q?Qtve7VNyk8o4i65myZXDY6ETrX9Bn1/edYpLZSpWa0S1gD+hP5Cn4pSKpYMT?= =?us-ascii?Q?aA9SWPULrsGeNg6d0qdHFJ+lGFvRn2wOmZd/cL1VI/j9HXzuSrWXbGpFBVtK?= =?us-ascii?Q?u9xuaxgvPNVV9NBF80L3fE+lrgxosm32mJQFQz0yHBD650qTEr6XmRTFrZ6x?= =?us-ascii?Q?SLQC5oeKxw51HHH6BUrPpKcJBwztU0vGwJb1VWJJPd60uFTqdchnNY1g4zPd?= =?us-ascii?Q?7QpYCA4JLXd0BMMp8q08VelcQOElNaA28iVPRvTD7CkC4zyJVvB82p7jRkE5?= =?us-ascii?Q?dLQNy+/vOoJlZs32OmyCbWnHD3IQ57Z3uLp5ebMRlUPxTmiBFg811XMt5Qjz?= =?us-ascii?Q?YZnY/uVEJQZA9u6kK4u44re5hJ72NrpcyX6dy8qfVE2X236dNrjAmzwO+yTs?= =?us-ascii?Q?mLMTkjC3SFDb1kf2vGErzS3fZUkObz86qfuUFPtlPfx4k0rDtzwGAp0VsH5e?= =?us-ascii?Q?3nLlxc7UHoHrix1vOK5jx+07oYHnFTxEBzMCvwZWQX+1Q2OdbbhdrLil84+a?= =?us-ascii?Q?oWKO0ZaPBkUpMQzeB3XyiHW0rac9jYJFzoWTwczC6GJW/6jEQNWvJL9nzrUo?= =?us-ascii?Q?MbdV+nUJ6V7CrQjpmsvXj/Rs3Ir6jcmdp2qJIHoKM1m6qdxkRecGIrYy65ko?= =?us-ascii?Q?bvhS3gTiUU8Rxcr/nCzvF916yx71kcyaAX+5BK/I6g7fUgxTSnxYt5z+FxnU?= =?us-ascii?Q?/Q6ZaVQo3U1UqOZDU2WnQGSIswX8cfAjOeYJwh0dq3I1GjqEhFpzHjZuTF9m?= =?us-ascii?Q?k2iuUdYNUjW3M77fMFEMfSdzuqgkinML72W7SaQNcrx7d8+gNmxG5WiIgXrR?= =?us-ascii?Q?CJLVG7f5uXK47eTOp8AbHj1Swjcgn3yhA2F/tv2ZxVW+8hsH5/2tpT0L/q2D?= =?us-ascii?Q?CXSJBY+WfiL/m4uqlzkYBiyONl4CxBGZuZyKJkgiKdIKjjPlFBAbjLmM896c?= =?us-ascii?Q?pdd0hSzTwUtcn6X5bj2+TpSEEG2wPNkpGMgcHbiZ65MH4BVpevsTJJHs0lBZ?= =?us-ascii?Q?0BGAm2HIdep80MjW7izKRQQQopURWKeeBPSqDulCGiDy7qV2TXcDZ6q4L4hx?= =?us-ascii?Q?3QbqdKD9VWGNN4GitocsMHUCAzbEidQx9iibERprVl2Oa44Uw55tDNCYZxPt?= =?us-ascii?Q?8pDxMEn0IMTFC6KbIHlAwroK2HTYuE0+pPnV8AdmdPDGWs1W52+ZY+gOVBRD?= =?us-ascii?Q?qkal9hH3d4y5dAYbI82BERWg3PwGjUVGa2GGZ9ccrNANbEOWdxYMRHtqm9CQ?= =?us-ascii?Q?LiPdUs0uSsuC0wZGoh6oLqFFyavOlKTQd13Pg8P1P3U71VEWmScKjMvhrhAA?= =?us-ascii?Q?3x3l9xhn2zjhVJf1Qo/IeG1EhnjwqCvdpZjzf3krjj8w5vTkHX5mji9X7CHb?= =?us-ascii?Q?okmBZE4enm7ZPJ1T/1XSo5o=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f574073-41e4-4e31-bd7a-08d9e9dcabaf X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 01:53:43.5570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5jG6ObUi4iwzdPuJqaSFuoq6G5T7Egf2kzhYqr0PQX+ok6D3kYCgHhwYBn0sf2CKmIh7YXx1BKXvfb66nvUz9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2493 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Peng Fan Similar to i.MX8QM/QXP SCU, i.MX8 SECO MU is dedicated for communication between SECO and Cortex-A cores from hardware design, it could not be reused for other purpose. To use SECO MU more effectivly, add "fsl,imx8-mu-seco" compatile to support fast IPC. Acked-by: Rob Herring Signed-off-by: Peng Fan --- Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Docume= ntation/devicetree/bindings/mailbox/fsl,mu.yaml index a337bcd80c4a..f865b806ae6a 100644 --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml @@ -28,6 +28,7 @@ properties: - const: fsl,imx7ulp-mu - const: fsl,imx8ulp-mu - const: fsl,imx8-mu-scu + - const: fsl,imx8-mu-seco - const: fsl,imx8ulp-mu-s4 - items: - enum: --=20 2.25.1 From nobody Mon Jun 29 16:47:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3550DC433EF for ; Mon, 7 Feb 2022 01:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348542AbiBGByC (ORCPT ); Sun, 6 Feb 2022 20:54:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348528AbiBGBx6 (ORCPT ); Sun, 6 Feb 2022 20:53:58 -0500 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130088.outbound.protection.outlook.com [40.107.13.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17BC9C0401C7; Sun, 6 Feb 2022 17:53:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LRdLO+10Lcg4VbDVjNwHzxETlhjwZmlN/7379V0Q6sIHh8lNeKkPxWxgVyac1ynwjvWK1l+XGMzhrwe4LGLPP+s5nhFdMuBqhOQ0cpfqR6NjshvgIhaBBdbgv8JGhTvkKep3UCOC3FEBeOniXsjspXc6T4Vf0Pz+QMOxdJjqQOBTea9cFm9taOMNNJfJ3qMtuMJQPZxPRkpMxdafJY2wgQABTX8MfX3KWagYZvdMD12InpKGDKASodwv1zwcGq672Wk118p0gfjDNHL+3H0IFa48aynG2KK7zLKBLZwbIO0k1pIPIt2T341gQKy/TQPM8t26UHDI7TeO3vkY5qYpCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=epRTnvLZv6luqrscflz5l4WxjNfOVfooGjuIuM4az9M=; b=XtFSCb6tQ2NI9xofVkOsI4tvE5fjVQaizIwzcHazD2EYWpZ1mHmYAKI2Zy+OlqH6/C8oQhS78VocaUx63n6jNyeEGMCtpxs3z7kBT4cg7faLWKWn/Cuyc8+TQymbNpBF0DBE4h8ch2ghTrUXR4MXPN3pgCdjCpwvSZQNltD7zfXcfnGVrR8yqHoZSCsDgCS9njjHUSo2JjLVzXYGGA35dbuQQb+naVxLa54LjnNiE0F6bzm/K9ef9+CUUJ1Ey6wTtF2b4Qfx12jdvS2QKlZeM1fQgzuyVpV/ahTs+kNwM06QohDFkcXPJcDxwqyr9N/T8Pty+ixCRAkbyRRc5aDU7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=epRTnvLZv6luqrscflz5l4WxjNfOVfooGjuIuM4az9M=; b=Yo7IhJj8BF1sG0AB6NjMi6AtYSzFfpwtdM4ftrdFMWVx8Rgs/CUFqT4yKJCHU1T3Eh/rC+zzi3BOEXvN9h4IJyif7z0SZArT8SH0QGogu98SCrEl3GB9GqXIzSvZoDU/Bst3pP7A+zSkpFLeB6PF6qmnTOvBSNejXcImi/ZeDAI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VI1PR0401MB2493.eurprd04.prod.outlook.com (2603:10a6:800:58::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb 2022 01:53:47 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d4dc:8c9a:55d0:81d8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d4dc:8c9a:55d0:81d8%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022 01:53:47 +0000 From: "Peng Fan (OSS)" To: jassisinghbrar@gmail.com, robh+dt@kernel.org, shawnguo@kernel.org Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan Subject: [PATCH V2 5/6] mailbox: imx: introduce rxdb callback Date: Mon, 7 Feb 2022 09:52:10 +0800 Message-Id: <20220207015211.394297-6-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220207015211.394297-1-peng.fan@oss.nxp.com> References: <20220207015211.394297-1-peng.fan@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2PR01CA0152.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::32) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 95785d6d-2a37-44f5-07cf-08d9e9dcade3 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2493:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1122; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J2eCG27bRcS4jEHcD+s0+vAceyk2LI2cnik1nd6BRSi1z2p5UfoL2jjGn8iYc4fj2YDUK4I6hKgXA+WSVGeOTS/zUzmdCXCGF3sOrCvR4etBNBRZA3fS4pw6MVK3Slq0IQXgffDGFdkAZIUDXkuJctx04JtJNAdEULVGw5xtz7JWcoIqvzR2AUesz5wiaWDe96O1bAYVxLmXnADO3vgd0T7LO+aQV08wpZAp4gMoVvIhLurfrDmr4H4ha4GYupwgm3fWkT7knjYDMNqHP7srl0V2I52rkC21bEV0LFBGVfGSQgscQMzfGfr6vD0EKFvCPoie++7AvbAkIFhk5zJWjTU+t4LDOG5dQpf7FHRH0c2lMAkpHqb0CbEjbAZGqGRaqy320mFBRwicUO46cmmogJ+/NQWM+FubAu+wVDpe6OPRdLAU7Dh0yEqxoVTpmP5lFRRhrb1RoBOAQRxlwkkR0Qz+ALxU9IfiA2VfhPMXOed82QeeG0viA6a1xSRTWSY/6nvHAvX8PKybO7jc3aGm7uEHyJdVPz3Yt30Q1xJ9WMB3XKNEMVafD/2B9HbYMGgeH0+iz6SD4eG0GEJsHs1kuLzlHEgFYp8XOOZolLY4URFMLDyRRLIfDExBIFZHA4a72VZC0faSXeMQmxpC6M71FYRBd93H6aENSKXFppYYPe5DT53NUbsQHa1ZosFVGz6RBvwvRbM/FqHq6Sq+ZW9DVw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(52116002)(1076003)(6512007)(6506007)(6666004)(8676002)(8936002)(66946007)(508600001)(2616005)(66556008)(66476007)(26005)(186003)(38350700002)(38100700002)(2906002)(316002)(6486002)(5660300002)(15650500001)(86362001)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aXKtVtVz6xL5eT7DcKpg2VwpmLbrGXWm8wDkTTBYpX7lE4y4aWnj9f2P4NKl?= =?us-ascii?Q?xihfSrYarFNyEKeExAHlhrn3nRZb3ubiKdNwpnpxMIMfz/AGRennfGZI/vwH?= =?us-ascii?Q?62zVKwuop2npLv1ZyV0Vad+66jr2ZCDKjCRlMKZj4H15fJM3xi38hkar/LLx?= =?us-ascii?Q?ceIC0jpMHS/Zj1aa/3bEApjzkGQ90PcshaE6jZnW5k3rckLOVMIe1AJZZAK3?= =?us-ascii?Q?rceAzLr+XbMfz4SpxIu0JL0QZIEjQmLEmDvXleUbQDksTD9M81vIMUB2rOs/?= =?us-ascii?Q?KlUEb/7TE1Vp2Mb4LYiYMonlB6ArzF2hizUW1yUkT2FXZ1yoLF6+A90sFhzg?= =?us-ascii?Q?xXpm+YOSLMeEOD5/eJz+RXfEvZGT/9qqkdvtsGRyEnH9Yp0p/bJYlTyaiPfe?= =?us-ascii?Q?50+j3rv8QC/vRwJLJXragRRx/0y6eW+SjKCW7ODd+G40P51FA744VZ5eJfPw?= =?us-ascii?Q?h0QYIXoppuRL5bChi59cvbGzvDNw7+aWt7qotlHnlB33AOGudfmbPGCZJq1A?= =?us-ascii?Q?jVqrz8iXYp8WA61EPlZ19SThzN6fTD5dyRmP/BaZZkeKCx/0AN+n3Oip4K4C?= =?us-ascii?Q?Wo9dWBsQZsh0d3ucefKK/aUdgGiB8KDPNP1iMRakAsQAG8AqInj0Z5bjnGjS?= =?us-ascii?Q?u1z74X0i2XnH7SvMgrMutoxqyLrJKeVDUGd//5hnkQ31tGh1nSFNoyfaeq5x?= =?us-ascii?Q?PjtgJF0hr0qB55MsJzRbuA30qBF/6XYPdqpQhZFi+ESlepBNRhcPmWkjpXsP?= =?us-ascii?Q?zzJefS6/L60uxBR445ql6F6SwuN9ZWqjZTTZnzXjanlVFPbAYexxMOEp02Jw?= =?us-ascii?Q?04D+gmG/ZHxKHzy9wSlMwxVbVhpSgrvwWkqGWGlOl1V6N6P/xL8kpoCTHU3i?= =?us-ascii?Q?eyCcU8vdmREq/idom44Ttc+joQhWZmbWHtu/ebxaMJlTsllafw/zPTuq9vNO?= =?us-ascii?Q?ZH45DqcOICEcZuRGLVjw816pe7XxjdTBFqDXctu04rw8gsBbC6pV1oWqmv+U?= =?us-ascii?Q?ViIUXim4v/ih+sJ8h6N3fX4qlEzajnbODJxRKFZZFjMGimZFKYpdAkMOKbu9?= =?us-ascii?Q?TcdxAuyuC8tpNm7iqMm069RlH+Sy7NWFqtjk/PJ8tnWCwAM/1i9vF/PVsSDR?= =?us-ascii?Q?PxRbxQZegAv3aTyUvnPbqZNGVSKEYu87O+vRYy1EkW5aH8Ti108JEeUBbwEU?= =?us-ascii?Q?cSbR2+xrG+fdIMh9h1zJ+g5SEElE8jqzYVlVv1dyW6rbfjXLM29Gn++vzuad?= =?us-ascii?Q?sZtqHKt2TtKulIlXCNxo41QNff0YChmVN7D3Pm2iDCcKYYd3PvWP5v2vY9R8?= =?us-ascii?Q?74+q/+9SIm0KsXSYgTwBvCA6R7/ei3+08ayTg1gKRkPqkV4GIKjBc2gZQCIk?= =?us-ascii?Q?U/pGB8lDi86Y88CIbq7MCbfQDsXY/P7OnHLmV/5R+/hXvduiThGkTGExDD6d?= =?us-ascii?Q?Zp33GjotPVfyvcOLSvS5bc1Bds6mrF+8pC74yGDcAxizXiWfMTtCDEo6Il4F?= =?us-ascii?Q?jV04Mn1q+yQVfOoIk3+b+QUuBLBgAPfLVHsGSE4wJHRfVOHvPb5ZX0BjN15u?= =?us-ascii?Q?jqcwqrefJECYGeMTrOOcUNXKBRhiFXJb5rwK57qnteiC4ncjitGTtRAQWHAl?= =?us-ascii?Q?FcaQx0ilfWtJ9mKNKTkXJLQ=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95785d6d-2a37-44f5-07cf-08d9e9dcade3 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 01:53:47.0945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x9B+aUFXHWU2eI9OXvgw4mMGN3SHTUwM4WqR+44PieUvxVfRMsHkNYAi0wUhrRQp4YGjfGRc9qvvNGwN0v6Pag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2493 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Peng Fan Add a rxdb callback to prepare for i.MX8 SECO MU rxdb which has a different logic. Signed-off-by: Peng Fan --- drivers/mailbox/imx-mailbox.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c index a29f8006ad0d..399e12671bad 100644 --- a/drivers/mailbox/imx-mailbox.c +++ b/drivers/mailbox/imx-mailbox.c @@ -93,6 +93,7 @@ enum imx_mu_type { struct imx_mu_dcfg { int (*tx)(struct imx_mu_priv *priv, struct imx_mu_con_priv *cp, void *dat= a); int (*rx)(struct imx_mu_priv *priv, struct imx_mu_con_priv *cp); + int (*rxdb)(struct imx_mu_priv *priv, struct imx_mu_con_priv *cp); void (*init)(struct imx_mu_priv *priv); enum imx_mu_type type; u32 xTR; /* Transmit Register0 */ @@ -179,6 +180,16 @@ static int imx_mu_generic_rx(struct imx_mu_priv *priv, return 0; } =20 +static int imx_mu_generic_rxdb(struct imx_mu_priv *priv, + struct imx_mu_con_priv *cp) +{ + imx_mu_write(priv, IMX_MU_xSR_GIPn(priv->dcfg->type, cp->idx), + priv->dcfg->xSR[IMX_MU_GSR]); + mbox_chan_received_data(cp->chan, NULL); + + return 0; +} + static int imx_mu_specific_tx(struct imx_mu_priv *priv, struct imx_mu_con_= priv *cp, void *data) { u32 *arg =3D data; @@ -329,9 +340,7 @@ static irqreturn_t imx_mu_isr(int irq, void *p) priv->dcfg->rx(priv, cp); } else if ((val =3D=3D IMX_MU_xSR_GIPn(priv->dcfg->type, cp->idx)) && (cp->type =3D=3D IMX_MU_TYPE_RXDB)) { - imx_mu_write(priv, IMX_MU_xSR_GIPn(priv->dcfg->type, cp->idx), - priv->dcfg->xSR[IMX_MU_GSR]); - mbox_chan_received_data(chan, NULL); + priv->dcfg->rxdb(priv, cp); } else { dev_warn_ratelimited(priv->dev, "Not handled interrupt\n"); return IRQ_NONE; @@ -639,6 +648,7 @@ static int imx_mu_remove(struct platform_device *pdev) static const struct imx_mu_dcfg imx_mu_cfg_imx6sx =3D { .tx =3D imx_mu_generic_tx, .rx =3D imx_mu_generic_rx, + .rxdb =3D imx_mu_generic_rxdb, .init =3D imx_mu_init_generic, .xTR =3D 0x0, .xRR =3D 0x10, @@ -649,6 +659,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx6sx =3D { static const struct imx_mu_dcfg imx_mu_cfg_imx7ulp =3D { .tx =3D imx_mu_generic_tx, .rx =3D imx_mu_generic_rx, + .rxdb =3D imx_mu_generic_rxdb, .init =3D imx_mu_init_generic, .xTR =3D 0x20, .xRR =3D 0x40, @@ -659,7 +670,9 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx7ulp =3D { static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp =3D { .tx =3D imx_mu_generic_tx, .rx =3D imx_mu_generic_rx, + .rxdb =3D imx_mu_generic_rxdb, .init =3D imx_mu_init_generic, + .rxdb =3D imx_mu_generic_rxdb, .type =3D IMX_MU_V2, .xTR =3D 0x200, .xRR =3D 0x280, @@ -682,6 +695,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8_scu =3D= { .tx =3D imx_mu_specific_tx, .rx =3D imx_mu_specific_rx, .init =3D imx_mu_init_specific, + .rxdb =3D imx_mu_generic_rxdb, .xTR =3D 0x0, .xRR =3D 0x10, .xSR =3D {0x20, 0x20, 0x20, 0x20}, --=20 2.25.1 From nobody Mon Jun 29 16:47:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5214FC433FE for ; Mon, 7 Feb 2022 01:54:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348423AbiBGByK (ORCPT ); Sun, 6 Feb 2022 20:54:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348257AbiBGBx7 (ORCPT ); Sun, 6 Feb 2022 20:53:59 -0500 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60087.outbound.protection.outlook.com [40.107.6.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 629CDC0401E1; Sun, 6 Feb 2022 17:53:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MQDlzp9N93BL2PrnH/ih1JquqlYDhvB0NO3eG3FBmjkmMrj7/4/tv38kOxihmuD+nxuP7K5zSCwx5Kx2YyVCVcVt1FWQKx71tfBApmbnv8ofq1gZsSzq7cCofzc7ejbEsKEOlRSRZBcO/LYlO9g6+ErbUkaM1riopUr2oxBnrw6LIzciRPgysTVmR+jOn88PBBIq52v5YuSUcpj/tSA2G95kuPmbABFhXEhs7EfO2oUb2RPrPVbSFPFuvCT27WQ7NIQzdLT3Oc99H5Vbn3KBIQ2lftTWFUXF1gmHdhyq4VqszRdxdjDKvHHYXAPkKHoyc1dKrN/cmop+BUpQkGXDjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gyepUu0NxG2JjUQwtj2TBBTs6iEw3DAYCsM6kKJSGvk=; b=hxIgcoCXKwx0s7KQQMmD8GggrztwxhzwbaCVnma/3tMlCQMQ8CAXCee98u+dTmgWnFr6p30DrVEZRyG0XI2dHeOt6S2VlTxsCSZU/NoVRMqMumKNAEsDw6YZ/NtEfdgqx/j9z3yo3cW8fSNVTGE7jfL93Af7teMNe5yJdlnlMx85Va27xOsuNKyMReG+8B0SSQWiLkULN6GxyvgNbddxNqdP4cpkDRohACDrRhtuqTLEtTQUn//GfDFX9cpumu7Nh1QCSiQwv46kfcT6/on3esPK/iBxXHGgAXr/v4PPiFAhqiaUlzvaUuD0c+mP/FHCmfykRP+I8s01+qArQVijYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gyepUu0NxG2JjUQwtj2TBBTs6iEw3DAYCsM6kKJSGvk=; b=FClHOfopT1Pv2zyxr6GoISXWhG+3zeiJsXEn0o/ffY6+DbyUj4aIVX18eggw63UF6CGnGpim349pgz8rKCjpQF4G/a6XYACe2dclFKcCCkIa2H2UtocQCOxhfo1VKGX0XOvGLNFaD4JKqstGClOKjoP/KnGW75h+KH8GW0X21Xc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VI1PR0401MB2493.eurprd04.prod.outlook.com (2603:10a6:800:58::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb 2022 01:53:51 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d4dc:8c9a:55d0:81d8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d4dc:8c9a:55d0:81d8%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022 01:53:51 +0000 From: "Peng Fan (OSS)" To: jassisinghbrar@gmail.com, robh+dt@kernel.org, shawnguo@kernel.org Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Franck LENORMAND , Peng Fan Subject: [PATCH V2 6/6] mailbox: imx: add i.MX8 SECO MU support Date: Mon, 7 Feb 2022 09:52:11 +0800 Message-Id: <20220207015211.394297-7-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220207015211.394297-1-peng.fan@oss.nxp.com> References: <20220207015211.394297-1-peng.fan@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2PR01CA0152.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::32) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f7ca713d-20a3-439d-c3da-08d9e9dcb024 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2493:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p1/DzJUupUzuqLimBHs1oNtyq1gP349wnYWP9Q25y4vQI1UClWrnzXnZ4IqfCGocNtGa/BqUPH4Gq25B1/r7qFCMdKiHg2d2i6mxibmwLhvG/3PjzpzKAS39Lf358s6bvQ/hjQPZS0bxASxEzhgHrQfRUT107JNjGotHyNUZZyMY0XOn48r0JurhqDtN8ni3dcTs7C7JCZI6fwtIr7DG5Bvmfq/qTE1T3mDTe9sCMKznDIaHgWdk+im/yGwDLHSA3d7HhA1aTKScfhjBkpQeUct9hXD04/QwPsIIzIDaohk2dfucqQC4yUfVheCIE6Lm+ZJ+iVBEGGU2UJ6mgiYQuq/VoTCsGGSSu2DK0YKt+KHtLY+SCj7l/DmIhppZhaHey/SQtbMAxv7EVf16zWO5VQrRykx7E5HVu1gdo610gVY7tBMKh6S6nGXNR3Mv9iC0hzHs7S+hxnvPl4TxVkopePVTi9+P9BGSvlWzfM/z4Oy+OAx1praydNe73WMuVp6kHzXz7tcBJTWNuzG2T6cGZJO0KvFYmqsJDlI2HRszL14ZhQVibqieYc7oNRoZ/HKHP88AotQEBKAZM9632gGwRsQHIbAd5n2NGRsfT90xmFuQXZC1NXHAPiKz7SKQ+/4AfvxVweNwP+QU5AeEGgUFMzbLNDdMwBlPxPKzMT9rn8sRPzFJjLCAFRd7Pru7lFsFRceuEh2dhwiN1A3WvUKjXA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(52116002)(1076003)(6512007)(6506007)(6666004)(8676002)(8936002)(66946007)(508600001)(2616005)(66556008)(66476007)(26005)(186003)(38350700002)(54906003)(38100700002)(2906002)(316002)(6486002)(5660300002)(15650500001)(86362001)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8ZEOhnb2qMxlhiQOhoRwmGe38zS48l52yyJnlFH6Huy5jCzS4K887OOXfL7d?= =?us-ascii?Q?I8jcRBjKGsGIyh18ruheELQv7afzPw5aQjyCusqMY6EXh45GecgwCvvZ3iU6?= =?us-ascii?Q?rQ7XxvUoS+t1y/SnZXmADC00UtHSdoUQoCbIqK9pm9qp6b4ZTqz35Fw1k6xV?= =?us-ascii?Q?U22FekxJMUx9Y4I2t5zfAprLHhsG1ZcxtNx2P65vy93W+fKKkP7ztkmXZqbO?= =?us-ascii?Q?O/C2QDU1HencrwBySdKYZNVZD3xC2aAVyCIh+FD/6j0IZFEKdSsZ/LEL0s5X?= =?us-ascii?Q?FpsFRwAqqzaTx+RLi70VP2TkJo+N93aPiIwXMLi7YZseke4ACpM1xE6ADyYn?= =?us-ascii?Q?xDlMqcgMoUk/AjkJJ+6HBfQ870dt5M5ReJy+stsPWateM70vZTnKglO+kaz6?= =?us-ascii?Q?RMyRkTZxvf0EtlrS0U2zNhLCk4aVYVs1odsJ2C/aalbxT5kcmVuNv5va6kQi?= =?us-ascii?Q?HGS7VQaztUZJ0DIhNcJDAaYI5StEMbjJxmM/jSLg5OZeEtT+Y+vhlF7wEF9+?= =?us-ascii?Q?tOoJGHPZA6mt15ANha3Fi3pbBDWeFeXWSAsMA/96YMouc3jwhCBhvlTERTvF?= =?us-ascii?Q?FNkp30XtD1xBB1a3zv5QaCLRYW8jh6eibAmSZHVNn/TiIrKPCmBi2YJAZWAg?= =?us-ascii?Q?5GWA8DtkC7tEZ4pdiTzfMQPuE5m8L0CByERP8UFpIqKggMXn7Z0fD6sJ7IdE?= =?us-ascii?Q?CHgFSpTy9CYHVtk/UAZ5VZOQn5ZGtm/ZsHCpFWbBgmTwVMktt27Y5tFAbQPl?= =?us-ascii?Q?pXvmcxnOzlr4IKkV/IEK4iT66rQqz9hi6Uo/aCx+OTgHLugqObXiKot+FwRw?= =?us-ascii?Q?mz1T0OD2CEbL9gEuGXjw8sD5BJMedsSgle4zuPZV0zO6jLYHEpgdlX2FOj53?= =?us-ascii?Q?AEkYdmapjXNXyl6DuFv28qC+KHsMyzG6K7MPgqkmlzp2/X6jtwilIP2sABbe?= =?us-ascii?Q?jKYR04GXxKUPEWyzzmkAlvQYhQLfP8NFnYCzQBmflBqZ/izUmTgVDm5b60Z3?= =?us-ascii?Q?6nKQ59ibX91MEOJRctjiFNbuoilN02X7AyMiDG+Kxgd87vlQe6wEFx9TLFVo?= =?us-ascii?Q?mr59622Adg02tQj7RJ1xx9WnRhy8HjywXXQjZXbAMV/8YlKgPlG+PpAeiyZT?= =?us-ascii?Q?eQD26Nkc7d/VT4bo5+PmsBQWy/+133Ef+yldKavtvU3fopd0JVqanlVB5d96?= =?us-ascii?Q?TW7hygE+UVQKF+R9jVcWAF7ywrN0N55OLcTZE3PBCdC6VAdgO24sHG4tr++Z?= =?us-ascii?Q?8dabi5HH9CXFK9bBBp8Q7i7MPPzaaeHwWtGILRzrLkDbCu+t8XAfoJ/IOdwk?= =?us-ascii?Q?t2K1qQN1v0tGbmpUG52CZnhFdQ3eqgeG48xbkbjf8EtQncwROeqolA4VqOHa?= =?us-ascii?Q?MhgeIAJk/egNpw2TplEWrS65K9VU6XCx5ZSwEii1GKM9exjOFp5EQ47NQHNn?= =?us-ascii?Q?a5E71eaTQCBFTwEsNxYqud6ZqfiY6vYrH5aoTGJAC/DtI5pVSpvfLsQPMUIV?= =?us-ascii?Q?9wQM170Psj/qa0BSRKeiiGR0P9aKe7D8tQf7icXdrwF/ZG5PrUDjhJkyAoK8?= =?us-ascii?Q?/dgCPmoBKpJUdfUBRCVuk4QAtgfgzopzs3y73+EfnmKYQH1kNbYqFTgH/zqt?= =?us-ascii?Q?4vvlN/gBbfuBxsSPy+s0G/Q=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7ca713d-20a3-439d-c3da-08d9e9dcb024 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 01:53:51.0348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FasGpMNupv6LrsCre1jUDi4o1/i77N7xILFf12erHHICBiJJfWWmg5gedMw8fW52GErihR5S2jlLdGIXjr6N0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2493 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Franck LENORMAND i.MX8/8X SECO firmware IPC is an implementation of passing messages. But current imx-mailbox driver only support one word message, i.MX8/8X linux side firmware has to request four TX, four RX and a TXDB to support IPC to SECO firmware. This is low efficent and more interrupts triggered compared with one TX and one RX. To make SECO MU work, - parse the size of msg. - Only enable TR0/RR0 interrupt for transmit/receive message. - For TX/RX, only support one TX channel and one RX channel - For RX, support receive msg of any size, limited by hardcoded value of 30. Signed-off-by: Franck LENORMAND Signed-off-by: Peng Fan --- drivers/mailbox/imx-mailbox.c | 213 +++++++++++++++++++++++++++++++++- 1 file changed, 212 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c index 399e12671bad..cd011ca5707e 100644 --- a/drivers/mailbox/imx-mailbox.c +++ b/drivers/mailbox/imx-mailbox.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include @@ -24,6 +25,9 @@ #define IMX_MU_S4_CHANS 2 #define IMX_MU_CHAN_NAME_SIZE 20 =20 +#define IMX_MU_SECO_TX_TOUT (msecs_to_jiffies(3000)) +#define IMX_MU_SECO_RX_TOUT (msecs_to_jiffies(3000)) + enum imx_mu_chan_type { IMX_MU_TYPE_TX, /* Tx */ IMX_MU_TYPE_RX, /* Rx */ @@ -48,7 +52,7 @@ enum imx_mu_xsr { =20 struct imx_sc_rpc_msg_max { struct imx_sc_rpc_msg hdr; - u32 data[7]; + u32 data[30]; }; =20 struct imx_s4_rpc_msg_max { @@ -131,6 +135,55 @@ static u32 imx_mu_read(struct imx_mu_priv *priv, u32 o= ffs) return ioread32(priv->base + offs); } =20 +static int imx_mu_tx_waiting_write(struct imx_mu_priv *priv, u32 val, u32 = idx) +{ + u64 timeout_time =3D get_jiffies_64() + IMX_MU_SECO_TX_TOUT; + u32 status; + u32 can_write; + + dev_dbg(priv->dev, "Trying to write %.8x to idx %d\n", val, idx); + + do { + status =3D imx_mu_read(priv, priv->dcfg->xSR[IMX_MU_TSR]); + can_write =3D status & IMX_MU_xSR_TEn(priv->dcfg->type, idx % 4); + } while (!can_write && time_is_after_jiffies64(timeout_time)); + + if (!can_write) { + dev_err(priv->dev, "timeout trying to write %.8x at %d(%.8x)\n", + val, idx, status); + return -ETIME; + } + + imx_mu_write(priv, val, priv->dcfg->xTR + (idx % 4) * 4); + + return 0; +} + +static int imx_mu_rx_waiting_read(struct imx_mu_priv *priv, u32 *val, u32 = idx) +{ + u64 timeout_time =3D get_jiffies_64() + IMX_MU_SECO_RX_TOUT; + u32 status; + u32 can_read; + + dev_dbg(priv->dev, "Trying to read from idx %d\n", idx); + + do { + status =3D imx_mu_read(priv, priv->dcfg->xSR[IMX_MU_RSR]); + can_read =3D status & IMX_MU_xSR_RFn(priv->dcfg->type, idx % 4); + } while (!can_read && time_is_after_jiffies64(timeout_time)); + + if (!can_read) { + dev_err(priv->dev, "timeout trying to read idx %d (%.8x)\n", + idx, status); + return -ETIME; + } + + *val =3D imx_mu_read(priv, priv->dcfg->xRR + (idx % 4) * 4); + dev_dbg(priv->dev, "Read %.8x\n", *val); + + return 0; +} + static u32 imx_mu_xcr_rmw(struct imx_mu_priv *priv, enum imx_mu_xcr type, = u32 set, u32 clr) { unsigned long flags; @@ -289,6 +342,125 @@ static int imx_mu_specific_rx(struct imx_mu_priv *pri= v, struct imx_mu_con_priv * return 0; } =20 +static int imx_mu_seco_tx(struct imx_mu_priv *priv, struct imx_mu_con_priv= *cp, + void *data) +{ + struct imx_sc_rpc_msg_max *msg =3D data; + u32 *arg =3D data; + u32 byte_size; + int err; + int i; + + dev_dbg(priv->dev, "Sending message\n"); + + switch (cp->type) { + case IMX_MU_TYPE_TXDB: + byte_size =3D msg->hdr.size * sizeof(u32); + if (byte_size > sizeof(*msg)) { + /* + * The real message size can be different to + * struct imx_sc_rpc_msg_max size + */ + dev_err(priv->dev, + "Exceed max msg size (%zu) on TX, got: %i\n", + sizeof(*msg), byte_size); + return -EINVAL; + } + + print_hex_dump_debug("from client ", DUMP_PREFIX_OFFSET, 4, 4, + data, byte_size, false); + + /* Send first word */ + dev_dbg(priv->dev, "Sending header\n"); + imx_mu_write(priv, *arg++, priv->dcfg->xTR); + + /* Send signaling */ + dev_dbg(priv->dev, "Sending signaling\n"); + imx_mu_xcr_rmw(priv, IMX_MU_GCR, + IMX_MU_xCR_GIRn(priv->dcfg->type, cp->idx), 0); + + /* Send words to fill the mailbox */ + for (i =3D 1; i < 4 && i < msg->hdr.size; i++) { + dev_dbg(priv->dev, "Sending word %d\n", i); + imx_mu_write(priv, *arg++, + priv->dcfg->xTR + (i % 4) * 4); + } + + /* Send rest of message waiting for remote read */ + for (; i < msg->hdr.size; i++) { + dev_dbg(priv->dev, "Sending word %d\n", i); + err =3D imx_mu_tx_waiting_write(priv, *arg++, i); + if (err) { + dev_err(priv->dev, "Timeout tx %d\n", i); + return err; + } + } + + /* Simulate hack for mbox framework */ + tasklet_schedule(&cp->txdb_tasklet); + + break; + default: + dev_warn_ratelimited(priv->dev, + "Send data on wrong channel type: %d\n", + cp->type); + return -EINVAL; + } + + return 0; +} + +static int imx_mu_seco_rxdb(struct imx_mu_priv *priv, struct imx_mu_con_pr= iv *cp) +{ + struct imx_sc_rpc_msg_max msg; + u32 *data =3D (u32 *)&msg; + u32 byte_size; + int err =3D 0; + int i; + + dev_dbg(priv->dev, "Receiving message\n"); + + /* Read header */ + dev_dbg(priv->dev, "Receiving header\n"); + *data++ =3D imx_mu_read(priv, priv->dcfg->xRR); + byte_size =3D msg.hdr.size * sizeof(u32); + if (byte_size > sizeof(msg)) { + dev_err(priv->dev, "Exceed max msg size (%zu) on RX, got: %i\n", + sizeof(msg), byte_size); + err =3D -EINVAL; + goto error; + } + + /* Read message waiting they are written */ + for (i =3D 1; i < msg.hdr.size; i++) { + dev_dbg(priv->dev, "Receiving word %d\n", i); + err =3D imx_mu_rx_waiting_read(priv, data++, i); + if (err) { + dev_err(priv->dev, "Timeout rx %d\n", i); + goto error; + } + } + + /* Clear GIP */ + imx_mu_write(priv, IMX_MU_xSR_GIPn(priv->dcfg->type, cp->idx), + priv->dcfg->xSR[IMX_MU_GSR]); + + print_hex_dump_debug("to client ", DUMP_PREFIX_OFFSET, 4, 4, + &msg, byte_size, false); + + /* send data to client */ + dev_dbg(priv->dev, "Sending message to client\n"); + mbox_chan_received_data(cp->chan, (void *)&msg); + + goto exit; + +error: + mbox_chan_received_data(cp->chan, ERR_PTR(err)); + +exit: + return err; +} + static void imx_mu_txdb_tasklet(unsigned long data) { struct imx_mu_con_priv *cp =3D (struct imx_mu_con_priv *)data; @@ -494,6 +666,27 @@ static struct mbox_chan * imx_mu_xlate(struct mbox_con= troller *mbox, return &mbox->chans[chan]; } =20 +static struct mbox_chan *imx_mu_seco_xlate(struct mbox_controller *mbox, + const struct of_phandle_args *sp) +{ + u32 type; + + if (sp->args_count < 1) { + dev_err(mbox->dev, "Invalid argument count %d\n", sp->args_count); + return ERR_PTR(-EINVAL); + } + + type =3D sp->args[0]; /* channel type */ + + /* Only supports TXDB and RXDB */ + if (type =3D=3D IMX_MU_TYPE_TX || type =3D=3D IMX_MU_TYPE_RX) { + dev_err(mbox->dev, "Invalid type: %d\n", type); + return ERR_PTR(-EINVAL); + } + + return imx_mu_xlate(mbox, sp); +} + static void imx_mu_init_generic(struct imx_mu_priv *priv) { unsigned int i; @@ -544,6 +737,12 @@ static void imx_mu_init_specific(struct imx_mu_priv *p= riv) imx_mu_write(priv, 0, priv->dcfg->xCR[i]); } =20 +static void imx_mu_init_seco(struct imx_mu_priv *priv) +{ + imx_mu_init_generic(priv); + priv->mbox.of_xlate =3D imx_mu_seco_xlate; +} + static int imx_mu_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -702,12 +901,24 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8_scu = =3D { .xCR =3D {0x24, 0x24, 0x24, 0x24}, }; =20 +static const struct imx_mu_dcfg imx_mu_cfg_imx8_seco =3D { + .tx =3D imx_mu_seco_tx, + .rx =3D imx_mu_generic_rx, + .rxdb =3D imx_mu_seco_rxdb, + .init =3D imx_mu_init_seco, + .xTR =3D 0x0, + .xRR =3D 0x10, + .xSR =3D {0x20, 0x20, 0x20, 0x20}, + .xCR =3D {0x24, 0x24, 0x24, 0x24}, +}; + static const struct of_device_id imx_mu_dt_ids[] =3D { { .compatible =3D "fsl,imx7ulp-mu", .data =3D &imx_mu_cfg_imx7ulp }, { .compatible =3D "fsl,imx6sx-mu", .data =3D &imx_mu_cfg_imx6sx }, { .compatible =3D "fsl,imx8ulp-mu", .data =3D &imx_mu_cfg_imx8ulp }, { .compatible =3D "fsl,imx8ulp-mu-s4", .data =3D &imx_mu_cfg_imx8ulp_s4 }, { .compatible =3D "fsl,imx8-mu-scu", .data =3D &imx_mu_cfg_imx8_scu }, + { .compatible =3D "fsl,imx8-mu-seco", .data =3D &imx_mu_cfg_imx8_seco }, { }, }; MODULE_DEVICE_TABLE(of, imx_mu_dt_ids); --=20 2.25.1