From nobody Mon Jun 29 16:47:10 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5EA4C433EF for ; Sun, 6 Feb 2022 17:59:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237370AbiBFR7o (ORCPT ); Sun, 6 Feb 2022 12:59:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345293AbiBFR7j (ORCPT ); Sun, 6 Feb 2022 12:59:39 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F229BC06173B for ; Sun, 6 Feb 2022 09:59:38 -0800 (PST) Received: from ipservice-092-217-075-184.092.217.pools.vodafone-ip.de ([92.217.75.184] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nGlp0-0002n8-Qm; Sun, 06 Feb 2022 18:59:34 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 1/5] staging: r8188eu: usb_vendor_req_mutex is not used Date: Sun, 6 Feb 2022 18:59:21 +0100 Message-Id: <20220206175925.461426-2-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220206175925.461426-1-martin@kaiser.cx> References: <20220206175925.461426-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" usb_vendor_req_mutex in struct dvobj_priv is not used. Remove it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/include/drv_types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/r8188eu/include/drv_types.h b/drivers/staging/= r8188eu/include/drv_types.h index 987dae613d8b..7e6385109cbc 100644 --- a/drivers/staging/r8188eu/include/drv_types.h +++ b/drivers/staging/r8188eu/include/drv_types.h @@ -141,7 +141,6 @@ struct dvobj_priv { u8 RtNumOutPipes; int RegUsbSS; struct semaphore usb_suspend_sema; - struct mutex usb_vendor_req_mutex; =20 struct usb_interface *pusbintf; struct usb_device *pusbdev; --=20 2.30.2 From nobody Mon Jun 29 16:47:10 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC2CDC433EF for ; Sun, 6 Feb 2022 17:59:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345602AbiBFR7r (ORCPT ); Sun, 6 Feb 2022 12:59:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345327AbiBFR7k (ORCPT ); Sun, 6 Feb 2022 12:59:40 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D71A2C043184 for ; Sun, 6 Feb 2022 09:59:39 -0800 (PST) Received: from ipservice-092-217-075-184.092.217.pools.vodafone-ip.de ([92.217.75.184] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nGlp1-0002n8-Mh; Sun, 06 Feb 2022 18:59:35 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 2/5] staging: r8188eu: dvobj_priv's signal_strength is not used Date: Sun, 6 Feb 2022 18:59:22 +0100 Message-Id: <20220206175925.461426-3-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220206175925.461426-1-martin@kaiser.cx> References: <20220206175925.461426-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" signal_strength is struct dvobj_priv is not used. Remove it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/include/drv_types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/r8188eu/include/drv_types.h b/drivers/staging/= r8188eu/include/drv_types.h index 7e6385109cbc..79ff0b25914c 100644 --- a/drivers/staging/r8188eu/include/drv_types.h +++ b/drivers/staging/r8188eu/include/drv_types.h @@ -146,7 +146,6 @@ struct dvobj_priv { struct usb_device *pusbdev; =20 atomic_t continual_urb_error; - u8 signal_strength; }; =20 static inline struct device *dvobj_to_dev(struct dvobj_priv *dvobj) --=20 2.30.2 From nobody Mon Jun 29 16:47:10 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD8CFC433EF for ; Sun, 6 Feb 2022 17:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345567AbiBFR7u (ORCPT ); Sun, 6 Feb 2022 12:59:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345429AbiBFR7k (ORCPT ); Sun, 6 Feb 2022 12:59:40 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99E54C043185 for ; Sun, 6 Feb 2022 09:59:40 -0800 (PST) Received: from ipservice-092-217-075-184.092.217.pools.vodafone-ip.de ([92.217.75.184] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nGlp2-0002n8-Ez; Sun, 06 Feb 2022 18:59:36 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 3/5] staging: r8188eu: RegUsbSS is not used Date: Sun, 6 Feb 2022 18:59:23 +0100 Message-Id: <20220206175925.461426-4-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220206175925.461426-1-martin@kaiser.cx> References: <20220206175925.461426-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" RegUsbSS in struct dvobj_priv is not used. Remove it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/include/drv_types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/r8188eu/include/drv_types.h b/drivers/staging/= r8188eu/include/drv_types.h index 79ff0b25914c..e3acac56ce6e 100644 --- a/drivers/staging/r8188eu/include/drv_types.h +++ b/drivers/staging/r8188eu/include/drv_types.h @@ -139,7 +139,6 @@ struct dvobj_priv { =20 u8 ishighspeed; u8 RtNumOutPipes; - int RegUsbSS; struct semaphore usb_suspend_sema; =20 struct usb_interface *pusbintf; --=20 2.30.2 From nobody Mon Jun 29 16:47:10 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37392C433F5 for ; Sun, 6 Feb 2022 17:59:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345678AbiBFR7w (ORCPT ); Sun, 6 Feb 2022 12:59:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345432AbiBFR7l (ORCPT ); Sun, 6 Feb 2022 12:59:41 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D91DC043184 for ; Sun, 6 Feb 2022 09:59:40 -0800 (PST) Received: from ipservice-092-217-075-184.092.217.pools.vodafone-ip.de ([92.217.75.184] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nGlp3-0002n8-6B; Sun, 06 Feb 2022 18:59:37 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 4/5] staging: r8188eu: usb_suspend_sema is initialised but not used Date: Sun, 6 Feb 2022 18:59:24 +0100 Message-Id: <20220206175925.461426-5-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220206175925.461426-1-martin@kaiser.cx> References: <20220206175925.461426-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" usb_suspend_sema from struct dvobj_priv is initialised but never used. Remove it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/include/drv_types.h | 1 - drivers/staging/r8188eu/os_dep/usb_intf.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/r8188eu/include/drv_types.h b/drivers/staging/= r8188eu/include/drv_types.h index e3acac56ce6e..618a6529192b 100644 --- a/drivers/staging/r8188eu/include/drv_types.h +++ b/drivers/staging/r8188eu/include/drv_types.h @@ -139,7 +139,6 @@ struct dvobj_priv { =20 u8 ishighspeed; u8 RtNumOutPipes; - struct semaphore usb_suspend_sema; =20 struct usb_interface *pusbintf; struct usb_device *pusbdev; diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8= 188eu/os_dep/usb_intf.c index b20d0eca12fa..10c33e2ae3bc 100644 --- a/drivers/staging/r8188eu/os_dep/usb_intf.c +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c @@ -126,7 +126,6 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_int= erface *usb_intf) } =20 /* 3 misc */ - sema_init(&pdvobjpriv->usb_suspend_sema, 0); rtw_reset_continual_urb_error(pdvobjpriv); =20 usb_get_dev(pusbd); --=20 2.30.2 From nobody Mon Jun 29 16:47:10 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F91AC433EF for ; Sun, 6 Feb 2022 17:59:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229904AbiBFR75 (ORCPT ); Sun, 6 Feb 2022 12:59:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345435AbiBFR7m (ORCPT ); Sun, 6 Feb 2022 12:59:42 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7D9FC06173B for ; Sun, 6 Feb 2022 09:59:41 -0800 (PST) Received: from ipservice-092-217-075-184.092.217.pools.vodafone-ip.de ([92.217.75.184] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nGlp4-0002n8-1H; Sun, 06 Feb 2022 18:59:38 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 5/5] staging: r8188eu: remove ishighspeed from dvobj_priv Date: Sun, 6 Feb 2022 18:59:25 +0100 Message-Id: <20220206175925.461426-6-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220206175925.461426-1-martin@kaiser.cx> References: <20220206175925.461426-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There's no need to store the usb device speed in struct dvobj_priv. We can read the speed from struct usb_device. dvobj_priv has a pointer to the usb_device. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_iol.c | 4 +++- drivers/staging/r8188eu/hal/usb_halinit.c | 4 ++-- drivers/staging/r8188eu/include/drv_types.h | 1 - drivers/staging/r8188eu/include/usb_ops.h | 2 +- drivers/staging/r8188eu/os_dep/usb_intf.c | 8 -------- 5 files changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_iol.c b/drivers/staging/r8188= eu/core/rtw_iol.c index 923da2a9f6ae..26f2a6fc3f38 100644 --- a/drivers/staging/r8188eu/core/rtw_iol.c +++ b/drivers/staging/r8188eu/core/rtw_iol.c @@ -68,8 +68,10 @@ bool rtw_IOL_applied(struct adapter *adapter) if (1 =3D=3D adapter->registrypriv.fw_iol) return true; =20 - if ((2 =3D=3D adapter->registrypriv.fw_iol) && (!adapter_to_dvobj(adapter= )->ishighspeed)) + if ((2 =3D=3D adapter->registrypriv.fw_iol) && + (!(adapter_to_dvobj(adapter)->pusbdev->speed =3D=3D USB_SPEED_HIGH))) return true; + return false; } =20 diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8= 188eu/hal/usb_halinit.c index 03966a1e247e..e3a28c443f24 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -48,7 +48,7 @@ void rtl8188eu_interface_configure(struct adapter *adapt) struct hal_data_8188e *haldata =3D &adapt->haldata; struct dvobj_priv *pdvobjpriv =3D adapter_to_dvobj(adapt); =20 - if (pdvobjpriv->ishighspeed) + if (pdvobjpriv->pusbdev->speed =3D=3D USB_SPEED_HIGH) haldata->UsbBulkOutSize =3D USB_HIGH_SPEED_BULK_SIZE;/* 512 bytes */ else haldata->UsbBulkOutSize =3D USB_FULL_SPEED_BULK_SIZE;/* 64 bytes */ @@ -105,7 +105,7 @@ static void _InitInterrupt(struct adapter *Adapter) /* 1; Use bulk endpoint to upload interrupt pkt, */ usb_opt =3D rtw_read8(Adapter, REG_USB_SPECIAL_OPTION); =20 - if (!adapter_to_dvobj(Adapter)->ishighspeed) + if (!(adapter_to_dvobj(Adapter)->pusbdev->speed =3D=3D USB_SPEED_HIGH)) usb_opt =3D usb_opt & (~INT_BULK_SEL); else usb_opt =3D usb_opt | (INT_BULK_SEL); diff --git a/drivers/staging/r8188eu/include/drv_types.h b/drivers/staging/= r8188eu/include/drv_types.h index 618a6529192b..894e70a0d506 100644 --- a/drivers/staging/r8188eu/include/drv_types.h +++ b/drivers/staging/r8188eu/include/drv_types.h @@ -137,7 +137,6 @@ struct dvobj_priv { =20 /*-------- below is for USB INTERFACE --------*/ =20 - u8 ishighspeed; u8 RtNumOutPipes; =20 struct usb_interface *pusbintf; diff --git a/drivers/staging/r8188eu/include/usb_ops.h b/drivers/staging/r8= 188eu/include/usb_ops.h index 0a1155bbc7b8..62e4706c0497 100644 --- a/drivers/staging/r8188eu/include/usb_ops.h +++ b/drivers/staging/r8188eu/include/usb_ops.h @@ -55,7 +55,7 @@ static inline u8 rtw_usb_bulk_size_boundary(struct adapte= r *padapter, u8 rst =3D true; struct dvobj_priv *pdvobjpriv =3D adapter_to_dvobj(padapter); =20 - if (pdvobjpriv->ishighspeed) + if (pdvobjpriv->pusbdev->speed =3D=3D USB_SPEED_HIGH) rst =3D (0 =3D=3D (buf_len) % USB_HIGH_SPEED_BULK_SIZE) ? true : false; else diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8= 188eu/os_dep/usb_intf.c index 10c33e2ae3bc..cd7f28d25c47 100644 --- a/drivers/staging/r8188eu/os_dep/usb_intf.c +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c @@ -117,14 +117,6 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_in= terface *usb_intf) if (rt_num_in_pipes !=3D 1) goto err; =20 - if (pusbd->speed =3D=3D USB_SPEED_HIGH) { - pdvobjpriv->ishighspeed =3D true; - DBG_88E("USB_SPEED_HIGH\n"); - } else { - pdvobjpriv->ishighspeed =3D false; - DBG_88E("NON USB_SPEED_HIGH\n"); - } - /* 3 misc */ rtw_reset_continual_urb_error(pdvobjpriv); =20 --=20 2.30.2