From nobody Mon Jun 29 22:17:44 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3BFFC433FE for ; Tue, 1 Feb 2022 18:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241968AbiBASu5 (ORCPT ); Tue, 1 Feb 2022 13:50:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27634 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229915AbiBASu4 (ORCPT ); Tue, 1 Feb 2022 13:50:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643741455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=CXMEPCO/uu0dla1c1qYh6jAoya9d0BWMm4xi0Tv2h6E=; b=K6DtNxVTWRUq3slM6JRAzQcR0TTol5eER6IvAp3JfcuCwFWn2AL6nelF+xAtOSz43A86Il vrF3F5QXK6LEGTPjBwUWsR1heL6E8YlPw9PWg6VP9kdp58DINdXF8rbnJJniSH0eaRkQEI Z9kHT3jyqgKpoBD4xZdXXTCENkH7Uis= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-326-u83wDGirPWCbKuSqOIw8XQ-1; Tue, 01 Feb 2022 13:50:54 -0500 X-MC-Unique: u83wDGirPWCbKuSqOIw8XQ-1 Received: by mail-qv1-f72.google.com with SMTP id r12-20020a0562140c8c00b004226c4fc035so16771809qvr.4 for ; Tue, 01 Feb 2022 10:50:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CXMEPCO/uu0dla1c1qYh6jAoya9d0BWMm4xi0Tv2h6E=; b=ixXX8R4TrkLyN8oXGNeb1SJTQNzLxrhWqpYc7seEPqVHBmjlJk7TKy2thY9AcQ8rUy Ltz8iKRjcC6do7kY9S4C231eWkjsM7eH6gR71mcAVyt0IEmUYPTdZsvkt5YN2I4Nu7EI 3NXx39Wb+rk6GjUQMEDT4Bji0+PVSeRjJUSFw1ViuMmDQRdsE7q+7DKJGUjaUSH840En aMnBcNxyADNMliY82+HdhycsiZS3c/dIvGiG7y3j8HjUbFuhmuMLGXQgD7KElf1QSqfn r+/B1Wdw49EXGiHona5gZ+43i+Kr9yTTpf18ZojkaVhx6p+VK4Qv5m+OOUNViQBAOQd1 asOw== X-Gm-Message-State: AOAM532V3miRUT0B2XSfRqaSOtPqSyrkLj5gSQ/6IK+mxBGVTjSmt04u PB5SxzhSwLkx+N6ndVwZqXVpj5k3pfFIrlv0ohE/CULe1SfBALGPqJLttmLLIJZ06cAVj1iq8BD CJmhDmLfCKF0BQ+NyMNUYoARk X-Received: by 2002:a05:620a:2802:: with SMTP id f2mr16767625qkp.507.1643741453755; Tue, 01 Feb 2022 10:50:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJxeYTqpwtK/INgbSNiwXFDLjZ29hCQC22MnWYuwPikv73Imxyj7d0mLQowMRGUhnvmg77nScw== X-Received: by 2002:a05:620a:2802:: with SMTP id f2mr16767612qkp.507.1643741453530; Tue, 01 Feb 2022 10:50:53 -0800 (PST) Received: from fedora.hitronhub.home (modemcable200.11-22-96.mc.videotron.ca. [96.22.11.200]) by smtp.gmail.com with ESMTPSA id w22sm6225383qtk.7.2022.02.01.10.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 10:50:53 -0800 (PST) From: Adrien Thierry To: linux-serial@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Adrien Thierry , Jeremy Linton , Greg Kroah-Hartman , Jiri Slaby , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com Subject: [PATCH] serial: 8250_bcm2835aux: Add ACPI support Date: Tue, 1 Feb 2022 13:50:01 -0500 Message-Id: <20220201185001.926338-1-athierry@redhat.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add ACPI support to 8250_bcm2835aux driver. This makes it possible to use the miniuart on the Raspberry Pi with the tianocore/edk2 UEFI firmware. Signed-off-by: Adrien Thierry --- drivers/tty/serial/8250/8250_bcm2835aux.c | 103 +++++++++++++++++----- 1 file changed, 83 insertions(+), 20 deletions(-) diff --git a/drivers/tty/serial/8250/8250_bcm2835aux.c b/drivers/tty/serial= /8250/8250_bcm2835aux.c index fd95860cd..b904b321e 100644 --- a/drivers/tty/serial/8250/8250_bcm2835aux.c +++ b/drivers/tty/serial/8250/8250_bcm2835aux.c @@ -12,6 +12,7 @@ * simultaneously to rs485. */ =20 +#include #include #include #include @@ -44,6 +45,10 @@ struct bcm2835aux_data { u32 cntl; }; =20 +struct bcm2835_aux_serial_acpi_driver_data { + resource_size_t offset; +}; + static void bcm2835aux_rs485_start_tx(struct uart_8250_port *up) { if (!(up->port.rs485.flags & SER_RS485_RX_DURING_TX)) { @@ -82,8 +87,12 @@ static int bcm2835aux_serial_probe(struct platform_devic= e *pdev) { struct uart_8250_port up =3D { }; struct bcm2835aux_data *data; + struct bcm2835_aux_serial_acpi_driver_data *acpi_data; struct resource *res; int ret; + resource_size_t mapbase; + resource_size_t mapsize; + unsigned int uartclk; =20 /* allocate the custom structure */ data =3D devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); @@ -108,10 +117,12 @@ static int bcm2835aux_serial_probe(struct platform_de= vice *pdev) =20 platform_set_drvdata(pdev, data); =20 - /* get the clock - this also enables the HW */ - data->clk =3D devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(data->clk)) - return dev_err_probe(&pdev->dev, PTR_ERR(data->clk), "could not get clk\= n"); + if (dev_of_node(&pdev->dev)) { + /* get the clock - this also enables the HW */ + data->clk =3D devm_clk_get(&pdev->dev, NULL); + if (IS_ERR(data->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(data->clk), "could not get clk= \n"); + } =20 /* get the interrupt */ ret =3D platform_get_irq(pdev, 0); @@ -125,20 +136,59 @@ static int bcm2835aux_serial_probe(struct platform_de= vice *pdev) dev_err(&pdev->dev, "memory resource not found"); return -EINVAL; } - up.port.mapbase =3D res->start; - up.port.mapsize =3D resource_size(res); - - /* Check for a fixed line number */ - ret =3D of_alias_get_id(pdev->dev.of_node, "serial"); - if (ret >=3D 0) - up.port.line =3D ret; - - /* enable the clock as a last step */ - ret =3D clk_prepare_enable(data->clk); - if (ret) { - dev_err(&pdev->dev, "unable to enable uart clock - %d\n", - ret); - return ret; + + mapbase =3D res->start; + mapsize =3D resource_size(res); + + if (has_acpi_companion(&pdev->dev)) { + const struct acpi_device_id *match; + + match =3D acpi_match_device(pdev->dev.driver->acpi_match_table, &pdev->d= ev); + if (!match) + return -ENODEV; + + acpi_data =3D (struct bcm2835_aux_serial_acpi_driver_data *)match->drive= r_data; + + /* Some UEFI implementations (e.g. tianocore/edk2 for the Raspberry Pi) + * describe the miniuart with a base address that encompasses the auxili= ary + * registers shared between the miniuart and spi. + * + * This is due to historical reasons, see discussion here : + * https://edk2.groups.io/g/devel/topic/87501357#84349 + * + * We need to add the offset between the miniuart and auxiliary + * registers to get the real miniuart base address. + */ + up.port.mapbase =3D mapbase + acpi_data->offset; + up.port.mapsize =3D mapsize - acpi_data->offset; + } else { + up.port.mapbase =3D mapbase; + up.port.mapsize =3D mapsize; + } + + if (dev_of_node(&pdev->dev)) { + /* Check for a fixed line number */ + ret =3D of_alias_get_id(pdev->dev.of_node, "serial"); + if (ret >=3D 0) + up.port.line =3D ret; + + /* enable the clock as a last step */ + ret =3D clk_prepare_enable(data->clk); + if (ret) { + dev_err(&pdev->dev, "unable to enable uart clock - %d\n", + ret); + return ret; + } + + uartclk =3D clk_get_rate(data->clk); + + + } else { + ret =3D device_property_read_u32(&pdev->dev, "clock-frequency", &uartclk= ); + if (ret) { + dev_err(&pdev->dev, "unable to get clock frequency\n"); + return ret; + } } =20 /* the HW-clock divider for bcm2835aux is 8, @@ -146,7 +196,7 @@ static int bcm2835aux_serial_probe(struct platform_devi= ce *pdev) * so we have to multiply the actual clock by 2 * to get identical baudrates. */ - up.port.uartclk =3D clk_get_rate(data->clk) * 2; + up.port.uartclk =3D uartclk * 2; =20 /* register the port */ ret =3D serial8250_register_8250_port(&up); @@ -159,7 +209,9 @@ static int bcm2835aux_serial_probe(struct platform_devi= ce *pdev) return 0; =20 dis_clk: - clk_disable_unprepare(data->clk); + if (dev_of_node(&pdev->dev)) + clk_disable_unprepare(data->clk); + return ret; } =20 @@ -173,16 +225,27 @@ static int bcm2835aux_serial_remove(struct platform_d= evice *pdev) return 0; } =20 +static const struct bcm2835_aux_serial_acpi_driver_data bcm2835_acpi_data = =3D { + .offset =3D 0x40 +}; + static const struct of_device_id bcm2835aux_serial_match[] =3D { { .compatible =3D "brcm,bcm2835-aux-uart" }, { }, }; MODULE_DEVICE_TABLE(of, bcm2835aux_serial_match); =20 +static const struct acpi_device_id bcm2835aux_serial_acpi_match[] =3D { + { "BCM2836", (kernel_ulong_t)&bcm2835_acpi_data }, + { }, +}; +MODULE_DEVICE_TABLE(acpi, bcm2835aux_serial_acpi_match); + static struct platform_driver bcm2835aux_serial_driver =3D { .driver =3D { .name =3D "bcm2835-aux-uart", .of_match_table =3D bcm2835aux_serial_match, + .acpi_match_table =3D bcm2835aux_serial_acpi_match, }, .probe =3D bcm2835aux_serial_probe, .remove =3D bcm2835aux_serial_remove, base-commit: 26291c54e111ff6ba87a164d85d4a4e134b7315c --=20 2.34.1