From nobody Mon Jun 29 22:11:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F4EC4332F for ; Tue, 1 Feb 2022 17:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241639AbiBARnL (ORCPT ); Tue, 1 Feb 2022 12:43:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:49446 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241628AbiBARnJ (ORCPT ); Tue, 1 Feb 2022 12:43:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643737389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3/onK8AnDtL53ai739ibWRR8ijRtGmfoRrTuaxLarqk=; b=SF9JG/qozJIozPGG4llfqz9spz84Ixdyg5zfJP4bv1wGLKOFSlrV1VT3ILCrbD9fw+W+0P /0U5GBEHL48mNe1iTKowGUJOomkXfF4SMn7TlUvfUI/GwhRcKdGpD3f2Y4EGPIUfRdHVvx m4D02imkRyBMMN4PcECEkjZwmbMIuV8= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-437-Qs4kkyltMnW7d1deRVThog-1; Tue, 01 Feb 2022 12:43:08 -0500 X-MC-Unique: Qs4kkyltMnW7d1deRVThog-1 Received: by mail-qt1-f198.google.com with SMTP id y1-20020ac87041000000b002c3db9c25f8so13462867qtm.5 for ; Tue, 01 Feb 2022 09:43:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3/onK8AnDtL53ai739ibWRR8ijRtGmfoRrTuaxLarqk=; b=F6hbFzlNYRMpX0VZltZhyD+n5YvorgqRfmfVKdjqy+j6deuLbv7dKWstxNEU6jVbgl pbj6eD6c+5HWr9bd7d9Rc44lVOFI6gg8cLgtHMCxwjtTQfJfhBefNoQRmKi3VNdv4ZAa BteQTjjq/zI4fuI9hBKX9JoXLgRLIuO9EYdZ1rjmRvmq8HAbPLFM6b3f59SPdOC9DecZ Ya1Hx4DyzE4bpxY+Rjb/roCoLSMwN0uwEXu+T5an+CU8xejj5KUumDjY9MikNLIBl8tu nnHGH5zL/e87WEFxoJFw17Ks/jokSkMKtQhxC6LNnO5uzWGzeP1LLpVBKRQs075r+sHj bsDA== X-Gm-Message-State: AOAM532YzQnumnxkn1LOlQSoEiDQLWYcn9mIyMLa4BNARNgrpuB6y0MG i/QGgiLeFeNxopCQcHgUZcpXdkGKiF1MxggdF9476hePSC0m56kYBD0kxWzZ3h9JYCYH9UJ0mIn esWb3Hx1jG1UnVpyanLbLUNwP X-Received: by 2002:a05:622a:44b:: with SMTP id o11mr10694442qtx.507.1643737387525; Tue, 01 Feb 2022 09:43:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJyADtOcufdtCgzPuWfrUXmKa/HFQ+qhMTdmjjxzdXxSj8ZJqSx+dyiOnLYrEWaALkPWKiqX+g== X-Received: by 2002:a05:622a:44b:: with SMTP id o11mr10694429qtx.507.1643737387313; Tue, 01 Feb 2022 09:43:07 -0800 (PST) Received: from localhost.localdomain.com (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id d17sm11962845qkn.84.2022.02.01.09.43.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 09:43:06 -0800 (PST) From: trix@redhat.com To: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, davem@davemloft.net, kuba@kernel.org, nathan@kernel.org, ndesaulniers@google.com Cc: linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] Bluetooth: hci_sync: fix undefined return of hci_disconnect_all_sync() Date: Tue, 1 Feb 2022 09:42:56 -0800 Message-Id: <20220201174256.1690515-1-trix@redhat.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Tom Rix clang static analysis reports this problem hci_sync.c:4428:2: warning: Undefined or garbage value returned to caller return err; ^~~~~~~~~~ If there are no connections this function is a noop but err is never set and a false error could be reported. Return 0 as other hci_* functions do. Fixes: 182ee45da083 ("Bluetooth: hci_sync: Rework hci_suspend_notifier") Signed-off-by: Tom Rix --- net/bluetooth/hci_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c index 6e71aa6b6feae..9327737da6003 100644 --- a/net/bluetooth/hci_sync.c +++ b/net/bluetooth/hci_sync.c @@ -4425,7 +4425,7 @@ static int hci_disconnect_all_sync(struct hci_dev *hd= ev, u8 reason) return err; } =20 - return err; + return 0; } =20 /* This function perform power off HCI command sequence as follows: --=20 2.26.3