From nobody Mon Jun 29 23:23:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07E92C43219 for ; Tue, 1 Feb 2022 15:02:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239654AbiBAPCN (ORCPT ); Tue, 1 Feb 2022 10:02:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239634AbiBAPCL (ORCPT ); Tue, 1 Feb 2022 10:02:11 -0500 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FB30C061714 for ; Tue, 1 Feb 2022 07:02:11 -0800 (PST) Received: by mail-io1-xd2f.google.com with SMTP id p63so20674488iod.11 for ; Tue, 01 Feb 2022 07:02:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MLEfOvs0XYTBMi37IYE0nxh2vKRdvGYr4hL4oQxHa8M=; b=ytR9ybKf78e9r81Jz1vLmp3ngHBYNuUbyHoXl0+O4rFQB6Vs/4C7C1Ecd9rXJcbbig YGojHqXI/UcsZAlFVi6QT0jyJprhWEoJ6mM0GBmachNrlLMrvkuvaaDBJMcnJOtb+MT1 l/l+UU9EAaIk/tCTmy7F6tUZhTEaJ8+KclYhuj/Xs013OY7RIcrqq6nrmGk0hw4+Evc6 u7F+0nn+IuRWx+0lSZkx9VQXlzcutd7lJ5T+adOPdCBOQF9tSkOa/D/O5zwX5+h4p3Dw noH1d0V7Iv04n5Hh97cQJFj4fs1S7GK59N6L8HHZzcFNI0Uo16GuaDszeSV3e4vl1pDY QUdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MLEfOvs0XYTBMi37IYE0nxh2vKRdvGYr4hL4oQxHa8M=; b=y4+xEQ6990LIjBiNuI/a7nmZ4e1yjjl2OC4ox+YKFN8dhyLqfKGhygOm7g1belJTfE vuW+4pRCXKOb3Xj+Pra/c/PLp9yq5TpY/DMsVC+4+2mjYwnprcvwwfAuACKC1Vi3fJ0J F4MoPmH+d5+vxmjrpkW07rdAucPfxe3tKgHINleXSxgG7iYe14nKT5g8FgaDf7JquA4M Vvi7ojPPUg4+uZaFarawdT4TDtjaakhbs0ssMleWrcQV3ySmqyoYjfoMxpywyHn88+LZ kFV7owGsKOhfJWThsu77QjSjaRIzv7XmlIfKczTRzCmQNkMAWMEydZ6u3FtzO0Be95pq 5sag== X-Gm-Message-State: AOAM531m/vyuGTYt6F0fu+bcGxipPQQF+rbM39MyMud1ETMzkxOCwWw/ PTYbLpcLpkLt86Ft6w1+Rhpynw== X-Google-Smtp-Source: ABdhPJx88GjpHLi9TGbQVzWh0R/FUwA9VTi13g/mfPQwP/mDrRHrsVDnZ9O+iWUbx3B492hm38AOZA== X-Received: by 2002:a02:9645:: with SMTP id c63mr12719886jai.260.1643727730766; Tue, 01 Feb 2022 07:02:10 -0800 (PST) Received: from localhost.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id e17sm19141307ilm.67.2022.02.01.07.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 07:02:10 -0800 (PST) From: Alex Elder To: robh+dt@kernel.org, davem@davemloft.net, kuba@kernel.org Cc: bjorn.andersson@linaro.org, agross@kernel.org, mka@chromium.org, evgreen@chromium.org, cpratapa@codeaurora.org, avuyyuru@codeaurora.org, jponduru@codeaurora.org, subashab@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 1/2] dt-bindings: net: qcom,ipa: add optional qcom,qmp property Date: Tue, 1 Feb 2022 09:02:04 -0600 Message-Id: <20220201150205.468403-2-elder@linaro.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220201150205.468403-1-elder@linaro.org> References: <20220201150205.468403-1-elder@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" For some systems, the IPA driver must make a request to ensure that its registers are retained across power collapse of the IPA hardware. On such systems, we'll use the existence of the "qcom,qmp" property as a signal that this request is required. Signed-off-by: Alex Elder --- Documentation/devicetree/bindings/net/qcom,ipa.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Document= ation/devicetree/bindings/net/qcom,ipa.yaml index b86edf67ce626..58ecc62adfaae 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml @@ -107,6 +107,10 @@ properties: - const: imem - const: config =20 + qcom,qmp: + $ref: /schemas/types.yaml#/definitions/phandle + description: phandle to the AOSS side-channel message RAM + qcom,smem-states: $ref: /schemas/types.yaml#/definitions/phandle-array description: State bits used in by the AP to signal the modem. @@ -222,6 +226,8 @@ examples: "imem", "config"; =20 + qcom,qmp =3D <&aoss_qmp>; + qcom,smem-states =3D <&ipa_smp2p_out 0>, <&ipa_smp2p_out 1>; qcom,smem-state-names =3D "ipa-clock-enabled-valid", --=20 2.32.0 From nobody Mon Jun 29 23:23:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2FA6C433FE for ; Tue, 1 Feb 2022 15:02:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239671AbiBAPCP (ORCPT ); Tue, 1 Feb 2022 10:02:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239648AbiBAPCM (ORCPT ); Tue, 1 Feb 2022 10:02:12 -0500 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4586C06173B for ; Tue, 1 Feb 2022 07:02:12 -0800 (PST) Received: by mail-io1-xd33.google.com with SMTP id q204so21504677iod.8 for ; Tue, 01 Feb 2022 07:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Psa2zXq9CIoesnxGhdNYAKpIpdpvJqYiAj5N20pw5fs=; b=TobaHrqBNR77g0qOCWpypBwg6HIQxMn5bYtPxAZU+bHbGruKW9uW52W9KgiWE8kIcP d2IUU8goU9kJ732v1Ii8+DCWuMxBXow5I/R+EN5jDHKpYpXf9wZfdfkWSPTlpFFweFkD ClqPnk8MaECrlDi00jonB1myC0RsRdRcGdIf9IzT+lfxwvmfUX929HX8ayazCiQQffKe vWgJtjxZJG1XZfVUGxSBpaRFYIr+LXiKlF0icAQO7Nhr5k8K+YNM7IlgTYOenc7A8m1o StNvSYBDjHY5k3qhrSopYtzmO1pgmqChluk4mY3iuYOQrce8998Zqj8d3CvzhpyVRO5Z 3aZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Psa2zXq9CIoesnxGhdNYAKpIpdpvJqYiAj5N20pw5fs=; b=XDUkzTj9rCwpFSEpHvIfcfjS6gYpp+cQ2arENeoIUT1ksltSKBu12hGAtseWMiPrNt bs2ZlRXrWt+SQvthoBncfXlSGEOquj0MQzJ7zRU6noiFlO711zkjkCQNrC5dbi0/IzbF OZtu+x6mdB/hZnKv2MJbLNAqcz79PIjjosGc82qmdRFdXt1sf2rmsUrguJZeajOMVxpM 6HiKGW8HY2Bp+R8s9SDWGrpV1Q6FBTLEz+Lp/GqTjBrUgB7Oura/bbVfC/tdLYJci27z x+Vt8FnGYp8I6yzwLZdmjOny/FSCZf5YEYuoYDzIHcAI/AzArn0Hubvk01pb4vkxXv0v Uhbg== X-Gm-Message-State: AOAM532nTbu9I+90f/Aa25EB31RLeaMh2ZdKmXSMttr3E9F9ul+IvIU6 ut8ZWTajYzppKCCOUCurRZxYzw== X-Google-Smtp-Source: ABdhPJxnl2G6CdXw3UYQ2ueHlyZJNFOqm5B7PDylM0/r8g3VNPQFCfDE6WqyJy9+yyOOXXw+cnJRKQ== X-Received: by 2002:a05:6638:3591:: with SMTP id v17mr11788085jal.277.1643727732147; Tue, 01 Feb 2022 07:02:12 -0800 (PST) Received: from localhost.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id e17sm19141307ilm.67.2022.02.01.07.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 07:02:11 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: robh+dt@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, mka@chromium.org, evgreen@chromium.org, cpratapa@codeaurora.org, avuyyuru@codeaurora.org, jponduru@codeaurora.org, subashab@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 2/2] net: ipa: request IPA register values be retained Date: Tue, 1 Feb 2022 09:02:05 -0600 Message-Id: <20220201150205.468403-3-elder@linaro.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220201150205.468403-1-elder@linaro.org> References: <20220201150205.468403-1-elder@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In some cases, the IPA hardware needs to request the always-on subsystem (AOSS) to coordinate with the IPA microcontroller to retain IPA register values at power collapse. This is done by issuing a QMP request to the AOSS microcontroller. A similar request ondoes that request. We must get and hold the "QMP" handle early, because we might get back EPROBE_DEFER for that. But the actual request should be sent while we know the IPA clock is active, and when we know the microcontroller is operational. Fixes: 2775cbc5afeb6 ("net: ipa: rename "ipa_clock.c"") Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_power.c | 52 +++++++++++++++++++++++++++++++++++++ drivers/net/ipa/ipa_power.h | 7 +++++ drivers/net/ipa/ipa_uc.c | 5 ++++ 3 files changed, 64 insertions(+) diff --git a/drivers/net/ipa/ipa_power.c b/drivers/net/ipa/ipa_power.c index b1c6c0fcb654f..f2989aac47a62 100644 --- a/drivers/net/ipa/ipa_power.c +++ b/drivers/net/ipa/ipa_power.c @@ -11,6 +11,8 @@ #include #include =20 +#include "linux/soc/qcom/qcom_aoss.h" + #include "ipa.h" #include "ipa_power.h" #include "ipa_endpoint.h" @@ -64,6 +66,7 @@ enum ipa_power_flag { * struct ipa_power - IPA power management information * @dev: IPA device pointer * @core: IPA core clock + * @qmp: QMP handle for AOSS communication * @spinlock: Protects modem TX queue enable/disable * @flags: Boolean state flags * @interconnect_count: Number of elements in interconnect[] @@ -72,6 +75,7 @@ enum ipa_power_flag { struct ipa_power { struct device *dev; struct clk *core; + struct qmp *qmp; spinlock_t spinlock; /* used with STOPPED/STARTED power flags */ DECLARE_BITMAP(flags, IPA_POWER_FLAG_COUNT); u32 interconnect_count; @@ -382,6 +386,47 @@ void ipa_power_modem_queue_active(struct ipa *ipa) clear_bit(IPA_POWER_FLAG_STARTED, ipa->power->flags); } =20 +static int ipa_power_retention_init(struct ipa_power *power) +{ + struct qmp *qmp =3D qmp_get(power->dev); + + if (IS_ERR(qmp)) { + if (PTR_ERR(qmp) =3D=3D -EPROBE_DEFER) + return -EPROBE_DEFER; + + /* We assume any other error means it's not defined/needed */ + qmp =3D NULL; + } + power->qmp =3D qmp; + + return 0; +} + +static void ipa_power_retention_exit(struct ipa_power *power) +{ + qmp_put(power->qmp); + power->qmp =3D NULL; +} + +/* Control register retention on power collapse */ +void ipa_power_retention(struct ipa *ipa, bool enable) +{ + static const char fmt[] =3D "{ class: bcm, res: ipa_pc, val: %c }"; + struct ipa_power *power =3D ipa->power; + char buf[36]; /* Exactly enough for fmt[]; size a multiple of 4 */ + int ret; + + if (!power->qmp) + return; /* Not needed on this platform */ + + (void)snprintf(buf, sizeof(buf), fmt, enable ? '1' : '0'); + + ret =3D qmp_send(power->qmp, buf, sizeof(buf)); + if (ret) + dev_err(power->dev, "error %d sending QMP %sable request\n", + ret, enable ? "en" : "dis"); +} + int ipa_power_setup(struct ipa *ipa) { int ret; @@ -438,12 +483,18 @@ ipa_power_init(struct device *dev, const struct ipa_p= ower_data *data) if (ret) goto err_kfree; =20 + ret =3D ipa_power_retention_init(power); + if (ret) + goto err_interconnect_exit; + pm_runtime_set_autosuspend_delay(dev, IPA_AUTOSUSPEND_DELAY); pm_runtime_use_autosuspend(dev); pm_runtime_enable(dev); =20 return power; =20 +err_interconnect_exit: + ipa_interconnect_exit(power); err_kfree: kfree(power); err_clk_put: @@ -460,6 +511,7 @@ void ipa_power_exit(struct ipa_power *power) =20 pm_runtime_disable(dev); pm_runtime_dont_use_autosuspend(dev); + ipa_power_retention_exit(power); ipa_interconnect_exit(power); kfree(power); clk_put(clk); diff --git a/drivers/net/ipa/ipa_power.h b/drivers/net/ipa/ipa_power.h index 2151805d7fbb0..6f84f057a2095 100644 --- a/drivers/net/ipa/ipa_power.h +++ b/drivers/net/ipa/ipa_power.h @@ -40,6 +40,13 @@ void ipa_power_modem_queue_wake(struct ipa *ipa); */ void ipa_power_modem_queue_active(struct ipa *ipa); =20 +/** + * ipa_power_retention() - Control register retention on power collapse + * @ipa: IPA pointer + * @enable: Whether retention should be enabled or disabled + */ +void ipa_power_retention(struct ipa *ipa, bool enable); + /** * ipa_power_setup() - Set up IPA power management * @ipa: IPA pointer diff --git a/drivers/net/ipa/ipa_uc.c b/drivers/net/ipa/ipa_uc.c index 856e55a080a7f..fe11910518d95 100644 --- a/drivers/net/ipa/ipa_uc.c +++ b/drivers/net/ipa/ipa_uc.c @@ -11,6 +11,7 @@ =20 #include "ipa.h" #include "ipa_uc.h" +#include "ipa_power.h" =20 /** * DOC: The IPA embedded microcontroller @@ -154,6 +155,7 @@ static void ipa_uc_response_hdlr(struct ipa *ipa, enum = ipa_irq_id irq_id) case IPA_UC_RESPONSE_INIT_COMPLETED: if (ipa->uc_powered) { ipa->uc_loaded =3D true; + ipa_power_retention(ipa, true); pm_runtime_mark_last_busy(dev); (void)pm_runtime_put_autosuspend(dev); ipa->uc_powered =3D false; @@ -184,6 +186,9 @@ void ipa_uc_deconfig(struct ipa *ipa) =20 ipa_interrupt_remove(ipa->interrupt, IPA_IRQ_UC_1); ipa_interrupt_remove(ipa->interrupt, IPA_IRQ_UC_0); + if (ipa->uc_loaded) + ipa_power_retention(ipa, false); + if (!ipa->uc_powered) return; =20 --=20 2.32.0