From nobody Tue Jun 30 00:46:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A16C433F5 for ; Sat, 29 Jan 2022 11:33:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238789AbiA2LdX (ORCPT ); Sat, 29 Jan 2022 06:33:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237690AbiA2LdN (ORCPT ); Sat, 29 Jan 2022 06:33:13 -0500 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 047E9C061714 for ; Sat, 29 Jan 2022 03:33:13 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id c24so15832554edy.4 for ; Sat, 29 Jan 2022 03:33:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ERA8aqBvYsjnUMCz9U3prbef6jppsXR/APdHoQnIWjI=; b=P1NiM06ryBLQy3PdF+YpGkhXnOuNMR3s8H1hQSsvru5rizLJ7ry7FqvJ3vWk9DV9nS PlUjGs9ofhwEoHiosLGbGNy3yqtrTNemNzSrlcuq9mt7vj0cFJuT+bXrsw70rs3peRTz RUXFPvgVugBgBKomRdW0C24/qgG3t/DCG2JA4uNZ1xWGPVPPKombPk4PuthWsbQe8FcT 94xi0DwL5gX2/1SRrZxIH0H3tQlwg4aDnOxImjglbQnb+bTgdbpbKiBs9svG8hQ+mjbh Y0EyFlOXzXc09r9aXVE0k4Euwp9B3BlAvENQLzEmnOmAgM/ARgyYHmhRTZq2PUOz+7XQ pDkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ERA8aqBvYsjnUMCz9U3prbef6jppsXR/APdHoQnIWjI=; b=E26/QE/tjmiPIICLvaiw2Bh51vWIDKmyT63aTW7FG/r9G8qosCypKO8WowIzmCUiJU IUkio9x+1RSDs2BOSr2K/I6rd/5jRSLze2Ii0pKZlV3AhHcsrNvCGSz8FXmyvE24VZkb Uj3Dw5Y/wsoN/xyGv7QwTAK9J4He5n+6XfOggToVVXBDxRTTCdHfVBvQF7YIDXNXxWjX We5SwmX+MMhrFwpm2YwsdL0xHW0KUpll8RYokk64mdd27hbVelrsS1JWgRulnfpiV33W JgNbWqXfhnoXBKqTJlPhzje6q6InsjsFKhGwSVyMqeARRmqJfibQkdHiXGu8dZnuSc9l KCyQ== X-Gm-Message-State: AOAM531guE/7MIkgAHB9vywTRTu7GDHYtO++QpRKdcdeYQ8PLm5dqnjg +UBsgzSmtMvewbeBeyMQeTY= X-Google-Smtp-Source: ABdhPJzLP+bbtbCvN3Io1A8R1+++zl+5dkNH9PZbnUUObW7WZv04fmuU2WXnQGXu/SJSsU31RnO0JQ== X-Received: by 2002:a05:6402:5147:: with SMTP id n7mr12261744edd.2.1643455991590; Sat, 29 Jan 2022 03:33:11 -0800 (PST) Received: from cosmos.lan (178.113.77.92.wireless.dyn.drei.com. [178.113.77.92]) by smtp.gmail.com with ESMTPSA id g6sm8885062ejz.170.2022.01.29.03.33.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 03:33:11 -0800 (PST) From: Christian Lachner To: perex@perex.cz, tiwai@suse.com, kailang@realtek.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Christian Lachner Subject: [PATCH 1/3] hda/realtek: Add missing fixup-model entry for Gigabyte X570 ALC1220 quirks Date: Sat, 29 Jan 2022 12:32:41 +0100 Message-Id: <20220129113243.93068-2-gladiac@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220129113243.93068-1-gladiac@gmail.com> References: <20220129113243.93068-1-gladiac@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The initial commit of the new Gigabyte X570 ALC1220 quirks lacked the fixup-model entry in alc882_fixup_models[]. It seemed not to cause any ill effects but for completeness sake this commit makes up for that. Signed-off-by: Christian Lachner --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 668274e52674..48af182f87e4 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -2626,6 +2626,7 @@ static const struct hda_model_fixup alc882_fixup_mode= ls[] =3D { {.id =3D ALC882_FIXUP_NO_PRIMARY_HP, .name =3D "no-primary-hp"}, {.id =3D ALC887_FIXUP_ASUS_BASS, .name =3D "asus-bass"}, {.id =3D ALC1220_FIXUP_GB_DUAL_CODECS, .name =3D "dual-codecs"}, + {.id =3D ALC1220_FIXUP_GB_X570, .name =3D "gb-x570"}, {.id =3D ALC1220_FIXUP_CLEVO_P950, .name =3D "clevo-p950"}, {} }; --=20 2.34.1 From nobody Tue Jun 30 00:46:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1459EC433F5 for ; Sat, 29 Jan 2022 11:33:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238070AbiA2Ld0 (ORCPT ); Sat, 29 Jan 2022 06:33:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237825AbiA2LdO (ORCPT ); Sat, 29 Jan 2022 06:33:14 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2C28C061714 for ; Sat, 29 Jan 2022 03:33:13 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id j23so15690349edp.5 for ; Sat, 29 Jan 2022 03:33:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Sru1jdaN0i8x7BMpLToXDQYkXxi+rqmOmOeEeeUCi8w=; b=oAnGyMaNax0I3RmgHekqsLU9GExFU8MdPWRMoUgsM0/KyoGqF3j17wvCP2d7r2MErD dQY0cvVfW8p5BbHBbHPQr9Fv8Gm5t2Og27W8JoT5EwJ9877viAtCJMVBdKt1wJr8wc6d 4pEa5UCK3aQGakgHPwW3g6OhckKFpVEUACxPycUjEd3a8Kn1elF0VFNgUHxmxcEd1Cm/ 1qAMC6YFeLAAEovPrYs1ScwvsWvT1G6xy673H1XAQsy4q+uQUBK+iM5ysLcr2sSpsaNf 3OF865pyXiPZkW4ChbMhhBNrpExCRccTS9OzP5lxU7o6+/UkOg3QQcc81Mo9Kr1wK7Uw MXRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Sru1jdaN0i8x7BMpLToXDQYkXxi+rqmOmOeEeeUCi8w=; b=cDbBUODtP4iyY+36/msPTm0NKXHaM9O32C60Gpkd53tGastHea0Iue7tquAy29qeit eY+JeCZEs+0ln+rcuz+51bjrAXqwqGjPvwsf7HJMfye2KozL6mENyvTKFUlR0RFg569n a8sccbdJaEStmyA++wSWynAh1oa/8/jEZ5Ieb0MgIwmvlhg+S23IVPOZvPb9mUvWEHmQ +YWxeZJsdTYVrL2UblNKjUzzFo8aXuaBcfJbJkK41nBE00l8MHhhMTIZultBVSnq9oWP 6JvCrO78FPd2990TRCexE09keSCxbO0pZTTD9oxDY2WTZOF8vhj3iUgPrLcUhKPLwRMd y06g== X-Gm-Message-State: AOAM533oJpRAXm9Mr8X0jmtx50/hrCWey9MByM1wP/QcIetH4iLqWPcK Ov4IuZFTfry5C6RAHVWR9WE= X-Google-Smtp-Source: ABdhPJzBi8S9tPmb0gPjL+mqr1DSXbVLEoeBxZimbwlpMKMIEusoJzn6cn4RgGbtDGRcQtCP/pCsmw== X-Received: by 2002:a50:fc14:: with SMTP id i20mr12197926edr.261.1643455992567; Sat, 29 Jan 2022 03:33:12 -0800 (PST) Received: from cosmos.lan (178.113.77.92.wireless.dyn.drei.com. [178.113.77.92]) by smtp.gmail.com with ESMTPSA id g6sm8885062ejz.170.2022.01.29.03.33.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 03:33:12 -0800 (PST) From: Christian Lachner To: perex@perex.cz, tiwai@suse.com, kailang@realtek.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Christian Lachner Subject: [PATCH 2/3] hda/realtek: Fix silent output on Gigabyte X570S Aorus Master (newer chipset) Date: Sat, 29 Jan 2022 12:32:42 +0100 Message-Id: <20220129113243.93068-3-gladiac@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220129113243.93068-1-gladiac@gmail.com> References: <20220129113243.93068-1-gladiac@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Newer versions of the X570 Master come with a newer revision of the mainboard chipset - the X570S. These boards have the same ALC1220 codec but seem to initialize the codec with a different parameter in Coef 0x7 which causes the output audio to be very low. We therefore write a known-good value to Coef 0x7 to fix that. As the value is the exact same as on the other X570(non-S) boards the same quirk-function can be shared between both generations. This commit adds the Gigabyte X570S Aorus Master to the list of boards using the ALC1220_FIXUP_GB_X570 quirk. This fixes both, the silent output and the no-audio after reboot from windows problems. This work has been tested by the folks over at the level1techs forum here: https://forum.level1techs.com/t/has-anybody-gotten-audio-working-in-linux-o= n-aorus-x570-master/154072 Signed-off-by: Christian Lachner --- sound/pci/hda/patch_realtek.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 48af182f87e4..ca8475c24187 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -2125,6 +2125,7 @@ static void alc1220_fixup_gb_x570(struct hda_codec *c= odec, { static const hda_nid_t conn1[] =3D { 0x0c }; static const struct coef_fw gb_x570_coefs[] =3D { + WRITE_COEF(0x07, 0x03c0), WRITE_COEF(0x1a, 0x01c1), WRITE_COEF(0x1b, 0x0202), WRITE_COEF(0x43, 0x3005), @@ -2552,6 +2553,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = =3D { SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_D= UAL_CODECS), SND_PCI_QUIRK(0x1458, 0xa0cd, "Gigabyte X570 Aorus Master", ALC1220_FIXUP= _GB_X570), SND_PCI_QUIRK(0x1458, 0xa0ce, "Gigabyte X570 Aorus Xtreme", ALC1220_FIXUP= _CLEVO_P950), + SND_PCI_QUIRK(0x1458, 0xa0d5, "Gigabyte X570S Aorus Master", ALC1220_FIXU= P_GB_X570), SND_PCI_QUIRK(0x1462, 0x11f7, "MSI-GE63", ALC1220_FIXUP_CLEVO_P950), SND_PCI_QUIRK(0x1462, 0x1228, "MSI-GP63", ALC1220_FIXUP_CLEVO_P950), SND_PCI_QUIRK(0x1462, 0x1229, "MSI-GP73", ALC1220_FIXUP_CLEVO_P950), --=20 2.34.1 From nobody Tue Jun 30 00:46:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F29ABC433F5 for ; Sat, 29 Jan 2022 11:33:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238716AbiA2Ld3 (ORCPT ); Sat, 29 Jan 2022 06:33:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237913AbiA2LdP (ORCPT ); Sat, 29 Jan 2022 06:33:15 -0500 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0EFEC06173B for ; Sat, 29 Jan 2022 03:33:14 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id w25so14856837edt.7 for ; Sat, 29 Jan 2022 03:33:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FNNDRp1DwqScqAKKfKlwRaoAS6b293HuHJmyYnE9wS8=; b=Zi8eoe7gWXACuUnDq5t0aWFzMJGG4durC3+Muthlr1md1mipaKJpB5q05nI5KKSpap P8iZm0jVx2+xK5IJXfmR5J6isPNA/Yv8nSKeWpCN0nlatcSJFk7QAekzdMYqFPXYY69d 2xMPRRJ58KunDFjAnjn8xprIKwaBQf+5qHq6thXwLOqcDkn11HSmOrUiaHaYVcjPVtvm AH4bCx/hfq/8auaG40sjTIc1bgd4CIP8ZN31sgiBb/R86mi4YpktODHw1ir1tDUnEOBd xugN3WOAVzI6wJle7otsVeBeqy1d6pJz0B0OHAfWpKPiMukwxuU397W+Rb2W5s+yEMMr Wb1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FNNDRp1DwqScqAKKfKlwRaoAS6b293HuHJmyYnE9wS8=; b=2LEuAiGgwLWI3viQAjwNT+Z4KMDQ5mwA9d5ltq+SK2TI8ziYNOpMGsnFC1QbHZx+uF L/9zce/8FWrxoZ+inybvftaUUZ93qoNMgdNygYQlNVqD2JVfk2NcXzvpYr9bZvNSuf8I erhky/U0yj0TECuJ7B7EAke5wJmXgnSDdfLzg5lzqTJRr5MYawLkoOOnewZ4XWqXvQfz yZyqyT9irvk3fsBwad2vZb8l2XyPQc6qQyftSq7HMJbWiy6B1rtDN2a9253rbTxr6IX4 ODcWbLwVy4UFESj7/d3qmoON3Dce0KBk3S+f9VsaAQlTXuE+sc5+f/SPCwEdaDsD13qL YBzQ== X-Gm-Message-State: AOAM533lYUhdjwnzBCuqj6dFaPZPLqSldnpRkxjOJ8tUV+VR54Vakqx7 CbS4oqPCtiW2GP0dLONMF+k= X-Google-Smtp-Source: ABdhPJzcGNGWAcIyzhGn3nbQK2CtmvxSCcdePO+OD9d6F0cJ+39tKSEi8scnnzCon2J/8kOxyRkixA== X-Received: by 2002:a05:6402:1705:: with SMTP id y5mr12271070edu.200.1643455993377; Sat, 29 Jan 2022 03:33:13 -0800 (PST) Received: from cosmos.lan (178.113.77.92.wireless.dyn.drei.com. [178.113.77.92]) by smtp.gmail.com with ESMTPSA id g6sm8885062ejz.170.2022.01.29.03.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 03:33:13 -0800 (PST) From: Christian Lachner To: perex@perex.cz, tiwai@suse.com, kailang@realtek.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Christian Lachner Subject: [PATCH 3/3] hda/realtek: Fix silent output on Gigabyte X570 Aorus Xtreme after reboot from Windows Date: Sat, 29 Jan 2022 12:32:43 +0100 Message-Id: <20220129113243.93068-4-gladiac@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220129113243.93068-1-gladiac@gmail.com> References: <20220129113243.93068-1-gladiac@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This commit switches the Gigabyte X570 Aorus Xtreme from using the ALC1220_FIXUP_CLEVO_P950 to the ALC1220_FIXUP_GB_X570 quirk. This fixes the no-audio after reboot from windows problem. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=3D205275 Signed-off-by: Christian Lachner --- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index ca8475c24187..a2e36bf0f25e 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -2552,7 +2552,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = =3D { SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte EP45-DS3/Z87X-UD3H", ALC889_FIXUP= _FRONT_HP_NO_PRESENCE), SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_D= UAL_CODECS), SND_PCI_QUIRK(0x1458, 0xa0cd, "Gigabyte X570 Aorus Master", ALC1220_FIXUP= _GB_X570), - SND_PCI_QUIRK(0x1458, 0xa0ce, "Gigabyte X570 Aorus Xtreme", ALC1220_FIXUP= _CLEVO_P950), + SND_PCI_QUIRK(0x1458, 0xa0ce, "Gigabyte X570 Aorus Xtreme", ALC1220_FIXUP= _GB_X570), SND_PCI_QUIRK(0x1458, 0xa0d5, "Gigabyte X570S Aorus Master", ALC1220_FIXU= P_GB_X570), SND_PCI_QUIRK(0x1462, 0x11f7, "MSI-GE63", ALC1220_FIXUP_CLEVO_P950), SND_PCI_QUIRK(0x1462, 0x1228, "MSI-GP63", ALC1220_FIXUP_CLEVO_P950), --=20 2.34.1