From nobody Tue Jun 30 00:49:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2736C433FE for ; Fri, 28 Jan 2022 13:00:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236498AbiA1NAK (ORCPT ); Fri, 28 Jan 2022 08:00:10 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:36046 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229869AbiA1NAH (ORCPT ); Fri, 28 Jan 2022 08:00:07 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: usama.anjum) with ESMTPSA id AD94F1F45F31 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1643374800; bh=qpjsngu8uHb7twpIdfcS2cTWB2a6x0Zf7hcMkNFCCDg=; h=From:To:Cc:Subject:Date:From; b=ka8jRs3ohT4RnrJ4hfU0FL2r3gzE/orqRLHZRhPg9LOki6toywWd0J3osiikd8jfi ZXv46gsxUWTMc4vx78IZx5Cd00/OOEUQWOrZXD4+E49ceBjRlhzl3SvheaG1KjrS9c +kVmVBafu2sXXCvuJZAUzdby9rLYgrVgjbVynoedKTI8YZJH6B695rb2/SmH4hzXdv tcuDOMnSJbAdH1MVrOjEvp0+j41LZZE05+d3n7s+fcmpeXereu3oXLUPmolTx07lmr 37rLEVI5223LsaDML8LjRAoFqhQO4vRtAnSkIYwD2t5f6L/uKUdCr6hAsOtN5ZqILL M90tZDOopcKjQ== From: Muhammad Usama Anjum To: Jean Delvare , Guenter Roeck Cc: Muhammad Usama Anjum , kernel@collabora.com, kernel-janitors@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hwmon: Remove checks for validity of dev Date: Fri, 28 Jan 2022 17:59:13 +0500 Message-Id: <20220128125913.1291533-1-usama.anjum@collabora.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" dev is being dereferenced in device_property_present() which means that it is valid. Don't check its validity again and simplify the code. Signed-off-by: Muhammad Usama Anjum --- drivers/hwmon/hwmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c index e36ea82da1474..aec32abd0a89f 100644 --- a/drivers/hwmon/hwmon.c +++ b/drivers/hwmon/hwmon.c @@ -822,7 +822,7 @@ __hwmon_device_register(struct device *dev, const char = *name, void *drvdata, hwdev->name =3D name; hdev->class =3D &hwmon_class; hdev->parent =3D dev; - hdev->of_node =3D dev ? dev->of_node : NULL; + hdev->of_node =3D dev->of_node; hwdev->chip =3D chip; dev_set_drvdata(hdev, drvdata); dev_set_name(hdev, HWMON_ID_FORMAT, id); @@ -834,7 +834,7 @@ __hwmon_device_register(struct device *dev, const char = *name, void *drvdata, =20 INIT_LIST_HEAD(&hwdev->tzdata); =20 - if (dev && dev->of_node && chip && chip->ops->read && + if (dev->of_node && chip && chip->ops->read && chip->info[0]->type =3D=3D hwmon_chip && (chip->info[0]->config[0] & HWMON_C_REGISTER_TZ)) { err =3D hwmon_thermal_register_sensors(hdev); --=20 2.30.2