From nobody Tue Jun 30 07:09:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66666C433F5 for ; Mon, 24 Jan 2022 04:26:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241355AbiAXE0o (ORCPT ); Sun, 23 Jan 2022 23:26:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbiAXE0m (ORCPT ); Sun, 23 Jan 2022 23:26:42 -0500 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53F8EC06173B for ; Sun, 23 Jan 2022 20:26:42 -0800 (PST) Received: by mail-pg1-x532.google.com with SMTP id v3so8931497pgc.1 for ; Sun, 23 Jan 2022 20:26:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :in-reply-to; bh=wg8p6MJoeXN1GheWHqOGh696C/oxn1QTFiYK3wt4Tk8=; b=HSKGIMxHPF0hjmGxZ7JnR8ZIymOJus9qLm27mkGXkFuSX0+AgExwJ56EGzvyG1Gzfe UI64p1Ar1V6vyHEH6ecabD8nhpmzlHy1Fwv/MTIYwKbSACopW+mUMwJ9dTkCFzPfMfxw XRm2H2dF8uDmGfCXmxx0dlJvXWyYo6vOsFd/H2Z9OjwOOfm+6SHKqUZ71qM9yNlLZ900 m0p0uUt0x5aCV8sc4bNRj4hR0w2fZZS6TeZPDRhMHxhVwSgLe5hXEORwIrrdFjSR/r+c KjPSQnWhjhZOUsfggnxoh2I60/3RNSH9bMaurInM7SD4pKaBxW04HqNl4YGgOA4AkDKl FePA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:in-reply-to; bh=wg8p6MJoeXN1GheWHqOGh696C/oxn1QTFiYK3wt4Tk8=; b=yFXFK7cgGYYhugvWp7Q5q1tgVgjFvzmMC+ew33hD546zv1n4HlcILJySQhRGegWrzD PuZbhg6YUF223iIhhVrDXuJfQI/wTbO/iv9gHiLdo5X1O3b7PggPnLbf0YYK71Ym/fw6 7vQ9qFQRA3ux0Ui0NbXKeeo9vandbcCZdiklGU8EweAWbjdIRJZD+cxM7/10M0HZYz3B wEhl4aB60+PJCGaXaLdjybLXR4BZ5jTSRcOZa92cmnsfCk3KGkLqXshA17jA6qdVUIAn QwhlDmctB3VG/MxPLlOOgSYSGkjlf42n+JYga0SeVVWb+3iqZPWPdeKj3PbB22pl6sqv sj1w== X-Gm-Message-State: AOAM530ubMUvsdIwdQpZXwt+8fhM6s+Q4ihGFF15OfILbz9KO8mcGd3I j0XggA0VVEI8rO8m2N5W58A= X-Google-Smtp-Source: ABdhPJxFGme3GKnWg91F82NBmqrmlLAp9xb2nFQdckwfSvKAecraKNcNxVAgPLLCvv9uz1LlfwzwtA== X-Received: by 2002:a05:6a00:2189:b0:4bc:3def:b662 with SMTP id h9-20020a056a00218900b004bc3defb662mr12747565pfi.5.1642998401887; Sun, 23 Jan 2022 20:26:41 -0800 (PST) Received: from mail.google.com (122-58-164-114-fibre.sparkbb.co.nz. [122.58.164.114]) by smtp.gmail.com with ESMTPSA id l10sm2070853pff.44.2022.01.23.20.26.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 20:26:41 -0800 (PST) Date: Mon, 24 Jan 2022 17:26:36 +1300 From: Paulo Miguel Almeida To: gregkh@linuxfoundation.org, paulo.miguel.almeida.rodenas@gmail.com, realwakka@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] staging: pi433: add missing register contants Message-ID: <20220124042636.GA7962@mail.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220124042506.GA7662@mail.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" add missing register constants present in RFM69 and/or RFM69HW so that we don't need to hardcode values when referencing them. this patch adds REG_TESTLNA, REG_TESTAFC constants Signed-off-by: Paulo Miguel Almeida --- drivers/staging/pi433/rf69_registers.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/pi433/rf69_registers.h b/drivers/staging/pi433= /rf69_registers.h index a170c66c3d5b..0d6737738841 100644 --- a/drivers/staging/pi433/rf69_registers.h +++ b/drivers/staging/pi433/rf69_registers.h @@ -89,9 +89,11 @@ #define REG_AESKEY16 0x4D #define REG_TEMP1 0x4E #define REG_TEMP2 0x4F +#define REG_TESTLNA 0x58 #define REG_TESTPA1 0x5A /* only present on RFM69HW */ #define REG_TESTPA2 0x5C /* only present on RFM69HW */ #define REG_TESTDAGC 0x6F +#define REG_TESTAFC 0x71 =20 /******************************************************/ /* RF69/SX1231 bit definition */ --=20 2.25.4 From nobody Tue Jun 30 07:09:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 716B3C433EF for ; Mon, 24 Jan 2022 04:27:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241381AbiAXE12 (ORCPT ); Sun, 23 Jan 2022 23:27:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbiAXE11 (ORCPT ); Sun, 23 Jan 2022 23:27:27 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4955C06173B for ; Sun, 23 Jan 2022 20:27:26 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id d7so14319283plr.12 for ; Sun, 23 Jan 2022 20:27:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :in-reply-to; bh=svTekGvyDZ2bj2QSTavJFICPjSj2BK/HSxFtjLcNUZg=; b=cj0eJduN2KD5xEDRexDuFEFl4CfVOoLVzYDtJOl6ELjecKQaraYubvOQIp/D4VOY7v UXiZigrN4Yxe2fl431ykYdmnkNlqcUUs3NdayA6V22qLlplls/yxNcjFPZqaNT/xj53e 52NV5Ib7Y8zOJ3OAbkDz2TO9D7FGMCP0/HHX9dxHUzYj5sD0fmVwbBp5uzlGRD49lgmQ bQHnFornUjHarm30lAbpt2/DNZJPsMBMvHrWroKKpHvrGrodTj7XH0v9wIQ3FexNMSU5 TDPxTbOGliqV3ns6VwnkwvAp9FOtk3poUVwbhbPkEtDASeOfwzdtLp5ymwDkwY/UE/wn OSQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:in-reply-to; bh=svTekGvyDZ2bj2QSTavJFICPjSj2BK/HSxFtjLcNUZg=; b=IC+XMJ9iOwAttwGivAhIQanvlZrNCR+pqbo4pPJDI2kg5geK7PL0Vy+hYXGx7RhsBb gYRGlMlocnGiw1JWAOqezcH12QcvYBzoaaVMqp2bIBVmoxLa63opK/PFvBgF5ckDSF5f cFC/BmCF+3eSLETPi9COnrj5r8SdW26Y/oFDo6lbQber4otEhGYPkIaXkg6wNb3J5/Ff /5L8/AZYKqkzb4go7QjdjXZensCoXkV8Qtzf6RADeAGS3vNTm9s1AE02TNMXi9OAI/h6 IHpPUeUs/Z1yRVq7mgxaRvJbjkAx0bN/Ceg9qyEXndIBsnQ8c+VqcIexFejOzcr5QeuD zggg== X-Gm-Message-State: AOAM533AuKSatKT7i5SxmF0rC5L7588UKs7lsVyyCreDi0niUbk4XPCl MMthllZFNlKEf8yS7PfmFD4= X-Google-Smtp-Source: ABdhPJwKJtczzDDaS0Jalw6m0S4Hj+FDST5vD3k+dEoP4A9L2yVgAJ4dVMz4b4B7Ef/4kbkBPUgj0g== X-Received: by 2002:a17:902:b40c:b0:14a:792:741f with SMTP id x12-20020a170902b40c00b0014a0792741fmr12884384plr.113.1642998446441; Sun, 23 Jan 2022 20:27:26 -0800 (PST) Received: from mail.google.com (122-58-164-114-fibre.sparkbb.co.nz. [122.58.164.114]) by smtp.gmail.com with ESMTPSA id 189sm2875339pfg.142.2022.01.23.20.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 20:27:26 -0800 (PST) Date: Mon, 24 Jan 2022 17:27:21 +1300 From: Paulo Miguel Almeida To: gregkh@linuxfoundation.org, paulo.miguel.almeida.rodenas@gmail.com, realwakka@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] staging: pi433: add debugfs interface Message-ID: <20220124042721.GA8078@mail.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220124042506.GA7662@mail.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This adds debugfs interface that can be used for debugging possible hardware/software issues. It currently exposes the following debugfs entries for each SPI device probed: /sys/kernel/debug/pi433//regs ... The 'regs' file contains all rf69 uC registers values that are useful for troubleshooting misconfigurations between 2 devices. It contains one register per line so it should be easy to use normal filtering tools to find the registers of interest if needed. Signed-off-by: Paulo Miguel Almeida --- drivers/staging/pi433/pi433_if.c | 80 ++++++++++++++++++++++++++++++++ drivers/staging/pi433/rf69.c | 2 +- drivers/staging/pi433/rf69.h | 1 + 3 files changed, 82 insertions(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index 17ff51f6a9da..54bb2af2c2ea 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -41,6 +41,8 @@ #ifdef CONFIG_COMPAT #include #endif +#include +#include =20 #include "pi433_if.h" #include "rf69.h" @@ -1102,11 +1104,77 @@ static const struct file_operations pi433_fops =3D { .llseek =3D no_llseek, }; =20 +static int pi433_debugfs_regs_show(struct seq_file *m, void *p) +{ + struct pi433_device *dev; + u8 reg_data[114]; + size_t i; + char *fmt =3D "0x%02x, 0x%02x\n"; + + dev =3D m->private; + + // acquire locks to avoid race conditions + mutex_lock(&dev->tx_fifo_lock); + mutex_lock(&dev->rx_lock); + + // wait for on-going operations to finish + if (dev->tx_active) + wait_event_interruptible(dev->rx_wait_queue, !dev->tx_active); + + if (dev->rx_active) + wait_event_interruptible(dev->tx_wait_queue, !dev->rx_active); + + // read contiguous regs + // skip FIFO register (0x0) otherwise this can affect some of uC ops + for (i =3D 1; i < 0x50; i++) + reg_data[i] =3D rf69_read_reg(dev->spi, i); + + // read non-contiguous regs + reg_data[REG_TESTLNA] =3D rf69_read_reg(dev->spi, REG_TESTLNA); + reg_data[REG_TESTPA1] =3D rf69_read_reg(dev->spi, REG_TESTPA1); + reg_data[REG_TESTPA2] =3D rf69_read_reg(dev->spi, REG_TESTPA2); + reg_data[REG_TESTDAGC] =3D rf69_read_reg(dev->spi, REG_TESTDAGC); + reg_data[REG_TESTAFC] =3D rf69_read_reg(dev->spi, REG_TESTAFC); + + seq_puts(m, "# reg, val\n"); + + // print contiguous regs + for (i =3D 1; i < 0x50; i++) + seq_printf(m, fmt, i, reg_data[i]); + + // print non-contiguous regs + seq_printf(m, fmt, REG_TESTLNA, reg_data[REG_TESTLNA]); + seq_printf(m, fmt, REG_TESTPA1, reg_data[REG_TESTPA1]); + seq_printf(m, fmt, REG_TESTPA2, reg_data[REG_TESTPA2]); + seq_printf(m, fmt, REG_TESTDAGC, reg_data[REG_TESTDAGC]); + seq_printf(m, fmt, REG_TESTAFC, reg_data[REG_TESTAFC]); + + // release locks + mutex_unlock(&dev->tx_fifo_lock); + mutex_unlock(&dev->rx_lock); + + return 0; +} + +static ssize_t pi433_debugfs_regs_open(struct inode *inode, struct file *f= ilp) +{ + return single_open(filp, pi433_debugfs_regs_show, inode->i_private); +} + +static const struct file_operations debugfs_fops =3D { + .llseek =3D seq_lseek, + .open =3D pi433_debugfs_regs_open, + .owner =3D THIS_MODULE, + .read =3D seq_read, + .release =3D single_release +}; + /*------------------------------------------------------------------------= -*/ =20 static int pi433_probe(struct spi_device *spi) { struct pi433_device *device; + struct dentry *entry; /* debugfs */ int retval; =20 /* setup spi parameters */ @@ -1256,6 +1324,11 @@ static int pi433_probe(struct spi_device *spi) /* spi setup */ spi_set_drvdata(spi, device); =20 + /* debugfs setup */ + entry =3D debugfs_create_dir(dev_name(device->dev), + debugfs_lookup(KBUILD_MODNAME, NULL)); + debugfs_create_file("regs", 0400, entry, device, &debugfs_fops); + return 0; =20 del_cdev: @@ -1279,6 +1352,10 @@ static int pi433_probe(struct spi_device *spi) static int pi433_remove(struct spi_device *spi) { struct pi433_device *device =3D spi_get_drvdata(spi); + struct dentry *mod_entry =3D debugfs_lookup(KBUILD_MODNAME, NULL); + + /* debugfs */ + debugfs_remove(debugfs_lookup(dev_name(device->dev), mod_entry)); =20 /* free GPIOs */ free_gpio(device); @@ -1353,6 +1430,8 @@ static int __init pi433_init(void) return PTR_ERR(pi433_class); } =20 + debugfs_create_dir(KBUILD_MODNAME, NULL); + status =3D spi_register_driver(&pi433_spi_driver); if (status < 0) { class_destroy(pi433_class); @@ -1370,6 +1449,7 @@ static void __exit pi433_exit(void) spi_unregister_driver(&pi433_spi_driver); class_destroy(pi433_class); unregister_chrdev(MAJOR(pi433_dev), pi433_spi_driver.driver.name); + debugfs_remove_recursive(debugfs_lookup(KBUILD_MODNAME, NULL)); } module_exit(pi433_exit); =20 diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index d60514a840c2..b1a3382f4042 100644 --- a/drivers/staging/pi433/rf69.c +++ b/drivers/staging/pi433/rf69.c @@ -24,7 +24,7 @@ =20 /*------------------------------------------------------------------------= -*/ =20 -static u8 rf69_read_reg(struct spi_device *spi, u8 addr) +u8 rf69_read_reg(struct spi_device *spi, u8 addr) { int retval; =20 diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h index c25942f142a6..3ff5609ecf2e 100644 --- a/drivers/staging/pi433/rf69.h +++ b/drivers/staging/pi433/rf69.h @@ -17,6 +17,7 @@ #define FIFO_SIZE 66 /* bytes */ #define FIFO_THRESHOLD 15 /* bytes */ =20 +u8 rf69_read_reg(struct spi_device *spi, u8 addr); int rf69_get_version(struct spi_device *spi); int rf69_set_mode(struct spi_device *spi, enum mode mode); int rf69_set_data_mode(struct spi_device *spi, u8 data_mode); --=20 2.25.4