From nobody Tue Jun 30 06:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2888FC433EF for ; Mon, 24 Jan 2022 03:45:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241080AbiAXDpG (ORCPT ); Sun, 23 Jan 2022 22:45:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241072AbiAXDpE (ORCPT ); Sun, 23 Jan 2022 22:45:04 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EEE6C06173B for ; Sun, 23 Jan 2022 19:45:04 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id w190so8414152pfw.7 for ; Sun, 23 Jan 2022 19:45:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8+nbXvw94PzoNmHfYGu561mFtWJdPhsIQ7x5qJXCJwc=; b=d0Kpe/sOGKJAd1FxWY5F/WWuCkTWDIyJyyCzeS28umlb8BUqoyDse1LohIIXP4+k49 D0ccvsP3i+coZq/tBupobh0bByousAnwoHa+aXk3W+wpZJBzFUyJdux+MKq/Ig5Z7ofA h5LBetSRv4/8Wgz+szrRVZEBn4fEFjF7aaRvrOy/p4bmfZrysJOHmw5SaWj3+CSGgMgU KJonOKHWn3hRiJa3WvqTh1zR7NBYZCJCVeShzIekI8AEYtILjBdYUw0TGaqBvOh9Mm/o 3hB3lnR26QQab9wKxLnLWiWW69nKOMPqGwoTpJCT21honpP/Z971/0ro0g6r4dttjIrs lXCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8+nbXvw94PzoNmHfYGu561mFtWJdPhsIQ7x5qJXCJwc=; b=Wcz6ZhVpe+O+UTOmyDM7oFWZIr85Qq5+NV24jI4mMH+oA+Gw6seP0WzI3ICj6swMDg XNA1FVuAIa5gK8dZSplwhuol3YtDVwfBrcxWA7AF/YW6ny74DSR1RoOxvI2vd+I0R/+C gSqoJ3cFWmhuC43yXsNurLHnY+dUDo4E87LX1wIhSndr5ffe9QaO5Y9B9Irchg06mvUR tGyB67CCcXkaJQUX+vTZa6UPqnsHe+Q9BnxZne2WVyXntB+Lec0ggKQecIUzefGXR72F xBuf5MOBaMm9xyAnM1BzPbsSbTk+lxY4kR6Zl2ma3gaIuRmbB+8MZocCebWOBEfiTxKl L0ag== X-Gm-Message-State: AOAM531CaQKx1MYzWRCsk8Nw9Ce1LuSQ3hAi0URXX+UV6BXufUQpy7tM y9UY0ecxgz1IAWYO4w0bZOM= X-Google-Smtp-Source: ABdhPJzxaiP8PVfayZs9NI91HT/VTWIetRnfnaWf+VxX8S/yC6wXePeMrhkiV3Zk4DuzQrf5YJvNUQ== X-Received: by 2002:a63:2b84:: with SMTP id r126mr10522298pgr.624.1642995903985; Sun, 23 Jan 2022 19:45:03 -0800 (PST) Received: from localhost.localdomain ([27.7.142.194]) by smtp.gmail.com with ESMTPSA id p38sm9853390pgb.36.2022.01.23.19.45.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 19:45:03 -0800 (PST) From: Jagath Jog J To: gregkh@linuxfoundation.org, hdegoede@redhat.com, Larry.Finger@lwfinger.net Cc: fabioaiuto83@gmail.com, dan.carpenter@oracle.com, marcocesati@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, jagathjog1996@gmail.com Subject: [Patch 1/3] Staging: rtl8723bs: Placing opening { braces in previous line Date: Mon, 24 Jan 2022 09:14:54 +0530 Message-Id: <20220124034456.8665-2-jagathjog1996@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220124034456.8665-1-jagathjog1996@gmail.com> References: <20220124034456.8665-1-jagathjog1996@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fix following checkpatch.pl error by placing opening { braces in previous line ERROR: that open brace { should be on the previous line Signed-off-by: Jagath Jog J Reviewed-by: Hans de Goede --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 98 ++++++------------- 1 file changed, 32 insertions(+), 66 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 5157b5b12597..43b5604c0bca 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -113,13 +113,10 @@ static struct ieee80211_supported_band *rtw_spt_band_= alloc( struct ieee80211_supported_band *spt_band =3D NULL; int n_channels, n_bitrates; =20 - if (band =3D=3D NL80211_BAND_2GHZ) - { + if (band =3D=3D NL80211_BAND_2GHZ) { n_channels =3D RTW_2G_CHANNELS_NUM; n_bitrates =3D RTW_G_RATES_NUM; - } - else - { + } else { goto exit; } =20 @@ -135,8 +132,7 @@ static struct ieee80211_supported_band *rtw_spt_band_al= loc( spt_band->n_channels =3D n_channels; spt_band->n_bitrates =3D n_bitrates; =20 - if (band =3D=3D NL80211_BAND_2GHZ) - { + if (band =3D=3D NL80211_BAND_2GHZ) { rtw_2g_channels_init(spt_band->channels); rtw_2g_rates_init(spt_band->bitrates); } @@ -235,8 +231,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl { u16 wapi_len =3D 0; =20 - if (rtw_get_wapi_ie(pnetwork->network.ies, pnetwork->network.ie_length, = NULL, &wapi_len) > 0) - { + if (rtw_get_wapi_ie(pnetwork->network.ies, pnetwork->network.ie_length, = NULL, &wapi_len) > 0) { if (wapi_len > 0) goto exit; } @@ -244,8 +239,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl =20 /* To reduce PBC Overlap rate */ /* spin_lock_bh(&pwdev_priv->scan_req_lock); */ - if (adapter_wdev_data(padapter)->scan_request) - { + if (adapter_wdev_data(padapter)->scan_request) { u8 *psr =3D NULL, sr =3D 0; struct ndis_802_11_ssid *pssid =3D &pnetwork->network.ssid; struct cfg80211_scan_request *request =3D adapter_wdev_data(padapter)->s= can_request; @@ -258,14 +252,12 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct a= dapter *padapter, struct wl if (wpsie && wpsielen > 0) psr =3D rtw_get_wps_attr_content(wpsie, wpsielen, WPS_ATTR_SELECTED_RE= GISTRAR, (u8 *)(&sr), NULL); =20 - if (sr !=3D 0) - { - if (request->n_ssids =3D=3D 1 && request->n_channels =3D=3D 1) /* it m= eans under processing WPS */ - { + if (sr !=3D 0) { + /* it means under processing WPS */ + if (request->n_ssids =3D=3D 1 && request->n_channels =3D=3D 1) { if (ssids[0].ssid_len !=3D 0 && (pssid->ssid_length !=3D ssids[0].ssid_len || - memcmp(pssid->ssid, ssids[0].ssid, ssids[0].ssid_len))) - { + memcmp(pssid->ssid, ssids[0].ssid, ssids[0].ssid_len))) { if (psr) *psr =3D 0; /* clear sr */ } @@ -374,8 +366,7 @@ void rtw_cfg80211_ibss_indicate_connect(struct adapter = *padapter) int freq =3D (int)cur_network->network.configuration.ds_config; struct ieee80211_channel *chan; =20 - if (pwdev->iftype !=3D NL80211_IFTYPE_ADHOC) - { + if (pwdev->iftype !=3D NL80211_IFTYPE_ADHOC) { return; } =20 @@ -383,14 +374,11 @@ void rtw_cfg80211_ibss_indicate_connect(struct adapte= r *padapter) struct wlan_bssid_ex *pnetwork =3D &(padapter->mlmeextpriv.mlmext_info.= network); struct wlan_network *scanned =3D pmlmepriv->cur_network_scanned; =20 - if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) - { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) { =20 memcpy(&cur_network->network, pnetwork, sizeof(struct wlan_bssid_ex)); rtw_cfg80211_inform_bss(padapter, cur_network); - } - else - { + } else { if (!scanned) { rtw_warn_on(1); return; @@ -473,9 +461,7 @@ void rtw_cfg80211_indicate_connect(struct adapter *pada= pter) roam_info.resp_ie_len =3D pmlmepriv->assoc_rsp_len-sizeof(struct ieee80211_hdr_3addr)-6; cfg80211_roamed(padapter->pnetdev, &roam_info, GFP_ATOMIC); - } - else - { + } else { cfg80211_connect_result(padapter->pnetdev, cur_network->network.mac_addr= ess , pmlmepriv->assoc_req+sizeof(struct ieee80211_hdr_3addr)+2 , pmlmepriv->assoc_req_len-sizeof(struct ieee80211_hdr_3addr)-2 @@ -527,24 +513,19 @@ static int rtw_cfg80211_ap_set_encryption(struct net_= device *dev, struct ieee_pa param->u.crypt.err =3D 0; param->u.crypt.alg[IEEE_CRYPT_ALG_NAME_LEN - 1] =3D '\0'; =20 - if (param_len !=3D sizeof(struct ieee_param) + param->u.crypt.key_len) - { + if (param_len !=3D sizeof(struct ieee_param) + param->u.crypt.key_len) { ret =3D -EINVAL; goto exit; } =20 if (param->sta_addr[0] =3D=3D 0xff && param->sta_addr[1] =3D=3D 0xff && param->sta_addr[2] =3D=3D 0xff && param->sta_addr[3] =3D=3D 0xff && - param->sta_addr[4] =3D=3D 0xff && param->sta_addr[5] =3D=3D 0xff) - { - if (param->u.crypt.idx >=3D WEP_KEYS) - { + param->sta_addr[4] =3D=3D 0xff && param->sta_addr[5] =3D=3D 0xff) { + if (param->u.crypt.idx >=3D WEP_KEYS) { ret =3D -EINVAL; goto exit; } - } - else - { + } else { psta =3D rtw_get_stainfo(pstapriv, param->sta_addr); if (!psta) /* ret =3D -EINVAL; */ @@ -554,24 +535,20 @@ static int rtw_cfg80211_ap_set_encryption(struct net_= device *dev, struct ieee_pa if (strcmp(param->u.crypt.alg, "none") =3D=3D 0 && !psta) goto exit; =20 - if (strcmp(param->u.crypt.alg, "WEP") =3D=3D 0 && !psta) - { + if (strcmp(param->u.crypt.alg, "WEP") =3D=3D 0 && !psta) { wep_key_idx =3D param->u.crypt.idx; wep_key_len =3D param->u.crypt.key_len; =20 - if ((wep_key_idx >=3D WEP_KEYS) || (wep_key_len <=3D 0)) - { + if ((wep_key_idx >=3D WEP_KEYS) || (wep_key_len <=3D 0)) { ret =3D -EINVAL; goto exit; } =20 - if (wep_key_len > 0) - { + if (wep_key_len > 0) { wep_key_len =3D wep_key_len <=3D 5 ? 5 : 13; } =20 - if (psecuritypriv->bWepDefaultKeyIdxSet =3D=3D 0) - { + if (psecuritypriv->bWepDefaultKeyIdxSet =3D=3D 0) { /* wep default key has not been set, so use this key index as default k= ey. */ =20 psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_Auto; @@ -579,8 +556,7 @@ static int rtw_cfg80211_ap_set_encryption(struct net_de= vice *dev, struct ieee_pa psecuritypriv->dot11PrivacyAlgrthm =3D _WEP40_; psecuritypriv->dot118021XGrpPrivacy =3D _WEP40_; =20 - if (wep_key_len =3D=3D 13) - { + if (wep_key_len =3D=3D 13) { psecuritypriv->dot11PrivacyAlgrthm =3D _WEP104_; psecuritypriv->dot118021XGrpPrivacy =3D _WEP104_; } @@ -598,24 +574,19 @@ static int rtw_cfg80211_ap_set_encryption(struct net_= device *dev, struct ieee_pa =20 } =20 - - if (!psta && check_fwstate(pmlmepriv, WIFI_AP_STATE)) /* group key */ - { - if (param->u.crypt.set_tx =3D=3D 0) /* group key */ - { - if (strcmp(param->u.crypt.alg, "WEP") =3D=3D 0) - { + /* group key */ + if (!psta && check_fwstate(pmlmepriv, WIFI_AP_STATE)) { + /* group key */ + if (param->u.crypt.set_tx =3D=3D 0) { + if (strcmp(param->u.crypt.alg, "WEP") =3D=3D 0) { memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 := param->u.crypt.key_len)); =20 psecuritypriv->dot118021XGrpPrivacy =3D _WEP40_; - if (param->u.crypt.key_len =3D=3D 13) - { + if (param->u.crypt.key_len =3D=3D 13) { psecuritypriv->dot118021XGrpPrivacy =3D _WEP104_; } =20 - } - else if (strcmp(param->u.crypt.alg, "TKIP") =3D=3D 0) - { + } else if (strcmp(param->u.crypt.alg, "TKIP") =3D=3D 0) { psecuritypriv->dot118021XGrpPrivacy =3D _TKIP_; =20 memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 := param->u.crypt.key_len)); @@ -627,15 +598,11 @@ static int rtw_cfg80211_ap_set_encryption(struct net_= device *dev, struct ieee_pa =20 psecuritypriv->busetkipkey =3D true; =20 - } - else if (strcmp(param->u.crypt.alg, "CCMP") =3D=3D 0) - { + } else if (strcmp(param->u.crypt.alg, "CCMP") =3D=3D 0) { psecuritypriv->dot118021XGrpPrivacy =3D _AES_; =20 memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 := param->u.crypt.key_len)); - } - else - { + } else { psecuritypriv->dot118021XGrpPrivacy =3D _NO_PRIVACY_; } =20 @@ -648,8 +615,7 @@ static int rtw_cfg80211_ap_set_encryption(struct net_de= vice *dev, struct ieee_pa rtw_ap_set_group_key(padapter, param->u.crypt.key, psecuritypriv->dot11= 8021XGrpPrivacy, param->u.crypt.idx); =20 pbcmc_sta =3D rtw_get_bcmc_stainfo(padapter); - if (pbcmc_sta) - { + if (pbcmc_sta) { pbcmc_sta->ieee8021x_blocked =3D false; pbcmc_sta->dot118021XPrivacy =3D psecuritypriv->dot118021XGrpPrivacy;/= * rx will use bmc_sta's dot118021XPrivacy */ } --=20 2.17.1 From nobody Tue Jun 30 06:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 198A3C433EF for ; Mon, 24 Jan 2022 03:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241087AbiAXDpJ (ORCPT ); Sun, 23 Jan 2022 22:45:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241082AbiAXDpH (ORCPT ); Sun, 23 Jan 2022 22:45:07 -0500 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CDAEC06173D for ; Sun, 23 Jan 2022 19:45:07 -0800 (PST) Received: by mail-pg1-x536.google.com with SMTP id e16so4814411pgn.4 for ; Sun, 23 Jan 2022 19:45:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=o5goEzVTL8jcl0JNIqgZWIhooaVKAMAMA+en32+iljw=; b=qP8cVR6TY+bklbJiYJNaATSc+XFaZvjghft5GhaE2ulpWRl+guuUEFPza8K10W0ANm wM56kGzB6BG94XYS+N20Z4/t6UTjIqx2bcXV02DpPSol4omEiHPExrYbsbg7sIDarHEe QeFAaKgYWXrGdo99Md4qnNcYMWWgQ7WW7KCKR7dxydbfjw1jEGR5/rDOtxE5XqYfnGCs mT74LzASZhuRKjVuk3EoyAKwaM5Iw6nCXt6e79IQ6A2jecGo8U2+b2WCQURpqvVirltI TuVU2j9DfRIRVrKZMyXGo91Y/wIPqcMJbHhoqFMpd8flbr2TrCo2OAJlzZOzLdFXzj+M 69zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=o5goEzVTL8jcl0JNIqgZWIhooaVKAMAMA+en32+iljw=; b=ia7W74Pr/TSAkLPbLT17U2ApL3UmEIQ4/n8R+hd4wRnSC2ONIma+v8kwVjbLQlfS1O mFAvlUdROtuQm+lSlh/kpoEHxxuNolbVbSlcADuIFhyoDLqJ9eIt+KTqSU/gHYjGTTn6 p0JaYTeFRqUqSMUSr0woHBgxzMhAWHmXIjcEahOAOfX4SgibqJjkXQ7avTzmesgBfQBm CHOhY3be1RkwYsUASm1hbx0Fm/Vw0p9sRaMBU/BZlws4Sdg6RTZxlzya9+5Fqe7BOkxp OdBbJwgpVCAc/8k8ZeU1vSpjLrNZDRrdVPkfENqBw8K1BfROdOLY2qJn790r5i8clBmO u6rQ== X-Gm-Message-State: AOAM531Fg4+m9zhv80ShZ7MSq74lBSNwtjRKRJsioyZ/Uae13u0cmo4s psi/WZ8Jl5EY8qKB5OBDuRU= X-Google-Smtp-Source: ABdhPJxrtmYNC8f6EujWuQAHjiV04DUJZZgQCztAO28ohBunjINzlUDHQjO8glKft91l1wUzuZaQSg== X-Received: by 2002:a62:7602:0:b0:4c6:864b:6400 with SMTP id r2-20020a627602000000b004c6864b6400mr12604078pfc.14.1642995906830; Sun, 23 Jan 2022 19:45:06 -0800 (PST) Received: from localhost.localdomain ([27.7.142.194]) by smtp.gmail.com with ESMTPSA id p38sm9853390pgb.36.2022.01.23.19.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 19:45:06 -0800 (PST) From: Jagath Jog J To: gregkh@linuxfoundation.org, hdegoede@redhat.com, Larry.Finger@lwfinger.net Cc: fabioaiuto83@gmail.com, dan.carpenter@oracle.com, marcocesati@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, jagathjog1996@gmail.com Subject: [Patch 2/3] Staging: rtl8723bs: Removed extra spaces between datatype and variable Date: Mon, 24 Jan 2022 09:14:55 +0530 Message-Id: <20220124034456.8665-3-jagathjog1996@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220124034456.8665-1-jagathjog1996@gmail.com> References: <20220124034456.8665-1-jagathjog1996@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fix following checkpatch.pl warning by placing single space between datatype and variable WARNING: please, no space before tabs Signed-off-by: Jagath Jog J Reviewed-by: Hans de Goede --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 54 ++++++++++++------------ 1 file changed, 26 insertions(+), 28 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index b28351a97cd3..14d37b369273 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -531,9 +531,9 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct= ndis_802_11_ssid *ssid, struct rtw_ieee80211_channel *ch, int ch_num) { u8 res =3D _FAIL; - struct cmd_obj *ph2c; - struct sitesurvey_parm *psurveyPara; - struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; + struct cmd_obj *ph2c; + struct sitesurvey_parm *psurveyPara; + struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 if (check_fwstate(pmlmepriv, _FW_LINKED)) @@ -632,8 +632,8 @@ void rtw_getbbrfreg_cmdrsp_callback(struct adapter *pad= apter, struct cmd_obj *p u8 rtw_createbss_cmd(struct adapter *padapter) { struct cmd_obj *pcmd; - struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; - struct wlan_bssid_ex *pdev_network =3D &padapter->registrypriv.dev_netwo= rk; + struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; + struct wlan_bssid_ex *pdev_network =3D &padapter->registrypriv.dev_networ= k; u8 res =3D _SUCCESS; =20 pcmd =3D rtw_zmalloc(sizeof(struct cmd_obj)); @@ -707,14 +707,14 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct = wlan_network *pnetwork) { u8 res =3D _SUCCESS; uint t_len =3D 0; - struct wlan_bssid_ex *psecnetwork; - struct cmd_obj *pcmd; - struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; - struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - struct qos_priv *pqospriv =3D &pmlmepriv->qospriv; + struct wlan_bssid_ex *psecnetwork; + struct cmd_obj *pcmd; + struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; + struct qos_priv *pqospriv =3D &pmlmepriv->qospriv; struct security_priv *psecuritypriv =3D &padapter->securitypriv; struct registry_priv *pregistrypriv =3D &padapter->registrypriv; - struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; + struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; enum ndis_802_11_network_infrastructure ndis_network_mode =3D pnetwork->n= etwork.infrastructure_mode; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; @@ -789,9 +789,9 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wl= an_network *pnetwork) phtpriv->ht_option =3D false; ptmp =3D rtw_get_ie(&pnetwork->network.ies[12], WLAN_EID_HT_CAPABILITY, &= tmp_len, pnetwork->network.ie_length-12); if (pregistrypriv->ht_enable && ptmp && tmp_len > 0) { - /* Added by Albert 2010/06/23 */ - /* For the WEP mode, we will use the bg mode to do the connection to av= oid some IOT issue. */ - /* Especially for Realtek 8192u SoftAP. */ + /* Added by Albert 2010/06/23 */ + /* For the WEP mode, we will use the bg mode to do the connection to avo= id some IOT issue. */ + /* Especially for Realtek 8192u SoftAP. */ if ((padapter->securitypriv.dot11PrivacyAlgrthm !=3D _WEP40_) && (padapter->securitypriv.dot11PrivacyAlgrthm !=3D _WEP104_) && (padapter->securitypriv.dot11PrivacyAlgrthm !=3D _TKIP_)) { @@ -897,12 +897,11 @@ u8 rtw_setopmode_cmd(struct adapter *padapter, enum = ndis_802_11_network_infrast u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 un= icast_key, bool enqueue) { struct cmd_obj *ph2c; - struct set_stakey_parm *psetstakey_para; - struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; - struct set_stakey_rsp *psetstakey_rsp =3D NULL; - - struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - struct security_priv *psecuritypriv =3D &padapter->securitypriv; + struct set_stakey_parm *psetstakey_para; + struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; + struct set_stakey_rsp *psetstakey_rsp =3D NULL; + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; + struct security_priv *psecuritypriv =3D &padapter->securitypriv; u8 res =3D _SUCCESS; =20 psetstakey_para =3D rtw_zmalloc(sizeof(struct set_stakey_parm)); @@ -957,9 +956,9 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct s= ta_info *sta, u8 unicast_ u8 rtw_clearstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 = enqueue) { struct cmd_obj *ph2c; - struct set_stakey_parm *psetstakey_para; - struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; - struct set_stakey_rsp *psetstakey_rsp =3D NULL; + struct set_stakey_parm *psetstakey_para; + struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; + struct set_stakey_rsp *psetstakey_rsp =3D NULL; s16 cam_id =3D 0; u8 res =3D _SUCCESS; =20 @@ -1009,9 +1008,9 @@ u8 rtw_clearstakey_cmd(struct adapter *padapter, stru= ct sta_info *sta, u8 enqueu =20 u8 rtw_addbareq_cmd(struct adapter *padapter, u8 tid, u8 *addr) { - struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; + struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; struct cmd_obj *ph2c; - struct addBaReq_parm *paddbareq_parm; + struct addBaReq_parm *paddbareq_parm; =20 u8 res =3D _SUCCESS; =20 @@ -1228,8 +1227,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, = u8 from_timer) u16 BusyThreshold =3D BusyThresholdHigh; u8 bBusyTraffic =3D false, bTxBusyTraffic =3D false, bRxBusyTraffic =3D f= alse; u8 bHigherBusyTraffic =3D false, bHigherBusyRxTraffic =3D false, bHigherB= usyTxTraffic =3D false; - - struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 collect_traffic_statistics(padapter); =20 @@ -1409,7 +1407,7 @@ void lps_ctrl_wk_hdl(struct adapter *padapter, u8 lps= _ctrl_type) u8 rtw_lps_ctrl_wk_cmd(struct adapter *padapter, u8 lps_ctrl_type, u8 enqu= eue) { struct cmd_obj *ph2c; - struct drvextra_cmd_parm *pdrvextra_cmd_parm; + struct drvextra_cmd_parm *pdrvextra_cmd_parm; struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; /* struct pwrctrl_priv *pwrctrlpriv =3D adapter_to_pwrctl(padapter); */ u8 res =3D _SUCCESS; --=20 2.17.1 From nobody Tue Jun 30 06:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2888BC433F5 for ; Mon, 24 Jan 2022 03:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241095AbiAXDpL (ORCPT ); Sun, 23 Jan 2022 22:45:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241090AbiAXDpK (ORCPT ); Sun, 23 Jan 2022 22:45:10 -0500 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 188F1C06173B for ; Sun, 23 Jan 2022 19:45:10 -0800 (PST) Received: by mail-pg1-x531.google.com with SMTP id t32so14109162pgm.7 for ; Sun, 23 Jan 2022 19:45:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tb8ev88MIiS9qrS2N39+coBDw1ZgKiiPgwQGLIy8NO0=; b=gh96JrdmAPsc3vo6qQxKFADlpyd8LFLO5olb3vqBrStdF45pW+n0QcSP602gA3hBEU vrwHNLqoYKQBonkebuD1MwqDQcyL5qO1lMYU8hbac8rcOJHbhlsZGyKRw+UODPSXTTZx yCgf0I0vJxh7/bI1SDb3TmNMuuVdaDWgvo9TTXFDBl/sn+Ncl6wsufslVow0wP9nMiMh GxlLJ0NuIIwVTEWrjWm0kcxMfO8saGIbGaCK/ZrHSvfcWFqZsPXknCCsbK6B4Hdk5lqu ZYMv5wGvg9DWSvUzW5r5/6l+e2mjtDfIYe6Z15qR9a9yRKBupmIY5i/JLxnWUQeeN4qq GgIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tb8ev88MIiS9qrS2N39+coBDw1ZgKiiPgwQGLIy8NO0=; b=sEgzsftxMutcRo1ePxYBOytVLo/++Y/tlewuBuEtK7TN0MKqH346RupfbtkyXIMJKJ SM92xAaea1n429XsTuvss9JQPftO45rKGTk53AnLD25E1ZL/j6Hh/xkC/r/RPYkJnFDZ 9hI1f+jZ4LPXa2IPKdlg82yWsmXckuBfPuqNVvfRhP3oD6BSNUAQHT0K5yeM3iD1AXkY /xrkma1m1kJH9vUtvI1Dyody3Kbf5Vl9JADAIbti+ohuelDeWVH+Loh3BTvi9jBDPiJR jRW31o1ykPzIozZ/XYbZdXBHKE+F9VvF3WZsI6mFlqS82eebE8fqjv8coLom4ZDR+2v+ jXCQ== X-Gm-Message-State: AOAM532IYzIUb8OfE8oZwmLCx8MZ6DWrbsByj5IMN7i15TnrzT1d56XF Sx3NULYoyxKGqhCvCcmQa0U= X-Google-Smtp-Source: ABdhPJxNnfREXnof87U37sNWFZ2xiV4qj18RlwYBQyDNpnGgxu5CdKxZB8dkppEQ/4BfzAznDv/Y4g== X-Received: by 2002:a05:6a00:b84:b0:4c8:fe03:94f8 with SMTP id g4-20020a056a000b8400b004c8fe0394f8mr3563911pfj.33.1642995909597; Sun, 23 Jan 2022 19:45:09 -0800 (PST) Received: from localhost.localdomain ([27.7.142.194]) by smtp.gmail.com with ESMTPSA id p38sm9853390pgb.36.2022.01.23.19.45.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 19:45:09 -0800 (PST) From: Jagath Jog J To: gregkh@linuxfoundation.org, hdegoede@redhat.com, Larry.Finger@lwfinger.net Cc: fabioaiuto83@gmail.com, dan.carpenter@oracle.com, marcocesati@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, jagathjog1996@gmail.com Subject: [Patch 3/3] Staging: rtl8723bs: Inserting blank line after declaration Date: Mon, 24 Jan 2022 09:14:56 +0530 Message-Id: <20220124034456.8665-4-jagathjog1996@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220124034456.8665-1-jagathjog1996@gmail.com> References: <20220124034456.8665-1-jagathjog1996@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fix following checkpatch.pl warning by inserting blank line WARNING: Missing a blank line after declarations Signed-off-by: Jagath Jog J Reviewed-by: Hans de Goede --- drivers/staging/rtl8723bs/hal/hal_intf.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index 4868a69cdb8f..94ecefb9113d 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -181,6 +181,7 @@ void rtw_hal_disable_interrupt(struct adapter *padapter) u8 rtw_hal_check_ips_status(struct adapter *padapter) { u8 val =3D false; + if (padapter->HalFunc.check_ips_status) val =3D padapter->HalFunc.check_ips_status(padapter); =20 @@ -209,6 +210,7 @@ s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_= frame *pxmitframe) s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntfr= ame) { s32 ret =3D _FAIL; + update_mgntframe_attrib_addr(padapter, pmgntframe); /* pframe =3D (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET; */ /* pwlanhdr =3D (struct rtw_ieee80211_hdr *)pframe; */ @@ -299,6 +301,7 @@ void rtw_hal_stop_thread(struct adapter *padapter) u32 rtw_hal_read_bbreg(struct adapter *padapter, u32 RegAddr, u32 BitMask) { u32 data =3D 0; + if (padapter->HalFunc.read_bbreg) data =3D padapter->HalFunc.read_bbreg(padapter, RegAddr, BitMask); return data; @@ -312,6 +315,7 @@ void rtw_hal_write_bbreg(struct adapter *padapter, u32 = RegAddr, u32 BitMask, u32 u32 rtw_hal_read_rfreg(struct adapter *padapter, u32 eRFPath, u32 RegAddr,= u32 BitMask) { u32 data =3D 0; + if (padapter->HalFunc.read_rfreg) data =3D padapter->HalFunc.read_rfreg(padapter, eRFPath, RegAddr, BitMas= k); return data; @@ -385,6 +389,7 @@ bool rtw_hal_c2h_valid(struct adapter *adapter, u8 *buf) s32 rtw_hal_c2h_handler(struct adapter *adapter, u8 *c2h_evt) { s32 ret =3D _FAIL; + if (adapter->HalFunc.c2h_handler) ret =3D adapter->HalFunc.c2h_handler(adapter, c2h_evt); return ret; --=20 2.17.1