From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07877C433EF for ; Fri, 21 Jan 2022 16:54:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378930AbiAUQyS (ORCPT ); Fri, 21 Jan 2022 11:54:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233943AbiAUQyQ (ORCPT ); Fri, 21 Jan 2022 11:54:16 -0500 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60CC6C06173B for ; Fri, 21 Jan 2022 08:54:16 -0800 (PST) Received: by mail-ot1-x32d.google.com with SMTP id x31-20020a056830245f00b00599111c8b20so12500769otr.7 for ; Fri, 21 Jan 2022 08:54:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WJAypc7GOb09YdvN33B2vpee2uXuBcVdkBylIc96AeA=; b=K5JwDApwVvttoj1FuEQWHcNMeEk9ffV26USk+IVo7z4R+E0TB6ZLbA+uyyhQbQIeIW 7/HguzO/fxNh33d2a1NipgqeVvG2HGQkV2/EUEuAcyenIBmOSItP0HQtiTRTMSQCTB19 Q8JRE466S0mqUGFHRMq6HnMj6W7VTJm84rdOAn/bB0D6pKxs4VHgQ12wQqE8s4vSm8ad pfC/q04FuRUVchCnEmBr9uvyn9AHV11GeeDBs4nU09hWmqoVn7DMtgVKdhjraXSGsd9L S0FyshtxeBr3TgNQJXcg1xT2BR2QOjvt6FqBAdNWocPYRpii+5V1Wc/NGPoJFEjoJ972 JFQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WJAypc7GOb09YdvN33B2vpee2uXuBcVdkBylIc96AeA=; b=NMIvzb9X6rqtPiV74Fa4DGvUgBE47WPBXef/XGRKL7HIAFHl6W05AOeO8xOcXZvFTa Ub9ZJFqx5VSzMAQ7QvS09zV62PNpKt2AbjwTAvxobAbwAhBoP8hOym34kPe3wIj+GsPH 67kAG5miVITYqghhwyBUXHkMddQ92kBkBUJEwMm87abcvoKmUOvj4spdvyzEXqWp/YLb 8p/u4pasliMQb0YesrvnDRSnHmvBRi35jY3fHF/ZXp/F8zS6s1AMUKpwfQWsuNly5UZ3 bRTQDEuZB6kNPTlcIOFP84wyChTD0rl84Csav9DY/z0e+z0+jOM9hj678cZwKTYo9c1U elig== X-Gm-Message-State: AOAM531YIFmG4CvWlKZNTf2rnNbIneWuMippFO6Ne++W7c+nZUwChSH1 XD84thRV29vfIIxn6TK/ZMDPUTUb6zI= X-Google-Smtp-Source: ABdhPJxVTLluA8KZ26wu9YLuaAzbXLzAR+oweGtMG8xK7CPe3rWm/4vkcVKatam8xzsp4HJXvlwuhg== X-Received: by 2002:a9d:650e:: with SMTP id i14mr3360247otl.350.1642784055795; Fri, 21 Jan 2022 08:54:15 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.54.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:54:15 -0800 (PST) From: Luiz Sampaio To: Ben Skeggs , Karol Herbst , Lyude Paul , David Airlie , Daniel Vetter Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Subject: [PATCH 01/31] gpu: nouveau: nouveau_led: changing LED_FULL to actual value Date: Fri, 21 Jan 2022 13:54:06 -0300 Message-Id: <20220121165436.30956-2-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/gpu/drm/nouveau/nouveau_led.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_led.c b/drivers/gpu/drm/nouvea= u/nouveau_led.c index 2c5e0628da12..df4a734510e1 100644 --- a/drivers/gpu/drm/nouveau/nouveau_led.c +++ b/drivers/gpu/drm/nouveau/nouveau_led.c @@ -45,7 +45,7 @@ nouveau_led_get_brightness(struct led_classdev *led) duty =3D nvif_rd32(device, 0x61c884) & 0x00ffffff; =20 if (div > 0) - return duty * LED_FULL / div; + return duty * 255 / div; else return 0; } @@ -62,7 +62,7 @@ nouveau_led_set_brightness(struct led_classdev *led, enum= led_brightness value) u32 div, duty; =20 div =3D input_clk / freq; - duty =3D value * div / LED_FULL; + duty =3D value * div / 255; =20 /* for now, this is safe to directly poke those registers because: * - A: nvidia never puts the logo led to any other PWM controler --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A184C433FE for ; Fri, 21 Jan 2022 16:54:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379271AbiAUQy1 (ORCPT ); Fri, 21 Jan 2022 11:54:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379008AbiAUQyV (ORCPT ); Fri, 21 Jan 2022 11:54:21 -0500 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0622EC06173D; Fri, 21 Jan 2022 08:54:21 -0800 (PST) Received: by mail-oi1-x234.google.com with SMTP id t9so14290844oie.12; Fri, 21 Jan 2022 08:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=W6q2GvKgFmLMSEA3uVGLoy2Js4lfhFob5eKXqXL9wS0=; b=V80sEKCJ7CvnStxN8YoKYOwNYeczaLRhIjom+agXBX2hAYX0UqJNjEiP2Al+h+Mjgw oPX5Zlj1ftCCLNXZ2Qqqi7Zp6Y7oYFQBuGldLvYmnZ6yZSQGN16TAYAs2vv0rZc9H9mr g/S9b1+gABjVgoN2Q7+n3ISkE8tvMSYNRQgaC1hsgWsfG3q122/BjXtfIx+RxqEDpmup fiOZFqsGkp1ZgD9UNnuaiAMSjhDsTHmGmO26mVqEY18jOTui9yMgobi45DcusBteF2p+ 7QPnogKz4cAQrRqJbj0KElKi6ujDsNiJgHYNClWGVLgkkvO3GfVdyRZ0hrcfhvHqw0op E2WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=W6q2GvKgFmLMSEA3uVGLoy2Js4lfhFob5eKXqXL9wS0=; b=2F36GXUspEeoUtuQ5Quj1sWlNPlegPM1IUtShh+313OviZuyWy9yen0yIxzf1r96CN 967CcF9Jtl1DKRcZBfT7iVAYY9ogo3PIUZFhV2PFMaBegnSJbAtkMxCV9BqUJ2PD3atf x5+p38/+2a6qBYUp/7MqlZvKR9GEinogaixJ+e0B9toQHThR5ZX7w5y+5TmYM71uI6uL MZaQmW8x3BzOWdwWVREtKAR0sBcVkzo7CCgvucOF2yRwoYAJQPA0tivKocjzff1icwFS kIs7wWlBtKksCtIKvsghQCCI305XdCLByK50455wn2Eyq9ImjYmTVCD8ezBRCgrnmtl2 FCow== X-Gm-Message-State: AOAM533Nduok8J4fveu1J52ixaELtlY6T2gpPABQ4UViPJ72qqBUHUIv TqSC0BMR/ujKcwPUp4LjNAc= X-Google-Smtp-Source: ABdhPJxfuo+LWu20AiZhd5QEX3IL1Gxj5Jtadphle0HxWIMb8yHSIZs3cLopupLv0yVDm7K3ObMPjA== X-Received: by 2002:a54:4191:: with SMTP id 17mr1222572oiy.39.1642784060271; Fri, 21 Jan 2022 08:54:20 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:54:20 -0800 (PST) From: Luiz Sampaio To: Jiri Kosina , Benjamin Tissoires , =?UTF-8?q?Bruno=20Pr=C3=A9mont?= , Roderick Colenbrander , David Rheinsberg Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-input@vger.kernel.org Subject: [PATCH 02/31] hid: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:07 -0300 Message-Id: <20220121165436.30956-3-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/hid/hid-bigbenff.c | 10 +++++----- drivers/hid/hid-elan.c | 2 +- drivers/hid/hid-lenovo.c | 2 +- drivers/hid/hid-lg4ff.c | 10 +++++----- drivers/hid/hid-picolcd_leds.c | 6 +++--- drivers/hid/hid-playstation.c | 2 +- drivers/hid/hid-sony.c | 4 ++-- drivers/hid/hid-steelseries.c | 14 +++++++------- drivers/hid/hid-u2fzero.c | 4 ++-- drivers/hid/hid-wiimote-modules.c | 4 ++-- drivers/hid/wacom_sys.c | 16 ++++++++-------- drivers/hid/wacom_wac.c | 2 +- 12 files changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/hid/hid-bigbenff.c b/drivers/hid/hid-bigbenff.c index 74ad8bf98bfd..3882b514f581 100644 --- a/drivers/hid/hid-bigbenff.c +++ b/drivers/hid/hid-bigbenff.c @@ -267,7 +267,7 @@ static void bigben_set_led(struct led_classdev *led, =20 for (n =3D 0; n < NUM_LEDS; n++) { if (led =3D=3D bigben->leds[n]) { - if (value =3D=3D LED_OFF) { + if (value =3D=3D 0) { work =3D (bigben->led_state & BIT(n)); bigben->led_state &=3D ~BIT(n); } else { @@ -293,15 +293,15 @@ static enum led_brightness bigben_get_led(struct led_= classdev *led) =20 if (!bigben) { hid_err(hid, "no device data\n"); - return LED_OFF; + return 0; } =20 for (n =3D 0; n < NUM_LEDS; n++) { if (led =3D=3D bigben->leds[n]) - return (bigben->led_state & BIT(n)) ? LED_ON : LED_OFF; + return (bigben->led_state & BIT(n)) ? 1 : 0; } =20 - return LED_OFF; + return 0; } =20 static void bigben_remove(struct hid_device *hid) @@ -375,7 +375,7 @@ static int bigben_probe(struct hid_device *hid, dev_name(&hid->dev), n + 1 ); led->name =3D name; - led->brightness =3D (n =3D=3D 0) ? LED_ON : LED_OFF; + led->brightness =3D (n =3D=3D 0) ? 1 : 0; led->max_brightness =3D 1; led->brightness_get =3D bigben_get_led; led->brightness_set =3D bigben_set_led; diff --git a/drivers/hid/hid-elan.c b/drivers/hid/hid-elan.c index 3091355d48df..44c20b60ba3e 100644 --- a/drivers/hid/hid-elan.c +++ b/drivers/hid/hid-elan.c @@ -453,7 +453,7 @@ static int elan_init_mute_led(struct hid_device *hdev) mute_led->name =3D "elan:red:mute"; mute_led->default_trigger =3D "audio-mute"; mute_led->brightness_set_blocking =3D elan_mute_led_set_brigtness; - mute_led->max_brightness =3D LED_ON; + mute_led->max_brightness =3D 1; mute_led->flags =3D LED_HW_PLUGGABLE; mute_led->dev =3D &hdev->dev; =20 diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index 93b1f935e526..b65d3a5175d5 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -842,7 +842,7 @@ static int lenovo_led_brightness_set(struct led_classde= v *led_cdev, if (led_cdev =3D=3D &data_pointer->led_micmute) led_nr =3D 1; =20 - if (value =3D=3D LED_OFF) + if (value =3D=3D 0) data_pointer->led_state &=3D ~(1 << led_nr); else data_pointer->led_state |=3D 1 << led_nr; diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c index 5e6a0cef2a06..6e65f92e6aec 100644 --- a/drivers/hid/hid-lg4ff.c +++ b/drivers/hid/hid-lg4ff.c @@ -1136,10 +1136,10 @@ static void lg4ff_led_set_brightness(struct led_cla= ssdev *led_cdev, if (led_cdev !=3D entry->wdata.led[i]) continue; state =3D (entry->wdata.led_state >> i) & 1; - if (value =3D=3D LED_OFF && state) { + if (value =3D=3D 0 && state) { entry->wdata.led_state &=3D ~(1 << i); lg4ff_set_leds(hid, entry->wdata.led_state); - } else if (value !=3D LED_OFF && !state) { + } else if (value !=3D 0 && !state) { entry->wdata.led_state |=3D 1 << i; lg4ff_set_leds(hid, entry->wdata.led_state); } @@ -1157,14 +1157,14 @@ static enum led_brightness lg4ff_led_get_brightness= (struct led_classdev *led_cde =20 if (!drv_data) { hid_err(hid, "Device data not found."); - return LED_OFF; + return 0; } =20 entry =3D drv_data->device_props; =20 if (!entry) { hid_err(hid, "Device properties not found."); - return LED_OFF; + return 0; } =20 for (i =3D 0; i < 5; i++) @@ -1173,7 +1173,7 @@ static enum led_brightness lg4ff_led_get_brightness(s= truct led_classdev *led_cde break; } =20 - return value ? LED_FULL : LED_OFF; + return value ? 255 : 0; } #endif =20 diff --git a/drivers/hid/hid-picolcd_leds.c b/drivers/hid/hid-picolcd_leds.c index 6b505a753511..b000ee63b1c9 100644 --- a/drivers/hid/hid-picolcd_leds.c +++ b/drivers/hid/hid-picolcd_leds.c @@ -64,10 +64,10 @@ static void picolcd_led_set_brightness(struct led_class= dev *led_cdev, if (led_cdev !=3D data->led[i]) continue; state =3D (data->led_state >> i) & 1; - if (value =3D=3D LED_OFF && state) { + if (value =3D=3D 0 && state) { data->led_state &=3D ~(1 << i); picolcd_leds_set(data); - } else if (value !=3D LED_OFF && !state) { + } else if (value !=3D 0 && !state) { data->led_state |=3D 1 << i; picolcd_leds_set(data); } @@ -90,7 +90,7 @@ static enum led_brightness picolcd_led_get_brightness(str= uct led_classdev *led_c value =3D (data->led_state >> i) & 1; break; } - return value ? LED_FULL : LED_OFF; + return value ? 255 : 0; } =20 int picolcd_init_leds(struct picolcd_data *data, struct hid_report *report) diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c index b1b5721b5d8f..95ed22a533ec 100644 --- a/drivers/hid/hid-playstation.c +++ b/drivers/hid/hid-playstation.c @@ -873,7 +873,7 @@ static int dualsense_player_led_set_brightness(struct l= ed_classdev *led, enum le spin_lock_irqsave(&ds->base.lock, flags); =20 led_index =3D led - ds->player_leds; - if (value =3D=3D LED_OFF) + if (value =3D=3D 0) ds->player_leds_state &=3D ~BIT(led_index); else ds->player_leds_state |=3D BIT(led_index); diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index 60ec2b29d54d..f4198cd8b94d 100644 --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c @@ -2048,7 +2048,7 @@ static enum led_brightness sony_led_get_brightness(st= ruct led_classdev *led) drv_data =3D hid_get_drvdata(hdev); if (!drv_data) { hid_err(hdev, "No device data\n"); - return LED_OFF; + return 0; } =20 for (n =3D 0; n < drv_data->led_count; n++) { @@ -2056,7 +2056,7 @@ static enum led_brightness sony_led_get_brightness(st= ruct led_classdev *led) return drv_data->led_state[n]; } =20 - return LED_OFF; + return 0; } =20 static int sony_led_blink_set(struct led_classdev *led, unsigned long *del= ay_on, diff --git a/drivers/hid/hid-steelseries.c b/drivers/hid/hid-steelseries.c index 37353c41cba7..b53587891b32 100644 --- a/drivers/hid/hid-steelseries.c +++ b/drivers/hid/hid-steelseries.c @@ -146,7 +146,7 @@ static void steelseries_srws1_led_all_set_brightness(st= ruct led_classdev *led_cd return; } =20 - if (value =3D=3D LED_OFF) + if (value =3D=3D 0) drv_data->led_state =3D 0; else drv_data->led_state =3D (1 << (SRWS1_NUMBER_LEDS + 1)) - 1; @@ -164,10 +164,10 @@ static enum led_brightness steelseries_srws1_led_all_= get_brightness(struct led_c =20 if (!drv_data) { hid_err(hid, "Device data not found."); - return LED_OFF; + return 0; } =20 - return (drv_data->led_state >> SRWS1_NUMBER_LEDS) ? LED_FULL : LED_OFF; + return (drv_data->led_state >> SRWS1_NUMBER_LEDS) ? 255 : 0; } =20 static void steelseries_srws1_led_set_brightness(struct led_classdev *led_= cdev, @@ -188,10 +188,10 @@ static void steelseries_srws1_led_set_brightness(stru= ct led_classdev *led_cdev, continue; =20 state =3D (drv_data->led_state >> i) & 1; - if (value =3D=3D LED_OFF && state) { + if (value =3D=3D 0 && state) { drv_data->led_state &=3D ~(1 << i); steelseries_srws1_set_leds(hid, drv_data->led_state); - } else if (value !=3D LED_OFF && !state) { + } else if (value !=3D 0 && !state) { drv_data->led_state |=3D 1 << i; steelseries_srws1_set_leds(hid, drv_data->led_state); } @@ -210,7 +210,7 @@ static enum led_brightness steelseries_srws1_led_get_br= ightness(struct led_class =20 if (!drv_data) { hid_err(hid, "Device data not found."); - return LED_OFF; + return 0; } =20 for (i =3D 0; i < SRWS1_NUMBER_LEDS; i++) @@ -219,7 +219,7 @@ static enum led_brightness steelseries_srws1_led_get_br= ightness(struct led_class break; } =20 - return value ? LED_FULL : LED_OFF; + return value ? 255 : 0; } =20 static int steelseries_srws1_probe(struct hid_device *hdev, diff --git a/drivers/hid/hid-u2fzero.c b/drivers/hid/hid-u2fzero.c index ad489caf53ad..1e73bd85b9b7 100644 --- a/drivers/hid/hid-u2fzero.c +++ b/drivers/hid/hid-u2fzero.c @@ -187,7 +187,7 @@ static int u2fzero_blink(struct led_classdev *ldev) static int u2fzero_brightness_set(struct led_classdev *ldev, enum led_brightness brightness) { - ldev->brightness =3D LED_OFF; + ldev->brightness =3D 0; if (brightness) return u2fzero_blink(ldev); else @@ -244,7 +244,7 @@ static int u2fzero_init_led(struct u2fzero_device *dev, return -ENOMEM; =20 dev->ldev.name =3D dev->led_name; - dev->ldev.max_brightness =3D LED_ON; + dev->ldev.max_brightness =3D 1; dev->ldev.flags =3D LED_HW_PLUGGABLE; dev->ldev.brightness_set_blocking =3D u2fzero_brightness_set; =20 diff --git a/drivers/hid/hid-wiimote-modules.c b/drivers/hid/hid-wiimote-mo= dules.c index 213c58bf2495..9416f0e2a092 100644 --- a/drivers/hid/hid-wiimote-modules.c +++ b/drivers/hid/hid-wiimote-modules.c @@ -308,7 +308,7 @@ static enum led_brightness wiimod_led_get(struct led_cl= assdev *led_dev) } } =20 - return value ? LED_FULL : LED_OFF; + return value ? 255 : 0; } =20 static void wiimod_led_set(struct led_classdev *led_dev, @@ -325,7 +325,7 @@ static void wiimod_led_set(struct led_classdev *led_dev, flag =3D WIIPROTO_FLAG_LED(i + 1); spin_lock_irqsave(&wdata->state.lock, flags); state =3D wdata->state.flags; - if (value =3D=3D LED_OFF) + if (value =3D=3D 0) wiiproto_req_leds(wdata, state & ~flag); else wiiproto_req_leds(wdata, state | flag); diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 066c567dbaa2..9b0786f48867 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -1304,13 +1304,13 @@ enum led_brightness wacom_leds_brightness_get(struc= t wacom_led *led) struct wacom *wacom =3D led->wacom; =20 if (wacom->led.max_hlv) - return led->hlv * LED_FULL / wacom->led.max_hlv; + return led->hlv * 255 / wacom->led.max_hlv; =20 if (wacom->led.max_llv) - return led->llv * LED_FULL / wacom->led.max_llv; + return led->llv * 255 / wacom->led.max_llv; =20 /* device doesn't support brightness tuning */ - return LED_FULL; + return 255; } =20 static enum led_brightness __wacom_led_brightness_get(struct led_classdev = *cdev) @@ -1319,7 +1319,7 @@ static enum led_brightness __wacom_led_brightness_get= (struct led_classdev *cdev) struct wacom *wacom =3D led->wacom; =20 if (wacom->led.groups[led->group].select !=3D led->id) - return LED_OFF; + return 0; =20 return wacom_leds_brightness_get(led); } @@ -1333,14 +1333,14 @@ static int wacom_led_brightness_set(struct led_clas= sdev *cdev, =20 mutex_lock(&wacom->lock); =20 - if (!wacom->led.groups || (brightness =3D=3D LED_OFF && + if (!wacom->led.groups || (brightness =3D=3D 0 && wacom->led.groups[led->group].select !=3D led->id)) { error =3D 0; goto out; } =20 - led->llv =3D wacom->led.llv =3D wacom->led.max_llv * brightness / LED_FUL= L; - led->hlv =3D wacom->led.hlv =3D wacom->led.max_hlv * brightness / LED_FUL= L; + led->llv =3D wacom->led.llv =3D wacom->led.max_llv * brightness / 255; + led->hlv =3D wacom->led.hlv =3D wacom->led.max_hlv * brightness / 255; =20 wacom->led.groups[led->group].select =3D led->id; =20 @@ -1389,7 +1389,7 @@ static int wacom_led_register_one(struct device *dev,= struct wacom *wacom, led->llv =3D wacom->led.llv; led->hlv =3D wacom->led.hlv; led->cdev.name =3D name; - led->cdev.max_brightness =3D LED_FULL; + led->cdev.max_brightness =3D 255; led->cdev.flags =3D LED_HW_PLUGGABLE; led->cdev.brightness_get =3D __wacom_led_brightness_get; if (!read_only) { diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 2a4cc39962e7..d47e8c59aa4d 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -3958,7 +3958,7 @@ static void wacom_24hd_update_leds(struct wacom *waco= m, int mask, int group) } if (!updated && mask & BIT(i)) { led->held =3D true; - led_trigger_event(&led->trigger, LED_FULL); + led_trigger_event(&led->trigger, 255); } else { led->held =3D false; } --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD45C433EF for ; Fri, 21 Jan 2022 16:54:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378965AbiAUQyd (ORCPT ); Fri, 21 Jan 2022 11:54:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379215AbiAUQyZ (ORCPT ); Fri, 21 Jan 2022 11:54:25 -0500 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71449C061748; Fri, 21 Jan 2022 08:54:23 -0800 (PST) Received: by mail-oi1-x236.google.com with SMTP id w188so14286000oiw.13; Fri, 21 Jan 2022 08:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oJfZ9bxEyakRGqsa0D0+XQlWPcD9uzPytbmizuUotgY=; b=FdXBH7Iek6amWg401VuWNnvfE9n1dEqsm8gSRUc4W2+XwCI5e8f6fwvDbQmNRDjo59 a09lHndSHbtHfW3CHRvyv2HsmMjh8igO9/R+ATU6uo0QHhcYzu2klOt4FNOFw9532/ZI ZFtMYQyZPg8v+a+KqFMBQMFsZva1t8R1liGLfCKUvumxuKGFg7NLOIfKtJanuco7bJzC iBcBgMe+6hcaFTIFg6WqQrMqDXGSrOLHFCqYYZT7BaflUtcCmG5ix3jGYyJcjp5j0q+H 6TUB5gRoFnFR3Fb+cD9Jd9G4iWEfBpo3+2nuIB+riZi5uu5Oe46BCujP3OBfi+G/vY84 y9Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oJfZ9bxEyakRGqsa0D0+XQlWPcD9uzPytbmizuUotgY=; b=Fkd/vc7U/B3H8K5mX/a0sf4K2z+hFAkvQiOzenoIE921cUKI45Cfs/5BJTqFK7MO8L TZ6xg3XzQJkdbsD/Y+Gi4lQpfL0cuWdgqgbdDL+a5+BgPUsXYTga2HWCT8XuGXcN1n6M w8BlOknkdl3chYuWnkFUwEAOhR1DclPxKbDT+2aQfmZLNNrtTMGV1six8U8fz/pzCL+t qkvtgXWaoFOt9REaSpN5y3sY8qovY0pJNjcOXtFpg5F9zbdUsgvGhAyLKnqMS8lNFYn9 bYgmOSdv+p+weimWkiLvd6OtCx8VKWtI3L0c6tHYGqUD6bd8/pIMwA4+l2ymDkALMfk/ JmSA== X-Gm-Message-State: AOAM531xsBMFXetVKQhPAXGkWJnnW25g3xegOzhb3BAdy2u7YuCW426r 7lrf+jKItdsCYrdQXDuO2n1tF2KXqpo= X-Google-Smtp-Source: ABdhPJxVB60m/+irtROG2vo5Jixi422f8mmMPw0s5dKqSWNTf6DszjlcuSjSB8uP4NKmSlGKrxB3hQ== X-Received: by 2002:a54:4097:: with SMTP id i23mr1250934oii.115.1642784062879; Fri, 21 Jan 2022 08:54:22 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.54.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:54:22 -0800 (PST) From: Luiz Sampaio To: Guenter Roeck , Jean Delvare Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-hwmon@vger.kernel.org Subject: [PATCH 03/31] hwmon: pmbus: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:08 -0300 Message-Id: <20220121165436.30956-4-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/hwmon/pmbus/ibm-cffps.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffp= s.c index e3294a1a54bb..cc20a70c723b 100644 --- a/drivers/hwmon/pmbus/ibm-cffps.c +++ b/drivers/hwmon/pmbus/ibm-cffps.c @@ -382,10 +382,10 @@ static int ibm_cffps_led_brightness_set(struct led_cl= assdev *led_cdev, u8 next_led_state; struct ibm_cffps *psu =3D container_of(led_cdev, struct ibm_cffps, led); =20 - if (brightness =3D=3D LED_OFF) { + if (brightness =3D=3D 0) { next_led_state =3D CFFPS_LED_OFF; } else { - brightness =3D LED_FULL; + brightness =3D 255; =20 if (psu->led_state !=3D CFFPS_LED_BLINK) next_led_state =3D CFFPS_LED_ON; @@ -426,7 +426,7 @@ static int ibm_cffps_led_blink_set(struct led_classdev = *led_cdev, return rc; =20 psu->led_state =3D CFFPS_LED_BLINK; - led_cdev->brightness =3D LED_FULL; + led_cdev->brightness =3D 255; *delay_on =3D CFFPS_BLINK_RATE_MS; *delay_off =3D CFFPS_BLINK_RATE_MS; =20 @@ -442,7 +442,7 @@ static void ibm_cffps_create_led_class(struct ibm_cffps= *psu) snprintf(psu->led_name, sizeof(psu->led_name), "%s-%02x", client->name, client->addr); psu->led.name =3D psu->led_name; - psu->led.max_brightness =3D LED_FULL; + psu->led.max_brightness =3D 255; psu->led.brightness_set_blocking =3D ibm_cffps_led_brightness_set; psu->led.blink_set =3D ibm_cffps_led_blink_set; =20 --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3272EC43219 for ; Fri, 21 Jan 2022 16:54:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379114AbiAUQya (ORCPT ); Fri, 21 Jan 2022 11:54:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378980AbiAUQy0 (ORCPT ); Fri, 21 Jan 2022 11:54:26 -0500 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F68DC06173B; Fri, 21 Jan 2022 08:54:26 -0800 (PST) Received: by mail-oi1-x234.google.com with SMTP id q186so14347327oih.8; Fri, 21 Jan 2022 08:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+onRDSB8NBPE12vkU5FSeD+tqXtPtVIIqSZAFj9Gqb8=; b=VV0tazK7JhQqvueYD1I/rC7s9R8HgpUIHqZqhR0so78OUBIyxJzsOkZkyJNytnuH7E 8/O7RYFDXW+m/2+S3G2iaeCYXRKOQbxjyBtfnVarWEzqFkEXXDl3a+GJpNvA3sM80C95 WuRWMpBE7RWUc93hiZl44IJ9aFgyDh6wqo4DW90F6w6rMrEv82svtmvyjBfGRb8cut8/ 2SBxiOwNDSBRpIXXJ87wFFU6h+UWqFA2sBo+NxfJsuUo4Jt3EDjJCiy4dHf03oZfGYwf pG/cb31Cj2GH81TFWwKHFwFng9ad7x6gluu3fQaKgahICi8VznMMQJFRSudA0gAb/DJY TDhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+onRDSB8NBPE12vkU5FSeD+tqXtPtVIIqSZAFj9Gqb8=; b=yZ87zy1JOiMiIyqjEBZeOmwh1jdpJWwn9Zvr0KqOx78ENNM3aSz8xnCmFjS7OQFw6u aOZZh9vdfh7dAmkNqKrr77Pr2FXUm3n1Rw7WsbRAhhCq2c7oFkbVsMsmxB2QD3cVmhfh tBvgFWxNGrI5lCfoV7lQsidZ5IjI32LwOAtZqMR2t7dVBMMAUfSykkBEhr4jWj+VPmUc ANv+0txlyxhZSWJ2d8HgcpAGwSfi84kYBZB7MubI0TytZkVAbG+9HSkamF9ZQHVtlobm 8WGdx1SbplS0hHq928Rc2dmqhGsBQOIhwAqvzmYBbJWeWBwR7+MD4dX2TThsHqr2xU8a 0Mkw== X-Gm-Message-State: AOAM531tSO7v2NQcmSHksFN6oJE8PZ/cnXMVnY7WjXqUsKxvxXEcJhRS lHZwP6mQVUohSKaHlP86Yfo= X-Google-Smtp-Source: ABdhPJzH/cMZPe1PawEcN7hDEZjfPuESpYNcLZvMMWhAMFkqLEdpxOA/Lmu+Qc3XChTtI6z7i2zqIg== X-Received: by 2002:a05:6808:1709:: with SMTP id bc9mr1280338oib.130.1642784065694; Fri, 21 Jan 2022 08:54:25 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.54.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:54:25 -0800 (PST) From: Luiz Sampaio To: Kevin Tsai , Jonathan Cameron , Lars-Peter Clausen Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-iio@vger.kernel.org Subject: [PATCH 04/31] iio: light: cm3605: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:09 -0300 Message-Id: <20220121165436.30956-5-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/iio/light/cm3605.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/light/cm3605.c b/drivers/iio/light/cm3605.c index 50d34a98839c..f60db6cd9e6d 100644 --- a/drivers/iio/light/cm3605.c +++ b/drivers/iio/light/cm3605.c @@ -238,7 +238,7 @@ static int cm3605_probe(struct platform_device *pdev) =20 /* Just name the trigger the same as the driver */ led_trigger_register_simple("cm3605", &cm3605->led); - led_trigger_event(cm3605->led, LED_FULL); + led_trigger_event(cm3605->led, 255); =20 indio_dev->info =3D &cm3605_info; indio_dev->name =3D "cm3605"; @@ -255,7 +255,7 @@ static int cm3605_probe(struct platform_device *pdev) return 0; =20 out_remove_trigger: - led_trigger_event(cm3605->led, LED_OFF); + led_trigger_event(cm3605->led, 0); led_trigger_unregister_simple(cm3605->led); out_disable_aset: gpiod_set_value_cansleep(cm3605->aset, 0); @@ -269,7 +269,7 @@ static int cm3605_remove(struct platform_device *pdev) struct iio_dev *indio_dev =3D platform_get_drvdata(pdev); struct cm3605 *cm3605 =3D iio_priv(indio_dev); =20 - led_trigger_event(cm3605->led, LED_OFF); + led_trigger_event(cm3605->led, 0); led_trigger_unregister_simple(cm3605->led); gpiod_set_value_cansleep(cm3605->aset, 0); iio_device_unregister(indio_dev); @@ -283,7 +283,7 @@ static int __maybe_unused cm3605_pm_suspend(struct devi= ce *dev) struct iio_dev *indio_dev =3D dev_get_drvdata(dev); struct cm3605 *cm3605 =3D iio_priv(indio_dev); =20 - led_trigger_event(cm3605->led, LED_OFF); + led_trigger_event(cm3605->led, 0); regulator_disable(cm3605->vdd); =20 return 0; @@ -298,7 +298,7 @@ static int __maybe_unused cm3605_pm_resume(struct devic= e *dev) ret =3D regulator_enable(cm3605->vdd); if (ret) dev_err(dev, "failed to enable regulator in resume path\n"); - led_trigger_event(cm3605->led, LED_FULL); + led_trigger_event(cm3605->led, 255); =20 return 0; } --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AD3FC433F5 for ; Fri, 21 Jan 2022 16:54:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379365AbiAUQyf (ORCPT ); Fri, 21 Jan 2022 11:54:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378945AbiAUQy3 (ORCPT ); Fri, 21 Jan 2022 11:54:29 -0500 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA9F3C06173B; Fri, 21 Jan 2022 08:54:28 -0800 (PST) Received: by mail-ot1-x32c.google.com with SMTP id a10-20020a9d260a000000b005991bd6ae3eso12458581otb.11; Fri, 21 Jan 2022 08:54:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Je4Vg4olpeQt3YYgiuDinqh8u3SDDMhhHec3zR+vbpw=; b=eyCdocg3/BwFXfNB6Ra58X0zGei6GdzjOGAdVx7J3EZnQTgNGumoi5fmYK2Za3iy/V jN4KcidqxXKzrCkljB4x44HUo0uALqPUK43TPmRzhAvbqRJMFkRqo6GK8HHgOmkpkYMb VH5XLEj6enzXbw4Y5gnI7kzbDKx7XjMl5ewZlxJ9g7HHghQjUU1V24v+fC1CwCfIzFWn JrgLaglsFFu6zmi604vr/azRkUrGkI+B1oTVYYKJki6GU/uzAgmPq6SNxHH12lnQSmDy kuNuIvUTd6OO79GVAqblQz1rJXzXKW6npRKdtuI63j3qmOr8EXqz8PDpQiksyusBI/L6 m+Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Je4Vg4olpeQt3YYgiuDinqh8u3SDDMhhHec3zR+vbpw=; b=GBjo9k+eK9gUAmpwzDlTlMIAUGW7/xZxJXLidH9GSBbbh/JyKlOys7PDhMo5ryyuK+ RRbHmcEUR0SCUzEJU3t17XWc1oOq9tPG/W5Y7LgDilly4q+94+vWUTEBbYd98C30Vwu0 /JZyPLBW5MgimB9Y10I12KkuBZEx5asvXVT9mECbu3UCISporkP/+GgkHZ6Pug6kIhiy 2/JmCTlfT+jkQJzo8QnxAU1gVz913HOaIae4Hr0cU2MFomWwDe3SqTGa1WWkstCqTdBS vLqAMwlH88RH0zDDDgwOHWSWPvYWcUtVcKmFakzQRl7nckoFCyErvlnxGNKgHb7BMzFv GJWA== X-Gm-Message-State: AOAM530VAR8UaLVIojQ5oT1qVwMm8Sp41wmU0qFxBYzCUrVF3isAQUv2 oRKFajr+yXDdZOyw/g+L9IxKQzFnNkQ= X-Google-Smtp-Source: ABdhPJy2nNfP2/sQ5pcqgIqsWk02rQQ3m1RbWO9oJ+ZEbEFN7V0EXWGwjzgsJulb5byjReHdhGwo3A== X-Received: by 2002:a05:6830:40c6:: with SMTP id h6mr3263411otu.247.1642784068274; Fri, 21 Jan 2022 08:54:28 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:54:27 -0800 (PST) From: Luiz Sampaio To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-input@vger.kernel.org Subject: [PATCH 05/31] input: keyboard: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:10 -0300 Message-Id: <20220121165436.30956-6-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/input/keyboard/cap11xx.c | 2 +- drivers/input/keyboard/qt2160.c | 6 +++--- drivers/input/keyboard/tm2-touchkey.c | 12 ++++++------ 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap1= 1xx.c index 7c85343cd32f..04c03157ef8a 100644 --- a/drivers/input/keyboard/cap11xx.c +++ b/drivers/input/keyboard/cap11xx.c @@ -290,7 +290,7 @@ static int cap11xx_init_leds(struct device *dev, led->cdev.flags =3D 0; led->cdev.brightness_set_blocking =3D cap11xx_led_set; led->cdev.max_brightness =3D 1; - led->cdev.brightness =3D LED_OFF; + led->cdev.brightness =3D 0; =20 error =3D of_property_read_u32(child, "reg", ®); if (error !=3D 0 || reg >=3D num_leds) { diff --git a/drivers/input/keyboard/qt2160.c b/drivers/input/keyboard/qt216= 0.c index 32d4a076eaa3..b80c2195dabb 100644 --- a/drivers/input/keyboard/qt2160.c +++ b/drivers/input/keyboard/qt2160.c @@ -78,7 +78,7 @@ static int qt2160_led_set(struct led_classdev *cdev, if (value !=3D led->brightness) { drive =3D qt2160_read(client, QT2160_CMD_DRIVE_X); pwmen =3D qt2160_read(client, QT2160_CMD_PWMEN_X); - if (value !=3D LED_OFF) { + if (value !=3D 0) { drive |=3D BIT(led->id); pwmen |=3D BIT(led->id); =20 @@ -93,7 +93,7 @@ static int qt2160_led_set(struct led_classdev *cdev, * Changing this register will change the brightness * of every LED in the qt2160. It's a HW limitation. */ - if (value !=3D LED_OFF) + if (value !=3D 0) qt2160_write(client, QT2160_CMD_PWM_DUTY, value); =20 led->brightness =3D value; @@ -269,7 +269,7 @@ static int qt2160_register_leds(struct qt2160_data *qt2= 160) snprintf(led->name, sizeof(led->name), "qt2160:x%d", i); led->cdev.name =3D led->name; led->cdev.brightness_set_blocking =3D qt2160_led_set; - led->cdev.brightness =3D LED_OFF; + led->cdev.brightness =3D 0; led->id =3D i; led->qt2160 =3D qt2160; =20 diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard= /tm2-touchkey.c index 632cd6c1c8d4..b28ebbc75d11 100644 --- a/drivers/input/keyboard/tm2-touchkey.c +++ b/drivers/input/keyboard/tm2-touchkey.c @@ -91,7 +91,7 @@ static int tm2_touchkey_led_brightness_set(struct led_cla= ssdev *led_dev, u32 volt; u8 data; =20 - if (brightness =3D=3D LED_OFF) { + if (brightness =3D=3D 0) { volt =3D TM2_TOUCHKEY_LED_VOLTAGE_MIN; data =3D touchkey->variant->cmd_led_off; } else { @@ -173,9 +173,9 @@ static irqreturn_t tm2_touchkey_irq_handler(int irq, vo= id *devid) if (touchkey->variant->fixed_regulator && data & TM2_TOUCHKEY_BIT_PRESS_EV) { /* touch turns backlight on, so make sure we're in sync */ - if (touchkey->led_dev.brightness =3D=3D LED_OFF) + if (touchkey->led_dev.brightness =3D=3D 0) tm2_touchkey_led_brightness_set(&touchkey->led_dev, - LED_OFF); + 0); } =20 return IRQ_HANDLED; @@ -280,8 +280,8 @@ static int tm2_touchkey_probe(struct i2c_client *client, =20 /* led device */ touchkey->led_dev.name =3D TM2_TOUCHKEY_DEV_NAME; - touchkey->led_dev.brightness =3D LED_ON; - touchkey->led_dev.max_brightness =3D LED_ON; + touchkey->led_dev.brightness =3D 1; + touchkey->led_dev.max_brightness =3D 1; touchkey->led_dev.brightness_set_blocking =3D tm2_touchkey_led_brightness_set; =20 @@ -293,7 +293,7 @@ static int tm2_touchkey_probe(struct i2c_client *client, } =20 if (touchkey->variant->fixed_regulator) - tm2_touchkey_led_brightness_set(&touchkey->led_dev, LED_ON); + tm2_touchkey_led_brightness_set(&touchkey->led_dev, 1); =20 return 0; } --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59E4CC433F5 for ; Fri, 21 Jan 2022 16:54:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379414AbiAUQys (ORCPT ); Fri, 21 Jan 2022 11:54:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379036AbiAUQyb (ORCPT ); Fri, 21 Jan 2022 11:54:31 -0500 Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88D01C06173D; Fri, 21 Jan 2022 08:54:31 -0800 (PST) Received: by mail-oi1-x235.google.com with SMTP id q186so14347706oih.8; Fri, 21 Jan 2022 08:54:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5s5UbzjGtCWz5IFAAJ8W73hj4zFXrrDystMmQJgy/K0=; b=fSDTz17GP1ENZ9TNg++fhuNarE5aoMJy71DtoGonwd2QtSCqntLqDPoSo9iC4DLF2H 4pbJ+SCNGlyzBVTN4L/32SyjESoCM+qQ6jaB9RVpb79aZJplW0zuj4TJHO0H6qL3RTFf 1zwGf8QO4wXLwDO5HatBgBKCGjcZRkFjf5KXxcpcXuiIw4N5PoJQoXbL836v3ECgfluM 30gNkB+pVZ1vRTU2FlYFRBH0jQl7QemGvOJzeKODlI9aPRnWlJSOJ+UYzaqgS3oznNSs uk75Wohu9H5pNRdEMgG/ZNY4nhu4S05fvlAKPlSRXjIg1ztqG3W+4RwISw2K8VV2fXNx lktQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5s5UbzjGtCWz5IFAAJ8W73hj4zFXrrDystMmQJgy/K0=; b=EYV4HNs8k1CA6tdPm7MBgdKM2fkk9/VxF3nLvvlD68lGMjkgR12f0HZCihQEh73NbZ icRNfNPVoLJhQvaducXiX4JXKlV3hsgxjMFhRvxhsrY0/sQ8of1TtDYtyoZ+cARgu1Fp 7nu2lfqj4gs6qvupCva3RMU0nVy7xPDrlHf2WYM83smIcGoPcmJtLmTEhN2ky+sxECV5 ki60/sAgfgPlaztdp7A6edm02xF+z1AhVOelJEI3bPPI3fR0HojhGmBacW2iTTNDJ4nF zV6L9yXSE6WNZfTqHJosIGoLtpQm15c1sryAdWcn/y7uzIGPIZP8VmolimUBj6nfxedV I0TQ== X-Gm-Message-State: AOAM531VRKKB9z9PjPUjh7xCeSugCj/tXhbS+BgWI7V2V19IusAj0fZS eiYDTjLVR1Tw4D3WkPe2FGk= X-Google-Smtp-Source: ABdhPJxvBuBxMuXHNeqQqmpPiBGLgjWTEw0bKwOXqMg3pK9cWTM3CNpmQojh7ca/Kw7mYV+BxY9+ww== X-Received: by 2002:a05:6808:1b07:: with SMTP id bx7mr1267018oib.38.1642784070933; Fri, 21 Jan 2022 08:54:30 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:54:30 -0800 (PST) From: Luiz Sampaio To: Dmitry Torokhov , Miloslav Trmac Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-input@vger.kernel.org Subject: [PATCH 06/31] input: misc: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:11 -0300 Message-Id: <20220121165436.30956-7-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/input/misc/apanel.c | 4 ++-- drivers/input/misc/ims-pcu.c | 2 +- drivers/input/misc/wistron_btns.c | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/input/misc/apanel.c b/drivers/input/misc/apanel.c index 7276657ad7ca..3b7e2f032f33 100644 --- a/drivers/input/misc/apanel.c +++ b/drivers/input/misc/apanel.c @@ -115,7 +115,7 @@ static int mail_led_set(struct led_classdev *led, enum led_brightness value) { struct apanel *ap =3D container_of(led, struct apanel, mail_led); - u16 led_bits =3D value !=3D LED_OFF ? 0x8000 : 0x0000; + u16 led_bits =3D value !=3D 0 ? 0x8000 : 0x0000; =20 return i2c_smbus_write_word_data(ap->client, 0x10, led_bits); } @@ -189,7 +189,7 @@ static void apanel_shutdown(struct i2c_client *client) struct apanel *ap =3D i2c_get_clientdata(client); =20 if (device_chip[APANEL_DEV_LED] !=3D CHIP_NONE) - led_set_brightness(&ap->mail_led, LED_OFF); + led_set_brightness(&ap->mail_led, 0); } =20 static const struct i2c_device_id apanel_id[] =3D { diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c index 6f38aa23a1ff..9665f371837d 100644 --- a/drivers/input/misc/ims-pcu.c +++ b/drivers/input/misc/ims-pcu.c @@ -986,7 +986,7 @@ ims_pcu_backlight_get_brightness(struct led_classdev *c= dev) "Failed to get current brightness, error: %d\n", error); /* Assume the LED is OFF */ - brightness =3D LED_OFF; + brightness =3D 0; } else { brightness =3D get_unaligned_le16(&pcu->cmd_buf[IMS_PCU_DATA_OFFSET]); diff --git a/drivers/input/misc/wistron_btns.c b/drivers/input/misc/wistron= _btns.c index 80dfd72a02d3..cd290722a389 100644 --- a/drivers/input/misc/wistron_btns.c +++ b/drivers/input/misc/wistron_btns.c @@ -1039,14 +1039,14 @@ static bool bluetooth_enabled; static void wistron_mail_led_set(struct led_classdev *led_cdev, enum led_brightness value) { - bios_set_state(MAIL_LED, (value !=3D LED_OFF) ? 1 : 0); + bios_set_state(MAIL_LED, (value !=3D 0) ? 1 : 0); } =20 /* same as setting up wifi card, but for laptops on which the led is manag= ed */ static void wistron_wifi_led_set(struct led_classdev *led_cdev, enum led_brightness value) { - bios_set_state(WIFI, (value !=3D LED_OFF) ? 1 : 0); + bios_set_state(WIFI, (value !=3D 0) ? 1 : 0); } =20 static struct led_classdev wistron_mail_led =3D { @@ -1064,7 +1064,7 @@ static void wistron_led_init(struct device *parent) if (leds_present & FE_WIFI_LED) { u16 wifi =3D bios_get_default_setting(WIFI); if (wifi & 1) { - wistron_wifi_led.brightness =3D (wifi & 2) ? LED_FULL : LED_OFF; + wistron_wifi_led.brightness =3D (wifi & 2) ? LED_FULL : 0; if (led_classdev_register(parent, &wistron_wifi_led)) leds_present &=3D ~FE_WIFI_LED; else @@ -1076,7 +1076,7 @@ static void wistron_led_init(struct device *parent) =20 if (leds_present & FE_MAIL_LED) { /* bios_get_default_setting(MAIL) always retuns 0, so just turn the led = off */ - wistron_mail_led.brightness =3D LED_OFF; + wistron_mail_led.brightness =3D 0; if (led_classdev_register(parent, &wistron_mail_led)) leds_present &=3D ~FE_MAIL_LED; else --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0790FC433F5 for ; Fri, 21 Jan 2022 16:55:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379740AbiAUQzD (ORCPT ); Fri, 21 Jan 2022 11:55:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379312AbiAUQye (ORCPT ); Fri, 21 Jan 2022 11:54:34 -0500 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 862E3C06173B; Fri, 21 Jan 2022 08:54:34 -0800 (PST) Received: by mail-oi1-x234.google.com with SMTP id s127so14381111oig.2; Fri, 21 Jan 2022 08:54:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gMvwDdKHz8SxD4XNsSXi0ifYKZbrqBGSjCLlHvwqADI=; b=bFxWZzsGiGVdBe5x6szZZuz5pjdNt6E15NqjGO8IZpJRKXyU1CUVtQfiS7nQ85w9Hr a2F1y2md9h0rVZQajdIrclWiJ+nPA3vP/ZbKGqY1iQ5LhRK5axOYZFH1PI5vO/zWWhHl Eor7nYxkOYgUmAvJXNbqMrfjOckjduoYsdX4Y6JNRzNb3G1lgccNCs7Y980we11ot3UN XHQSZwNj5VD7/nnNJ8r4qN9vTm6Bj+G85IZM4HPdO+1G2RHVJXmzMRqb+7g60TcsjCK4 wuMh1c/1/kQbcrDd8GS8Jj8JzJYBPQdU0Ypn6G0fz+xx25Wr4xWQNsmqWf1XxJQQbtiZ KVQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gMvwDdKHz8SxD4XNsSXi0ifYKZbrqBGSjCLlHvwqADI=; b=v6NZrRcc03i/LAx1MtmQH/zsI3ox74a08ew4B2sK0zop3ll94wwmMr8qkDKWbac48/ Gjl1DtXTn5shBeK3f4HEWrHBfeU4xiX89XpGk3ZQAU/btCgvLptYNLFv7J7iEkRBrcdh wN2hNE/F4r9FOOl4OWCgurdXtiS9VTk9LAVsSJGBbsGSNSdhSZ/iM0HQhLheho9cyzFd gY/AxgMuzSCfLxL+Lsc+91TNrNZz4rWjeGJy5QGDfZRiCQTuJlxfCH1yP/WqyByOrNnu VSCxhljM7hHWIQnSCCg/be+/5q1Raq2MiD5w5BmnOg47bs3bvPZX0Q+u6vSq3GKnPENr hizg== X-Gm-Message-State: AOAM533X99YDAl/Qj01E6p/xeeJiHtdw471z2LKx/RV/11aWKu72DYdS O+glebWAECoSg1ZFgzJN1e0= X-Google-Smtp-Source: ABdhPJynqGcrSez4vywi3ZAwZ9c1EdrO57Z15fp5aZAFGlBkrVlL1jMCkHBNN5fSrWBvd5Uebtem0g== X-Received: by 2002:a05:6808:171c:: with SMTP id bc28mr1273461oib.102.1642784073967; Fri, 21 Jan 2022 08:54:33 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.54.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:54:33 -0800 (PST) From: Luiz Sampaio To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH 07/31] input: touchscreen: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:12 -0300 Message-Id: <20220121165436.30956-8-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/input/touchscreen/stmfts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index bc11203c9cf7..7e7cb5f4d6d3 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -608,8 +608,8 @@ static int stmfts_enable_led(struct stmfts_data *sdata) return PTR_ERR(sdata->ledvdd); =20 sdata->led_cdev.name =3D STMFTS_DEV_NAME; - sdata->led_cdev.max_brightness =3D LED_ON; - sdata->led_cdev.brightness =3D LED_OFF; + sdata->led_cdev.max_brightness =3D 1; + sdata->led_cdev.brightness =3D 0; sdata->led_cdev.brightness_set_blocking =3D stmfts_brightness_set; sdata->led_cdev.brightness_get =3D stmfts_brightness_get; =20 --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A8CEC433F5 for ; Fri, 21 Jan 2022 16:55:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351572AbiAUQzk (ORCPT ); Fri, 21 Jan 2022 11:55:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379503AbiAUQyy (ORCPT ); Fri, 21 Jan 2022 11:54:54 -0500 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 183D8C061401; Fri, 21 Jan 2022 08:54:50 -0800 (PST) Received: by mail-oi1-x22f.google.com with SMTP id g205so14355435oif.5; Fri, 21 Jan 2022 08:54:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CtvdvKf3bfl2pica1l8Cw2pF6EugbvEYx4CaiKYIKZ0=; b=XGWEGyhJXLDY0/SCOgAaoYsffd1Ec5zfN1KHjqRA6n6f0VO9/vXz78ORilfU8noZkl SptuPXoysJlw+Y4qfRCYwIRQPooanvdGUn/mI0HxjADuWiNVkRtj4WUPg5AwiXjf5OXG sDCzJmuvM/XcDmX+2aVjbPjPSYA42wH89qrF0RqPukAFa3WlZW9/R4jfPZMs7u8HJOqr ulcSuDPYfZ/zQf3Xn8mfiYZM9Ip+f9mSTB76WCRLNPB1wDQN2TGWdUD0wF/2mSlnYcZG EhqRujrFa3sg/0044GLsQEi4dJ5wTLJQJMZK0ejLO2rGg47YqEFZl2SCpj+blTzWV6mz gsPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CtvdvKf3bfl2pica1l8Cw2pF6EugbvEYx4CaiKYIKZ0=; b=jvP8OqG2XdcKHHXybvA0nGaVvmD4GFO08bhsWO6xCkcUlnaVEnJsE2ynRcJZIERlvm pQywXPPUW10p55izyUIiOCjK/inSayzABTsEMzFBmMhAL2c1Yy1vN748fJ4ZSYYTqhbD hULgTi3tnAEGAdSRy5KbnURu5Q04X0yxsEu9vf7XLEI5bEHShMl9q/Nk+h8bkbt8PQKE VZvFscx7ovLVWytWroj+ajKAp5FxPUlUVOnNLoVNc0ZwOK2OFrn92+KpeuWygpRIm0CJ CL7jApuFtRCAfJRx7LbrgWJtPMN1/bca5478s69WSrr4f21uk4C7ErzvsquAFXv25oT+ CIkQ== X-Gm-Message-State: AOAM530hquEAFFNHIHdgcKRpT86W++XyF90yPT2U2x4njeo/NNkW+Eww 91897HilaepWSm6CMPRpmZyGKPQLLnAs5Q== X-Google-Smtp-Source: ABdhPJz0hHW1Wv5UZvrqiyoSuqikDmpEj2d/E38Gbh8uYnoC32BIP0MgXNnv57guy9ncUu3s8LU9ig== X-Received: by 2002:a05:6808:1306:: with SMTP id y6mr1306040oiv.49.1642784088560; Fri, 21 Jan 2022 08:54:48 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.54.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:54:48 -0800 (PST) From: Luiz Sampaio To: Pavel Machek , Matthias Brugger , Michael Hennerich , Support Opensource , Bartosz Golaszewski , Andreas Werner , Vadim Pasternak , Sean Wang , Riku Voipio , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, patches@opensource.cirrus.com Subject: [PATCH 08/31] leds: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:13 -0300 Message-Id: <20220121165436.30956-9-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/leds/blink/leds-lgm-sso.c | 8 +++---- drivers/leds/flash/leds-ktd2692.c | 4 ++-- drivers/leds/flash/leds-lm3601x.c | 10 ++++---- drivers/leds/flash/leds-mt6360.c | 10 ++++---- drivers/leds/flash/leds-rt4505.c | 8 +++---- drivers/leds/flash/leds-rt8515.c | 4 ++-- drivers/leds/flash/leds-sgm3140.c | 4 ++-- drivers/leds/led-class.c | 6 ++--- drivers/leds/led-core.c | 8 +++---- drivers/leds/led-triggers.c | 4 ++-- drivers/leds/leds-adp5520.c | 2 +- drivers/leds/leds-an30259a.c | 8 +++---- drivers/leds/leds-apu.c | 6 ++--- drivers/leds/leds-ariel.c | 8 +++---- drivers/leds/leds-asic3.c | 2 +- drivers/leds/leds-aw2013.c | 6 ++--- drivers/leds/leds-bcm6328.c | 14 +++++------ drivers/leds/leds-bcm6358.c | 14 +++++------ drivers/leds/leds-bd2802.c | 14 +++++------ drivers/leds/leds-clevo-mail.c | 6 ++--- drivers/leds/leds-cobalt-qube.c | 2 +- drivers/leds/leds-cpcap.c | 10 ++++---- drivers/leds/leds-da903x.c | 4 ++-- drivers/leds/leds-da9052.c | 4 ++-- drivers/leds/leds-dac124s085.c | 2 +- drivers/leds/leds-el15203000.c | 4 ++-- drivers/leds/leds-gpio.c | 4 ++-- drivers/leds/leds-is31fl319x.c | 2 +- drivers/leds/leds-lm3530.c | 4 ++-- drivers/leds/leds-lm3532.c | 8 +++---- drivers/leds/leds-lm3533.c | 4 ++-- drivers/leds/leds-lm3692x.c | 2 +- drivers/leds/leds-lm3697.c | 6 ++--- drivers/leds/leds-lp3952.c | 4 ++-- drivers/leds/leds-lt3593.c | 2 +- drivers/leds/leds-max77650.c | 4 ++-- drivers/leds/leds-menf21bmc.c | 2 +- drivers/leds/leds-mlxcpld.c | 22 ++++++++--------- drivers/leds/leds-mlxreg.c | 10 ++++---- drivers/leds/leds-mt6323.c | 2 +- drivers/leds/leds-netxbig.c | 4 ++-- drivers/leds/leds-nic78bx.c | 2 +- drivers/leds/leds-ns2.c | 4 ++-- drivers/leds/leds-ot200.c | 2 +- drivers/leds/leds-pca9532.c | 6 ++--- drivers/leds/leds-pca955x.c | 30 ++++++++++++------------ drivers/leds/leds-pca963x.c | 4 ++-- drivers/leds/leds-pm8058.c | 8 +++---- drivers/leds/leds-powernv.c | 12 +++++----- drivers/leds/leds-pwm.c | 2 +- drivers/leds/leds-rb532.c | 2 +- drivers/leds/leds-regulator.c | 2 +- drivers/leds/leds-sc27xx-bltc.c | 6 ++--- drivers/leds/leds-spi-byte.c | 2 +- drivers/leds/leds-ss4200.c | 12 +++++----- drivers/leds/leds-sunfire.c | 2 +- drivers/leds/leds-syscon.c | 2 +- drivers/leds/leds-tca6507.c | 8 +++---- drivers/leds/leds-wm831x-status.c | 8 +++---- drivers/leds/leds-wm8350.c | 8 +++---- drivers/leds/simple/simatic-ipc-leds.c | 10 ++++---- drivers/leds/trigger/ledtrig-activity.c | 2 +- drivers/leds/trigger/ledtrig-backlight.c | 4 ++-- drivers/leds/trigger/ledtrig-camera.c | 4 ++-- drivers/leds/trigger/ledtrig-cpu.c | 4 ++-- drivers/leds/trigger/ledtrig-gpio.c | 4 ++-- drivers/leds/trigger/ledtrig-heartbeat.c | 4 ++-- drivers/leds/trigger/ledtrig-netdev.c | 6 ++--- drivers/leds/trigger/ledtrig-oneshot.c | 6 ++--- drivers/leds/trigger/ledtrig-panic.c | 2 +- drivers/leds/trigger/ledtrig-pattern.c | 2 +- drivers/leds/trigger/ledtrig-timer.c | 2 +- drivers/leds/trigger/ledtrig-transient.c | 6 ++--- drivers/leds/trigger/ledtrig-tty.c | 4 ++-- 74 files changed, 217 insertions(+), 217 deletions(-) diff --git a/drivers/leds/blink/leds-lgm-sso.c b/drivers/leds/blink/leds-lg= m-sso.c index 6f270c0272fb..26c17c64bd4f 100644 --- a/drivers/leds/blink/leds-lgm-sso.c +++ b/drivers/leds/blink/leds-lgm-sso.c @@ -51,7 +51,7 @@ #define SSO_LED_MAX_NUM SZ_32 #define MAX_FREQ_RANK 10 #define DEF_GPTC_CLK_RATE 200000000 -#define SSO_DEF_BRIGHTNESS LED_HALF +#define SSO_DEF_BRIGHTNESS 127 #define DATA_CLK_EDGE 0 /* 0-rising, 1-falling */ =20 static const u32 freq_div_tbl[] =3D {4000, 2000, 1000, 800}; @@ -244,7 +244,7 @@ static void sso_led_brightness_set(struct led_classdev = *led_cdev, desc->brightness =3D brightness; regmap_write(priv->mmap, DUTY_CYCLE(desc->pin), brightness); =20 - if (brightness =3D=3D LED_OFF) + if (brightness =3D=3D 0) val =3D 0; else val =3D 1; @@ -360,7 +360,7 @@ static int sso_create_led(struct sso_led_priv *priv, st= ruct sso_led *led, led->cdev.brightness_set =3D sso_led_brightness_set; led->cdev.brightness_get =3D sso_led_brightness_get; led->cdev.brightness =3D desc->brightness; - led->cdev.max_brightness =3D LED_FULL; + led->cdev.max_brightness =3D 255; =20 if (desc->retain_state_shutdown) led->cdev.flags |=3D LED_RETAIN_AT_SHUTDOWN; @@ -696,7 +696,7 @@ __sso_led_dt_parse(struct sso_led_priv *priv, struct fw= node_handle *fw_ssoled) =20 if (!fwnode_property_read_string(fwnode_child, "default-state", &tmp)) { if (!strcmp(tmp, "on")) - desc->brightness =3D LED_FULL; + desc->brightness =3D 255; } =20 ret =3D sso_create_led(priv, led, fwnode_child); diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-kt= d2692.c index ed1f20a58bf6..30937156d156 100644 --- a/drivers/leds/flash/leds-ktd2692.c +++ b/drivers/leds/flash/leds-ktd2692.c @@ -161,7 +161,7 @@ static int ktd2692_led_brightness_set(struct led_classd= ev *led_cdev, =20 mutex_lock(&led->lock); =20 - if (brightness =3D=3D LED_OFF) { + if (brightness =3D=3D 0) { led->mode =3D KTD2692_MODE_DISABLE; gpiod_direction_output(led->aux_gpio, KTD2692_LOW); } else { @@ -199,7 +199,7 @@ static int ktd2692_led_flash_strobe_set(struct led_clas= sdev_flash *fled_cdev, =20 ktd2692_expresswire_write(led, led->mode | KTD2692_REG_MODE_BASE); =20 - fled_cdev->led_cdev.brightness =3D LED_OFF; + fled_cdev->led_cdev.brightness =3D 0; led->mode =3D KTD2692_MODE_DISABLE; =20 mutex_unlock(&led->lock); diff --git a/drivers/leds/flash/leds-lm3601x.c b/drivers/leds/flash/leds-lm= 3601x.c index d0e1d4814042..0edcb56a8e8d 100644 --- a/drivers/leds/flash/leds-lm3601x.c +++ b/drivers/leds/flash/leds-lm3601x.c @@ -185,9 +185,9 @@ static int lm3601x_brightness_set(struct led_classdev *= cdev, else led_mode_val =3D LM3601X_MODE_IR_DRV; =20 - if (brightness =3D=3D LED_OFF) { + if (brightness =3D=3D 0) { ret =3D regmap_update_bits(led->regmap, LM3601X_ENABLE_REG, - led_mode_val, LED_OFF); + led_mode_val, 0); goto out; } =20 @@ -232,7 +232,7 @@ static int lm3601x_strobe_set(struct led_classdev_flash= *fled_cdev, LM3601X_MODE_STROBE); else ret =3D regmap_update_bits(led->regmap, LM3601X_ENABLE_REG, - LM3601X_MODE_STROBE, LED_OFF); + LM3601X_MODE_STROBE, 0); =20 ret =3D lm3601x_read_faults(led); out: @@ -252,9 +252,9 @@ static int lm3601x_flash_brightness_set(struct led_clas= sdev_flash *fled_cdev, if (ret < 0) goto out; =20 - if (brightness =3D=3D LED_OFF) { + if (brightness =3D=3D 0) { ret =3D regmap_update_bits(led->regmap, LM3601X_ENABLE_REG, - LM3601X_MODE_STROBE, LED_OFF); + LM3601X_MODE_STROBE, 0); goto out; } =20 diff --git a/drivers/leds/flash/leds-mt6360.c b/drivers/leds/flash/leds-mt6= 360.c index e1066a52d2d2..69145a154b53 100644 --- a/drivers/leds/flash/leds-mt6360.c +++ b/drivers/leds/flash/leds-mt6360.c @@ -402,7 +402,7 @@ static int mt6360_isnk_init_default_state(struct mt6360= _led *led) return ret; =20 if (!(regval & MT6360_ISNK_ENMASK(led->led_no))) - level =3D LED_OFF; + level =3D 0; =20 switch (led->default_state) { case STATE_ON: @@ -412,7 +412,7 @@ static int mt6360_isnk_init_default_state(struct mt6360= _led *led) led->isnk.brightness =3D min(level, led->isnk.max_brightness); break; default: - led->isnk.brightness =3D LED_OFF; + led->isnk.brightness =3D 0; } =20 return mt6360_isnk_brightness_set(&led->isnk, led->isnk.brightness); @@ -440,7 +440,7 @@ static int mt6360_flash_init_default_state(struct mt636= 0_led *led) if ((regval & enable_mask) =3D=3D enable_mask) level +=3D 1; else - level =3D LED_OFF; + level =3D 0; =20 switch (led->default_state) { case STATE_ON: @@ -451,7 +451,7 @@ static int mt6360_flash_init_default_state(struct mt636= 0_led *led) min(level, flash->led_cdev.max_brightness); break; default: - flash->led_cdev.brightness =3D LED_OFF; + flash->led_cdev.brightness =3D 0; } =20 return mt6360_torch_brightness_set(&flash->led_cdev, @@ -542,7 +542,7 @@ static int mt6360_led_register(struct device *parent, s= truct mt6360_led *led, =20 switch (led->led_no) { case MT6360_VIRTUAL_MULTICOLOR: - ret =3D mt6360_mc_brightness_set(&led->mc.led_cdev, LED_OFF); + ret =3D mt6360_mc_brightness_set(&led->mc.led_cdev, 0); if (ret) { dev_err(parent, "Failed to init multicolor brightness\n"); diff --git a/drivers/leds/flash/leds-rt4505.c b/drivers/leds/flash/leds-rt4= 505.c index ee129ab7255d..d92899347928 100644 --- a/drivers/leds/flash/leds-rt4505.c +++ b/drivers/leds/flash/leds-rt4505.c @@ -59,7 +59,7 @@ static int rt4505_torch_brightness_set(struct led_classde= v *lcdev, =20 mutex_lock(&priv->lock); =20 - if (level !=3D LED_OFF) { + if (level !=3D 0) { ret =3D regmap_update_bits(priv->regmap, RT4505_REG_ILED, RT4505_ITORCH_MASK, (level - 1) << RT4505_ITORCH_SHIFT); @@ -90,19 +90,19 @@ static enum led_brightness rt4505_torch_brightness_get( ret =3D regmap_read(priv->regmap, RT4505_REG_ENABLE, &val); if (ret) { dev_err(lcdev->dev, "Failed to get LED enable\n"); - ret =3D LED_OFF; + ret =3D 0; goto unlock; } =20 if ((val & RT4505_ENABLE_MASK) !=3D RT4505_TORCH_SET) { - ret =3D LED_OFF; + ret =3D 0; goto unlock; } =20 ret =3D regmap_read(priv->regmap, RT4505_REG_ILED, &val); if (ret) { dev_err(lcdev->dev, "Failed to get LED brightness\n"); - ret =3D LED_OFF; + ret =3D 0; goto unlock; } =20 diff --git a/drivers/leds/flash/leds-rt8515.c b/drivers/leds/flash/leds-rt8= 515.c index 44904fdee3cc..e9eb5f57fe50 100644 --- a/drivers/leds/flash/leds-rt8515.c +++ b/drivers/leds/flash/leds-rt8515.c @@ -95,7 +95,7 @@ static int rt8515_led_brightness_set(struct led_classdev = *led, =20 mutex_lock(&rt->lock); =20 - if (brightness =3D=3D LED_OFF) { + if (brightness =3D=3D 0) { /* Off */ rt8515_gpio_led_off(rt); } else if (brightness < RT8515_TORCH_MAX) { @@ -132,7 +132,7 @@ static int rt8515_led_flash_strobe_set(struct led_class= dev_flash *fled, rt8515_gpio_led_off(rt); } =20 - fled->led_cdev.brightness =3D LED_OFF; + fled->led_cdev.brightness =3D 0; /* After this the torch LED will be disabled */ =20 mutex_unlock(&rt->lock); diff --git a/drivers/leds/flash/leds-sgm3140.c b/drivers/leds/flash/leds-sg= m3140.c index f4f831570f11..4c36488a33bb 100644 --- a/drivers/leds/flash/leds-sgm3140.c +++ b/drivers/leds/flash/leds-sgm3140.c @@ -101,7 +101,7 @@ static int sgm3140_brightness_set(struct led_classdev *= led_cdev, { struct led_classdev_flash *fled_cdev =3D lcdev_to_flcdev(led_cdev); struct sgm3140 *priv =3D flcdev_to_sgm3140(fled_cdev); - bool enable =3D brightness =3D=3D LED_ON; + bool enable =3D brightness =3D=3D 1; int ret; =20 if (priv->enabled =3D=3D enable) @@ -241,7 +241,7 @@ static int sgm3140_probe(struct platform_device *pdev) fled_cdev->ops =3D &sgm3140_flash_ops; =20 led_cdev->brightness_set_blocking =3D sgm3140_brightness_set; - led_cdev->max_brightness =3D LED_ON; + led_cdev->max_brightness =3D 1; led_cdev->flags |=3D LED_DEV_CAP_FLASH; =20 sgm3140_init_flash_timeout(priv); diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index 6a8ea94834fa..786132946a10 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c @@ -53,7 +53,7 @@ static ssize_t brightness_store(struct device *dev, if (ret) goto unlock; =20 - if (state =3D=3D LED_OFF) + if (state =3D=3D 0) led_trigger_remove(led_cdev); led_set_brightness(led_cdev, state); flush_work(&led_cdev->set_brightness_work); @@ -405,7 +405,7 @@ int led_classdev_register_ext(struct device *parent, up_write(&leds_list_lock); =20 if (!led_cdev->max_brightness) - led_cdev->max_brightness =3D LED_FULL; + led_cdev->max_brightness =3D 255; =20 led_update_brightness(led_cdev); =20 @@ -448,7 +448,7 @@ void led_classdev_unregister(struct led_classdev *led_c= dev) led_stop_software_blink(led_cdev); =20 if (!(led_cdev->flags & LED_RETAIN_AT_SHUTDOWN)) - led_set_brightness(led_cdev, LED_OFF); + led_set_brightness(led_cdev, 0); =20 flush_work(&led_cdev->set_brightness_work); =20 diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index 4a97cb745788..eb51f9f7d81c 100644 --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c @@ -64,7 +64,7 @@ static void led_timer_function(struct timer_list *t) unsigned long delay; =20 if (!led_cdev->blink_delay_on || !led_cdev->blink_delay_off) { - led_set_brightness_nosleep(led_cdev, LED_OFF); + led_set_brightness_nosleep(led_cdev, 0); clear_bit(LED_BLINK_SW, &led_cdev->work_flags); return; } @@ -89,7 +89,7 @@ static void led_timer_function(struct timer_list *t) * to restore it when the delay_off period is over. */ led_cdev->blink_brightness =3D brightness; - brightness =3D LED_OFF; + brightness =3D 0; delay =3D led_cdev->blink_delay_off; } =20 @@ -121,7 +121,7 @@ static void set_brightness_delayed(struct work_struct *= ws) int ret =3D 0; =20 if (test_and_clear_bit(LED_BLINK_DISABLE, &led_cdev->work_flags)) { - led_cdev->delayed_set_value =3D LED_OFF; + led_cdev->delayed_set_value =3D 0; led_stop_software_blink(led_cdev); } =20 @@ -154,7 +154,7 @@ static void led_set_software_blink(struct led_classdev = *led_cdev, =20 /* never on - just set to off */ if (!delay_on) { - led_set_brightness_nosleep(led_cdev, LED_OFF); + led_set_brightness_nosleep(led_cdev, 0); return; } =20 diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c index 072491d3e17b..17fba1ad0d3d 100644 --- a/drivers/leds/led-triggers.c +++ b/drivers/leds/led-triggers.c @@ -185,7 +185,7 @@ int led_trigger_set(struct led_classdev *led_cdev, stru= ct led_trigger *trig) led_cdev->trigger =3D NULL; led_cdev->trigger_data =3D NULL; led_cdev->activated =3D false; - led_set_brightness(led_cdev, LED_OFF); + led_set_brightness(led_cdev, 0); } if (trig) { spin_lock(&trig->leddev_list_lock); @@ -231,7 +231,7 @@ int led_trigger_set(struct led_classdev *led_cdev, stru= ct led_trigger *trig) synchronize_rcu(); led_cdev->trigger =3D NULL; led_cdev->trigger_data =3D NULL; - led_set_brightness(led_cdev, LED_OFF); + led_set_brightness(led_cdev, 0); kfree(event); =20 return ret; diff --git a/drivers/leds/leds-adp5520.c b/drivers/leds/leds-adp5520.c index 5a0cc7af2df8..0cc92acffbed 100644 --- a/drivers/leds/leds-adp5520.c +++ b/drivers/leds/leds-adp5520.c @@ -125,7 +125,7 @@ static int adp5520_led_probe(struct platform_device *pd= ev) led_dat->cdev.name =3D cur_led->name; led_dat->cdev.default_trigger =3D cur_led->default_trigger; led_dat->cdev.brightness_set_blocking =3D adp5520_led_set; - led_dat->cdev.brightness =3D LED_OFF; + led_dat->cdev.brightness =3D 0; =20 if (cur_led->flags & ADP5520_FLAG_LED_MASK) led_dat->flags =3D cur_led->flags; diff --git a/drivers/leds/leds-an30259a.c b/drivers/leds/leds-an30259a.c index a0df1fb28774..8df45d78418b 100644 --- a/drivers/leds/leds-an30259a.c +++ b/drivers/leds/leds-an30259a.c @@ -93,7 +93,7 @@ static int an30259a_brightness_set(struct led_classdev *c= dev, goto error; =20 switch (brightness) { - case LED_OFF: + case 0: led_on &=3D ~AN30259A_LED_EN(led->num); led_on &=3D ~AN30259A_LED_SLOPE(led->num); led->sloping =3D false; @@ -262,7 +262,7 @@ static void an30259a_init_default_state(struct an30259a= _led *led) =20 switch (led->default_state) { case STATE_ON: - led->cdev.brightness =3D LED_FULL; + led->cdev.brightness =3D 255; break; case STATE_KEEP: err =3D regmap_read(chip->regmap, AN30259A_REG_LED_ON, &led_on); @@ -270,14 +270,14 @@ static void an30259a_init_default_state(struct an3025= 9a_led *led) break; =20 if (!(led_on & AN30259A_LED_EN(led->num))) { - led->cdev.brightness =3D LED_OFF; + led->cdev.brightness =3D 0; break; } regmap_read(chip->regmap, AN30259A_REG_LEDCC(led->num), &led->cdev.brightness); break; default: - led->cdev.brightness =3D LED_OFF; + led->cdev.brightness =3D 0; } =20 an30259a_brightness_set(&led->cdev, led->cdev.brightness); diff --git a/drivers/leds/leds-apu.c b/drivers/leds/leds-apu.c index c409b80c236d..172f86daab3b 100644 --- a/drivers/leds/leds-apu.c +++ b/drivers/leds/leds-apu.c @@ -77,9 +77,9 @@ struct apu_led_pdata { static struct apu_led_pdata *apu_led; =20 static const struct apu_led_profile apu1_led_profile[] =3D { - { "apu:green:1", LED_ON, APU1_FCH_GPIO_BASE + 0 * APU1_IOSIZE }, - { "apu:green:2", LED_OFF, APU1_FCH_GPIO_BASE + 1 * APU1_IOSIZE }, - { "apu:green:3", LED_OFF, APU1_FCH_GPIO_BASE + 2 * APU1_IOSIZE }, + { "apu:green:1", 1, APU1_FCH_GPIO_BASE + 0 * APU1_IOSIZE }, + { "apu:green:2", 0, APU1_FCH_GPIO_BASE + 1 * APU1_IOSIZE }, + { "apu:green:3", 0, APU1_FCH_GPIO_BASE + 2 * APU1_IOSIZE }, }; =20 static const struct dmi_system_id apu_led_dmi_table[] __initconst =3D { diff --git a/drivers/leds/leds-ariel.c b/drivers/leds/leds-ariel.c index 49e1bddaa15e..6a6cfdf7c7df 100644 --- a/drivers/leds/leds-ariel.c +++ b/drivers/leds/leds-ariel.c @@ -37,12 +37,12 @@ static enum led_brightness ariel_led_get(struct led_cla= ssdev *led_cdev) unsigned int led_status =3D 0; =20 if (regmap_read(led->ec_ram, led->ec_index, &led_status)) - return LED_OFF; + return 0; =20 if (led_status =3D=3D EC_LED_STILL) - return LED_FULL; + return 255; else - return LED_OFF; + return 0; } =20 static void ariel_led_set(struct led_classdev *led_cdev, @@ -50,7 +50,7 @@ static void ariel_led_set(struct led_classdev *led_cdev, { struct ariel_led *led =3D led_cdev_to_ariel_led(led_cdev); =20 - if (brightness =3D=3D LED_OFF) + if (brightness =3D=3D 0) regmap_write(led->ec_ram, led->ec_index, EC_LED_OFF); else regmap_write(led->ec_ram, led->ec_index, EC_LED_STILL); diff --git a/drivers/leds/leds-asic3.c b/drivers/leds/leds-asic3.c index 8cbc1b8bafa5..53b7b8551808 100644 --- a/drivers/leds/leds-asic3.c +++ b/drivers/leds/leds-asic3.c @@ -42,7 +42,7 @@ static void brightness_set(struct led_classdev *cdev, u32 timebase; unsigned int base; =20 - timebase =3D (value =3D=3D LED_OFF) ? 0 : (LED_EN|0x4); + timebase =3D (value =3D=3D 0) ? 0 : (LED_EN|0x4); =20 base =3D led_n_base[cell->id]; asic3_write_register(asic, (base + ASIC3_LED_PeriodTime), 32); diff --git a/drivers/leds/leds-aw2013.c b/drivers/leds/leds-aw2013.c index 80d937454aee..4b3043ed1d69 100644 --- a/drivers/leds/leds-aw2013.c +++ b/drivers/leds/leds-aw2013.c @@ -206,7 +206,7 @@ static int aw2013_blink_set(struct led_classdev *cdev, } =20 if (!led->cdev.brightness) { - led->cdev.brightness =3D LED_FULL; + led->cdev.brightness =3D 255; ret =3D aw2013_brightness_set(&led->cdev, led->cdev.brightness); if (ret) return ret; @@ -214,8 +214,8 @@ static int aw2013_blink_set(struct led_classdev *cdev, =20 /* Never on - just set to off */ if (!*delay_on) { - led->cdev.brightness =3D LED_OFF; - return aw2013_brightness_set(&led->cdev, LED_OFF); + led->cdev.brightness =3D 0; + return aw2013_brightness_set(&led->cdev, 0); } =20 mutex_lock(&led->chip->mutex); diff --git a/drivers/leds/leds-bcm6328.c b/drivers/leds/leds-bcm6328.c index 2d4d87957a30..7a2d26429653 100644 --- a/drivers/leds/leds-bcm6328.c +++ b/drivers/leds/leds-bcm6328.c @@ -138,8 +138,8 @@ static void bcm6328_led_set(struct led_classdev *led_cd= ev, led->blink_leds[1] &=3D ~BIT(led->pin); =20 /* Set LED on/off */ - if ((led->active_low && value =3D=3D LED_OFF) || - (!led->active_low && value !=3D LED_OFF)) + if ((led->active_low && value =3D=3D 0) || + (!led->active_low && value !=3D 0)) bcm6328_led_mode(led, BCM6328_LED_MODE_ON); else bcm6328_led_mode(led, BCM6328_LED_MODE_OFF); @@ -348,7 +348,7 @@ static int bcm6328_led(struct device *dev, struct devic= e_node *nc, u32 reg, =20 if (!of_property_read_string(nc, "default-state", &state)) { if (!strcmp(state, "on")) { - led->cdev.brightness =3D LED_FULL; + led->cdev.brightness =3D 255; } else if (!strcmp(state, "keep")) { void __iomem *mode; unsigned long val, shift; @@ -364,14 +364,14 @@ static int bcm6328_led(struct device *dev, struct dev= ice_node *nc, u32 reg, val &=3D BCM6328_LED_MODE_MASK; if ((led->active_low && val =3D=3D BCM6328_LED_MODE_OFF) || (!led->active_low && val =3D=3D BCM6328_LED_MODE_ON)) - led->cdev.brightness =3D LED_FULL; + led->cdev.brightness =3D 255; else - led->cdev.brightness =3D LED_OFF; + led->cdev.brightness =3D 0; } else { - led->cdev.brightness =3D LED_OFF; + led->cdev.brightness =3D 0; } } else { - led->cdev.brightness =3D LED_OFF; + led->cdev.brightness =3D 0; } =20 bcm6328_led_set(&led->cdev, led->cdev.brightness); diff --git a/drivers/leds/leds-bcm6358.c b/drivers/leds/leds-bcm6358.c index 9d2e487fa08a..955fdd4e0967 100644 --- a/drivers/leds/leds-bcm6358.c +++ b/drivers/leds/leds-bcm6358.c @@ -82,8 +82,8 @@ static void bcm6358_led_set(struct led_classdev *led_cdev, spin_lock_irqsave(led->lock, flags); bcm6358_led_busy(led->mem); val =3D bcm6358_led_read(led->mem + BCM6358_REG_MODE); - if ((led->active_low && value =3D=3D LED_OFF) || - (!led->active_low && value !=3D LED_OFF)) + if ((led->active_low && value =3D=3D 0) || + (!led->active_low && value !=3D 0)) val |=3D BIT(led->pin); else val &=3D ~(BIT(led->pin)); @@ -112,21 +112,21 @@ static int bcm6358_led(struct device *dev, struct dev= ice_node *nc, u32 reg, =20 if (!of_property_read_string(nc, "default-state", &state)) { if (!strcmp(state, "on")) { - led->cdev.brightness =3D LED_FULL; + led->cdev.brightness =3D 255; } else if (!strcmp(state, "keep")) { unsigned long val; val =3D bcm6358_led_read(led->mem + BCM6358_REG_MODE); val &=3D BIT(led->pin); if ((led->active_low && !val) || (!led->active_low && val)) - led->cdev.brightness =3D LED_FULL; + led->cdev.brightness =3D 255; else - led->cdev.brightness =3D LED_OFF; + led->cdev.brightness =3D 0; } else { - led->cdev.brightness =3D LED_OFF; + led->cdev.brightness =3D 0; } } else { - led->cdev.brightness =3D LED_OFF; + led->cdev.brightness =3D 0; } =20 bcm6358_led_set(&led->cdev, led->cdev.brightness); diff --git a/drivers/leds/leds-bd2802.c b/drivers/leds/leds-bd2802.c index 8bbaef5a2986..096b8c86c0ea 100644 --- a/drivers/leds/leds-bd2802.c +++ b/drivers/leds/leds-bd2802.c @@ -522,7 +522,7 @@ static int bd2802_set_##name##_brightness(struct led_cl= assdev *led_cdev,\ container_of(led_cdev, struct bd2802_led, cdev_##name); \ led->led_id =3D id; \ led->color =3D clr; \ - if (value =3D=3D LED_OFF) { \ + if (value =3D=3D 0) { \ led->state =3D BD2802_OFF; \ bd2802_turn_off(led, led->led_id, led->color); \ } else { \ @@ -557,7 +557,7 @@ static int bd2802_register_led_classdev(struct bd2802_l= ed *led) int ret; =20 led->cdev_led1r.name =3D "led1_R"; - led->cdev_led1r.brightness =3D LED_OFF; + led->cdev_led1r.brightness =3D 0; led->cdev_led1r.brightness_set_blocking =3D bd2802_set_led1r_brightness; led->cdev_led1r.blink_set =3D bd2802_set_led1r_blink; =20 @@ -569,7 +569,7 @@ static int bd2802_register_led_classdev(struct bd2802_l= ed *led) } =20 led->cdev_led1g.name =3D "led1_G"; - led->cdev_led1g.brightness =3D LED_OFF; + led->cdev_led1g.brightness =3D 0; led->cdev_led1g.brightness_set_blocking =3D bd2802_set_led1g_brightness; led->cdev_led1g.blink_set =3D bd2802_set_led1g_blink; =20 @@ -581,7 +581,7 @@ static int bd2802_register_led_classdev(struct bd2802_l= ed *led) } =20 led->cdev_led1b.name =3D "led1_B"; - led->cdev_led1b.brightness =3D LED_OFF; + led->cdev_led1b.brightness =3D 0; led->cdev_led1b.brightness_set_blocking =3D bd2802_set_led1b_brightness; led->cdev_led1b.blink_set =3D bd2802_set_led1b_blink; =20 @@ -593,7 +593,7 @@ static int bd2802_register_led_classdev(struct bd2802_l= ed *led) } =20 led->cdev_led2r.name =3D "led2_R"; - led->cdev_led2r.brightness =3D LED_OFF; + led->cdev_led2r.brightness =3D 0; led->cdev_led2r.brightness_set_blocking =3D bd2802_set_led2r_brightness; led->cdev_led2r.blink_set =3D bd2802_set_led2r_blink; =20 @@ -605,7 +605,7 @@ static int bd2802_register_led_classdev(struct bd2802_l= ed *led) } =20 led->cdev_led2g.name =3D "led2_G"; - led->cdev_led2g.brightness =3D LED_OFF; + led->cdev_led2g.brightness =3D 0; led->cdev_led2g.brightness_set_blocking =3D bd2802_set_led2g_brightness; led->cdev_led2g.blink_set =3D bd2802_set_led2g_blink; =20 @@ -617,7 +617,7 @@ static int bd2802_register_led_classdev(struct bd2802_l= ed *led) } =20 led->cdev_led2b.name =3D "led2_B"; - led->cdev_led2b.brightness =3D LED_OFF; + led->cdev_led2b.brightness =3D 0; led->cdev_led2b.brightness_set_blocking =3D bd2802_set_led2b_brightness; led->cdev_led2b.blink_set =3D bd2802_set_led2b_blink; led->cdev_led2b.flags |=3D LED_CORE_SUSPENDRESUME; diff --git a/drivers/leds/leds-clevo-mail.c b/drivers/leds/leds-clevo-mail.c index f512e99b976b..24e985539b18 100644 --- a/drivers/leds/leds-clevo-mail.c +++ b/drivers/leds/leds-clevo-mail.c @@ -97,9 +97,9 @@ static void clevo_mail_led_set(struct led_classdev *led_c= dev, { i8042_lock_chip(); =20 - if (value =3D=3D LED_OFF) + if (value =3D=3D 0) i8042_command(NULL, CLEVO_MAIL_LED_OFF); - else if (value <=3D LED_HALF) + else if (value <=3D 127) i8042_command(NULL, CLEVO_MAIL_LED_BLINK_0_5HZ); else i8042_command(NULL, CLEVO_MAIL_LED_BLINK_1HZ); @@ -210,7 +210,7 @@ static void __exit clevo_mail_led_exit(void) platform_device_unregister(pdev); platform_driver_unregister(&clevo_mail_led_driver); =20 - clevo_mail_led_set(NULL, LED_OFF); + clevo_mail_led_set(NULL, 0); } =20 module_init(clevo_mail_led_init); diff --git a/drivers/leds/leds-cobalt-qube.c b/drivers/leds/leds-cobalt-qub= e.c index ef22e1e94048..4af123a10342 100644 --- a/drivers/leds/leds-cobalt-qube.c +++ b/drivers/leds/leds-cobalt-qube.c @@ -29,7 +29,7 @@ static void qube_front_led_set(struct led_classdev *led_c= dev, =20 static struct led_classdev qube_front_led =3D { .name =3D "qube::front", - .brightness =3D LED_FULL, + .brightness =3D 255, .brightness_set =3D qube_front_led_set, .default_trigger =3D "default-on", }; diff --git a/drivers/leds/leds-cpcap.c b/drivers/leds/leds-cpcap.c index 7d41ce8c9bb1..8f7eba98a636 100644 --- a/drivers/leds/leds-cpcap.c +++ b/drivers/leds/leds-cpcap.c @@ -108,13 +108,13 @@ static int cpcap_led_set(struct led_classdev *ledc, e= num led_brightness value) =20 mutex_lock(&led->update_lock); =20 - if (value > LED_OFF) { + if (value > 0) { err =3D cpcap_led_set_power(led, true); if (err) goto exit; } =20 - if (value =3D=3D LED_OFF) { + if (value =3D=3D 0) { /* Avoid HW issue by turning off current before duty cycle */ err =3D regmap_update_bits(led->regmap, led->info->reg, led->info->mask, CPCAP_LED_NO_CURRENT); @@ -123,9 +123,9 @@ static int cpcap_led_set(struct led_classdev *ledc, enu= m led_brightness value) goto exit; } =20 - brightness =3D cpcap_led_val(value, LED_OFF); + brightness =3D cpcap_led_val(value, 0); } else { - brightness =3D cpcap_led_val(value, LED_ON); + brightness =3D cpcap_led_val(value, 1); } =20 err =3D regmap_update_bits(led->regmap, led->info->reg, led->info->mask, @@ -135,7 +135,7 @@ static int cpcap_led_set(struct led_classdev *ledc, enu= m led_brightness value) goto exit; } =20 - if (value =3D=3D LED_OFF) { + if (value =3D=3D 0) { err =3D cpcap_led_set_power(led, false); if (err) goto exit; diff --git a/drivers/leds/leds-da903x.c b/drivers/leds/leds-da903x.c index 2b5fb00438a2..a09446591add 100644 --- a/drivers/leds/leds-da903x.c +++ b/drivers/leds/leds-da903x.c @@ -66,7 +66,7 @@ static int da903x_led_set(struct led_classdev *led_cdev, case DA9034_ID_LED_1: case DA9034_ID_LED_2: offset =3D DA9034_LED_OFFSET(led->id); - val =3D (value * 0x5f / LED_FULL) & 0x7f; + val =3D (value * 0x5f / 255) & 0x7f; val |=3D (led->flags & DA9034_LED_RAMP) ? 0x80 : 0; ret =3D da903x_write(led->master, DA9034_LED1_CONTROL + offset, val); @@ -104,7 +104,7 @@ static int da903x_led_probe(struct platform_device *pde= v) led->cdev.name =3D pdata->name; led->cdev.default_trigger =3D pdata->default_trigger; led->cdev.brightness_set_blocking =3D da903x_led_set; - led->cdev.brightness =3D LED_OFF; + led->cdev.brightness =3D 0; =20 led->id =3D id; led->flags =3D pdata->flags; diff --git a/drivers/leds/leds-da9052.c b/drivers/leds/leds-da9052.c index 04060c862bf9..69b72892b540 100644 --- a/drivers/leds/leds-da9052.c +++ b/drivers/leds/leds-da9052.c @@ -119,7 +119,7 @@ static int da9052_led_probe(struct platform_device *pde= v) for (i =3D 0; i < pled->num_leds; i++) { led[i].cdev.name =3D pled->leds[i].name; led[i].cdev.brightness_set_blocking =3D da9052_led_set; - led[i].cdev.brightness =3D LED_OFF; + led[i].cdev.brightness =3D 0; led[i].cdev.max_brightness =3D DA9052_MAX_BRIGHTNESS; led[i].led_index =3D pled->leds[i].flags; led[i].da9052 =3D dev_get_drvdata(pdev->dev.parent); @@ -169,7 +169,7 @@ static int da9052_led_remove(struct platform_device *pd= ev) pled =3D pdata->pled; =20 for (i =3D 0; i < pled->num_leds; i++) { - da9052_set_led_brightness(&led[i], LED_OFF); + da9052_set_led_brightness(&led[i], 0); led_classdev_unregister(&led[i].cdev); } =20 diff --git a/drivers/leds/leds-dac124s085.c b/drivers/leds/leds-dac124s085.c index 20dc9b9d7dea..582d9a070115 100644 --- a/drivers/leds/leds-dac124s085.c +++ b/drivers/leds/leds-dac124s085.c @@ -66,7 +66,7 @@ static int dac124s085_probe(struct spi_device *spi) snprintf(led->name, sizeof(led->name), "dac124s085-%d", i); mutex_init(&led->mutex); led->ldev.name =3D led->name; - led->ldev.brightness =3D LED_OFF; + led->ldev.brightness =3D 0; led->ldev.max_brightness =3D 0xfff; led->ldev.brightness_set_blocking =3D dac124s085_set_brightness; ret =3D led_classdev_register(&spi->dev, &led->ldev); diff --git a/drivers/leds/leds-el15203000.c b/drivers/leds/leds-el15203000.c index f9eb59a25570..b1a7ceaca434 100644 --- a/drivers/leds/leds-el15203000.c +++ b/drivers/leds/leds-el15203000.c @@ -133,7 +133,7 @@ static int el15203000_set_blocking(struct led_classdev = *ldev, { struct el15203000_led *led =3D to_el15203000_led(ldev); =20 - return el15203000_cmd(led, brightness =3D=3D LED_OFF ? EL_OFF : EL_ON); + return el15203000_cmd(led, brightness =3D=3D 0 ? EL_OFF : EL_ON); } =20 static int el15203000_pattern_set_S(struct led_classdev *ldev, @@ -256,7 +256,7 @@ static int el15203000_probe_dt(struct el15203000 *priv) } =20 led->priv =3D priv; - led->ldev.max_brightness =3D LED_ON; + led->ldev.max_brightness =3D 1; led->ldev.brightness_set_blocking =3D el15203000_set_blocking; =20 if (led->reg =3D=3D 'S') { diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 092eb59a7d32..ac363efc37bc 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -38,7 +38,7 @@ static void gpio_led_set(struct led_classdev *led_cdev, struct gpio_led_data *led_dat =3D cdev_to_gpio_led_data(led_cdev); int level; =20 - if (value =3D=3D LED_OFF) + if (value =3D=3D 0) level =3D 0; else level =3D 1; @@ -292,7 +292,7 @@ static void gpio_led_shutdown(struct platform_device *p= dev) struct gpio_led_data *led =3D &priv->leds[i]; =20 if (!(led->cdev.flags & LED_RETAIN_AT_SHUTDOWN)) - gpio_led_set(&led->cdev, LED_OFF); + gpio_led_set(&led->cdev, 0); } } =20 diff --git a/drivers/leds/leds-is31fl319x.c b/drivers/leds/leds-is31fl319x.c index 4161b9dd7e48..2a9c8dcc9a2c 100644 --- a/drivers/leds/leds-is31fl319x.c +++ b/drivers/leds/leds-is31fl319x.c @@ -140,7 +140,7 @@ static int is31fl319x_brightness_set(struct led_classde= v *cdev, ret =3D regmap_read(is31->regmap, IS31FL319X_PWM(i), &pwm_value); dev_dbg(&is31->client->dev, "%s read %d: ret=3D%d: %d\n", __func__, i, ret, pwm_value); - on =3D ret >=3D 0 && pwm_value > LED_OFF; + on =3D ret >=3D 0 && pwm_value > 0; =20 if (i < 3) ctrl1 |=3D on << i; /* 0..2 =3D> bit 0..2 */ diff --git a/drivers/leds/leds-lm3530.c b/drivers/leds/leds-lm3530.c index e72393534b72..a5358cac5d4d 100644 --- a/drivers/leds/leds-lm3530.c +++ b/drivers/leds/leds-lm3530.c @@ -174,7 +174,7 @@ static void lm3530_als_configure(struct lm3530_platform= _data *pdata, =20 for (i =3D 0; i < LM3530_ALS_ZB_MAX; i++) als->zones[i] =3D (((als_vmin + LM3530_ALS_OFFSET_mV) + - als_vstep + (i * als_vstep)) * LED_FULL) / 1000; + als_vstep + (i * als_vstep)) * 255) / 1000; =20 als->config =3D (pdata->als_avrg_time << LM3530_ALS_AVG_TIME_SHIFT) | @@ -436,7 +436,7 @@ static int lm3530_probe(struct i2c_client *client, drvdata->mode =3D pdata->mode; drvdata->client =3D client; drvdata->pdata =3D pdata; - drvdata->brightness =3D LED_OFF; + drvdata->brightness =3D 0; drvdata->enable =3D false; drvdata->led_dev.name =3D LM3530_LED_DEV; drvdata->led_dev.brightness_set =3D lm3530_brightness_set; diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c index beb53040e09e..b0671fe4957b 100644 --- a/drivers/leds/leds-lm3532.c +++ b/drivers/leds/leds-lm3532.c @@ -354,7 +354,7 @@ static int lm3532_brightness_set(struct led_classdev *l= ed_cdev, mutex_lock(&led->priv->lock); =20 if (led->mode =3D=3D LM3532_ALS_CTRL) { - if (brt_val > LED_OFF) + if (brt_val > 0) ret =3D lm3532_led_enable(led); else ret =3D lm3532_led_disable(led); @@ -362,7 +362,7 @@ static int lm3532_brightness_set(struct led_classdev *l= ed_cdev, goto unlock; } =20 - if (brt_val =3D=3D LED_OFF) { + if (brt_val =3D=3D 0) { ret =3D lm3532_led_disable(led); goto unlock; } @@ -459,9 +459,9 @@ static int lm3532_als_configure(struct lm3532_data *pri= v, =20 for (i =3D 0; i < LM3532_ALS_ZB_MAX; i++) { als->zones_lo[i] =3D ((als_vmin + als_vstep + (i * als_vstep)) * - LED_FULL) / 1000; + 255) / 1000; als->zones_hi[i] =3D ((als_vmin + LM3532_ALS_OFFSET_mV + - als_vstep + (i * als_vstep)) * LED_FULL) / 1000; + als_vstep + (i * als_vstep)) * 255) / 1000; =20 zone_reg =3D LM3532_REG_ZN_0_HI + i * 2; ret =3D regmap_write(priv->regmap, zone_reg, als->zones_lo[i]); diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c index 43d5970d96aa..7411c528a0d4 100644 --- a/drivers/leds/leds-lm3533.c +++ b/drivers/leds/leds-lm3533.c @@ -678,7 +678,7 @@ static int lm3533_led_probe(struct platform_device *pde= v) led->cdev.brightness_set_blocking =3D lm3533_led_set; led->cdev.brightness_get =3D lm3533_led_get; led->cdev.blink_set =3D lm3533_led_blink_set; - led->cdev.brightness =3D LED_OFF; + led->cdev.brightness =3D 0; led->cdev.groups =3D lm3533_led_attribute_groups; led->id =3D pdev->id; =20 @@ -738,7 +738,7 @@ static void lm3533_led_shutdown(struct platform_device = *pdev) dev_dbg(&pdev->dev, "%s\n", __func__); =20 lm3533_ctrlbank_disable(&led->cb); - lm3533_led_set(&led->cdev, LED_OFF); /* disable blink */ + lm3533_led_set(&led->cdev, 0); /* disable blink */ } =20 static struct platform_driver lm3533_led_driver =3D { diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c index afe6fb297855..be5fbed7f428 100644 --- a/drivers/leds/leds-lm3692x.c +++ b/drivers/leds/leds-lm3692x.c @@ -440,7 +440,7 @@ static int lm3692x_probe_dt(struct lm3692x_led *led) } =20 ret =3D fwnode_property_read_u32(child, "led-max-microamp", &max_cur); - led->led_dev.max_brightness =3D ret ? LED_FULL : + led->led_dev.max_brightness =3D ret ? 255 : lm3692x_max_brightness(led, max_cur); =20 init_data.fwnode =3D child; diff --git a/drivers/leds/leds-lm3697.c b/drivers/leds/leds-lm3697.c index a8c9322558cc..9366e0b7fb4d 100644 --- a/drivers/leds/leds-lm3697.c +++ b/drivers/leds/leds-lm3697.c @@ -52,7 +52,7 @@ * @lmu_data: Register and setting values for common code * @control_bank: Control bank the LED is associated to. 0 is control bank= A * 1 is control bank B - * @enabled: LED brightness level (or LED_OFF) + * @enabled: LED brightness level (or 0) * @num_leds: Number of LEDs available */ struct lm3697_led { @@ -130,7 +130,7 @@ static int lm3697_brightness_set(struct led_classdev *l= ed_cdev, =20 mutex_lock(&led->priv->lock); =20 - if (brt_val =3D=3D LED_OFF) { + if (brt_val =3D=3D 0) { ret =3D regmap_update_bits(led->priv->regmap, LM3697_CTRL_ENABLE, ctrl_en_val, ~ctrl_en_val); if (ret) { @@ -138,7 +138,7 @@ static int lm3697_brightness_set(struct led_classdev *l= ed_cdev, goto brightness_out; } =20 - led->enabled =3D LED_OFF; + led->enabled =3D 0; } else { ret =3D ti_lmu_common_set_brightness(&led->lmu_data, brt_val); if (ret) { diff --git a/drivers/leds/leds-lp3952.c b/drivers/leds/leds-lp3952.c index 6ee9131fbf25..3b65b0206312 100644 --- a/drivers/leds/leds-lp3952.c +++ b/drivers/leds/leds-lp3952.c @@ -67,7 +67,7 @@ static int lp3952_set_brightness(struct led_classdev *cde= v, dev_dbg(cdev->dev, "Brightness request: %d on %d\n", value, led->channel); =20 - if (value =3D=3D LED_OFF) { + if (value =3D=3D 0) { lp3952_on_off(priv, led->channel, false); return 0; } @@ -124,7 +124,7 @@ static int lp3952_register_led_classdev(struct lp3952_l= ed_array *priv) continue; =20 priv->leds[i].cdev.name =3D priv->leds[i].name; - priv->leds[i].cdev.brightness =3D LED_OFF; + priv->leds[i].cdev.brightness =3D 0; priv->leds[i].cdev.max_brightness =3D LP3952_BRIGHT_MAX; priv->leds[i].cdev.brightness_set_blocking =3D lp3952_set_brightness; diff --git a/drivers/leds/leds-lt3593.c b/drivers/leds/leds-lt3593.c index d0160fde0f94..dd69c190ce10 100644 --- a/drivers/leds/leds-lt3593.c +++ b/drivers/leds/leds-lt3593.c @@ -90,7 +90,7 @@ static int lt3593_led_probe(struct platform_device *pdev) } =20 led_data->cdev.brightness_set_blocking =3D lt3593_led_set; - led_data->cdev.brightness =3D state ? LED_FULL : LED_OFF; + led_data->cdev.brightness =3D state ? 255 : 0; =20 init_data.fwnode =3D child; init_data.devicename =3D LED_LT3593_NAME; diff --git a/drivers/leds/leds-max77650.c b/drivers/leds/leds-max77650.c index 1eeac56b0014..5ea67e3c319c 100644 --- a/drivers/leds/leds-max77650.c +++ b/drivers/leds/leds-max77650.c @@ -45,14 +45,14 @@ static struct max77650_led *max77650_to_led(struct led_= classdev *cdev) } =20 static int max77650_led_brightness_set(struct led_classdev *cdev, - enum led_brightness brightness) + unsigned int brightness) { struct max77650_led *led =3D max77650_to_led(cdev); int val, mask; =20 mask =3D MAX77650_LED_BR_MASK | MAX77650_LED_EN_MASK; =20 - if (brightness =3D=3D LED_OFF) + if (brightness =3D=3D 0) val =3D MAX77650_LED_DISABLE; else val =3D MAX77650_LED_ENABLE | brightness; diff --git a/drivers/leds/leds-menf21bmc.c b/drivers/leds/leds-menf21bmc.c index 6b1b47160602..0203db50cda2 100644 --- a/drivers/leds/leds-menf21bmc.c +++ b/drivers/leds/leds-menf21bmc.c @@ -62,7 +62,7 @@ menf21bmc_led_set(struct led_classdev *led_cdev, enum led= _brightness value) if (led_val < 0) goto err_out; =20 - if (value =3D=3D LED_OFF) + if (value =3D=3D 0) led_val &=3D ~led->led_bit; else led_val |=3D led->led_bit; diff --git a/drivers/leds/leds-mlxcpld.c b/drivers/leds/leds-mlxcpld.c index 1355c84a2919..93526857e766 100644 --- a/drivers/leds/leds-mlxcpld.c +++ b/drivers/leds/leds-mlxcpld.c @@ -131,7 +131,7 @@ static struct mlxcpld_led_profile mlxcpld_led_default_p= rofile[] =3D { "mlxcpld:fan1:green", }, { - 0x21, 0xf0, MLXCPLD_LED_RED_STATIC_ON, LED_OFF, + 0x21, 0xf0, MLXCPLD_LED_RED_STATIC_ON, 0, "mlxcpld:fan1:red", }, { @@ -139,7 +139,7 @@ static struct mlxcpld_led_profile mlxcpld_led_default_p= rofile[] =3D { "mlxcpld:fan2:green", }, { - 0x21, 0x0f, MLXCPLD_LED_RED_STATIC_ON, LED_OFF, + 0x21, 0x0f, MLXCPLD_LED_RED_STATIC_ON, 0, "mlxcpld:fan2:red", }, { @@ -147,7 +147,7 @@ static struct mlxcpld_led_profile mlxcpld_led_default_p= rofile[] =3D { "mlxcpld:fan3:green", }, { - 0x22, 0xf0, MLXCPLD_LED_RED_STATIC_ON, LED_OFF, + 0x22, 0xf0, MLXCPLD_LED_RED_STATIC_ON, 0, "mlxcpld:fan3:red", }, { @@ -155,7 +155,7 @@ static struct mlxcpld_led_profile mlxcpld_led_default_p= rofile[] =3D { "mlxcpld:fan4:green", }, { - 0x22, 0x0f, MLXCPLD_LED_RED_STATIC_ON, LED_OFF, + 0x22, 0x0f, MLXCPLD_LED_RED_STATIC_ON, 0, "mlxcpld:fan4:red", }, { @@ -163,7 +163,7 @@ static struct mlxcpld_led_profile mlxcpld_led_default_p= rofile[] =3D { "mlxcpld:psu:green", }, { - 0x20, 0x0f, MLXCPLD_LED_RED_STATIC_ON, LED_OFF, + 0x20, 0x0f, MLXCPLD_LED_RED_STATIC_ON, 0, "mlxcpld:psu:red", }, { @@ -171,7 +171,7 @@ static struct mlxcpld_led_profile mlxcpld_led_default_p= rofile[] =3D { "mlxcpld:status:green", }, { - 0x20, 0xf0, MLXCPLD_LED_RED_STATIC_ON, LED_OFF, + 0x20, 0xf0, MLXCPLD_LED_RED_STATIC_ON, 0, "mlxcpld:status:red", }, }; @@ -183,7 +183,7 @@ static struct mlxcpld_led_profile mlxcpld_led_msn2100_p= rofile[] =3D { "mlxcpld:fan:green", }, { - 0x21, 0xf0, MLXCPLD_LED_RED_STATIC_ON, LED_OFF, + 0x21, 0xf0, MLXCPLD_LED_RED_STATIC_ON, 0, "mlxcpld:fan:red", }, { @@ -191,7 +191,7 @@ static struct mlxcpld_led_profile mlxcpld_led_msn2100_p= rofile[] =3D { "mlxcpld:psu1:green", }, { - 0x23, 0xf0, MLXCPLD_LED_RED_STATIC_ON, LED_OFF, + 0x23, 0xf0, MLXCPLD_LED_RED_STATIC_ON, 0, "mlxcpld:psu1:red", }, { @@ -199,7 +199,7 @@ static struct mlxcpld_led_profile mlxcpld_led_msn2100_p= rofile[] =3D { "mlxcpld:psu2:green", }, { - 0x23, 0x0f, MLXCPLD_LED_RED_STATIC_ON, LED_OFF, + 0x23, 0x0f, MLXCPLD_LED_RED_STATIC_ON, 0, "mlxcpld:psu2:red", }, { @@ -207,11 +207,11 @@ static struct mlxcpld_led_profile mlxcpld_led_msn2100= _profile[] =3D { "mlxcpld:status:green", }, { - 0x20, 0xf0, MLXCPLD_LED_RED_STATIC_ON, LED_OFF, + 0x20, 0xf0, MLXCPLD_LED_RED_STATIC_ON, 0, "mlxcpld:status:red", }, { - 0x24, 0xf0, MLXCPLD_LED_GREEN_STATIC_ON, LED_OFF, + 0x24, 0xf0, MLXCPLD_LED_GREEN_STATIC_ON, 0, "mlxcpld:uid:blue", }, }; diff --git a/drivers/leds/leds-mlxreg.c b/drivers/leds/leds-mlxreg.c index b7855c93bd72..2340a205ce44 100644 --- a/drivers/leds/leds-mlxreg.c +++ b/drivers/leds/leds-mlxreg.c @@ -119,7 +119,7 @@ mlxreg_led_get_hw(struct mlxreg_led_data *led_data) dev_warn(led_data->led_cdev.dev, "Failed to get current brightness, erro= r: %d\n", err); /* Assume the LED is OFF */ - return LED_OFF; + return 0; } =20 regval =3D regval & ~data->mask; @@ -220,20 +220,20 @@ static int mlxreg_led_config(struct mlxreg_led_priv_d= ata *priv) led_data->data_parent =3D priv; if (strstr(data->label, "red") || strstr(data->label, "orange")) { - brightness =3D LED_OFF; + brightness =3D 0; led_data->base_color =3D MLXREG_LED_RED_SOLID; } else if (strstr(data->label, "amber")) { - brightness =3D LED_OFF; + brightness =3D 0; led_data->base_color =3D MLXREG_LED_AMBER_SOLID; } else { - brightness =3D LED_OFF; + brightness =3D 0; led_data->base_color =3D MLXREG_LED_GREEN_SOLID; } snprintf(led_data->led_cdev_name, sizeof(led_data->led_cdev_name), "mlxreg:%s", data->label); led_cdev->name =3D led_data->led_cdev_name; led_cdev->brightness =3D brightness; - led_cdev->max_brightness =3D LED_ON; + led_cdev->max_brightness =3D 1; led_cdev->brightness_set_blocking =3D mlxreg_led_brightness_set; led_cdev->brightness_get =3D mlxreg_led_brightness_get; diff --git a/drivers/leds/leds-mt6323.c b/drivers/leds/leds-mt6323.c index f59e0e8bda8b..cbefd78f2d49 100644 --- a/drivers/leds/leds-mt6323.c +++ b/drivers/leds/leds-mt6323.c @@ -354,7 +354,7 @@ static int mt6323_led_set_dt_default(struct led_classde= v *cdev, ret =3D mt6323_led_set_brightness(cdev, cdev->max_brightness); } else { - ret =3D mt6323_led_set_brightness(cdev, LED_OFF); + ret =3D mt6323_led_set_brightness(cdev, 0); } } =20 diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c index 77213b79f84d..8ffbe5e19952 100644 --- a/drivers/leds/leds-netxbig.c +++ b/drivers/leds/leds-netxbig.c @@ -177,7 +177,7 @@ static void netxbig_led_set(struct led_classdev *led_cd= ev, =20 spin_lock_irqsave(&led_dat->lock, flags); =20 - if (value =3D=3D LED_OFF) { + if (value =3D=3D 0) { mode =3D NETXBIG_LED_OFF; set_brightness =3D 0; } else { @@ -295,7 +295,7 @@ static int create_netxbig_led(struct platform_device *p= dev, * the whole boot process (bootloader+linux). */ led_dat->sata =3D 0; - led_dat->cdev.brightness =3D LED_OFF; + led_dat->cdev.brightness =3D 0; led_dat->cdev.max_brightness =3D template->bright_max; led_dat->cdev.flags |=3D LED_CORE_SUSPENDRESUME; led_dat->mode_addr =3D template->mode_addr; diff --git a/drivers/leds/leds-nic78bx.c b/drivers/leds/leds-nic78bx.c index f196f52eec1e..25639c40975c 100644 --- a/drivers/leds/leds-nic78bx.c +++ b/drivers/leds/leds-nic78bx.c @@ -72,7 +72,7 @@ static enum led_brightness nic78bx_brightness_get(struct = led_classdev *cdev) value =3D inb(nled->data->io_base); spin_unlock_irqrestore(&nled->data->lock, flags); =20 - return (value & nled->bit) ? 1 : LED_OFF; + return (value & nled->bit) ? 1 : 0; } =20 static struct nic78bx_led nic78bx_leds[] =3D { diff --git a/drivers/leds/leds-ns2.c b/drivers/leds/leds-ns2.c index 1677d66d8b0e..34e899adfc0d 100644 --- a/drivers/leds/leds-ns2.c +++ b/drivers/leds/leds-ns2.c @@ -106,7 +106,7 @@ static void ns2_led_set(struct led_classdev *led_cdev, struct ns2_led *led =3D container_of(led_cdev, struct ns2_led, cdev); enum ns2_led_modes mode; =20 - if (value =3D=3D LED_OFF) + if (value =3D=3D 0) mode =3D NS_V2_LED_OFF; else if (led->sata) mode =3D NS_V2_LED_SATA; @@ -224,7 +224,7 @@ static int ns2_led_register(struct device *dev, struct = fwnode_handle *node, =20 /* Set LED initial state. */ led->sata =3D (mode =3D=3D NS_V2_LED_SATA) ? 1 : 0; - led->cdev.brightness =3D (mode =3D=3D NS_V2_LED_OFF) ? LED_OFF : LED_FULL; + led->cdev.brightness =3D (mode =3D=3D NS_V2_LED_OFF) ? 0 : 255; =20 init_data.fwnode =3D node; =20 diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c index 12af1127d9b7..693fbfeced6c 100644 --- a/drivers/leds/leds-ot200.c +++ b/drivers/leds/leds-ot200.c @@ -105,7 +105,7 @@ static void ot200_led_brightness_set(struct led_classde= v *led_cdev, else BUG(); =20 - if (value =3D=3D LED_OFF) + if (value =3D=3D 0) *val &=3D ~led->mask; else *val |=3D led->mask; diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c index 017794bb87ae..3e14a61e9807 100644 --- a/drivers/leds/leds-pca9532.c +++ b/drivers/leds/leds-pca9532.c @@ -177,9 +177,9 @@ static int pca9532_set_brightness(struct led_classdev *= led_cdev, int err =3D 0; struct pca9532_led *led =3D ldev_to_led(led_cdev); =20 - if (value =3D=3D LED_OFF) + if (value =3D=3D 0) led->state =3D PCA9532_OFF; - else if (value =3D=3D LED_FULL) + else if (value =3D=3D 255) led->state =3D PCA9532_ON; else { led->state =3D PCA9532_PWM0; /* Thecus: hardcode one pwm */ @@ -386,7 +386,7 @@ static int pca9532_configure(struct i2c_client *client, led->name =3D pled->name; led->ldev.name =3D led->name; led->ldev.default_trigger =3D pled->default_trigger; - led->ldev.brightness =3D LED_OFF; + led->ldev.brightness =3D 0; led->ldev.brightness_set_blocking =3D pca9532_set_brightness; led->ldev.blink_set =3D pca9532_set_blink; diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c index a6b5699aeae4..2230d3f0e846 100644 --- a/drivers/leds/leds-pca955x.c +++ b/drivers/leds/leds-pca955x.c @@ -57,9 +57,9 @@ #define PCA955X_LS_BLINK0 0x2 /* Blink at PWM0 rate */ #define PCA955X_LS_BLINK1 0x3 /* Blink at PWM1 rate */ =20 -#define PCA955X_GPIO_INPUT LED_OFF -#define PCA955X_GPIO_HIGH LED_OFF -#define PCA955X_GPIO_LOW LED_FULL +#define PCA955X_GPIO_INPUT 0 +#define PCA955X_GPIO_HIGH 0 +#define PCA955X_GPIO_LOW 255 =20 enum pca955x_type { pca9550, @@ -265,13 +265,13 @@ static enum led_brightness pca955x_led_get(struct led= _classdev *led_cdev) ls =3D (ls >> ((pca955x_led->led_num % 4) << 1)) & 0x3; switch (ls) { case PCA955X_LS_LED_ON: - ret =3D LED_FULL; + ret =3D 255; break; case PCA955X_LS_LED_OFF: - ret =3D LED_OFF; + ret =3D 0; break; case PCA955X_LS_BLINK0: - ret =3D LED_HALF; + ret =3D 127; break; case PCA955X_LS_BLINK1: ret =3D pca955x_read_pwm(pca955x->client, 1, &pwm); @@ -307,13 +307,13 @@ static int pca955x_led_set(struct led_classdev *led_c= dev, goto out; =20 switch (value) { - case LED_FULL: + case 255: ls =3D pca955x_ledsel(ls, ls_led, PCA955X_LS_LED_ON); break; - case LED_OFF: + case 0: ls =3D pca955x_ledsel(ls, ls_led, PCA955X_LS_LED_OFF); break; - case LED_HALF: + case 127: ls =3D pca955x_ledsel(ls, ls_led, PCA955X_LS_BLINK0); break; default: @@ -578,12 +578,12 @@ static int pca955x_probe(struct i2c_client *client) =20 if (pdata->leds[i].default_state =3D=3D LEDS_GPIO_DEFSTATE_OFF) { - err =3D pca955x_led_set(led, LED_OFF); + err =3D pca955x_led_set(led, 0); if (err) return err; } else if (pdata->leds[i].default_state =3D=3D LEDS_GPIO_DEFSTATE_ON) { - err =3D pca955x_led_set(led, LED_FULL); + err =3D pca955x_led_set(led, 255); if (err) return err; } @@ -621,16 +621,16 @@ static int pca955x_probe(struct i2c_client *client) */ if (pdata->leds[i].default_state =3D=3D LEDS_GPIO_DEFSTATE_KEEP) { - if (led->brightness !=3D LED_FULL && - led->brightness !=3D LED_OFF && - led->brightness !=3D LED_HALF) + if (led->brightness !=3D 255 && + led->brightness !=3D 0 && + led->brightness !=3D 127) keep_pwm =3D true; } } } =20 /* PWM0 is used for half brightness or 50% duty cycle */ - err =3D pca955x_write_pwm(client, 0, 255 - LED_HALF); + err =3D pca955x_write_pwm(client, 0, 255 - 127); if (err) return err; =20 diff --git a/drivers/leds/leds-pca963x.c b/drivers/leds/leds-pca963x.c index 00aecd67e348..17612f5021b9 100644 --- a/drivers/leds/leds-pca963x.c +++ b/drivers/leds/leds-pca963x.c @@ -128,11 +128,11 @@ static int pca963x_brightness(struct pca963x_led *led, ledout =3D i2c_smbus_read_byte_data(client, ledout_addr); =20 switch (brightness) { - case LED_FULL: + case 255: val =3D (ledout & ~mask) | (PCA963X_LED_ON << shift); ret =3D i2c_smbus_write_byte_data(client, ledout_addr, val); break; - case LED_OFF: + case 0: val =3D ledout & ~mask; ret =3D i2c_smbus_write_byte_data(client, ledout_addr, val); break; diff --git a/drivers/leds/leds-pm8058.c b/drivers/leds/leds-pm8058.c index fb2ab72c0c40..535b471a634a 100644 --- a/drivers/leds/leds-pm8058.c +++ b/drivers/leds/leds-pm8058.c @@ -64,7 +64,7 @@ static enum led_brightness pm8058_led_get(struct led_clas= sdev *cled) ret =3D regmap_read(led->map, led->reg, &val); if (ret) { pr_err("Failed to get LED brightness\n"); - return LED_OFF; + return 0; } =20 switch (led->ledtype) { @@ -78,7 +78,7 @@ static enum led_brightness pm8058_led_get(struct led_clas= sdev *cled) val >>=3D PM8058_LED_TYPE_KEYPAD_SHIFT; break; default: - val =3D LED_OFF; + val =3D 0; break; } =20 @@ -133,8 +133,8 @@ static int pm8058_led_probe(struct platform_device *pde= v) led->cdev.brightness =3D maxbright; pm8058_led_set(&led->cdev, maxbright); } else { - led->cdev.brightness =3D LED_OFF; - pm8058_led_set(&led->cdev, LED_OFF); + led->cdev.brightness =3D 0; + pm8058_led_set(&led->cdev, 0); } } =20 diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c index 743e2cdd0891..9ee3ad46a82c 100644 --- a/drivers/leds/leds-powernv.c +++ b/drivers/leds/leds-powernv.c @@ -146,7 +146,7 @@ static enum led_brightness powernv_led_get(struct power= nv_led_data *powernv_led) if (rc !=3D OPAL_SUCCESS && rc !=3D OPAL_PARTIAL) { dev_err(dev, "%s: OPAL get led call failed [rc=3D%d]\n", __func__, rc); - return LED_OFF; + return 0; } =20 led_mask =3D be64_to_cpu(mask); @@ -156,14 +156,14 @@ static enum led_brightness powernv_led_get(struct pow= ernv_led_data *powernv_led) if (!((led_mask >> powernv_led->led_type) & OPAL_SLOT_LED_STATE_ON)) { dev_err(dev, "%s: LED status not available for %s\n", __func__, powernv_led->cdev.name); - return LED_OFF; + return 0; } =20 /* LED status value */ if ((led_value >> powernv_led->led_type) & OPAL_SLOT_LED_STATE_ON) - return LED_FULL; + return 255; =20 - return LED_OFF; + return 0; } =20 /* @@ -225,8 +225,8 @@ static int powernv_led_create(struct device *dev, =20 powernv_led->cdev.brightness_set_blocking =3D powernv_brightness_set; powernv_led->cdev.brightness_get =3D powernv_brightness_get; - powernv_led->cdev.brightness =3D LED_OFF; - powernv_led->cdev.max_brightness =3D LED_FULL; + powernv_led->cdev.brightness =3D 0; + powernv_led->cdev.max_brightness =3D 255; =20 /* Register the classdev */ rc =3D devm_led_classdev_register(dev, &powernv_led->cdev); diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c index 6832180c1c54..50e97e70051a 100644 --- a/drivers/leds/leds-pwm.c +++ b/drivers/leds/leds-pwm.c @@ -67,7 +67,7 @@ static int led_pwm_add(struct device *dev, struct led_pwm= _priv *priv, =20 led_data->active_low =3D led->active_low; led_data->cdev.name =3D led->name; - led_data->cdev.brightness =3D LED_OFF; + led_data->cdev.brightness =3D 0; led_data->cdev.max_brightness =3D led->max_brightness; led_data->cdev.flags =3D LED_CORE_SUSPENDRESUME; =20 diff --git a/drivers/leds/leds-rb532.c b/drivers/leds/leds-rb532.c index b6447c1721b4..350418795353 100644 --- a/drivers/leds/leds-rb532.c +++ b/drivers/leds/leds-rb532.c @@ -27,7 +27,7 @@ static void rb532_led_set(struct led_classdev *cdev, =20 static enum led_brightness rb532_led_get(struct led_classdev *cdev) { - return (get_latch_u5() & LO_ULED) ? LED_FULL : LED_OFF; + return (get_latch_u5() & LO_ULED) ? 255 : 0; } =20 static struct led_classdev rb532_uled =3D { diff --git a/drivers/leds/leds-regulator.c b/drivers/leds/leds-regulator.c index 208c98918433..c99460ac1d3c 100644 --- a/drivers/leds/leds-regulator.c +++ b/drivers/leds/leds-regulator.c @@ -96,7 +96,7 @@ static int regulator_led_brightness_set(struct led_classd= ev *led_cdev, =20 mutex_lock(&led->mutex); =20 - if (value =3D=3D LED_OFF) { + if (value =3D=3D 0) { regulator_led_disable(led); goto out; } diff --git a/drivers/leds/leds-sc27xx-bltc.c b/drivers/leds/leds-sc27xx-blt= c.c index e199ea15e406..e7c105e45a81 100644 --- a/drivers/leds/leds-sc27xx-bltc.c +++ b/drivers/leds/leds-sc27xx-bltc.c @@ -114,14 +114,14 @@ static int sc27xx_led_disable(struct sc27xx_led *leds) (SC27XX_LED_RUN | SC27XX_LED_TYPE) << ctrl_shift, 0); } =20 -static int sc27xx_led_set(struct led_classdev *ldev, enum led_brightness v= alue) +static int sc27xx_led_set(struct led_classdev *ldev, unsigned int value) { struct sc27xx_led *leds =3D to_sc27xx_led(ldev); int err; =20 mutex_lock(&leds->priv->lock); =20 - if (value =3D=3D LED_OFF) + if (value =3D=3D 0) err =3D sc27xx_led_disable(leds); else err =3D sc27xx_led_enable(leds, value); @@ -161,7 +161,7 @@ static int sc27xx_led_pattern_clear(struct led_classdev= *ldev) err =3D regmap_update_bits(regmap, ctrl_base, (SC27XX_LED_RUN | SC27XX_LED_TYPE) << ctrl_shift, 0); =20 - ldev->brightness =3D LED_OFF; + ldev->brightness =3D 0; =20 mutex_unlock(&leds->priv->lock); =20 diff --git a/drivers/leds/leds-spi-byte.c b/drivers/leds/leds-spi-byte.c index f1964c96fb15..e96fc874c0f4 100644 --- a/drivers/leds/leds-spi-byte.c +++ b/drivers/leds/leds-spi-byte.c @@ -103,7 +103,7 @@ static int spi_byte_probe(struct spi_device *spi) mutex_init(&led->mutex); led->cdef =3D device_get_match_data(dev); led->ldev.name =3D led->name; - led->ldev.brightness =3D LED_OFF; + led->ldev.brightness =3D 0; led->ldev.max_brightness =3D led->cdef->max_value - led->cdef->off_value; led->ldev.brightness_set_blocking =3D spi_byte_brightness_set_blocking; =20 diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c index fcaa34706b6c..08cbe2ba5417 100644 --- a/drivers/leds/leds-ss4200.c +++ b/drivers/leds/leds-ss4200.c @@ -220,7 +220,7 @@ static void nasgpio_led_set_brightness(struct led_class= dev *led_cdev, enum led_brightness brightness) { u32 setting =3D 0; - if (brightness >=3D LED_HALF) + if (brightness >=3D 127) setting =3D 1; /* * Hold the lock across both operations. This ensures @@ -433,12 +433,12 @@ static void set_power_light_amber_noblink(void) if (!amber || !blue) return; /* - * LED_OFF implies disabling future blinking + * 0 implies disabling future blinking */ pr_debug("setting blue off and amber on\n"); =20 - nasgpio_led_set_brightness(&blue->led_cdev, LED_OFF); - nasgpio_led_set_brightness(&amber->led_cdev, LED_FULL); + nasgpio_led_set_brightness(&blue->led_cdev, 0); + nasgpio_led_set_brightness(&amber->led_cdev, 255); } =20 static ssize_t blink_show(struct device *dev, @@ -482,9 +482,9 @@ static int register_nasgpio_led(int led_nr) struct led_classdev *led =3D get_classdev_for_led_nr(led_nr); =20 led->name =3D nas_led->name; - led->brightness =3D LED_OFF; + led->brightness =3D 0; if (nasgpio_led_get_attr(led, GP_LVL)) - led->brightness =3D LED_FULL; + led->brightness =3D 255; led->brightness_set =3D nasgpio_led_set_brightness; led->blink_set =3D nasgpio_led_set_blink; led->groups =3D nasgpio_led_groups; diff --git a/drivers/leds/leds-sunfire.c b/drivers/leds/leds-sunfire.c index eba7313719bf..f9e42661d02a 100644 --- a/drivers/leds/leds-sunfire.c +++ b/drivers/leds/leds-sunfire.c @@ -144,7 +144,7 @@ static int sunfire_led_generic_probe(struct platform_de= vice *pdev, =20 p->leds[i].reg =3D (void __iomem *) pdev->resource[0].start; lp->name =3D types[i].name; - lp->brightness =3D LED_FULL; + lp->brightness =3D 255; lp->brightness_set =3D types[i].handler; lp->default_trigger =3D types[i].default_trigger; =20 diff --git a/drivers/leds/leds-syscon.c b/drivers/leds/leds-syscon.c index 7eddb8ecb44e..1533b39e22ec 100644 --- a/drivers/leds/leds-syscon.c +++ b/drivers/leds/leds-syscon.c @@ -40,7 +40,7 @@ static void syscon_led_set(struct led_classdev *led_cdev, u32 val; int ret; =20 - if (value =3D=3D LED_OFF) { + if (value =3D=3D 0) { val =3D 0; sled->state =3D false; } else { diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c index 1473ced8664c..e40d659b6119 100644 --- a/drivers/leds/leds-tca6507.c +++ b/drivers/leds/leds-tca6507.c @@ -423,7 +423,7 @@ static int led_prepare(struct tca6507_led *led) if (best =3D=3D -1) { /* Best brightness is full-on */ set_select(tca, led->num, TCA6507_LS_LED_ON); - led->led_cdev.brightness =3D LED_FULL; + led->led_cdev.brightness =3D 255; return 0; } =20 @@ -577,12 +577,12 @@ static int tca6507_blink_set(struct led_classdev *led= _cdev, if (led->offtime =3D=3D 0) led->offtime =3D 512; =20 - if (led->led_cdev.brightness =3D=3D LED_OFF) - led->led_cdev.brightness =3D LED_FULL; + if (led->led_cdev.brightness =3D=3D 0) + led->led_cdev.brightness =3D 255; if (led_assign(led) < 0) { led->ontime =3D 0; led->offtime =3D 0; - led->led_cdev.brightness =3D LED_OFF; + led->led_cdev.brightness =3D 0; return -EINVAL; } *delay_on =3D led->ontime; diff --git a/drivers/leds/leds-wm831x-status.c b/drivers/leds/leds-wm831x-s= tatus.c index c48b80574f02..37328c0c00b1 100644 --- a/drivers/leds/leds-wm831x-status.c +++ b/drivers/leds/leds-wm831x-status.c @@ -52,7 +52,7 @@ static void wm831x_status_set(struct wm831x_status *led) led->reg_val |=3D led->blink_time << WM831X_LED_DUR_SHIFT; led->reg_val |=3D led->blink_cyc; } else { - if (led->brightness !=3D LED_OFF) + if (led->brightness !=3D 0) led->reg_val |=3D 1 << WM831X_LED_MODE_SHIFT; } =20 @@ -71,7 +71,7 @@ static int wm831x_status_brightness_set(struct led_classd= ev *led_cdev, =20 spin_lock_irqsave(&led->value_lock, flags); led->brightness =3D value; - if (value =3D=3D LED_OFF) + if (value =3D=3D 0) led->blink =3D 0; spin_unlock_irqrestore(&led->value_lock, flags); wm831x_status_set(led); @@ -248,9 +248,9 @@ static int wm831x_status_probe(struct platform_device *= pdev) drvdata->reg_val =3D wm831x_reg_read(wm831x, drvdata->reg); =20 if (drvdata->reg_val & WM831X_LED_MODE_MASK) - drvdata->brightness =3D LED_FULL; + drvdata->brightness =3D 255; else - drvdata->brightness =3D LED_OFF; + drvdata->brightness =3D 0; =20 /* Set a default source if configured, otherwise leave the * current hardware setting. diff --git a/drivers/leds/leds-wm8350.c b/drivers/leds/leds-wm8350.c index 8f243c413723..512bbc266258 100644 --- a/drivers/leds/leds-wm8350.c +++ b/drivers/leds/leds-wm8350.c @@ -150,7 +150,7 @@ static int wm8350_led_set(struct led_classdev *led_cdev, =20 spin_lock_irqsave(&led->value_lock, flags); =20 - if (led->value =3D=3D LED_OFF) { + if (led->value =3D=3D 0) { spin_unlock_irqrestore(&led->value_lock, flags); return wm8350_led_disable(led); } @@ -160,7 +160,7 @@ static int wm8350_led_set(struct led_classdev *led_cdev, * brightness due to the non-linear current settings provided * by the hardware. */ - uA =3D (led->max_uA_index * led->value) / LED_FULL; + uA =3D (led->max_uA_index * led->value) / 255; spin_unlock_irqrestore(&led->value_lock, flags); BUG_ON(uA >=3D ARRAY_SIZE(isink_cur)); =20 @@ -179,7 +179,7 @@ static void wm8350_led_shutdown(struct platform_device = *pdev) { struct wm8350_led *led =3D platform_get_drvdata(pdev); =20 - led->value =3D LED_OFF; + led->value =3D 0; wm8350_led_disable(led); } =20 @@ -236,7 +236,7 @@ static int wm8350_led_probe(struct platform_device *pde= v) pdata->max_uA); =20 spin_lock_init(&led->value_lock); - led->value =3D LED_OFF; + led->value =3D 0; platform_set_drvdata(pdev, led); =20 return led_classdev_register(&pdev->dev, &led->cdev); diff --git a/drivers/leds/simple/simatic-ipc-leds.c b/drivers/leds/simple/s= imatic-ipc-leds.c index ff2c96e73241..be5d7e1e4145 100644 --- a/drivers/leds/simple/simatic-ipc-leds.c +++ b/drivers/leds/simple/simatic-ipc-leds.c @@ -73,7 +73,7 @@ static void simatic_ipc_led_set_io(struct led_classdev *l= ed_cd, spin_lock_irqsave(®_lock, flags); =20 val =3D inw(SIMATIC_IPC_LED_PORT_BASE); - if (brightness =3D=3D LED_OFF) + if (brightness =3D=3D 0) outw(val | led->value, SIMATIC_IPC_LED_PORT_BASE); else outw(val & ~led->value, SIMATIC_IPC_LED_PORT_BASE); @@ -85,7 +85,7 @@ static enum led_brightness simatic_ipc_led_get_io(struct = led_classdev *led_cd) { struct simatic_ipc_led *led =3D cdev_to_led(led_cd); =20 - return inw(SIMATIC_IPC_LED_PORT_BASE) & led->value ? LED_OFF : led_cd->ma= x_brightness; + return inw(SIMATIC_IPC_LED_PORT_BASE) & led->value ? 0 : led_cd->max_brig= htness; } =20 static void simatic_ipc_led_set_mem(struct led_classdev *led_cd, @@ -96,7 +96,7 @@ static void simatic_ipc_led_set_mem(struct led_classdev *= led_cd, u32 *p; =20 p =3D simatic_ipc_led_memory + led->value; - *p =3D (*p & ~1) | (brightness =3D=3D LED_OFF); + *p =3D (*p & ~1) | (brightness =3D=3D 0); } =20 static enum led_brightness simatic_ipc_led_get_mem(struct led_classdev *le= d_cd) @@ -106,7 +106,7 @@ static enum led_brightness simatic_ipc_led_get_mem(stru= ct led_classdev *led_cd) u32 *p; =20 p =3D simatic_ipc_led_memory + led->value; - return (*p & 1) ? LED_OFF : led_cd->max_brightness; + return (*p & 1) ? 0 : led_cd->max_brightness; } =20 static int simatic_ipc_leds_probe(struct platform_device *pdev) @@ -176,7 +176,7 @@ static int simatic_ipc_leds_probe(struct platform_devic= e *pdev) cdev->brightness_set =3D simatic_ipc_led_set_io; cdev->brightness_get =3D simatic_ipc_led_get_io; } - cdev->max_brightness =3D LED_ON; + cdev->max_brightness =3D 1; cdev->name =3D ipcled->name; =20 err =3D devm_led_classdev_register(dev, cdev); diff --git a/drivers/leds/trigger/ledtrig-activity.c b/drivers/leds/trigger= /ledtrig-activity.c index 30bc9df03636..d0d8cc8db8c6 100644 --- a/drivers/leds/trigger/ledtrig-activity.c +++ b/drivers/leds/trigger/ledtrig-activity.c @@ -129,7 +129,7 @@ static void led_activity_function(struct timer_list *t) activity_data->state =3D !activity_data->state; led_set_brightness_nosleep(led_cdev, (activity_data->state ^ activity_data->invert) ? - led_cdev->blink_brightness : LED_OFF); + led_cdev->blink_brightness : 0); } =20 target =3D (cpus > 1) ? (100 / cpus) : 50; diff --git a/drivers/leds/trigger/ledtrig-backlight.c b/drivers/leds/trigge= r/ledtrig-backlight.c index 487577d22cfc..ec965e192365 100644 --- a/drivers/leds/trigger/ledtrig-backlight.c +++ b/drivers/leds/trigger/ledtrig-backlight.c @@ -47,7 +47,7 @@ static int fb_notifier_callback(struct notifier_block *p, =20 if ((n->old_status =3D=3D UNBLANK) ^ n->invert) { n->brightness =3D led->brightness; - led_set_brightness_nosleep(led, LED_OFF); + led_set_brightness_nosleep(led, 0); } else { led_set_brightness_nosleep(led, n->brightness); } @@ -84,7 +84,7 @@ static ssize_t bl_trig_invert_store(struct device *dev, =20 /* After inverting, we need to update the LED. */ if ((n->old_status =3D=3D BLANK) ^ n->invert) - led_set_brightness_nosleep(led, LED_OFF); + led_set_brightness_nosleep(led, 0); else led_set_brightness_nosleep(led, n->brightness); =20 diff --git a/drivers/leds/trigger/ledtrig-camera.c b/drivers/leds/trigger/l= edtrig-camera.c index ab1c410872ff..1c9707c60a19 100644 --- a/drivers/leds/trigger/ledtrig-camera.c +++ b/drivers/leds/trigger/ledtrig-camera.c @@ -19,7 +19,7 @@ DEFINE_LED_TRIGGER(ledtrig_torch); =20 void ledtrig_flash_ctrl(bool on) { - enum led_brightness brt =3D on ? LED_FULL : LED_OFF; + unsigned int brt =3D on ? 255 : 0; =20 led_trigger_event(ledtrig_flash, brt); } @@ -27,7 +27,7 @@ EXPORT_SYMBOL_GPL(ledtrig_flash_ctrl); =20 void ledtrig_torch_ctrl(bool on) { - enum led_brightness brt =3D on ? LED_FULL : LED_OFF; + unsigned int brt =3D on ? 255 : 0; =20 led_trigger_event(ledtrig_torch, brt); } diff --git a/drivers/leds/trigger/ledtrig-cpu.c b/drivers/leds/trigger/ledt= rig-cpu.c index 8af4f9bb9cde..a7d358412f8a 100644 --- a/drivers/leds/trigger/ledtrig-cpu.c +++ b/drivers/leds/trigger/ledtrig-cpu.c @@ -84,11 +84,11 @@ void ledtrig_cpu(enum cpu_led_event ledevt) total_cpus =3D num_present_cpus(); =20 led_trigger_event(trig->_trig, - is_active ? LED_FULL : LED_OFF); + is_active ? 255 : 0); =20 =20 led_trigger_event(trig_cpu_all, - DIV_ROUND_UP(LED_FULL * active_cpus, total_cpus)); + DIV_ROUND_UP(255 * active_cpus, total_cpus)); =20 } } diff --git a/drivers/leds/trigger/ledtrig-gpio.c b/drivers/leds/trigger/led= trig-gpio.c index 0120faa3dafa..d794e44f2eff 100644 --- a/drivers/leds/trigger/ledtrig-gpio.c +++ b/drivers/leds/trigger/ledtrig-gpio.c @@ -37,9 +37,9 @@ static irqreturn_t gpio_trig_irq(int irq, void *_led) led_set_brightness_nosleep(gpio_data->led, gpio_data->desired_brightness); else - led_set_brightness_nosleep(gpio_data->led, LED_FULL); + led_set_brightness_nosleep(gpio_data->led, 255); } else { - led_set_brightness_nosleep(gpio_data->led, LED_OFF); + led_set_brightness_nosleep(gpio_data->led, 0); } =20 return IRQ_HANDLED; diff --git a/drivers/leds/trigger/ledtrig-heartbeat.c b/drivers/leds/trigge= r/ledtrig-heartbeat.c index 7fe0a05574d2..0b5ec7dc14fa 100644 --- a/drivers/leds/trigger/ledtrig-heartbeat.c +++ b/drivers/leds/trigger/ledtrig-heartbeat.c @@ -35,13 +35,13 @@ static void led_heartbeat_function(struct timer_list *t) struct heartbeat_trig_data *heartbeat_data =3D from_timer(heartbeat_data, t, timer); struct led_classdev *led_cdev; - unsigned long brightness =3D LED_OFF; + unsigned long brightness =3D 0; unsigned long delay =3D 0; =20 led_cdev =3D heartbeat_data->led_cdev; =20 if (unlikely(panic_heartbeats)) { - led_set_brightness_nosleep(led_cdev, LED_OFF); + led_set_brightness_nosleep(led_cdev, 0); return; } =20 diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/l= edtrig-netdev.c index d5e774d83021..e3174d09111c 100644 --- a/drivers/leds/trigger/ledtrig-netdev.c +++ b/drivers/leds/trigger/ledtrig-netdev.c @@ -74,13 +74,13 @@ static void set_baseline_state(struct led_netdev_data *= trigger_data) led_cdev->blink_brightness =3D led_cdev->max_brightness; =20 if (!test_bit(NETDEV_LED_MODE_LINKUP, &trigger_data->mode)) - led_set_brightness(led_cdev, LED_OFF); + led_set_brightness(led_cdev, 0); else { if (test_bit(NETDEV_LED_LINK, &trigger_data->mode)) led_set_brightness(led_cdev, led_cdev->blink_brightness); else - led_set_brightness(led_cdev, LED_OFF); + led_set_brightness(led_cdev, 0); =20 /* If we are looking for RX/TX start periodically * checking stats @@ -355,7 +355,7 @@ static void netdev_trig_work(struct work_struct *work) =20 /* If we dont have a device, insure we are off */ if (!trigger_data->net_dev) { - led_set_brightness(trigger_data->led_cdev, LED_OFF); + led_set_brightness(trigger_data->led_cdev, 0); return; } =20 diff --git a/drivers/leds/trigger/ledtrig-oneshot.c b/drivers/leds/trigger/= ledtrig-oneshot.c index bee3bd452abf..bc5ff2d2fd6c 100644 --- a/drivers/leds/trigger/ledtrig-oneshot.c +++ b/drivers/leds/trigger/ledtrig-oneshot.c @@ -58,9 +58,9 @@ static ssize_t led_invert_store(struct device *dev, oneshot_data->invert =3D !!state; =20 if (oneshot_data->invert) - led_set_brightness_nosleep(led_cdev, LED_FULL); + led_set_brightness_nosleep(led_cdev, 255); else - led_set_brightness_nosleep(led_cdev, LED_OFF); + led_set_brightness_nosleep(led_cdev, 0); =20 return size; } @@ -184,7 +184,7 @@ static void oneshot_trig_deactivate(struct led_classdev= *led_cdev) kfree(oneshot_data); =20 /* Stop blinking */ - led_set_brightness(led_cdev, LED_OFF); + led_set_brightness(led_cdev, 0); } =20 static struct led_trigger oneshot_led_trigger =3D { diff --git a/drivers/leds/trigger/ledtrig-panic.c b/drivers/leds/trigger/le= dtrig-panic.c index 64abf2e91608..2576632d2264 100644 --- a/drivers/leds/trigger/ledtrig-panic.c +++ b/drivers/leds/trigger/ledtrig-panic.c @@ -58,7 +58,7 @@ static struct notifier_block led_trigger_panic_nb =3D { =20 static long led_panic_blink(int state) { - led_trigger_event(trigger, state ? LED_FULL : LED_OFF); + led_trigger_event(trigger, state ? 255 : 0); return 0; } =20 diff --git a/drivers/leds/trigger/ledtrig-pattern.c b/drivers/leds/trigger/= ledtrig-pattern.c index 43a265dc4696..d49e45395aca 100644 --- a/drivers/leds/trigger/ledtrig-pattern.c +++ b/drivers/leds/trigger/ledtrig-pattern.c @@ -432,7 +432,7 @@ static void pattern_trig_deactivate(struct led_classdev= *led_cdev) =20 del_timer_sync(&data->timer); =20 - led_set_brightness(led_cdev, LED_OFF); + led_set_brightness(led_cdev, 0); kfree(data); led_cdev->activated =3D false; } diff --git a/drivers/leds/trigger/ledtrig-timer.c b/drivers/leds/trigger/le= dtrig-timer.c index b4688d1d9d2b..cb2b4dcd4a2c 100644 --- a/drivers/leds/trigger/ledtrig-timer.c +++ b/drivers/leds/trigger/ledtrig-timer.c @@ -124,7 +124,7 @@ static int timer_trig_activate(struct led_classdev *led= _cdev) static void timer_trig_deactivate(struct led_classdev *led_cdev) { /* Stop blinking */ - led_set_brightness(led_cdev, LED_OFF); + led_set_brightness(led_cdev, 0); } =20 static struct led_trigger timer_led_trigger =3D { diff --git a/drivers/leds/trigger/ledtrig-transient.c b/drivers/leds/trigge= r/ledtrig-transient.c index 80635183fac8..b35ba2527346 100644 --- a/drivers/leds/trigger/ledtrig-transient.c +++ b/drivers/leds/trigger/ledtrig-transient.c @@ -79,7 +79,7 @@ static ssize_t transient_activate_store(struct device *de= v, transient_data->activate =3D state; led_set_brightness_nosleep(led_cdev, transient_data->state); transient_data->restore_state =3D - (transient_data->state =3D=3D LED_FULL) ? LED_OFF : LED_FULL; + (transient_data->state =3D=3D 255) ? 0 : 255; mod_timer(&transient_data->timer, jiffies + msecs_to_jiffies(transient_data->duration)); } @@ -123,7 +123,7 @@ static ssize_t transient_state_show(struct device *dev, led_trigger_get_drvdata(dev); int state; =20 - state =3D (transient_data->state =3D=3D LED_FULL) ? 1 : 0; + state =3D (transient_data->state =3D=3D 255) ? 1 : 0; return sprintf(buf, "%d\n", state); } =20 @@ -142,7 +142,7 @@ static ssize_t transient_state_store(struct device *dev, if (state !=3D 1 && state !=3D 0) return -EINVAL; =20 - transient_data->state =3D (state =3D=3D 1) ? LED_FULL : LED_OFF; + transient_data->state =3D (state =3D=3D 1) ? 255 : 0; return size; } =20 diff --git a/drivers/leds/trigger/ledtrig-tty.c b/drivers/leds/trigger/ledt= rig-tty.c index f62db7e520b5..378ccb7b12df 100644 --- a/drivers/leds/trigger/ledtrig-tty.c +++ b/drivers/leds/trigger/ledtrig-tty.c @@ -122,12 +122,12 @@ static void ledtrig_tty_work(struct work_struct *work) =20 if (icount.rx !=3D trigger_data->rx || icount.tx !=3D trigger_data->tx) { - led_set_brightness_sync(trigger_data->led_cdev, LED_ON); + led_set_brightness_sync(trigger_data->led_cdev, 1); =20 trigger_data->rx =3D icount.rx; trigger_data->tx =3D icount.tx; } else { - led_set_brightness_sync(trigger_data->led_cdev, LED_OFF); + led_set_brightness_sync(trigger_data->led_cdev, 0); } =20 out: --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 396A4C433F5 for ; Fri, 21 Jan 2022 16:55:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379803AbiAUQz2 (ORCPT ); Fri, 21 Jan 2022 11:55:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379776AbiAUQyy (ORCPT ); Fri, 21 Jan 2022 11:54:54 -0500 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC4F1C061747 for ; Fri, 21 Jan 2022 08:54:51 -0800 (PST) Received: by mail-ot1-x32e.google.com with SMTP id n22-20020a9d2016000000b0059bd79f7777so12085120ota.2 for ; Fri, 21 Jan 2022 08:54:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HVA0ZWgzizXSbtVSNUIGHlKEL+CetSwxidS0XXuLPDw=; b=lhqbeFLn6LGWwaXmjOPj025/8uD2u6ghPM19YiK6cJI0mhCqlepHSe+COo5qrpuYrj Sl6tQM2aeFiwynHCEpE3AmawxvDoNYa46HXASqlYacYo/jQwc673zhFfithjVFOpFXq4 wMa0NyFx/j25Ww4M4OL/nOUVvICnZ+Fk1posng1CxQ50V0w1A+I/ILNOAffBghZahGoA h8sg9o+LHpseXVWuqr9PKyzV/3hDbSpG2nLG2I2YSJk+g07XlsrvaurbNJYMGO3G37YW DjlvKNOAaIu0LDJVdA8MoxqUYd4NYzgYb/l9WBlYQWnYnu+5F+NGDNZRxUWtYq+HaI86 GLSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HVA0ZWgzizXSbtVSNUIGHlKEL+CetSwxidS0XXuLPDw=; b=xSY68OJ1Pg8v9EuluwEB8NRsL6Q0aFaAI7Rk7J+yUYOSbA/NF/R0ig9XxntsEFpg+U sGMn52NjvX06IuFNIkA8mCFQwRBW3JfzTdg0lNs5KEhOSbE/BHcpc30g47qq87bixJdp FpPYMyh0X/euZQnwKDWm9xd67yoeTf3kl4Ewmxd3kKgYPARXY+V7YGEIoiwefzTXlUQJ NwuwA4d0aQsF2MlU1O+ertusKTHhVa6kiXJSPggNGs6uamtfOYUZgU0gdNtieM8WS1ee ngQPO51n6jbi/+2IeKl4anCfzELrdAAxQUAhtCw7bG3r67ReZ7aIFbI3EeupZNcp0Ll2 s4Bw== X-Gm-Message-State: AOAM533fsDIPVEmakRuA38kXVZ7S8JKNRxjNRPnBYjPNri84+GIhFrGa bd3bHjA0uXW+FNmFm1lg6vFqndRJl/M= X-Google-Smtp-Source: ABdhPJzGe5RaMv9muOHI7TUblJz0zvxsC6HtZXqdKfF4KHj5o321mFmDbasyCgJoXNohCMLyfEp3ew== X-Received: by 2002:a9d:60b:: with SMTP id 11mr3320985otn.384.1642784091086; Fri, 21 Jan 2022 08:54:51 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.54.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:54:50 -0800 (PST) From: Luiz Sampaio To: Benjamin Herrenschmidt Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linuxppc-dev@lists.ozlabs.org Subject: [PATCH 09/31] macintosh: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:14 -0300 Message-Id: <20220121165436.30956-10-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/macintosh/via-pmu-led.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/macintosh/via-pmu-led.c b/drivers/macintosh/via-pmu-le= d.c index ae067ab2373d..b0a727ad0157 100644 --- a/drivers/macintosh/via-pmu-led.c +++ b/drivers/macintosh/via-pmu-led.c @@ -54,7 +54,7 @@ static void pmu_led_set(struct led_classdev *led_cdev, =20 spin_lock_irqsave(&pmu_blink_lock, flags); switch (brightness) { - case LED_OFF: + case 0: requested_change =3D 0; break; case LED_FULL: --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AC3EC433F5 for ; Fri, 21 Jan 2022 16:56:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379704AbiAUQ4Z (ORCPT ); Fri, 21 Jan 2022 11:56:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379753AbiAUQzE (ORCPT ); Fri, 21 Jan 2022 11:55:04 -0500 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54B6FC061748; Fri, 21 Jan 2022 08:54:54 -0800 (PST) Received: by mail-ot1-x333.google.com with SMTP id c3-20020a9d6c83000000b00590b9c8819aso12498612otr.6; Fri, 21 Jan 2022 08:54:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WfWZ8z/c/kEADyr83ZdSZ7HmhzMbcPfKaXMwZ33jf64=; b=QB83QpSASmCXMToFqXDtKMEQRhXoMgyyyCiWNfu8VEiMPRd4Lp9HrXXmUaY/bN+74s bwRWXUaMr6Tun1Bg7/dWpT3nmESJOGlHDjUU429H4HH9IX3RlADya7L78fr4ysnpuWsM ZEBdIDFB3pj9VFbTbxRv2TXP8PHt64lo88E+tTC8NK+Ipn7Hl8hk+EQGg94XKEVnESc8 q+8Wts7mftymr7j7CdzS/rb8N5J2S2hfUl0ld+m9a+yMmAo5IRYuApGKVhm0m6kgUCru zEPP+bxNr7W+1Wwz5QZkC3UfAXAPRvMmJIfAe4Iu2NCOkgF9IhT43yg480OIkrsY4U9q TQrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WfWZ8z/c/kEADyr83ZdSZ7HmhzMbcPfKaXMwZ33jf64=; b=i7FP1UeXc8gg+WI3l98bcM7H5Xa5ItoYafh2oA9uA26pSYBEalJQZAcsJwugHHhCok qfSyPixDOUhu5QckiI0JkT7uxNt1+/W+zLsWtQza11LHiQWSbNEdgWhOOSKRFPUjZ4Vc uZhhYs7H07lrX78KMpKBSLuxr7j3XvNE0WMj9U8sFvkbMw7HYO1o/sb5m/Kof7/j9bim /GMbSQ4/oVVm+yZSgz3uKIJwt2xOUTMxFZ3y0zLu1crd4JRzRqgF1cedwKtVLCvvAdzc 07mt8Jy0H5LdwWy5c0LpRxUdhl1pOdNY9HtcMPVFmX/coVCWgbFWUSkn96eXmmxdFjwn TWJA== X-Gm-Message-State: AOAM5326WPIl/tgQskE7Fd0TEVzHJ0G7dJOIPYpBiZcUxjA8F5MOsebI 3HWipmsIBFaMyanVBGMLTHG9NsdHpos= X-Google-Smtp-Source: ABdhPJzu1YXz0p2R3AreojsTRQmVu1cEtFeHh4gHzGHQ2i4QnVquGgkJyRDCzA+AyL+U0X7fJBrO1g== X-Received: by 2002:a05:6830:3152:: with SMTP id c18mr3442539ots.244.1642784093746; Fri, 21 Jan 2022 08:54:53 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.54.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:54:53 -0800 (PST) From: Luiz Sampaio To: Hans Verkuil , Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-media@vger.kernel.org Subject: [PATCH 10/31] media: radio: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:15 -0300 Message-Id: <20220121165436.30956-11-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/media/radio/radio-shark.c | 6 +++--- drivers/media/radio/radio-shark2.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/radio/radio-shark.c b/drivers/media/radio/radio-= shark.c index 8230da828d0e..7998b75df525 100644 --- a/drivers/media/radio/radio-shark.c +++ b/drivers/media/radio/radio-shark.c @@ -217,19 +217,19 @@ static void shark_led_set_red(struct led_classdev *le= d_cdev, static const struct led_classdev shark_led_templates[NO_LEDS] =3D { [BLUE_LED] =3D { .name =3D "%s:blue:", - .brightness =3D LED_OFF, + .brightness =3D 0, .max_brightness =3D 127, .brightness_set =3D shark_led_set_blue, }, [BLUE_PULSE_LED] =3D { .name =3D "%s:blue-pulse:", - .brightness =3D LED_OFF, + .brightness =3D 0, .max_brightness =3D 255, .brightness_set =3D shark_led_set_blue_pulse, }, [RED_LED] =3D { .name =3D "%s:red:", - .brightness =3D LED_OFF, + .brightness =3D 0, .max_brightness =3D 1, .brightness_set =3D shark_led_set_red, }, diff --git a/drivers/media/radio/radio-shark2.c b/drivers/media/radio/radio= -shark2.c index d150f12382c6..776877a294d8 100644 --- a/drivers/media/radio/radio-shark2.c +++ b/drivers/media/radio/radio-shark2.c @@ -189,13 +189,13 @@ static void shark_led_set_red(struct led_classdev *le= d_cdev, static const struct led_classdev shark_led_templates[NO_LEDS] =3D { [BLUE_LED] =3D { .name =3D "%s:blue:", - .brightness =3D LED_OFF, + .brightness =3D 0, .max_brightness =3D 127, .brightness_set =3D shark_led_set_blue, }, [RED_LED] =3D { .name =3D "%s:red:", - .brightness =3D LED_OFF, + .brightness =3D 0, .max_brightness =3D 1, .brightness_set =3D shark_led_set_red, }, --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF8BC4332F for ; Fri, 21 Jan 2022 16:56:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380017AbiAUQ4u (ORCPT ); Fri, 21 Jan 2022 11:56:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379976AbiAUQzR (ORCPT ); Fri, 21 Jan 2022 11:55:17 -0500 Received: from mail-oo1-xc29.google.com (mail-oo1-xc29.google.com [IPv6:2607:f8b0:4864:20::c29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A06AC06174E; Fri, 21 Jan 2022 08:54:57 -0800 (PST) Received: by mail-oo1-xc29.google.com with SMTP id v10-20020a4a860a000000b002ddc59f8900so3495545ooh.7; Fri, 21 Jan 2022 08:54:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=axyN3Dmc+7i+0pzDHxCOIZN0RRBTRZkn0CanzB+myz0=; b=H/B2qyOFALvP9VFgovDj7du1b8svC8K7k2YjHRIPfkpAurE74+rahvqGO2yfytLNFB ki1YIOOlpG9npQJ3Bj1vwyvUY+e1Pz8YnU5DmPlcyLtM9JO2BxJ4KS0qHLpAzpmKdePl 0G9I3pplsNbfyBN2yNVnnIma3FpJzkJ0PSjdC7g7DjPogdR+dwWYGg7tFvzYl9LTlBTO czKoTDx2QeMutjcfGzCUjKdodosIF9Xe80Y66dT/OZ+coUmyi1wVX8hKn52k4I7EEVUl cre6LJDg9R+6+DTQ33HuezIQTOOo3BDszs2kmfZfzV0Raul4oIb6fTokXJPt/J3HzhqJ EHbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=axyN3Dmc+7i+0pzDHxCOIZN0RRBTRZkn0CanzB+myz0=; b=gFQFU6ifX65jI6BsgPEncz/j40rDnnfwgF+8+CzAMV3aLnsw91EZahDrdoYihLqAGV GiE5mTOpC3GAPUp5RlWgoyKbQdo9zzC16y/524aWAMHSl3ZT3dHQOml9QUKn8k2yoySZ KMUtSHcVd+1dEZEsxcYSjToU2fD4CPzfb+KM2lcX+kDBVCkJLKswxjq4Ww126/OlaplJ H68wJnUTyO8zS6U5OumZ8fdsSQfRhFZAAlZyGyk5tiSAzz5cwlAy6ueLCgmypB64qXR5 kjmOUVtyc5tKPsYd1/cPBACSEN0NLQZUMtYSiX7xR6c5iatUqIe3mGy76T++jNfZWedx BG6Q== X-Gm-Message-State: AOAM531aq7VWaWNUuTEajCuaaTjxJRDd2CXIZMO4mc9MLCQinx7jkEcc oKeE1yGwrLmJEoMkte1QIfQxzjq/KuE= X-Google-Smtp-Source: ABdhPJyB7LicWmiaKhTj/MOAxL2NyKsn2SS+i0ZOfk+4vgm1FtLkR75CZD27pOXEHGvewZ/KzNUBRg== X-Received: by 2002:a4a:e8c9:: with SMTP id h9mr3121251ooe.12.1642784096951; Fri, 21 Jan 2022 08:54:56 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.54.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:54:56 -0800 (PST) From: Luiz Sampaio To: Sean Young , Mauro Carvalho Chehab , =?UTF-8?q?David=20H=C3=A4rdeman?= Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-media@vger.kernel.org Subject: [PATCH 11/31] media: rc: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:16 -0300 Message-Id: <20220121165436.30956-12-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/media/rc/rc-main.c | 4 ++-- drivers/media/rc/redrat3.c | 4 ++-- drivers/media/rc/ttusbir.c | 4 ++-- drivers/media/rc/winbond-cir.c | 6 +++--- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index b90438a71c80..76580f1920e2 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -641,7 +641,7 @@ static void ir_do_keyup(struct rc_dev *dev, bool sync) dev_dbg(&dev->dev, "keyup key 0x%04x\n", dev->last_keycode); del_timer(&dev->timer_repeat); input_report_key(dev->input_dev, dev->last_keycode, 0); - led_trigger_event(led_feedback, LED_OFF); + led_trigger_event(led_feedback, 0); if (sync) input_sync(dev->input_dev); dev->keypressed =3D false; @@ -812,7 +812,7 @@ static void ir_do_keydown(struct rc_dev *dev, enum rc_p= roto protocol, dev->device_name, keycode, protocol, scancode); input_report_key(dev->input_dev, keycode, 1); =20 - led_trigger_event(led_feedback, LED_FULL); + led_trigger_event(led_feedback, 255); } =20 /* diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c index cb22316b3f00..7c255f7d790c 100644 --- a/drivers/media/rc/redrat3.c +++ b/drivers/media/rc/redrat3.c @@ -855,7 +855,7 @@ static void redrat3_brightness_set(struct led_classdev = *led_dev, enum struct redrat3_dev *rr3 =3D container_of(led_dev, struct redrat3_dev, led); =20 - if (brightness !=3D LED_OFF && atomic_cmpxchg(&rr3->flash, 0, 1) =3D=3D 0= ) { + if (brightness !=3D 0 && atomic_cmpxchg(&rr3->flash, 0, 1) =3D=3D 0) { int ret =3D usb_submit_urb(rr3->flash_urb, GFP_ATOMIC); if (ret !=3D 0) { dev_dbg(rr3->dev, "%s: unexpected ret of %d\n", @@ -919,7 +919,7 @@ static void redrat3_led_complete(struct urb *urb) break; } =20 - rr3->led.brightness =3D LED_OFF; + rr3->led.brightness =3D 0; atomic_dec(&rr3->flash); } =20 diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c index 629787d53ee1..a295112644c3 100644 --- a/drivers/media/rc/ttusbir.c +++ b/drivers/media/rc/ttusbir.c @@ -44,7 +44,7 @@ static enum led_brightness ttusbir_brightness_get(struct = led_classdev *led_dev) { struct ttusbir *tt =3D container_of(led_dev, struct ttusbir, led); =20 - return tt->led_on ? LED_FULL : LED_OFF; + return tt->led_on ? 255 : 0; } =20 static void ttusbir_set_led(struct ttusbir *tt) @@ -70,7 +70,7 @@ static void ttusbir_brightness_set(struct led_classdev *l= ed_dev, enum { struct ttusbir *tt =3D container_of(led_dev, struct ttusbir, led); =20 - tt->led_on =3D brightness !=3D LED_OFF; + tt->led_on =3D brightness !=3D 0; =20 ttusbir_set_led(tt); } diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media/rc/winbond-cir.c index 94efb035d21b..d14e495a8641 100644 --- a/drivers/media/rc/winbond-cir.c +++ b/drivers/media/rc/winbond-cir.c @@ -265,7 +265,7 @@ wbcir_led_brightness_get(struct led_classdev *led_cdev) if (inb(data->ebase + WBCIR_REG_ECEIR_CTS) & WBCIR_LED_ENABLE) return LED_FULL; else - return LED_OFF; + return 0; } =20 static void @@ -277,7 +277,7 @@ wbcir_led_brightness_set(struct led_classdev *led_cdev, led); =20 wbcir_set_bits(data->ebase + WBCIR_REG_ECEIR_CTS, - brightness =3D=3D LED_OFF ? 0x00 : WBCIR_LED_ENABLE, + brightness =3D=3D 0 ? 0x00 : WBCIR_LED_ENABLE, WBCIR_LED_ENABLE); } =20 @@ -1167,7 +1167,7 @@ wbcir_remove(struct pnp_dev *device) led_classdev_unregister(&data->led); =20 /* This is ok since &data->led isn't actually used */ - wbcir_led_brightness_set(&data->led, LED_OFF); + wbcir_led_brightness_set(&data->led, 0); =20 release_region(data->wbase, WAKEUP_IOMEM_LEN); release_region(data->ebase, EHFUNC_IOMEM_LEN); --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A257FC433F5 for ; Fri, 21 Jan 2022 16:56:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379557AbiAUQ4w (ORCPT ); Fri, 21 Jan 2022 11:56:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379984AbiAUQzR (ORCPT ); Fri, 21 Jan 2022 11:55:17 -0500 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 224F8C061751; Fri, 21 Jan 2022 08:55:00 -0800 (PST) Received: by mail-ot1-x333.google.com with SMTP id a12-20020a0568301dcc00b005919e149b4cso12492855otj.8; Fri, 21 Jan 2022 08:55:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XRkMGPYm8YHI9B+ytD+Zs/rtt+wOfDZnupLp3J3rdss=; b=jhjODjRCQrcaRbsSvitlKjbN9/O+vC0R6ReJa9+BuXHVqBCBHDFTt+mY+MFSawgicb NeWPBaLvhJqg5Zeufmt+ChofbKnT53HI6Sg7oitjtE4PmBRxqRCgnBv2simLL9mkCsjs Edyph23cNwnKCtiV/riHxkPR0LxIjVDp/RjEwPtGfooXsrwsMPB5wpXOpY4TTcRlsrbo ee3mV5xQHarXvJY42PDZWd6BCTzPC50OCXq4ol7ud0KZwYoFCe4n/CB9ajcqCoYd7pKx xnuZZxWntLZ7cLv3seueKql40MqPzWsBObou3hoU/C6EtdaqQwPAmElqYp5MxDJHZEtJ Ew/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XRkMGPYm8YHI9B+ytD+Zs/rtt+wOfDZnupLp3J3rdss=; b=f3wlNHqkL49l9uLuBBe41WdZ+sLmy76ATEozk3x/c8eGBA/ehexSbGqS/DmEpev+4i fx5Lik05xoKfPQQGE5R3GPSkfLKH2mEyju2n2bon521qXMTtWF8+vWzhWvSh9gfGj+CY Nm2BadHbCPNd5QznlVbLyf8ZyBc/zqdwhUcnLGVZu48MUjFQLLH+a/u3usAFhcjz+14o 4PDpMK4nkpIVooZ05Atf7k6Pi6XXE6B1NId76Qfe9Iuy+ba52N0+N0QRCOBHNLxb12Ar gQ3MPrtKSRsQ4KlPj9WD/eaDv8UODaAPWFCn3xgLw92V5/FV5cwqLeuZUrk53cFrapDw klXA== X-Gm-Message-State: AOAM5339m8Vhibg14GDkAush7rz+ajqCGwTuYrsUuFNDMpM7iFMS0QWN JtJX9J2EnXARrZFWa7VwvQU= X-Google-Smtp-Source: ABdhPJzhEd2XBHo2Fm46jjhKsmeir1zZ+dSho/AoK/PAiPC26SPAPqy1RAFOSzOMiROSRYqePduSmg== X-Received: by 2002:a05:6830:40c6:: with SMTP id h6mr3264903otu.247.1642784099522; Fri, 21 Jan 2022 08:54:59 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.54.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:54:59 -0800 (PST) From: Luiz Sampaio To: Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-media@vger.kernel.org Subject: [PATCH 12/31] media: v4l2-core: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:17 -0300 Message-Id: <20220121165436.30956-13-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/media/v4l2-core/v4l2-flash-led-class.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-flash-led-class.c b/drivers/media= /v4l2-core/v4l2-flash-led-class.c index e70e128ccc9c..a47ac654c9f4 100644 --- a/drivers/media/v4l2-core/v4l2-flash-led-class.c +++ b/drivers/media/v4l2-core/v4l2-flash-led-class.c @@ -234,11 +234,11 @@ static int v4l2_flash_s_ctrl(struct v4l2_ctrl *c) case V4L2_CID_FLASH_LED_MODE: switch (c->val) { case V4L2_FLASH_LED_MODE_NONE: - led_set_brightness_sync(led_cdev, LED_OFF); + led_set_brightness_sync(led_cdev, 0); return led_set_flash_strobe(fled_cdev, false); case V4L2_FLASH_LED_MODE_FLASH: /* Turn the torch LED off */ - led_set_brightness_sync(led_cdev, LED_OFF); + led_set_brightness_sync(led_cdev, 0); if (ctrls[STROBE_SOURCE]) { external_strobe =3D (ctrls[STROBE_SOURCE]->val =3D=3D V4L2_FLASH_STROBE_SOURCE_EXTERNAL); --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14F3AC4332F for ; Fri, 21 Jan 2022 16:57:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380512AbiAUQ46 (ORCPT ); Fri, 21 Jan 2022 11:56:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380007AbiAUQzS (ORCPT ); Fri, 21 Jan 2022 11:55:18 -0500 Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C72DC061756; Fri, 21 Jan 2022 08:55:03 -0800 (PST) Received: by mail-ot1-x332.google.com with SMTP id l64-20020a9d1b46000000b005983a0a8aaaso12528714otl.3; Fri, 21 Jan 2022 08:55:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=//qkdexdYIAffr/wUpysgq4KHDNS4hLAy6zYf5Zu0v0=; b=OSxN7qu75Jl6Ebypga9EB+rplXL2NknX3v4hf6fdfBKRFxnzpNYg+gtEDRUJTspnNY kTwMubX5Osq+gG0ozYv5J1+mfyiuQoGQH/OAU0XLabU/xitBEHrV25rvFJyLpopYC2qI WT94JRxDJECeNsRXFsx/cv2LpFTwt+rhh9PEY5ypRwDUQ9GoxjRJeC9434EFhq9dzfwx 2uhCO3G6gMl/MVRzOhxZ2RZMEExqltWLaKq4cn+sm3Zwt9+slU6u7ifmmAYWmCbEQQf7 wL+7KNo8KcKA4dwGpoGlNJIXNzPjgv7VTBnRA1dcMvHBqykqPMmfIX6lqlZZ8OTy9myu /NzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=//qkdexdYIAffr/wUpysgq4KHDNS4hLAy6zYf5Zu0v0=; b=4sHEBAlGpgqvaAfnACkn7R8xBI7ulCVZcXhZX4+t+NUFJFPzFjF24/hZ092ev8u/na +R6ztxuaktFtYx6mN+v069+nFIgq0GI7Ow1E0XISYu5QLFDy/4fRj3mCpDkNbZ+7HeCK xojQmjRqBpUDsk/coSi1oNgpD9oyG54jmToir377joarnkupOplpidqPKnAOAfHh93dR jYrq4MKFlk1+B+kiNc99OiDLsLDIMPFzvFVDMOhPZNOWT7cMAecCOeva4B2v/Z3EvNNM vhMiFEYtNmLe7U0Gr/7N4mUMeh1CQuXH+PAF+iWV4syL5wutG82I86PFd2xDZS7SsEfx QZJA== X-Gm-Message-State: AOAM532K5Vk71RQnXf7zNWQBbEPYjQP321Yqlf4lNSY5upjZYHE/xSzZ o1jXwJihueWNa9DW8wKyHf8= X-Google-Smtp-Source: ABdhPJwLwqGU0n96VjHoplzG9X99JN+vvV5vjYkOWtZbXe7dcfTezy+ooVZ/MdX9vggOI9EvsoDRwA== X-Received: by 2002:a9d:27c1:: with SMTP id c59mr3457166otb.150.1642784102699; Fri, 21 Jan 2022 08:55:02 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:02 -0800 (PST) From: Luiz Sampaio To: Ulf Hansson , Adrian Hunter Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-mmc@vger.kernel.org Subject: [PATCH 13/31] mmc: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:18 -0300 Message-Id: <20220121165436.30956-14-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/mmc/core/core.c | 4 ++-- drivers/mmc/host/rtsx_usb_sdmmc.c | 4 ++-- drivers/mmc/host/sdhci.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 368f10405e13..66bc9c780e06 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -175,7 +175,7 @@ void mmc_request_done(struct mmc_host *host, struct mmc= _request *mrq) mmc_should_fail_request(host, mrq); =20 if (!host->ongoing_mrq) - led_trigger_event(host->led, LED_OFF); + led_trigger_event(host->led, 0); =20 if (mrq->sbc) { pr_debug("%s: req done : %d: %08x %08x %08x %08x\n", @@ -352,7 +352,7 @@ int mmc_start_request(struct mmc_host *host, struct mmc= _request *mrq) if (err) return err; =20 - led_trigger_event(host->led, LED_FULL); + led_trigger_event(host->led, 255); __mmc_start_request(host, mrq); =20 return 0; diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_= sdmmc.c index 5fe4528e296e..64fe7a75f401 100644 --- a/drivers/mmc/host/rtsx_usb_sdmmc.c +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c @@ -1287,7 +1287,7 @@ static void rtsx_usb_update_led(struct work_struct *w= ork) if (host->power_mode =3D=3D MMC_POWER_OFF) goto out; =20 - if (host->led.brightness =3D=3D LED_OFF) + if (host->led.brightness =3D=3D 0) rtsx_usb_turn_off_led(ucr); else rtsx_usb_turn_on_led(ucr); @@ -1357,7 +1357,7 @@ static int rtsx_usb_sdmmc_drv_probe(struct platform_d= evice *pdev) snprintf(host->led_name, sizeof(host->led_name), "%s::", mmc_hostname(mmc)); host->led.name =3D host->led_name; - host->led.brightness =3D LED_OFF; + host->led.brightness =3D 0; host->led.default_trigger =3D mmc_hostname(mmc); host->led.brightness_set =3D rtsx_usb_led_control; =20 diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 07c6da1f2f0f..ddc58a8f0c4f 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -395,7 +395,7 @@ static void sdhci_led_control(struct led_classdev *led, if (host->runtime_suspended) goto out; =20 - if (brightness =3D=3D LED_OFF) + if (brightness =3D=3D 0) __sdhci_led_deactivate(host); else __sdhci_led_activate(host); @@ -414,7 +414,7 @@ static int sdhci_led_register(struct sdhci_host *host) "%s::", mmc_hostname(mmc)); =20 host->led.name =3D host->led_name; - host->led.brightness =3D LED_OFF; + host->led.brightness =3D 0; host->led.default_trigger =3D mmc_hostname(mmc); host->led.brightness_set =3D sdhci_led_control; =20 --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B7D2C433F5 for ; Fri, 21 Jan 2022 16:58:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382140AbiAUQ6b (ORCPT ); Fri, 21 Jan 2022 11:58:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380025AbiAUQzS (ORCPT ); Fri, 21 Jan 2022 11:55:18 -0500 Received: from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 894CBC061757; Fri, 21 Jan 2022 08:55:07 -0800 (PST) Received: by mail-oo1-xc34.google.com with SMTP id q16-20020a4a3010000000b002dde2463e66so3486183oof.9; Fri, 21 Jan 2022 08:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v7u/1reZfs0BoCSFwSj+daUOVIdy7CF8lGf6AzgFwV8=; b=dUOYa3+iMqZXKhKXRcAf//V+c049D5heIy9QFjxhsiTO/lGEOqy6uNxoq+GzfKpUk5 MEZAMsqOpgmn3b+tyP42LjxdhK3iF8t2Vo9PJV+78hMvS6E3HTV7Ld+y2CpsX8SPaIbf HlpuYROwuiBADozL4lPZ89RIcJGxAjwcflh8qmkWsTTdCTv41ic03v/lliYc1q2XriGH GwCE6T/U7oYnOWM+Ikhp8+IjZYyCPw2Hev08/zkDx83ezLQHMUTJAFM9rqyesSoYtVVI lPJFfEViD7jt9X3i5Ms/4rmyT+A3W2FzIaOjMlZ5DyE6MLCt7/WNDDI08HO5NvDZ2+kt JEBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v7u/1reZfs0BoCSFwSj+daUOVIdy7CF8lGf6AzgFwV8=; b=KwH9zXLoh8iTTSbAcdYjLFKgIVlZg4enexS2l5PTbmpABZeWkh4aOP2oDV7BjBljIT dwIoziHO3rtQOQtaG5Xsbyd9dTAb9D5JwIEEW25P8SiytOu11kV+iar1uT8kn8F2iHxh nFitbJgB2H9XRDOeOfzG+ELSXbpHRLgDFhYYnGGokll3kWD/11veNOA7UnYSoj4pfiIu VL1kK0M74Y1hNvs7zdOwAaS91YkYAvjw/ud50xE3qRkLGRrBwIarDh+jZe0c/TgB3BE8 VIuwSlQdbUcD6ojvTZfHd+odxCaj2rWjK11eCzlBsMSgz2zaj5SYktIN/m34rC6v2Zn7 xfnw== X-Gm-Message-State: AOAM533tDJbIuDrtEiZbilpJCOCb11aAlyboN2z3Ymqt52jbaI5OQdjo 8lupqaesnG+NAZleBGObGjk= X-Google-Smtp-Source: ABdhPJx7+MxuKThO+YBT6naKuMHTwYdavYAds1jlnbwFonjq9bexJ87FdRlAV6oXlywXptGdgQ1aAQ== X-Received: by 2002:a4a:e60f:: with SMTP id f15mr3106188oot.75.1642784106971; Fri, 21 Jan 2022 08:55:06 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:06 -0800 (PST) From: Luiz Sampaio To: Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Kalle Valo , "David S. Miller" , Jakub Kicinski , ath9k-devel@qca.qualcomm.com Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 14/31] net: wireless: ath: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:19 -0300 Message-Id: <20220121165436.30956-15-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/net/wireless/ath/ath5k/led.c | 2 +- drivers/net/wireless/ath/ath9k/gpio.c | 4 ++-- drivers/net/wireless/ath/ath9k/htc_drv_gpio.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/led.c b/drivers/net/wireless/at= h/ath5k/led.c index 33e9928af363..df3db4851bf3 100644 --- a/drivers/net/wireless/ath/ath5k/led.c +++ b/drivers/net/wireless/ath/ath5k/led.c @@ -118,7 +118,7 @@ ath5k_led_brightness_set(struct led_classdev *led_dev, struct ath5k_led *led =3D container_of(led_dev, struct ath5k_led, led_dev); =20 - if (brightness =3D=3D LED_OFF) + if (brightness =3D=3D 0) ath5k_led_off(led->ah); else ath5k_led_on(led->ah); diff --git a/drivers/net/wireless/ath/ath9k/gpio.c b/drivers/net/wireless/a= th/ath9k/gpio.c index b457e52dd365..0828dc9d3503 100644 --- a/drivers/net/wireless/ath/ath9k/gpio.c +++ b/drivers/net/wireless/ath/ath9k/gpio.c @@ -52,7 +52,7 @@ static void ath_led_brightness(struct led_classdev *led_c= dev, enum led_brightness brightness) { struct ath_softc *sc =3D container_of(led_cdev, struct ath_softc, led_cde= v); - u32 val =3D (brightness =3D=3D LED_OFF); + u32 val =3D (brightness =3D=3D 0); =20 if (sc->sc_ah->config.led_active_high) val =3D !val; @@ -65,7 +65,7 @@ void ath_deinit_leds(struct ath_softc *sc) if (!sc->led_registered) return; =20 - ath_led_brightness(&sc->led_cdev, LED_OFF); + ath_led_brightness(&sc->led_cdev, 0); led_classdev_unregister(&sc->led_cdev); =20 ath9k_hw_gpio_free(sc->sc_ah, sc->sc_ah->led_pin); diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c b/drivers/net/wi= reless/ath/ath9k/htc_drv_gpio.c index ecb848b60725..7a9369f06534 100644 --- a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c +++ b/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c @@ -230,7 +230,7 @@ void ath9k_led_work(struct work_struct *work) led_work); =20 ath9k_hw_set_gpio(priv->ah, priv->ah->led_pin, - (priv->brightness =3D=3D LED_OFF)); + (priv->brightness =3D=3D 0)); } =20 static void ath9k_led_brightness(struct led_classdev *led_cdev, @@ -250,7 +250,7 @@ void ath9k_deinit_leds(struct ath9k_htc_priv *priv) if (!priv->led_registered) return; =20 - ath9k_led_brightness(&priv->led_cdev, LED_OFF); + ath9k_led_brightness(&priv->led_cdev, 0); led_classdev_unregister(&priv->led_cdev); cancel_work_sync(&priv->led_work); =20 --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C895C433F5 for ; Fri, 21 Jan 2022 16:57:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381136AbiAUQ5C (ORCPT ); Fri, 21 Jan 2022 11:57:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379114AbiAUQ4T (ORCPT ); Fri, 21 Jan 2022 11:56:19 -0500 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC483C06175B; Fri, 21 Jan 2022 08:55:10 -0800 (PST) Received: by mail-oi1-x233.google.com with SMTP id bx18so14350749oib.7; Fri, 21 Jan 2022 08:55:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LECfU6cLXmTWAFEkOmILc0YJMNkX9LftVPNv4hejlLw=; b=X1kgsEpBLZffAa6n2Zpdp3hS5eepWNOv7/NvBFCUrLPcDJE7Bb4iovVZguI/81N2Va T9Izj9GCrpLlmiY3jAP7FHD32lbBBoDVYU9aFaII3Ci3mdxhCfgw18C5xGs6nhGcF1jA OB9NWxVkn+zp78jd4frB+zrngn5WDc4SokFNup+Uv+Cl+NtmNhMjTjTKDrLiztSE5swy kGcXylufL7Yg/0WuuFfpyI2wuIj6KLRC8oB27XMpp845Ykq7ovO8++bP0Mzlv8pSuFP6 QbpB8wwGNDPXycyEZV6d7lpuxftlO15tpuQ1t6nz/b2l4Yz02AUn4DgS7fqHEA6g9urH yYPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LECfU6cLXmTWAFEkOmILc0YJMNkX9LftVPNv4hejlLw=; b=Xwxs0LT0kKh0cvNKWzDoiRLlpLt2MbZUY77hFn/bVQ0IEQ3dldS6TknoPDnZrQbxsR 31ezKaA8CyirypwkfqJnT0Vz1PaNnpMQNuANEx4aun3SaQOVFDUxdXSBAPPKuT1iOslg xhbnN8yb2+erFuDsens1NHqIjIhTEbEqIMoJ9fCD8TWstkYZiVvjkC02uiJL1AVpb6GZ Z63gWclAp3Ueo2raRxl7DR+KWJx1VjoKgk9A1qIRgcucmuJeJ7BB+EwM25TVhjxaV20e MkLJHN14MZVZgA+eSuwmynLbWwQDr020h5Feuccku+JEqrAZKj3GoxCmjukjH9svM+ul Q4Fg== X-Gm-Message-State: AOAM532xs3Sb4Xz3Q5HWxC5kfESFyGOqHdtW6yHgFxu+wHxNP0D4fZb8 YFPxWWnybFkI7imPjb+ZZvg= X-Google-Smtp-Source: ABdhPJwnMTm/HRYkycV0dhiJ7DZNarIXvBbprClF5tkRMIbPP/TqgF6weELN4MPUKaK2ZtRzAyN7JQ== X-Received: by 2002:a05:6808:f13:: with SMTP id m19mr1242656oiw.123.1642784109992; Fri, 21 Jan 2022 08:55:09 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:09 -0800 (PST) From: Luiz Sampaio To: Kalle Valo , "David S. Miller" , Jakub Kicinski Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 15/31] net: wireless: atmel: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:20 -0300 Message-Id: <20220121165436.30956-16-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/net/wireless/atmel/at76c50x-usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c b/drivers/net/wirele= ss/atmel/at76c50x-usb.c index 7582761c61e2..3847c59b9672 100644 --- a/drivers/net/wireless/atmel/at76c50x-usb.c +++ b/drivers/net/wireless/atmel/at76c50x-usb.c @@ -523,10 +523,10 @@ static void at76_ledtrig_tx_timerfunc(struct timer_li= st *unused) =20 if (tx_lastactivity !=3D tx_activity) { tx_lastactivity =3D tx_activity; - led_trigger_event(ledtrig_tx, LED_FULL); + led_trigger_event(ledtrig_tx, 255); mod_timer(&ledtrig_tx_timer, jiffies + HZ / 4); } else - led_trigger_event(ledtrig_tx, LED_OFF); + led_trigger_event(ledtrig_tx, 0); } =20 static void at76_ledtrig_tx_activity(void) --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F15C433FE for ; Fri, 21 Jan 2022 16:57:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381436AbiAUQ5J (ORCPT ); Fri, 21 Jan 2022 11:57:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379251AbiAUQ4T (ORCPT ); Fri, 21 Jan 2022 11:56:19 -0500 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A10EC06175C; Fri, 21 Jan 2022 08:55:14 -0800 (PST) Received: by mail-ot1-x32c.google.com with SMTP id n22-20020a9d2016000000b0059bd79f7777so12086472ota.2; Fri, 21 Jan 2022 08:55:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q356TySGpOi9cm8C15uJYgLdKIpPtBrszItNMB5sdtA=; b=d08sxUH3eK/+C4ImWey5IwRNyFJty2X4q2Fcg6n7ZHmZN9ctajF8uw1GBf1L5BH5I7 V/kKVyFpnQavgkZlPTK9Wg7ngEaOyGBjaq09IRMK1VTXfYANVnxMFNgSagNRfAPoAH+D fFY6QEbafaDPfAMdRL/B0VVisl/qar+seAQrHGkmlFelczDkuQ0RWymHEGujEWGDcOje y3S9LAVnu7DcuX+DlLtdGeeYGobgEUea6WaaNt5Zq0xv1Pwt6Gcu5v1UvbeK3I45x6SX AeuEz12eggrSCViDGacZEm47IFancwGQ4otY0iBDgahmOIf5w5EazCIq7c1CRKotuRJh eoqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q356TySGpOi9cm8C15uJYgLdKIpPtBrszItNMB5sdtA=; b=sqCq7pT1GmeFygG2d28OyL5iaiu4ZrISrlZhZEczb7mhrfb8lBSUCgZW0jRfargdGl oiV6VLaEx/NAyI03+ZoIivfs9geh9Pn1WWvYqPBrBsLduak97hD3x7vftiyHERM5VaJQ YTm4uBaFsQWM6Si2X2umo/+fJAbkvtgpn/mfOunaxoN6hNEV4EIWgNmdOyH/3HlQJKmi Aq/byVl4mTN4seCztL2S/GLInssYO2FSfg0RElGntP8DjY4XM/hViv/HuVucRV/V11ro 6FralrpgW/gT9xlOsEEgfEoMHgadcnmI8Nv3/pp927+DpjCPkBGJwuFSZhZxo3Lf9lTI 0/HQ== X-Gm-Message-State: AOAM532ahF59RFHp0a1A+78slma53tN4kOrh1ZlTVz+ot+hiReST0Qf7 HZiXY0QA7pEieVxVccuIaZY= X-Google-Smtp-Source: ABdhPJxMLXhmV3f3kN56sohiz2YckqgwjTMJ0RtIqk/x215sI8lHLYXhQHyVMgC8DtQbU8bte5FllA== X-Received: by 2002:a05:6830:1047:: with SMTP id b7mr3285242otp.197.1642784113714; Fri, 21 Jan 2022 08:55:13 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:13 -0800 (PST) From: Luiz Sampaio To: Kalle Valo , "David S. Miller" , Jakub Kicinski , Larry Finger Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 16/31] net: broadcom: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:21 -0300 Message-Id: <20220121165436.30956-17-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/net/wireless/broadcom/b43/leds.c | 2 +- drivers/net/wireless/broadcom/b43legacy/leds.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/b43/leds.c b/drivers/net/wireles= s/broadcom/b43/leds.c index 982a772a9d87..bdb46168e019 100644 --- a/drivers/net/wireless/broadcom/b43/leds.c +++ b/drivers/net/wireless/broadcom/b43/leds.c @@ -59,7 +59,7 @@ static void b43_led_update(struct b43_wldev *dev, * with the brightness_set handler, we will be called again soon * to fixup our state. */ if (radio_enabled) - turn_on =3D atomic_read(&led->state) !=3D LED_OFF; + turn_on =3D atomic_read(&led->state) !=3D 0; else turn_on =3D false; if (turn_on =3D=3D led->hw_state) diff --git a/drivers/net/wireless/broadcom/b43legacy/leds.c b/drivers/net/w= ireless/broadcom/b43legacy/leds.c index 38b5be3a84e2..5803d41185e7 100644 --- a/drivers/net/wireless/broadcom/b43legacy/leds.c +++ b/drivers/net/wireless/broadcom/b43legacy/leds.c @@ -66,7 +66,7 @@ static void b43legacy_led_brightness_set(struct led_class= dev *led_dev, * whether the LED has the wrong state for a second. */ radio_enabled =3D (dev->phy.radio_on && dev->radio_hw_enable); =20 - if (brightness =3D=3D LED_OFF || !radio_enabled) + if (brightness =3D=3D 0 || !radio_enabled) b43legacy_led_turn_off(dev, led->index, led->activelow); else b43legacy_led_turn_on(dev, led->index, led->activelow); --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EA30C4321E for ; Fri, 21 Jan 2022 16:58:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382024AbiAUQ6F (ORCPT ); Fri, 21 Jan 2022 11:58:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379407AbiAUQ4s (ORCPT ); Fri, 21 Jan 2022 11:56:48 -0500 Received: from mail-oo1-xc2d.google.com (mail-oo1-xc2d.google.com [IPv6:2607:f8b0:4864:20::c2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC585C06173D; Fri, 21 Jan 2022 08:55:17 -0800 (PST) Received: by mail-oo1-xc2d.google.com with SMTP id q16-20020a4a3010000000b002dde2463e66so3486305oof.9; Fri, 21 Jan 2022 08:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IVOAJ94pJepIbpbSfUfz/TwG9KdmwHk/Cvcx+UDJ5T4=; b=pIOKSl0EpHvfWhlFljlxDebl+wxZ1lCxG5dYv20Sp2Zkx6SU2GmaD5OaTmH+Wo2MfF 6Orxsa9dl/d5YlGtUQn6m1HOLOyIOSAO6qQVimJLB+W9GPbjzEk3FMHa3mjDGT2Truk2 HsYXLEUl+oAYX+Lhq0g7gMYFELX7rOAWTZ/7Vw+kRPKCGUSe6S1JAJJpTkwSMkulTlDD Czl00JsRrGhseMk1qAXTK76Q8Sm099C/heQTp05HF2pjEgsnc7ldOiQAYgikA4F7crlq NLqhs+rqc1W0D+hQnJSBgspyxs+2VXk+cyq5GA+2lFsNPL2oXE97+Sz4RS6P9fLxw73R 4aSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IVOAJ94pJepIbpbSfUfz/TwG9KdmwHk/Cvcx+UDJ5T4=; b=qzQ4LB6X/oDw/RZKK9L7FX0tpLwsDHpUxtGYOqEyiNCxJt/cvOP2E+qoiZrJUwAkPq OUcYzjqtfM/2be1OqScRzKbaPfFqO90LnusCXYW9i1NA1+XLkZRyDxPu30vYI9drchbh doVe2/DG0rxZ4ZPZcsVsP2YnFDXtnSK7k48t249qUxVTKlOeNaVW3Dnm0gBJcvdfnZhp iFuvA46JIo6akCw4Em/b5lxJo4OvRek35bvDVIbByDqHSe900QxiHxbjpPtunmmURhAS VDfzOOOXXedrLx423w+Xkzz6vGozZC5vgMi6/lKuFlBl1kyVQ9sCXUxtGUzS7+izxMvO 7ndg== X-Gm-Message-State: AOAM530y+c6e2XHLH/33b6pMKsu/dv75CnD5+HyriRt7NIt7rX2L31/1 FN4RzsAcaH8oOAzZb+ekvOYJ/qPGBCE= X-Google-Smtp-Source: ABdhPJz8GHk+7q5boe5b4Wu0fQHWY4WMc/PaCje5B6GeKDz/SFWL8Lj2dH6TwrxPxJylQDn8286Vrg== X-Received: by 2002:a4a:d184:: with SMTP id j4mr3108067oor.20.1642784117119; Fri, 21 Jan 2022 08:55:17 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:16 -0800 (PST) From: Luiz Sampaio To: Christian Lamparter , Kalle Valo , "David S. Miller" , Jakub Kicinski Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 17/31] net: intersil: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:22 -0300 Message-Id: <20220121165436.30956-18-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/net/wireless/intersil/p54/led.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intersil/p54/led.c b/drivers/net/wireless= /intersil/p54/led.c index 4bc77010f9c1..c5966b32416e 100644 --- a/drivers/net/wireless/intersil/p54/led.c +++ b/drivers/net/wireless/intersil/p54/led.c @@ -43,7 +43,7 @@ static void p54_update_leds(struct work_struct *work) if (tmp < blink_delay) blink_delay =3D tmp; =20 - if (priv->leds[i].led_dev.brightness =3D=3D LED_OFF) + if (priv->leds[i].led_dev.brightness =3D=3D 0) rerun =3D true; =20 priv->leds[i].toggled =3D --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B67C433EF for ; Fri, 21 Jan 2022 16:58:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381833AbiAUQ6P (ORCPT ); Fri, 21 Jan 2022 11:58:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379421AbiAUQ4s (ORCPT ); Fri, 21 Jan 2022 11:56:48 -0500 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09EEAC061401; Fri, 21 Jan 2022 08:55:22 -0800 (PST) Received: by mail-oi1-x22c.google.com with SMTP id s22so14315382oie.10; Fri, 21 Jan 2022 08:55:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9FkOQM5u5ppX0zk2cCe8h17WreOcSuyA+cCjXY4Ibok=; b=FImpVhK9ZDZtG1dz51vQYI+AlMCcxdaba/9f1CXpNApQCy38g6sYulfphRnyOrmCQa Ug2GmcTOm7WP5jTgcvWBrL46Jq1T/T0Y+ZI5YkHDKuIpBqlNdJ0eOKiLveK3OT7JcHct +oPN+9I+Nw2rWZrMaWVgrhwVMPXD+CTIeJyPtb5eUivV8wDYSv+aJoc9AOkuxwFIzOA6 /XUFpoEAwyVjwFJ/4/cvPwMunTEHZPQzDxTs6FCHQL0mL2l0v6I2JP4LDJ5g7b4TENCX 0Fi1g8vLruqjZLWCsbkQeHM8aBWg83w4iOqfR3D4utcscqfzbpJyvmp+sL0pzasfQsj/ lyag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9FkOQM5u5ppX0zk2cCe8h17WreOcSuyA+cCjXY4Ibok=; b=iRO2/J7Uq/RKupYUOJKVsG4ind1LM1RszlXbJyR5Plsb2CwHN0Zspu02DbRdbY1Vf9 Ee0d6vBsj98N7ccv8JTpQIzefbeMXRf8Dj68Iy6YideY6vDdbMyI24wVIZMLPpdB+phT V4PMR9vgUiSf1OSMR/qkjfqZgZYyZ8xgKEqNnd/0yi+Yz6DpHWm6E8Jbo0oV3EHV08gg 1OtluL/LxXP4zVQOMatrOK/m1rpl3scdWhoh8DSvNQTbS1hZ4rITsyunWCgWl3OEm42x PZ3Y6k5WkqDKHLiIc/uATsX8Kyqnb4NyGPN9O0fHfabw3ceVZ8LD4wvCqt4SPWlj1ZFi Xy0Q== X-Gm-Message-State: AOAM5335eSDZF27Lc6AJJ4JsYVh2/dlwoMG0JR00X3mIAyqk8rigydx3 uOm5t07cxGQQf4o04gyjVnc= X-Google-Smtp-Source: ABdhPJx8j5Rh7OutZLuKLTpoZF2an+JuV/Gd63EofLmY8JJ/xD3MoU6NM+EYsXzEfYtITA3o2R3p3w== X-Received: by 2002:a05:6808:11c5:: with SMTP id p5mr1269478oiv.51.1642784121430; Fri, 21 Jan 2022 08:55:21 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:21 -0800 (PST) From: Luiz Sampaio To: Stanislaw Gruszka , Helmut Schaa , Kalle Valo , "David S. Miller" , Jakub Kicinski Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 18/31] net: wireless: ralink: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:23 -0300 Message-Id: <20220121165436.30956-19-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/net/wireless/ralink/rt2x00/rt2400pci.c | 2 +- drivers/net/wireless/ralink/rt2x00/rt2500pci.c | 2 +- drivers/net/wireless/ralink/rt2x00/rt2500usb.c | 2 +- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4 ++-- drivers/net/wireless/ralink/rt2x00/rt2x00leds.c | 16 ++++++++-------- drivers/net/wireless/ralink/rt2x00/rt61pci.c | 4 ++-- drivers/net/wireless/ralink/rt2x00/rt73usb.c | 4 ++-- 7 files changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2400pci.c b/drivers/net/w= ireless/ralink/rt2x00/rt2400pci.c index dec6ffdf07c4..d8b7f1a73267 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2400pci.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2400pci.c @@ -204,7 +204,7 @@ static void rt2400pci_brightness_set(struct led_classde= v *led_cdev, { struct rt2x00_led *led =3D container_of(led_cdev, struct rt2x00_led, led_dev); - unsigned int enabled =3D brightness !=3D LED_OFF; + unsigned int enabled =3D brightness !=3D 0; u32 reg; =20 reg =3D rt2x00mmio_register_read(led->rt2x00dev, LEDCSR); diff --git a/drivers/net/wireless/ralink/rt2x00/rt2500pci.c b/drivers/net/w= ireless/ralink/rt2x00/rt2500pci.c index 8faa0a80e73a..fe490a6382fe 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2500pci.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2500pci.c @@ -204,7 +204,7 @@ static void rt2500pci_brightness_set(struct led_classde= v *led_cdev, { struct rt2x00_led *led =3D container_of(led_cdev, struct rt2x00_led, led_dev); - unsigned int enabled =3D brightness !=3D LED_OFF; + unsigned int enabled =3D brightness !=3D 0; u32 reg; =20 reg =3D rt2x00mmio_register_read(led->rt2x00dev, LEDCSR); diff --git a/drivers/net/wireless/ralink/rt2x00/rt2500usb.c b/drivers/net/w= ireless/ralink/rt2x00/rt2500usb.c index bb5ed6630645..b25c32a03d99 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2500usb.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2500usb.c @@ -267,7 +267,7 @@ static void rt2500usb_brightness_set(struct led_classde= v *led_cdev, { struct rt2x00_led *led =3D container_of(led_cdev, struct rt2x00_led, led_dev); - unsigned int enabled =3D brightness !=3D LED_OFF; + unsigned int enabled =3D brightness !=3D 0; u16 reg; =20 reg =3D rt2500usb_register_read(led->rt2x00dev, MAC_CSR20); diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/w= ireless/ralink/rt2x00/rt2800lib.c index deddb0afd312..8441e6e5320a 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c @@ -1521,7 +1521,7 @@ static void rt2800_brightness_set(struct led_classdev= *led_cdev, { struct rt2x00_led *led =3D container_of(led_cdev, struct rt2x00_led, led_dev); - unsigned int enabled =3D brightness !=3D LED_OFF; + unsigned int enabled =3D brightness !=3D 0; unsigned int bg_mode =3D (enabled && led->rt2x00dev->curr_band =3D=3D NL80211_BAND_2GHZ); unsigned int polarity =3D @@ -1570,7 +1570,7 @@ static void rt2800_brightness_set(struct led_classdev= *led_cdev, * (1 << level) - 1 */ rt2800_mcu_request(led->rt2x00dev, MCU_LED_STRENGTH, 0xff, - (1 << brightness / (LED_FULL / 6)) - 1, + (1 << brightness / (255 / 6)) - 1, polarity); } } diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00leds.c b/drivers/net/= wireless/ralink/rt2x00/rt2x00leds.c index f5361d582d4e..3ef2a81aed7d 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00leds.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00leds.c @@ -52,7 +52,7 @@ void rt2x00leds_led_quality(struct rt2x00_dev *rt2x00dev,= int rssi) * is going to calculate the value and might use it in a * division. */ - brightness =3D ((LED_FULL / 6) * rssi) + 1; + brightness =3D ((255 / 6) * rssi) + 1; if (brightness !=3D led->led_dev.brightness) { led->led_dev.brightness_set(&led->led_dev, brightness); led->led_dev.brightness =3D brightness; @@ -61,7 +61,7 @@ void rt2x00leds_led_quality(struct rt2x00_dev *rt2x00dev,= int rssi) =20 static void rt2x00led_led_simple(struct rt2x00_led *led, bool enabled) { - unsigned int brightness =3D enabled ? LED_FULL : LED_OFF; + unsigned int brightness =3D enabled ? 255 : 0; =20 if (!(led->flags & LED_REGISTERED)) return; @@ -96,7 +96,7 @@ static int rt2x00leds_register_led(struct rt2x00_dev *rt2= x00dev, int retval; =20 led->led_dev.name =3D name; - led->led_dev.brightness =3D LED_OFF; + led->led_dev.brightness =3D 0; =20 retval =3D led_classdev_register(device, &led->led_dev); if (retval) { @@ -179,7 +179,7 @@ static void rt2x00leds_unregister_led(struct rt2x00_led= *led) * possible yet. */ if (!(led->led_dev.flags & LED_SUSPENDED)) - led->led_dev.brightness_set(&led->led_dev, LED_OFF); + led->led_dev.brightness_set(&led->led_dev, 0); =20 led->flags &=3D ~LED_REGISTERED; } @@ -199,8 +199,8 @@ static inline void rt2x00leds_suspend_led(struct rt2x00= _led *led) led_classdev_suspend(&led->led_dev); =20 /* This shouldn't be needed, but just to be safe */ - led->led_dev.brightness_set(&led->led_dev, LED_OFF); - led->led_dev.brightness =3D LED_OFF; + led->led_dev.brightness_set(&led->led_dev, 0); + led->led_dev.brightness =3D 0; } =20 void rt2x00leds_suspend(struct rt2x00_dev *rt2x00dev) @@ -218,8 +218,8 @@ static inline void rt2x00leds_resume_led(struct rt2x00_= led *led) led_classdev_resume(&led->led_dev); =20 /* Device might have enabled the LEDS during resume */ - led->led_dev.brightness_set(&led->led_dev, LED_OFF); - led->led_dev.brightness =3D LED_OFF; + led->led_dev.brightness_set(&led->led_dev, 0); + led->led_dev.brightness =3D 0; } =20 void rt2x00leds_resume(struct rt2x00_dev *rt2x00dev) diff --git a/drivers/net/wireless/ralink/rt2x00/rt61pci.c b/drivers/net/wir= eless/ralink/rt2x00/rt61pci.c index 82cfc2aadc2b..d48a7d06013c 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt61pci.c +++ b/drivers/net/wireless/ralink/rt2x00/rt61pci.c @@ -242,7 +242,7 @@ static void rt61pci_brightness_set(struct led_classdev = *led_cdev, { struct rt2x00_led *led =3D container_of(led_cdev, struct rt2x00_led, led_dev); - unsigned int enabled =3D brightness !=3D LED_OFF; + unsigned int enabled =3D brightness !=3D 0; unsigned int a_mode =3D (enabled && led->rt2x00dev->curr_band =3D=3D NL80211_BAND_5GHZ); unsigned int bg_mode =3D @@ -271,7 +271,7 @@ static void rt61pci_brightness_set(struct led_classdev = *led_cdev, * argument into the matching level within that range. */ rt61pci_mcu_request(led->rt2x00dev, MCU_LED_STRENGTH, 0xff, - brightness / (LED_FULL / 6), 0); + brightness / (255 / 6), 0); } } =20 diff --git a/drivers/net/wireless/ralink/rt2x00/rt73usb.c b/drivers/net/wir= eless/ralink/rt2x00/rt73usb.c index 5ff2c740c3ea..45b98395cf9e 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt73usb.c +++ b/drivers/net/wireless/ralink/rt2x00/rt73usb.c @@ -187,7 +187,7 @@ static void rt73usb_brightness_set(struct led_classdev = *led_cdev, { struct rt2x00_led *led =3D container_of(led_cdev, struct rt2x00_led, led_dev); - unsigned int enabled =3D brightness !=3D LED_OFF; + unsigned int enabled =3D brightness !=3D 0; unsigned int a_mode =3D (enabled && led->rt2x00dev->curr_band =3D=3D NL80211_BAND_5GHZ); unsigned int bg_mode =3D @@ -216,7 +216,7 @@ static void rt73usb_brightness_set(struct led_classdev = *led_cdev, * argument into the matching level within that range. */ rt2x00usb_vendor_request_sw(led->rt2x00dev, USB_LED_CONTROL, - brightness / (LED_FULL / 6), + brightness / (255 / 6), led->rt2x00dev->led_mcu_reg, REGISTER_TIMEOUT); } --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A2DAC433EF for ; Fri, 21 Jan 2022 16:58:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381814AbiAUQ6J (ORCPT ); Fri, 21 Jan 2022 11:58:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379623AbiAUQ4s (ORCPT ); Fri, 21 Jan 2022 11:56:48 -0500 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EF27C061747; Fri, 21 Jan 2022 08:55:25 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id x31-20020a056830245f00b00599111c8b20so12504870otr.7; Fri, 21 Jan 2022 08:55:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JlNCFKNGzNdKjL5cT/OHwG1B8Niqq4wld0y5z7aO8fE=; b=P3ZOxoBv55viB3dAfzKSRe+1LS/DMWgFmA6bqUxm/ovvkTeWR7NZqhHJARZwrUpfYV uAFpzChQtQvMYNxvF/wyh4OHPqWPfCq47VgxTMbA+mzmCT96pCpWnZBa03Ixea6CK5f7 g3Xcg6Y0PlXxcUVkWZi/CoU+wO7N81b5NqB7KfvZjp0AmELclzB6hax5OLTKOVulGG6Z lgOqc9YMRKttH758573dUWbIihX69VAZTXTSbwZNlq57Dr6V2KTAWzbRH8q9gdyGW900 VR5DVtQcVujUJMM10ZSPz7SGbf3C6tr9N2vjIDMDUlBgkW3HC4bxfmNHIFxq/Bwaimgt EMRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JlNCFKNGzNdKjL5cT/OHwG1B8Niqq4wld0y5z7aO8fE=; b=1qlWrfh/+87e68oCeGiBHiw22UWOyIRzE7xa3+zziEhEKbenVk7LBRFpDVQU7Ws168 LyivcYWSFqS3a1of0sfemCS+RwEB8FBm7JTJdWoD7ZT0bnCl8NGrOUwbSPtIU0NDElpp HtWmFij8RizE7KZYBwFslGhdfG1qhlAPcG/V9YYvZ/pAN2zPPBrhc96eV8HJAVLrzFFd 5hvVC7y0jEvdztKTjnlvl9K0oSI7s2ysnTqtntBNav3Uz07GAJXt15C39xLuVmupr/Ui gIwfFzpx80mKmpsuItwAfPMLSdSqh5JkuPrKTISE8pCkmWnJWLn47LcItAgbjLBtaQIS DfSA== X-Gm-Message-State: AOAM530pVEnp+zYYqqSvTXSBH95dYicEpZmSVuDNFdGQ6A3mgdWZN2eq EPAfCTYWSedEHMKCGRzc327432z8Q0I= X-Google-Smtp-Source: ABdhPJzLLejlyKQ1rc8bYS0Xd9Akuzio8gSFpnxClDl2uhTyxnM4hGeyoWTzSS5u4eKTAtH0DLZGSg== X-Received: by 2002:a05:6830:3152:: with SMTP id c18mr3444071ots.244.1642784125013; Fri, 21 Jan 2022 08:55:25 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:24 -0800 (PST) From: Luiz Sampaio To: Herton Ronaldo Krzesinski , Hin-Tak Leung , Larry Finger , Kalle Valo , "David S. Miller" , Jakub Kicinski Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 19/31] net: realtek: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:24 -0300 Message-Id: <20220121165436.30956-20-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c b/drivers/= net/wireless/realtek/rtl818x/rtl8187/leds.c index 49421d10e22b..6ddbdb5e3fa5 100644 --- a/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c +++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c @@ -109,7 +109,7 @@ static void rtl8187_led_brightness_set(struct led_class= dev *led_dev, return; priv =3D hw->priv; if (led->is_radio) { - if (brightness =3D=3D LED_FULL) { + if (brightness =3D=3D 255) { ieee80211_queue_delayed_work(hw, &priv->led_on, 0); radio_on =3D true; } else if (radio_on) { @@ -118,7 +118,7 @@ static void rtl8187_led_brightness_set(struct led_class= dev *led_dev, ieee80211_queue_delayed_work(hw, &priv->led_off, 0); } } else if (radio_on) { - if (brightness =3D=3D LED_OFF) { + if (brightness =3D=3D 0) { ieee80211_queue_delayed_work(hw, &priv->led_off, 0); /* The LED is off for 1/20 sec - it just blinks. */ ieee80211_queue_delayed_work(hw, &priv->led_on, --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62AF4C4332F for ; Fri, 21 Jan 2022 16:58:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382044AbiAUQ6N (ORCPT ); Fri, 21 Jan 2022 11:58:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230131AbiAUQ4s (ORCPT ); Fri, 21 Jan 2022 11:56:48 -0500 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 319E1C061762; Fri, 21 Jan 2022 08:55:32 -0800 (PST) Received: by mail-oi1-x230.google.com with SMTP id bb37so14391454oib.1; Fri, 21 Jan 2022 08:55:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b0M4okk/H4nrrlK7QqkbLry7t5aeu160aTNcn3RwhCo=; b=XAbkG7K+fm+bsIQ7zZxrvxnx3aG7q6GlqdVN+O5PmoX8gj4v/bzO2blN7LHfhBj/kW jzOh4PRxL/kNc8BTlcLYWWneKD6YwviUAsaA37+QjK08mWLo3JmaWGvtJIfbdrVWYRtk WFhIoUfBLo0wC7cxZ+5byX7877XlbgRHR4WFrcCPd27yWEcuCJEN/zK1Uxvdh4F/VLOH hBvbk/XOSzw5AkEOwcXtaZSovV1Kh1X0CqGVP4dbn4Yjzu+Eoyl/tt6qqFUcuAFyH3xy RfRoHzAdLQkk1b5n4m20C4C6ezrhoZ4gaWDqVhXhGRRsTTljHcDvLHTsrsqZi+i00D+J iOOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b0M4okk/H4nrrlK7QqkbLry7t5aeu160aTNcn3RwhCo=; b=YeeG3s47fN73eaADlDTEkcgdEQvuYfvW69j5QjV/G7wRDr6cv5kbOr3j3osTy4ow+X sKxR3+4JdUrc2tesz3KCtVydcOTubdSe9TtDnKR8xOOOD5RXM137pg5Wpx+W6pKQfqt0 uNDDXGvatevP41CUroPZPV2VbQ1ubbtojd4a3aySUHIxpZjqJO3MrnlXkJ43s7DbvHw5 KlS+5gXC2pNEBno1nM3XRb5unORuzkpFp/RpIW+ElnPKefUmqvJruGHFOALwmle3sYHy Lu80DZ4moAZSCAE1zLsZ5WymtzzDKRlE3XrpiT07aP3Q20YNGdnioBCd2syFInUkaCJP 39kQ== X-Gm-Message-State: AOAM530TkvaDJRJDLw4D2XUq6uHkjra7ZIMCwb8xu7Ql4LDBR6K0tePL KlRiXZWSHVYZ/nm32LnoYL0= X-Google-Smtp-Source: ABdhPJxf+wNBbKgamGV80Ye704WncAamSECYwf1z584BggR5/FONvhWcDX6Qqt6MP3HBPjlmINm6fQ== X-Received: by 2002:a54:4802:: with SMTP id j2mr1291994oij.160.1642784131472; Fri, 21 Jan 2022 08:55:31 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:31 -0800 (PST) From: Luiz Sampaio To: "Lee, Chun-Yi" , Hans de Goede , Mark Gross , Corentin Chary , =?UTF-8?q?Jo=C3=A3o=20Paulo=20Rechi=20Vita?= , Matthew Garrett , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Jonathan Woithe , Matan Ziv-Av , Jeremy Soller , System76 Product Development , Henrique de Moraes Holschuh , Herton Ronaldo Krzesinski , Azael Avalos Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, ibm-acpi-devel@lists.sourceforge.net Subject: [PATCH 20/31] platform: x86: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:25 -0300 Message-Id: <20220121165436.30956-21-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. Acked-by: Hans de Goede --- drivers/platform/x86/acer-wmi.c | 6 ++--- drivers/platform/x86/asus-wireless.c | 6 ++--- drivers/platform/x86/dell/dell-laptop.c | 2 +- drivers/platform/x86/dell/dell-wmi-led.c | 4 ++-- drivers/platform/x86/fujitsu-laptop.c | 28 ++++++++++++------------ drivers/platform/x86/lg-laptop.c | 18 +++++++-------- drivers/platform/x86/system76_acpi.c | 4 ++-- drivers/platform/x86/thinkpad_acpi.c | 14 ++++++------ drivers/platform/x86/topstar-laptop.c | 4 ++-- drivers/platform/x86/toshiba_acpi.c | 24 ++++++++++---------- 10 files changed, 55 insertions(+), 55 deletions(-) diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wm= i.c index 9c6943e401a6..ce960164a397 100644 --- a/drivers/platform/x86/acer-wmi.c +++ b/drivers/platform/x86/acer-wmi.c @@ -1597,7 +1597,7 @@ static int acer_led_init(struct device *dev) =20 static void acer_led_exit(void) { - set_u32(LED_OFF, ACER_CAP_MAILLED); + set_u32(0, ACER_CAP_MAILLED); led_classdev_unregister(&mail_led); } =20 @@ -2332,7 +2332,7 @@ static int acer_suspend(struct device *dev) =20 if (has_cap(ACER_CAP_MAILLED)) { get_u32(&value, ACER_CAP_MAILLED); - set_u32(LED_OFF, ACER_CAP_MAILLED); + set_u32(0, ACER_CAP_MAILLED); data->mailled =3D value; } =20 @@ -2377,7 +2377,7 @@ static void acer_platform_shutdown(struct platform_de= vice *device) return; =20 if (has_cap(ACER_CAP_MAILLED)) - set_u32(LED_OFF, ACER_CAP_MAILLED); + set_u32(0, ACER_CAP_MAILLED); } =20 static struct platform_driver acer_platform_driver =3D { diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/as= us-wireless.c index d3e7171928e5..139257bf71ea 100644 --- a/drivers/platform/x86/asus-wireless.c +++ b/drivers/platform/x86/asus-wireless.c @@ -84,8 +84,8 @@ static enum led_brightness led_state_get(struct led_class= dev *led) s =3D asus_wireless_method(acpi_device_handle(data->adev), "HSWC", data->hswc_params->status, &ret); if (ACPI_SUCCESS(s) && ret =3D=3D data->hswc_params->on) - return LED_FULL; - return LED_OFF; + return 255; + return 0; } =20 static void led_state_update(struct work_struct *work) @@ -103,7 +103,7 @@ static void led_state_set(struct led_classdev *led, enu= m led_brightness value) struct asus_wireless_data *data; =20 data =3D container_of(led, struct asus_wireless_data, led); - data->led_state =3D value =3D=3D LED_OFF ? data->hswc_params->off : + data->led_state =3D value =3D=3D 0 ? data->hswc_params->off : data->hswc_params->on; queue_work(data->wq, &data->led_work); } diff --git a/drivers/platform/x86/dell/dell-laptop.c b/drivers/platform/x86= /dell/dell-laptop.c index 8230e7a68a5e..4dd530e3b47b 100644 --- a/drivers/platform/x86/dell/dell-laptop.c +++ b/drivers/platform/x86/dell/dell-laptop.c @@ -2141,7 +2141,7 @@ static int micmute_led_set(struct led_classdev *led_c= dev, { struct calling_interface_buffer buffer; struct calling_interface_token *token; - int state =3D brightness !=3D LED_OFF; + int state =3D brightness !=3D 0; =20 if (state =3D=3D 0) token =3D dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE); diff --git a/drivers/platform/x86/dell/dell-wmi-led.c b/drivers/platform/x8= 6/dell/dell-wmi-led.c index 5bedaf7f0633..fcfd6dd60583 100644 --- a/drivers/platform/x86/dell/dell-wmi-led.c +++ b/drivers/platform/x86/dell/dell-wmi-led.c @@ -122,7 +122,7 @@ static int led_blink(unsigned char on_eighths, unsigned= char off_eighths) static void dell_led_set(struct led_classdev *led_cdev, enum led_brightness value) { - if (value =3D=3D LED_OFF) + if (value =3D=3D 0) led_off(); else led_on(); @@ -154,7 +154,7 @@ static int dell_led_blink(struct led_classdev *led_cdev, =20 static struct led_classdev dell_led =3D { .name =3D "dell::lid", - .brightness =3D LED_OFF, + .brightness =3D 0, .max_brightness =3D 1, .brightness_set =3D dell_led_set, .blink_set =3D dell_led_blink, diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/f= ujitsu-laptop.c index 80929380ec7e..6ebfda771209 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -584,10 +584,10 @@ static int logolamp_set(struct led_classdev *cdev, int poweron =3D FUNC_LED_ON, always =3D FUNC_LED_ON; int ret; =20 - if (brightness < LED_HALF) + if (brightness < 127) poweron =3D FUNC_LED_OFF; =20 - if (brightness < LED_FULL) + if (brightness < 255) always =3D FUNC_LED_OFF; =20 ret =3D call_fext_func(device, FUNC_LEDS, 0x1, LOGOLAMP_POWERON, poweron); @@ -604,13 +604,13 @@ static enum led_brightness logolamp_get(struct led_cl= assdev *cdev) =20 ret =3D call_fext_func(device, FUNC_LEDS, 0x2, LOGOLAMP_ALWAYS, 0x0); if (ret =3D=3D FUNC_LED_ON) - return LED_FULL; + return 255; =20 ret =3D call_fext_func(device, FUNC_LEDS, 0x2, LOGOLAMP_POWERON, 0x0); if (ret =3D=3D FUNC_LED_ON) - return LED_HALF; + return 127; =20 - return LED_OFF; + return 0; } =20 static int kblamps_set(struct led_classdev *cdev, @@ -618,7 +618,7 @@ static int kblamps_set(struct led_classdev *cdev, { struct acpi_device *device =3D to_acpi_device(cdev->dev->parent); =20 - if (brightness >=3D LED_FULL) + if (brightness >=3D 255) return call_fext_func(device, FUNC_LEDS, 0x1, KEYBOARD_LAMPS, FUNC_LED_ON); else @@ -629,11 +629,11 @@ static int kblamps_set(struct led_classdev *cdev, static enum led_brightness kblamps_get(struct led_classdev *cdev) { struct acpi_device *device =3D to_acpi_device(cdev->dev->parent); - enum led_brightness brightness =3D LED_OFF; + unsigned int brightness =3D 0; =20 if (call_fext_func(device, FUNC_LEDS, 0x2, KEYBOARD_LAMPS, 0x0) =3D=3D FUNC_LED_ON) - brightness =3D LED_FULL; + brightness =3D 255; =20 return brightness; } @@ -643,7 +643,7 @@ static int radio_led_set(struct led_classdev *cdev, { struct acpi_device *device =3D to_acpi_device(cdev->dev->parent); =20 - if (brightness >=3D LED_FULL) + if (brightness >=3D 255) return call_fext_func(device, FUNC_FLAGS, 0x5, RADIO_LED_ON, RADIO_LED_ON); else @@ -654,10 +654,10 @@ static int radio_led_set(struct led_classdev *cdev, static enum led_brightness radio_led_get(struct led_classdev *cdev) { struct acpi_device *device =3D to_acpi_device(cdev->dev->parent); - enum led_brightness brightness =3D LED_OFF; + unsigned int brightness =3D 0; =20 if (call_fext_func(device, FUNC_FLAGS, 0x4, 0x0, 0x0) & RADIO_LED_ON) - brightness =3D LED_FULL; + brightness =3D 255; =20 return brightness; } @@ -669,7 +669,7 @@ static int eco_led_set(struct led_classdev *cdev, int curr; =20 curr =3D call_fext_func(device, FUNC_LEDS, 0x2, ECO_LED, 0x0); - if (brightness >=3D LED_FULL) + if (brightness >=3D 255) return call_fext_func(device, FUNC_LEDS, 0x1, ECO_LED, curr | ECO_LED_ON); else @@ -680,10 +680,10 @@ static int eco_led_set(struct led_classdev *cdev, static enum led_brightness eco_led_get(struct led_classdev *cdev) { struct acpi_device *device =3D to_acpi_device(cdev->dev->parent); - enum led_brightness brightness =3D LED_OFF; + unsigned int brightness =3D 0; =20 if (call_fext_func(device, FUNC_LEDS, 0x2, ECO_LED, 0x0) & ECO_LED_ON) - brightness =3D LED_FULL; + brightness =3D 255; =20 return brightness; } diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-lap= top.c index a91847a551a7..cbcc945c2d9d 100644 --- a/drivers/platform/x86/lg-laptop.c +++ b/drivers/platform/x86/lg-laptop.c @@ -547,13 +547,13 @@ static void tpad_led_set(struct led_classdev *cdev, { union acpi_object *r; =20 - r =3D lg_wmab(WM_TLED, WM_SET, brightness > LED_OFF); + r =3D lg_wmab(WM_TLED, WM_SET, brightness > 0); kfree(r); } =20 static enum led_brightness tpad_led_get(struct led_classdev *cdev) { - return ggov(GOV_TLED) > 0 ? LED_ON : LED_OFF; + return ggov(GOV_TLED) > 0 ? 1 : 0; } =20 static LED_DEVICE(tpad_led, 1, 0); @@ -565,9 +565,9 @@ static void kbd_backlight_set(struct led_classdev *cdev, union acpi_object *r; =20 val =3D 0x22; - if (brightness <=3D LED_OFF) + if (brightness <=3D 0) val =3D 0; - if (brightness >=3D LED_FULL) + if (brightness >=3D 255) val =3D 0x24; r =3D lg_wmab(WM_KEY_LIGHT, WM_SET, val); kfree(r); @@ -581,22 +581,22 @@ static enum led_brightness get_kbd_backlight_level(vo= id) r =3D lg_wmab(WM_KEY_LIGHT, WM_GET, 0); =20 if (!r) - return LED_OFF; + return 0; =20 if (r->type !=3D ACPI_TYPE_BUFFER || r->buffer.pointer[1] !=3D 0x05) { kfree(r); - return LED_OFF; + return 0; } =20 switch (r->buffer.pointer[0] & 0x27) { case 0x24: - val =3D LED_FULL; + val =3D 255; break; case 0x22: - val =3D LED_HALF; + val =3D 127; break; default: - val =3D LED_OFF; + val =3D 0; } =20 kfree(r); diff --git a/drivers/platform/x86/system76_acpi.c b/drivers/platform/x86/sy= stem76_acpi.c index 7299ad08c838..9f2b11a0e02f 100644 --- a/drivers/platform/x86/system76_acpi.c +++ b/drivers/platform/x86/system76_acpi.c @@ -299,7 +299,7 @@ static enum led_brightness ap_led_get(struct led_classd= ev *led) if (value > 0) return (enum led_brightness)value; else - return LED_OFF; + return 0; } =20 // Set the airplane mode LED brightness @@ -308,7 +308,7 @@ static int ap_led_set(struct led_classdev *led, enum le= d_brightness value) struct system76_data *data; =20 data =3D container_of(led, struct system76_data, ap_led); - return system76_set(data, "SAPL", value =3D=3D LED_OFF ? 0 : 1); + return system76_set(data, "SAPL", value =3D=3D 0 ? 0 : 1); } =20 // Get the last set keyboard LED brightness diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/th= inkpad_acpi.c index 82fa6148216c..01fe0a2995fd 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -5421,13 +5421,13 @@ static int light_set_status(int status) static int light_sysfs_set(struct led_classdev *led_cdev, enum led_brightness brightness) { - return light_set_status((brightness !=3D LED_OFF) ? + return light_set_status((brightness !=3D 0) ? TPACPI_LED_ON : TPACPI_LED_OFF); } =20 static enum led_brightness light_sysfs_get(struct led_classdev *led_cdev) { - return (light_get_status() =3D=3D 1) ? LED_FULL : LED_OFF; + return (light_get_status() =3D=3D 1) ? 255 : 0; } =20 static struct tpacpi_led_classdev tpacpi_led_thinklight =3D { @@ -5759,7 +5759,7 @@ static int led_sysfs_set(struct led_classdev *led_cde= v, struct tpacpi_led_classdev, led_classdev); enum led_status_t new_state; =20 - if (brightness =3D=3D LED_OFF) + if (brightness =3D=3D 0) new_state =3D TPACPI_LED_OFF; else if (tpacpi_led_state_cache[data->led] !=3D TPACPI_LED_BLINK) new_state =3D TPACPI_LED_ON; @@ -5796,9 +5796,9 @@ static enum led_brightness led_sysfs_get(struct led_c= lassdev *led_cdev) rc =3D led_get_status(data->led); =20 if (rc =3D=3D TPACPI_LED_OFF || rc < 0) - rc =3D LED_OFF; /* no error handling in led class :( */ + rc =3D 0; /* no error handling in led class :( */ else - rc =3D LED_FULL; + rc =3D 255; =20 return rc; } @@ -9145,13 +9145,13 @@ static int tpacpi_led_set(int whichled, bool on) static int tpacpi_led_mute_set(struct led_classdev *led_cdev, enum led_brightness brightness) { - return tpacpi_led_set(LED_AUDIO_MUTE, brightness !=3D LED_OFF); + return tpacpi_led_set(LED_AUDIO_MUTE, brightness !=3D 0); } =20 static int tpacpi_led_micmute_set(struct led_classdev *led_cdev, enum led_brightness brightness) { - return tpacpi_led_set(LED_AUDIO_MICMUTE, brightness !=3D LED_OFF); + return tpacpi_led_set(LED_AUDIO_MICMUTE, brightness !=3D 0); } =20 static struct led_classdev mute_led_cdev[TPACPI_LED_MAX] =3D { diff --git a/drivers/platform/x86/topstar-laptop.c b/drivers/platform/x86/t= opstar-laptop.c index f7761d98c0fd..1382b91c2860 100644 --- a/drivers/platform/x86/topstar-laptop.c +++ b/drivers/platform/x86/topstar-laptop.c @@ -71,8 +71,8 @@ static int topstar_led_set(struct led_classdev *led, * it seems to be faulty on some models like the Topstar U931 * Notebook). */ - if ((ret =3D=3D 0x30001 && state =3D=3D LED_OFF) - || (ret =3D=3D 0x30000 && state !=3D LED_OFF)) { + if ((ret =3D=3D 0x30001 && state =3D=3D 0) + || (ret =3D=3D 0x30000 && state !=3D 0)) { status =3D acpi_execute_simple_method(topstar->device->handle, "FNCX", 0x83); if (ACPI_FAILURE(status)) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/tos= hiba_acpi.c index 352508d30467..641c6766febe 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -501,19 +501,19 @@ static enum led_brightness toshiba_illumination_get(s= truct led_classdev *cdev) =20 /* First request : initialize communication. */ if (!sci_open(dev)) - return LED_OFF; + return 0; =20 /* Check the illumination */ result =3D sci_read(dev, SCI_ILLUMINATION, &state); sci_close(dev); if (result =3D=3D TOS_FAILURE) { pr_err("ACPI call for illumination failed\n"); - return LED_OFF; + return 0; } else if (result !=3D TOS_SUCCESS) { - return LED_OFF; + return 0; } =20 - return state ? LED_FULL : LED_OFF; + return state ? 255 : 0; } =20 /* KBD Illumination */ @@ -602,12 +602,12 @@ static enum led_brightness toshiba_kbd_backlight_get(= struct led_classdev *cdev) result =3D hci_read(dev, HCI_KBD_ILLUMINATION, &state); if (result =3D=3D TOS_FAILURE) { pr_err("ACPI call to get the keyboard backlight failed\n"); - return LED_OFF; + return 0; } else if (result !=3D TOS_SUCCESS) { - return LED_OFF; + return 0; } =20 - return state ? LED_FULL : LED_OFF; + return state ? 255 : 0; } =20 static void toshiba_kbd_backlight_set(struct led_classdev *cdev, @@ -711,13 +711,13 @@ toshiba_eco_mode_get_status(struct led_classdev *cdev) status =3D tci_raw(dev, in, out); if (ACPI_FAILURE(status)) { pr_err("ACPI call to get ECO led failed\n"); - return LED_OFF; + return 0; } =20 if (out[0] !=3D TOS_SUCCESS) - return LED_OFF; + return 0; =20 - return out[2] ? LED_FULL : LED_OFF; + return out[2] ? 255 : 0; } =20 static void toshiba_eco_mode_set_status(struct led_classdev *cdev, @@ -2402,7 +2402,7 @@ static void toshiba_acpi_kbd_bl_work(struct work_stru= ct *work) toshiba_acpi->kbd_mode !=3D SCI_KBD_MODE_AUTO) led_classdev_notify_brightness_hw_changed(&toshiba_acpi->kbd_led, (toshiba_acpi->kbd_mode =3D=3D SCI_KBD_MODE_ON) ? - LED_FULL : LED_OFF); + 255 : 0); =20 /* Emulate the keyboard backlight event */ acpi_bus_generate_netlink_event(toshiba_acpi->acpi_dev->pnp.device_class, @@ -3225,7 +3225,7 @@ static void toshiba_acpi_notify(struct acpi_device *a= cpi_dev, u32 event) if (dev->kbd_type =3D=3D 2 && dev->kbd_mode !=3D SCI_KBD_MODE_AUTO) led_classdev_notify_brightness_hw_changed(&dev->kbd_led, (dev->kbd_mode =3D=3D SCI_KBD_MODE_ON) ? - LED_FULL : LED_OFF); + 255 : 0); break; case 0x85: /* Unknown */ case 0x8d: /* Unknown */ --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27604C433F5 for ; Fri, 21 Jan 2022 16:58:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231512AbiAUQ56 (ORCPT ); Fri, 21 Jan 2022 11:57:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379849AbiAUQ4t (ORCPT ); Fri, 21 Jan 2022 11:56:49 -0500 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 755DBC061763; Fri, 21 Jan 2022 08:55:34 -0800 (PST) Received: by mail-oi1-x22f.google.com with SMTP id w188so14290830oiw.13; Fri, 21 Jan 2022 08:55:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4weifrQ7PTCoGujS0yQMKZpi8lSBUanoNpSA0DdSt+Y=; b=OF1LGc0evnBIhNNz84FPs7c8hsoF1r+/WS4fAuOmilgSYZYbT6CrqaPs1OIO/6LIxh aCfomttS8vaYkKjlBhGRnCkK5sNSvB90MhaAykJPVz096eYCnJ7kncwalddJLbZmYVe5 MjebfomEvGhfTf2h1MgGTNSTVznz9gV0EWT14LVTZ24nZGykPBIKktLkT/rP1v3y60e1 Z6yTLr7ejol0GHlZUCZY41ckrUnhyqaRW1JwMN5GZK5O2k8qBmD5DCBxAozgWYBBu1uF 5RSJhj6dkBWt0EeCIIdyLjgqmWG4OcP7EQD/B7dkBMCqcGG2P0YCfdnVn2Gyds3JND8A yv3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4weifrQ7PTCoGujS0yQMKZpi8lSBUanoNpSA0DdSt+Y=; b=x+li9HbDXQxNSfkR5zgpJikqvGrAYCErkUYGH9I5UfkQQCf1U17sx/roNCXoDm411l BZclYBsCnwRC1gLj6Y8kDxmWfULut50+ZKnVP1JpyMb36dfHJWM8l/sdQON2F9jw6coW sYgEzsKs8JzU71ELMlRk/CFcjK4Z/DDKNZ8BQ79MqAEL+VyjNxRNedhBWMHbcdKYzQbf pgphObiWid10/FsYZViA3CWwGNuMYXD4OMAzeWSfLZPee1S2LBAkvQDYpe+uCbMGrmCa tvAxKp4vZeDflKS0MmJV67b8cSlk40cM5ha1LV/sp0g2Vc7tKNTtJiVpml4kn4cekY3w zWSg== X-Gm-Message-State: AOAM5328Le80sLSk3NGsLg4blFjC2dRtgEx06Ps5cugKvls4BHdkbhL9 jKm8j0ZRnfnfhvjjHkUGUflbyJnnq9I= X-Google-Smtp-Source: ABdhPJwjGzQmdpB6fvzrVNmA0mJLwxz20tqVgliSftrr9PonyQNufPf2QsVgpesq4DcccdBJkKfIgw== X-Received: by 2002:a54:4e9a:: with SMTP id c26mr1250134oiy.159.1642784133886; Fri, 21 Jan 2022 08:55:33 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:33 -0800 (PST) From: Luiz Sampaio To: Sebastian Reichel Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-pm@vger.kernel.org Subject: [PATCH 21/31] power: supply: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:26 -0300 Message-Id: <20220121165436.30956-22-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/power/supply/power_supply_leds.c | 26 ++++++++++++------------ 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/power/supply/power_supply_leds.c b/drivers/power/suppl= y/power_supply_leds.c index d69880cc3593..16f25179f710 100644 --- a/drivers/power/supply/power_supply_leds.c +++ b/drivers/power/supply/power_supply_leds.c @@ -31,25 +31,25 @@ static void power_supply_update_bat_leds(struct power_s= upply *psy) =20 switch (status.intval) { case POWER_SUPPLY_STATUS_FULL: - led_trigger_event(psy->charging_full_trig, LED_FULL); - led_trigger_event(psy->charging_trig, LED_OFF); - led_trigger_event(psy->full_trig, LED_FULL); + led_trigger_event(psy->charging_full_trig, 255); + led_trigger_event(psy->charging_trig, 0); + led_trigger_event(psy->full_trig, 255); led_trigger_event(psy->charging_blink_full_solid_trig, - LED_FULL); + 255); break; case POWER_SUPPLY_STATUS_CHARGING: - led_trigger_event(psy->charging_full_trig, LED_FULL); - led_trigger_event(psy->charging_trig, LED_FULL); - led_trigger_event(psy->full_trig, LED_OFF); + led_trigger_event(psy->charging_full_trig, 255); + led_trigger_event(psy->charging_trig, 255); + led_trigger_event(psy->full_trig, 0); led_trigger_blink(psy->charging_blink_full_solid_trig, &delay_on, &delay_off); break; default: - led_trigger_event(psy->charging_full_trig, LED_OFF); - led_trigger_event(psy->charging_trig, LED_OFF); - led_trigger_event(psy->full_trig, LED_OFF); + led_trigger_event(psy->charging_full_trig, 0); + led_trigger_event(psy->charging_trig, 0); + led_trigger_event(psy->full_trig, 0); led_trigger_event(psy->charging_blink_full_solid_trig, - LED_OFF); + 0); break; } } @@ -120,9 +120,9 @@ static void power_supply_update_gen_leds(struct power_s= upply *psy) dev_dbg(&psy->dev, "%s %d\n", __func__, online.intval); =20 if (online.intval) - led_trigger_event(psy->online_trig, LED_FULL); + led_trigger_event(psy->online_trig, 255); else - led_trigger_event(psy->online_trig, LED_OFF); + led_trigger_event(psy->online_trig, 0); } =20 static int power_supply_create_gen_triggers(struct power_supply *psy) --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FB31C433F5 for ; Fri, 21 Jan 2022 16:58:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382015AbiAUQ6C (ORCPT ); Fri, 21 Jan 2022 11:58:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379858AbiAUQ4t (ORCPT ); Fri, 21 Jan 2022 11:56:49 -0500 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6995C061769 for ; Fri, 21 Jan 2022 08:55:36 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id a12-20020a0568301dcc00b005919e149b4cso12495062otj.8 for ; Fri, 21 Jan 2022 08:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YaU4VG8N9CoVLuyvuF8eKASeQ+KGlO318g0VjIU083s=; b=h5ng4rGJAP8Dw2GzBBkwMcUMgwOH/C0MM674tyPWcagZpg5a5cPerPWSPK9gZ/q+SZ aGijwYdlRIUg87bxdAGcJFIiMjPJf5at0voT815CKdmYzHDrr1qrsq9nqLlP/evlL3o0 e++guAbfsQxsxNK5JbI+IvV65L7FGZUv9HJOOXckrW9NyOZhC6k6Zw/GDczbvSxKGkLJ D5QMucQtMB28DMsAvGJduBLGkw4fHUcbACqPG0NvBVFU8hqNEp9mtfGdznqUX+cyRAHh lj5cW9oSn6tQweYPwYEqO3NRL3UzaW5LVqKul2TTano8i6rbANy18HV2wayUJxPdgJDZ /sTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YaU4VG8N9CoVLuyvuF8eKASeQ+KGlO318g0VjIU083s=; b=6m87ARSMT5/eA7Ogg/IKVgQCVJwZL8ZFKaKoO+INF/V+IiZfDpBTIY+i62LrIrWl3a a4jQChRVkSYp8zvFYkrqdGdV/e/Tm9Qy/hLuZkoMioEuNULI+Fx4LxcZMBCmMm7+FaIc LZq8FNvnpnFZ7n47a7kuGDPpvobnoYXqLwQxtyle+4SbkE0Ys7T/Q0DU2z+btZiZrEHX RhsRuzAePkiYdftGMq8zVnI3h5MhckyJqoKxKUB2EdQD4JGAJF2TcLd8iKebOs5Bk+w7 xyNYBTPH5Sd3LHWu+wL1sYk75cxnIW7HmPIav3REwCEdk4iIU8NePJ7E1CAwhyVFgShW Ez8A== X-Gm-Message-State: AOAM531QzGQiIprCdePlIxQW5DDoRpXi2PKfPPBsZM36The79xtR+v8t yMosOrS1wN4cvsCxoVfsKTX7bPBd/lY= X-Google-Smtp-Source: ABdhPJxB6j58CX46EprCZsW8G6PeZqqSZ6IOoAEGrPdGDyJdeI4cHRGDwsx4dFfMPggbz9WNz7820Q== X-Received: by 2002:a05:6830:1ad9:: with SMTP id r25mr3397494otc.31.1642784136254; Fri, 21 Jan 2022 08:55:36 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:35 -0800 (PST) From: Luiz Sampaio To: Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, Luiz Sampaio Subject: [PATCH 22/31] tty: vt: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:27 -0300 Message-Id: <20220121165436.30956-23-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/tty/vt/keyboard.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c index be8313cdbac3..33bad1973180 100644 --- a/drivers/tty/vt/keyboard.c +++ b/drivers/tty/vt/keyboard.c @@ -1035,7 +1035,7 @@ static int kbd_led_trigger_activate(struct led_classd= ev *cdev) if (ledstate !=3D -1U) led_trigger_event(&trigger->trigger, ledstate & trigger->mask ? - LED_FULL : LED_OFF); + 255 : 0); tasklet_enable(&keyboard_tasklet); =20 return 0; @@ -1081,7 +1081,7 @@ static void kbd_propagate_led_state(unsigned int old_= state, if (changed & trigger->mask) led_trigger_event(&trigger->trigger, new_state & trigger->mask ? - LED_FULL : LED_OFF); + 255 : 0); } } =20 --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C8E8C433EF for ; Fri, 21 Jan 2022 16:57:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381790AbiAUQ5P (ORCPT ); Fri, 21 Jan 2022 11:57:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379874AbiAUQ4t (ORCPT ); Fri, 21 Jan 2022 11:56:49 -0500 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B246C06176C; Fri, 21 Jan 2022 08:55:39 -0800 (PST) Received: by mail-ot1-x329.google.com with SMTP id q13-20020a9d4b0d000000b0059b1209d708so12478481otf.10; Fri, 21 Jan 2022 08:55:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z6NMdJmJY0918lK7MEwP90+HahbtL5bkAvsIK2mROkA=; b=ALwBxRoNLaUVojdxu1UguTgJFEO/82SZFhkbgYEuonAQegmTYzNFfsRNgj6/ZT+Awt vSjyx55OfaySiDO8ebcX2PhLzpDQGFCCho3P/uPLnwZtBp/YTrKrOrUm4/4q0NQefk4S LfAXU+3oyS0do27wY18gbjge/cVfM8d27+dP7A/ZPV3rPVS4cFhvlvx2qGdz1WeXRW7L SZ/djoWj/kvENVc8jGiWNz1C9BlYw7XbgvrCkWoZdTlkEQJyUzZJn+vAOf7Raf2p6QSR EfI/DsoiRkf0xrgCrRNT2Da9yRHnJXLCl8jRkKppUVYAdaz1YBisZl5C0wFK/CcDFHKY vlLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z6NMdJmJY0918lK7MEwP90+HahbtL5bkAvsIK2mROkA=; b=4fA6o1nQydvYzZTAXAE67lvDgS1T/rHWi8TvC9m8Lii3+/SZQPJJ+V+qDSk0RozUed jC0JMy6rBr7i5qoehZCppePmjAdjmn0bu+b5aL1XP6H6T5e0FzrZNElO/Xb3u8knfALv wOlhcfoodxT8yuZ4qvC1FSXjZY4xhSH4n5fkxssrfAi/bR7fDRE09A0qX/gAirLFdi4L UZgqxnm3d5tSKsMgGcQq2vcI728Gd/pJXDECxWRbau8LmrHQExvWXJ6+2AmQ+Q6DhBSP aUVANv8z9sHsGyAkAk7C7wh4zGm8ZRqnB81495SfKVKyn7qwslsQCiu64L124fROpreW yqtw== X-Gm-Message-State: AOAM533HEsVI/Ouyx/8US5+WS0f2JWLUBa9bsxOGucO3vTXpa/kjAzRj pgXvAPWXodvzezeKVsnrr5jwWmakUkU= X-Google-Smtp-Source: ABdhPJy/hpy/QZlbs/qzPqVwNjr+5RZEo6fmAPgo+WXiKx1V4audpzhkpeR32y92eA/k8WW86Plb2g== X-Received: by 2002:a05:6830:60a:: with SMTP id w10mr3376814oti.111.1642784138528; Fri, 21 Jan 2022 08:55:38 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:38 -0800 (PST) From: Luiz Sampaio To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-usb@vger.kernel.org Subject: [PATCH 23/31] usb: core: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:28 -0300 Message-Id: <20220121165436.30956-24-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/usb/core/ledtrig-usbport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/core/ledtrig-usbport.c b/drivers/usb/core/ledtrig-= usbport.c index ba371a24ff78..85fa5699bb3d 100644 --- a/drivers/usb/core/ledtrig-usbport.c +++ b/drivers/usb/core/ledtrig-usbport.c @@ -73,7 +73,7 @@ static void usbport_trig_update_count(struct usbport_trig= _data *usbport_data) =20 usbport_data->count =3D 0; usb_for_each_dev(usbport_data, usbport_trig_usb_dev_check); - led_set_brightness(led_cdev, usbport_data->count ? LED_FULL : LED_OFF); + led_set_brightness(led_cdev, usbport_data->count ? 255 : 0); } =20 /*************************************** @@ -287,12 +287,12 @@ static int usbport_trig_notify(struct notifier_block = *nb, unsigned long action, case USB_DEVICE_ADD: usbport_trig_add_usb_dev_ports(usb_dev, usbport_data); if (observed && usbport_data->count++ =3D=3D 0) - led_set_brightness(led_cdev, LED_FULL); + led_set_brightness(led_cdev, 255); return NOTIFY_OK; case USB_DEVICE_REMOVE: usbport_trig_remove_usb_dev_ports(usbport_data, usb_dev); if (observed && --usbport_data->count =3D=3D 0) - led_set_brightness(led_cdev, LED_OFF); + led_set_brightness(led_cdev, 0); return NOTIFY_OK; } =20 --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6766C433EF for ; Fri, 21 Jan 2022 16:57:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381568AbiAUQ5j (ORCPT ); Fri, 21 Jan 2022 11:57:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380207AbiAUQ45 (ORCPT ); Fri, 21 Jan 2022 11:56:57 -0500 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 979CBC061770; Fri, 21 Jan 2022 08:55:42 -0800 (PST) Received: by mail-oi1-x22f.google.com with SMTP id x193so14466068oix.0; Fri, 21 Jan 2022 08:55:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EONUWJiGBiFmk1iJqYCT7v73PWb5tLXI9z7AYQ153+I=; b=aad+fr6w46RiyYwIGj0bv9tlmUENIOrZQpszpW75bDcFiMmDEQ7MA3A3+vn7o/1SZi uthe990vX/MVBrA4EkUn9GYzFohlQQu/TZ0SRqkRs7Njk0/NqPfPeW2F4on/rzC56k05 OrUJO8V20q/mAxbJTiWQWN7bgsQEEUPrzJiwMrW7KO7db+WiHBjbhe4IXzJJ1jXeDw/Q nK7iNU5uj9N5T6NfJFOnzA7Fj6lUGXHMONlcUDOCs7yWBNbMiGuhPzBGzMJ6/16e/yrR fl1kmqXIU10sQxaWdeDTrOQs9A4ZOA1awpk8APv8Hx8WS9QU39kXTOs4PSKN56ASEYrh qiOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EONUWJiGBiFmk1iJqYCT7v73PWb5tLXI9z7AYQ153+I=; b=oPv9jWCkB3mLxZSb5vhypqxgoViud6X7ZsANYdn+LSW0RJQTgcj+7tAYRFRHhdV691 OWLJ9CqU3dG+rZcZ9NJhiwC6/Bd7daJnlrPAKWfgzpR2Yne/JfjTA4qmu+NUwB+3l1vU 09YbOZMMOpe1PxXzgX525io5VwbSswb6I7NzK41wKLYZYiAYi06PyxCHa87Vb+6AEEJh gI4NPiT22nNaO5oNX0kkQRvVxu7bK0i7AirE2jF7frNZh/v+R0KiZbj4xOEh926Ay/rz Cxvw332D+yXlqLubfukdSq0QHkLz6PBNi+LAsLax/JyQJwDLjv/ADoPnJAukXVVFvcoY M9Hw== X-Gm-Message-State: AOAM532cCKDkxs/eYEBOPLZX+4w8Kn8U+jfCSbpD41UaDJCl67k0FJhn 4sX1agwvR9gxHERkUb+dq/8= X-Google-Smtp-Source: ABdhPJw5RZlemfgOZ2JSxB+h74JPNrnYn7EOQ34SHJ6/u2NPq0tcb7c4dwH4t5xwlLqRqvJClr2EJg== X-Received: by 2002:a54:4198:: with SMTP id 24mr1225683oiy.21.1642784142081; Fri, 21 Jan 2022 08:55:42 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:41 -0800 (PST) From: Luiz Sampaio To: Michael Hennerich , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 24/31] video: backlight: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:29 -0300 Message-Id: <20220121165436.30956-25-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. Reviewed-by: Daniel Thompson Reviewed-by: as an Acked-by: ;-) ! --- drivers/video/backlight/adp8860_bl.c | 4 ++-- drivers/video/backlight/adp8870_bl.c | 4 ++-- drivers/video/backlight/led_bl.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight= /adp8860_bl.c index 8ec19425671f..063be4189e7e 100644 --- a/drivers/video/backlight/adp8860_bl.c +++ b/drivers/video/backlight/adp8860_bl.c @@ -261,10 +261,10 @@ static int adp8860_led_probe(struct i2c_client *clien= t) led_dat->cdev.name =3D cur_led->name; led_dat->cdev.default_trigger =3D cur_led->default_trigger; led_dat->cdev.brightness_set =3D adp8860_led_set; - led_dat->cdev.brightness =3D LED_OFF; + led_dat->cdev.brightness =3D 0; led_dat->flags =3D cur_led->flags >> FLAG_OFFT_SHIFT; led_dat->client =3D client; - led_dat->new_brightness =3D LED_OFF; + led_dat->new_brightness =3D 0; INIT_WORK(&led_dat->work, adp8860_led_work); =20 ret =3D led_classdev_register(&client->dev, &led_dat->cdev); diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight= /adp8870_bl.c index 8b5213a39527..b04faf8d631d 100644 --- a/drivers/video/backlight/adp8870_bl.c +++ b/drivers/video/backlight/adp8870_bl.c @@ -287,10 +287,10 @@ static int adp8870_led_probe(struct i2c_client *clien= t) led_dat->cdev.name =3D cur_led->name; led_dat->cdev.default_trigger =3D cur_led->default_trigger; led_dat->cdev.brightness_set =3D adp8870_led_set; - led_dat->cdev.brightness =3D LED_OFF; + led_dat->cdev.brightness =3D 0; led_dat->flags =3D cur_led->flags >> FLAG_OFFT_SHIFT; led_dat->client =3D client; - led_dat->new_brightness =3D LED_OFF; + led_dat->new_brightness =3D 0; INIT_WORK(&led_dat->work, adp8870_led_work); =20 ret =3D led_classdev_register(&client->dev, &led_dat->cdev); diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led= _bl.c index f54d256e2d54..1b869624b4f8 100644 --- a/drivers/video/backlight/led_bl.c +++ b/drivers/video/backlight/led_bl.c @@ -46,7 +46,7 @@ static void led_bl_power_off(struct led_bl_data *priv) return; =20 for (i =3D 0; i < priv->nb_leds; i++) - led_set_brightness(priv->leds[i], LED_OFF); + led_set_brightness(priv->leds[i], 0); =20 priv->enabled =3D false; } --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C17DEC433FE for ; Fri, 21 Jan 2022 16:57:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381896AbiAUQ5h (ORCPT ); Fri, 21 Jan 2022 11:57:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380315AbiAUQ45 (ORCPT ); Fri, 21 Jan 2022 11:56:57 -0500 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13ED6C061772; Fri, 21 Jan 2022 08:55:45 -0800 (PST) Received: by mail-oi1-x231.google.com with SMTP id e81so14365960oia.6; Fri, 21 Jan 2022 08:55:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lfG5LLChWvRNdV9wVnldjwvOnVKmO3qiE7tQP9HKM08=; b=aW+lLvcniNVbrserfJPdMCLN+pjYIGdCJyovb01N9B356oX9NqLNjrEKpWRJypyk3G dhj4n3KX5qWKuXWdzY3XY1jKasWd4F6312ewviRlgL18S0j6Y+7LI4UwnLQqRGULGS1s dKrLEncGyDf5b/5ZQn81LzlEutk3qyhaYpInHqTzuJpyrdjtujD28LGSCfuVQXBz0nw/ 3j4OTSnLnUHGb8KX7UIDr4KG2raMwMNoJ4smKXRLBmNNuuyUiY/ifk58w5lDAX3ok+j1 P0WmbqetCG/0NkSLF5hUPg2XjJ0lX/oS9w0N3UtacNfcmxnakpE4vG9VDgfVwsIraKOB iT8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lfG5LLChWvRNdV9wVnldjwvOnVKmO3qiE7tQP9HKM08=; b=QB8aCx2K55ZfBqRo9Yev6JyM225d3phdGjyUydmFsDfhpY+Vg6AAFJkrgYymUzhF8F Fsi6/eao0wCKDH+VQQsasPa1SsKLSE4ExGi1we0kc/mnAcNX8zKcHPMQgR5fcH14v43Q 2evdyhQdoOU/6h0r0g13IfU6Jt1gQQSmKaEGwipd3mDgBAUlG33/U5lIv5Re/HXyGyWH exGx7NADs6CA6gOZJdpYmbauVDNjm8l3rBtgY2dvUc9pqAGm9YbfaUpHIIF12jI3R2r6 DuNvfBPqTPrOaNpyHvZjJgKmPAmFGKidIu3COdzrIhCvtK0NpYeGT7n7SurSAjS5ciWw TWAA== X-Gm-Message-State: AOAM531AboBVnQzOEoIw+6ydYIfEcpvZS1mOoEzMkdzKVjZSGq95bFSD IVgs10ui3g+dbG/38L1BopsPPW5d3hw= X-Google-Smtp-Source: ABdhPJyrJQEbFXhs9KtvBf+u6DpwUM4N/tZ43aXtQP893w84s/JggZSo1F8pUf7m1CvR0hfopANpZg== X-Received: by 2002:a05:6808:1824:: with SMTP id bh36mr1239215oib.142.1642784144544; Fri, 21 Jan 2022 08:55:44 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:44 -0800 (PST) From: Luiz Sampaio To: Pavel Machek Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-leds@vger.kernel.org Subject: [PATCH 25/31] include: linux: leds: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:30 -0300 Message-Id: <20220121165436.30956-26-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- include/linux/leds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/leds.h b/include/linux/leds.h index ba4861ec73d3..814541e41ce0 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -597,7 +597,7 @@ void ledtrig_audio_set(enum led_audio type, enum led_br= ightness state); #else static inline enum led_brightness ledtrig_audio_get(enum led_audio type) { - return LED_OFF; + return 0; } static inline void ledtrig_audio_set(enum led_audio type, enum led_brightness state) --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A17AAC433F5 for ; Fri, 21 Jan 2022 16:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379301AbiAUQ5m (ORCPT ); Fri, 21 Jan 2022 11:57:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380343AbiAUQ44 (ORCPT ); Fri, 21 Jan 2022 11:56:56 -0500 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81043C061773; Fri, 21 Jan 2022 08:55:48 -0800 (PST) Received: by mail-oi1-x22f.google.com with SMTP id bb37so14392661oib.1; Fri, 21 Jan 2022 08:55:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/hFEnKfQJiIAaQ2mjd4rxrXqXcThyAji37idZyhsBAY=; b=HEDrhGVj7yfZqvkjCw8k1/FNEXYzOGPmv9dNN2Hn6Ih3y+FbsyD2K4jPUpYbNauJT8 bhUbA4IVknUbh6oM8nQDN5aFYvnp1bOdR0zYfUmbmVsSTNpmSF+ydgzjS2IjIvPFwvOi wm5++I3D8YKAJmsKDWrCqlQBb21YPA7Z0xNV/ft/YJNfpkRdkRTm3j2l3quXGaU2npIV qgGxPa2AU2MyfCpmiy+eBEn6LQ+z89Kp3A8rlk7IcSJCOA3XTiiSHqGWRCR4V1McJOKW 1L+0wi/MNWYT1AuruOViuur8pCfx+lF/oFLKZH6fHOCNEZbY1AHof/Dlsq16lwsVaZUh r9bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/hFEnKfQJiIAaQ2mjd4rxrXqXcThyAji37idZyhsBAY=; b=LD/ZRy5MlWFyv4U850/TZ/BlHnADzbQUmrAn5Vwa6GedMbqdfRPWrLcHSbpou/bVvb 7qKIek8LORHeBtbRIf4KtkvgHkG61FqfQ0teUWxabOASx5yh+3DytZNZ+vQmk/Mq8PXG OUqoySn5+SgqyKWTCg7+5bAzQwPDFtDWE3zN7ZgQROiXSqgmVLcN4jC7vQhSq3pZOJ8g 7tL7ASlFT1/c8cv0EcJHUlHgkd/NMbvg5mS+sivLTrexBxu+kyxQ6U0LLzZPvO5HAbZc qU7JNADXRpAhvkWtQnjQsxhLxX3Jv70ew06UQ/1B+LtNy3Jm07YF3OTXAowLfH526Ry+ pPlA== X-Gm-Message-State: AOAM532u1f+O5Y9zPiYTKfoPwN7PRhxDeXghqds6Maqrr9WaQRPVbgzt BPmBNKNRugxp8B8E40n+S0E= X-Google-Smtp-Source: ABdhPJxuroa+LmFuxwX8sb8C/C6iB0kFXUlik7h0Gj12vxUub1iXO+HFMA6PEGE12EVI32ETMI7pNg== X-Received: by 2002:a05:6808:1147:: with SMTP id u7mr1261723oiu.117.1642784147933; Fri, 21 Jan 2022 08:55:47 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:47 -0800 (PST) From: Luiz Sampaio To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , "David S. Miller" , Jakub Kicinski Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 26/31] net: bluetooth: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:31 -0300 Message-Id: <20220121165436.30956-27-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- net/bluetooth/leds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bluetooth/leds.c b/net/bluetooth/leds.c index f46847632ffa..7f7e3eed9407 100644 --- a/net/bluetooth/leds.c +++ b/net/bluetooth/leds.c @@ -22,7 +22,7 @@ void hci_leds_update_powered(struct hci_dev *hdev, bool e= nabled) { if (hdev->power_led) led_trigger_event(hdev->power_led, - enabled ? LED_FULL : LED_OFF); + enabled ? 255 : 0); =20 if (!enabled) { struct hci_dev *d; @@ -37,7 +37,7 @@ void hci_leds_update_powered(struct hci_dev *hdev, bool e= nabled) read_unlock(&hci_dev_list_lock); } =20 - led_trigger_event(bt_power_led_trigger, enabled ? LED_FULL : LED_OFF); + led_trigger_event(bt_power_led_trigger, enabled ? 255 : 0); } =20 static int power_activate(struct led_classdev *led_cdev) @@ -48,7 +48,7 @@ static int power_activate(struct led_classdev *led_cdev) htrig =3D to_hci_basic_led_trigger(led_cdev->trigger); powered =3D test_bit(HCI_UP, &htrig->hdev->flags); =20 - led_trigger_event(led_cdev->trigger, powered ? LED_FULL : LED_OFF); + led_trigger_event(led_cdev->trigger, powered ? 255 : 0); =20 return 0; } --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD1BC43219 for ; Fri, 21 Jan 2022 16:57:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381957AbiAUQ5r (ORCPT ); Fri, 21 Jan 2022 11:57:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380350AbiAUQ44 (ORCPT ); Fri, 21 Jan 2022 11:56:56 -0500 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BE6CC061775; Fri, 21 Jan 2022 08:55:51 -0800 (PST) Received: by mail-oi1-x22a.google.com with SMTP id s9so14319296oib.11; Fri, 21 Jan 2022 08:55:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JWwCA6Os6ufO2OamoDdA1VpkWXg1qWYv/gpuXYzvEa0=; b=MjAl/2d7hFcNgyCHuaDhSHTjyebU3drd8M3jU8y2IQsqE6Okaz0WRef5nk97QClDqB dvRMz5ydDfyCVO7XtDrt7BlmMK8yIEirVQKVXa4Ab0p+oKDAgX92r7pE+hkI77CSUetS MH/DYXn1WvTkPKI+tE5gsImAWrq+f6bwAihvF9Zrbyyajq/ZWrGOG31AcvN0xvHHsQ/a 76Zbei7//5h/FF2ZDZo4d56PGsZXeyiJsEbzfQNDCrF7XS9IcXprwm/icw8/L0rshHl1 SNFx7oImgsZ6tDJvJDrHND4vFRrTq7IlAxO8d9ISxYF3yqUI1B4MhMf2hN48A52BFZM4 0oSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JWwCA6Os6ufO2OamoDdA1VpkWXg1qWYv/gpuXYzvEa0=; b=PxZNcHG/qr/KxQvSQ1Z9i/Ov/3ZWXQQV57z6Hde1O73TuAe56EUWAIHv+/D4NSLYxH gF/MOXhjuzR3vrTETsC9D3rbz9FC/IG0EswFyqKE1wnVgqT8MZxbXlh5pt7kS35q46Az hC/zNMnZmvNm5+zl4MBWgmZG1PfPxThqIUynx7fq31dWXf49PYxkjxsQre9tubgCmVwd XWN45CZ5h7TlJdOIu8XSQYIOJtDbRuYCrSVW7BtOb/Z7hZpqocefiQCkAj1q0JVz6tBq yYJwNKToy60bjwXNxee7ORLWfkAt56c1QhVd6SUTudwJ4ETv2tLm8NcBtMvEZIQChkaP LnBQ== X-Gm-Message-State: AOAM530DTZW9qPeXPJHeZmcgvj4F48d0hh8/+HtBjC8ID8AA9Xs3bUro ViGcXU20Mrstl/VKD7oQ1t0= X-Google-Smtp-Source: ABdhPJy/+XAmfEonekRvbRYH2yUx5daOlccr8uacmMOv+0HVuWMPQYm2UMLY4TsXH0dx9xykQjzivA== X-Received: by 2002:a05:6808:1442:: with SMTP id x2mr1217003oiv.166.1642784150774; Fri, 21 Jan 2022 08:55:50 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:50 -0800 (PST) From: Luiz Sampaio To: Johannes Berg , "David S. Miller" , Jakub Kicinski Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 27/31] net: mac80211 : changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:32 -0300 Message-Id: <20220121165436.30956-28-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- net/mac80211/led.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/mac80211/led.c b/net/mac80211/led.c index 6de8d0ad5497..ac36579636bb 100644 --- a/net/mac80211/led.c +++ b/net/mac80211/led.c @@ -14,9 +14,9 @@ void ieee80211_led_assoc(struct ieee80211_local *local, b= ool associated) if (!atomic_read(&local->assoc_led_active)) return; if (associated) - led_trigger_event(&local->assoc_led, LED_FULL); + led_trigger_event(&local->assoc_led, 255); else - led_trigger_event(&local->assoc_led, LED_OFF); + led_trigger_event(&local->assoc_led, 0); } =20 void ieee80211_led_radio(struct ieee80211_local *local, bool enabled) @@ -24,9 +24,9 @@ void ieee80211_led_radio(struct ieee80211_local *local, b= ool enabled) if (!atomic_read(&local->radio_led_active)) return; if (enabled) - led_trigger_event(&local->radio_led, LED_FULL); + led_trigger_event(&local->radio_led, 255); else - led_trigger_event(&local->radio_led, LED_OFF); + led_trigger_event(&local->radio_led, 0); } =20 void ieee80211_alloc_led_names(struct ieee80211_local *local) @@ -344,7 +344,7 @@ static void ieee80211_stop_tpt_led_trig(struct ieee8021= 1_local *local) tpt_trig->running =3D false; del_timer_sync(&tpt_trig->timer); =20 - led_trigger_event(&local->tpt_led, LED_OFF); + led_trigger_event(&local->tpt_led, 0); } =20 void ieee80211_mod_tpt_led_trig(struct ieee80211_local *local, --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F537C433F5 for ; Fri, 21 Jan 2022 16:57:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381849AbiAUQ5Y (ORCPT ); Fri, 21 Jan 2022 11:57:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380361AbiAUQ46 (ORCPT ); Fri, 21 Jan 2022 11:56:58 -0500 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BA4DC061778; Fri, 21 Jan 2022 08:55:55 -0800 (PST) Received: by mail-oi1-x22e.google.com with SMTP id s127so14386942oig.2; Fri, 21 Jan 2022 08:55:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X1prsGZ36V3LEOTvvkMgk2CqZfwnDb5j2wczkknGbpY=; b=M7T75cltulYZ8dLhgYXj6Dqlc+gxskyEj1qidzGRzta8A7Ws3Zr9QSTdP2w/UtNCH7 1QfX8VMaNiOeO+aJ43N06CEVr1qHaj21QOWCh66A0Szq1y/o6Oho0NI9zlUO9u8pGT59 EtP8QRnBXkMWCZlGNXKyV/jcv7iIlxRmyq2P2drG6x93IlqH8s6xSoTS+N5MiAShuOnK SlwWVtPdq0Td7Ppi3b0Y9dJHAl1tIlUGE7SGv5WstOM27x3MWNCgph2FW0eLWUqoCkHb AHjTTNndE/ulSBROV/tV651tAmVP3ndCfgP7y8g9poS1Z2rpgmJo+BmCTYa/riabA7NJ VVwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X1prsGZ36V3LEOTvvkMgk2CqZfwnDb5j2wczkknGbpY=; b=pqq4I2WsK6LMCR52KFx3dYLimgloQDgMER59HG7/85zl9r0CumgBCR9XpWGYnxW04M +LXHBkyU9no/epRg0UwbBmX2Osw93MMJQRUMJA22mQdry/HoFo/10nklRvmIHk8DQTVK MYQXYzldlvZfHMkXSufHv172uwqOBuSIfZSPKcvPfw4OJwTflqLTsgx4jhQMkPqDmKeo 13dGJNjInHukhacbSnjanQLzhdAfdrWBqBDmUtafm9gxX2HnWHEgucQG/eaKoIpcdO2J R8CAQhyFE9S9MLmdH/L+lCjSjfjZc2sgCKFTDTXlvRp10aY2dG0sXts4C7sYofjx5cwM bKeQ== X-Gm-Message-State: AOAM532XaQykolbg6b6pXgEVh8HrGOJxLnrIJJV+/+RYZE6QvLO7WPzY EMrGlN6Jl2ST5Z9P6i1Adm0= X-Google-Smtp-Source: ABdhPJz8BK3W/Oh4kBRyv2FuNLqsoZfq+UPcczheQf1w5dq3RrySWoTvNPIRVTRDXq4pSGHlxozTVA== X-Received: by 2002:a54:4097:: with SMTP id i23mr1255843oii.115.1642784154379; Fri, 21 Jan 2022 08:55:54 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:54 -0800 (PST) From: Luiz Sampaio To: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org Subject: [PATCH 28/31] net: netfilter: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:33 -0300 Message-Id: <20220121165436.30956-29-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- net/netfilter/xt_LED.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/netfilter/xt_LED.c b/net/netfilter/xt_LED.c index 0371c387b0d1..eb66e12c7ff7 100644 --- a/net/netfilter/xt_LED.c +++ b/net/netfilter/xt_LED.c @@ -54,7 +54,7 @@ led_tg(struct sk_buff *skb, const struct xt_action_param = *par) led_trigger_blink_oneshot(&ledinternal->netfilter_led_trigger, &led_delay, &led_delay, 1); else - led_trigger_event(&ledinternal->netfilter_led_trigger, LED_FULL); + led_trigger_event(&ledinternal->netfilter_led_trigger, 255); =20 /* If there's a positive delay, start/update the timer */ if (ledinfo->delay > 0) { @@ -63,7 +63,7 @@ led_tg(struct sk_buff *skb, const struct xt_action_param = *par) =20 /* Otherwise if there was no delay given, blink as fast as possible */ } else if (ledinfo->delay =3D=3D 0) { - led_trigger_event(&ledinternal->netfilter_led_trigger, LED_OFF); + led_trigger_event(&ledinternal->netfilter_led_trigger, 0); } =20 /* else the delay is negative, which means switch on and stay on */ @@ -76,7 +76,7 @@ static void led_timeout_callback(struct timer_list *t) struct xt_led_info_internal *ledinternal =3D from_timer(ledinternal, t, timer); =20 - led_trigger_event(&ledinternal->netfilter_led_trigger, LED_OFF); + led_trigger_event(&ledinternal->netfilter_led_trigger, 0); } =20 static struct xt_led_info_internal *led_trigger_lookup(const char *name) --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B215DC433EF for ; Fri, 21 Jan 2022 16:57:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243916AbiAUQ5e (ORCPT ); Fri, 21 Jan 2022 11:57:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379719AbiAUQ46 (ORCPT ); Fri, 21 Jan 2022 11:56:58 -0500 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 092DFC061779; Fri, 21 Jan 2022 08:55:58 -0800 (PST) Received: by mail-ot1-x336.google.com with SMTP id a12-20020a0568301dcc00b005919e149b4cso12496259otj.8; Fri, 21 Jan 2022 08:55:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=si2C+vA2MagtGvM7KQVl7R4c/GkdTJnQxP83OLRcJVk=; b=UQGLTtt5LSEMTK67FS1ihHCiUCpYDCH9lpQphiGsNhgiy4hAmw4ejccESomUBNnmB/ aYQ+4LcEArvrDIG0KkSm+4Ai3oIf2AnPCZ0KVnCMpAPm6NmRJ/V03BR5V/c4yIjI3kSu sf6hDb0a5KoXclLLT2u8NhgaTaHM4G9x5Lf3cyL3IBsm9HRi8O4LZ3+tvWjCf5BpyHa6 tU4u/eRjs08GGNLHGtmpGMVnxgQAQF8uuASICG2GeIA2YhrzNxE2VccrdIUVKCESgwuU PYiTQH7jFNvJ3TyAuWIk3er2Op6E1kVZTdCJ/oh+lDvRopzfcAndcm2pPBfLGRlGJea9 iWwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=si2C+vA2MagtGvM7KQVl7R4c/GkdTJnQxP83OLRcJVk=; b=TF8vtws4ovSk2Ph1+ialGaKJTCekWhIt7+A+Ez/PYTh8h6q93Fjr9Mp8j3u4fnyglg WutzMcXr7NZ32CAFDYlDu46yNu9nQ8ZNdYlZy8w+hV3iaX+125QB0wfEYbyn5vh8xXpc eCm/iftbiEkV6AYgbxpX5R8iQhWbAVLxzzq5W/gR/r6YC7iCTR2FpG3OgDeMuuJs+iTV wUYofeQkRiK4AsglCypFopW8zvUHBbPe2w60jL3oIMWcpNhBMmzBRZYrkNrOCSF68Fvo KblIIFnMN1f+KGhzMlIJlMINIMXAdmztRHxYVWUImyqHB54ZlFp8IlV/ROsk+c/vN/+g c8sg== X-Gm-Message-State: AOAM5323k6zYq7sQm0gwr66qpBeIFkQ4sDi3Gp61XtyfYU/kbEJkSXsb UKhICewCqFVShGR7xRMSLsA= X-Google-Smtp-Source: ABdhPJx1jT0kqIhJYUFQF5ZtfKDl8S9daCIITgVVP8nCR1xY42JaZ2RR+AijgO/vDQjpBB6+OFVyIA== X-Received: by 2002:a05:6830:1047:: with SMTP id b7mr3287296otp.197.1642784157446; Fri, 21 Jan 2022 08:55:57 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:57 -0800 (PST) From: Luiz Sampaio To: Johannes Berg , "David S. Miller" , Jakub Kicinski Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 29/31] net: rfkill: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:34 -0300 Message-Id: <20220121165436.30956-30-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- net/rfkill/core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/rfkill/core.c b/net/rfkill/core.c index 5b1927d66f0d..68b4c3a71513 100644 --- a/net/rfkill/core.c +++ b/net/rfkill/core.c @@ -125,9 +125,9 @@ static void rfkill_led_trigger_event(struct rfkill *rfk= ill) trigger =3D &rfkill->led_trigger; =20 if (rfkill->state & RFKILL_BLOCK_ANY) - led_trigger_event(trigger, LED_OFF); + led_trigger_event(trigger, 0); else - led_trigger_event(trigger, LED_FULL); + led_trigger_event(trigger, 255); } =20 static int rfkill_led_trigger_activate(struct led_classdev *led) @@ -180,7 +180,7 @@ static void rfkill_global_led_trigger_worker(struct wor= k_struct *work) mutex_lock(&rfkill_global_mutex); list_for_each_entry(rfkill, &rfkill_list, node) { if (!(rfkill->state & RFKILL_BLOCK_ANY)) { - brightness =3D LED_FULL; + brightness =3D 255; break; } } @@ -188,7 +188,7 @@ static void rfkill_global_led_trigger_worker(struct wor= k_struct *work) =20 led_trigger_event(&rfkill_any_led_trigger, brightness); led_trigger_event(&rfkill_none_led_trigger, - brightness =3D=3D LED_OFF ? LED_FULL : LED_OFF); + brightness =3D=3D 0 ? 255 : 0); } =20 static void rfkill_global_led_trigger_event(void) --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02CA2C4332F for ; Fri, 21 Jan 2022 16:57:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381829AbiAUQ5W (ORCPT ); Fri, 21 Jan 2022 11:57:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380405AbiAUQ46 (ORCPT ); Fri, 21 Jan 2022 11:56:58 -0500 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97C4CC06177A for ; Fri, 21 Jan 2022 08:56:00 -0800 (PST) Received: by mail-ot1-x334.google.com with SMTP id m8-20020a9d4c88000000b00592bae7944bso12545890otf.1 for ; Fri, 21 Jan 2022 08:56:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yPhrE44c4X8EiRps7ZyTdjyC/DhZv0Ym7BaWgxIimP4=; b=P+o+RNbzvnvNZw8S93pq9pgBsfdPWaqUB/OAudqOSe9NOlR3YP4b+RsIyZanHpa4FA DPxznSbqJcND87IBpj0udvG60BW2fqsIH7xiHOwBMm2/yNJEA/3sv3B+ClO28zVLlyfT Gyq/v/1lDk/iv8tCDRKQmMjYSC9CyEYo1BavdreIiWR21N/KDYDW2H4p9mHMBcy3Q2fs cxj/O9hAzSnuXFCc05MShi+3F8F0majPBKW3G1hVGFNYPdO7HEQekJz5m0MVgdm86fgj 9YTOmo+ecrfdy4UggOG/2IXM+kC9erCkAMdNCCebhMr1IqtUzzZO2xs2MCjGg2Crdqsb dpZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yPhrE44c4X8EiRps7ZyTdjyC/DhZv0Ym7BaWgxIimP4=; b=WSJBYnS3VtgiT/hFQGq4ef/c14aYZbT7YocBzEylTwcpDDlYX6rC6Q54Z14/L6X/TI PwksDiaaHrAVHnMKWcxb5dFlNTnUk6500S9dIh2+EwFOcwFCM6ugIKPMuWuv5etNDeVx MtJmC2ssCv4JNF7UrNeWHI6lJ3+fGkrWvbux7uYOKaU3jY4T4mBs0NZF1ZTvFbSJn4N4 608vbzm1duuGEbDH0uMBo6roRiORKn+8tz/6Df5Zz8iyxqLaLNG2ElSVagd2na1FDoU/ +As8stGle5QHL7DBTqEtRW0RycQFfUDZ5OKvzUMqQqc/aYQmYEITZJOXw+rEf7DnpkCc Ai3Q== X-Gm-Message-State: AOAM5318N1wTpOtwL7LZE8gEI+DgpHtTsXi/s0bQgeocnj0A0pKgM/Tf gwTjheEKes5tRslfWsTqCbw= X-Google-Smtp-Source: ABdhPJyHMKAh1594d9L9b4cHpehF1tSuCMmjKBl93/j+Ribj0RM1jbdudMygzgJ8Aqvl8jZjcB1NDg== X-Received: by 2002:a05:6830:905:: with SMTP id v5mr3330424ott.143.1642784160014; Fri, 21 Jan 2022 08:56:00 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:55:59 -0800 (PST) From: Luiz Sampaio To: Jaroslav Kysela , Takashi Iwai Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , alsa-devel@alsa-project.org Subject: [PATCH 30/31] sound: core: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:35 -0300 Message-Id: <20220121165436.30956-31-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- sound/core/control_led.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/control_led.c b/sound/core/control_led.c index 207828f30983..ddfac2f5f59e 100644 --- a/sound/core/control_led.c +++ b/sound/core/control_led.c @@ -177,7 +177,7 @@ static void snd_ctl_led_set_state(struct snd_card *card= , unsigned int access, case MODE_FOLLOW_MUTE: /* noop */ break; } if (route >=3D 0) - ledtrig_audio_set(led->trigger_type, route ? LED_OFF : LED_ON); + ledtrig_audio_set(led->trigger_type, route ? 0 : 1); } =20 static struct snd_ctl_led_ctl *snd_ctl_led_find(struct snd_kcontrol *kctl,= unsigned int ioff) --=20 2.34.1 From nobody Tue Jun 30 08:15:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B6FC433F5 for ; Fri, 21 Jan 2022 16:57:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344702AbiAUQ5a (ORCPT ); Fri, 21 Jan 2022 11:57:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380449AbiAUQ46 (ORCPT ); Fri, 21 Jan 2022 11:56:58 -0500 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7B1BC06177C for ; Fri, 21 Jan 2022 08:56:04 -0800 (PST) Received: by mail-ot1-x32e.google.com with SMTP id n22-20020a9d2016000000b0059bd79f7777so12089606ota.2 for ; Fri, 21 Jan 2022 08:56:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OJAPsXsyMyStdrgiiG/42UEEzPqRzVav9xb3OpyRVHQ=; b=Twc9JkSiDP8VFRJqzluEaW2Z+2+GsDobGXcC4mRcD907KrgRdR7biXOtGDPPZ2UBWt SPMO43Mn+NBkptudLVDrRUTuJPwBucOHSQvFhxsq2Tf7rxv8Qs8gegVEYIJ5nXRbv8uQ x9Z2CA/QUQmuSwk7MhgPz/pdOBc9invJxmtmwXQBb5fjr1FWY/BqXLqFTgcGCvKfPjyH RDA6E5h78KUKRRB/ZI+IbfQHiEh6q55IMcPdqQYJD4jzqlu50WlCa1PLLmJQlwOMncv3 nrku0yGN4/fMx3DFztsEOuLHsE0Vuq7C4jRLm6GufgYAYvmaOg5563KJ1tass8i47vFZ +xpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OJAPsXsyMyStdrgiiG/42UEEzPqRzVav9xb3OpyRVHQ=; b=gykTHJNNvNOcN2NMvyI0C4FC5Mj8Mh+kzDWmIVm//98Xi7SUyPV4abVZF9irf9BLH+ oqGkK96NCzezuMsc78+GPb70HFmVvDkwbGmXk6b426DQjwnVoqttNPUwVpqpOoO5wZxa 6KIr0sSTQudCej4zdEWoHMeoaxyA3pOqwVMAZzK3Mf7kcRZSYpkMAjYdnb0+ds+6lOgl h3FRj7XQaHeltUyfVbybl7Xss6GFtt+UtpU93DeL/ubmH9cHGF6g4GojXW7DhD1oq9XU Hx8cpmDtTz4wgRhiJ1eAjVBla88Hg4EpncIRh6GeXY2rQ825DleUrsKB4lX184u6OS4b 7yNg== X-Gm-Message-State: AOAM531ylhE1UaTkPkuxJjSLb34ucejSFJ05suGVxgdxl9TRtX2nAmbs 2OtRCfUYhp2L+diBQYcazjg= X-Google-Smtp-Source: ABdhPJzeJejm8YYaXmOdZw3QExcnXsXNYn1jraBIWNvWa+5iSEwrJf3YLpi7qF8eTFUbVqtjFmtDxw== X-Received: by 2002:a9d:74d0:: with SMTP id a16mr3413937otl.47.1642784164101; Fri, 21 Jan 2022 08:56:04 -0800 (PST) Received: from thinkpad.localdomain ([2804:14d:5cd1:5d03:cf72:4317:3105:f6e5]) by smtp.gmail.com with ESMTPSA id y8sm1089271oou.23.2022.01.21.08.56.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:56:03 -0800 (PST) From: Luiz Sampaio To: Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-kernel@vger.kernel.org, Luiz Sampaio , sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org Subject: [PATCH 31/31] sound: soc: sof: changing LED_* from enum led_brightness to actual value Date: Fri, 21 Jan 2022 13:54:36 -0300 Message-Id: <20220121165436.30956-32-sampaio.ime@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com> References: <20220121165436.30956-1-sampaio.ime@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- sound/soc/sof/control.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/sof/control.c b/sound/soc/sof/control.c index ef61936dad59..02e40aef9995 100644 --- a/sound/soc/sof/control.c +++ b/sound/soc/sof/control.c @@ -39,9 +39,9 @@ static void update_mute_led(struct snd_sof_control *scont= rol, =20 #if IS_REACHABLE(CONFIG_LEDS_TRIGGER_AUDIO) if (!scontrol->led_ctl.direction) - ledtrig_audio_set(LED_AUDIO_MUTE, temp ? LED_OFF : LED_ON); + ledtrig_audio_set(LED_AUDIO_MUTE, temp ? 0 : 1); else - ledtrig_audio_set(LED_AUDIO_MICMUTE, temp ? LED_OFF : LED_ON); + ledtrig_audio_set(LED_AUDIO_MICMUTE, temp ? 0 : 1); #endif } =20 --=20 2.34.1