From nobody Tue Jun 30 09:25:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D896C433FE for ; Thu, 20 Jan 2022 19:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377413AbiATTM5 (ORCPT ); Thu, 20 Jan 2022 14:12:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236860AbiATTMz (ORCPT ); Thu, 20 Jan 2022 14:12:55 -0500 Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 026AEC061574 for ; Thu, 20 Jan 2022 11:12:55 -0800 (PST) Received: by mail-qv1-xf31.google.com with SMTP id 15so7778734qvp.12 for ; Thu, 20 Jan 2022 11:12:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=ljRHzu8EIti/rwgbKsna6fOCiQbES3TZ5TTYfFv0egw=; b=FyNEAIm/3bE5CybyyukETOQ/BQa7EhXGoW8WaHTc5aG9OMBkNDJ0v0IxBNUDBn7JcJ qY/Fi2S4h5MYwXg4pELzsxmpyzOLEYq5cf2kR4ObXgaUcpEEl2M/8hR0/838NFa4RUSh WMTlEm+f/O2OesyO8SbAkTVyfRj1k0LXXgkfmAv2CLxhI/SCnWhAEE+c+pi15uDOQIs3 ANyEOssIBASnEYRn3/chz8M8SCXLBshno7oN6a78RV+aHElzwXJ6zmpR+KJIcE4XkWl9 egN5vg3Y9WPN//dCaL2OGEjhy1+Jc4eFmdmfTmJlVB7og/sM0WoHgVXCEne2nAaG44EU S1+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ljRHzu8EIti/rwgbKsna6fOCiQbES3TZ5TTYfFv0egw=; b=drcYsaWogEGBzQBcHLIVfLjK0swGaLNYYy8We1laey86PSsVkZo1u6wxoN8RVfJoWv vuwc/PC5mgKcQP3HWthOdiXhTq1Mc4VbaCJH44EGJeADU1PL883jCpe68qVl+QjAOAA5 R2EosrQempJGIPN5qfTQaj0uU3xI/eFqXYE0VqUtNpdyRYm7vMvqGZ4yRKQ6nuSptWW9 y48zaGoE5I3TOFt2YsMPW9uSTgcRzvzSAY7HihBdM0g9ztdyvrHEl2zmQRUFGWzU3Ayd jVw00X8kj6Uab/l1OgWWoiiVRlz5E1zFQ9UB7rXid4J6yRFEM2JI1DJRXne6JQ5d2RnH /7xA== X-Gm-Message-State: AOAM53145LAWvEQwqEGke14tilw4ZUmOf88uJQFpKxxJ+1TRwopvnShQ opo/M8jeiRnEE3BC08SYMuuKAw== X-Google-Smtp-Source: ABdhPJy2i251uJu/EMC4DLi9WRnxHlaT88/Fup2DjBtaR+0+svTyX1C9lcQd1dHZttx5/jijgXaJNg== X-Received: by 2002:a05:6214:20a4:: with SMTP id 4mr384015qvd.7.1642705974062; Thu, 20 Jan 2022 11:12:54 -0800 (PST) Received: from soleen.c.googlers.com.com (189.216.85.34.bc.googleusercontent.com. [34.85.216.189]) by smtp.gmail.com with ESMTPSA id w1sm1822509qko.40.2022.01.20.11.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jan 2022 11:12:53 -0800 (PST) From: Pasha Tatashin To: pasha.tatashin@soleen.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, rientjes@google.com, pjt@google.com, weixugc@google.com, gthelen@google.com, mingo@redhat.com, will@kernel.org, rppt@kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, aneesh.kumar@linux.ibm.com, jirislaby@kernel.org, songmuchun@bytedance.com, qydwhotmail@gmail.com, hughd@google.com, ziy@nvidia.com, anshuman.khandual@arm.com Subject: [PATCH v2 1/3] mm/debug_vm_pgtable: remove pte entry from the page table Date: Thu, 20 Jan 2022 19:12:48 +0000 Message-Id: <20220120191250.2671557-2-pasha.tatashin@soleen.com> X-Mailer: git-send-email 2.34.1.703.g22d0c6ccf7-goog In-Reply-To: <20220120191250.2671557-1-pasha.tatashin@soleen.com> References: <20220120191250.2671557-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The pte entry that is used in pte_advanced_tests() is never removed from the page table at the end of the test. The issue is detected by page_table_check, to repro compile kernel with the following configs: CONFIG_DEBUG_VM_PGTABLE=3Dy CONFIG_PAGE_TABLE_CHECK=3Dy CONFIG_PAGE_TABLE_CHECK_ENFORCED=3Dy During the boot the following BUG is printed: [ 7.483050][ T1] debug_vm_pgtable: [debug_vm_pgtable ]: Validating architecture page tabs [ 7.490930][ T1] ------------[ cut here ]------------ [ 7.494926][ T1] kernel BUG at mm/page_table_check.c:194! [ 7.499172][ T1] invalid opcode: 0000 [#1] PREEMPT SMP KASAN [ 7.503610][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.16.0+ [ 7.508600][ T1] Hardware name: QEMU Standard PC (i440FX + PIIX, ... The entry should be properly removed from the page table before the page is released to the free list. Fixes: a5c3b9ffb0f4 ("mm/debug_vm_pgtable: add tests validating advanced ar= ch page table helpers") Signed-off-by: Pasha Tatashin Reviewed-by: Zi Yan Tested-by: Zi Yan --- mm/debug_vm_pgtable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index a7ac97c76762..db2abd9e415b 100644 --- a/mm/debug_vm_pgtable.c +++ b/mm/debug_vm_pgtable.c @@ -171,6 +171,8 @@ static void __init pte_advanced_tests(struct pgtable_de= bug_args *args) ptep_test_and_clear_young(args->vma, args->vaddr, args->ptep); pte =3D ptep_get(args->ptep); WARN_ON(pte_young(pte)); + + ptep_get_and_clear_full(args->mm, args->vaddr, args->ptep, 1); } =20 static void __init pte_savedwrite_tests(struct pgtable_debug_args *args) --=20 2.34.1.703.g22d0c6ccf7-goog From nobody Tue Jun 30 09:25:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0C1DC433F5 for ; Thu, 20 Jan 2022 19:12:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377420AbiATTM6 (ORCPT ); Thu, 20 Jan 2022 14:12:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377403AbiATTM4 (ORCPT ); Thu, 20 Jan 2022 14:12:56 -0500 Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E77A0C061574 for ; Thu, 20 Jan 2022 11:12:55 -0800 (PST) Received: by mail-qk1-x734.google.com with SMTP id o135so7238859qke.8 for ; Thu, 20 Jan 2022 11:12:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=zdhQ37gTy669jxm5MfPtrCEbBTPzaXPL9fEyLC9GrfM=; b=acbHonsDujIZqvIlBu3ScdQMbDpcDthc62uw0hIhKjw14Pyp0QhM65c0oAl3q/d3nA MhvzqoBFKI+lpp3Gxd/U4waC2haiFKxbEnPAA1+WgQegnl2G7ABtbgjPhiM0Yubc3lls RZ4JyHubTI2JjhzUXV480GSF/mlrgM66+dox4csGG8pxhCyHskBSuUILiW+aFs6Z0/vE 1EVm8aBeGY49R5jZ+F6qL3/5nnDfw3CStv7qHQcRLurFatHzEMioBjDmA6KZplGQmJmm uTUq6imMyxQ2KHpcE2ZXnkrPw1slvh+G9X/1Cj9pz6bApltRsHg9vk2XySBhCuy5Q9Hp qyJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zdhQ37gTy669jxm5MfPtrCEbBTPzaXPL9fEyLC9GrfM=; b=7rlDAEPg4awFtT+OK0Qn2AuJklX8PTdraHrY1sB9qDTrDUmnMUzpHjKjs6s745mUA9 04Zksnw2n71b8om0J5eZuj/Y0nuQ7M7pivOiHwTmNng+uOomutjNaPubPSARMzh97GYM Sk5lVbEpgh2GW0xM+EJw8XybcLAjv9sFiXB/f3exqnMBJm60p9lB90tMHimMgxwSwg24 bZE2f+6KsXkMvbuEdu7GDMnrEUBoIFkev/z3q21I19bvqYFh7yn4NLILxGbVqtjO1U5o xM30xq0rIi3qFKeh3kPrnxN/Mf7neHOo5SIAHgq8JWgXKyOSsIQqpSPRWyKX7T2Muj2K qY8g== X-Gm-Message-State: AOAM5315jAxD71E9XJUXzq3rejiONLVqhfxg63ZWAGT94fRkcATcK0mt xNerjyeIfMpvDV+ty8GER9foSw== X-Google-Smtp-Source: ABdhPJw8EzgzG83pHzYvqX5rdn6x63o0CAsToMH5cNIpJhgaFS0q8fMX/f6IRu2cPZtoGvh49xptxQ== X-Received: by 2002:a37:a8d6:: with SMTP id r205mr226689qke.716.1642705975032; Thu, 20 Jan 2022 11:12:55 -0800 (PST) Received: from soleen.c.googlers.com.com (189.216.85.34.bc.googleusercontent.com. [34.85.216.189]) by smtp.gmail.com with ESMTPSA id w1sm1822509qko.40.2022.01.20.11.12.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jan 2022 11:12:54 -0800 (PST) From: Pasha Tatashin To: pasha.tatashin@soleen.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, rientjes@google.com, pjt@google.com, weixugc@google.com, gthelen@google.com, mingo@redhat.com, will@kernel.org, rppt@kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, aneesh.kumar@linux.ibm.com, jirislaby@kernel.org, songmuchun@bytedance.com, qydwhotmail@gmail.com, hughd@google.com, ziy@nvidia.com, anshuman.khandual@arm.com Subject: [PATCH v2 2/3] mm/page_table_check: check entries at pud and pmd levels Date: Thu, 20 Jan 2022 19:12:49 +0000 Message-Id: <20220120191250.2671557-3-pasha.tatashin@soleen.com> X-Mailer: git-send-email 2.34.1.703.g22d0c6ccf7-goog In-Reply-To: <20220120191250.2671557-1-pasha.tatashin@soleen.com> References: <20220120191250.2671557-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" syzbot detected a case where the page table counters were not properly updated. syzkaller login: ------------[ cut here ]------------ kernel BUG at mm/page_table_check.c:162! invalid opcode: 0000 [#1] PREEMPT SMP KASAN CPU: 0 PID: 3099 Comm: pasha Not tainted 5.16.0+ #48 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIO4 RIP: 0010:__page_table_check_zero+0x159/0x1a0 Code: 7d 3a b2 ff 45 39 f5 74 2a e8 43 38 b2 ff 4d 85 e4 01 RSP: 0018:ffff888010667418 EFLAGS: 00010293 RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000000 RDX: ffff88800cea8680 RSI: ffffffff81becaf9 RDI: 0000000003 RBP: ffff888010667450 R08: 0000000000000001 R09: 0000000000 R10: ffffffff81becaab R11: 0000000000000001 R12: ffff888008 R13: 0000000000000001 R14: 0000000000000200 R15: dffffc0000 FS: 0000000000000000(0000) GS:ffff888035e00000(0000) knlG0 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007ffd875cad00 CR3: 00000000094ce000 CR4: 0000000000 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000 Call Trace: free_pcp_prepare+0x3be/0xaa0 free_unref_page+0x1c/0x650 ? trace_hardirqs_on+0x6a/0x1d0 free_compound_page+0xec/0x130 free_transhuge_page+0x1be/0x260 __put_compound_page+0x90/0xd0 release_pages+0x54c/0x1060 ? filemap_remove_folio+0x161/0x210 ? lock_downgrade+0x720/0x720 ? __put_page+0x150/0x150 ? filemap_free_folio+0x164/0x350 __pagevec_release+0x7c/0x110 shmem_undo_range+0x85e/0x1250 ... The repro involved having a huge page that is split due to uprobe event temporarily replacing one of the pages in the huge page. Later the huge page was combined again, but the counters were off, as the PTE level was not properly updated. Make sure that not only huge page but also small pages are updated when a new entry is set or cleared. Fixes: df4e817b7108 ("mm: page table check") Signed-off-by: Pasha Tatashin --- mm/page_table_check.c | 60 ++++++++++++++++++++++++++----------------- 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a/mm/page_table_check.c b/mm/page_table_check.c index 7504e7caa2a1..877d967742bc 100644 --- a/mm/page_table_check.c +++ b/mm/page_table_check.c @@ -145,6 +145,30 @@ static void page_table_check_set(struct mm_struct *mm,= unsigned long addr, } } =20 +static void pte_clear_level(struct mm_struct *mm, unsigned long addr, + pte_t *ptep) +{ + unsigned long i; + + for (i =3D 0; i < PTRS_PER_PTE; i++) { + __page_table_check_pte_clear(mm, addr, *ptep); + addr +=3D PAGE_SIZE; + ptep++; + } +} + +static void pmd_clear_level(struct mm_struct *mm, unsigned long addr, + pmd_t *pmdp) +{ + unsigned long i; + + for (i =3D 0; i < PTRS_PER_PMD; i++) { + __page_table_check_pmd_clear(mm, addr, *pmdp); + addr +=3D PMD_PAGE_SIZE; + pmdp++; + } +} + /* * page is on free list, or is being allocated, verify that counters are z= eroes * crash if they are not. @@ -186,6 +210,11 @@ void __page_table_check_pmd_clear(struct mm_struct *mm= , unsigned long addr, if (pmd_user_accessible_page(pmd)) { page_table_check_clear(mm, addr, pmd_pfn(pmd), PMD_PAGE_SIZE >> PAGE_SHIFT); + } else if (!pmd_bad(pmd) && !pmd_leaf(pmd)) { + pte_t *ptep =3D pte_offset_map(&pmd, addr); + + pte_clear_level(mm, addr, ptep); + pte_unmap(ptep); } } EXPORT_SYMBOL(__page_table_check_pmd_clear); @@ -199,6 +228,10 @@ void __page_table_check_pud_clear(struct mm_struct *mm= , unsigned long addr, if (pud_user_accessible_page(pud)) { page_table_check_clear(mm, addr, pud_pfn(pud), PUD_PAGE_SIZE >> PAGE_SHIFT); + } else if (!pud_bad(pud) && !pud_leaf(pud)) { + pmd_t *pmdp =3D pmd_offset(&pud, addr); + + pmd_clear_level(mm, addr, pmdp); } } EXPORT_SYMBOL(__page_table_check_pud_clear); @@ -206,17 +239,10 @@ EXPORT_SYMBOL(__page_table_check_pud_clear); void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr, pte_t *ptep, pte_t pte) { - pte_t old_pte; - if (&init_mm =3D=3D mm) return; =20 - old_pte =3D *ptep; - if (pte_user_accessible_page(old_pte)) { - page_table_check_clear(mm, addr, pte_pfn(old_pte), - PAGE_SIZE >> PAGE_SHIFT); - } - + __page_table_check_pte_clear(mm, addr, *ptep); if (pte_user_accessible_page(pte)) { page_table_check_set(mm, addr, pte_pfn(pte), PAGE_SIZE >> PAGE_SHIFT, @@ -228,17 +254,10 @@ EXPORT_SYMBOL(__page_table_check_pte_set); void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr, pmd_t *pmdp, pmd_t pmd) { - pmd_t old_pmd; - if (&init_mm =3D=3D mm) return; =20 - old_pmd =3D *pmdp; - if (pmd_user_accessible_page(old_pmd)) { - page_table_check_clear(mm, addr, pmd_pfn(old_pmd), - PMD_PAGE_SIZE >> PAGE_SHIFT); - } - + __page_table_check_pmd_clear(mm, addr, *pmdp); if (pmd_user_accessible_page(pmd)) { page_table_check_set(mm, addr, pmd_pfn(pmd), PMD_PAGE_SIZE >> PAGE_SHIFT, @@ -250,17 +269,10 @@ EXPORT_SYMBOL(__page_table_check_pmd_set); void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr, pud_t *pudp, pud_t pud) { - pud_t old_pud; - if (&init_mm =3D=3D mm) return; =20 - old_pud =3D *pudp; - if (pud_user_accessible_page(old_pud)) { - page_table_check_clear(mm, addr, pud_pfn(old_pud), - PUD_PAGE_SIZE >> PAGE_SHIFT); - } - + __page_table_check_pud_clear(mm, addr, *pudp); if (pud_user_accessible_page(pud)) { page_table_check_set(mm, addr, pud_pfn(pud), PUD_PAGE_SIZE >> PAGE_SHIFT, --=20 2.34.1.703.g22d0c6ccf7-goog From nobody Tue Jun 30 09:25:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CACF0C433F5 for ; Thu, 20 Jan 2022 19:13:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377440AbiATTNB (ORCPT ); Thu, 20 Jan 2022 14:13:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377410AbiATTM5 (ORCPT ); Thu, 20 Jan 2022 14:12:57 -0500 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE16AC061574 for ; Thu, 20 Jan 2022 11:12:56 -0800 (PST) Received: by mail-qv1-xf2b.google.com with SMTP id o9so3795253qvy.13 for ; Thu, 20 Jan 2022 11:12:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=/lrhieXAQjpkgK4+rimVAixmRMROqE/GcACBpp2RziA=; b=DVbJt984cdsTf0nLyL0gU+CRPeI6csgRuWb0tYVjhrI1WKObUvjWiJH3vkiFqxeXv6 DGDPkwoRX5AKCXqVNns18Tl1MheshVE0QOVPsw+a5azPgWxiRQlnp8toELV+g+0koCpD EXmmlh0mVnvWi3Bd9TaiLKo1E++CJb2OBDNan93i7tO9ODFWsRVISd8blF1c+C7BZqOW AcM5kBPI9Zta1hy4wePoAnTjZ7kNNY6TJp538BwMkMc3Yl49am02dp6618Wso6ozgF4e 4+Ri0un9Nw1/L0A2LhfqJ+KCGA9Tr3cym3CSlFBCIMGmaGB091V2I7z7tPgcXu1I+DM2 3lzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/lrhieXAQjpkgK4+rimVAixmRMROqE/GcACBpp2RziA=; b=nHAiu123IKe+mkR4QoxPSaUr5L9cOz6fWOh5Bii7Cmi1ynrdmenrpb4z4u34uvtxEp BrsryLGISAVdMtCTZHq88JUgGltIz6XUL21nod2Hv7GrSyaTrbBfi/telnRgdb1qnJXO nO6SIbjqP63tRI0lUTaQBaZWnQ7Fjo633GlzypnqQQtswwuVHQ4U3yoL3xHy5L3cXnAc sqO9Nv/WDbErdGEKzMxsIG+JmbqtWc/rcjRoScZcZ1Ycdq4QL1KZiaQUqtipdKdBxPY1 ks9dxprjtzyLYbhvpEoZAki1e0zdzkAGVRC3lu14ahpDoQqoguuXMfREnGU1WFMYe+Ub RngA== X-Gm-Message-State: AOAM531pTsmh9AITRO6QuC6I2L3LO1GFXHv2+PhHV4RACRmC1V/lhBu+ qm0787hjvmQ+FA83Eh3b3geB8A== X-Google-Smtp-Source: ABdhPJzX9ogZQNd0p5asU4lyl7+h+DwhcECJON4g0QSGJOOD4M1nujIMQK+391N6XK1gOndyju7qjQ== X-Received: by 2002:a05:6214:2428:: with SMTP id gy8mr359142qvb.117.1642705975967; Thu, 20 Jan 2022 11:12:55 -0800 (PST) Received: from soleen.c.googlers.com.com (189.216.85.34.bc.googleusercontent.com. [34.85.216.189]) by smtp.gmail.com with ESMTPSA id w1sm1822509qko.40.2022.01.20.11.12.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jan 2022 11:12:55 -0800 (PST) From: Pasha Tatashin To: pasha.tatashin@soleen.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, rientjes@google.com, pjt@google.com, weixugc@google.com, gthelen@google.com, mingo@redhat.com, will@kernel.org, rppt@kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, aneesh.kumar@linux.ibm.com, jirislaby@kernel.org, songmuchun@bytedance.com, qydwhotmail@gmail.com, hughd@google.com, ziy@nvidia.com, anshuman.khandual@arm.com Subject: [PATCH v2 3/3] mm/page_table_check: use unsigned long for page counters Date: Thu, 20 Jan 2022 19:12:50 +0000 Message-Id: <20220120191250.2671557-4-pasha.tatashin@soleen.com> X-Mailer: git-send-email 2.34.1.703.g22d0c6ccf7-goog In-Reply-To: <20220120191250.2671557-1-pasha.tatashin@soleen.com> References: <20220120191250.2671557-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" For the consistency, use "unsigned long" for all page counters. Signed-off-by: Pasha Tatashin Reviewed-by: Wei Xu --- mm/page_table_check.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/page_table_check.c b/mm/page_table_check.c index 877d967742bc..f1db4de8bed2 100644 --- a/mm/page_table_check.c +++ b/mm/page_table_check.c @@ -86,8 +86,8 @@ static void page_table_check_clear(struct mm_struct *mm, = unsigned long addr, { struct page_ext *page_ext; struct page *page; + unsigned long i; bool anon; - int i; =20 if (!pfn_valid(pfn)) return; @@ -121,8 +121,8 @@ static void page_table_check_set(struct mm_struct *mm, = unsigned long addr, { struct page_ext *page_ext; struct page *page; + unsigned long i; bool anon; - int i; =20 if (!pfn_valid(pfn)) return; @@ -176,10 +176,10 @@ static void pmd_clear_level(struct mm_struct *mm, uns= igned long addr, void __page_table_check_zero(struct page *page, unsigned int order) { struct page_ext *page_ext =3D lookup_page_ext(page); - int i; + unsigned long i; =20 BUG_ON(!page_ext); - for (i =3D 0; i < (1 << order); i++) { + for (i =3D 0; i < (1ul << order); i++) { struct page_table_check *ptc =3D get_page_table_check(page_ext); =20 BUG_ON(atomic_read(&ptc->anon_map_count)); --=20 2.34.1.703.g22d0c6ccf7-goog