From nobody Tue Jun 30 12:08:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD8DC433EF for ; Mon, 17 Jan 2022 22:57:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243726AbiAQW5g (ORCPT ); Mon, 17 Jan 2022 17:57:36 -0500 Received: from mail.hugovil.com ([162.243.120.170]:47626 "EHLO mail.hugovil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243714AbiAQW5f (ORCPT ); Mon, 17 Jan 2022 17:57:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To :From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=lYvTF/25cdLyhwma94gJzi2/3ahZEKEEqHXKbvbNM4w=; b=h VtpwJKgX8UDKLEjdziaK3s6P64HJLzen0N33uEA+S7Ol4r9orx8ebOL5faCMwL1GP6VIfeb688j35 ledL7H/Pv8yZ+vmOLoFpiaQ0lngpiE0T24BXG5oWy2h4juDO42KZb8xZALWxTCbthl0oiYLOA4yNr kl1oBK02YIUnzX48=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:54812 helo=pettiford.lan) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1n9awN-0005lm-Fb; Mon, 17 Jan 2022 17:57:32 -0500 From: Hugo Villeneuve To: Alessandro Zummo , Alexandre Belloni Cc: hugo@hugovil.com, Hugo Villeneuve , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 17 Jan 2022 17:56:24 -0500 Message-Id: <20220117225625.1252233-1-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: [PATCH] rtc: pcf2127: add error checking and message when disabling POR0 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Hugo Villeneuve If PCF2127 device is absent from the I2C bus, or if there is a communication problem, disabling POR0 may fail silently and we still continue with probing the device. In that case, abort probe operation and display an error message. Signed-off-by: Hugo Villeneuve --- drivers/rtc/rtc-pcf2127.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c index 81a5b1f2e68c..e6d0838ccfe3 100644 --- a/drivers/rtc/rtc-pcf2127.c +++ b/drivers/rtc/rtc-pcf2127.c @@ -690,8 +690,12 @@ static int pcf2127_probe(struct device *dev, struct re= gmap *regmap, * The "Power-On Reset Override" facility prevents the RTC to do a reset * after power on. For normal operation the PORO must be disabled. */ - regmap_clear_bits(pcf2127->regmap, PCF2127_REG_CTRL1, + ret =3D regmap_clear_bits(pcf2127->regmap, PCF2127_REG_CTRL1, PCF2127_BIT_CTRL1_POR_OVRD); + if (ret < 0) { + dev_err(dev, "PORO disabling failed\n"); + return ret; + } =20 ret =3D regmap_read(pcf2127->regmap, PCF2127_REG_CLKOUT, &val); if (ret < 0) --=20 2.30.2