From nobody Tue Jun 30 13:05:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFC68C433F5 for ; Mon, 17 Jan 2022 05:45:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234370AbiAQFpm (ORCPT ); Mon, 17 Jan 2022 00:45:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234281AbiAQFpl (ORCPT ); Mon, 17 Jan 2022 00:45:41 -0500 Received: from mail-ua1-x931.google.com (mail-ua1-x931.google.com [IPv6:2607:f8b0:4864:20::931]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBA7CC061574 for ; Sun, 16 Jan 2022 21:45:41 -0800 (PST) Received: by mail-ua1-x931.google.com with SMTP id y4so28510219uad.1 for ; Sun, 16 Jan 2022 21:45:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Y0oUOdrqx+M8py6qBVJEFpjZfRB3lbu88LpKn+n4xFE=; b=pmZXDEv7iSwpJpTGyxqLIzk7jhq/Vi9ZB43sj1LMdQc/OU4J7XN83dD3YojAvNsoyI TqcN6zwobKvHNxTKi5vAH1nvfDoOc1pDbBL6o4gXtbwFSGMHlof6TK8vVWKmSTmjIkcd nvbK4SrS9LCmu4jGNOaGYMT9IeNt+YHGiULQY7ccclyruK3TcJwwAE0Xzn+1spjuEXM6 6OYTNEuggycMHr7X8BepSs7l6flHVfedcX0PIPdOdw4fLQ3tG+y5lVr2GFflpoSVhLTe dXLxmrv2wkeVq1su3cSyhLJtAv2ZOBo/tWJ7XThmUVmEt+uifLZ+rezqwPnP8viXmIKg I4Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=Y0oUOdrqx+M8py6qBVJEFpjZfRB3lbu88LpKn+n4xFE=; b=vpxxpkRuTDdl7EJkZDpNB2I7Cqy+0IMhTxIKapJrRcpiDSBuxra7R7bFkKMbjHD+TG NCgq+tiAfbOoFqMmFXvSsmpGdS6qOwA/hB9ieGPM9tjPSzGAjk+lkkO8AwW5Hag7eUCT m+SMngWQyv3jqFhR91Vs2P6PJWj2cihkC2rmQhX+dwq3dBGEcsyRoFn3Jqli0RpM3sda k2AU/m8PgmaGWWozjVJysuNpNpTGq6kNFUms0saJ3MBYHAwfcgUr0Mf0uBTQRyMeV/TS IljGT8cW1gG+PTIaonXx646ctHLGknZ5uNomW+a8DNv2T0EgbBed0GeckWSF1rj/Koc/ 0GlA== X-Gm-Message-State: AOAM533i2IA1Rtz3E5vlkKhC32PaXhopKBnHEMp8LBSdZkdYewkgHlRo BOvakptkqMcgFTuZ5z38W9kQmQj19ZfkfcJc X-Google-Smtp-Source: ABdhPJwawnuHrizaHjg8rkobDL8ONBEIo4JDdRDosuyLLDmKJanABd2iFWFhGJSt+PrgNZbWEO934A== X-Received: by 2002:a67:c00b:: with SMTP id v11mr7339828vsi.56.1642398340807; Sun, 16 Jan 2022 21:45:40 -0800 (PST) Received: from kubuntu-desktop.. ([67.8.38.84]) by smtp.gmail.com with ESMTPSA id 41sm3262976uag.18.2022.01.16.21.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jan 2022 21:45:40 -0800 (PST) Sender: Julian Braha From: Julian Braha To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, fazilyildiran@gmail.com Subject: [PATCH] ASoC: au1x: fix unmet dependency on SND_SOC_I2C_AND_SPI for SND_SOC_WM8731 Date: Mon, 17 Jan 2022 00:45:39 -0500 Message-Id: <20220117054539.81757-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" When SND_SOC_DB1200 is selected, and SND_SOC_I2C_AND_SPI is not selected, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for SND_SOC_WM8731 Depends on [n]: SOUND [=3Dy] && !UML && SND [=3Dy] && SND_SOC [=3Dy] && S= ND_SOC_I2C_AND_SPI [=3Dn] Selected by [y]: - SND_SOC_DB1200 [=3Dy] && SOUND [=3Dy] && !UML && SND [=3Dy] && SND_SOC = [=3Dy] && SND_SOC_AU1XPSC [=3Dy] This is because SND_SOC_DB1200 selects SND_SOC_WM8731 without selecting or depending on SND_SOC_I2C_AND_SPI, despite SND_SOC_WM8731 depending on SND_SOC_I2C_AND_SPI. This unmet dependency bug was detected by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution. Signed-off-by: Julian Braha --- sound/soc/au1x/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/au1x/Kconfig b/sound/soc/au1x/Kconfig index 38de7c0efbc7..3dccdfddbf9d 100644 --- a/sound/soc/au1x/Kconfig +++ b/sound/soc/au1x/Kconfig @@ -54,6 +54,7 @@ config SND_SOC_DB1000 config SND_SOC_DB1200 tristate "DB1200/DB1300/DB1550 Audio support" depends on SND_SOC_AU1XPSC + depends on SND_SOC_I2C_AND_SPI select SND_SOC_AU1XPSC_AC97 select SND_SOC_AC97_CODEC select SND_SOC_WM9712 --=20 2.32.0