From nobody Tue Jun 30 17:47:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A736EC433EF for ; Wed, 12 Jan 2022 19:12:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356961AbiALTMU (ORCPT ); Wed, 12 Jan 2022 14:12:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356630AbiALTLF (ORCPT ); Wed, 12 Jan 2022 14:11:05 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67136C03401F for ; Wed, 12 Jan 2022 11:10:55 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id c14-20020a17090a674e00b001b31e16749cso14173813pjm.4 for ; Wed, 12 Jan 2022 11:10:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BGP24qVZTEpaBQ1xv9moCmCJQ917JXiSUjVHHrmVp/E=; b=PVG7VTvqlLNGORnwYw9j1OMg3+3ZTPcoOj7kAksry9PLrHcTCLejULVii9l67Eb/Yb OyWS2q9EPoXcwoFq2f9ykMMa51KEQobaL9AdrHlljItrFlLb84qUPypxl7NeIFM2gYfP F73jNvzEHeYQkxbqSRA7deWpXLcHHVQuVGgD4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BGP24qVZTEpaBQ1xv9moCmCJQ917JXiSUjVHHrmVp/E=; b=QvT2Xgb3+pigixJzuMADcX3Rhx7JAAqhr7EbC8GK1011BHOmlRlrzJGjepSrR3d+3d RHzKMYhTrT1MSc3PCUFrQHRBSjFrkrzdZ6CHr53gqx4gLtQtGyWsGYBpiyYex94lXbUC rWsNCyIiItRSxH3ZX88Rrh/JJr9rSfJT6ys0bHRNXmxNLtUE43+8C7h7yn9Msu+7ueoy +fjdVsDvETpptrUvGYFJJ5tF0yoSejaQzibWVcxf6y9diPSFyaDLeDHpjeLiuPiF0zjX cM88vlCyy2YnoX58w4g6o+vQovltgk9mgZISaxXlwE9otpOfCQ31JJI28nsaqauB4W3V zlWg== X-Gm-Message-State: AOAM5308V3vXimhr0qYpkj9gNkwmNhfQKFcLbE60OQ7WRokL9OmvcFKT DzoJGo35UCa2Xq4U+8rgfRkTRg== X-Google-Smtp-Source: ABdhPJw0V7BAx/B4MLxvQ6u03zIBW4izudN2SvaqvG2oZbVic37IkfQmBRwmo4ewdqAYV59wyZCiPw== X-Received: by 2002:a63:a74d:: with SMTP id w13mr904351pgo.7.1642014654994; Wed, 12 Jan 2022 11:10:54 -0800 (PST) Received: from localhost ([2620:15c:202:201:f6eb:5b26:28c:1ca5]) by smtp.gmail.com with UTF8SMTPSA id n8sm356040pgh.94.2022.01.12.11.10.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 11:10:54 -0800 (PST) From: Matthias Kaehlcke To: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi Cc: Bastien Nocera , Krzysztof Kozlowski , Douglas Anderson , Peter Chen , Ravi Chandra Sadineni , linux-usb@vger.kernel.org, Roger Quadros , Michal Simek , linux-kernel@vger.kernel.org, Stephen Boyd , devicetree@vger.kernel.org, Matthias Kaehlcke , Rob Herring Subject: [PATCH v19 1/5] of/platform: Add stubs for of_platform_device_create/destroy() Date: Wed, 12 Jan 2022 11:10:44 -0800 Message-Id: <20220112111028.v19.1.I08fd2e1c775af04f663730e9fb4d00e6bbb38541@changeid> X-Mailer: git-send-email 2.34.1.575.g55b058a8bb-goog In-Reply-To: <20220112191048.837236-1-mka@chromium.org> References: <20220112191048.837236-1-mka@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Code for platform_device_create() and of_platform_device_destroy() is only generated if CONFIG_OF_ADDRESS=3Dy. Add stubs to avoid unresolved symbols when CONFIG_OF_ADDRESS is not set. Signed-off-by: Matthias Kaehlcke Acked-by: Rob Herring Reviewed-by: Douglas Anderson Reviewed-by: Stephen Boyd --- Changes in v19: - still no changes ... Changes in v18: - still no changes ... Changes in v17: - none Changes in v16: - none Changes in v15: - none Changes in v14: - none Changes in v13: - none Changes in v12: - none Changes in v11: - none Changes in v10: - none Changes in v9: - added Rob's 'Acked-by' tag Changes in v8: - fixed C&P error in commit message Changes in v7: - none Changes in v6: - patch added to the series include/linux/of_platform.h | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h index 84a966623e78..d15b6cd5e1c3 100644 --- a/include/linux/of_platform.h +++ b/include/linux/of_platform.h @@ -61,16 +61,18 @@ static inline struct platform_device *of_find_device_by= _node(struct device_node } #endif =20 +extern int of_platform_bus_probe(struct device_node *root, + const struct of_device_id *matches, + struct device *parent); + +#ifdef CONFIG_OF_ADDRESS /* Platform devices and busses creation */ extern struct platform_device *of_platform_device_create(struct device_nod= e *np, const char *bus_id, struct device *parent); =20 extern int of_platform_device_destroy(struct device *dev, void *data); -extern int of_platform_bus_probe(struct device_node *root, - const struct of_device_id *matches, - struct device *parent); -#ifdef CONFIG_OF_ADDRESS + extern int of_platform_populate(struct device_node *root, const struct of_device_id *matches, const struct of_dev_auxdata *lookup, @@ -84,6 +86,18 @@ extern int devm_of_platform_populate(struct device *dev); =20 extern void devm_of_platform_depopulate(struct device *dev); #else +/* Platform devices and busses creation */ +static inline struct platform_device *of_platform_device_create(struct dev= ice_node *np, + const char *bus_id, + struct device *parent) +{ + return NULL; +} +static inline int of_platform_device_destroy(struct device *dev, void *dat= a) +{ + return -ENODEV; +} + static inline int of_platform_populate(struct device_node *root, const struct of_device_id *matches, const struct of_dev_auxdata *lookup, --=20 2.34.1.575.g55b058a8bb-goog From nobody Tue Jun 30 17:47:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 507A7C433EF for ; Wed, 12 Jan 2022 19:12:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356908AbiALTME (ORCPT ); Wed, 12 Jan 2022 14:12:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356642AbiALTLG (ORCPT ); Wed, 12 Jan 2022 14:11:06 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5438FC033277 for ; Wed, 12 Jan 2022 11:10:57 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id hv15so7029376pjb.5 for ; Wed, 12 Jan 2022 11:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pKeAIKPGnBe5p4mKBOYRyjPyKIPYZXrfJeUjwODaD04=; b=O9xzxnEyN48+XuI6KdJAjnPm1qqgTtzP1kc0YLwuJejoGCDPV/ekTNYZ/Lo7B1X01m jIyns4PECcoO+KuOt93ZVQfVzz2TQ38CLaZBa/EAt/RzdMN4/QVe5Qxhapej9ohQ/vod cZRi0OKSOXuGRzsc1zuRfbw/f5496CPT7mZZM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pKeAIKPGnBe5p4mKBOYRyjPyKIPYZXrfJeUjwODaD04=; b=bPPeoNqs3qdJuhYXC3D8CX9lSvDPq+eg6OhPaUeLBwYwemW8PQFS1WucloFA9XcbV8 EZr9UnGA2x38icDjFYPikO7EpmLRAKHGv3Y7HpHpn+qy9/SAWjh1AmQH72kSdGNbUMEs kFuQnQVlli1fbbFr7/PwVwScRKfZ7oq3bdIfTcrU8VjhNtVrE6RMVSvFnIXBEbyDHgp1 sWVvNUJRS+B5mir1rsV4U2db69SrjmuV3tGPhS4cD8c2B2p3hGGNLtN9kjV4OhDsgxnl 7h6aptP0JhlS17q6ppF/kx4FszHR3IcTvcM/x0uM8tN3zfFLjzpXnDsu4KdgFALOqepd 1+Fw== X-Gm-Message-State: AOAM532QXM41NWStTzG+gmbdEMVjbnuFbG2bpw9ZH/IJcBLGzKqqL+ka 5xGU4NqMnGFtAZNEiHJLBO3xwQ== X-Google-Smtp-Source: ABdhPJwFVqMt/whp1hvarNmRUEpprD9igUYqty+P+1qtyx4QHrs7Sz6wMecsVhJczPLGXbJP2yPZWg== X-Received: by 2002:a17:90b:1d0b:: with SMTP id on11mr10638905pjb.114.1642014656908; Wed, 12 Jan 2022 11:10:56 -0800 (PST) Received: from localhost ([2620:15c:202:201:f6eb:5b26:28c:1ca5]) by smtp.gmail.com with UTF8SMTPSA id z3sm381030pgc.45.2022.01.12.11.10.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 11:10:56 -0800 (PST) From: Matthias Kaehlcke To: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi Cc: Bastien Nocera , Krzysztof Kozlowski , Douglas Anderson , Peter Chen , Ravi Chandra Sadineni , linux-usb@vger.kernel.org, Roger Quadros , Michal Simek , linux-kernel@vger.kernel.org, Stephen Boyd , devicetree@vger.kernel.org, Matthias Kaehlcke , "Rafael J. Wysocki" Subject: [PATCH v19 2/5] driver core: Export device_is_bound() Date: Wed, 12 Jan 2022 11:10:45 -0800 Message-Id: <20220112111028.v19.2.Ie1de382686d61909e17fa8def2b83899256e8f5d@changeid> X-Mailer: git-send-email 2.34.1.575.g55b058a8bb-goog In-Reply-To: <20220112191048.837236-1-mka@chromium.org> References: <20220112191048.837236-1-mka@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Export device_is_bound() to enable its use by drivers that are built as modules. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson Reviewed-by: Stephen Boyd --- Changes in v19: - none Changes in v18: - patch added to the series drivers/base/dd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 68ea1f949daa..07eefddd4a77 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -370,6 +370,7 @@ bool device_is_bound(struct device *dev) { return dev->p && klist_node_attached(&dev->p->knode_driver); } +EXPORT_SYMBOL_GPL(device_is_bound); =20 static void driver_bound(struct device *dev) { --=20 2.34.1.575.g55b058a8bb-goog From nobody Tue Jun 30 17:47:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E8E1C433F5 for ; Wed, 12 Jan 2022 19:11:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356707AbiALTLJ (ORCPT ); Wed, 12 Jan 2022 14:11:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356651AbiALTLG (ORCPT ); Wed, 12 Jan 2022 14:11:06 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B564C02C464 for ; Wed, 12 Jan 2022 11:10:59 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id n30-20020a17090a5aa100b001b2b6509685so6870874pji.3 for ; Wed, 12 Jan 2022 11:10:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eaPzMEcF/47qbGNeyAaG3YNPqvIboy0vM0ZPU44PbYU=; b=jePLfcd2mU6v8cMwJnLzzQOXQunxtPdRAZt03K59tefXRQRnBMvLHRHZMoS5GCUF6+ RxI2TeFY086DJ17orl9x0zQR0nvCcCLfduopcGYoQuLFhWKc13e1byhBmf7YUAiWTNee nFZ8ajJvNyt8CYQnhU+11wdmcuNi0UXjlG1l0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eaPzMEcF/47qbGNeyAaG3YNPqvIboy0vM0ZPU44PbYU=; b=dSR191YT/aXqNlUkzBOOSI+W0bEngzfkj+1Sn4xQxPdiirpiQSuLkkRle6Uz0k7W64 WJYVd9krtawdLpfGj4evsJrlz0DCK9ICt1RpCzp+LMj4ezPl7GHRMFpTq07gSY3ZSl1K cXN0F/7gnuLmNov3EUQP9M9Ugc1Cscib7IeS2iwIv47k2AMXajfuXOCe1d9Vd2wIKNZR b+xSInfvNwUrxKGT+2/nNjEfqIFQJ/qlONQn+ep7riyQ+Fc11h1CIsdQ22nnUITUM88F 1V/Jl/MWw9KnmgHnogVrADiYVYUENNdHgNB1lU1GD6NABYO/rzFtnptgREmSZF7guRAg KpVQ== X-Gm-Message-State: AOAM531oaVNG5Rr3So8FvKuUVDTEmOL02MamBC3U7F6tDcyDl/tW7e47 xa7rinszloUwCh9Yogp9K//HQA== X-Google-Smtp-Source: ABdhPJx3snghXGcYXpMys7otfoDHcCYfSNu5qqUW7+ic5sU/Q/GTdKaY1MLoxd53gyRfaBspV8smrQ== X-Received: by 2002:a17:90b:38c7:: with SMTP id nn7mr1081444pjb.135.1642014658533; Wed, 12 Jan 2022 11:10:58 -0800 (PST) Received: from localhost ([2620:15c:202:201:f6eb:5b26:28c:1ca5]) by smtp.gmail.com with UTF8SMTPSA id b5sm344088pfm.155.2022.01.12.11.10.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 11:10:58 -0800 (PST) From: Matthias Kaehlcke To: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi Cc: Bastien Nocera , Krzysztof Kozlowski , Douglas Anderson , Peter Chen , Ravi Chandra Sadineni , linux-usb@vger.kernel.org, Roger Quadros , Michal Simek , linux-kernel@vger.kernel.org, Stephen Boyd , devicetree@vger.kernel.org, Matthias Kaehlcke Subject: [PATCH v19 3/5] usb: misc: Add onboard_usb_hub driver Date: Wed, 12 Jan 2022 11:10:46 -0800 Message-Id: <20220112111028.v19.3.I7c9a1f1d6ced41dd8310e8a03da666a32364e790@changeid> X-Mailer: git-send-email 2.34.1.575.g55b058a8bb-goog In-Reply-To: <20220112191048.837236-1-mka@chromium.org> References: <20220112191048.837236-1-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The main issue this driver addresses is that a USB hub needs to be powered before it can be discovered. For discrete onboard hubs (an example for such a hub is the Realtek RTS5411) this is often solved by supplying the hub with an 'always-on' regulator, which is kind of a hack. Some onboard hubs may require further initialization steps, like changing the state of a GPIO or enabling a clock, which requires even more hacks. This driver creates a platform device representing the hub which performs the necessary initialization. Currently it only supports switching on a single regulator, support for multiple regulators or other actions can be added as needed. Different initialization sequences can be supported based on the compatible string. Besides performing the initialization the driver can be configured to power the hub off during system suspend. This can help to extend battery life on battery powered devices which have no requirements to keep the hub powered during suspend. The driver can also be configured to leave the hub powered when a wakeup capable USB device is connected when suspending, and power it off otherwise. Technically the driver consists of two drivers, the platform driver described above and a very thin USB driver that subclasses the generic driver. The purpose of this driver is to provide the platform driver with the USB devices corresponding to the hub(s) (a hub controller may provide multiple 'logical' hubs, e.g. one to support USB 2.0 and another for USB 3.x). Note: the current series only supports hubs connected directly to a root hub, support for other configurations could be added if needed. Co-developed-by: Ravi Chandra Sadineni Signed-off-by: Ravi Chandra Sadineni Signed-off-by: Matthias Kaehlcke Acked-by: Alan Stern Reviewed-by: Douglas Anderson --- Changes in v19: - added VID:PID pairs and compatible strings for RTS5414 hub - updated comments with RTS5411 USB versions to reflect those reported/supported by the hub Changes in v18: - introduced hidden Kconfig option to align module vs. builtin choice with CONFIG_USB (thanks Doug!) - refactored onboard_hub_create_pdevs() Changes in v17: - updated date and kernel version in ABI documentation for 'always_powered_in_suspend' attribute - removed obsolete .yaml entry from MAINTAINERS file - added entry for ABI documentation to MAINTAINERS file - renamed struct 'udev_node' to 'usbdev_node' - changed return logic in onboard_hub_suspend/resume() to get rid of 'rc' variable - added helper set_udev_link_name() to set link names for onboard hub USB devices - use of_parse_phandle() instead of of_property_read_u32() + of_find_node_by_phandle() combo - defer probing in _find_onboard_hub() if the platform device isn't bound yet - initialize list head passed as parameter to onboard_hub_create_pdevs() instead of relying on the caller to do so - don't require the 'companion-hub' property to be specified. This is needed to support hubs without companion hub - use devm_kzalloc() to allocate platform device list entries and stop freeing them explicitly - remove unnecessary INIT_LIST_HEAD() of platform device list entries - use '%pOF' to print DT node name - delete platform device list entries from the list of devices in onboard_hub_destroy_pdevs(). It shouldn't be strictly necessary, but better be on the safe side. Changes in v16: - none Changes in v15: - none Changes in v14: - none Changes in v13: - none Changes in v12: - use IS_ENABLED(CONFIG_USB_ONBOARD_HUB_MODULE) in onboard_hub.h to also check for the driver built as module - include onboard_hub.h again from the driver to make sure there are prototype declarations for the public functions - remove indentation from label in onboard_hub_create_pdevs() Changes in v11: - added onboard_hub_create/destroy_pdevs() helpers, to support multiple onb= oard hubs connected to the same parent hub - don't include =E2=80=98onboard_hub.h=E2=80=99 from the onboard hub driver - updated commit message - added =E2=80=98Acked-by' from Alan Changes in v10: - always use of_is_onboard_usb_hub() stub unless ONBOARD_USB_HUB=3Dy/m Changes in v9: - none Changes in v8: - none Changes in v7: - don't declare stub for of_is_onboard_usb_hub() when CONFIG_COMPILE_TEST is defined Changes in v6: - use 'companion-hub' to locate the platform device, instead of scanning through the nodes of the parent - added ABI documentation for 'always_powered_in_suspend' - sysfs_emit() instead of sprintf() in always_powered_in_suspend_show() - register sysfs attribute through driver.dev_groups - evaluate return value of driver_attach() in _probe() - use dev_warn() instead of WARN_ON() in _probe() - include 'onboard_hub.h' Changes in v5: - the platform device is now instantiated from the same DT node as the 'primary' USB hub device - use the USB compatible strings for the platform device - refactored _find_onboard_hub() to search the parents child nodes for a platform device with a matching compatible string - added exported function of_is_onboard_usb_hub() to allow other drivers (like xhci_plat) to check if one of their child DT nodes is a supported hub - use late suspend to make sure info about wakeup enabled descendants is updated - call driver_attach() for the USB driver in onboard_hub_probe() to make sure the driver is re-attached after the device_release_driver() calls in onboard_hub_remove() - renamed sysfs attribute 'power_off_in_suspend' to 'always_powered_in_suspend' - added sysfs symlinks between platform device and USB devices - marked 'onboard_hub_pm_ops' as __maybe_unused - removed 'realtek' compatible string which is not needed at this point - fix log for regulator_disable() failure Changes in v4: - updated Kconfig documentation - changed the loop in onboard_hub_remove() to release the hub lock before unbinding the USB device and make self deadlock prevention less clunky - fixed return value in onboard_hub_usbdev_probe() - added entry to MAINTAINERS file Changes in v3: - updated the commit message - updated description in Kconfig - remove include of 'core/usb.h' - use 'is_powered_on' flag instead of 'has_wakeup_capable_descendants' - added 'going_away' flag to struct onboard_hub - don't allow adding new USB devices when the platform device is going aw= ay - don't bother with deleting the list item in onboard_hub_remove_usbdev() when the platform device is going away - don't assume in onboard_hub_suspend() that all USB hub devices are connected to the same controller - removed unnecessary devm_kfree() from onboard_hub_remove_usbdev() - fixed error handling in onboard_hub_remove_usbdev() - use kstrtobool() instead of strtobool() in power_off_in_suspend_store() - unbind USB devices in onboard_hub_remove() to avoid dangling references to the platform device - moved put_device() for platform device to _find_onboard_hub() - changed return value of onboard_hub_remove_usbdev() to void - evaluate return value of onboard_hub_add_usbdev() - register 'power_off_in_suspend' as managed device attribute - use USB_DEVICE macro instead manual initialization - add unwinding to onboard_hub_init() - updated MODULE_DESCRIPTION - use module_init() instead of device_initcall() Changes in v2: - check wakeup enabled state of the USB controller instead of using 'wakeup-source' property - use sysfs attribute instead of DT property to determine if the hub should be powered off at all during system suspend - added missing brace in onboard_hub_suspend() - updated commit message - use pm_ptr for pm_ops as suggested by Alan Changes in v1: - renamed the driver to 'onboard_usb_hub' - single file for platform and USB driver - USB hub devices register with the platform device - the DT includes a phandle of the platform device - the platform device now controls when power is turned off - the USB driver became a very thin subclass of the generic USB driver - enabled autosuspend support .../sysfs-bus-platform-onboard-usb-hub | 8 + MAINTAINERS | 7 + drivers/usb/misc/Kconfig | 23 + drivers/usb/misc/Makefile | 1 + drivers/usb/misc/onboard_usb_hub.c | 494 ++++++++++++++++++ include/linux/usb/onboard_hub.h | 18 + 6 files changed, 551 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-bus-platform-onboard-us= b-hub create mode 100644 drivers/usb/misc/onboard_usb_hub.c create mode 100644 include/linux/usb/onboard_hub.h diff --git a/Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-hub b= /Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-hub new file mode 100644 index 000000000000..39fa2ed29fed --- /dev/null +++ b/Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-hub @@ -0,0 +1,8 @@ +What: /sys/bus/platform/devices//always_powered_in_suspend +Date: November 2021 +KernelVersion: 5.17 +Contact: Matthias Kaehlcke + linux-usb@vger.kernel.org +Description: + (RW) Controls whether the USB hub remains always powered + during system suspend or not. \ No newline at end of file diff --git a/MAINTAINERS b/MAINTAINERS index dd36acc87ce6..68bc6efaad3f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14183,6 +14183,13 @@ S: Maintained T: git git://linuxtv.org/media_tree.git F: drivers/media/i2c/ov9734.c =20 +ONBOARD USB HUB DRIVER +M: Matthias Kaehlcke +L: linux-usb@vger.kernel.org +S: Maintained +F: Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-hub +F: drivers/usb/misc/onboard_usb_hub.c + ONENAND FLASH DRIVER M: Kyungmin Park L: linux-mtd@lists.infradead.org diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig index 8f1144359012..bbced519499a 100644 --- a/drivers/usb/misc/Kconfig +++ b/drivers/usb/misc/Kconfig @@ -284,3 +284,26 @@ config BRCM_USB_PINMAP This option enables support for remapping some USB external signals, which are typically on dedicated pins on the chip, to any gpio. + +config USB_ONBOARD_HUB + bool "Onboard USB hub support" + depends on OF || COMPILE_TEST + help + Say Y here if you want to support discrete onboard USB hubs that + don't require an additional control bus for initialization, but + need some nontrivial form of initialization, such as enabling a + power regulator. An example for such a hub is the Realtek + RTS5411. + + This driver can be used as a module but its state (module vs + builtin) must match the state of the USB subsystem. Enabling + this config will enable the driver and it will automatically + match the state of the USB subsystem. If this driver is a + module it will be called onboard_usb_hub. + +if USB_ONBOARD_HUB +config USB_ONBOARD_HUB_ACTUAL + tristate + default m if USB=3Dm + default y if USB=3Dy +endif diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile index 5f4e598573ab..9549b88c2cc1 100644 --- a/drivers/usb/misc/Makefile +++ b/drivers/usb/misc/Makefile @@ -32,3 +32,4 @@ obj-$(CONFIG_USB_CHAOSKEY) +=3D chaoskey.o obj-$(CONFIG_USB_SISUSBVGA) +=3D sisusbvga/ obj-$(CONFIG_USB_LINK_LAYER_TEST) +=3D lvstest.o obj-$(CONFIG_BRCM_USB_PINMAP) +=3D brcmstb-usb-pinmap.o +obj-$(CONFIG_USB_ONBOARD_HUB_ACTUAL) +=3D onboard_usb_hub.o diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_= usb_hub.c new file mode 100644 index 000000000000..4e88e3089def --- /dev/null +++ b/drivers/usb/misc/onboard_usb_hub.c @@ -0,0 +1,494 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Driver for onboard USB hubs + * + * Copyright (c) 2020, Google LLC + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +static struct usb_device_driver onboard_hub_usbdev_driver; + +/************************** Platform driver **************************/ + +struct usbdev_node { + struct usb_device *udev; + struct list_head list; +}; + +struct onboard_hub { + struct regulator *vdd; + struct device *dev; + bool always_powered_in_suspend; + bool is_powered_on; + bool going_away; + struct list_head udev_list; + struct mutex lock; +}; + +static int onboard_hub_power_on(struct onboard_hub *hub) +{ + int err; + + err =3D regulator_enable(hub->vdd); + if (err) { + dev_err(hub->dev, "failed to enable regulator: %d\n", err); + return err; + } + + hub->is_powered_on =3D true; + + return 0; +} + +static int onboard_hub_power_off(struct onboard_hub *hub) +{ + int err; + + err =3D regulator_disable(hub->vdd); + if (err) { + dev_err(hub->dev, "failed to disable regulator: %d\n", err); + return err; + } + + hub->is_powered_on =3D false; + + return 0; +} + +static int __maybe_unused onboard_hub_suspend(struct device *dev) +{ + struct onboard_hub *hub =3D dev_get_drvdata(dev); + struct usbdev_node *node; + bool power_off; + + if (hub->always_powered_in_suspend) + return 0; + + power_off =3D true; + + mutex_lock(&hub->lock); + + list_for_each_entry(node, &hub->udev_list, list) { + if (!device_may_wakeup(node->udev->bus->controller)) + continue; + + if (usb_wakeup_enabled_descendants(node->udev)) { + power_off =3D false; + break; + } + } + + mutex_unlock(&hub->lock); + + if (!power_off) + return 0; + + return onboard_hub_power_off(hub); +} + +static int __maybe_unused onboard_hub_resume(struct device *dev) +{ + struct onboard_hub *hub =3D dev_get_drvdata(dev); + + if (hub->is_powered_on) + return 0; + + return onboard_hub_power_on(hub); +} + +static inline void set_udev_link_name(struct usb_device *udev, char *buf, = size_t size) +{ + snprintf(buf, size, "usb_dev.%s", dev_name(&udev->dev)); +} + +static int onboard_hub_add_usbdev(struct onboard_hub *hub, struct usb_devi= ce *udev) +{ + struct usbdev_node *node; + char link_name[64]; + int ret =3D 0; + + mutex_lock(&hub->lock); + + if (hub->going_away) { + ret =3D -EINVAL; + goto unlock; + } + + node =3D devm_kzalloc(hub->dev, sizeof(*node), GFP_KERNEL); + if (!node) { + ret =3D -ENOMEM; + goto unlock; + } + + node->udev =3D udev; + + list_add(&node->list, &hub->udev_list); + + set_udev_link_name(udev, link_name, sizeof(link_name)); + WARN_ON(sysfs_create_link(&hub->dev->kobj, &udev->dev.kobj, link_name)); + +unlock: + mutex_unlock(&hub->lock); + + return ret; +} + +static void onboard_hub_remove_usbdev(struct onboard_hub *hub, struct usb_= device *udev) +{ + struct usbdev_node *node; + char link_name[64]; + + set_udev_link_name(udev, link_name, sizeof(link_name)); + sysfs_remove_link(&hub->dev->kobj, link_name); + + mutex_lock(&hub->lock); + + list_for_each_entry(node, &hub->udev_list, list) { + if (node->udev =3D=3D udev) { + list_del(&node->list); + break; + } + } + + mutex_unlock(&hub->lock); +} + +static ssize_t always_powered_in_suspend_show(struct device *dev, struct d= evice_attribute *attr, + char *buf) +{ + struct onboard_hub *hub =3D dev_get_drvdata(dev); + + return sysfs_emit(buf, "%d\n", hub->always_powered_in_suspend); +} + +static ssize_t always_powered_in_suspend_store(struct device *dev, struct = device_attribute *attr, + const char *buf, size_t count) +{ + struct onboard_hub *hub =3D dev_get_drvdata(dev); + bool val; + int ret; + + ret =3D kstrtobool(buf, &val); + if (ret < 0) + return ret; + + hub->always_powered_in_suspend =3D val; + + return count; +} +static DEVICE_ATTR_RW(always_powered_in_suspend); + +static struct attribute *onboard_hub_attrs[] =3D { + &dev_attr_always_powered_in_suspend.attr, + NULL, +}; +ATTRIBUTE_GROUPS(onboard_hub); + +static int onboard_hub_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct onboard_hub *hub; + int err; + + hub =3D devm_kzalloc(dev, sizeof(*hub), GFP_KERNEL); + if (!hub) + return -ENOMEM; + + hub->vdd =3D devm_regulator_get(dev, "vdd"); + if (IS_ERR(hub->vdd)) + return PTR_ERR(hub->vdd); + + hub->dev =3D dev; + mutex_init(&hub->lock); + INIT_LIST_HEAD(&hub->udev_list); + + dev_set_drvdata(dev, hub); + + err =3D onboard_hub_power_on(hub); + if (err) + return err; + + /* + * The USB driver might have been detached from the USB devices by + * onboard_hub_remove(), make sure to re-attach it if needed. + */ + err =3D driver_attach(&onboard_hub_usbdev_driver.drvwrap.driver); + if (err) { + onboard_hub_power_off(hub); + return err; + } + + return 0; +} + +static int onboard_hub_remove(struct platform_device *pdev) +{ + struct onboard_hub *hub =3D dev_get_drvdata(&pdev->dev); + struct usbdev_node *node; + struct usb_device *udev; + + hub->going_away =3D true; + + mutex_lock(&hub->lock); + + /* unbind the USB devices to avoid dangling references to this device */ + while (!list_empty(&hub->udev_list)) { + node =3D list_first_entry(&hub->udev_list, struct usbdev_node, list); + udev =3D node->udev; + + /* + * Unbinding the driver will call onboard_hub_remove_usbdev(), + * which acquires hub->lock. We must release the lock first. + */ + get_device(&udev->dev); + mutex_unlock(&hub->lock); + device_release_driver(&udev->dev); + put_device(&udev->dev); + mutex_lock(&hub->lock); + } + + mutex_unlock(&hub->lock); + + return onboard_hub_power_off(hub); +} + +static const struct of_device_id onboard_hub_match[] =3D { + { .compatible =3D "usbbda,411" }, + { .compatible =3D "usbbda,5411" }, + { .compatible =3D "usbbda,414" }, + { .compatible =3D "usbbda,5414" }, + {} +}; +MODULE_DEVICE_TABLE(of, onboard_hub_match); + +static bool of_is_onboard_usb_hub(const struct device_node *np) +{ + return !!of_match_node(onboard_hub_match, np); +} + +static const struct dev_pm_ops __maybe_unused onboard_hub_pm_ops =3D { + SET_LATE_SYSTEM_SLEEP_PM_OPS(onboard_hub_suspend, onboard_hub_resume) +}; + +static struct platform_driver onboard_hub_driver =3D { + .probe =3D onboard_hub_probe, + .remove =3D onboard_hub_remove, + + .driver =3D { + .name =3D "onboard-usb-hub", + .of_match_table =3D onboard_hub_match, + .pm =3D pm_ptr(&onboard_hub_pm_ops), + .dev_groups =3D onboard_hub_groups, + }, +}; + +/************************** USB driver **************************/ + +#define VENDOR_ID_REALTEK 0x0bda + +/* + * Returns the onboard_hub platform device that is associated with the USB + * device passed as parameter. + */ +static struct onboard_hub *_find_onboard_hub(struct device *dev) +{ + struct platform_device *pdev; + struct device_node *np; + + pdev =3D of_find_device_by_node(dev->of_node); + if (!pdev) { + np =3D of_parse_phandle(dev->of_node, "companion-hub", 0); + if (!np) { + dev_err(dev, "failed to find device node for companion hub\n"); + return ERR_PTR(-EINVAL); + } + + pdev =3D of_find_device_by_node(np); + of_node_put(np); + + if (!pdev || !device_is_bound(&pdev->dev)) + return ERR_PTR(-EPROBE_DEFER); + } + + put_device(&pdev->dev); + + return dev_get_drvdata(&pdev->dev); +} + +static int onboard_hub_usbdev_probe(struct usb_device *udev) +{ + struct device *dev =3D &udev->dev; + struct onboard_hub *hub; + int err; + + /* ignore supported hubs without device tree node */ + if (!dev->of_node) + return -ENODEV; + + hub =3D _find_onboard_hub(dev); + if (IS_ERR(hub)) + return PTR_ERR(hub); + + dev_set_drvdata(dev, hub); + + err =3D onboard_hub_add_usbdev(hub, udev); + if (err) + return err; + + err =3D sysfs_create_link(&udev->dev.kobj, &hub->dev->kobj, "onboard_hub_= dev"); + if (err) + dev_warn(&udev->dev, "failed to create symlink to platform device: %d\n"= , err); + + return 0; +} + +static void onboard_hub_usbdev_disconnect(struct usb_device *udev) +{ + struct onboard_hub *hub =3D dev_get_drvdata(&udev->dev); + + sysfs_remove_link(&udev->dev.kobj, "onboard_hub_dev"); + + onboard_hub_remove_usbdev(hub, udev); +} + +static const struct usb_device_id onboard_hub_id_table[] =3D { + { USB_DEVICE(VENDOR_ID_REALTEK, 0x0411) }, /* RTS5411 USB 3.1 */ + { USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 */ + { USB_DEVICE(VENDOR_ID_REALTEK, 0x0414) }, /* RTS5414 USB 3.2 */ + { USB_DEVICE(VENDOR_ID_REALTEK, 0x5414) }, /* RTS5414 USB 2.1 */ + {}, +}; + +MODULE_DEVICE_TABLE(usb, onboard_hub_id_table); + +static struct usb_device_driver onboard_hub_usbdev_driver =3D { + .name =3D "onboard-usb-hub", + .probe =3D onboard_hub_usbdev_probe, + .disconnect =3D onboard_hub_usbdev_disconnect, + .generic_subclass =3D 1, + .supports_autosuspend =3D 1, + .id_table =3D onboard_hub_id_table, +}; + +/*** Helpers for creating/destroying platform devices for onboard hubs ***/ + +struct pdev_list_entry { + struct platform_device *pdev; + struct list_head node; +}; + +/* + * Creates a platform device for each supported onboard hub that is connec= ted to + * the given parent hub. To keep track of the platform devices they are ad= ded to + * a list that is owned by the parent hub. + */ +void onboard_hub_create_pdevs(struct usb_device *parent_hub, struct list_h= ead *pdev_list) +{ + int i; + struct device_node *np, *npc; + struct platform_device *pdev =3D NULL; + struct pdev_list_entry *pdle; + + INIT_LIST_HEAD(pdev_list); + + for (i =3D 1; i <=3D parent_hub->maxchild; i++) { + np =3D usb_of_get_device_node(parent_hub, i); + if (!np) + continue; + + if (!of_is_onboard_usb_hub(np)) + goto node_put; + + npc =3D of_parse_phandle(np, "companion-hub", 0); + if (npc) { + pdev =3D of_find_device_by_node(npc); + of_node_put(npc); + } + + if (pdev) { + /* the companion hub already has a platform device, nothing to do here = */ + put_device(&pdev->dev); + goto node_put; + } + + pdev =3D of_platform_device_create(np, NULL, &parent_hub->dev); + if (!pdev) { + dev_err(&parent_hub->dev, + "failed to create platform device for onboard hub '%pOF'\n", np); + goto node_put; + } + + pdle =3D devm_kzalloc(&pdev->dev, sizeof(*pdle), GFP_KERNEL); + if (!pdle) { + of_platform_device_destroy(&pdev->dev, NULL); + goto node_put; + } + + pdle->pdev =3D pdev; + list_add(&pdle->node, pdev_list); + +node_put: + of_node_put(np); + } +} +EXPORT_SYMBOL_GPL(onboard_hub_create_pdevs); + +/* + * Destroys the platform devices in the given list and frees the memory as= sociated + * with the list entry. + */ +void onboard_hub_destroy_pdevs(struct list_head *pdev_list) +{ + struct pdev_list_entry *pdle, *tmp; + + list_for_each_entry_safe(pdle, tmp, pdev_list, node) { + list_del(&pdle->node); + of_platform_device_destroy(&pdle->pdev->dev, NULL); + } +} +EXPORT_SYMBOL_GPL(onboard_hub_destroy_pdevs); + +/************************** Driver (de)registration **********************= ****/ + +static int __init onboard_hub_init(void) +{ + int ret; + + ret =3D platform_driver_register(&onboard_hub_driver); + if (ret) + return ret; + + ret =3D usb_register_device_driver(&onboard_hub_usbdev_driver, THIS_MODUL= E); + if (ret) + platform_driver_unregister(&onboard_hub_driver); + + return ret; +} +module_init(onboard_hub_init); + +static void __exit onboard_hub_exit(void) +{ + usb_deregister_device_driver(&onboard_hub_usbdev_driver); + platform_driver_unregister(&onboard_hub_driver); +} +module_exit(onboard_hub_exit); + +MODULE_AUTHOR("Matthias Kaehlcke "); +MODULE_DESCRIPTION("Driver for discrete onboard USB hubs"); +MODULE_LICENSE("GPL v2"); diff --git a/include/linux/usb/onboard_hub.h b/include/linux/usb/onboard_hu= b.h new file mode 100644 index 000000000000..d9373230556e --- /dev/null +++ b/include/linux/usb/onboard_hub.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef __LINUX_USB_ONBOARD_HUB_H +#define __LINUX_USB_ONBOARD_HUB_H + +struct usb_device; +struct list_head; + +#if IS_ENABLED(CONFIG_USB_ONBOARD_HUB) +void onboard_hub_create_pdevs(struct usb_device *parent_hub, struct list_h= ead *pdev_list); +void onboard_hub_destroy_pdevs(struct list_head *pdev_list); +#else +static inline void onboard_hub_create_pdevs(struct usb_device *parent_hub, + struct list_head *pdev_list) {} +static inline void onboard_hub_destroy_pdevs(struct list_head *pdev_list) = {} +#endif + +#endif /* __LINUX_USB_ONBOARD_HUB_H */ --=20 2.34.1.575.g55b058a8bb-goog From nobody Tue Jun 30 17:47:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D66C433F5 for ; Wed, 12 Jan 2022 19:11:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356772AbiALTLW (ORCPT ); Wed, 12 Jan 2022 14:11:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356660AbiALTLH (ORCPT ); Wed, 12 Jan 2022 14:11:07 -0500 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CED33C02982B for ; Wed, 12 Jan 2022 11:11:00 -0800 (PST) Received: by mail-pj1-x102e.google.com with SMTP id rj2-20020a17090b3e8200b001b1944bad25so6856859pjb.5 for ; Wed, 12 Jan 2022 11:11:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uQcGi+6PYdh2e7/00+1dBPTYZ2lf1jbIQG8r20v5neo=; b=l5Jjt2T+wxJNXK9pmrhHg4a/BvMUSohbgq7j9pUWWPa5qsSXKzbG+fkUHCu4Fkphma GPc/kqIseqCp1HF0owP2Z7IHY01ZLpWGAx/DMlgVRuXJLPMOe/CD22ufcdF/TuypjnHY GlIfs2i2Ue6tnIkNMEv91lfEqF+R7NZXb5VCk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uQcGi+6PYdh2e7/00+1dBPTYZ2lf1jbIQG8r20v5neo=; b=pIDB8QBvg8KI+6JmJgU42wkIGt7U9DFzuTWnjzeV+dEKZuqm3D9FT8KRRVp2MITxRy 5vHARmCxppybiMDSAX++7S8hWN6MKoiLIVoRdGxCUNfEyPRMHn+Sn6CO/FQqsNuq9dne 7DG1pUTBL5WCvxWC6ItsDFtaNoo8pcQTmhXEqEpFeLnNPrQKuU5WGXFY1m5lOZMEemg5 8gp8sI6XVj4RoODiyWeSIo+2pvD+J/35kTStyN4BDA4p2dd38n0XznT8a+XIHR4BLp44 hnWYyTm7a4dfP02i3yFzZ1U1Kp3p/4boc8so3esZy8pqsW/qy1XDb5L618ywCroaqqTj VT3g== X-Gm-Message-State: AOAM532Gg/soYWE2Z+aIdhISu3ZG4CtcOWGOmz4qKAaZ3Or+7CzEOL2u aXP3jNMwu2Sx0aAOwPV8wAPU6A== X-Google-Smtp-Source: ABdhPJxKIne1lEAJXsoSkOTRM2e0zyLGy6gyrmWxfV81wIYD1WSumFzvQ5DuGxS04S4eXSiE10eY1Q== X-Received: by 2002:a63:474b:: with SMTP id w11mr916429pgk.618.1642014660414; Wed, 12 Jan 2022 11:11:00 -0800 (PST) Received: from localhost ([2620:15c:202:201:f6eb:5b26:28c:1ca5]) by smtp.gmail.com with UTF8SMTPSA id d17sm344757pfl.125.2022.01.12.11.10.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 11:11:00 -0800 (PST) From: Matthias Kaehlcke To: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi Cc: Bastien Nocera , Krzysztof Kozlowski , Douglas Anderson , Peter Chen , Ravi Chandra Sadineni , linux-usb@vger.kernel.org, Roger Quadros , Michal Simek , linux-kernel@vger.kernel.org, Stephen Boyd , devicetree@vger.kernel.org, Matthias Kaehlcke , Kishon Vijay Abraham I , Li Jun , Peter Chen , Sasha Levin , Thinh Nguyen Subject: [PATCH v19 4/5] usb: core: hcd: Create platform devices for onboard hubs in probe() Date: Wed, 12 Jan 2022 11:10:47 -0800 Message-Id: <20220112111028.v19.4.I7a3a7d9d2126c34079b1cab87aa0b2ec3030f9b7@changeid> X-Mailer: git-send-email 2.34.1.575.g55b058a8bb-goog In-Reply-To: <20220112191048.837236-1-mka@chromium.org> References: <20220112191048.837236-1-mka@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Call onboard_hub_create/destroy_pdevs() from usb_add/remove_hcd() for primary HCDs to create/destroy platform devices for onboard USB hubs that may be connected to the root hub of the controller. These functions are a NOP unless CONFIG_USB_ONBOARD_HUB=3Dy/m. Also add a field to struct usb_hcd to keep track of the onboard hub platform devices that are owned by the HCD. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson Reviewed-by: Stephen Boyd --- Changes in v19: - none Changes in v18: - none Changes in v17: - create the platform devices in the generic HCD code instead of the xhci_platform driver - updated subject and commit message to reflect the above change - dropped initialization of platform device list, which is now done in onboard_hub_create_pdevs() Changes in v16: - none Changes in v15: - none Changes in v14: - none Changes in v13: - added comment for 'depends on USB_ONBOARD_HUB || !USB_ONBOARD_HUB' construct Changes in v12: - none Changes in v11: - use onboard_hub_create/destroy_pdevs() to support multiple onboard hubs that are connected to the same root hub - moved field/list to keep track of platform devices from struct usb_hcd to struct xhci_hcd - updated commit message Changes in v10: - none Changes in v9: - added dependency on USB_ONBOARD_HUB (or !!USB_ONBOARD_HUB) to USB_XHCI_PLATFORM Changes in v8: - none Changes in v7: - none Changes in v6: - none Changes in v5: - patch added to the series drivers/usb/core/hcd.c | 6 ++++++ include/linux/usb/hcd.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 4d326ee12c36..b8220e411e07 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -36,6 +36,7 @@ #include #include #include +#include #include =20 #include "usb.h" @@ -2963,6 +2964,9 @@ int usb_add_hcd(struct usb_hcd *hcd, if (hcd->uses_new_polling && HCD_POLL_RH(hcd)) usb_hcd_poll_rh_status(hcd); =20 + if (usb_hcd_is_primary_hcd(hcd)) + onboard_hub_create_pdevs(hcd->self.root_hub, &hcd->onboard_hub_devs); + return retval; =20 err_register_root_hub: @@ -3041,6 +3045,8 @@ void usb_remove_hcd(struct usb_hcd *hcd) if (usb_hcd_is_primary_hcd(hcd)) { if (hcd->irq > 0) free_irq(hcd->irq, hcd); + + onboard_hub_destroy_pdevs(&hcd->onboard_hub_devs); } =20 usb_deregister_bus(&hcd->self); diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h index 548a028f2dab..4ebc91c09182 100644 --- a/include/linux/usb/hcd.h +++ b/include/linux/usb/hcd.h @@ -198,6 +198,7 @@ struct usb_hcd { struct usb_hcd *shared_hcd; struct usb_hcd *primary_hcd; =20 + struct list_head onboard_hub_devs; =20 #define HCD_BUFFER_POOLS 4 struct dma_pool *pool[HCD_BUFFER_POOLS]; --=20 2.34.1.575.g55b058a8bb-goog From nobody Tue Jun 30 17:47:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20157C433F5 for ; Wed, 12 Jan 2022 19:11:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344430AbiALTLs (ORCPT ); Wed, 12 Jan 2022 14:11:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356671AbiALTLH (ORCPT ); Wed, 12 Jan 2022 14:11:07 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3BA0C02983E for ; Wed, 12 Jan 2022 11:11:02 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id oa15so7033911pjb.4 for ; Wed, 12 Jan 2022 11:11:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y+bvR63I7KR8sEFELGUNVYeIRATxm3eSr33Bl5gS1To=; b=EVWvBXjRy2Ry33Tx++6Y0hAcx7n28QD/RB9sLVZywtVrmEIMbCOzGVpBPQr3/bJJWo MV12P84YmLpW5dGpgelspP15QWyo1JVLbaoAyfjFQSxKB/21o6qP3weO2js7F9ewh4FG T5bgmtR8NuMdN51SKck9RqlA6WmZGBWZhFC9Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y+bvR63I7KR8sEFELGUNVYeIRATxm3eSr33Bl5gS1To=; b=NjlwcvvRh573U+1dtYvC6fceniBZgLQ+YobaGl6hKkXCddzqSF4w4t+aDaCiv3CeH1 o1ebiiCFEwZ9MRs5Y/gByM9i2xwrXg0y5wVCAIPP2YP06JN8Dq9fEm8/Gp1hJNDU/D0V aic6d8oyRYlCb0JsVygg2mB01/uaqAD1Ck0zAYbsps6J28M31JtBHnLH9vdh7A/Bjsi9 kvn9PfMYRf5Ep/vTEnnwJ54otRNnD5nw8WKuQRLL/7Vcx0/2gpEiRLC+NDT11EJurSnt WEcEsS1RgnIQO3aI9udrxTZqCgRupfC3IbiUoypJ7JZu9hRI78FbnXKcvG187n8jxacr 4etQ== X-Gm-Message-State: AOAM533BxUw05hHJg8NAn+oMfybftFmhr7hAiAkyePYIbGjPrS1Q5ZYq 2/BOmN6bXBQfEwrkIhA+vy8tEw== X-Google-Smtp-Source: ABdhPJwcgGe7fK+/F3zBdr7heZHFA4sXA1EN48Rg3VtNYOcxsstsz76aHYSt4unv2pfINRTH1fEKJA== X-Received: by 2002:a63:9b0a:: with SMTP id r10mr900079pgd.405.1642014662199; Wed, 12 Jan 2022 11:11:02 -0800 (PST) Received: from localhost ([2620:15c:202:201:f6eb:5b26:28c:1ca5]) by smtp.gmail.com with UTF8SMTPSA id s8sm325254pfu.190.2022.01.12.11.11.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 11:11:01 -0800 (PST) From: Matthias Kaehlcke To: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi Cc: Bastien Nocera , Krzysztof Kozlowski , Douglas Anderson , Peter Chen , Ravi Chandra Sadineni , linux-usb@vger.kernel.org, Roger Quadros , Michal Simek , linux-kernel@vger.kernel.org, Stephen Boyd , devicetree@vger.kernel.org, Matthias Kaehlcke , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org Subject: [PATCH v19 5/5] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub Date: Wed, 12 Jan 2022 11:10:48 -0800 Message-Id: <20220112111028.v19.5.Ie0d2c1214b767bb5551dd4cad38398bd40e4466f@changeid> X-Mailer: git-send-email 2.34.1.575.g55b058a8bb-goog In-Reply-To: <20220112191048.837236-1-mka@chromium.org> References: <20220112191048.837236-1-mka@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add nodes for the onboard USB hub on trogdor devices. Remove the 'always-on' property from the hub regulator, since the regulator is now managed by the onboard_usb_hub driver. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson Reviewed-by: Stephen Boyd --- Changes in v19: - none Changes in v18: - also adjust config for pompom rev1 Changes in v17: - none Changes in v16: - none Changes in v15: - none Changes in v14: - none Changes in v13: - none Changes in v12: - none Changes in v11: - rebased on qcom/arm64-for-5.14 (with the rest of the series) Changes in v10: - keep 'regulator-boot-on' property - updated commit message Changes in v9: - none Changes in v8: - none Changes in v7: - rebased on qcom/arm64-for-5.13 (with the rest of the series) Changes in v6: - added 'companion-hub' entry to both USB devices - added 'vdd-supply' also to hub@2 Changes in v5: - patch added to the series .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 19 ++++++++----------- .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 12 +++++------- .../dts/qcom/sc7180-trogdor-pompom-r1.dts | 11 ++++------- .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 19 ++++++++----------- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 19 ++++++++++++++++++- 5 files changed, 43 insertions(+), 37 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts b/arch/ar= m64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts index 30e3e769d2b4..5fb8e12af1a0 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts @@ -14,17 +14,6 @@ / { compatible =3D "google,lazor-rev0", "qcom,sc7180"; }; =20 -&pp3300_hub { - /* pp3300_l7c is used to power the USB hub */ - /delete-property/regulator-always-on; - /delete-property/regulator-boot-on; -}; - -&pp3300_l7c { - regulator-always-on; - regulator-boot-on; -}; - &sn65dsi86_out { /* * Lane 0 was incorrectly mapped on the cable, but we've now decided @@ -33,3 +22,11 @@ &sn65dsi86_out { */ lane-polarities =3D <1 0>; }; + +&usb_hub_2_0 { + vdd-supply =3D <&pp3300_l7c>; +}; + +&usb_hub_3_0 { + vdd-supply =3D <&pp3300_l7c>; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dts b/arch/ar= m64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dts index c2ef06367baf..1dae714250f5 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dts @@ -14,13 +14,11 @@ / { compatible =3D "google,lazor-rev1", "google,lazor-rev2", "qcom,sc7180"; }; =20 -&pp3300_hub { - /* pp3300_l7c is used to power the USB hub */ - /delete-property/regulator-always-on; - /delete-property/regulator-boot-on; + +&usb_hub_2_0 { + vdd-supply =3D <&pp3300_l7c>; }; =20 -&pp3300_l7c { - regulator-always-on; - regulator-boot-on; +&usb_hub_3_0 { + vdd-supply =3D <&pp3300_l7c>; }; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts b/arch/a= rm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts index 76a130bad60a..c913bb5677e5 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts @@ -34,13 +34,10 @@ &pm6150_adc_tm { /delete-node/ charger-thermistor@0; }; =20 -&pp3300_hub { - /* pp3300_l7c is used to power the USB hub */ - /delete-property/regulator-always-on; - /delete-property/regulator-boot-on; +&usb_hub_2_0 { + vdd-supply =3D <&pp3300_l7c>; }; =20 -&pp3300_l7c { - regulator-always-on; - regulator-boot-on; +&usb_hub_3_0 { + vdd-supply =3D <&pp3300_l7c>; }; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts b/arch/arm64/bo= ot/dts/qcom/sc7180-trogdor-r1.dts index 457c25499863..8477c82c410a 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts @@ -43,17 +43,6 @@ &panel { compatible =3D "auo,b116xa01"; }; =20 -&pp3300_hub { - /* pp3300_l7c is used to power the USB hub */ - /delete-property/regulator-always-on; - /delete-property/regulator-boot-on; -}; - -&pp3300_l7c { - regulator-always-on; - regulator-boot-on; -}; - &sdhc_2 { status =3D "okay"; }; @@ -62,6 +51,14 @@ &trackpad { interrupts =3D <58 IRQ_TYPE_EDGE_FALLING>; }; =20 +&usb_hub_2_0 { + vdd-supply =3D <&pp3300_l7c>; +}; + +&usb_hub_3_0 { + vdd-supply =3D <&pp3300_l7c>; +}; + /* PINCTRL - modifications to sc7180-trogdor.dtsi */ =20 &trackpad_int_1v8_odl { diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot= /dts/qcom/sc7180-trogdor.dtsi index d4f4441179fc..cd31460b3bd6 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -202,7 +202,6 @@ pp3300_hub: pp3300-hub { pinctrl-names =3D "default"; pinctrl-0 =3D <&en_pp3300_hub>; =20 - regulator-always-on; regulator-boot-on; =20 vin-supply =3D <&pp3300_a>; @@ -839,6 +838,24 @@ &usb_1 { =20 &usb_1_dwc3 { dr_mode =3D "host"; + #address-cells =3D <1>; + #size-cells =3D <0>; + + /* 2.0 hub on port 1 */ + usb_hub_2_0: hub@1 { + compatible =3D "usbbda,5411"; + reg =3D <1>; + vdd-supply =3D <&pp3300_hub>; + companion-hub =3D <&usb_hub_3_0>; + }; + + /* 3.0 hub on port 2 */ + usb_hub_3_0: hub@2 { + compatible =3D "usbbda,411"; + reg =3D <2>; + vdd-supply =3D <&pp3300_hub>; + companion-hub =3D <&usb_hub_2_0>; + }; }; =20 &usb_1_hsphy { --=20 2.34.1.575.g55b058a8bb-goog