From nobody Tue Jun 30 17:46:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 237ABC433EF for ; Wed, 12 Jan 2022 04:22:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350629AbiALEWN (ORCPT ); Tue, 11 Jan 2022 23:22:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350613AbiALEWJ (ORCPT ); Tue, 11 Jan 2022 23:22:09 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47325C06173F for ; Tue, 11 Jan 2022 20:22:09 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id 59-20020a17090a09c100b001b34a13745eso9359793pjo.5 for ; Tue, 11 Jan 2022 20:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kboHIb2qimmeziUoT1eD5XtRn5oDOkA2cacDUt27T1s=; b=F+xr3MeBBBwQ6Bn32wVfIBpyKp3OeuNBgl81G53UM3nhoPGi+bh45DIUWSnB+tJWZa kj5mksiXv41PBrSIvoSpHSgdP27M5/7RsUVCdBKGCt7DitiLtlcsO6ebNCPSxrAusHsM 86eYIY8Eu3YfbfpfTH7yWPD2bE+5viurSLAIE7A+yLKjH47U7F7sWo47ULefQEvgtJ9K lGbf2VDkdxRolr6itpieS7eX5vv7OoBOyHP71TPmh46StPVnUaIeTDoGl41NrWhbkP1M 50P5Tqa+sxsknLlifbnLnV34FtLqOaYfRBNH8zNWyD6AYoTwYbuuPQVTX/iK+UkmAqot 79UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kboHIb2qimmeziUoT1eD5XtRn5oDOkA2cacDUt27T1s=; b=ROdJMVOoNHbLsaTbt5HctviAgCkhzEvKOebTPU0vJnPo2+X20MizXsBr1+AQgc7z0u UIf022l8ii7mXDVHsLFeDSAyemYYQsYQVaKaH/FnCiCWpQ0JcjNHaLbJCAXoIN01qrpk VPTvpbnHvCEpOv3jAZZvu1mHpFOmUTLQ09hleCDr24Bt8Jja7xIigB/CsxQ+oflGWIRn QWajncdHO7S9tphmpQiLt0Lw/2cR8ffvzZAGBn3J+zeC1flDa20sq5dpu1VMdIrlYvJV usBrRllWAwkutIQCIYLLVWok17Cit29MJAssD/qdGf5JN8+kLymyk85Xtv3HM9DiK/V0 lQPg== X-Gm-Message-State: AOAM530eK7vnEfxURgYzHkcnpHdSyRsVdRBa/veE+NBU/ieFbKoQiR7A KthyykeX7XzyyITmr+86eCM= X-Google-Smtp-Source: ABdhPJzVGvNhr1ihwiJVs3pL1YYkNtBu1Z5wvKSit5bZKeiMwVRvn8UYqCjK9P9ApU23ZF8F1B2NLA== X-Received: by 2002:a17:90a:8b81:: with SMTP id z1mr6817104pjn.83.1641961328550; Tue, 11 Jan 2022 20:22:08 -0800 (PST) Received: from localhost.localdomain ([115.99.137.58]) by smtp.gmail.com with ESMTPSA id t207sm11237747pfc.205.2022.01.11.20.22.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 20:22:08 -0800 (PST) From: Jagath Jog J To: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com, marcocesati@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, jagathjog1996@gmail.com Subject: [PATCH 1/4] Staging: rtl8723bs: Placing opening { braces in previous line Date: Wed, 12 Jan 2022 09:51:58 +0530 Message-Id: <20220112042201.5056-2-jagathjog1996@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220112042201.5056-1-jagathjog1996@gmail.com> References: <20220112042201.5056-1-jagathjog1996@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fix following checkpatch.pl error by placing opening { braces in previous line ERROR: that open brace { should be on the previous line Signed-off-by: Jagath Jog J --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 40 ++++++------------- 1 file changed, 13 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 5157b5b12597..81b548ad4e30 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -113,13 +113,10 @@ static struct ieee80211_supported_band *rtw_spt_band_= alloc( struct ieee80211_supported_band *spt_band =3D NULL; int n_channels, n_bitrates; =20 - if (band =3D=3D NL80211_BAND_2GHZ) - { + if (band =3D=3D NL80211_BAND_2GHZ) { n_channels =3D RTW_2G_CHANNELS_NUM; n_bitrates =3D RTW_G_RATES_NUM; - } - else - { + } else { goto exit; } =20 @@ -135,8 +132,7 @@ static struct ieee80211_supported_band *rtw_spt_band_al= loc( spt_band->n_channels =3D n_channels; spt_band->n_bitrates =3D n_bitrates; =20 - if (band =3D=3D NL80211_BAND_2GHZ) - { + if (band =3D=3D NL80211_BAND_2GHZ) { rtw_2g_channels_init(spt_band->channels); rtw_2g_rates_init(spt_band->bitrates); } @@ -235,8 +231,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl { u16 wapi_len =3D 0; =20 - if (rtw_get_wapi_ie(pnetwork->network.ies, pnetwork->network.ie_length, = NULL, &wapi_len) > 0) - { + if (rtw_get_wapi_ie(pnetwork->network.ies, pnetwork->network.ie_length, = NULL, &wapi_len) > 0) { if (wapi_len > 0) goto exit; } @@ -244,8 +239,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl =20 /* To reduce PBC Overlap rate */ /* spin_lock_bh(&pwdev_priv->scan_req_lock); */ - if (adapter_wdev_data(padapter)->scan_request) - { + if (adapter_wdev_data(padapter)->scan_request) { u8 *psr =3D NULL, sr =3D 0; struct ndis_802_11_ssid *pssid =3D &pnetwork->network.ssid; struct cfg80211_scan_request *request =3D adapter_wdev_data(padapter)->s= can_request; @@ -258,14 +252,12 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct a= dapter *padapter, struct wl if (wpsie && wpsielen > 0) psr =3D rtw_get_wps_attr_content(wpsie, wpsielen, WPS_ATTR_SELECTED_RE= GISTRAR, (u8 *)(&sr), NULL); =20 - if (sr !=3D 0) - { - if (request->n_ssids =3D=3D 1 && request->n_channels =3D=3D 1) /* it m= eans under processing WPS */ - { + if (sr !=3D 0) { + /* it means under processing WPS */ + if (request->n_ssids =3D=3D 1 && request->n_channels =3D=3D 1) { if (ssids[0].ssid_len !=3D 0 && (pssid->ssid_length !=3D ssids[0].ssid_len || - memcmp(pssid->ssid, ssids[0].ssid, ssids[0].ssid_len))) - { + memcmp(pssid->ssid, ssids[0].ssid, ssids[0].ssid_len))) { if (psr) *psr =3D 0; /* clear sr */ } @@ -374,8 +366,7 @@ void rtw_cfg80211_ibss_indicate_connect(struct adapter = *padapter) int freq =3D (int)cur_network->network.configuration.ds_config; struct ieee80211_channel *chan; =20 - if (pwdev->iftype !=3D NL80211_IFTYPE_ADHOC) - { + if (pwdev->iftype !=3D NL80211_IFTYPE_ADHOC) { return; } =20 @@ -383,14 +374,11 @@ void rtw_cfg80211_ibss_indicate_connect(struct adapte= r *padapter) struct wlan_bssid_ex *pnetwork =3D &(padapter->mlmeextpriv.mlmext_info.= network); struct wlan_network *scanned =3D pmlmepriv->cur_network_scanned; =20 - if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) - { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) { =20 memcpy(&cur_network->network, pnetwork, sizeof(struct wlan_bssid_ex)); rtw_cfg80211_inform_bss(padapter, cur_network); - } - else - { + } else { if (!scanned) { rtw_warn_on(1); return; @@ -473,9 +461,7 @@ void rtw_cfg80211_indicate_connect(struct adapter *pada= pter) roam_info.resp_ie_len =3D pmlmepriv->assoc_rsp_len-sizeof(struct ieee80211_hdr_3addr)-6; cfg80211_roamed(padapter->pnetdev, &roam_info, GFP_ATOMIC); - } - else - { + } else { cfg80211_connect_result(padapter->pnetdev, cur_network->network.mac_addr= ess , pmlmepriv->assoc_req+sizeof(struct ieee80211_hdr_3addr)+2 , pmlmepriv->assoc_req_len-sizeof(struct ieee80211_hdr_3addr)-2 --=20 2.17.1 From nobody Tue Jun 30 17:46:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45414C433F5 for ; Wed, 12 Jan 2022 04:22:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350665AbiALEWO (ORCPT ); Tue, 11 Jan 2022 23:22:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350617AbiALEWL (ORCPT ); Tue, 11 Jan 2022 23:22:11 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49D42C06173F for ; Tue, 11 Jan 2022 20:22:11 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id hv15so2428237pjb.5 for ; Tue, 11 Jan 2022 20:22:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=o7osdo2BrmjDyjcS9PkvYkntr2CZq4Fce8zzeRAMN9w=; b=MJRkHySPt6R9biKhtWIETa/mGGma9zDhgdKwaT3b2KtzBOoHr89RLeRwj914ky+cLZ gPJ2xB5zpFBs65WuPawhtY2f4wweQRDrfu7YiarMdj0n9gk8EhMc5gukRpdomHgEFmfs T+4j4KsnUXWKIeAQukVuPH+gM+Y3s10tFmz5QS/1aejjJsB1bpAhf+CiGtwY5COF3ZoB 4wwJ/WDtSnyzgRDxKzhtCzwcVx20BHmjryPeNhjOakrEIutXqM7t9cOrMzGJ0VAx3+E4 ZF8K/zJsBy1/7Uq0JU2sZZ6MswnmQJO3l/yBfOe/HUmW5gvnmscB71vnoT4DaEq994/q is5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=o7osdo2BrmjDyjcS9PkvYkntr2CZq4Fce8zzeRAMN9w=; b=pXq7kG+3gbnCq3viOHo/K8HrtfBiHFj9gvMQzFOsLewfknb2kpxS0cdHF6tULBrEnH +JKUhoTNwihwXobaKArtEoungns3iTrL4jFJG+ewRinirAIR8P/8vXdnj3REjBiLeoSs yO5JxzFHmRVk+J2rZEgYKjKEZ9Dy3RCSp0g6+8Lef3i/GwP19VQ/+XIr0jZ4J220rlUA 880/bpyzF5mnYb+rO4y/0hX3YC0KGAdkhJvpbeDD0CXsirRqe7GRg1cQ2oR1C77UpuXo AOmEEtbbpSB5Xz+tEPu/ekiOv00K2iWMqHZNxrlonVxQ44h3aBglWQy8Kun/UYCLC6oq Hegw== X-Gm-Message-State: AOAM5310DvdBSitbDTp1c6dFedkFbdSIM+oBchDPAH9IyuYJdbaDd5ij 5kQeZN4F5pwGdqxfKd0of1PxJIYBZDcxsg== X-Google-Smtp-Source: ABdhPJxwgjM4wHLTKFa51oNax5zFELQWraXlDGN1SnqWlEvcRwhlxE0SSqLjxv5NWGsVtrk5UP4haQ== X-Received: by 2002:a63:5007:: with SMTP id e7mr6729952pgb.295.1641961330772; Tue, 11 Jan 2022 20:22:10 -0800 (PST) Received: from localhost.localdomain ([115.99.137.58]) by smtp.gmail.com with ESMTPSA id t207sm11237747pfc.205.2022.01.11.20.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 20:22:10 -0800 (PST) From: Jagath Jog J To: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com, marcocesati@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, jagathjog1996@gmail.com Subject: [PATCH 2/4] Staging: rtl8723bs: Interchanging comparison expression operands Date: Wed, 12 Jan 2022 09:51:59 +0530 Message-Id: <20220112042201.5056-3-jagathjog1996@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220112042201.5056-1-jagathjog1996@gmail.com> References: <20220112042201.5056-1-jagathjog1996@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fix following checkpatch.pl warning by placing constant on rignt side of comparison WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: Jagath Jog J --- drivers/staging/rtl8723bs/core/rtw_security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/stagin= g/rtl8723bs/core/rtw_security.c index ac731415f733..fcecee824797 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -1554,7 +1554,7 @@ void rtw_sec_restore_wep_key(struct adapter *adapter) struct security_priv *securitypriv =3D &(adapter->securitypriv); signed int keyid; =20 - if ((_WEP40_ =3D=3D securitypriv->dot11PrivacyAlgrthm) || (_WEP104_ =3D= =3D securitypriv->dot11PrivacyAlgrthm)) { + if ((securitypriv->dot11PrivacyAlgrthm =3D=3D _WEP40_) || (securitypriv->= dot11PrivacyAlgrthm =3D=3D _WEP104_)) { for (keyid =3D 0; keyid < 4; keyid++) { if (securitypriv->key_mask & BIT(keyid)) { if (keyid =3D=3D securitypriv->dot11PrivacyKeyIndex) --=20 2.17.1 From nobody Tue Jun 30 17:46:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6733BC433F5 for ; Wed, 12 Jan 2022 04:22:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350719AbiALEWU (ORCPT ); Tue, 11 Jan 2022 23:22:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350644AbiALEWN (ORCPT ); Tue, 11 Jan 2022 23:22:13 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FCCAC061748 for ; Tue, 11 Jan 2022 20:22:13 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id c14-20020a17090a674e00b001b31e16749cso9385577pjm.4 for ; Tue, 11 Jan 2022 20:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=k1CvHCi8TZtIaZG3Bq0qS6ZhlctMk+7qABS/i6xkMSo=; b=fX30lOZ4FMJYr8CjAkgql92CW01yJo51P/NyvoW2q3Otmx1d7TgGIIOGCMAUfEUONo fi6mrvtSxZ2Dj1CK+4ZtvPW6Ose0K0hMp4yfJ943LAUbRuHxLXI1dNf8wbhh/UQi/nIR EE/U3JeY5lpy1uX+peOLmLa4K0ift8XklH4ZfGVrFj58X4e2wFamWtRk0QVL5OGMammm GJ9dYwrRa1j2tu3fAZfNjmjSWNiQL/icAFH5CqWtihKBqY7TkMNV0NOIN9weNX/C59M0 QJnOgztUcDdUxNPcXBfoOBgEzJizRGoalUDYQwYTPJ2pNZ/vt00WcEwNKAn48Cts4nNI s9Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=k1CvHCi8TZtIaZG3Bq0qS6ZhlctMk+7qABS/i6xkMSo=; b=J/AQXeJHczl2MXEoFwSW5lP1myWQC1a9kPKXddxBGMXyHomIsA6e5AyZfalIe5fuhh Rl/y+8/8KM+kUeQRakWPaJk/16LgsZzoKYmHSsGq9nBlYozscjat4soOOkG0AF5GYjqy hmgd7Dx4sevSpZIuE3ajGN7XG4SWGCELngeKj6bYZvp7H92GZ69qNfZa0O/Tnbd451y1 sMTGoyfz4ggXQNu+Aho6I+RoQRAcZzLXXwmWHmhI0uKtRiDZjZe54VonnqsKLfJFIWaQ FSnLAwv2wuAs+95o/5X74M6mKjnvWEMPyIsds4PSu42VbqT89/3vnvCcaDGeXnloNwD7 SHNQ== X-Gm-Message-State: AOAM533CzDadDegDlbU3tiQuNYQZBzPJXO1suO97OYYhgnshkFeN/f+f Zx4UbaZw8eOvanFb6V7Prvs= X-Google-Smtp-Source: ABdhPJzq+/s/gE+BaV/JcOeqHlDltMnS5dSpSDKYFDU7LPdDSGbuHCJQTK3LG6ayx3bqlh5+s45ZaA== X-Received: by 2002:a05:6a00:198a:b0:4bb:4621:f074 with SMTP id d10-20020a056a00198a00b004bb4621f074mr7649925pfl.69.1641961332980; Tue, 11 Jan 2022 20:22:12 -0800 (PST) Received: from localhost.localdomain ([115.99.137.58]) by smtp.gmail.com with ESMTPSA id t207sm11237747pfc.205.2022.01.11.20.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 20:22:12 -0800 (PST) From: Jagath Jog J To: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com, marcocesati@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, jagathjog1996@gmail.com Subject: [PATCH 3/4] Staging: rtl8723bs: Removed extra spaces between datatype and variable Date: Wed, 12 Jan 2022 09:52:00 +0530 Message-Id: <20220112042201.5056-4-jagathjog1996@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220112042201.5056-1-jagathjog1996@gmail.com> References: <20220112042201.5056-1-jagathjog1996@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fix following checkpatch.pl warning by placing single space between datatype and variable WARNING: please, no space before tabs Signed-off-by: Jagath Jog J --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 42 +++++++++++------------- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index b28351a97cd3..79294e25c3f4 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -531,9 +531,9 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct= ndis_802_11_ssid *ssid, struct rtw_ieee80211_channel *ch, int ch_num) { u8 res =3D _FAIL; - struct cmd_obj *ph2c; - struct sitesurvey_parm *psurveyPara; - struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; + struct cmd_obj *ph2c; + struct sitesurvey_parm *psurveyPara; + struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 if (check_fwstate(pmlmepriv, _FW_LINKED)) @@ -632,8 +632,8 @@ void rtw_getbbrfreg_cmdrsp_callback(struct adapter *pad= apter, struct cmd_obj *p u8 rtw_createbss_cmd(struct adapter *padapter) { struct cmd_obj *pcmd; - struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; - struct wlan_bssid_ex *pdev_network =3D &padapter->registrypriv.dev_netwo= rk; + struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; + struct wlan_bssid_ex *pdev_network =3D &padapter->registrypriv.dev_networ= k; u8 res =3D _SUCCESS; =20 pcmd =3D rtw_zmalloc(sizeof(struct cmd_obj)); @@ -707,14 +707,14 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct = wlan_network *pnetwork) { u8 res =3D _SUCCESS; uint t_len =3D 0; - struct wlan_bssid_ex *psecnetwork; - struct cmd_obj *pcmd; - struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; - struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - struct qos_priv *pqospriv =3D &pmlmepriv->qospriv; + struct wlan_bssid_ex *psecnetwork; + struct cmd_obj *pcmd; + struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; + struct qos_priv *pqospriv =3D &pmlmepriv->qospriv; struct security_priv *psecuritypriv =3D &padapter->securitypriv; struct registry_priv *pregistrypriv =3D &padapter->registrypriv; - struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; + struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; enum ndis_802_11_network_infrastructure ndis_network_mode =3D pnetwork->n= etwork.infrastructure_mode; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; @@ -897,12 +897,11 @@ u8 rtw_setopmode_cmd(struct adapter *padapter, enum = ndis_802_11_network_infrast u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 un= icast_key, bool enqueue) { struct cmd_obj *ph2c; - struct set_stakey_parm *psetstakey_para; - struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; - struct set_stakey_rsp *psetstakey_rsp =3D NULL; - - struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - struct security_priv *psecuritypriv =3D &padapter->securitypriv; + struct set_stakey_parm *psetstakey_para; + struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; + struct set_stakey_rsp *psetstakey_rsp =3D NULL; + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; + struct security_priv *psecuritypriv =3D &padapter->securitypriv; u8 res =3D _SUCCESS; =20 psetstakey_para =3D rtw_zmalloc(sizeof(struct set_stakey_parm)); @@ -957,9 +956,9 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct s= ta_info *sta, u8 unicast_ u8 rtw_clearstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 = enqueue) { struct cmd_obj *ph2c; - struct set_stakey_parm *psetstakey_para; - struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; - struct set_stakey_rsp *psetstakey_rsp =3D NULL; + struct set_stakey_parm *psetstakey_para; + struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; + struct set_stakey_rsp *psetstakey_rsp =3D NULL; s16 cam_id =3D 0; u8 res =3D _SUCCESS; =20 @@ -1228,8 +1227,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, = u8 from_timer) u16 BusyThreshold =3D BusyThresholdHigh; u8 bBusyTraffic =3D false, bTxBusyTraffic =3D false, bRxBusyTraffic =3D f= alse; u8 bHigherBusyTraffic =3D false, bHigherBusyRxTraffic =3D false, bHigherB= usyTxTraffic =3D false; - - struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 collect_traffic_statistics(padapter); =20 --=20 2.17.1 From nobody Tue Jun 30 17:46:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A36BC433EF for ; Wed, 12 Jan 2022 04:22:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350667AbiALEWW (ORCPT ); Tue, 11 Jan 2022 23:22:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350662AbiALEWQ (ORCPT ); Tue, 11 Jan 2022 23:22:16 -0500 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD405C06173F for ; Tue, 11 Jan 2022 20:22:15 -0800 (PST) Received: by mail-pl1-x62a.google.com with SMTP id l15so2263512pls.7 for ; Tue, 11 Jan 2022 20:22:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2R7ZVHCw02Rsd6KEYUhmsx7al3DqDAEUHEngmsp8FkQ=; b=dnxIrVKdQ6h2JdYrWAjfTleVVECs28kpUbTiUcf0mNwpjSUzOyPKjUdmx0JI9i9lQR O9jzMhAz05DwGdXbPQq4zhCOWo/1TN+DfDnoaB0ybjhjxiAsPcYGXi52q4whryQc//Sw Zlr9gI20VM0EgdUtab4vePrTV6qNdjCI7jQRK1jnSvGjKwDVb/0vTjc3lY+ayCbmfFMo RFGNwS63jDa/C9uAptISdrcbl0va30U/tY8/Xclz0G5sQBru1hhrzN2d58Zq4oWZPw7c rhd8Iq1QcJBITPJ6LNW7Znm2Dyaq52mq6qdi6aPQtx4r8oKxRD0KqyV6EwMHSzInXZ3p Eg5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2R7ZVHCw02Rsd6KEYUhmsx7al3DqDAEUHEngmsp8FkQ=; b=eHD0RjsS/pXWOiYkhRjFi+a7t5C/zBAr0Gr81Uma8AbTs+k6ITLxJMAVu8HBiWl/2Y FhoEUI5KUDZhbUBKgDCv0UvG3J4CLzT2Hzy2kKGwnB30UkpoD6d5EuR0APo61hSwFf5Y PcrGlkbIzYsbz22ZeBnSEswva0cSN59ZmJymLR3F9zMqKoNIVIkaFXeEFswBo4C2QwaM CV6RCDvq1Jw8NKB6jjjn+xvQvn4BjcYOPOYub0kXHnV6E0AvU/kpO8JYKmKEi1Rz9i/2 mK3DH6l/Z1vVuNYCdfnDlVuBJnfud1cvuy+pKQehWjUiQGPvmJzUQ3DD366wBrv//TEH V6DA== X-Gm-Message-State: AOAM532iny10bPBn+dk0zKIAUzCSt+C8rzg4pgTCYtidLY4+7Rs815vq /SlJ5Yqc1HGwtzD99zWGUNY= X-Google-Smtp-Source: ABdhPJwH04RiAnN/vpjJy/C7SUy9+Vt8ZIlRoKWHoHEUBCj0SXUouBS2IRJIOCWZ4bA4kXpR9eRK9A== X-Received: by 2002:a17:903:10c:b0:14a:3d99:d883 with SMTP id y12-20020a170903010c00b0014a3d99d883mr7797461plc.75.1641961335190; Tue, 11 Jan 2022 20:22:15 -0800 (PST) Received: from localhost.localdomain ([115.99.137.58]) by smtp.gmail.com with ESMTPSA id t207sm11237747pfc.205.2022.01.11.20.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 20:22:14 -0800 (PST) From: Jagath Jog J To: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com, marcocesati@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, jagathjog1996@gmail.com Subject: [PATCH 4/4] Staging: rtl8723bs: Inserting blank line after declaration Date: Wed, 12 Jan 2022 09:52:01 +0530 Message-Id: <20220112042201.5056-5-jagathjog1996@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220112042201.5056-1-jagathjog1996@gmail.com> References: <20220112042201.5056-1-jagathjog1996@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fix following checkpatch.pl warning by inserting blank line and removing unwanted spaces WARNING: Missing a blank line after declarations Signed-off-by: Jagath Jog J --- drivers/staging/rtl8723bs/hal/hal_intf.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index 4868a69cdb8f..02c720d49b53 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -181,13 +181,14 @@ void rtw_hal_disable_interrupt(struct adapter *padapt= er) u8 rtw_hal_check_ips_status(struct adapter *padapter) { u8 val =3D false; + if (padapter->HalFunc.check_ips_status) val =3D padapter->HalFunc.check_ips_status(padapter); =20 return val; } =20 -s32 rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame = *pxmitframe) +s32 rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame = *pxmitframe) { if (padapter->HalFunc.hal_xmitframe_enqueue) return padapter->HalFunc.hal_xmitframe_enqueue(padapter, pxmitframe); @@ -195,7 +196,7 @@ s32 rtw_hal_xmitframe_enqueue(struct adapter *padapter,= struct xmit_frame *pxmit return false; } =20 -s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe) +s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe) { if (padapter->HalFunc.hal_xmit) return padapter->HalFunc.hal_xmit(padapter, pxmitframe); @@ -206,9 +207,10 @@ s32 rtw_hal_xmit(struct adapter *padapter, struct xmit= _frame *pxmitframe) /* * [IMPORTANT] This function would be run in interrupt context. */ -s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntfr= ame) +s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntfr= ame) { s32 ret =3D _FAIL; + update_mgntframe_attrib_addr(padapter, pmgntframe); /* pframe =3D (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET; */ /* pwlanhdr =3D (struct rtw_ieee80211_hdr *)pframe; */ @@ -230,7 +232,7 @@ s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct = xmit_frame *pmgntframe) return ret; } =20 -s32 rtw_hal_init_xmit_priv(struct adapter *padapter) +s32 rtw_hal_init_xmit_priv(struct adapter *padapter) { if (padapter->HalFunc.init_xmit_priv) return padapter->HalFunc.init_xmit_priv(padapter); @@ -243,7 +245,7 @@ void rtw_hal_free_xmit_priv(struct adapter *padapter) padapter->HalFunc.free_xmit_priv(padapter); } =20 -s32 rtw_hal_init_recv_priv(struct adapter *padapter) +s32 rtw_hal_init_recv_priv(struct adapter *padapter) { if (padapter->HalFunc.init_recv_priv) return padapter->HalFunc.init_recv_priv(padapter); @@ -299,6 +301,7 @@ void rtw_hal_stop_thread(struct adapter *padapter) u32 rtw_hal_read_bbreg(struct adapter *padapter, u32 RegAddr, u32 BitMask) { u32 data =3D 0; + if (padapter->HalFunc.read_bbreg) data =3D padapter->HalFunc.read_bbreg(padapter, RegAddr, BitMask); return data; @@ -312,6 +315,7 @@ void rtw_hal_write_bbreg(struct adapter *padapter, u32 = RegAddr, u32 BitMask, u32 u32 rtw_hal_read_rfreg(struct adapter *padapter, u32 eRFPath, u32 RegAddr,= u32 BitMask) { u32 data =3D 0; + if (padapter->HalFunc.read_rfreg) data =3D padapter->HalFunc.read_rfreg(padapter, eRFPath, RegAddr, BitMas= k); return data; @@ -385,6 +389,7 @@ bool rtw_hal_c2h_valid(struct adapter *adapter, u8 *buf) s32 rtw_hal_c2h_handler(struct adapter *adapter, u8 *c2h_evt) { s32 ret =3D _FAIL; + if (adapter->HalFunc.c2h_handler) ret =3D adapter->HalFunc.c2h_handler(adapter, c2h_evt); return ret; --=20 2.17.1